1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/ash_element_identifiers.h"
#include "ash/style/switch.h"
#include "chrome/test/base/ash/interactive/hotspot/hotspot_state_observer.h"
#include "chrome/test/base/ash/interactive/interactive_ash_test.h"
#include "chrome/test/base/ash/interactive/network/shill_service_util.h"
#include "chrome/test/base/ash/interactive/settings/interactive_uitest_elements.h"
#include "chromeos/ash/components/dbus/session_manager/session_manager_client.h"
#include "chromeos/ash/components/dbus/shill/shill_manager_client.h"
#include "chromeos/ash/components/dbus/shill/shill_service_client.h"
#include "third_party/cros_system_api/dbus/shill/dbus-constants.h"
#include "ui/base/interaction/element_identifier.h"
namespace ash {
namespace {
// This string should match the prefix of
// IDS_SETTINGS_INTERNET_HOTSPOT_NO_MOBILE_DATA_SUBLABEL_WITH_LEARN_MORE_LINK
// without the "Learn more" link.
constexpr char kNoMobileDataLink[] = "Connect to mobile data to use hotspot.";
// This string should match the prefix of
// IDS_SETTINGS_INTERNET_HOTSPOT_MOBILE_DATA_NOT_SUPPORTED_SUBLABEL_WITH_LEARN_MORE_LINK
// without the "Learn more" link.
constexpr char kMobileDataNotSupportedLink[] =
"Your mobile data may not support hotspot.";
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kOSSettingsId);
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(HotspotStateObserver, kHotspotStateService);
class ToggleHotspotInteractiveUITest : public InteractiveAshTest {
protected:
// InteractiveAshTest:
void SetUpOnMainThread() override {
InteractiveAshTest::SetUpOnMainThread();
// Set up context for element tracking for InteractiveBrowserTest.
SetupContextWidget();
// Ensure the OS Settings app is installed.
InstallSystemApps();
}
void AddCellularService() {
ShillServiceClient::Get()->GetTestInterface()->AddService(
shill_service_info_.service_path(), shill_service_info_.service_guid(),
shill_service_info_.service_name(), shill::kTypeCellular,
shill::kStateOnline, /*visible=*/true);
}
void SetTetheringReadinessCheckSuccessResult(const std::string& result) {
ShillManagerClient::Get()
->GetTestInterface()
->SetSimulateCheckTetheringReadinessResult(
FakeShillSimulatedResult::kSuccess, result);
}
void SimulateHotspotUsedBefore() {
ShillManagerClient::Get()->GetTestInterface()->SetManagerProperty(
shill::kTetheringStatusProperty,
base::Value(
base::Value::Dict().Set(shill::kTetheringStatusStateProperty,
shill::kTetheringStateActive)));
base::RunLoop().RunUntilIdle();
// Set the hotspot state back to idle.
ShillManagerClient::Get()->GetTestInterface()->SetManagerProperty(
shill::kTetheringStatusProperty,
base::Value(base::Value::Dict().Set(
shill::kTetheringStatusStateProperty, shill::kTetheringStateIdle)));
base::RunLoop().RunUntilIdle();
SetTetheringReadinessCheckSuccessResult(shill::kTetheringReadinessReady);
}
// Shill updates the tethering state to Idle if no clients are connected
// within 5 minutes. We are simulating that scenario here by skipping the
// 5 minute timer and setting the status property to Idle.
ui::test::internal::InteractiveTestPrivate::MultiStep
SimulateHotspotTimeout() {
return Steps(Do([&]() {
ShillManagerClient::Get()->GetTestInterface()->SetManagerProperty(
shill::kTetheringStatusProperty,
base::Value(base::Value::Dict()
.Set(shill::kTetheringStatusStateProperty,
shill::kTetheringStateIdle)
.Set(shill::kTetheringStatusIdleReasonProperty,
shill::kTetheringIdleReasonInactive)));
base::RunLoop().RunUntilIdle();
}));
}
void LockScreen() { SessionManagerClient::Get()->RequestLockScreen(); }
private:
const ShillServiceInfo shill_service_info_ =
ShillServiceInfo(/*id=*/0, shill::kTypeCellular);
};
IN_PROC_BROWSER_TEST_F(ToggleHotspotInteractiveUITest,
HotspotToggleDisabledWhenNoCellularConnection) {
ui::ElementContext context =
LaunchSystemWebApp(SystemWebAppType::SETTINGS, kOSSettingsId);
// Run the following steps with the OS Settings context set as the default.
RunTestSequenceInContext(
context,
Log("Navigating to the internet page"),
NavigateSettingsToInternetPage(kOSSettingsId),
Log("Waiting for hotspot summary item and toggle to exist and disabled"),
WaitForElementExists(kOSSettingsId,
settings::hotspot::HotspotSummaryItem()),
WaitForElementDisabled(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Waiting for localized link appeared"),
WaitForElementTextContains(
kOSSettingsId, settings::hotspot::HotspotSummarySubtitleLink(),
/*text=*/kNoMobileDataLink),
Log("Test complete"));
}
IN_PROC_BROWSER_TEST_F(ToggleHotspotInteractiveUITest,
HotspotToggleDisabledWhenCarrierNotSupported) {
SetTetheringReadinessCheckSuccessResult(shill::kTetheringReadinessNotAllowed);
AddCellularService();
ui::ElementContext context =
LaunchSystemWebApp(SystemWebAppType::SETTINGS, kOSSettingsId);
// Run the following steps with the OS Settings context set as the default.
RunTestSequenceInContext(
context,
Log("Navigating to the internet page"),
NavigateSettingsToInternetPage(kOSSettingsId),
Log("Waiting for hotspot summary item and toggle to exist and disabled"),
WaitForElementExists(kOSSettingsId,
settings::hotspot::HotspotSummaryItem()),
WaitForElementDisabled(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Waiting for localized link appeared"),
WaitForElementTextContains(
kOSSettingsId, settings::hotspot::HotspotSummarySubtitleLink(),
/*text=*/kMobileDataNotSupportedLink),
Log("Test complete"));
}
IN_PROC_BROWSER_TEST_F(ToggleHotspotInteractiveUITest,
ToggleHotspotFromSettingsAndQuickSettings) {
SetTetheringReadinessCheckSuccessResult(shill::kTetheringReadinessReady);
AddCellularService();
ShillManagerClient::Get()
->GetTestInterface()
->SetSimulateTetheringEnableResult(FakeShillSimulatedResult::kSuccess,
shill::kTetheringEnableResultSuccess);
using Observer =
views::test::PollingViewPropertyObserver<bool, views::ToggleButton>;
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(Observer, kPollingViewPropertyState);
RunTestSequence(
Log("Open quick settings and make sure hotspot does not show"),
OpenQuickSettings(),
WaitForHide(ash::kHotspotFeatureTileDrillInArrowElementId));
ui::ElementContext context =
LaunchSystemWebApp(SystemWebAppType::SETTINGS, kOSSettingsId);
// Run the following steps with the OS Settings context set as the default.
RunTestSequenceInContext(
context,
Log("Navigating to the internet page"),
NavigateSettingsToInternetPage(kOSSettingsId),
Log("Waiting for hotspot summary item and toggle to exist and enabled"),
WaitForElementExists(kOSSettingsId,
settings::hotspot::HotspotSummaryItem()),
WaitForElementEnabled(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Make sure hotspot is initially disabled"),
ObserveState(kHotspotStateService,
std::make_unique<HotspotStateObserver>()),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
false),
Log("Waiting for hotspot toggle to be enabled then click it"),
ClickElement(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Wait for the hotspot state to be enabled"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kEnabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
true),
Log("Click on toggle to disable it"),
ClickElement(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Wait for the hotspot state to be disabled"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
false),
Log("Turn on and off hotspot in OS Settings complete"));
RunTestSequence(
Log("Open quick settings and navigate to hotspot page"),
OpenQuickSettings(), NavigateQuickSettingsToHotspotPage(),
PollViewProperty(kPollingViewPropertyState,
ash::kHotspotDetailedViewToggleElementId,
&views::ToggleButton::GetIsOn),
WaitForState(kPollingViewPropertyState, false),
Log("Click on the toggle to turn on hotspot from Quick Settings"),
MoveMouseTo(ash::kHotspotDetailedViewToggleElementId), ClickMouse(),
Log("Hotspot is turned on from Quick Settings"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kEnabled),
WaitForState(kPollingViewPropertyState, true),
Log("Click on the toggle to turn off hotspot from Quick Settings"),
MoveMouseTo(ash::kHotspotDetailedViewToggleElementId), ClickMouse(),
Log("Hotspot is turned off from Quick Settings"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForState(kPollingViewPropertyState, false),
Log("Turn on and off hotspot from Quick Settings complete"));
}
IN_PROC_BROWSER_TEST_F(ToggleHotspotInteractiveUITest, AbortEnablingHotspot) {
ui::ElementContext context =
LaunchSystemWebApp(SystemWebAppType::SETTINGS, kOSSettingsId);
SetTetheringReadinessCheckSuccessResult(shill::kTetheringReadinessReady);
AddCellularService();
// By setting the enable result to Busy, we are simulating the situation where
// the enable operation is stuck.
ShillManagerClient::Get()
->GetTestInterface()
->SetSimulateTetheringEnableResult(FakeShillSimulatedResult::kInProgress,
shill::kTetheringEnableResultBusy);
// Run the following steps with the OS Settings context set as the default.
RunTestSequenceInContext(
context,
Log("Navigating to the internet page"),
NavigateSettingsToInternetPage(kOSSettingsId),
Log("Waiting for hotspot summary item and toggle to exist and enabled"),
WaitForElementExists(kOSSettingsId,
settings::hotspot::HotspotSummaryItem()),
WaitForElementEnabled(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Make sure hotspot is initially disabled"),
ObserveState(kHotspotStateService,
std::make_unique<HotspotStateObserver>()),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
false),
Log("Click the hotspot toggle then wait for it to be enabled"),
ClickElement(kOSSettingsId, settings::hotspot::HotspotToggle()),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
true),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kEnabling),
Log("Simulating enable result to success to successfully abort "
"ongoing operations"),
Do([&]() {
ShillManagerClient::Get()
->GetTestInterface()
->SetSimulateTetheringEnableResult(
FakeShillSimulatedResult::kSuccess,
shill::kTetheringEnableResultSuccess);
}),
Log("Abort the enable operation by clicking on the toggle button"),
ClickElement(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Wait for the hotspot state to be disabled"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
false),
Log("Test complete"));
}
IN_PROC_BROWSER_TEST_F(ToggleHotspotInteractiveUITest, AutoDisableHotspot) {
SetTetheringReadinessCheckSuccessResult(shill::kTetheringReadinessReady);
AddCellularService();
ShillManagerClient::Get()
->GetTestInterface()
->SetSimulateTetheringEnableResult(FakeShillSimulatedResult::kSuccess,
shill::kTetheringEnableResultSuccess);
ui::ElementContext context =
LaunchSystemWebApp(SystemWebAppType::SETTINGS, kOSSettingsId);
// Run the following steps with the OS Settings context set as the default.
RunTestSequenceInContext(
context,
Log("Navigating to the internet page"),
NavigateSettingsToInternetPage(kOSSettingsId),
Log("Waiting for hotspot summary item and toggle to exist and enabled"),
WaitForElementExists(kOSSettingsId,
settings::hotspot::HotspotSummaryItem()),
WaitForElementEnabled(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Make sure hotspot is initially disabled"),
ObserveState(kHotspotStateService,
std::make_unique<HotspotStateObserver>()),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
false),
Log("Waiting for hotspot toggle to be enabled then click it"),
ClickElement(kOSSettingsId, settings::hotspot::HotspotToggle()),
Log("Wait for the hotspot state to be enabled"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kEnabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
true),
Log("Setting tethering state to idle in Shill to simulate auto disable "
"scenario"),
SimulateHotspotTimeout(),
Log("Waiting for the hotspot auto-disable notification to be shown"),
WaitForShow(kCellularHotspotAutoDisableNotificationElementId),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForToggleState(kOSSettingsId, settings::hotspot::HotspotToggle(),
false),
Log("Test complete"));
}
IN_PROC_BROWSER_TEST_F(ToggleHotspotInteractiveUITest,
ToggleHotspotFromLockScreen) {
LockScreen();
SimulateHotspotUsedBefore();
AddCellularService();
ShillManagerClient::Get()
->GetTestInterface()
->SetSimulateTetheringEnableResult(FakeShillSimulatedResult::kSuccess,
shill::kTetheringEnableResultSuccess);
using Observer =
views::test::PollingViewPropertyObserver<bool, views::ToggleButton>;
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(Observer, kPollingViewPropertyState);
RunTestSequence(
Log("Open quick settings and navigate to hotspot page"),
OpenQuickSettings(), NavigateQuickSettingsToHotspotPage(),
PollViewProperty(kPollingViewPropertyState,
ash::kHotspotDetailedViewToggleElementId,
&views::ToggleButton::GetIsOn),
WaitForState(kPollingViewPropertyState, false),
Log("Click on the toggle to turn on hotspot from Quick Settings"),
MoveMouseTo(ash::kHotspotDetailedViewToggleElementId), ClickMouse(),
Log("Hotspot is turned on from Quick Settings"),
ObserveState(kHotspotStateService,
std::make_unique<HotspotStateObserver>()),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kEnabled),
WaitForState(kPollingViewPropertyState, true),
Log("Click on the toggle to turn off hotspot from Quick Settings"),
MoveMouseTo(ash::kHotspotDetailedViewToggleElementId), ClickMouse(),
Log("Hotspot is turned off from Quick Settings"),
WaitForState(kHotspotStateService,
hotspot_config::mojom::HotspotState::kDisabled),
WaitForState(kPollingViewPropertyState, false),
Log("Turn on and off hotspot from Quick Settings complete"));
}
} // namespace
} // namespace ash
|
