1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chromeos/ash/components/network/network_connect.h"
#include <memory>
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/task_environment.h"
#include "base/values.h"
#include "chromeos/ash/components/dbus/shill/shill_device_client.h"
#include "chromeos/ash/components/dbus/shill/shill_service_client.h"
#include "chromeos/ash/components/login/login_state/login_state.h"
#include "chromeos/ash/components/network/network_connection_handler.h"
#include "chromeos/ash/components/network/network_handler.h"
#include "chromeos/ash/components/network/network_handler_test_helper.h"
#include "chromeos/ash/components/network/network_state.h"
#include "chromeos/ash/components/network/network_state_handler.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
using testing::_;
using testing::AnyNumber;
using testing::NiceMock;
using testing::Return;
namespace ash {
namespace {
const char kWiFi1ServicePath[] = "/service/wifi1";
const char kWiFi1Guid[] = "wifi1_guid";
const char kWiFiUnconfiguredServicePath[] = "/service/wifi_unconfigured";
const char kWiFiUnconfiguredGuid[] = "wifi_unconfigured_guid";
const char kCellular1DevicePath[] = "/device/stub_cellular_device1";
const char kCellular1ServicePath[] = "/service/cellular1";
const char kCellular1Guid[] = "cellular1_guid";
const char kTetherGuid[] = "tether_guid";
class MockDelegate : public NetworkConnect::Delegate {
public:
MockDelegate() = default;
~MockDelegate() override = default;
MOCK_METHOD1(ShowNetworkConfigure, void(const std::string& network_id));
MOCK_METHOD1(ShowNetworkSettings, void(const std::string& network_id));
MOCK_METHOD1(ShowEnrollNetwork, bool(const std::string& network_id));
MOCK_METHOD1(ShowMobileSetupDialog, void(const std::string& network_id));
MOCK_METHOD1(ShowCarrierAccountDetail, void(const std::string& network_id));
MOCK_METHOD2(ShowPortalSignin,
void(const std::string& network_id,
NetworkConnect::Source source));
MOCK_METHOD2(ShowNetworkConnectError,
void(const std::string& error_name,
const std::string& network_id));
MOCK_METHOD1(ShowMobileActivationError, void(const std::string& network_id));
MOCK_METHOD0(ShowCarrierUnlockNotification, void());
};
class FakeTetherDelegate : public NetworkConnectionHandler::TetherDelegate {
public:
FakeTetherDelegate() = default;
~FakeTetherDelegate() override = default;
std::string last_connected_tether_network_guid() {
return last_connected_tether_network_guid_;
}
// NetworkConnectionHandler::TetherDelegate:
void ConnectToNetwork(const std::string& tether_network_guid,
base::OnceClosure success_callback,
StringErrorCallback error_callback) override {
if (should_connect_to_network_id_succeed_) {
last_connected_tether_network_guid_ = tether_network_guid;
std::move(success_callback).Run();
} else {
std::move(error_callback)
.Run(NetworkConnectionHandler::kErrorConnectFailed);
}
}
void DisconnectFromNetwork(const std::string& tether_network_guid,
base::OnceClosure success_callback,
StringErrorCallback error_callback) override {}
void ShouldConnectToNetworkIdSucceed(bool success) {
should_connect_to_network_id_succeed_ = success;
}
private:
std::string last_connected_tether_network_guid_;
bool should_connect_to_network_id_succeed_ = true;
};
} // namespace
class NetworkConnectTest : public testing::Test {
public:
NetworkConnectTest() = default;
NetworkConnectTest(const NetworkConnectTest&) = delete;
NetworkConnectTest& operator=(const NetworkConnectTest&) = delete;
~NetworkConnectTest() override = default;
void SetUp() override {
testing::Test::SetUp();
LoginState::Initialize();
SetupDefaultShillState();
base::RunLoop().RunUntilIdle();
mock_delegate_ = std::make_unique<MockDelegate>();
ON_CALL(*mock_delegate_, ShowEnrollNetwork(_)).WillByDefault(Return(true));
fake_tether_delegate_ = std::make_unique<FakeTetherDelegate>();
NetworkHandler::Get()->network_connection_handler()->SetTetherDelegate(
fake_tether_delegate_.get());
NetworkConnect::Initialize(mock_delegate_.get());
}
void TearDown() override {
NetworkConnect::Shutdown();
mock_delegate_.reset();
LoginState::Shutdown();
testing::Test::TearDown();
}
protected:
void SetupDefaultShillState() {
base::RunLoop().RunUntilIdle();
device_test_ = ShillDeviceClient::Get()->GetTestInterface();
device_test_->ClearDevices();
device_test_->AddDevice("/device/stub_wifi_device1", shill::kTypeWifi,
"stub_wifi_device1");
device_test_->AddDevice(kCellular1DevicePath, shill::kTypeCellular,
"stub_cellular_device1");
device_test_->SetDeviceProperty(
kCellular1DevicePath, shill::kTechnologyFamilyProperty,
base::Value(shill::kNetworkTechnologyGsm), /*notify_changed=*/true);
service_test_ = ShillServiceClient::Get()->GetTestInterface();
service_test_->ClearServices();
const bool add_to_visible = true;
// Create a wifi network and set to online.
service_test_->AddService(kWiFi1ServicePath, kWiFi1Guid, "wifi1",
shill::kTypeWifi, shill::kStateIdle,
add_to_visible);
service_test_->SetServiceProperty(kWiFi1ServicePath,
shill::kSecurityClassProperty,
base::Value(shill::kSecurityClassWep));
service_test_->SetServiceProperty(
kWiFi1ServicePath, shill::kConnectableProperty, base::Value(true));
service_test_->SetServiceProperty(
kWiFi1ServicePath, shill::kPassphraseProperty, base::Value("password"));
// Create an unconfigured wifi network.
service_test_->AddService(kWiFiUnconfiguredServicePath,
kWiFiUnconfiguredGuid, "wifi_unconfigured",
shill::kTypeWifi, shill::kStateIdle,
add_to_visible);
service_test_->SetServiceProperty(kWiFiUnconfiguredServicePath,
shill::kSecurityClassProperty,
base::Value(shill::kSecurityClassWep));
service_test_->SetServiceProperty(kWiFiUnconfiguredServicePath,
shill::kConnectableProperty,
base::Value(false));
service_test_->SetServiceProperty(kWiFiUnconfiguredServicePath,
shill::kErrorProperty,
base::Value("bad-password"));
// Create a cellular network.
service_test_->AddService(kCellular1ServicePath, kCellular1Guid,
"cellular1", shill::kTypeCellular,
shill::kStateIdle, add_to_visible);
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kConnectableProperty, base::Value(true));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateActivated));
service_test_->SetServiceProperty(kCellular1ServicePath,
shill::kOutOfCreditsProperty,
base::Value(false));
base::RunLoop().RunUntilIdle();
}
void AddTetherNetwork(bool has_connected_to_host) {
NetworkStateHandler* handler =
NetworkHandler::Get()->network_state_handler();
handler->SetTetherTechnologyState(
NetworkStateHandler::TechnologyState::TECHNOLOGY_ENABLED);
handler->AddTetherNetworkState(kTetherGuid, "TetherName", "TetherCarrier",
100 /* battery_percentage */,
100 /* signal_strength */,
has_connected_to_host);
}
std::unique_ptr<MockDelegate> mock_delegate_;
std::unique_ptr<FakeTetherDelegate> fake_tether_delegate_;
base::test::SingleThreadTaskEnvironment task_environment_;
NetworkHandlerTestHelper network_handler_test_helper_;
raw_ptr<ShillDeviceClient::TestInterface> device_test_;
raw_ptr<ShillServiceClient::TestInterface> service_test_;
};
TEST_F(NetworkConnectTest, ConnectToNetworkId_NoConfiguration) {
EXPECT_CALL(*mock_delegate_, ShowNetworkConfigure(_)).Times(0);
EXPECT_CALL(*mock_delegate_, ShowNetworkConnectError(_, _)).Times(0);
NetworkConnect::Get()->ConnectToNetworkId("bad guid");
}
TEST_F(NetworkConnectTest, ConnectToNetworkId_Unconfigured) {
EXPECT_CALL(*mock_delegate_, ShowNetworkConfigure(_)).Times(1);
EXPECT_CALL(*mock_delegate_, ShowNetworkConnectError(_, _)).Times(0);
NetworkConnect::Get()->ConnectToNetworkId(kWiFiUnconfiguredGuid);
base::RunLoop().RunUntilIdle();
}
TEST_F(NetworkConnectTest, ConfigureAndConnectToNetwork_NoConfiguration) {
EXPECT_CALL(*mock_delegate_,
ShowNetworkConnectError(NetworkConnectionHandler::kErrorNotFound,
"bad guid"));
base::Value::Dict properties;
NetworkConnect::Get()->ConfigureNetworkIdAndConnect("bad guid", properties,
true);
}
TEST_F(NetworkConnectTest,
ConfigureAndConnectToNetwork_NotSharedButNoProfilePath) {
EXPECT_CALL(*mock_delegate_,
ShowNetworkConnectError(
NetworkConnectionHandler::kErrorConfigureFailed, kWiFi1Guid));
base::Value::Dict properties;
NetworkConnect::Get()->ConfigureNetworkIdAndConnect(kWiFi1Guid, properties,
false);
}
TEST_F(NetworkConnectTest, ConnectThenDisconnectWiFiNetwork) {
const NetworkState* network =
NetworkHandler::Get()->network_state_handler()->GetNetworkStateFromGuid(
kWiFi1Guid);
NetworkConnect::Get()->ConnectToNetworkId(kWiFi1Guid);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(network->IsConnectedState());
NetworkConnect::Get()->DisconnectFromNetworkId(kWiFi1Guid);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(network->IsConnectedState());
EXPECT_FALSE(network->IsConnectingState());
}
TEST_F(NetworkConnectTest, ConnectToTetherNetwork_HasConnectedToHost) {
EXPECT_CALL(*mock_delegate_, ShowNetworkConfigure(_)).Times(0);
AddTetherNetwork(true /* has_connected_to_host */);
NetworkConnect::Get()->ConnectToNetworkId(kTetherGuid);
EXPECT_EQ(kTetherGuid,
fake_tether_delegate_->last_connected_tether_network_guid());
}
TEST_F(NetworkConnectTest, ConnectToTetherNetwork_HasNotConnectedToHost) {
EXPECT_CALL(*mock_delegate_, ShowNetworkConfigure(_));
AddTetherNetwork(false /* has_connected_to_host */);
NetworkConnect::Get()->ConnectToNetworkId(kTetherGuid);
EXPECT_TRUE(
fake_tether_delegate_->last_connected_tether_network_guid().empty());
}
TEST_F(NetworkConnectTest, ConnectToTetherNetwork_ConnectError) {
EXPECT_CALL(*mock_delegate_, ShowNetworkConfigure(_)).Times(0);
AddTetherNetwork(/*has_connected_to_host=*/true);
fake_tether_delegate_->ShouldConnectToNetworkIdSucceed(/*success=*/false);
NetworkConnect::Get()->ConnectToNetworkId(kTetherGuid);
EXPECT_TRUE(
fake_tether_delegate_->last_connected_tether_network_guid().empty());
}
TEST_F(NetworkConnectTest, ActivateCellular) {
EXPECT_CALL(*mock_delegate_, ShowMobileSetupDialog(kCellular1Guid));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateNotActivated));
base::RunLoop().RunUntilIdle();
NetworkConnect::Get()->ConnectToNetworkId(kCellular1Guid);
}
TEST_F(NetworkConnectTest, CarrierUnlock) {
EXPECT_CALL(*mock_delegate_, ShowCarrierUnlockNotification());
NetworkConnect::Get()->ShowCarrierUnlockNotification();
}
TEST_F(NetworkConnectTest, ActivateCellular_Error) {
EXPECT_CALL(*mock_delegate_, ShowMobileActivationError(kCellular1Guid));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateNotActivated));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kActivationTypeProperty,
base::Value(shill::kActivationTypeNonCellular));
base::RunLoop().RunUntilIdle();
NetworkConnect::Get()->ConnectToNetworkId(kCellular1Guid);
}
TEST_F(NetworkConnectTest, ConnectToCellularNetwork_OutOfCredits) {
EXPECT_CALL(*mock_delegate_, ShowCarrierAccountDetail(kCellular1Guid));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kConnectableProperty, base::Value(false));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kOutOfCreditsProperty, base::Value(true));
base::RunLoop().RunUntilIdle();
NetworkConnect::Get()->ConnectToNetworkId(kCellular1Guid);
base::RunLoop().RunUntilIdle();
}
TEST_F(NetworkConnectTest, ShowPortalSignin) {
EXPECT_CALL(*mock_delegate_, ShowPortalSignin(kWiFi1Guid, _));
service_test_->SetServiceProperty(kWiFi1ServicePath, shill::kStateProperty,
base::Value(shill::kStateRedirectFound));
base::RunLoop().RunUntilIdle();
NetworkConnect::Get()->ShowPortalSignin(kWiFi1Guid,
NetworkConnect::Source::kSettings);
base::RunLoop().RunUntilIdle();
}
TEST_F(NetworkConnectTest, ConnectToCellularNetwork_SimLocked) {
EXPECT_CALL(*mock_delegate_, ShowNetworkSettings(kCellular1Guid)).Times(0);
service_test_->SetServiceProperty(kCellular1ServicePath,
shill::kErrorProperty,
base::Value(shill::kErrorSimLocked));
service_test_->SetErrorForNextConnectionAttempt(shill::kErrorConnectFailed);
NetworkConnect::Get()->ConnectToNetworkId(kCellular1Guid);
base::RunLoop().RunUntilIdle();
}
TEST_F(NetworkConnectTest, ConnectToCellularNetwork_SimCarrierLocked) {
EXPECT_CALL(*mock_delegate_, ShowNetworkSettings(kCellular1Guid)).Times(0);
service_test_->SetServiceProperty(kCellular1ServicePath,
shill::kErrorProperty,
base::Value(shill::kErrorSimCarrierLocked));
service_test_->SetErrorForNextConnectionAttempt(shill::kErrorConnectFailed);
NetworkConnect::Get()->ConnectToNetworkId(kCellular1Guid);
base::RunLoop().RunUntilIdle();
}
} // namespace ash
|
