1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/nacl/loader/nacl_validation_query.h"
#include <stdint.h>
#include <memory>
#include "base/compiler_specific.h"
#include "components/nacl/loader/nacl_validation_db.h"
#include "testing/gtest/include/gtest/gtest.h"
// This test makes sure that validation signature generation is performed
// correctly. In effect, this means that we are checking all of the data
// (and no other data) we are passing the signature generator affects the final
// signature. To avoid tying the tests to a particular implementation, each
// test generates two signatures and compares them rather than trying to compare
// against a specified signature.
namespace {
const char kKey[] = "bogus key for HMAC...";
const char kKeyAlt[] = "bogus key for HMAC!!!";
const char kVersion[] = "bogus version";
const char kVersionAlt[] = "bogus!version";
const char kShortData[] = "Short data 1234567890";
const char kAltShortData[] = "Short!data 1234567890";
const char kLongData[] = "Long data."
"1234567890123456789012345678901234567890123456789012345678901234567890"
"1234567890123456789012345678901234567890123456789012345678901234567890"
"1234567890123456789012345678901234567890123456789012345678901234567890"
"1234567890123456789012345678901234567890123456789012345678901234567890";
class MockValidationDB : public NaClValidationDB {
public:
MockValidationDB()
: did_query_(false),
did_set_(false),
status_(true) {
}
bool QueryKnownToValidate(const std::string& signature) override {
// The typecast is needed to work around gtest trying to take the address
// of a constant.
EXPECT_EQ((int) NaClValidationQuery::kDigestLength,
(int) signature.length());
EXPECT_FALSE(did_query_);
EXPECT_FALSE(did_set_);
did_query_ = true;
UNSAFE_TODO(memcpy(query_signature_, signature.data(),
NaClValidationQuery::kDigestLength));
return status_;
}
void SetKnownToValidate(const std::string& signature) override {
// The typecast is needed to work around gtest trying to take the address
// of a constant.
ASSERT_EQ((int) NaClValidationQuery::kDigestLength,
(int) signature.length());
EXPECT_TRUE(did_query_);
EXPECT_FALSE(did_set_);
did_set_ = true;
UNSAFE_TODO(memcpy(set_signature_, signature.data(),
NaClValidationQuery::kDigestLength));
// Signatures should be the same.
EXPECT_EQ(0, UNSAFE_TODO(memcmp(query_signature_, set_signature_,
NaClValidationQuery::kDigestLength)));
}
bool did_query_;
bool did_set_;
bool status_;
uint8_t query_signature_[NaClValidationQuery::kDigestLength];
uint8_t set_signature_[NaClValidationQuery::kDigestLength];
};
class TestQuery {
public:
TestQuery(const char* key, const char* version) {
db = std::make_unique<MockValidationDB>();
context =
std::make_unique<NaClValidationQueryContext>(db.get(), key, version);
query.reset(context->CreateQuery());
}
std::unique_ptr<MockValidationDB> db;
std::unique_ptr<NaClValidationQueryContext> context;
std::unique_ptr<NaClValidationQuery> query;
};
class NaClValidationQueryTest : public ::testing::Test {
protected:
std::unique_ptr<TestQuery> query1;
std::unique_ptr<TestQuery> query2;
void SetUp() override {
query1 = std::make_unique<TestQuery>(kKey, kVersion);
query2 = std::make_unique<TestQuery>(kKey, kVersion);
}
void AssertQuerySame() {
ASSERT_TRUE(query1->db->did_query_);
ASSERT_TRUE(query2->db->did_query_);
ASSERT_EQ(0, UNSAFE_TODO(memcmp(query1->db->query_signature_,
query2->db->query_signature_,
NaClValidationQuery::kDigestLength)));
}
void AssertQueryDifferent() {
ASSERT_TRUE(query1->db->did_query_);
ASSERT_TRUE(query2->db->did_query_);
ASSERT_NE(0, UNSAFE_TODO(memcmp(query1->db->query_signature_,
query2->db->query_signature_,
NaClValidationQuery::kDigestLength)));
}
};
TEST_F(NaClValidationQueryTest, Sanity) {
query1->query->AddData(kShortData, sizeof(kShortData));
ASSERT_FALSE(query1->db->did_query_);
ASSERT_FALSE(query1->db->did_set_);
ASSERT_EQ(1, query1->query->QueryKnownToValidate());
ASSERT_TRUE(query1->db->did_query_);
ASSERT_FALSE(query1->db->did_set_);
query1->query->SetKnownToValidate();
ASSERT_TRUE(query1->db->did_query_);
ASSERT_TRUE(query1->db->did_set_);
}
TEST_F(NaClValidationQueryTest, ConsistentShort) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->QueryKnownToValidate();
AssertQuerySame();
}
TEST_F(NaClValidationQueryTest, InconsistentShort) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kAltShortData, sizeof(kAltShortData));
query2->query->QueryKnownToValidate();
AssertQueryDifferent();
}
// Test for a bug caught during development where AddData would accidently
// overwrite previously written data and add uninitialzied memory to the hash.
TEST_F(NaClValidationQueryTest, ConsistentShortBug) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->QueryKnownToValidate();
AssertQuerySame();
}
// Test for a bug caught during development where AddData would accidently
// overwrite previously written data and add uninitialzed memory to the hash.
TEST_F(NaClValidationQueryTest, InconsistentShortBug1) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kAltShortData, sizeof(kAltShortData));
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->QueryKnownToValidate();
AssertQueryDifferent();
}
// Make sure we don't ignore the second bit of data.
TEST_F(NaClValidationQueryTest, InconsistentShort2) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->AddData(kAltShortData, sizeof(kAltShortData));
query2->query->QueryKnownToValidate();
AssertQueryDifferent();
}
TEST_F(NaClValidationQueryTest, InconsistentZeroSizedAdd) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->AddData(kShortData, 0);
query2->query->QueryKnownToValidate();
AssertQueryDifferent();
}
TEST_F(NaClValidationQueryTest, ConsistentZeroSizedAdd) {
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->AddData("a", 0);
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->AddData("b", 0);
query2->query->QueryKnownToValidate();
AssertQuerySame();
}
TEST_F(NaClValidationQueryTest, ConsistentRepeatedShort) {
for (int i = 0; i < 30; i++) {
query1->query->AddData(kShortData, sizeof(kShortData));
}
query1->query->QueryKnownToValidate();
for (int i = 0; i < 30; i++) {
query2->query->AddData(kShortData, sizeof(kShortData));
}
query2->query->QueryKnownToValidate();
AssertQuerySame();
}
TEST_F(NaClValidationQueryTest, ConsistentLong) {
query1->query->AddData(kLongData, sizeof(kLongData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kLongData, sizeof(kLongData));
query2->query->QueryKnownToValidate();
AssertQuerySame();
}
TEST_F(NaClValidationQueryTest, ConsistentRepeatedLong) {
for (int i = 0; i < 30; i++) {
query1->query->AddData(kLongData, sizeof(kLongData));
}
query1->query->QueryKnownToValidate();
for (int i = 0; i < 30; i++) {
query2->query->AddData(kLongData, sizeof(kLongData));
}
query2->query->QueryKnownToValidate();
AssertQuerySame();
}
TEST_F(NaClValidationQueryTest, PerturbKey) {
query2 = std::make_unique<TestQuery>(kKeyAlt, kVersion);
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->QueryKnownToValidate();
AssertQueryDifferent();
}
TEST_F(NaClValidationQueryTest, PerturbVersion) {
query2 = std::make_unique<TestQuery>(kKey, kVersionAlt);
query1->query->AddData(kShortData, sizeof(kShortData));
query1->query->QueryKnownToValidate();
query2->query->AddData(kShortData, sizeof(kShortData));
query2->query->QueryKnownToValidate();
AssertQueryDifferent();
}
}
|
