1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/content_verifier/content_verifier.h"
#include <memory>
#include "base/files/file_path.h"
#include "base/memory/raw_ptr.h"
#include "base/path_service.h"
#include "base/strings/string_util.h"
#include "base/test/icu_test_util.h"
#include "base/values.h"
#include "extensions/browser/content_verifier/content_verifier_utils.h"
#include "extensions/browser/content_verifier/test_utils.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extensions_test.h"
#include "extensions/common/api/content_scripts.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/extension_paths.h"
#include "extensions/common/extensions_client.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handlers/background_info.h"
#include "extensions/common/manifest_handlers/content_scripts_handler.h"
#include "extensions/common/scoped_testing_manifest_handler_registry.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace {
enum class BackgroundManifestType {
kNone,
kBackgroundScript,
kBackgroundPage,
};
base::FilePath kBackgroundScriptPath(FILE_PATH_LITERAL("foo/bg.js"));
base::FilePath kContentScriptPath(FILE_PATH_LITERAL("foo/content.js"));
base::FilePath kBackgroundPagePath(FILE_PATH_LITERAL("foo/page.html"));
base::FilePath kScriptFilePath(FILE_PATH_LITERAL("bar/code.js"));
base::FilePath kUnknownTypeFilePath(FILE_PATH_LITERAL("bar/code.txt"));
base::FilePath kHTMLFilePath(FILE_PATH_LITERAL("bar/page.html"));
base::FilePath kHTMFilePath(FILE_PATH_LITERAL("bar/page.htm"));
base::FilePath kIconPath(FILE_PATH_LITERAL("bar/16.png"));
base::FilePath ToUppercasePath(const base::FilePath& path) {
return base::FilePath(base::ToUpperASCII(path.value()));
}
base::FilePath ToFirstLetterUppercasePath(const base::FilePath& path) {
base::FilePath::StringType path_copy = path.value();
// Note: if there are no lowercase letters in |path|, this method returns
// |path|.
for (auto& c : path_copy) {
const auto upper_c = base::ToUpperASCII(c);
if (upper_c != c) {
c = upper_c;
break;
}
}
return base::FilePath(path_copy);
}
class TestContentVerifierDelegate : public MockContentVerifierDelegate {
public:
TestContentVerifierDelegate() = default;
TestContentVerifierDelegate(const TestContentVerifierDelegate&) = delete;
TestContentVerifierDelegate& operator=(const TestContentVerifierDelegate&) =
delete;
~TestContentVerifierDelegate() override = default;
std::set<base::FilePath> GetBrowserImagePaths(
const extensions::Extension* extension) override;
void SetBrowserImagePaths(std::set<base::FilePath> paths);
private:
std::set<base::FilePath> browser_images_paths_;
};
std::set<base::FilePath> TestContentVerifierDelegate::GetBrowserImagePaths(
const extensions::Extension* extension) {
return std::set<base::FilePath>(browser_images_paths_);
}
void TestContentVerifierDelegate::SetBrowserImagePaths(
std::set<base::FilePath> paths) {
browser_images_paths_ = paths;
}
// Generated variants of a base::FilePath that are interesting for
// content-verification tests.
struct FilePathVariants {
explicit FilePathVariants(const base::FilePath& path) : original_path(path) {
auto insert_if_non_empty_and_different =
[&path](std::set<base::FilePath>* container, base::FilePath new_path) {
if (!new_path.empty() && new_path != path) {
container->insert(new_path);
}
};
// 1. Case variant 1/2: All uppercase.
insert_if_non_empty_and_different(&case_variants, ToUppercasePath(path));
// 2. Case variant 2/2: First letter uppercase.
insert_if_non_empty_and_different(&case_variants,
ToFirstLetterUppercasePath(path));
}
base::FilePath original_path;
// Case variants of |original_path| that are *not* equal to |original_path|.
std::set<base::FilePath> case_variants;
};
} // namespace
class ContentVerifierTest : public ExtensionsTest {
public:
ContentVerifierTest() = default;
ContentVerifierTest(const ContentVerifierTest&) = delete;
ContentVerifierTest& operator=(const ContentVerifierTest&) = delete;
void SetUp() override {
ExtensionsTest::SetUp();
// Manually register handlers since the |ContentScriptsHandler| is not
// usually registered in extensions_unittests.
ScopedTestingManifestHandlerRegistry scoped_registry;
{
ManifestHandlerRegistry* registry = ManifestHandlerRegistry::Get();
registry->RegisterHandler(std::make_unique<BackgroundManifestHandler>());
registry->RegisterHandler(std::make_unique<ContentScriptsHandler>());
ManifestHandler::FinalizeRegistration();
}
extension_ = CreateTestExtension();
ExtensionRegistry::Get(browser_context())->AddEnabled(extension_);
auto content_verifier_delegate =
std::make_unique<TestContentVerifierDelegate>();
content_verifier_delegate_raw_ = content_verifier_delegate.get();
content_verifier_ = new ContentVerifier(
browser_context(), std::move(content_verifier_delegate));
// |ContentVerifier::ShouldVerifyAnyPaths| always returns false if the
// Content Verifier does not have |ContentVerifierIOData::ExtensionData|
// for the extension.
content_verifier_->ResetIODataForTesting(extension_.get());
}
void TearDown() override {
content_verifier_->Shutdown();
ExtensionsTest::TearDown();
}
void UpdateBrowserImagePaths(const std::set<base::FilePath>& paths) {
content_verifier_delegate_raw_->SetBrowserImagePaths(paths);
content_verifier_->ResetIODataForTesting(extension_.get());
}
bool ShouldVerifySinglePath(const base::FilePath& path) {
return content_verifier_->ShouldVerifyAnyPathsForTesting(
extension_->id(), extension_->path(), {path});
}
BackgroundManifestType GetBackgroundManifestType() {
return background_manifest_type_;
}
void TestPathsForCaseInsensitiveHandling(std::string_view lower,
std::string_view upper) {
const auto lower_path = base::FilePath::FromUTF8Unsafe(lower);
const auto upper_path = base::FilePath::FromUTF8Unsafe(upper);
UpdateBrowserImagePaths({});
// The path would be treated as unclassified resource, so it gets verified.
EXPECT_TRUE(ShouldVerifySinglePath(lower_path))
<< "for lower_path " << lower_path;
EXPECT_TRUE(ShouldVerifySinglePath(upper_path))
<< "for upper_path " << upper_path;
// If the path is specified as browser image, it doesn't get verified.
UpdateBrowserImagePaths({lower_path});
EXPECT_FALSE(ShouldVerifySinglePath(lower_path))
<< "for lower_path " << lower_path;
EXPECT_FALSE(ShouldVerifySinglePath(upper_path))
<< "for upper_path " << upper_path;
// The case of the image path shouldn't matter.
UpdateBrowserImagePaths({upper_path});
EXPECT_FALSE(ShouldVerifySinglePath(lower_path))
<< "for lower_path " << lower_path;
EXPECT_FALSE(ShouldVerifySinglePath(upper_path))
<< "for upper_path " << upper_path;
UpdateBrowserImagePaths({});
}
protected:
BackgroundManifestType background_manifest_type_ =
BackgroundManifestType::kNone;
private:
// Create a test extension with a content script and possibly a background
// page or background script.
scoped_refptr<Extension> CreateTestExtension() {
auto manifest = base::Value::Dict()
.Set("name", "Dummy Extension")
.Set("version", "1")
.Set("manifest_version", 2);
if (background_manifest_type_ ==
BackgroundManifestType::kBackgroundScript) {
base::Value::List background_scripts;
background_scripts.Append(kBackgroundScriptPath.AsUTF8Unsafe());
manifest.SetByDottedPath(manifest_keys::kBackgroundScripts,
std::move(background_scripts));
} else if (background_manifest_type_ ==
BackgroundManifestType::kBackgroundPage) {
manifest.SetByDottedPath(manifest_keys::kBackgroundPage,
kBackgroundPagePath.AsUTF8Unsafe());
}
base::Value::List content_scripts;
base::Value::Dict content_script;
base::Value::List js_files;
base::Value::List matches;
js_files.Append("foo/content.txt");
content_script.Set("js", std::move(js_files));
matches.Append("http://*/*");
content_script.Set("matches", std::move(matches));
content_scripts.Append(std::move(content_script));
manifest.Set(api::content_scripts::ManifestKeys::kContentScripts,
std::move(content_scripts));
base::FilePath path;
EXPECT_TRUE(base::PathService::Get(DIR_TEST_DATA, &path));
std::string error;
scoped_refptr<Extension> extension(
Extension::Create(path, mojom::ManifestLocation::kInternal, manifest,
Extension::NO_FLAGS, &error));
EXPECT_TRUE(extension.get()) << error;
return extension;
}
scoped_refptr<ContentVerifier> content_verifier_;
scoped_refptr<Extension> extension_;
raw_ptr<TestContentVerifierDelegate> content_verifier_delegate_raw_;
};
class ContentVerifierTestWithBackgroundType
: public ContentVerifierTest,
public testing::WithParamInterface<BackgroundManifestType> {
public:
ContentVerifierTestWithBackgroundType() {
background_manifest_type_ = GetParam();
}
ContentVerifierTestWithBackgroundType(
const ContentVerifierTestWithBackgroundType&) = delete;
ContentVerifierTestWithBackgroundType& operator=(
const ContentVerifierTestWithBackgroundType&) = delete;
};
// Verifies that |ContentVerifier::ShouldVerifyAnyPaths| returns true for
// some file paths even if those paths are specified as browser images.
TEST_P(ContentVerifierTestWithBackgroundType, BrowserImagesShouldBeVerified) {
std::vector<base::FilePath> files_to_be_verified = {
kContentScriptPath, kScriptFilePath, kHTMLFilePath,
kHTMFilePath, kBackgroundScriptPath, kBackgroundPagePath};
std::vector<base::FilePath> files_not_to_be_verified{kIconPath,
kUnknownTypeFilePath};
auto generate_test_cases = [](const std::vector<base::FilePath>& input) {
std::set<base::FilePath> output;
for (const auto& path : input) {
output.insert(path);
if (!content_verifier_utils::IsFileAccessCaseSensitive()) {
// For case insensitive OS, upper casing the FilePaths would be
// treated in similar fashion.
output.insert(ToUppercasePath(path));
// Ditto for only upper casing first character of FilePath.
output.insert(ToFirstLetterUppercasePath(path));
}
}
return output;
};
std::set<base::FilePath> all_files_to_be_verified =
generate_test_cases(files_to_be_verified);
for (const base::FilePath& path : all_files_to_be_verified) {
UpdateBrowserImagePaths({});
EXPECT_TRUE(ShouldVerifySinglePath(path)) << "for path " << path;
UpdateBrowserImagePaths(std::set<base::FilePath>{path});
EXPECT_TRUE(ShouldVerifySinglePath(path)) << "for path " << path;
}
std::set<base::FilePath> all_files_not_to_be_verified =
generate_test_cases(files_not_to_be_verified);
for (const base::FilePath& path : all_files_not_to_be_verified) {
UpdateBrowserImagePaths({});
EXPECT_TRUE(ShouldVerifySinglePath(path)) << "for path " << path;
UpdateBrowserImagePaths(std::set<base::FilePath>{path});
EXPECT_FALSE(ShouldVerifySinglePath(path)) << "for path " << path;
}
}
INSTANTIATE_TEST_SUITE_P(
All,
ContentVerifierTestWithBackgroundType,
testing::Values(BackgroundManifestType::kNone,
BackgroundManifestType::kBackgroundScript,
BackgroundManifestType::kBackgroundPage));
TEST_F(ContentVerifierTest, NormalizeRelativePath) {
// This macro helps avoid wrapped lines in the test structs.
#define FPL(x) FILE_PATH_LITERAL(x)
struct TestData {
base::FilePath::StringViewType input;
base::FilePath::StringViewType expected;
} test_cases[] = {
{FPL("foo/bar"), FPL("foo/bar")},
{FPL("foo//bar"), FPL("foo/bar")},
{FPL("foo/bar/"), FPL("foo/bar/")},
{FPL("foo/bar//"), FPL("foo/bar/")},
{FPL("foo/options.html/"), FPL("foo/options.html/")},
{FPL("foo/./bar"), FPL("foo/bar")},
{FPL("foo/../bar"), FPL("bar")},
{FPL("foo/../.."), FPL("")},
{FPL("./foo"), FPL("foo")},
{FPL("../foo"), FPL("foo")},
{FPL("foo/../../bar"), FPL("bar")},
};
#undef FPL
for (const auto& test_case : test_cases) {
base::FilePath input(test_case.input);
base::FilePath expected(test_case.expected);
EXPECT_EQ(expected,
ContentVerifier::NormalizeRelativePathForTesting(input));
// A leading separator should be ignored.
base::FilePath input_with_root(
base::FilePath(FILE_PATH_LITERAL("/")).Append(test_case.input));
EXPECT_EQ(expected, ContentVerifier::NormalizeRelativePathForTesting(
input_with_root));
}
}
// Tests that JavaScript and html/htm files are always verified, even if their
// extension case isn't lower cased or even if they are specified as browser
// image paths.
TEST_F(ContentVerifierTest, JSAndHTMLAlwaysVerified) {
std::vector<std::string> exts_lowercase = {
// Common extensions.
"js",
"html",
"htm",
// Less common extensions.
"mjs",
"shtml",
"shtm",
};
for (const auto& ext_lowercase : exts_lowercase) {
auto ext_uppercase = base::ToUpperASCII(ext_lowercase);
auto ext_capitalized = ext_lowercase;
ext_capitalized[0] = base::ToUpperASCII(ext_capitalized[0]);
for (const auto& ext : {ext_lowercase, ext_uppercase, ext_capitalized}) {
const auto path =
base::FilePath(FILE_PATH_LITERAL("x")).AddExtensionASCII(ext);
UpdateBrowserImagePaths({});
// |path| would be treated as unclassified resource, so it gets verified.
EXPECT_TRUE(ShouldVerifySinglePath(path)) << "for path " << path;
// Even if |path| was specified as browser image, as |path| is JS/html
// (sensitive) resource, it would still get verified.
UpdateBrowserImagePaths({path});
EXPECT_TRUE(ShouldVerifySinglePath(path)) << "for path " << path;
}
}
}
TEST_F(ContentVerifierTest, CaseInsensitivePaths) {
if (content_verifier_utils::IsFileAccessCaseSensitive()) {
return;
}
std::vector<std::pair<std::string, std::string>> lower_upper = {
{"a.png", "A.png"},
{"ä.png", "Ä.png"},
{"æ.png", "Æ.png"},
{"ф.png", "Ф.png"},
};
for (const auto& [lower, upper] : lower_upper) {
TestPathsForCaseInsensitiveHandling(lower, upper);
}
}
TEST_F(ContentVerifierTest, CaseInsensitivePathsLocaleIndependent) {
if (content_verifier_utils::IsFileAccessCaseSensitive()) {
return;
}
std::vector<std::pair<std::string, std::string>> lower_upper = {
// Locale-depended Turkish conversion may normalize these file names
// differently, which would be undesirable.
{"icon.png", "Icon.png"},
};
std::vector<std::string> locales = {"en_US", "tr"};
for (const auto& locale : locales) {
base::test::ScopedRestoreICUDefaultLocale restore_locale(locale);
for (const auto& [lower, upper] : lower_upper) {
TestPathsForCaseInsensitiveHandling(lower, upper);
}
}
}
TEST_F(ContentVerifierTest, AlwaysVerifiedPathsWithVariants) {
FilePathVariants kAlwaysVerifiedTestCases[] = {
// JS files are always verified.
FilePathVariants(base::FilePath(FILE_PATH_LITERAL("always.js"))),
// html files are always verified.
FilePathVariants(base::FilePath(FILE_PATH_LITERAL("always.html"))),
};
for (const auto& test_case : kAlwaysVerifiedTestCases) {
EXPECT_TRUE(ShouldVerifySinglePath(test_case.original_path))
<< "original_path = " << test_case.original_path;
// Case changed variants always gets verified in case-insensitive OS.
// e.g. "ALWAYS.JS" is verified in win/mac. On other OS, they are treated as
// unclassified resource so also gets verified.
for (const auto& case_variant : test_case.case_variants) {
EXPECT_TRUE(ShouldVerifySinglePath({case_variant}))
<< " case_variant = " << case_variant;
}
}
}
// Tests paths that are never supposed to be verified by content verification.
// Also tests their OS specific equivalents (changing case and appending
// dot-space suffix to them in windows for example).
TEST_F(ContentVerifierTest, NeverVerifiedPaths) {
FilePathVariants kNeverVerifiedTestCases[] = {
// manifest.json is never verified.
FilePathVariants(base::FilePath(FILE_PATH_LITERAL("manifest.json"))),
// _locales paths are never verified:
// - locales with lowercase lang.
FilePathVariants(
base::FilePath(FILE_PATH_LITERAL("_locales/en/messages.json"))),
// - locales with mixedcase lang.
FilePathVariants(
base::FilePath(FILE_PATH_LITERAL("_locales/en_GB/messages.json"))),
};
for (const auto& test_case : kNeverVerifiedTestCases) {
EXPECT_FALSE(ShouldVerifySinglePath(test_case.original_path))
<< test_case.original_path;
// Case changed variants should only be verified iff the OS
// is case-sensitive, as they won't be treated as ignorable file path.
// e.g. "Manifest.json" is not verified in win/mac, but is verified in
// linux/chromeos.
for (const auto& case_variant : test_case.case_variants) {
EXPECT_EQ(content_verifier_utils::IsFileAccessCaseSensitive(),
ShouldVerifySinglePath({case_variant}))
<< " case_variant = " << case_variant;
}
}
}
} // namespace extensions
|