1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_restrictions.h"
#include "components/guest_view/browser/guest_view_manager_delegate.h"
#include "components/guest_view/browser/test_guest_view_manager.h"
#include "content/public/common/content_features.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "extensions/browser/app_window/app_window.h"
#include "extensions/browser/app_window/app_window_registry.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_paths.h"
#include "extensions/shell/browser/shell_app_delegate.h"
#include "extensions/shell/browser/shell_app_view_guest_delegate.h"
#include "extensions/shell/browser/shell_content_browser_client.h"
#include "extensions/shell/browser/shell_extension_system.h"
#include "extensions/shell/browser/shell_extensions_api_client.h"
#include "extensions/shell/browser/shell_extensions_browser_client.h"
#include "extensions/shell/test/shell_test.h"
#include "extensions/test/extension_test_message_listener.h"
namespace {
class MockShellAppDelegate : public extensions::ShellAppDelegate {
public:
MockShellAppDelegate() {
EXPECT_EQ(instance_, nullptr);
instance_ = this;
}
~MockShellAppDelegate() override { instance_ = nullptr; }
void RequestMediaAccessPermission(
content::WebContents* web_contents,
const content::MediaStreamRequest& request,
content::MediaResponseCallback callback,
const extensions::Extension* extension) override {
media_access_requested_ = true;
if (media_access_request_quit_closure_) {
std::move(media_access_request_quit_closure_).Run();
}
}
void WaitForRequestMediaPermission() {
if (media_access_requested_) {
return;
}
base::RunLoop run_loop;
media_access_request_quit_closure_ = run_loop.QuitClosure();
run_loop.Run();
}
static MockShellAppDelegate* Get() { return instance_; }
private:
bool media_access_requested_ = false;
base::OnceClosure media_access_request_quit_closure_;
static MockShellAppDelegate* instance_;
};
MockShellAppDelegate* MockShellAppDelegate::instance_ = nullptr;
class MockShellAppViewGuestDelegate
: public extensions::ShellAppViewGuestDelegate {
public:
MockShellAppViewGuestDelegate() = default;
extensions::AppDelegate* CreateAppDelegate(
content::BrowserContext* browser_context) override {
return new MockShellAppDelegate();
}
};
class MockExtensionsAPIClient : public extensions::ShellExtensionsAPIClient {
public:
MockExtensionsAPIClient() = default;
std::unique_ptr<extensions::AppViewGuestDelegate> CreateAppViewGuestDelegate()
const override {
return std::make_unique<MockShellAppViewGuestDelegate>();
}
};
} // namespace
namespace extensions {
class AppViewTest : public AppShellTest,
public testing::WithParamInterface<bool> {
public:
static std::string DescribeParams(
const testing::TestParamInfo<ParamType>& info) {
return info.param ? "MPArch" : "InnerWebContents";
}
AppViewTest() {
scoped_feature_list_.InitWithFeatureState(features::kGuestViewMPArch,
GetParam());
}
protected:
void SetUpOnMainThread() override {
AppShellTest::SetUpOnMainThread();
content::BrowserContext* context =
ShellContentBrowserClient::Get()->GetBrowserContext();
test_guest_view_manager_ = factory_.GetOrCreateTestGuestViewManager(
context, ExtensionsAPIClient::Get()->CreateGuestViewManagerDelegate());
}
void TearDownOnMainThread() override {
test_guest_view_manager_ = nullptr;
AppShellTest::TearDownOnMainThread();
}
content::WebContents* GetFirstAppWindowWebContents() {
const AppWindowRegistry::AppWindowList& app_window_list =
AppWindowRegistry::Get(browser_context_)->app_windows();
EXPECT_EQ(1U, app_window_list.size());
return (*app_window_list.begin())->web_contents();
}
const Extension* LoadApp(const std::string& app_location) {
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath test_data_dir;
base::PathService::Get(DIR_TEST_DATA, &test_data_dir);
test_data_dir = test_data_dir.AppendASCII(app_location.c_str());
return extension_system_->LoadApp(test_data_dir);
}
void RunTest(const std::string& test_name,
const std::string& app_location,
const std::string& app_to_embed) {
const Extension* app_embedder = LoadApp(app_location);
ASSERT_TRUE(app_embedder);
const Extension* app_embedded = LoadApp(app_to_embed);
ASSERT_TRUE(app_embedded);
extension_system_->LaunchApp(app_embedder->id());
ExtensionTestMessageListener launch_listener("LAUNCHED");
ASSERT_TRUE(launch_listener.WaitUntilSatisfied());
ExtensionTestMessageListener done_listener("TEST_PASSED");
done_listener.set_failure_message("TEST_FAILED");
ASSERT_TRUE(content::ExecJs(
GetFirstAppWindowWebContents(),
base::StringPrintf("runTest('%s', '%s')", test_name.c_str(),
app_embedded->id().c_str())))
<< "Unable to start test.";
ASSERT_TRUE(done_listener.WaitUntilSatisfied());
}
guest_view::TestGuestViewManager* test_guest_view_manager() const {
return test_guest_view_manager_;
}
private:
guest_view::TestGuestViewManagerFactory factory_;
raw_ptr<guest_view::TestGuestViewManager> test_guest_view_manager_ = nullptr;
base::test::ScopedFeatureList scoped_feature_list_;
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
AppViewTest,
testing::Bool(),
AppViewTest::DescribeParams);
// Tests that <appview> correctly processes parameters passed on connect.
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewGoodDataShouldSucceed) {
RunTest("testAppViewGoodDataShouldSucceed",
"app_view/apitest",
"app_view/apitest/skeleton");
// Note that the callback of the appview connect method runs after guest
// creation, but not necessarily after attachment. So we now ensure that the
// guest successfully attaches and loads.
EXPECT_TRUE(test_guest_view_manager()->WaitUntilAttachedAndLoaded(
test_guest_view_manager()->WaitForSingleGuestViewCreated()));
}
// Tests that <appview> can handle media permission requests.
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewMediaRequest) {
// TODO(crbug.com/40202416): Implement for MPArch.
if (base::FeatureList::IsEnabled(features::kGuestViewMPArch)) {
GTEST_SKIP() << "MPArch implementation skipped. https://crbug.com/40202416";
}
static_cast<ShellExtensionsBrowserClient*>(ExtensionsBrowserClient::Get())
->SetAPIClientForTest(nullptr);
static_cast<ShellExtensionsBrowserClient*>(ExtensionsBrowserClient::Get())
->SetAPIClientForTest(new MockExtensionsAPIClient);
RunTest("testAppViewMediaRequest", "app_view/apitest",
"app_view/apitest/media_request");
MockShellAppDelegate::Get()->WaitForRequestMediaPermission();
}
// Tests that <appview> correctly processes parameters passed on connect.
// This test should fail to connect because the embedded app (skeleton) will
// refuse the data passed by the embedder app and deny the request.
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewRefusedDataShouldFail) {
RunTest("testAppViewRefusedDataShouldFail",
"app_view/apitest",
"app_view/apitest/skeleton");
}
// Tests that <appview> is able to navigate to another installed app.
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewWithUndefinedDataShouldSucceed) {
RunTest("testAppViewWithUndefinedDataShouldSucceed",
"app_view/apitest",
"app_view/apitest/skeleton");
EXPECT_TRUE(test_guest_view_manager()->WaitUntilAttachedAndLoaded(
test_guest_view_manager()->WaitForSingleGuestViewCreated()));
}
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewNoEmbedRequestListener) {
RunTest("testAppViewNoEmbedRequestListener", "app_view/apitest",
"app_view/apitest/no_embed_request_listener");
}
} // namespace extensions
|
