1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/common/features/complex_feature.h"
#include <string>
#include <utility>
#include "base/test/bind.h"
#include "content/public/common/content_features.h"
#include "extensions/common/features/feature.h"
#include "extensions/common/features/simple_feature.h"
#include "extensions/common/manifest.h"
#include "extensions/common/mojom/context_type.mojom.h"
#include "extensions/test/test_context_data.h"
#include "testing/gtest/include/gtest/gtest.h"
using extensions::mojom::ManifestLocation;
namespace extensions {
TEST(ComplexFeatureTest, MultipleRulesAllowlist) {
const HashedExtensionId kIdFoo("fooabbbbccccddddeeeeffffgggghhhh");
const HashedExtensionId kIdBar("barabbbbccccddddeeeeffffgggghhhh");
std::vector<Feature*> features;
{
// Rule: "extension", allowlist "foo".
std::unique_ptr<SimpleFeature> simple_feature(new SimpleFeature());
simple_feature->set_allowlist({kIdFoo.value().c_str()});
simple_feature->set_extension_types({Manifest::TYPE_EXTENSION});
features.push_back(simple_feature.release());
}
{
// Rule: "legacy_packaged_app", allowlist "bar".
std::unique_ptr<SimpleFeature> simple_feature(new SimpleFeature());
simple_feature->set_allowlist({kIdBar.value().c_str()});
simple_feature->set_extension_types({Manifest::TYPE_LEGACY_PACKAGED_APP});
features.push_back(simple_feature.release());
}
std::unique_ptr<ComplexFeature> feature(new ComplexFeature(&features));
// Test match 1st rule.
EXPECT_EQ(Feature::IS_AVAILABLE,
feature
->IsAvailableToManifest(kIdFoo, Manifest::TYPE_EXTENSION,
ManifestLocation::kInvalidLocation,
Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(),
kUnspecifiedContextId)
.result());
// Test match 2nd rule.
EXPECT_EQ(
Feature::IS_AVAILABLE,
feature
->IsAvailableToManifest(
kIdBar, Manifest::TYPE_LEGACY_PACKAGED_APP,
ManifestLocation::kInvalidLocation, Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(), kUnspecifiedContextId)
.result());
// Test allowlist with wrong extension type.
EXPECT_NE(Feature::IS_AVAILABLE,
feature
->IsAvailableToManifest(kIdBar, Manifest::TYPE_EXTENSION,
ManifestLocation::kInvalidLocation,
Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(),
kUnspecifiedContextId)
.result());
EXPECT_NE(
Feature::IS_AVAILABLE,
feature
->IsAvailableToManifest(
kIdFoo, Manifest::TYPE_LEGACY_PACKAGED_APP,
ManifestLocation::kInvalidLocation, Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(), kUnspecifiedContextId)
.result());
}
// Tests that dependencies are correctly checked.
TEST(ComplexFeatureTest, Dependencies) {
std::vector<Feature*> features;
{
// Rule which depends on an extension-only feature
// (content_security_policy).
std::unique_ptr<SimpleFeature> simple_feature(new SimpleFeature());
simple_feature->set_dependencies({"manifest:content_security_policy"});
features.push_back(simple_feature.release());
}
{
// Rule which depends on an platform-app-only feature (serial).
std::unique_ptr<SimpleFeature> simple_feature(new SimpleFeature());
simple_feature->set_dependencies({"permission:serial"});
features.push_back(simple_feature.release());
}
std::unique_ptr<ComplexFeature> feature(new ComplexFeature(&features));
// Available to extensions because of the content_security_policy rule.
EXPECT_EQ(
Feature::IS_AVAILABLE,
feature
->IsAvailableToManifest(
HashedExtensionId(std::string(32, 'a')), Manifest::TYPE_EXTENSION,
ManifestLocation::kInvalidLocation, Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(), kUnspecifiedContextId)
.result());
// Available to platform apps because of the serial rule.
EXPECT_EQ(Feature::IS_AVAILABLE,
feature
->IsAvailableToManifest(HashedExtensionId(std::string(32, 'b')),
Manifest::TYPE_PLATFORM_APP,
ManifestLocation::kInvalidLocation,
Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(),
kUnspecifiedContextId)
.result());
// Not available to hosted apps.
EXPECT_EQ(Feature::INVALID_TYPE,
feature
->IsAvailableToManifest(HashedExtensionId(std::string(32, 'c')),
Manifest::TYPE_HOSTED_APP,
ManifestLocation::kInvalidLocation,
Feature::UNSPECIFIED_PLATFORM,
Feature::GetCurrentPlatform(),
kUnspecifiedContextId)
.result());
}
TEST(ComplexFeatureTest, RequiresDelegatedAvailabilityCheck) {
std::vector<Feature*> features;
// Test a complex feature where |requires_delegated_availability_check| hasn't
// been set on any of its simple features.
{
{
// Feature which doesn't set |requires_delegated_availability_check|.
auto simple_feature = std::make_unique<SimpleFeature>();
features.push_back(simple_feature.release());
}
{
// Feature which doesn't set |requires_delegated_availability_check|.
auto simple_feature = std::make_unique<SimpleFeature>();
features.push_back(simple_feature.release());
}
ComplexFeature complex_feature(&features);
EXPECT_FALSE(complex_feature.RequiresDelegatedAvailabilityCheck());
EXPECT_FALSE(complex_feature.HasDelegatedAvailabilityCheckHandler());
}
uint32_t delegated_availability_check_call_count = 0;
uint32_t success_call_count = 2;
auto delegated_availability_check =
[&](const std::string& api_full_name, const Extension* extension,
mojom::ContextType context, const GURL& url,
Feature::Platform platform, int context_id, bool check_developer_mode,
const ContextData& context_data) {
++delegated_availability_check_call_count;
return delegated_availability_check_call_count == success_call_count;
};
// Test a complex feature where |requires_delegated_availability_check| is set
// on multiple sub-features. The first sub-feature that requires the
// availability check should fail, while the second sub-feature should pass.
// In this case, the delegated availability check handler should be called
// twice.
{
{
// Feature which doesn't set |requires_delegated_availability_check|.
auto simple_feature = std::make_unique<SimpleFeature>();
simple_feature->set_contexts({mojom::ContextType::kPrivilegedExtension});
features.push_back(simple_feature.release());
}
// Two features which set |requires_delegated_availability_check| to true.
{
auto simple_feature = std::make_unique<SimpleFeature>();
simple_feature->set_requires_delegated_availability_check(true);
features.push_back(simple_feature.release());
}
{
auto simple_feature = std::make_unique<SimpleFeature>();
simple_feature->set_requires_delegated_availability_check(true);
features.push_back(simple_feature.release());
}
ComplexFeature complex_feature(&features);
EXPECT_TRUE(complex_feature.RequiresDelegatedAvailabilityCheck());
EXPECT_FALSE(complex_feature.HasDelegatedAvailabilityCheckHandler());
// A call to SetDelegatedAvailabilityCheckHandler() should set the
// handler to the sub-features that require it.
complex_feature.SetDelegatedAvailabilityCheckHandler(
base::BindLambdaForTesting(delegated_availability_check));
EXPECT_TRUE(complex_feature.HasDelegatedAvailabilityCheckHandler());
// This feature should be available the second time that the delegated
// availability check is called.
EXPECT_EQ(Feature::IS_AVAILABLE,
complex_feature
.IsAvailableToContext(
/*extension=*/nullptr, mojom::ContextType::kUnspecified,
GURL(), kUnspecifiedContextId, TestContextData())
.result());
EXPECT_EQ(2u, delegated_availability_check_call_count);
}
}
} // namespace extensions
|
