1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "third_party/blink/renderer/platform/graphics/parkable_image.h"
#include "base/debug/stack_trace.h"
#include "base/feature_list.h"
#include "base/memory/asan_interface.h"
#include "base/memory/ref_counted.h"
#include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/synchronization/lock.h"
#include "base/task/single_thread_task_runner.h"
#include "base/time/time.h"
#include "base/timer/elapsed_timer.h"
#include "base/trace_event/trace_event.h"
#include "third_party/blink/renderer/platform/graphics/parkable_image_manager.h"
#include "third_party/blink/renderer/platform/image-decoders/segment_reader.h"
#include "third_party/blink/renderer/platform/scheduler/public/post_cross_thread_task.h"
#include "third_party/blink/renderer/platform/scheduler/public/thread.h"
#include "third_party/blink/renderer/platform/scheduler/public/worker_pool.h"
#include "third_party/blink/renderer/platform/wtf/cross_thread_copier_base.h"
#include "third_party/blink/renderer/platform/wtf/cross_thread_functional.h"
#include "third_party/blink/renderer/platform/wtf/sanitizers.h"
#include "third_party/skia/include/core/SkData.h"
#include "third_party/skia/include/core/SkRefCnt.h"
namespace blink {
BASE_FEATURE(kDelayParkingImages,
"DelayParkingImages",
base::FEATURE_ENABLED_BY_DEFAULT);
namespace {
void RecordReadStatistics(size_t size,
base::TimeDelta duration,
base::TimeDelta time_since_freeze) {
int throughput_mb_s = duration.is_zero()
? INT_MAX
: base::saturated_cast<int>(
size / duration.InSecondsF() / (1024 * 1024));
// Size is usually >1KiB, and at most ~10MiB, and throughput ranges from
// single-digit MB/s to ~1000MiB/s depending on the CPU/disk, hence the
// ranges.
base::UmaHistogramCustomMicrosecondsTimes("Memory.ParkableImage.Read.Latency",
duration, base::Microseconds(500),
base::Seconds(1), 100);
base::UmaHistogramCounts1000("Memory.ParkableImage.Read.Throughput",
throughput_mb_s);
}
void RecordWriteStatistics(size_t size, base::TimeDelta duration) {
int size_kb = static_cast<int>(size / 1024); // in KiB
// Size should be <1MiB in most cases.
base::UmaHistogramCounts10000("Memory.ParkableImage.Write.Size", size_kb);
// Size is usually >1KiB, and at most ~10MiB, and throughput ranges from
// single-digit MB/s to ~1000MiB/s depending on the CPU/disk, hence the
// ranges.
base::UmaHistogramCustomMicrosecondsTimes(
"Memory.ParkableImage.Write.Latency", duration, base::Microseconds(500),
base::Seconds(1), 100);
}
void AsanPoisonBuffer(RWBuffer* rw_buffer) {
#if defined(ADDRESS_SANITIZER)
if (!rw_buffer || !rw_buffer->size())
return;
auto ro_buffer = rw_buffer->MakeROBufferSnapshot();
ROBuffer::Iter iter(ro_buffer);
do {
auto data = *iter;
ASAN_POISON_MEMORY_REGION(data.data(), data.size());
} while (iter.Next());
#endif
}
void AsanUnpoisonBuffer(RWBuffer* rw_buffer) {
#if defined(ADDRESS_SANITIZER)
if (!rw_buffer || !rw_buffer->size())
return;
auto ro_buffer = rw_buffer->MakeROBufferSnapshot();
ROBuffer::Iter iter(ro_buffer);
do {
auto data = *iter;
ASAN_UNPOISON_MEMORY_REGION(data.data(), data.size());
} while (iter.Next());
#endif
}
// This should be used to make sure that the last reference to the |this| is
// decremented on the main thread (since that's where the destructor must
// run), for example by posting a task with this to the main thread.
void NotifyWriteToDiskFinished(scoped_refptr<ParkableImageImpl>) {
DCHECK(IsMainThread());
}
} // namespace
// ParkableImageSegmentReader
class ParkableImageSegmentReader : public SegmentReader {
public:
explicit ParkableImageSegmentReader(scoped_refptr<ParkableImage> image);
size_t size() const override;
base::span<const uint8_t> GetSomeData(size_t position) const override;
sk_sp<SkData> GetAsSkData() const override;
void LockData() override;
void UnlockData() override;
private:
~ParkableImageSegmentReader() override = default;
scoped_refptr<ParkableImage> parkable_image_;
size_t available_;
};
ParkableImageSegmentReader::ParkableImageSegmentReader(
scoped_refptr<ParkableImage> image)
: parkable_image_(std::move(image)), available_(parkable_image_->size()) {}
size_t ParkableImageSegmentReader::size() const {
return available_;
}
base::span<const uint8_t> ParkableImageSegmentReader::GetSomeData(
size_t position) const {
if (!parkable_image_) {
return {};
}
base::AutoLock lock(parkable_image_->impl_->lock_);
DCHECK(parkable_image_->impl_->is_locked());
RWBuffer::ROIter iter(parkable_image_->impl_->rw_buffer_.get(), available_);
size_t position_of_block = 0;
return RWBufferGetSomeData(iter, position_of_block, position);
}
sk_sp<SkData> ParkableImageSegmentReader::GetAsSkData() const {
if (!parkable_image_) {
return nullptr;
}
base::AutoLock lock(parkable_image_->impl_->lock_);
parkable_image_->impl_->Unpark();
RWBuffer::ROIter iter(parkable_image_->impl_->rw_buffer_.get(), available_);
if (!iter.HasNext()) { // No need to copy because the data is contiguous.
// We lock here so that we don't get a use-after-free. ParkableImage can
// not be parked while it is locked, so the buffer is valid for the whole
// lifetime of the SkData. We add the ref so that the ParkableImage has a
// longer limetime than the SkData.
parkable_image_->AddRef();
parkable_image_->LockData();
auto data = *iter;
return SkData::MakeWithProc(
data.data(), data.size(),
[](const void* ptr, void* context) -> void {
auto* parkable_image = static_cast<ParkableImage*>(context);
{
base::AutoLock lock(parkable_image->impl_->lock_);
parkable_image->UnlockData();
}
// Don't hold the mutex while we call |Release|, since |Release| can
// free the ParkableImage, if this is the last reference to it;
// Freeing the ParkableImage while the mutex is held causes a UAF when
// the dtor for base::AutoLock is called.
parkable_image->Release();
},
parkable_image_.get());
}
// Data is not contiguous so we need to copy.
return RWBufferCopyAsSkData(iter, available_);
}
void ParkableImageSegmentReader::LockData() {
base::AutoLock lock(parkable_image_->impl_->lock_);
parkable_image_->impl_->Unpark();
parkable_image_->LockData();
}
void ParkableImageSegmentReader::UnlockData() {
base::AutoLock lock(parkable_image_->impl_->lock_);
parkable_image_->UnlockData();
}
constexpr base::TimeDelta ParkableImageImpl::kParkingDelay;
void ParkableImageImpl::Append(WTF::SharedBuffer* buffer, size_t offset) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
base::AutoLock lock(lock_);
DCHECK(!is_frozen());
DCHECK(!is_on_disk());
DCHECK(rw_buffer_);
for (auto it = buffer->GetIteratorAt(offset); it != buffer->cend(); ++it) {
DCHECK_GE(buffer->size(), rw_buffer_->size() + it->size());
const size_t remaining = buffer->size() - rw_buffer_->size() - it->size();
rw_buffer_->Append(base::as_byte_span(*it), remaining);
}
size_ = rw_buffer_->size();
}
scoped_refptr<SharedBuffer> ParkableImageImpl::Data() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
base::AutoLock lock(lock_);
Unpark();
DCHECK(rw_buffer_);
scoped_refptr<ROBuffer> ro_buffer(rw_buffer_->MakeROBufferSnapshot());
scoped_refptr<SharedBuffer> shared_buffer = SharedBuffer::Create();
ROBuffer::Iter it(ro_buffer.get());
do {
shared_buffer->Append(*it);
} while (it.Next());
return shared_buffer;
}
bool ParkableImageImpl::CanParkNow() const {
DCHECK(!is_on_disk());
return !TransientlyUnableToPark() && !is_locked() &&
rw_buffer_->HasNoSnapshots();
}
ParkableImageImpl::ParkableImageImpl(size_t initial_capacity)
: rw_buffer_(std::make_unique<RWBuffer>(initial_capacity)) {}
ParkableImageImpl::~ParkableImageImpl() {
DCHECK(IsMainThread());
DCHECK(!is_locked());
auto& manager = ParkableImageManager::Instance();
if (!is_below_min_parking_size() || !is_frozen())
manager.Remove(this);
DCHECK(!manager.IsRegistered(this));
if (on_disk_metadata_)
manager.data_allocator().Discard(std::move(on_disk_metadata_));
AsanUnpoisonBuffer(rw_buffer_.get());
}
// static
scoped_refptr<ParkableImageImpl> ParkableImageImpl::Create(
size_t initial_capacity) {
return base::MakeRefCounted<ParkableImageImpl>(initial_capacity);
}
void ParkableImageImpl::Freeze() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
base::AutoLock lock(lock_);
DCHECK(!is_frozen());
frozen_time_ = base::TimeTicks::Now();
if (is_below_min_parking_size()) {
ParkableImageManager::Instance().Remove(this);
return;
}
// If we don't have any snapshots of the current data, that means it could be
// parked at any time.
//
// If we have snapshots, we don't want to poison the buffer, because the
// snapshot is allowed to access the buffer's data freely.
if (CanParkNow())
AsanPoisonBuffer(rw_buffer_.get());
}
void ParkableImageImpl::LockData() {
// Calling |Lock| only makes sense if the data is available.
DCHECK(rw_buffer_);
lock_depth_++;
AsanUnpoisonBuffer(rw_buffer_.get());
}
void ParkableImageImpl::UnlockData() {
// Check that we've locked it already.
DCHECK_GT(lock_depth_, 0u);
// While locked, we can never write the data to disk.
DCHECK(!is_on_disk());
lock_depth_--;
// We only poison the buffer if we're able to park after unlocking.
// This is to avoid issues when creating a ROBufferSegmentReader from the
// ParkableImageImpl.
if (CanParkNow())
AsanPoisonBuffer(rw_buffer_.get());
}
// static
void ParkableImageImpl::WriteToDiskInBackground(
scoped_refptr<ParkableImageImpl> parkable_image,
scoped_refptr<base::SingleThreadTaskRunner> callback_task_runner) {
DCHECK(!IsMainThread());
base::AutoLock lock(parkable_image->lock_);
DCHECK(ParkableImageManager::IsParkableImagesToDiskEnabled());
DCHECK(parkable_image);
DCHECK(parkable_image->reserved_chunk_);
DCHECK(!parkable_image->on_disk_metadata_);
AsanUnpoisonBuffer(parkable_image->rw_buffer_.get());
scoped_refptr<ROBuffer> ro_buffer =
parkable_image->rw_buffer_->MakeROBufferSnapshot();
ROBuffer::Iter it(ro_buffer.get());
Vector<char> vector;
vector.ReserveInitialCapacity(
base::checked_cast<wtf_size_t>(parkable_image->size()));
do {
vector.AppendSpan(*it);
} while (it.Next());
auto reserved_chunk = std::move(parkable_image->reserved_chunk_);
// Release the lock while writing, so we don't block for too long.
parkable_image->lock_.Release();
base::ElapsedTimer timer;
auto metadata = ParkableImageManager::Instance().data_allocator().Write(
std::move(reserved_chunk), base::as_byte_span(vector));
base::TimeDelta elapsed = timer.Elapsed();
// Acquire the lock again after writing.
parkable_image->lock_.Acquire();
parkable_image->on_disk_metadata_ = std::move(metadata);
// Nothing to do if the write failed except return. Notably, we need to
// keep around the data for the ParkableImageImpl in this case.
if (!parkable_image->on_disk_metadata_) {
parkable_image->background_task_in_progress_ = false;
// This ensures that we don't destroy |this| on the background thread at
// the end of this function, if we happen to have the last reference to
// |this|.
//
// We cannot simply check the reference count here, since it may be
// changed racily on another thread, so posting a task is the only safe
// way to proceed.
PostCrossThreadTask(*callback_task_runner, FROM_HERE,
CrossThreadBindOnce(&NotifyWriteToDiskFinished,
std::move(parkable_image)));
} else {
RecordWriteStatistics(parkable_image->on_disk_metadata_->size(), elapsed);
ParkableImageManager::Instance().RecordDiskWriteTime(elapsed);
PostCrossThreadTask(
*callback_task_runner, FROM_HERE,
CrossThreadBindOnce(&ParkableImageImpl::MaybeDiscardData,
std::move(parkable_image)));
}
}
void ParkableImageImpl::MaybeDiscardData() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(!is_below_min_parking_size());
base::AutoLock lock(lock_);
DCHECK(on_disk_metadata_);
background_task_in_progress_ = false;
// If the image is now unparkable, we need to keep the data around.
// This can happen if, for example, in between the time we posted the task to
// discard the data and the time MaybeDiscardData is called, we've created a
// SegmentReader from |rw_buffer_|, since discarding the data would leave us
// with a dangling pointer in the SegmentReader.
if (CanParkNow())
DiscardData();
}
void ParkableImageImpl::DiscardData() {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(!is_locked());
AsanUnpoisonBuffer(rw_buffer_.get());
rw_buffer_ = nullptr;
ParkableImageManager::Instance().OnWrittenToDisk(this);
}
bool ParkableImageImpl::TransientlyUnableToPark() const {
if (base::FeatureList::IsEnabled(kDelayParkingImages)) {
// Most images are used only once, for the initial decode at render time.
// Since rendering can happen multiple seconds after the image load (e.g.
// if paint by a synchronous <script> earlier in the document), we instead
// wait up to kParkingDelay before parking an unused image.
return !is_frozen() ||
(base::TimeTicks::Now() - frozen_time_ <= kParkingDelay && !used_);
} else {
return !is_frozen();
}
}
bool ParkableImageImpl::MaybePark(
scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
DCHECK(ParkableImageManager::IsParkableImagesToDiskEnabled());
DCHECK(IsMainThread());
base::AutoLock lock(lock_);
if (background_task_in_progress_)
return true;
if (!CanParkNow())
return false;
if (on_disk_metadata_) {
DiscardData();
return true;
}
auto reserved_chunk =
ParkableImageManager::Instance().data_allocator().TryReserveChunk(size());
if (!reserved_chunk) {
return false;
}
reserved_chunk_ = std::move(reserved_chunk);
background_task_in_progress_ = true;
// The writing is done on a background thread. We pass a TaskRunner from the
// current thread for when we have finished writing.
worker_pool::PostTask(
FROM_HERE, {base::MayBlock()},
CrossThreadBindOnce(&ParkableImageImpl::WriteToDiskInBackground,
scoped_refptr<ParkableImageImpl>(this),
std::move(task_runner)));
return true;
}
// static
size_t ParkableImageImpl::ReadFromDiskIntoBuffer(
DiskDataMetadata* on_disk_metadata,
base::span<uint8_t> buffer) {
size_t size = on_disk_metadata->size();
DCHECK_LE(size, buffer.size());
ParkableImageManager::Instance().data_allocator().Read(*on_disk_metadata,
buffer);
return size;
}
void ParkableImageImpl::Unpark() {
// We mark the ParkableImage as having been read here, since any access to
// its data must first make sure it's not on disk.
used_ = true;
if (!is_on_disk()) {
AsanUnpoisonBuffer(rw_buffer_.get());
return;
}
DCHECK(ParkableImageManager::IsParkableImagesToDiskEnabled());
TRACE_EVENT1("blink", "ParkableImageImpl::Unpark", "size", size());
DCHECK(on_disk_metadata_);
base::ElapsedTimer timer;
DCHECK(!rw_buffer_);
rw_buffer_ = std::make_unique<RWBuffer>(
base::BindOnce(&ParkableImageImpl::ReadFromDiskIntoBuffer,
base::Unretained(on_disk_metadata_.get())),
size());
base::TimeDelta elapsed = timer.Elapsed();
base::TimeDelta time_since_freeze = base::TimeTicks::Now() - frozen_time_;
RecordReadStatistics(on_disk_metadata_->size(), elapsed, time_since_freeze);
ParkableImageManager::Instance().RecordDiskReadTime(elapsed);
ParkableImageManager::Instance().OnReadFromDisk(this);
DCHECK(rw_buffer_);
}
size_t ParkableImageImpl::size() const {
return size_;
}
bool ParkableImageImpl::is_below_min_parking_size() const {
return size() < ParkableImageImpl::kMinSizeToPark;
}
bool ParkableImageImpl::is_locked() const {
return lock_depth_ != 0;
}
ParkableImage::ParkableImage(size_t offset)
: impl_(ParkableImageManager::Instance().CreateParkableImage(offset)) {
ParkableImageManager::Instance().Add(impl_.get());
}
ParkableImage::~ParkableImage() {
ParkableImageManager::Instance().DestroyParkableImage(std::move(impl_));
}
// static
scoped_refptr<ParkableImage> ParkableImage::Create(size_t initial_capacity) {
return base::MakeRefCounted<ParkableImage>(initial_capacity);
}
size_t ParkableImage::size() const {
DCHECK(impl_);
return impl_->size();
}
bool ParkableImage::is_on_disk() const {
DCHECK(impl_);
return impl_->is_on_disk();
}
scoped_refptr<SegmentReader> ParkableImage::MakeROSnapshot() {
DCHECK(impl_);
DCHECK_CALLED_ON_VALID_THREAD(impl_->thread_checker_);
return CreateSegmentReader();
}
void ParkableImage::Freeze() {
DCHECK(impl_);
impl_->Freeze();
}
scoped_refptr<SharedBuffer> ParkableImage::Data() {
DCHECK(impl_);
return impl_->Data();
}
void ParkableImage::Append(WTF::SharedBuffer* buffer, size_t offset) {
DCHECK(impl_);
impl_->Append(buffer, offset);
}
void ParkableImage::LockData() {
DCHECK(impl_);
impl_->LockData();
}
void ParkableImage::UnlockData() {
DCHECK(impl_);
impl_->UnlockData();
}
scoped_refptr<SegmentReader> ParkableImage::CreateSegmentReader() {
return base::MakeRefCounted<ParkableImageSegmentReader>(this);
}
} // namespace blink
|