1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
|
#include "third_party/blink/renderer/platform/p2p/socket_client_impl.h"
#include "base/run_loop.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "net/base/ip_endpoint.h"
#include "services/network/public/cpp/p2p_socket_type.h"
#include "services/network/public/mojom/p2p.mojom-blink-forward.h"
#include "services/network/public/mojom/p2p.mojom.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/renderer/platform/p2p/socket_client_delegate.h"
#include "third_party/blink/renderer/platform/wtf/vector.h"
namespace network {
bool operator==(const P2PSendPacketMetrics& a, const P2PSendPacketMetrics& b) {
return a.packet_id == b.packet_id && a.rtc_packet_id == b.rtc_packet_id &&
a.send_time_ms == b.send_time_ms;
}
} // namespace network
namespace blink {
namespace {
using ::testing::_;
using ::testing::ElementsAre;
using ::testing::Field;
using ::testing::InSequence;
using ::testing::NiceMock;
using ::testing::Pointee;
using ::testing::Return;
using ::testing::SaveArg;
using ::testing::Values;
using ::testing::WithArgs;
class MockSocketService : public network::mojom::blink::P2PSocket {
public:
MOCK_METHOD(void,
Send,
(base::span<const uint8_t>, const network::P2PPacketInfo&),
(override));
MOCK_METHOD(void,
SendBatch,
(WTF::Vector<network::mojom::blink::P2PSendPacketPtr>),
(override));
MOCK_METHOD(void,
SetOption,
(network::P2PSocketOption option, int32_t value),
(override));
};
class MockDelegate : public P2PSocketClientDelegate {
public:
MOCK_METHOD(void,
OnOpen,
(const net::IPEndPoint&, const net::IPEndPoint&),
(override));
MOCK_METHOD(void,
OnSendComplete,
(const network::P2PSendPacketMetrics&),
(override));
MOCK_METHOD(void, OnError, (), (override));
MOCK_METHOD(void,
OnDataReceived,
(const net::IPEndPoint&,
base::span<const uint8_t>,
const base::TimeTicks&,
webrtc::EcnMarking),
(override));
};
class SocketClientImplTestBase {
public:
explicit SocketClientImplTestBase(bool batch_packets)
: client_(batch_packets) {
receiver_.Bind(client_.CreatePendingReceiver());
remote_.Bind(client_.CreatePendingRemote());
client_.Init(&delegate_);
}
virtual ~SocketClientImplTestBase() { client_.Close(); }
void Open() {
ON_CALL(delegate_, OnOpen).WillByDefault(Return());
remote_->SocketCreated(net::IPEndPoint(), net::IPEndPoint());
task_environment_.RunUntilIdle();
}
base::test::SingleThreadTaskEnvironment task_environment_;
MockSocketService socket_;
mojo::Receiver<network::mojom::blink::P2PSocket> receiver_{&socket_};
P2PSocketClientImpl client_;
mojo::Remote<network::mojom::blink::P2PSocketClient> remote_;
NiceMock<MockDelegate> delegate_;
};
class SocketClientImplParametrizedTest : public SocketClientImplTestBase,
public ::testing::TestWithParam<bool> {
public:
SocketClientImplParametrizedTest() : SocketClientImplTestBase(GetParam()) {}
};
TEST_P(SocketClientImplParametrizedTest, OnOpenCalled) {
EXPECT_CALL(delegate_, OnOpen);
remote_->SocketCreated(net::IPEndPoint(), net::IPEndPoint());
task_environment_.RunUntilIdle();
}
TEST_P(SocketClientImplParametrizedTest, OnDataReceivedCalled) {
using network::mojom::blink::P2PReceivedPacket;
using network::mojom::blink::P2PReceivedPacketPtr;
Open();
WTF::Vector<P2PReceivedPacketPtr> packets;
auto first = base::TimeTicks() + base::Microseconds(1);
auto second = base::TimeTicks() + base::Microseconds(2);
auto data = WTF::Vector<uint8_t>(1);
auto ecn = webrtc::EcnMarking::kNotEct;
packets.push_back(
P2PReceivedPacket::New(data, net::IPEndPoint(), first, ecn));
packets.push_back(
P2PReceivedPacket::New(data, net::IPEndPoint(), second, ecn));
InSequence s;
EXPECT_CALL(delegate_, OnDataReceived(_, _, first, ecn));
EXPECT_CALL(delegate_, OnDataReceived(_, _, second, ecn));
remote_->DataReceived(std::move(packets));
task_environment_.RunUntilIdle();
}
TEST_P(SocketClientImplParametrizedTest, OnSendCompleteCalled) {
Open();
EXPECT_CALL(delegate_, OnSendComplete);
remote_->SendComplete(network::P2PSendPacketMetrics());
task_environment_.RunUntilIdle();
}
TEST_P(SocketClientImplParametrizedTest, OnConnectionErrorCalled) {
Open();
EXPECT_CALL(delegate_, OnError);
remote_.reset();
task_environment_.RunUntilIdle();
}
TEST_P(SocketClientImplParametrizedTest, SendsWithIncreasingPacketId) {
Open();
network::P2PPacketInfo first_info;
InSequence s;
EXPECT_CALL(socket_, Send).WillOnce(SaveArg<1>(&first_info));
EXPECT_CALL(socket_, Send)
.WillOnce(WithArgs<1>([&first_info](const network::P2PPacketInfo& info) {
EXPECT_EQ(info.packet_id, first_info.packet_id + 1);
}));
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1),
webrtc::AsyncSocketPacketOptions());
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1),
webrtc::AsyncSocketPacketOptions());
task_environment_.RunUntilIdle();
}
TEST_P(SocketClientImplParametrizedTest, SetsOption) {
Open();
InSequence s;
EXPECT_CALL(socket_,
SetOption(network::P2PSocketOption::P2P_SOCKET_OPT_DSCP, 1));
EXPECT_CALL(socket_,
SetOption(network::P2PSocketOption::P2P_SOCKET_OPT_RCVBUF, 2));
client_.SetOption(network::P2PSocketOption::P2P_SOCKET_OPT_DSCP, 1);
client_.SetOption(network::P2PSocketOption::P2P_SOCKET_OPT_RCVBUF, 2);
task_environment_.RunUntilIdle();
}
TEST_P(SocketClientImplParametrizedTest, OnSendBatchCompleteCalled) {
Open();
network::P2PSendPacketMetrics metrics1 = {0, 1, 2};
network::P2PSendPacketMetrics metrics2 = {0, 1, 2};
InSequence s;
EXPECT_CALL(delegate_, OnSendComplete(metrics1));
EXPECT_CALL(delegate_, OnSendComplete(metrics2));
remote_->SendBatchComplete({metrics1, metrics2});
task_environment_.RunUntilIdle();
}
INSTANTIATE_TEST_SUITE_P(All,
SocketClientImplParametrizedTest,
Values(false, true),
[](const testing::TestParamInfo<bool>& info) {
return info.param ? "WithBatching"
: "WithoutBatching";
});
class SocketClientImplBatchingTest : public SocketClientImplTestBase,
public ::testing::Test {
public:
SocketClientImplBatchingTest()
: SocketClientImplTestBase(/*batch_packets=*/true) {}
};
TEST_F(SocketClientImplBatchingTest, OnePacketBatchUsesSend) {
Open();
EXPECT_CALL(socket_, Send);
webrtc::AsyncSocketPacketOptions options;
options.batchable = true;
options.last_packet_in_batch = true;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), options);
task_environment_.RunUntilIdle();
}
TEST_F(SocketClientImplBatchingTest, TwoPacketBatchUsesSendBatch) {
Open();
webrtc::AsyncSocketPacketOptions options;
options.batchable = true;
options.packet_id = 1;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), options);
EXPECT_CALL(
socket_,
SendBatch(ElementsAre(
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 1)))),
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(
&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 2)))))));
options.last_packet_in_batch = true;
options.packet_id = 2;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), options);
task_environment_.RunUntilIdle();
}
TEST_F(SocketClientImplBatchingTest,
TwoPacketBatchWithNonbatchableInterleavedUsesSendBatch) {
Open();
webrtc::AsyncSocketPacketOptions batchable_options;
batchable_options.batchable = true;
batchable_options.packet_id = 1;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), batchable_options);
webrtc::AsyncSocketPacketOptions interleaved_options; // Not batchable.
interleaved_options.packet_id = 2;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), interleaved_options);
// The expectation is placed after the initial sends to fail the test in case
// the first sends would create a batch.
EXPECT_CALL(
socket_,
SendBatch(ElementsAre(
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 1)))),
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 2)))),
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(
&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 3)))))));
batchable_options.last_packet_in_batch = true;
batchable_options.packet_id = 3;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), batchable_options);
task_environment_.RunUntilIdle();
}
TEST_F(SocketClientImplBatchingTest, PacketBatchCompletedWithFlush) {
Open();
webrtc::AsyncSocketPacketOptions batchable_options;
batchable_options.batchable = true;
batchable_options.packet_id = 1;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), batchable_options);
batchable_options.packet_id = 2;
client_.Send(net::IPEndPoint(), std::vector<uint8_t>(1), batchable_options);
// Expects packets to be sent on FlushBatch.
EXPECT_CALL(
socket_,
SendBatch(ElementsAre(
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 1)))),
Pointee(Field(
&network::mojom::blink::P2PSendPacket::packet_info,
Field(
&network::P2PPacketInfo::packet_options,
Field(&webrtc::AsyncSocketPacketOptions::packet_id, 2)))))));
client_.FlushBatch();
task_environment_.RunUntilIdle();
}
} // namespace
} // namespace blink
|
