1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551
|
/*
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "pc/simulcast_sdp_serializer.h"
#include <stddef.h>
#include <map>
#include <string>
#include <vector>
#include "media/base/codec.h"
#include "media/base/rid_description.h"
#include "pc/session_description.h"
#include "pc/simulcast_description.h"
#include "test/gtest.h"
using ::testing::TestWithParam;
using ::testing::ValuesIn;
using ::webrtc::RidDescription;
using ::webrtc::RidDirection;
using ::webrtc::SimulcastDescription;
using ::webrtc::SimulcastLayer;
using ::webrtc::SimulcastLayerList;
namespace webrtc {
namespace {
// Checks that two vectors have the same objects in the same order.
template <typename TElement>
void ExpectEqual(const std::vector<TElement>& expected,
const std::vector<TElement>& actual) {
ASSERT_EQ(expected.size(), actual.size());
for (size_t i = 0; i < expected.size(); i++) {
EXPECT_EQ(expected[i], actual[i]) << "Vectors differ at element " << i;
}
}
// Template specialization for vectors of SimulcastLayer objects.
template <>
void ExpectEqual(const std::vector<SimulcastLayer>& expected,
const std::vector<SimulcastLayer>& actual) {
EXPECT_EQ(expected.size(), actual.size());
for (size_t i = 0; i < expected.size(); i++) {
EXPECT_EQ(expected[i].rid, actual[i].rid);
EXPECT_EQ(expected[i].is_paused, actual[i].is_paused);
}
}
// Checks that two maps have the same key-value pairs.
// Even though a map is technically ordered, the order semantics are not
// tested because having the same key-set in both maps implies that they
// are ordered the same because the template enforces that they have the
// same Key-Comparer type.
template <typename TKey, typename TValue>
void ExpectEqual(const std::map<TKey, TValue>& expected,
const std::map<TKey, TValue>& actual) {
typedef typename std::map<TKey, TValue>::const_iterator const_iterator;
ASSERT_EQ(expected.size(), actual.size());
// Maps have unique keys, so if size is equal, it is enough to check
// that all the keys (and values) from one map exist in the other.
for (const auto& pair : expected) {
const_iterator iter = actual.find(pair.first);
EXPECT_NE(iter, actual.end()) << "Key: " << pair.first << " not found";
EXPECT_EQ(pair.second, iter->second);
}
}
// Checks that the two SimulcastLayerLists are equal.
void ExpectEqual(const SimulcastLayerList& expected,
const SimulcastLayerList& actual) {
EXPECT_EQ(expected.size(), actual.size());
for (size_t i = 0; i < expected.size(); i++) {
ExpectEqual(expected[i], actual[i]);
}
}
// Checks that the two SimulcastDescriptions are equal.
void ExpectEqual(const SimulcastDescription& expected,
const SimulcastDescription& actual) {
ExpectEqual(expected.send_layers(), actual.send_layers());
ExpectEqual(expected.receive_layers(), actual.receive_layers());
}
// Checks that the two RidDescriptions are equal.
void ExpectEqual(const RidDescription& expected, const RidDescription& actual) {
EXPECT_EQ(expected.rid, actual.rid);
EXPECT_EQ(expected.direction, actual.direction);
ExpectEqual(expected.codecs, actual.codecs);
ExpectEqual(expected.restrictions, actual.restrictions);
}
} // namespace
class SimulcastSdpSerializerTest : public TestWithParam<const char*> {
public:
// Runs a test for deserializing Simulcast.
// `str` - The serialized Simulcast to parse.
// `expected` - The expected output Simulcast to compare to.
void TestDeserialization(const std::string& str,
const SimulcastDescription& expected) const {
SimulcastSdpSerializer deserializer;
auto result = deserializer.DeserializeSimulcastDescription(str);
EXPECT_TRUE(result.ok());
ExpectEqual(expected, result.value());
}
// Runs a test for serializing Simulcast.
// `simulcast` - The Simulcast to serialize.
// `expected` - The expected output string to compare to.
void TestSerialization(const SimulcastDescription& simulcast,
const std::string& expected) const {
SimulcastSdpSerializer serializer;
auto result = serializer.SerializeSimulcastDescription(simulcast);
EXPECT_EQ(expected, result);
}
};
// Test Cases
// Test simple deserialization with no alternative streams.
TEST_F(SimulcastSdpSerializerTest, Deserialize_SimpleCaseNoAlternatives) {
std::string simulcast_str = "send 1;2 recv 3;4";
SimulcastDescription expected;
expected.send_layers().AddLayer(SimulcastLayer("1", false));
expected.send_layers().AddLayer(SimulcastLayer("2", false));
expected.receive_layers().AddLayer(SimulcastLayer("3", false));
expected.receive_layers().AddLayer(SimulcastLayer("4", false));
TestDeserialization(simulcast_str, expected);
}
// Test simulcast deserialization with alternative streams.
TEST_F(SimulcastSdpSerializerTest, Deserialize_SimpleCaseWithAlternatives) {
std::string simulcast_str = "send 1,5;2,6 recv 3,7;4,8";
SimulcastDescription expected;
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("1", false), SimulcastLayer("5", false)});
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", false), SimulcastLayer("6", false)});
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("3", false), SimulcastLayer("7", false)});
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("4", false), SimulcastLayer("8", false)});
TestDeserialization(simulcast_str, expected);
}
// Test simulcast deserialization when only some streams have alternatives.
TEST_F(SimulcastSdpSerializerTest, Deserialize_WithSomeAlternatives) {
std::string simulcast_str = "send 1;2,6 recv 3,7;4";
SimulcastDescription expected;
expected.send_layers().AddLayer(SimulcastLayer("1", false));
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", false), SimulcastLayer("6", false)});
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("3", false), SimulcastLayer("7", false)});
expected.receive_layers().AddLayer(SimulcastLayer("4", false));
TestDeserialization(simulcast_str, expected);
}
// Test simulcast deserialization when only send streams are specified.
TEST_F(SimulcastSdpSerializerTest, Deserialize_OnlySendStreams) {
std::string simulcast_str = "send 1;2,6;3,7;4";
SimulcastDescription expected;
expected.send_layers().AddLayer(SimulcastLayer("1", false));
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", false), SimulcastLayer("6", false)});
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("3", false), SimulcastLayer("7", false)});
expected.send_layers().AddLayer(SimulcastLayer("4", false));
TestDeserialization(simulcast_str, expected);
}
// Test simulcast deserialization when only receive streams are specified.
TEST_F(SimulcastSdpSerializerTest, Deserialize_OnlyReceiveStreams) {
std::string simulcast_str = "recv 1;2,6;3,7;4";
SimulcastDescription expected;
expected.receive_layers().AddLayer(SimulcastLayer("1", false));
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", false), SimulcastLayer("6", false)});
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("3", false), SimulcastLayer("7", false)});
expected.receive_layers().AddLayer(SimulcastLayer("4", false));
TestDeserialization(simulcast_str, expected);
}
// Test simulcast deserialization with receive streams before send streams.
TEST_F(SimulcastSdpSerializerTest, Deserialize_SendReceiveReversed) {
std::string simulcast_str = "recv 1;2,6 send 3,7;4";
SimulcastDescription expected;
expected.receive_layers().AddLayer(SimulcastLayer("1", false));
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", false), SimulcastLayer("6", false)});
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("3", false), SimulcastLayer("7", false)});
expected.send_layers().AddLayer(SimulcastLayer("4", false));
TestDeserialization(simulcast_str, expected);
}
// Test simulcast deserialization with some streams set to paused state.
TEST_F(SimulcastSdpSerializerTest, Deserialize_PausedStreams) {
std::string simulcast_str = "recv 1;~2,6 send 3,7;~4";
SimulcastDescription expected;
expected.receive_layers().AddLayer(SimulcastLayer("1", false));
expected.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", true), SimulcastLayer("6", false)});
expected.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("3", false), SimulcastLayer("7", false)});
expected.send_layers().AddLayer(SimulcastLayer("4", true));
TestDeserialization(simulcast_str, expected);
}
// Parameterized negative test case for deserialization with invalid inputs.
TEST_P(SimulcastSdpSerializerTest, SimulcastDeserializationFailed) {
SimulcastSdpSerializer deserializer;
auto result = deserializer.DeserializeSimulcastDescription(GetParam());
EXPECT_FALSE(result.ok());
}
// The malformed Simulcast inputs to use in the negative test case.
const char* kSimulcastMalformedStrings[] = {
"send ",
"recv ",
"recv 1 send",
"receive 1",
"recv 1;~2,6 recv 3,7;~4",
"send 1;~2,6 send 3,7;~4",
"send ~;~2,6",
"send 1; ;~2,6",
"send 1,;~2,6",
"recv 1 send 2 3",
"",
};
INSTANTIATE_TEST_SUITE_P(SimulcastDeserializationErrors,
SimulcastSdpSerializerTest,
ValuesIn(kSimulcastMalformedStrings));
// Test a simple serialization scenario.
TEST_F(SimulcastSdpSerializerTest, Serialize_SimpleCase) {
SimulcastDescription simulcast;
simulcast.send_layers().AddLayer(SimulcastLayer("1", false));
simulcast.receive_layers().AddLayer(SimulcastLayer("2", false));
TestSerialization(simulcast, "send 1 recv 2");
}
// Test serialization with only send streams.
TEST_F(SimulcastSdpSerializerTest, Serialize_OnlySend) {
SimulcastDescription simulcast;
simulcast.send_layers().AddLayer(SimulcastLayer("1", false));
simulcast.send_layers().AddLayer(SimulcastLayer("2", false));
TestSerialization(simulcast, "send 1;2");
}
// Test serialization with only receive streams
TEST_F(SimulcastSdpSerializerTest, Serialize_OnlyReceive) {
SimulcastDescription simulcast;
simulcast.receive_layers().AddLayer(SimulcastLayer("1", false));
simulcast.receive_layers().AddLayer(SimulcastLayer("2", false));
TestSerialization(simulcast, "recv 1;2");
}
// Test a complex serialization with multiple streams, alternatives and states.
TEST_F(SimulcastSdpSerializerTest, Serialize_ComplexSerialization) {
SimulcastDescription simulcast;
simulcast.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("2", false), SimulcastLayer("1", true)});
simulcast.send_layers().AddLayerWithAlternatives(
{SimulcastLayer("4", false), SimulcastLayer("3", false)});
simulcast.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("6", false), SimulcastLayer("7", false)});
simulcast.receive_layers().AddLayer(SimulcastLayer("8", true));
simulcast.receive_layers().AddLayerWithAlternatives(
{SimulcastLayer("9", false), SimulcastLayer("10", true),
SimulcastLayer("11", false)});
TestSerialization(simulcast, "send 2,~1;4,3 recv 6,7;~8;9,~10,11");
}
class RidDescriptionSdpSerializerTest : public TestWithParam<const char*> {
public:
// Runs a test for deserializing Rid Descriptions.
// `str` - The serialized Rid Description to parse.
// `expected` - The expected output RidDescription to compare to.
void TestDeserialization(const MediaContentDescription& media_desc,
const std::string& str,
const RidDescription& expected) const {
SimulcastSdpSerializer deserializer;
auto result = deserializer.DeserializeRidDescription(media_desc, str);
EXPECT_TRUE(result.ok());
ExpectEqual(expected, result.value());
}
// Runs a test for serializing RidDescriptions.
// `rid_description` - The RidDescription to serialize.
// `expected` - The expected output string to compare to.
void TestSerialization(const MediaContentDescription& media_desc,
const RidDescription& rid_description,
const std::string& expected) const {
SimulcastSdpSerializer serializer;
auto result =
serializer.SerializeRidDescription(media_desc, rid_description);
EXPECT_EQ(expected, result);
}
};
// Test serialization for RidDescription that only specifies send.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_OnlyDirectionSend) {
RidDescription rid_description("1", RidDirection::kSend);
TestSerialization(VideoContentDescription(), rid_description, "1 send");
}
// Test serialization for RidDescription that only specifies receive.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_OnlyDirectionReceive) {
RidDescription rid_description("2", RidDirection::kReceive);
TestSerialization(VideoContentDescription(), rid_description, "2 recv");
}
// Test serialization for RidDescription with format list.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_FormatList) {
Codec vp8 = CreateVideoCodec(101, "VP8");
Codec vp9 = CreateVideoCodec(102, "VP9");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8, vp9});
RidDescription rid_description("3", RidDirection::kSend);
rid_description.codecs = {vp9, vp8};
TestSerialization(video_desc, rid_description, "3 send pt=102,101");
}
// Test serialization for RidDescription with format list.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_FormatListSingleFormat) {
Codec vp8 = CreateVideoCodec(100, "VP8");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8});
RidDescription rid_description("4", RidDirection::kReceive);
rid_description.codecs = {vp8};
TestSerialization(video_desc, rid_description, "4 recv pt=100");
}
// Test serialization for RidDescription with restriction list.
// Note: restriction list will be sorted because it is stored in a map.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_AttributeList) {
RidDescription rid_description("5", RidDirection::kSend);
rid_description.restrictions["max-width"] = "1280";
rid_description.restrictions["max-height"] = "720";
TestSerialization(VideoContentDescription(), rid_description,
"5 send max-height=720;max-width=1280");
}
// Test serialization for RidDescription with format list and attribute list.
// Note: restriction list will be sorted because it is stored in a map.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_FormatAndAttributeList) {
Codec vp8 = CreateVideoCodec(103, "VP8");
Codec vp9 = CreateVideoCodec(104, "VP9");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8, vp9});
RidDescription rid_description("6", RidDirection::kSend);
rid_description.codecs = {vp8, vp9};
rid_description.restrictions["max-mbps"] = "108000";
rid_description.restrictions["max-br"] = "64000";
TestSerialization(video_desc, rid_description,
"6 send pt=103,104;max-br=64000;max-mbps=108000");
}
// Test serialization for attribute list that has key with no value.
// Note: restriction list will be sorted because it is stored in a map.
TEST_F(RidDescriptionSdpSerializerTest, Serialize_RestrictionWithoutValue) {
Codec vp8 = CreateVideoCodec(103, "VP8");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8});
RidDescription rid_description("7", RidDirection::kReceive);
rid_description.codecs = {vp8};
rid_description.restrictions["max-width"] = "1280";
rid_description.restrictions["max-height"] = "720";
rid_description.restrictions["max-myval"] = "";
TestSerialization(video_desc, rid_description,
"7 recv pt=103;max-height=720;max-myval;max-width=1280");
}
// Test simulcast deserialization with simple send stream.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_SimpleSendCase) {
RidDescription rid_description("1", RidDirection::kSend);
TestDeserialization(VideoContentDescription(), "1 send", rid_description);
}
// Test simulcast deserialization with simple receive stream.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_SimpleReceiveCase) {
RidDescription rid_description("2", RidDirection::kReceive);
TestDeserialization(VideoContentDescription(), "2 recv", rid_description);
}
// Test simulcast deserialization with single format.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_WithFormat) {
Codec vp8 = CreateVideoCodec(101, "VP8");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8});
RidDescription rid_description("3", RidDirection::kSend);
rid_description.codecs = {vp8};
TestDeserialization(video_desc, "3 send pt=101", rid_description);
}
// Test simulcast deserialization with valid format syntax (`pt=97`) but using
// a payload type that does not refer to any codec in the media description.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_ReferencingUnknownCodec) {
Codec vp8 = CreateVideoCodec(101, "VP8");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8});
RidDescription rid_description("3", RidDirection::kSend);
rid_description.codecs = {}; // pt=97 is ignored resulting in an empty list.
TestDeserialization(video_desc, "3 send pt=97", rid_description);
}
// Test simulcast deserialization with multiple formats.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_WithMultipleFormats) {
Codec vp8 = CreateVideoCodec(101, "VP8");
Codec vp9 = CreateVideoCodec(102, "VP9");
Codec av1 = CreateVideoCodec(103, "AV1");
Codec h264 = CreateVideoCodec(104, "H264");
VideoContentDescription video_desc;
video_desc.set_codecs({vp8, vp9, av1, h264});
RidDescription rid_description("4", RidDirection::kSend);
rid_description.codecs = {av1, h264, vp8, vp9};
TestDeserialization(video_desc, "4 send pt=103,104,101,102", rid_description);
}
// Test simulcast deserialization with restriction.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_WithRestriction) {
RidDescription rid_description("5", RidDirection::kReceive);
rid_description.restrictions["max-height"] = "720";
TestDeserialization(VideoContentDescription(), "5 recv max-height=720",
rid_description);
}
// Test simulcast deserialization with multiple restrictions.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_WithMultipleRestrictions) {
RidDescription rid_description("6", RidDirection::kReceive);
rid_description.restrictions["max-height"] = "720";
rid_description.restrictions["max-width"] = "1920";
rid_description.restrictions["max-fr"] = "60";
rid_description.restrictions["max-bps"] = "14000";
TestDeserialization(
VideoContentDescription(),
"6 recv max-height=720;max-width=1920;max-bps=14000;max-fr=60",
rid_description);
}
// Test simulcast deserialization with custom (non-standard) restriction.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_WithCustomRestrictions) {
RidDescription rid_description("7", RidDirection::kSend);
rid_description.restrictions["foo"] = "bar";
rid_description.restrictions["max-height"] = "720";
TestDeserialization(VideoContentDescription(),
"7 send max-height=720;foo=bar", rid_description);
}
// Test simulcast deserialization with multiple formats and restrictions.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_WithFormatAndRestrictions) {
Codec av1 = CreateVideoCodec(103, "AV1");
Codec h264 = CreateVideoCodec(104, "H264");
VideoContentDescription video_desc;
video_desc.set_codecs({av1, h264});
RidDescription rid_description("8", RidDirection::kSend);
rid_description.codecs = {h264, av1};
rid_description.restrictions["max-height"] = "720";
rid_description.restrictions["max-width"] = "1920";
TestDeserialization(video_desc,
"8 send pt=104,103;max-height=720;max-width=1920",
rid_description);
}
// Test simulcast deserialization with restriction that has no value.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_RestrictionHasNoValue) {
Codec h264 = CreateVideoCodec(104, "H264");
VideoContentDescription video_desc;
video_desc.set_codecs({h264});
RidDescription rid_description("9", RidDirection::kReceive);
rid_description.codecs = {h264};
rid_description.restrictions["max-height"];
rid_description.restrictions["max-width"] = "1920";
TestDeserialization(video_desc, "9 recv pt=104;max-height;max-width=1920",
rid_description);
}
// Add this test to explicitly indicate that this is not an error.
// The following string "1 send recv" looks malformed because it specifies
// two directions, but in fact, the recv can be interpreted as a parameter
// without a value. While such a use case is dubious, the input string is
// not malformed.
TEST_F(RidDescriptionSdpSerializerTest, Deserialize_AmbiguousCase) {
RidDescription rid_description("1", RidDirection::kSend);
rid_description.restrictions["recv"]; // No value.
TestDeserialization(VideoContentDescription(), "1 send recv",
rid_description);
}
// Parameterized negative test case for deserialization with invalid inputs.
TEST_P(RidDescriptionSdpSerializerTest, RidDescriptionDeserializationFailed) {
VideoContentDescription video_desc;
video_desc.set_codecs(
{CreateVideoCodec(101, "VP8"), CreateVideoCodec(102, "VP9")});
SimulcastSdpSerializer deserializer;
auto result = deserializer.DeserializeRidDescription(video_desc, GetParam());
EXPECT_FALSE(result.ok());
}
// The malformed Rid Description inputs to use in the negative test case.
const char* kRidDescriptionMalformedStrings[] = {
"1",
"recv",
"send",
"recv 1",
"send 1",
"1 receive",
"one direction",
"1 send pt=1 max-width=720", // The ' ' should be ';' in restriction list.
"1 recv ;",
"1 recv =",
"1 recv a=b=c",
"1 send max-width=720;pt=101", // pt= should appear first.
"1 send pt=101;pt=102",
"1 send pt=101,101",
"1 recv max-width=720;max-width=720",
"1 send pt=",
"1 send pt=abc",
"1 recv ;;",
"~1 recv",
"1$2 send",
"1=2 send",
"1* send",
};
INSTANTIATE_TEST_SUITE_P(RidDescriptionDeserializationErrors,
RidDescriptionSdpSerializerTest,
ValuesIn(kRidDescriptionMalformedStrings));
} // namespace webrtc
|