1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h"
#include <stddef.h>
#include <algorithm>
#include <cstring>
#include <memory>
#include <string>
#include <utility>
#include <vector>
#include "base/compiler_specific.h"
#include "base/containers/contains.h"
#include "base/containers/flat_map.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "base/metrics/histogram_functions.h"
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h"
#include "base/trace_event/trace_event.h"
#include "ui/display/display_features.h"
#include "ui/display/types/display_configuration_params.h"
#include "ui/display/types/display_mode.h"
#include "ui/display/types/display_snapshot.h"
#include "ui/display/types/gamma_ramp_rgb_entry.h"
#include "ui/ozone/platform/drm/common/drm_util.h"
#include "ui/ozone/platform/drm/common/hardware_display_controller_info.h"
#include "ui/ozone/platform/drm/gpu/drm_device.h"
#include "ui/ozone/platform/drm/gpu/drm_device_manager.h"
#include "ui/ozone/platform/drm/gpu/drm_display.h"
#include "ui/ozone/platform/drm/gpu/drm_gpu_util.h"
#include "ui/ozone/platform/drm/gpu/hardware_display_controller.h"
#include "ui/ozone/platform/drm/gpu/screen_manager.h"
namespace ui {
namespace {
constexpr char kMultipleDisplayIdsCollisionDetected[] =
"Display.MultipleDisplays.GenerateId.CollisionDetection";
// A list of property names that are blocked from issuing a full display
// configuration (modeset) via a udev display CHANGE event.
const char* kBlockedEventsByTriggerProperty[] = {"Content Protection"};
struct DrmDisplayParams {
scoped_refptr<DrmDevice> drm;
std::unique_ptr<HardwareDisplayControllerInfo> display_info;
raw_ptr<display::DisplaySnapshot> snapshot;
};
// These values are persisted to logs. Entries should not be renumbered and
// numeric values should never be reused.
enum class TestOnlyModesetOutcome {
kSuccess = 0,
kFallbackSuccess = 1,
kFailure = 2,
kMaxValue = kFailure,
};
using CrtcConnectorPairTileLocations = std::vector<
std::pair<CrtcConnectorPair, std::optional<gfx::Point> /*tile_location*/>>;
CrtcConnectorPairTileLocations CreateCrtcConnectorPairTileLocationsForDisplay(
const DrmDisplay& display) {
CrtcConnectorPairTileLocations crtc_connector_pairs;
for (const DrmDisplay::CrtcConnectorPair& crtc_connector_pair :
display.crtc_connector_pairs()) {
crtc_connector_pairs.push_back(
{{.crtc_id = crtc_connector_pair.crtc_id,
.connector_id = crtc_connector_pair.connector->connector_id},
crtc_connector_pair.tile_location});
}
return crtc_connector_pairs;
}
class DisplayComparator {
public:
explicit DisplayComparator(const DrmDisplay* display) : drm_(display->drm()) {
crtc_connector_pair_tile_locations_ =
CreateCrtcConnectorPairTileLocationsForDisplay(*display);
}
DisplayComparator(const scoped_refptr<DrmDevice>& drm,
const HardwareDisplayControllerInfo& display_info)
: drm_(drm) {
CrtcConnectorPair primary_crtc_connector{
.crtc_id = display_info.crtc()->crtc_id,
.connector_id = display_info.connector()->connector_id};
std::optional<gfx::Point> primary_tile_location;
const std::optional<TileProperty>& primary_tile_property =
display_info.tile_property();
if (primary_tile_property.has_value()) {
tile_group_id_ = std::optional<int>(primary_tile_property->group_id);
primary_tile_location = primary_tile_property->location;
}
crtc_connector_pair_tile_locations_.push_back(
{primary_crtc_connector, primary_tile_location});
for (const std::unique_ptr<HardwareDisplayControllerInfo>& nonprimary_tile :
display_info.nonprimary_tile_infos()) {
CrtcConnectorPair crtc_connector_pair{
.crtc_id = nonprimary_tile->crtc()->crtc_id,
.connector_id = nonprimary_tile->connector()->connector_id};
crtc_connector_pair_tile_locations_.push_back(
{crtc_connector_pair, nonprimary_tile->tile_property()->location});
}
}
bool operator()(const std::unique_ptr<DrmDisplay>& other) const {
if (drm_ != other->drm()) {
return false;
}
const std::optional<TileProperty>& other_tile_property =
other->GetTileProperty();
std::optional<int> other_tile_group_id =
other_tile_property.has_value() ? other_tile_property->group_id
: std::optional<int>(std::nullopt);
if (tile_group_id_ != other_tile_group_id) {
return false;
}
// Check that |crtc_connector_pair_tile_locations_| is unordered equal to
// CrtcConnectorPairs in |other| DrmDisplay.
CrtcConnectorPairTileLocations other_crtc_connector_tile_locations =
CreateCrtcConnectorPairTileLocationsForDisplay(*other);
return std::is_permutation(
crtc_connector_pair_tile_locations_.begin(),
crtc_connector_pair_tile_locations_.end(),
other_crtc_connector_tile_locations.begin(),
[](const std::pair<CrtcConnectorPair, std::optional<gfx::Point>>& lhs,
const std::pair<CrtcConnectorPair, std::optional<gfx::Point>>& rhs) {
return (lhs.first.crtc_id == rhs.first.crtc_id) &&
(lhs.first.connector_id == rhs.first.connector_id) &&
(lhs.second == rhs.second);
});
}
private:
scoped_refptr<DrmDevice> drm_;
CrtcConnectorPairTileLocations crtc_connector_pair_tile_locations_;
std::optional<int> tile_group_id_;
};
bool MatchMode(const display::DisplayMode& display_mode,
const drmModeModeInfo& m) {
return display_mode.size() == ModeSize(m) &&
display_mode.refresh_rate() == ModeRefreshRate(m) &&
display_mode.is_interlaced() == ModeIsInterlaced(m);
}
// Finds all modes from |modes| that match the size and timing specified by
// |request_mode| and returns a vector of pointers thereto.
std::vector<const drmModeModeInfo*> FindMatchingModes(
const display::DisplayMode& request_mode,
const std::vector<drmModeModeInfo>& modes) {
std::vector<const drmModeModeInfo*> matches;
for (const drmModeModeInfo& m : modes) {
if (MatchMode(request_mode, m)) {
matches.push_back(&m);
}
}
return matches;
}
// Finds and returns the drm mode from |display| matching |request_mode| except
// with the closest (or greater) refresh rate, or nullptr if no such mode
// exists. If |is_seamless| is set, only modes which pass seamless verification
// will be considered.
const drmModeModeInfo* FindClosestModeWithGreaterRefreshRate(
const display::DisplayMode& request_mode,
const DrmDisplay& display,
bool is_seamless,
HardwareDisplayController* controller) {
if (!display.IsVrrCapable()) {
return nullptr;
}
if (is_seamless && !controller) {
LOG(ERROR) << "Could not find HardwareDisplayController for display_id: "
<< display.display_id()
<< " required to perform seamless verification.";
return nullptr;
}
const drmModeModeInfo* closest_mode = nullptr;
for (const auto& m : display.modes()) {
if (request_mode.size() != ModeSize(m) ||
request_mode.is_interlaced() != ModeIsInterlaced(m)) {
continue;
}
if (request_mode.refresh_rate() <
ModeVSyncRateMin(m, display.vsync_rate_min_from_edid())) {
continue;
}
if (is_seamless &&
!controller->TestSeamlessMode(display.GetPrimaryCrtcId(), m)) {
continue;
}
if (ModeRefreshRate(m) >= request_mode.refresh_rate() &&
(!closest_mode ||
ModeRefreshRate(m) < ModeRefreshRate(*closest_mode))) {
closest_mode = &m;
}
}
return closest_mode;
}
std::string GetEventPropertyByKey(const std::string& key,
const EventPropertyMap event_props) {
const auto it = event_props.find(key);
if (it == event_props.end())
return std::string();
return std::string(it->second);
}
ControllerConfigParams* FindConfigParamsForConnector(
std::vector<ControllerConfigParams>& config_list,
uint32_t connector_id) {
for (auto& config : config_list) {
if (config.connector == connector_id) {
return &config;
}
}
return nullptr;
}
std::string ConfigRequestToString(
const std::vector<display::DisplayConfigurationParams>& config_requests) {
std::string signature;
for (const auto& config : config_requests) {
if (config.id <= 0) {
LOG(WARNING) << __func__
<< ": potentially invalid display ID: " << config.id;
}
signature += base::NumberToString(config.id) + ":" +
config.origin.ToString() + ":" +
(config.mode ? config.mode->ToString() : "Disabled") + ":" +
(config.enable_vrr ? "vrr" : "no_vrr") + ";";
}
if (signature.empty()) {
LOG(WARNING) << __func__ << ": empty return value with request of size: "
<< config_requests.size();
}
return signature;
}
TestOnlyModesetOutcome GetTestOnlyModesetOutcome(
bool config_success,
bool did_test_modeset_with_fallback) {
if (!config_success) {
return TestOnlyModesetOutcome::kFailure;
}
return did_test_modeset_with_fallback
? TestOnlyModesetOutcome::kFallbackSuccess
: TestOnlyModesetOutcome::kSuccess;
}
std::string NumDisplaysToHistogramString(int num_displays) {
DCHECK(num_displays >= 0)
<< __func__ << ": " << num_displays << " displays detected.";
switch (num_displays) {
case 1:
return "OneDisplay";
case 2:
return "TwoDisplays";
case 3:
return "ThreeDisplays";
default:
return "FourOrMoreDisplays";
}
}
std::string GetNumFallbackHistogramName(int num_displays) {
return base::StrCat({"ConfigureDisplays.Modeset.Test.DynamicCRTCs.",
NumDisplaysToHistogramString(num_displays),
".PermutationsAttempted"});
}
std::string GetTestOnlyModesetOutcomeName(int num_displays) {
return base::StrCat({"ConfigureDisplays.Modeset.Test.",
NumDisplaysToHistogramString(num_displays), ".Outcome"});
}
} // namespace
DrmGpuDisplayManager::DrmGpuDisplayManager(ScreenManager* screen_manager,
DrmDeviceManager* drm_device_manager)
: screen_manager_(screen_manager),
drm_device_manager_(drm_device_manager) {}
DrmGpuDisplayManager::~DrmGpuDisplayManager() = default;
void DrmGpuDisplayManager::SetDisplaysConfiguredCallback(
base::RepeatingClosure callback) {
displays_configured_callback_ = std::move(callback);
}
MovableDisplaySnapshots DrmGpuDisplayManager::GetDisplays() {
successful_test_config_params_.clear();
std::vector<std::unique_ptr<DrmDisplay>> old_displays;
old_displays.swap(displays_);
std::vector<DrmDisplayParams> displays_to_create;
MovableDisplaySnapshots display_snapshots;
const DrmDeviceVector& devices = drm_device_manager_->GetDrmDevices();
size_t device_index = 0;
MapEdidIdToDisplaySnapshot edid_id_collision_map;
bool collision_detected = false;
for (const auto& drm : devices) {
if (device_index >= kMaxDrmCount) {
LOG(WARNING) << "Reached the current limit of " << kMaxDrmCount
<< " connected DRM devices. Ignoring the remaining "
<< devices.size() - kMaxDrmCount << " connected devices.";
break;
}
// Receiving a signal that DRM state was updated. Need to reset the plane
// manager's resource cache since IDs may have changed.
base::flat_set<uint32_t> valid_connector_ids =
drm->plane_manager()->ResetConnectorsCacheAndGetValidIds(
drm->GetResources());
// TODO: b/327011965 - Move assigning CRTCs to connectors from
// RefreshNativeDisplays() to before test modeset.
// Create new DisplaySnapshots and resolve display ID collisions.
auto display_infos = GetDisplayInfosAndUpdateCrtcs(*drm);
// Make sure that the display infos we got have valid connector IDs.
// If not, we need to remove the display info from the list. This removes
// any zombie connectors.
std::erase_if(
display_infos, [&valid_connector_ids](const auto& display_info) {
return !base::Contains(valid_connector_ids,
display_info->connector()->connector_id);
});
// Consolidate all display infos that belong to the same tiled display into
// one.
ConsolidateTiledDisplayInfo(display_infos);
for (auto& display_info : display_infos) {
display_snapshots.emplace_back(CreateDisplaySnapshot(
*drm, display_info.get(), static_cast<uint8_t>(device_index)));
display::DisplaySnapshot* current_display_snapshot =
display_snapshots.back().get();
const auto colliding_display_snapshot_iter = edid_id_collision_map.find(
current_display_snapshot->edid_display_id());
if (colliding_display_snapshot_iter != edid_id_collision_map.end()) {
collision_detected = true;
current_display_snapshot->AddIndexToDisplayId();
display::DisplaySnapshot* colliding_display_snapshot =
colliding_display_snapshot_iter->second;
colliding_display_snapshot->AddIndexToDisplayId();
edid_id_collision_map[colliding_display_snapshot->edid_display_id()] =
colliding_display_snapshot;
}
edid_id_collision_map[current_display_snapshot->edid_display_id()] =
current_display_snapshot;
// Ownership of |display_info| is handed over.
displays_to_create.push_back(
{drm, std::move(display_info), current_display_snapshot});
}
device_index++;
}
// Create a new DrmDisplay with each of the corresponding display info and
// display snapshot. Note: do not use |display_infos| beyond this point,
// since some of the objects' internal references will be surrendered.
for (const DrmDisplayParams& params : displays_to_create) {
// If the DrmDisplay was present previously, copy its origin to the
// corresponding DisplaySnapshot before creating a new DrmDisplay.
auto old_drm_display_it = std::ranges::find_if(
old_displays, DisplayComparator(params.drm, *params.display_info));
if (old_drm_display_it != old_displays.end()) {
params.snapshot->set_origin(old_drm_display_it->get()->origin());
old_displays.erase(old_drm_display_it);
}
displays_.emplace_back(std::make_unique<DrmDisplay>(
params.drm, params.display_info.get(), *params.snapshot));
}
const bool multiple_connected_displays = display_snapshots.size() > 1;
if (multiple_connected_displays) {
base::UmaHistogramBoolean(kMultipleDisplayIdsCollisionDetected,
collision_detected);
}
NotifyScreenManager(displays_, old_displays);
return display_snapshots;
}
bool DrmGpuDisplayManager::TakeDisplayControl() {
const DrmDeviceVector& devices = drm_device_manager_->GetDrmDevices();
bool status = true;
for (const auto& drm : devices) {
const bool set_master_status = drm->SetMaster();
if (!set_master_status) {
LOG(ERROR) << __func__ << "Drm set master failed for: " // nocheck
<< drm->device_path().value();
}
status &= set_master_status;
}
// Roll-back any successful operation.
if (!status) {
LOG(ERROR) << "Failed to take control of the display";
RelinquishDisplayControl();
}
return status;
}
void DrmGpuDisplayManager::RelinquishDisplayControl() {
const bool detach_planes_before_dropping =
display::features::IsFastDrmMasterDropEnabled();
if (detach_planes_before_dropping &&
!screen_manager_->DetachPlanesFromAllControllers()) {
LOG(ERROR) << __func__
<< ": unable to detach planes from all enabled controllers.";
return;
}
const DrmDeviceVector& devices = drm_device_manager_->GetDrmDevices();
for (const auto& drm : devices) {
if (!drm->DropMaster()) {
LOG(ERROR) << __func__ << "Drm drop master failed for: " // nocheck
<< drm->device_path().value();
}
}
// Dissociate controllers from windows so that subsequent pageflips fail
// early. The only way to re-establish the mapping is to re-take DRM master
// and do a new configuration.
if (detach_planes_before_dropping) {
screen_manager_->UpdateControllerToWindowMapping();
}
}
bool DrmGpuDisplayManager::ShouldDisplayEventTriggerConfiguration(
const EventPropertyMap& event_props) {
DCHECK(!event_props.empty());
const std::string event_seq_num =
GetEventPropertyByKey("SEQNUM", event_props);
std::string log_prefix =
"Display event CHANGE" +
(event_seq_num.empty() ? "" : "(SEQNUM:" + event_seq_num + ") ");
std::string trigger_prop_log;
const std::string event_dev_path =
GetEventPropertyByKey("DEVPATH", event_props);
const DrmDeviceVector& devices = drm_device_manager_->GetDrmDevices();
for (const auto& drm : devices) {
if (drm->device_path().value().find(event_dev_path) == std::string::npos)
continue;
// Get the connector's ID and convert it to an int.
const std::string connector_id_str =
GetEventPropertyByKey("CONNECTOR", event_props);
if (connector_id_str.empty()) {
break;
}
uint32_t connector_id;
{
const bool conversion_success =
base::StringToUint(connector_id_str, &connector_id);
DCHECK(conversion_success);
}
// Get the trigger property's ID and convert to an int.
const std::string trigger_prop_id_str =
GetEventPropertyByKey("PROPERTY", event_props);
if (trigger_prop_id_str.empty())
break;
uint32_t trigger_prop_id;
{
const bool conversion_success =
base::StringToUint(trigger_prop_id_str, &trigger_prop_id);
DCHECK(conversion_success);
}
ScopedDrmObjectPropertyPtr property_values(
drm->GetObjectProperties(connector_id, DRM_MODE_OBJECT_CONNECTOR));
DCHECK(property_values);
// Fetch the name of the property from the device.
ScopedDrmPropertyPtr drm_property(drm->GetProperty(trigger_prop_id));
DCHECK(drm_property);
const std::string enum_value =
GetEnumNameForProperty(*drm_property, *property_values);
DCHECK(!enum_value.empty());
trigger_prop_log =
"[CONNECTOR:" + connector_id_str +
"] trigger property: " + std::string(drm_property->name) + "=" +
enum_value + ", ";
for (const char* blocked_prop : kBlockedEventsByTriggerProperty) {
if (UNSAFE_TODO(strcmp(drm_property->name, blocked_prop)) == 0) {
VLOG(1) << log_prefix << trigger_prop_log
<< "resolution: blocked; display configuration task "
"rejected.";
return false;
}
}
}
VLOG(1) << log_prefix << trigger_prop_log
<< "resolution: allowed; display configuration task triggered.";
return true;
}
bool DrmGpuDisplayManager::ConfigureDisplays(
const std::vector<display::DisplayConfigurationParams>& config_requests,
display::ModesetFlags modeset_flags,
std::vector<display::DisplayConfigurationParams>& out_requests) {
const bool is_commit =
modeset_flags.Has(display::ModesetFlag::kCommitModeset);
const bool is_seamless =
modeset_flags.Has(display::ModesetFlag::kSeamlessModeset);
std::vector<ControllerConfigParams> controllers_to_configure;
if (is_commit) {
controllers_to_configure = GetLatestModesetTestConfig(config_requests);
}
out_requests.clear();
if (controllers_to_configure.empty()) {
for (const auto& request : config_requests) {
int64_t display_id = request.id;
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID "
<< display_id;
out_requests = config_requests;
return false;
}
std::unique_ptr<drmModeModeInfo> found_mode = nullptr;
if (request.mode) {
found_mode = FindModeForDisplay(*request.mode, *display, is_seamless);
if (!found_mode) {
out_requests = config_requests;
return false;
}
// Populate |out_requests| with a new request which holds an updated
// DisplayMode that precisely matches the found drm mode.
std::unique_ptr<display::DisplayMode> out_mode =
CreateDisplayMode(*found_mode, display->vsync_rate_min_from_edid());
// For a tiled display, Ozone must always expose the tiled-composited
// mode size, rather than the tiled mode size from the tiled connector.
const std::optional<TileProperty>& tile_property =
display->GetTileProperty();
if (tile_property.has_value() &&
IsTileMode(out_mode->size(), *tile_property)) {
out_mode =
out_mode->CopyWithSize(GetTotalTileDisplaySize(*tile_property));
}
out_requests.emplace_back(request.id, request.origin, out_mode.get(),
request.enable_vrr);
} else {
out_requests.emplace_back(request);
}
scoped_refptr<DrmDevice> drm = display->drm();
ControllerConfigParams params(
display->display_id(), drm, display->GetPrimaryCrtcId(),
display->GetPrimaryConnectorId(), request.origin,
std::move(found_mode), request.enable_vrr,
display->base_connector_id());
controllers_to_configure.push_back(std::move(params));
}
}
bool config_success = screen_manager_->ConfigureDisplayControllers(
controllers_to_configure, modeset_flags);
// Only attempt to fallback on using different CRTC-connector pairings if
// hardware mirroring is disabled as hardware mirroring has multiple
// connectors assigned to one CRTC, and the fallback assumes 1:1 pairing.
const bool should_try_test_fallback =
!is_commit && !config_success &&
!display::features::IsHardwareMirrorModeEnabled();
bool did_test_modeset_with_fallback = false;
if (should_try_test_fallback) {
did_test_modeset_with_fallback = true;
config_success = RetryTestConfigureDisplaysWithAlternateCrtcs(
config_requests, controllers_to_configure);
}
if (displays_configured_callback_)
displays_configured_callback_.Run();
if (is_commit) {
successful_test_config_params_.clear();
if (config_success) {
for (const auto& controller : controllers_to_configure) {
FindDisplay(controller.display_id)->SetOrigin(controller.origin);
}
}
} else {
const std::string test_modest_outcome_histogram =
GetTestOnlyModesetOutcomeName(config_requests.size());
const TestOnlyModesetOutcome test_modeset_outcome =
GetTestOnlyModesetOutcome(config_success,
did_test_modeset_with_fallback);
base::UmaHistogramEnumeration(test_modest_outcome_histogram,
test_modeset_outcome);
}
return config_success;
}
bool DrmGpuDisplayManager::SetHdcpKeyProp(int64_t display_id,
const std::string& key) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(ERROR) << "SetHdcpKeyProp: There is no display with ID " << display_id;
return false;
}
return display->SetHdcpKeyProp(key);
}
bool DrmGpuDisplayManager::GetHDCPState(
int64_t display_id,
display::HDCPState* state,
display::ContentProtectionMethod* protection_method) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return false;
}
return display->GetHDCPState(state, protection_method);
}
bool DrmGpuDisplayManager::SetHDCPState(
int64_t display_id,
display::HDCPState state,
display::ContentProtectionMethod protection_method) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return false;
}
return display->SetHDCPState(state, protection_method);
}
void DrmGpuDisplayManager::SetColorTemperatureAdjustment(
int64_t display_id,
const display::ColorTemperatureAdjustment& cta) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return;
}
display->SetColorTemperatureAdjustment(cta);
}
void DrmGpuDisplayManager::SetColorCalibration(
int64_t display_id,
const display::ColorCalibration& calibration) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return;
}
display->SetColorCalibration(calibration);
}
void DrmGpuDisplayManager::SetGammaAdjustment(
int64_t display_id,
const display::GammaAdjustment& adjustment) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return;
}
display->SetGammaAdjustment(adjustment);
}
void DrmGpuDisplayManager::SetBackgroundColor(int64_t display_id,
const uint64_t background_color) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID" << display_id;
return;
}
display->SetBackgroundColor(background_color);
}
bool DrmGpuDisplayManager::SetPrivacyScreen(int64_t display_id, bool enabled) {
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return false;
}
return display->SetPrivacyScreen(enabled);
}
std::optional<std::vector<float>> DrmGpuDisplayManager::GetSeamlessRefreshRates(
int64_t display_id) const {
TRACE_EVENT1("drm", "DrmGpuDisplayManager::GetSeamlessRefreshRates",
"display_id", display_id);
DrmDisplay* display = FindDisplay(display_id);
if (!display) {
LOG(WARNING) << __func__ << ": there is no display with ID " << display_id;
return std::nullopt;
}
HardwareDisplayController* controller = screen_manager_->GetDisplayController(
display->drm(), display->GetPrimaryCrtcId());
if (!controller) {
LOG(ERROR) << "Could not find HardwareDisplayController for display_id: "
<< display_id;
return std::nullopt;
}
// TODO: b/323362145: Support continuity logic.
const gfx::Size current_mode_size = controller->GetModeSize();
std::vector<float> rates;
for (const drmModeModeInfo& mode : display->modes()) {
if (ui::ModeSize(mode) != current_mode_size) {
continue;
}
// Do a test commit to check if this mode can be configured without
// a modeset.
if (controller->TestSeamlessMode(display->GetPrimaryCrtcId(), mode)) {
rates.push_back(ModeRefreshRate(mode));
}
}
return rates;
}
DrmDisplay* DrmGpuDisplayManager::FindDisplay(int64_t display_id) const {
for (const auto& display : displays_) {
if (display->display_id() == display_id)
return display.get();
}
return nullptr;
}
DrmDisplay* DrmGpuDisplayManager::FindDisplayByConnectorId(
uint32_t connector_id) const {
for (const auto& display : displays_) {
if (display->GetCrtcConnectorPairForConnectorId(connector_id) != nullptr) {
return display.get();
}
}
return nullptr;
}
void DrmGpuDisplayManager::NotifyScreenManager(
const std::vector<std::unique_ptr<DrmDisplay>>& new_displays,
const std::vector<std::unique_ptr<DrmDisplay>>& old_displays) const {
ScreenManager::CrtcsWithDrmList controllers_to_remove;
for (const auto& old_display : old_displays) {
if (std::ranges::none_of(new_displays,
DisplayComparator(old_display.get()))) {
for (const auto& crtc_connector_pair :
old_display->crtc_connector_pairs()) {
controllers_to_remove.emplace_back(crtc_connector_pair.crtc_id,
old_display->drm());
}
}
}
if (!controllers_to_remove.empty())
screen_manager_->RemoveDisplayControllers(controllers_to_remove);
for (const auto& new_display : new_displays) {
if (std::ranges::none_of(old_displays,
DisplayComparator(new_display.get()))) {
screen_manager_->AddDisplayControllersForDisplay(*new_display);
}
}
}
// TODO: b/327015722 - Move test modeset fallback with alternate CRTCs
// from DrmGpuDisplayManager to ScreenManager.
// The kernel can sometimes silently reallocate the resources of one CRTC to
// another, making the other ineffective. One such case is when i915's Bigjoiner
// takes the underlying pipe of a secondary CRTC for high bandwidth displays
// (DP 2.1+). Attempting modeset with a stolen CRTC will result in failure. The
// only way for userspace to overcome a stolen CRTC is to dynamically assign
// other CRTC configurations via test modesets.
bool DrmGpuDisplayManager::RetryTestConfigureDisplaysWithAlternateCrtcs(
const std::vector<display::DisplayConfigurationParams>& config_requests,
const std::vector<ControllerConfigParams>& controllers_to_configure) {
// Separate individual params of |controllers_to_configure| into multiple
// std::vector<ControllerConfigParams> by their DrmDevice.
base::flat_map<scoped_refptr<DrmDevice>, std::vector<ControllerConfigParams>>
drm_device_controllers_to_configure;
for (const auto& config : controllers_to_configure) {
scoped_refptr<DrmDevice> drm = config.drm;
drm_device_controllers_to_configure[drm].emplace_back(config);
}
// For each DrmDevice, try test modeset with all possible CRTC-connector
// combinations. Use the first successful one.
int num_permutations_attempted = 0;
bool fallback_successful_for_all_devices = true;
std::vector<ControllerConfigParams> successful_config_list;
for (auto& [drm, configs_list] : drm_device_controllers_to_configure) {
std::vector<CrtcConnectorPairs> crtc_connector_permutations =
GetAllCrtcConnectorPermutations(*drm, configs_list);
VLOG(1) << "Number of possible fallback CRTC-connector permutations: "
<< crtc_connector_permutations.size();
bool has_successful_permutation = false;
for (const auto& permutation : crtc_connector_permutations) {
// Set up the display abstractions according to the current |permutation|.
for (const auto& crtc_connector_pair : permutation) {
uint32_t crtc_id = crtc_connector_pair.crtc_id;
uint32_t connector_id = crtc_connector_pair.connector_id;
ControllerConfigParams* param =
FindConfigParamsForConnector(configs_list, connector_id);
if (!param) {
LOG(ERROR) << __func__
<< ": Could not find ControllerConfigParams for connector "
"with ID: "
<< connector_id;
continue;
}
param->crtc = crtc_id;
}
if (!UpdateDisplaysWithNewCrtcs(configs_list)) {
continue;
}
++num_permutations_attempted;
if (screen_manager_->ConfigureDisplayControllers(
configs_list, {display::ModesetFlag::kTestModeset})) {
has_successful_permutation = true;
for (auto& config : configs_list) {
successful_config_list.push_back(config);
}
// No need to try other permutations for the device if one is
// successful.
break;
}
}
fallback_successful_for_all_devices &= has_successful_permutation;
if (!fallback_successful_for_all_devices) {
LOG(WARNING) << __func__
<< ": No successful CRTC-connector pairing permutation "
"found or DRM device: "
<< drm->device_path().value();
// TODO: b/329078793 - Stop reverting to the original config once
// pageflips are deferred/skipped during configuration.
// Revert ozone abstractions back to the original CRTC-controller pairings
// before the fallback attempt. The original CRTC-connector pairings are
// usually stable across display changes, and has better chances for a
// successful pageflip if one manages to happen between
// ConfigureDisplays() calls.
if (!UpdateDisplaysWithNewCrtcs(controllers_to_configure)) {
LOG(ERROR)
<< __func__
<< ": Failed to revert to the original CRTC-connector pairings.";
}
const std::string num_fallback_histogram =
GetNumFallbackHistogramName(config_requests.size());
base::UmaHistogramCounts1000(num_fallback_histogram,
num_permutations_attempted);
return false;
}
}
if (fallback_successful_for_all_devices) {
const std::string config_request_string =
ConfigRequestToString(config_requests);
successful_test_config_params_.insert(
{config_request_string, successful_config_list});
}
// TODO: b/329078793 - Stop reverting to the original config once
// pageflips are deferred/skipped during configuration.
// Revert ozone abstractions back to the original CRTC-controller pairings
// before the fallback attempt. The original CRTC-connector pairings are
// usually stable across display changes, and has better chances for a
// successful pageflip if one manages to happen between
// ConfigureDisplays() calls.
if (!UpdateDisplaysWithNewCrtcs(controllers_to_configure)) {
LOG(ERROR) << __func__
<< ": Failed to revert to the original CRTC-connector pairings.";
}
const std::string num_fallback_histogram =
GetNumFallbackHistogramName(config_requests.size());
base::UmaHistogramCounts1000(num_fallback_histogram,
num_permutations_attempted);
return fallback_successful_for_all_devices;
}
bool DrmGpuDisplayManager::UpdateDisplaysWithNewCrtcs(
const std::vector<ControllerConfigParams>& controllers_to_configure) {
base::flat_map<scoped_refptr<DrmDevice>, std::vector<ControllerConfigParams>>
drm_device_to_configs;
for (const auto& config : controllers_to_configure) {
scoped_refptr<DrmDevice> drm = config.drm;
drm_device_to_configs[drm].emplace_back(config);
}
// TODO: b/327015722 - handle ReplaceDisplayControllersCrtcs() inside
// ScreenManager.
base::flat_map<DrmDisplay*, base::flat_map<uint32_t /*current_crtc_id*/,
uint32_t /*new_crtc_id*/>>
display_to_new_crtcs_pairs;
for (const auto& [drm, config_list] : drm_device_to_configs) {
ConnectorCrtcMap current_connector_to_crtc_pairings;
ConnectorCrtcMap new_connector_to_crtc_pairings;
for (const auto& config_param : config_list) {
const uint32_t connector_id = config_param.connector;
DrmDisplay* display = FindDisplayByConnectorId(connector_id);
if (!display) {
LOG(DFATAL) << "DrmDisplay with connector ID " << connector_id
<< " not found.";
return false;
}
const DrmDisplay::CrtcConnectorPair* crtc_connector_pair =
display->GetCrtcConnectorPairForConnectorId(connector_id);
if (!crtc_connector_pair) {
LOG(DFATAL) << "CrtcConnectorPair with connector ID " << connector_id
<< " not found.";
return false;
}
uint32_t current_crtc_id = crtc_connector_pair->crtc_id;
display_to_new_crtcs_pairs[display][current_crtc_id] = config_param.crtc;
current_connector_to_crtc_pairings[connector_id] = current_crtc_id;
new_connector_to_crtc_pairings[connector_id] = config_param.crtc;
}
if (!screen_manager_->ReplaceDisplayControllersCrtcs(
drm, current_connector_to_crtc_pairings,
new_connector_to_crtc_pairings)) {
return false;
}
}
for (auto& [display, new_crtc_pairs] : display_to_new_crtcs_pairs) {
display->ReplaceCrtcs(new_crtc_pairs);
}
return true;
}
std::vector<ControllerConfigParams>
DrmGpuDisplayManager::GetLatestModesetTestConfig(
const std::vector<display::DisplayConfigurationParams>& config_requests) {
const std::string config_request_string =
ConfigRequestToString(config_requests);
const auto& config_param_it =
successful_test_config_params_.find(config_request_string);
if (config_param_it == successful_test_config_params_.end()) {
return {};
}
if (!UpdateDisplaysWithNewCrtcs(config_param_it->second)) {
LOG(ERROR) << __func__ << ": Unable to restore CRTC-connector pairings.";
}
return config_param_it->second;
}
std::unique_ptr<drmModeModeInfo> DrmGpuDisplayManager::FindModeForDisplay(
const display::DisplayMode& request_mode,
const DrmDisplay& display,
bool is_seamless) {
std::vector<const drmModeModeInfo*> matching_modes =
FindMatchingModes(request_mode, display.modes());
// If there's no matching mode for tiled display, that may be due to
// |request_mode| being tile-composited, while individual display.modes() are
// drmModeModeInfo, which have individual tile sized modes. Try to find
// matching modes again with tile sized request mode.
std::optional<TileProperty> tile_property = display.GetTileProperty();
if (matching_modes.empty() && tile_property.has_value()) {
if (request_mode.size() == GetTotalTileDisplaySize(*tile_property)) {
matching_modes = FindMatchingModes(
*request_mode.CopyWithSize(tile_property->tile_size),
display.modes());
}
}
// Filter the matched modes by testing for seamless configurability if needed.
HardwareDisplayController* controller = screen_manager_->GetDisplayController(
display.drm(), display.GetPrimaryCrtcId());
if (is_seamless) {
if (!controller) {
LOG(ERROR) << "Could not find HardwareDisplayController for display_id: "
<< display.display_id()
<< ". Continuing without seamless verification.";
} else {
std::erase_if(matching_modes, [&display,
&controller](const drmModeModeInfo* mode) {
return !controller->TestSeamlessMode(display.GetPrimaryCrtcId(), *mode);
});
}
}
// If the display doesn't have the mode natively, then lookup the mode
// from other displays and try using it on the current display (some
// displays support panel fitting and they can use different modes even
// if the mode isn't explicitly declared). Not attempted for seamless
// configuration requests.
if (matching_modes.empty() && !is_seamless) {
for (const auto& other_display : displays_) {
matching_modes = FindMatchingModes(request_mode, other_display->modes());
if (!matching_modes.empty()) {
VLOG(3) << "Found matching mode from another display. Attempting to "
"apply via panel fitting.";
break;
}
}
}
// If a matching mode hasn't been found and the display supports VRR, attempt
// to create a virtual mode with the requested properties.
if (matching_modes.empty() && display.IsVrrCapable()) {
const drmModeModeInfo* closest_mode = FindClosestModeWithGreaterRefreshRate(
request_mode, display, is_seamless, controller);
// Use the closest mode to create and return a virtual mode.
if (closest_mode) {
std::unique_ptr<drmModeModeInfo> out_virtual_mode =
CreateVirtualMode(*closest_mode, request_mode.refresh_rate());
if (out_virtual_mode) {
VLOG(3) << "Using virtual mode to achieve refresh_rate="
<< request_mode.refresh_rate();
return out_virtual_mode;
}
}
}
if (matching_modes.empty()) {
LOG(ERROR) << "Failed to find mode: size=" << request_mode.size().ToString()
<< " is_interlaced=" << request_mode.is_interlaced()
<< " refresh_rate=" << request_mode.refresh_rate();
return nullptr;
}
auto out_mode = std::make_unique<drmModeModeInfo>();
*out_mode = *matching_modes.front();
return out_mode;
}
} // namespace ui
|