1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/border.h"
#include <algorithm>
#include <memory>
#include <set>
#include <utility>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "cc/paint/paint_recorder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkCanvas.h"
#include "third_party/skia/include/core/SkPaint.h"
#include "third_party/skia/include/core/SkRRect.h"
#include "third_party/skia/include/core/SkRect.h"
#include "third_party/skia/include/core/SkRefCnt.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/geometry/skia_conversions.h"
#include "ui/views/painter.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
namespace {
class MockCanvas : public SkCanvas {
public:
struct DrawRectCall {
DrawRectCall(const SkRect& rect, const SkPaint& paint)
: rect(rect), paint(paint) {}
auto operator<=>(const DrawRectCall& other) const {
return std::tie(rect.fLeft, rect.fTop, rect.fRight, rect.fBottom) <=>
std::tie(other.rect.fLeft, other.rect.fTop, other.rect.fRight,
other.rect.fBottom);
}
SkRect rect;
SkPaint paint;
};
struct DrawRRectCall {
DrawRRectCall(const SkRRect& rrect, const SkPaint& paint)
: rrect(rrect), paint(paint) {}
auto operator<=>(const DrawRRectCall& other) const {
SkRect rect = rrect.rect();
SkRect other_rect = other.rrect.rect();
return std::tie(rect.fLeft, rect.fTop, rect.fRight, rect.fBottom) <=>
std::tie(other_rect.fLeft, other_rect.fTop, other_rect.fRight,
other_rect.fBottom);
}
SkRRect rrect;
SkPaint paint;
};
MockCanvas(int width, int height) : SkCanvas(width, height) {}
MockCanvas(const MockCanvas&) = delete;
MockCanvas& operator=(const MockCanvas&) = delete;
// Return calls in sorted order.
std::vector<DrawRectCall> draw_rect_calls() {
return std::vector<DrawRectCall>(draw_rect_calls_.begin(),
draw_rect_calls_.end());
}
// Return calls in sorted order.
std::vector<DrawRRectCall> draw_rrect_calls() {
return std::vector<DrawRRectCall>(draw_rrect_calls_.begin(),
draw_rrect_calls_.end());
}
const std::vector<SkPaint>& draw_paint_calls() const {
return draw_paint_calls_;
}
const SkRect& last_clip_bounds() const { return last_clip_bounds_; }
// SkCanvas overrides:
void onDrawRect(const SkRect& rect, const SkPaint& paint) override {
draw_rect_calls_.insert(DrawRectCall(rect, paint));
}
void onDrawRRect(const SkRRect& rrect, const SkPaint& paint) override {
draw_rrect_calls_.insert(DrawRRectCall(rrect, paint));
}
void onDrawPaint(const SkPaint& paint) override {
draw_paint_calls_.push_back(paint);
}
void onClipRect(const SkRect& rect,
SkClipOp op,
ClipEdgeStyle edge_style) override {
last_clip_bounds_ = rect;
}
private:
// Stores all the calls for querying by the test, in sorted order.
std::set<DrawRectCall> draw_rect_calls_;
std::set<DrawRRectCall> draw_rrect_calls_;
// Stores the onDrawPaint calls in chronological order.
std::vector<SkPaint> draw_paint_calls_;
SkRect last_clip_bounds_;
};
// Simple Painter that will be used to test BorderPainter.
class MockPainter : public views::Painter {
public:
MockPainter() = default;
MockPainter(const MockPainter&) = delete;
MockPainter& operator=(const MockPainter&) = delete;
// Gets the canvas given to the last call to Paint().
gfx::Canvas* given_canvas() const { return given_canvas_; }
// Gets the size given to the last call to Paint().
const gfx::Size& given_size() const { return given_size_; }
// Painter overrides:
gfx::Size GetMinimumSize() const override {
// Just return some arbitrary size.
return gfx::Size(60, 40);
}
void Paint(gfx::Canvas* canvas, const gfx::Size& size) override {
// Just record the arguments.
given_canvas_ = canvas;
given_size_ = size;
}
private:
raw_ptr<gfx::Canvas> given_canvas_ = nullptr;
gfx::Size given_size_;
};
} // namespace
namespace views {
class BorderTest : public ViewsTestBase {
public:
enum {
// The canvas should be much bigger than the view.
kCanvasWidth = 1000,
kCanvasHeight = 500,
};
void SetUp() override {
ViewsTestBase::SetUp();
recorder_ = std::make_unique<cc::PaintRecorder>();
canvas_ = std::make_unique<gfx::Canvas>(recorder_->beginRecording(), 1.0f);
widget_ = CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
view_ = widget_->SetContentsView(std::make_unique<views::View>());
view_->SetSize(gfx::Size(100, 50));
}
void TearDown() override {
widget_->Close();
ViewsTestBase::TearDown();
canvas_.reset();
recorder_.reset();
view_ = nullptr;
widget_.reset();
}
std::unique_ptr<MockCanvas> DrawIntoMockCanvas() {
cc::PaintRecord record = recorder_->finishRecordingAsPicture();
std::unique_ptr<MockCanvas> mock(
new MockCanvas(kCanvasWidth, kCanvasHeight));
record.Playback(mock.get());
return mock;
}
protected:
std::unique_ptr<cc::PaintRecorder> recorder_;
std::unique_ptr<views::Widget> widget_;
std::unique_ptr<gfx::Canvas> canvas_;
raw_ptr<View> view_ = nullptr;
};
TEST_F(BorderTest, NullBorder) {
std::unique_ptr<Border> border(NullBorder());
EXPECT_FALSE(border);
}
TEST_F(BorderTest, SolidBorder) {
const SkColor kBorderColor = SK_ColorMAGENTA;
std::unique_ptr<Border> border(CreateSolidBorder(3, kBorderColor));
EXPECT_EQ(gfx::Size(6, 6), border->GetMinimumSize());
EXPECT_EQ(gfx::Insets(3), border->GetInsets());
border->Paint(*view_, canvas_.get());
std::unique_ptr<MockCanvas> mock = DrawIntoMockCanvas();
std::vector<MockCanvas::DrawRectCall> draw_rect_calls =
mock->draw_rect_calls();
gfx::Rect bounds = view_->GetLocalBounds();
bounds.Inset(border->GetInsets());
ASSERT_EQ(1u, mock->draw_paint_calls().size());
EXPECT_EQ(kBorderColor, mock->draw_paint_calls()[0].getColor());
EXPECT_EQ(gfx::RectF(bounds), gfx::SkRectToRectF(mock->last_clip_bounds()));
}
TEST_F(BorderTest, RoundedRectBorder) {
std::unique_ptr<Border> border(CreateRoundedRectBorder(
3, LayoutProvider::Get()->GetCornerRadiusMetric(Emphasis::kLow),
SK_ColorBLUE));
EXPECT_EQ(gfx::Size(6, 6), border->GetMinimumSize());
EXPECT_EQ(gfx::Insets(3), border->GetInsets());
border->Paint(*view_, canvas_.get());
std::unique_ptr<MockCanvas> mock = DrawIntoMockCanvas();
SkRRect expected_rrect;
expected_rrect.setRectXY(SkRect::MakeLTRB(1.5, 1.5, 98.5, 48.5), 2.5, 2.5);
EXPECT_TRUE(mock->draw_rect_calls().empty());
std::vector<MockCanvas::DrawRRectCall> draw_rrect_calls =
mock->draw_rrect_calls();
ASSERT_EQ(1u, draw_rrect_calls.size());
EXPECT_EQ(expected_rrect, draw_rrect_calls[0].rrect);
EXPECT_EQ(3, draw_rrect_calls[0].paint.getStrokeWidth());
EXPECT_EQ(SK_ColorBLUE, draw_rrect_calls[0].paint.getColor());
EXPECT_EQ(SkPaint::kStroke_Style, draw_rrect_calls[0].paint.getStyle());
EXPECT_TRUE(draw_rrect_calls[0].paint.isAntiAlias());
}
TEST_F(BorderTest, EmptyBorder) {
constexpr auto kInsets = gfx::Insets::TLBR(1, 2, 3, 4);
std::unique_ptr<Border> border(CreateEmptyBorder(kInsets));
// The EmptyBorder has no minimum size despite nonzero insets.
EXPECT_EQ(gfx::Size(), border->GetMinimumSize());
EXPECT_EQ(kInsets, border->GetInsets());
// Should have no effect.
border->Paint(*view_, canvas_.get());
std::unique_ptr<Border> border2(CreateEmptyBorder(kInsets));
EXPECT_EQ(kInsets, border2->GetInsets());
}
TEST_F(BorderTest, SolidSidedBorder) {
constexpr SkColor kBorderColor = SK_ColorMAGENTA;
constexpr auto kInsets = gfx::Insets::TLBR(1, 2, 3, 4);
std::unique_ptr<Border> border(CreateSolidSidedBorder(kInsets, kBorderColor));
EXPECT_EQ(gfx::Size(6, 4), border->GetMinimumSize());
EXPECT_EQ(kInsets, border->GetInsets());
border->Paint(*view_, canvas_.get());
std::unique_ptr<MockCanvas> mock = DrawIntoMockCanvas();
std::vector<MockCanvas::DrawRectCall> draw_rect_calls =
mock->draw_rect_calls();
gfx::Rect bounds = view_->GetLocalBounds();
bounds.Inset(border->GetInsets());
ASSERT_EQ(1u, mock->draw_paint_calls().size());
EXPECT_EQ(kBorderColor, mock->draw_paint_calls().front().getColor());
EXPECT_EQ(gfx::RectF(bounds), gfx::SkRectToRectF(mock->last_clip_bounds()));
}
TEST_F(BorderTest, BorderPainter) {
constexpr auto kInsets = gfx::Insets::TLBR(1, 2, 3, 4);
std::unique_ptr<MockPainter> painter(new MockPainter());
MockPainter* painter_ptr = painter.get();
std::unique_ptr<Border> border(
CreateBorderPainter(std::move(painter), kInsets));
EXPECT_EQ(gfx::Size(60, 40), border->GetMinimumSize());
EXPECT_EQ(kInsets, border->GetInsets());
border->Paint(*view_, canvas_.get());
// Expect that the Painter was called with our canvas and the view's size.
EXPECT_EQ(canvas_.get(), painter_ptr->given_canvas());
EXPECT_EQ(view_->size(), painter_ptr->given_size());
}
TEST_F(BorderTest, ExtraInsetsBorder) {
constexpr SkColor kBorderColor = SK_ColorMAGENTA;
constexpr int kOriginalInset = 3;
std::unique_ptr<Border> border =
CreateSolidBorder(kOriginalInset, kBorderColor);
constexpr gfx::Insets kOriginalInsets(kOriginalInset);
EXPECT_EQ(kOriginalInsets.size(), border->GetMinimumSize());
EXPECT_EQ(kOriginalInsets, border->GetInsets());
EXPECT_EQ(kBorderColor, border->color());
constexpr int kExtraInset = 2;
constexpr gfx::Insets kExtraInsets(kExtraInset);
std::unique_ptr<Border> extra_insets_border =
CreatePaddedBorder(std::move(border), kExtraInsets);
constexpr gfx::Insets kTotalInsets(kOriginalInset + kExtraInset);
EXPECT_EQ(kTotalInsets.size(), extra_insets_border->GetMinimumSize());
EXPECT_EQ(kTotalInsets, extra_insets_border->GetInsets());
EXPECT_EQ(kBorderColor, extra_insets_border->color());
extra_insets_border->Paint(*view_, canvas_.get());
std::unique_ptr<MockCanvas> mock = DrawIntoMockCanvas();
std::vector<MockCanvas::DrawRectCall> draw_rect_calls =
mock->draw_rect_calls();
gfx::Rect bounds = view_->GetLocalBounds();
// We only use the wrapped border's insets for painting the border. The extra
// insets of the ExtraInsetsBorder are applied within the wrapped border.
bounds.Inset(extra_insets_border->GetInsets() - gfx::Insets(kExtraInset));
ASSERT_EQ(1u, mock->draw_paint_calls().size());
EXPECT_EQ(kBorderColor, mock->draw_paint_calls().front().getColor());
EXPECT_EQ(gfx::RectF(bounds), gfx::SkRectToRectF(mock->last_clip_bounds()));
}
} // namespace views
|