1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/controls/image_view.h"
#include <memory>
#include <string>
#include <utility>
#include "base/i18n/rtl.h"
#include "base/memory/raw_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/accessibility/ax_enums.mojom.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/views/accessibility/view_accessibility.h"
#include "ui/views/border.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/test/ax_event_counter.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/test/views_test_utils.h"
#include "ui/views/widget/widget.h"
namespace {
enum class Axis {
kHorizontal,
kVertical,
};
// A test utility function to set the application default text direction.
void SetRTL(bool rtl) {
// Override the current locale/direction.
base::i18n::SetICUDefaultLocale(rtl ? "he" : "en");
EXPECT_EQ(rtl, base::i18n::IsRTL());
}
} // namespace
namespace views {
class ImageViewTest : public ViewsTestBase,
public ::testing::WithParamInterface<Axis> {
public:
ImageViewTest() = default;
ImageViewTest(const ImageViewTest&) = delete;
ImageViewTest& operator=(const ImageViewTest&) = delete;
// ViewsTestBase:
void SetUp() override {
ViewsTestBase::SetUp();
Widget::InitParams params =
CreateParams(Widget::InitParams::CLIENT_OWNS_WIDGET,
Widget::InitParams::TYPE_WINDOW_FRAMELESS);
params.bounds = gfx::Rect(200, 200);
widget_.Init(std::move(params));
auto container = std::make_unique<View>();
// Make sure children can take up exactly as much space as they require.
BoxLayout::Orientation orientation =
GetParam() == Axis::kHorizontal ? BoxLayout::Orientation::kHorizontal
: BoxLayout::Orientation::kVertical;
container->SetLayoutManager(std::make_unique<BoxLayout>(orientation));
image_view_ = container->AddChildView(std::make_unique<ImageView>());
widget_.SetContentsView(std::move(container));
widget_.Show();
}
void TearDown() override {
// Null out the raw_ptr so it doesn't dangle during teardown.
image_view_ = nullptr;
widget_.Close();
ViewsTestBase::TearDown();
}
int CurrentImageOriginForParam() {
image_view()->UpdateImageOrigin();
gfx::Point origin = image_view()->GetImageBounds().origin();
return GetParam() == Axis::kHorizontal ? origin.x() : origin.y();
}
protected:
ImageView* image_view() { return image_view_; }
Widget* widget() { return &widget_; }
private:
raw_ptr<ImageView> image_view_ = nullptr;
Widget widget_;
};
// Test the image origin of the internal ImageSkia is correct when it is
// center-aligned (both horizontally and vertically).
TEST_P(ImageViewTest, CenterAlignment) {
image_view()->SetHorizontalAlignment(ImageView::Alignment::kCenter);
constexpr int kImageSkiaSize = 4;
SkBitmap bitmap;
bitmap.allocN32Pixels(kImageSkiaSize, kImageSkiaSize);
gfx::ImageSkia image_skia = gfx::ImageSkia::CreateFrom1xBitmap(bitmap);
image_view()->SetImage(ui::ImageModel::FromImageSkia(image_skia));
views::test::RunScheduledLayout(image_view());
EXPECT_NE(gfx::Size(), image_skia.size());
// With no changes to the size / padding of |image_view|, the origin of
// |image_skia| is the same as the origin of |image_view|.
EXPECT_EQ(0, CurrentImageOriginForParam());
// Test insets are always respected in LTR and RTL.
constexpr int kInset = 5;
image_view()->SetBorder(CreateEmptyBorder(kInset));
views::test::RunScheduledLayout(image_view());
EXPECT_EQ(kInset, CurrentImageOriginForParam());
SetRTL(true);
views::test::RunScheduledLayout(image_view());
EXPECT_EQ(kInset, CurrentImageOriginForParam());
// Check this still holds true when the insets are asymmetrical.
constexpr int kLeadingInset = 4;
constexpr int kTrailingInset = 6;
image_view()->SetBorder(CreateEmptyBorder(gfx::Insets::TLBR(
kLeadingInset, kLeadingInset, kTrailingInset, kTrailingInset)));
views::test::RunScheduledLayout(image_view());
EXPECT_EQ(kLeadingInset, CurrentImageOriginForParam());
SetRTL(false);
views::test::RunScheduledLayout(image_view());
EXPECT_EQ(kLeadingInset, CurrentImageOriginForParam());
}
TEST_P(ImageViewTest, ImageOriginForCustomViewBounds) {
gfx::Rect image_view_bounds(10, 10, 80, 80);
image_view()->SetHorizontalAlignment(ImageView::Alignment::kCenter);
image_view()->SetBoundsRect(image_view_bounds);
SkBitmap bitmap;
constexpr int kImageSkiaSize = 20;
bitmap.allocN32Pixels(kImageSkiaSize, kImageSkiaSize);
gfx::ImageSkia image_skia = gfx::ImageSkia::CreateFrom1xBitmap(bitmap);
image_view()->SetImage(ui::ImageModel::FromImageSkia(image_skia));
EXPECT_EQ(gfx::Point(30, 30), image_view()->GetImageBounds().origin());
EXPECT_EQ(image_view_bounds, image_view()->bounds());
}
// Verifies setting the accessible name will be call NotifyAccessibilityEvent.
TEST_P(ImageViewTest, SetAccessibleNameNotifiesAccessibilityEvent) {
std::u16string test_tooltip_text = u"Test Tooltip Text";
test::AXEventCounter counter(views::AXUpdateNotifier::Get());
EXPECT_EQ(0, counter.GetCount(ax::mojom::Event::kTextChanged));
image_view()->GetViewAccessibility().SetName(test_tooltip_text);
EXPECT_EQ(1, counter.GetCount(ax::mojom::Event::kTextChanged));
EXPECT_EQ(test_tooltip_text,
image_view()->GetViewAccessibility().GetCachedName());
ui::AXNodeData data;
image_view()->GetViewAccessibility().GetAccessibleNodeData(&data);
const std::string& name =
data.GetStringAttribute(ax::mojom::StringAttribute::kName);
EXPECT_EQ(test_tooltip_text, base::ASCIIToUTF16(name));
}
TEST_P(ImageViewTest, AccessibleNameFromTooltipText) {
// Initially there is no name and no tooltip text.
// The role should always be image, regardless of whether or not there is
// presentable information. It's the "ignored" state which should change.
ui::AXNodeData data;
image_view()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
std::u16string());
EXPECT_EQ(image_view()->GetViewAccessibility().GetCachedName(),
std::u16string());
EXPECT_EQ(image_view()->GetTooltipText(), std::u16string());
EXPECT_EQ(data.role, ax::mojom::Role::kImage);
EXPECT_TRUE(image_view()->GetViewAccessibility().GetIsIgnored());
// Setting the tooltip text when there is no accessible name should result in
// the tooltip text being used for the accessible name and the "ignored" state
// being removed.
data = ui::AXNodeData();
std::u16string tooltip_text = u"Tooltip Text";
image_view()->SetTooltipText(tooltip_text);
image_view()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
tooltip_text);
EXPECT_EQ(image_view()->GetViewAccessibility().GetCachedName(), tooltip_text);
EXPECT_EQ(image_view()->GetTooltipText(), tooltip_text);
EXPECT_EQ(data.role, ax::mojom::Role::kImage);
EXPECT_FALSE(image_view()->GetViewAccessibility().GetIsIgnored());
// Setting the accessible name to a non-empty string should replace the name
// from the tooltip text.
data = ui::AXNodeData();
std::u16string accessible_name = u"Accessible Name";
image_view()->GetViewAccessibility().SetName(accessible_name);
image_view()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
accessible_name);
EXPECT_EQ(image_view()->GetViewAccessibility().GetCachedName(),
accessible_name);
EXPECT_EQ(image_view()->GetTooltipText(), tooltip_text);
EXPECT_EQ(data.role, ax::mojom::Role::kImage);
EXPECT_FALSE(image_view()->GetViewAccessibility().GetIsIgnored());
// Setting the accessible name to an empty string should cause the tooltip
// text to be used as the name.
data = ui::AXNodeData();
image_view()->GetViewAccessibility().SetName(std::u16string());
image_view()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
tooltip_text);
EXPECT_EQ(image_view()->GetViewAccessibility().GetCachedName(), tooltip_text);
EXPECT_EQ(image_view()->GetTooltipText(), tooltip_text);
EXPECT_EQ(data.role, ax::mojom::Role::kImage);
EXPECT_FALSE(image_view()->GetViewAccessibility().GetIsIgnored());
// Setting the tooltip to an empty string without setting a new accessible
// name should cause the view to become "ignored" again.
data = ui::AXNodeData();
image_view()->SetTooltipText(std::u16string());
image_view()->GetViewAccessibility().GetAccessibleNodeData(&data);
EXPECT_EQ(data.GetString16Attribute(ax::mojom::StringAttribute::kName),
std::u16string());
EXPECT_EQ(image_view()->GetViewAccessibility().GetCachedName(),
std::u16string());
EXPECT_EQ(image_view()->GetTooltipText(), std::u16string());
EXPECT_EQ(data.role, ax::mojom::Role::kImage);
EXPECT_TRUE(image_view()->GetViewAccessibility().GetIsIgnored());
}
INSTANTIATE_TEST_SUITE_P(All,
ImageViewTest,
::testing::Values(Axis::kHorizontal, Axis::kVertical));
} // namespace views
|
