1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#include "base/functional/bind.h"
#include "base/i18n/rtl.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/test_timeouts.h"
#import "testing/gtest_mac.h"
#include "ui/base/accelerators/accelerator.h"
#include "ui/base/mojom/menu_source_type.mojom-shared.h"
#include "ui/events/event_utils.h"
#import "ui/events/test/cocoa_test_event_utils.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/menus/cocoa/menu_controller.h"
#include "ui/menus/simple_menu_model.h"
#include "ui/views/controls/menu/menu_cocoa_watcher_mac.h"
#include "ui/views/controls/menu/menu_runner_impl_adapter.h"
#import "ui/views/controls/menu/menu_runner_impl_cocoa.h"
#include "ui/views/test/views_test_base.h"
namespace views::test {
namespace {
constexpr int kTestCommandId = 0;
class TestModel : public ui::SimpleMenuModel {
public:
TestModel() : ui::SimpleMenuModel(&delegate_), delegate_(this) {}
TestModel(const TestModel&) = delete;
TestModel& operator=(const TestModel&) = delete;
void set_checked_command(int command) { checked_command_ = command; }
void set_menu_open_callback(base::OnceClosure callback) {
menu_open_callback_ = std::move(callback);
}
private:
class Delegate : public ui::SimpleMenuModel::Delegate {
public:
explicit Delegate(TestModel* model) : model_(model) {}
bool IsCommandIdChecked(int command_id) const override {
return command_id == model_->checked_command_;
}
Delegate(const Delegate&) = delete;
Delegate& operator=(const Delegate&) = delete;
bool IsCommandIdEnabled(int command_id) const override { return true; }
void ExecuteCommand(int command_id, int event_flags) override {}
void OnMenuWillShow(SimpleMenuModel* source) override {
if (!model_->menu_open_callback_.is_null()) {
std::move(model_->menu_open_callback_).Run();
}
}
bool GetAcceleratorForCommandId(
int command_id,
ui::Accelerator* accelerator) const override {
if (command_id == kTestCommandId) {
*accelerator = ui::Accelerator(ui::VKEY_E, ui::EF_CONTROL_DOWN);
return true;
}
return false;
}
private:
raw_ptr<TestModel> model_;
};
private:
int checked_command_ = -1;
Delegate delegate_;
base::OnceClosure menu_open_callback_;
};
enum class MenuType { NATIVE, VIEWS };
std::string MenuTypeToString(::testing::TestParamInfo<MenuType> info) {
return info.param == MenuType::VIEWS ? "VIEWS_MenuItemView" : "NATIVE_NSMenu";
}
} // namespace
class MenuRunnerCocoaTest : public ViewsTestBase,
public ::testing::WithParamInterface<MenuType> {
public:
static constexpr int kWindowHeight = 200;
static constexpr int kWindowOffset = 100;
MenuRunnerCocoaTest() : runner_(nullptr), parent_(nullptr) {}
MenuRunnerCocoaTest(const MenuRunnerCocoaTest&) = delete;
MenuRunnerCocoaTest& operator=(const MenuRunnerCocoaTest&) = delete;
~MenuRunnerCocoaTest() override = default;
void SetUp() override {
const int kWindowWidth = 300;
ViewsTestBase::SetUp();
menu_ = std::make_unique<TestModel>();
menu_->AddCheckItem(kTestCommandId, u"Menu Item");
parent_ = new views::Widget();
parent_->Init(CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS));
parent_->SetBounds(
gfx::Rect(kWindowOffset, kWindowOffset, kWindowWidth, kWindowHeight));
parent_->Show();
native_view_subview_count_ =
[[parent_->GetNativeView().GetNativeNSView() subviews] count];
base::RepeatingClosure on_close = base::BindRepeating(
&MenuRunnerCocoaTest::MenuCloseCallback, base::Unretained(this));
if (GetParam() == MenuType::NATIVE) {
runner_ = new internal::MenuRunnerImplCocoa(menu_.get(), on_close);
} else {
runner_ = new internal::MenuRunnerImplAdapter(menu_.get(), on_close);
}
EXPECT_FALSE(runner_->IsRunning());
}
void TearDown() override {
EXPECT_EQ(native_view_subview_count_,
[[parent_->GetNativeView().GetNativeNSView() subviews] count]);
if (runner_) {
runner_.ExtractAsDangling()->Release();
}
// Clean up for tests that set the notification filter.
MenuCocoaWatcherMac::SetNotificationFilterForTesting(
MacNotificationFilter::DontIgnoreNotifications);
parent_.ExtractAsDangling()->CloseNow();
ViewsTestBase::TearDown();
}
int IsAsync() const { return GetParam() == MenuType::VIEWS; }
// Runs the menu after registering |callback| as the menu open callback.
void RunMenu(base::OnceClosure callback) {
MenuCocoaWatcherMac::SetNotificationFilterForTesting(
MacNotificationFilter::IgnoreAllNotifications);
base::OnceClosure wrapped_callback = base::BindOnce(
[](base::OnceClosure cb) {
// Ignore app activation notifications while the test is running (all
// others are OK).
MenuCocoaWatcherMac::SetNotificationFilterForTesting(
MacNotificationFilter::IgnoreWorkspaceNotifications);
std::move(cb).Run();
},
std::move(callback));
if (IsAsync()) {
// Cancelling an async menu under MenuControllerCocoa::OpenMenuImpl()
// (which invokes WillShowMenu()) will cause a UAF when that same function
// tries to show the menu. So post a task instead.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE, std::move(wrapped_callback));
} else {
menu_->set_menu_open_callback(
base::BindOnce(&MenuRunnerCocoaTest::RunMenuWrapperCallback,
base::Unretained(this), std::move(wrapped_callback)));
}
runner_->RunMenuAt(
parent_, nullptr, gfx::Rect(), MenuAnchorPosition::kTopLeft,
ui::mojom::MenuSourceType::kNone, MenuRunner::CONTEXT_MENU);
MaybeRunAsync();
}
void MenuCancelCallback() {
runner_->Cancel();
if (IsAsync()) {
// Async menus report their cancellation immediately.
EXPECT_FALSE(runner_->IsRunning());
} else {
// For a synchronous menu, MenuRunner::IsRunning() should return true
// immediately after MenuRunner::Cancel() since the menu message loop has
// not yet terminated. It has only been marked for termination.
EXPECT_TRUE(runner_->IsRunning());
}
}
void MenuDeleteCallback() {
runner_.ExtractAsDangling()->Release();
// Deleting an async menu intentionally does not invoke MenuCloseCallback().
// (The callback is typically a method on something in the process of being
// destroyed). So invoke QuitAsyncRunLoop() here as well.
QuitAsyncRunLoop();
}
NSMenu* GetNativeNSMenu() {
if (GetParam() == MenuType::VIEWS) {
return nil;
}
internal::MenuRunnerImplCocoa* cocoa_runner =
static_cast<internal::MenuRunnerImplCocoa*>(runner_);
return [cocoa_runner->menu_controller_ menu];
}
void ModelDeleteThenSelectItemCallback() {
// AppKit may retain a reference to the NSMenu.
NSMenu* native_menu = GetNativeNSMenu();
// A View showing a menu typically owns a MenuRunner unique_ptr, which will
// will be destroyed (releasing the MenuRunnerImpl) alongside the MenuModel.
runner_.ExtractAsDangling()->Release();
menu_ = nullptr;
// The menu is closing (yet "alive"), but the model is destroyed. The user
// may have already made an event to select an item in the menu. This
// doesn't bother views menus (see MenuRunnerImpl::empty_delegate_) but
// Cocoa menu items are refcounted and have access to a raw weak pointer in
// the MenuController.
if (GetParam() == MenuType::VIEWS) {
QuitAsyncRunLoop();
return;
}
EXPECT_TRUE(native_menu);
// Simulate clicking the item using its accelerator.
NSEvent* accelerator = cocoa_test_event_utils::KeyEventWithKeyCode(
'e', 'e', NSEventTypeKeyDown, NSEventModifierFlagCommand);
[native_menu performKeyEquivalent:accelerator];
}
void MenuCancelAndDeleteCallback() {
runner_->Cancel();
// Release cause the runner to delete itself.
runner_.ExtractAsDangling()->Release();
}
protected:
std::unique_ptr<TestModel> menu_;
raw_ptr<internal::MenuRunnerImplInterface> runner_ = nullptr;
raw_ptr<views::Widget> parent_ = nullptr;
NSUInteger native_view_subview_count_ = 0;
int menu_close_count_ = 0;
private:
void RunMenuWrapperCallback(base::OnceClosure callback) {
EXPECT_TRUE(runner_->IsRunning());
std::move(callback).Run();
}
// Run a nested run loop so that async and sync menus can be tested the
// same way.
void MaybeRunAsync() {
if (!IsAsync()) {
return;
}
base::RunLoop run_loop;
quit_closure_ = run_loop.QuitClosure();
base::SingleThreadTaskRunner::GetCurrentDefault()->PostDelayedTask(
FROM_HERE, quit_closure_, TestTimeouts::action_timeout());
run_loop.Run();
// |quit_closure_| should be run by QuitAsyncRunLoop(), not the timeout.
EXPECT_TRUE(quit_closure_.is_null());
}
void QuitAsyncRunLoop() {
if (!IsAsync()) {
EXPECT_TRUE(quit_closure_.is_null());
return;
}
ASSERT_FALSE(quit_closure_.is_null());
quit_closure_.Run();
quit_closure_.Reset();
}
void MenuCloseCallback() {
++menu_close_count_;
QuitAsyncRunLoop();
}
base::RepeatingClosure quit_closure_;
};
TEST_P(MenuRunnerCocoaTest, RunMenuAndCancel) {
base::TimeTicks min_time = ui::EventTimeForNow();
RunMenu(base::BindOnce(&MenuRunnerCocoaTest::MenuCancelCallback,
base::Unretained(this)));
EXPECT_EQ(1, menu_close_count_);
EXPECT_FALSE(runner_->IsRunning());
if (GetParam() == MenuType::VIEWS) {
// MenuItemView's MenuRunnerImpl gets the closing time from
// MenuControllerCocoa:: closing_event_time(). This is is reset on show, but
// only updated when an event closes the menu -- not a cancellation.
EXPECT_EQ(runner_->GetClosingEventTime(), base::TimeTicks());
} else {
EXPECT_GE(runner_->GetClosingEventTime(), min_time);
}
EXPECT_LE(runner_->GetClosingEventTime(), ui::EventTimeForNow());
// Cancel again.
runner_->Cancel();
EXPECT_FALSE(runner_->IsRunning());
EXPECT_EQ(1, menu_close_count_);
}
TEST_P(MenuRunnerCocoaTest, RunMenuAndDelete) {
RunMenu(base::BindOnce(&MenuRunnerCocoaTest::MenuDeleteCallback,
base::Unretained(this)));
// Note the close callback is NOT invoked for deleted menus.
EXPECT_EQ(0, menu_close_count_);
}
// Tests a potential lifetime issue using the Cocoa MenuController, which has a
// weak reference to the model.
TEST_P(MenuRunnerCocoaTest, RunMenuAndDeleteThenSelectItem) {
RunMenu(
base::BindOnce(&MenuRunnerCocoaTest::ModelDeleteThenSelectItemCallback,
base::Unretained(this)));
EXPECT_EQ(0, menu_close_count_);
}
// Ensure a menu can be safely released immediately after a call to Cancel() in
// the same run loop iteration.
TEST_P(MenuRunnerCocoaTest, DestroyAfterCanceling) {
RunMenu(base::BindOnce(&MenuRunnerCocoaTest::MenuCancelAndDeleteCallback,
base::Unretained(this)));
if (IsAsync()) {
EXPECT_EQ(1, menu_close_count_);
} else {
// For a synchronous menu, the deletion happens before the cancel can be
// processed, so the close callback will not be invoked.
EXPECT_EQ(0, menu_close_count_);
}
}
TEST_P(MenuRunnerCocoaTest, RunMenuTwice) {
for (int i = 0; i < 2; ++i) {
RunMenu(base::BindOnce(&MenuRunnerCocoaTest::MenuCancelCallback,
base::Unretained(this)));
EXPECT_FALSE(runner_->IsRunning());
EXPECT_EQ(i + 1, menu_close_count_);
}
}
TEST_P(MenuRunnerCocoaTest, CancelWithoutRunning) {
runner_->Cancel();
EXPECT_FALSE(runner_->IsRunning());
EXPECT_EQ(base::TimeTicks(), runner_->GetClosingEventTime());
EXPECT_EQ(0, menu_close_count_);
}
TEST_P(MenuRunnerCocoaTest, DeleteWithoutRunning) {
runner_.ExtractAsDangling()->Release();
EXPECT_EQ(0, menu_close_count_);
}
INSTANTIATE_TEST_SUITE_P(,
MenuRunnerCocoaTest,
::testing::Values(MenuType::NATIVE, MenuType::VIEWS),
&MenuTypeToString);
} // namespace views::test
|