1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/web_dialogs/web_dialog_delegate.h"
#include "base/test/bind.h"
#include "content/public/browser/web_ui_message_handler.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ui {
namespace {
using WebDialogDelegateTest = testing::Test;
class TestMessageHandler : public content::WebUIMessageHandler {
public:
explicit TestMessageHandler(bool* destroyed) : destroyed_(destroyed) {}
~TestMessageHandler() override { *destroyed_ = true; }
protected:
void RegisterMessages() override {}
raw_ptr<bool> destroyed_;
};
// This test validates that:
// 1. AddWebUIMessageHandler() takes ownership of the passed-in handlers, and
// 2. GetWebUIMessageHandlers() passes ownership of the handlers back
TEST(WebDialogDelegateTest, MessageHandlerOwnershipIsPassed) {
ui::WebDialogDelegate delegate;
bool destroyed_1 = false;
bool destroyed_2 = false;
delegate.AddWebUIMessageHandler(
std::make_unique<TestMessageHandler>(&destroyed_1));
delegate.AddWebUIMessageHandler(
std::make_unique<TestMessageHandler>(&destroyed_2));
EXPECT_FALSE(destroyed_1);
EXPECT_FALSE(destroyed_2);
// Extract the WebUIMessageHandlers as owning raw pointers, and ensure they
// don't get destroyed in the process.
std::vector<content::WebUIMessageHandler*> handlers;
delegate.GetWebUIMessageHandlers(&handlers);
EXPECT_FALSE(destroyed_1);
EXPECT_FALSE(destroyed_2);
// Now, put both handlers back into unique_ptrs and let them go out of scope,
// destroying them, and validate that destroyed_1 and destroyed_2 are set.
{
auto handler_1 = base::WrapUnique(handlers[0]);
auto handler_2 = base::WrapUnique(handlers[1]);
}
EXPECT_TRUE(destroyed_1);
EXPECT_TRUE(destroyed_2);
}
TEST(WebDialogDelegateTest, CallbackOnClose) {
bool called = false;
auto delegate = std::make_unique<WebDialogDelegate>();
delegate->set_delete_on_close(false);
delegate->RegisterOnDialogClosedCallback(
base::BindLambdaForTesting([&](const std::string&) { called = true; }));
EXPECT_FALSE(called);
delegate->OnDialogClosed("{}");
EXPECT_TRUE(called);
called = false;
delegate.reset();
EXPECT_FALSE(called);
}
class DeletionTestWebDialogDelegate : public WebDialogDelegate {
public:
explicit DeletionTestWebDialogDelegate(bool* deleted) : deleted_(deleted) {}
~DeletionTestWebDialogDelegate() override { *deleted_ = true; }
private:
raw_ptr<bool> deleted_;
};
TEST(WebDialogDelegateTest, DeleteOnClose) {
bool deleted = false;
auto delegate = std::make_unique<DeletionTestWebDialogDelegate>(&deleted);
delegate->set_delete_on_close(true);
delegate.release()->OnDialogClosed("{}");
EXPECT_TRUE(deleted);
}
TEST(WebDialogDelegateTest, NoDeleteOnClose) {
bool deleted = false;
auto delegate = std::make_unique<DeletionTestWebDialogDelegate>(&deleted);
delegate->set_delete_on_close(false);
delegate->OnDialogClosed("{}");
EXPECT_FALSE(deleted);
delegate.reset();
EXPECT_TRUE(deleted);
}
TEST(WebDialogDelegateTest, AcceleratorsAreHandled) {
bool called = false;
auto delegate = std::make_unique<WebDialogDelegate>();
const ui::Accelerator accelerator{ui::VKEY_Z, ui::EF_CONTROL_DOWN};
const ui::Accelerator other_accelerator{ui::VKEY_Z, ui::EF_SHIFT_DOWN};
delegate->RegisterAccelerator(
accelerator, base::BindLambdaForTesting(
[&](WebDialogDelegate& provided_delegate,
const ui::Accelerator& provided_accelerator) {
EXPECT_EQ(&provided_delegate, delegate.get());
EXPECT_EQ(provided_accelerator, accelerator);
called = true;
return true;
}));
EXPECT_FALSE(delegate->AcceleratorPressed(other_accelerator));
EXPECT_FALSE(called);
EXPECT_TRUE(delegate->AcceleratorPressed(accelerator));
EXPECT_TRUE(called);
}
} // namespace
} // namespace ui
|
