1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/arc/arc_support_host.h"
#include <vector>
#include "base/functional/bind.h"
#include "chrome/browser/ash/arc/extensions/fake_arc_support.h"
#include "chrome/browser/ash/login/users/fake_chrome_user_manager.h"
#include "chrome/browser/consent_auditor/consent_auditor_factory.h"
#include "chrome/browser/consent_auditor/consent_auditor_test_utils.h"
#include "chrome/browser/signin/identity_test_environment_profile_adaptor.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/testing_profile.h"
#include "components/consent_auditor/fake_consent_auditor.h"
#include "components/signin/public/identity_manager/identity_manager.h"
#include "components/signin/public/identity_manager/identity_test_environment.h"
#include "components/user_manager/scoped_user_manager.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using arc::FakeArcSupport;
using testing::Eq;
using testing::StrictMock;
using testing::_;
namespace {
class MockTermsOfServiceDelegateNonStrict
: public ArcSupportHost::TermsOfServiceDelegate {
public:
MOCK_METHOD3(OnTermsAgreed,
void(bool is_metrics_enabled,
bool is_backup_and_restore_enabled,
bool is_location_service_enabled));
MOCK_METHOD0(OnTermsRejected, void());
MOCK_METHOD0(OnTermsRetryClicked, void());
MOCK_METHOD1(OnTermsLoadResult, void(bool success));
};
using MockTermsOfServiceDelegate =
StrictMock<MockTermsOfServiceDelegateNonStrict>;
class MockErrorDelegateNonStrict : public ArcSupportHost::ErrorDelegate {
public:
MOCK_METHOD0(OnWindowClosed, void());
MOCK_METHOD0(OnRetryClicked, void());
MOCK_METHOD0(OnSendFeedbackClicked, void());
MOCK_METHOD0(OnRunNetworkTestsClicked, void());
MOCK_METHOD1(OnErrorPageShown, void(bool network_tests_shown));
};
using MockErrorDelegate = StrictMock<MockErrorDelegateNonStrict>;
} // namespace
class ArcSupportHostTest : public BrowserWithTestWindowTest {
public:
ArcSupportHostTest() = default;
ArcSupportHostTest(const ArcSupportHostTest&) = delete;
ArcSupportHostTest& operator=(const ArcSupportHostTest&) = delete;
~ArcSupportHostTest() override = default;
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
fake_user_manager_.Reset(std::make_unique<ash::FakeChromeUserManager>());
identity_test_env_adaptor_ =
std::make_unique<IdentityTestEnvironmentProfileAdaptor>(profile());
// The code under test should not be tied to browser sync consent.
identity_test_env_adaptor_->identity_test_env()
->MakePrimaryAccountAvailable("testing@account.com",
signin::ConsentLevel::kSignin);
support_host_ = std::make_unique<ArcSupportHost>(profile());
fake_arc_support_ = std::make_unique<FakeArcSupport>(support_host_.get());
}
void TearDown() override {
support_host_->SetTermsOfServiceDelegate(nullptr);
support_host_->SetErrorDelegate(nullptr);
fake_arc_support_.reset();
support_host_.reset();
identity_test_env_adaptor_.reset();
fake_user_manager_.Reset();
BrowserWithTestWindowTest::TearDown();
}
ArcSupportHost* support_host() { return support_host_.get(); }
FakeArcSupport* fake_arc_support() { return fake_arc_support_.get(); }
MockTermsOfServiceDelegate* CreateMockTermsOfServiceDelegate() {
tos_delegate_ = std::make_unique<MockTermsOfServiceDelegate>();
support_host_->SetTermsOfServiceDelegate(tos_delegate_.get());
return tos_delegate_.get();
}
MockErrorDelegate* CreateMockErrorDelegate() {
error_delegate_ = std::make_unique<MockErrorDelegate>();
support_host_->SetErrorDelegate(error_delegate_.get());
return error_delegate_.get();
}
consent_auditor::FakeConsentAuditor* consent_auditor() {
return static_cast<consent_auditor::FakeConsentAuditor*>(
ConsentAuditorFactory::GetForProfile(profile()));
}
// BrowserWithTestWindowTest:
TestingProfile::TestingFactories GetTestingFactories() override {
return IdentityTestEnvironmentProfileAdaptor::
GetIdentityTestEnvironmentFactoriesWithAppendedFactories(
{TestingProfile::TestingFactory{
ConsentAuditorFactory::GetInstance(),
base::BindRepeating(&BuildFakeConsentAuditor)}});
}
private:
user_manager::TypedScopedUserManager<ash::FakeChromeUserManager>
fake_user_manager_;
std::unique_ptr<ArcSupportHost> support_host_;
std::unique_ptr<FakeArcSupport> fake_arc_support_;
std::unique_ptr<IdentityTestEnvironmentProfileAdaptor>
identity_test_env_adaptor_;
std::unique_ptr<MockTermsOfServiceDelegate> tos_delegate_;
std::unique_ptr<MockErrorDelegate> error_delegate_;
};
namespace {
TEST_F(ArcSupportHostTest, TermsOfServiceAccept) {
consent_auditor::FakeConsentAuditor* ca = consent_auditor();
EXPECT_CALL(*ca, RecordArcPlayConsent(_, _));
EXPECT_CALL(*ca, RecordArcBackupAndRestoreConsent(_, _));
EXPECT_CALL(*ca, RecordArcGoogleLocationServiceConsent(_, _));
MockTermsOfServiceDelegate tos_delegate;
support_host()->SetTermsOfServiceDelegate(&tos_delegate);
support_host()->ShowTermsOfService();
fake_arc_support()->set_metrics_mode(false); // just to add some diversity
fake_arc_support()->set_backup_and_restore_mode(true);
fake_arc_support()->set_location_service_mode(true);
EXPECT_CALL(tos_delegate, OnTermsAgreed(false, true, true));
fake_arc_support()->ClickAgreeButton();
}
TEST_F(ArcSupportHostTest, TermsOfServiceRejectOrCloseWindow) {
MockTermsOfServiceDelegate* tos_delegate = CreateMockTermsOfServiceDelegate();
support_host()->SetTermsOfServiceDelegate(tos_delegate);
MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
support_host()->SetErrorDelegate(error_delegate);
support_host()->ShowTermsOfService();
EXPECT_CALL(*tos_delegate, OnTermsRejected());
EXPECT_CALL(*error_delegate, OnWindowClosed()).Times(0);
// Rejecting ToS and closing the window when ToS is showing is the same thing.
fake_arc_support()->Close();
}
TEST_F(ArcSupportHostTest, TermsOfServiceRetryOnError) {
MockTermsOfServiceDelegate* tos_delegate = CreateMockTermsOfServiceDelegate();
support_host()->SetTermsOfServiceDelegate(tos_delegate);
MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
support_host()->SetErrorDelegate(error_delegate);
EXPECT_CALL(*error_delegate, OnErrorPageShown(true));
support_host()->ShowError(
ArcSupportHost::ErrorInfo(
ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR),
false /* should_show_send_feedback */,
true /* should_show_run_network_tests */);
EXPECT_CALL(*tos_delegate, OnTermsRetryClicked());
EXPECT_CALL(*error_delegate, OnWindowClosed()).Times(0);
fake_arc_support()->ClickRetryButton();
}
TEST_F(ArcSupportHostTest, CloseWindowWithoutTermsOfServiceOrAuthOngoing) {
// No TermsOfServiceDelegate since it is not ongoing.
MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
support_host()->SetErrorDelegate(error_delegate);
support_host()->ShowArcLoading();
EXPECT_CALL(*error_delegate, OnWindowClosed());
fake_arc_support()->Close();
}
TEST_F(ArcSupportHostTest, RetryOnGeneralError) {
// No TermsOfServiceDelegate and AuthDelegate since it is not ongoing.
MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
support_host()->SetErrorDelegate(error_delegate);
EXPECT_CALL(*error_delegate, OnErrorPageShown(true));
support_host()->ShowError(
ArcSupportHost::ErrorInfo(
ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR),
false /* should_show_send_feedback */,
true /* should_show_run_network_tests */);
EXPECT_CALL(*error_delegate, OnRetryClicked());
fake_arc_support()->ClickRetryButton();
}
TEST_F(ArcSupportHostTest, SendFeedbackOnError) {
MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
support_host()->SetErrorDelegate(error_delegate);
EXPECT_CALL(*error_delegate, OnErrorPageShown(true));
support_host()->ShowError(
ArcSupportHost::ErrorInfo(
ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR),
true /* should_show_send_feedback */,
true /* should_show_run_network_tests */);
EXPECT_CALL(*error_delegate, OnSendFeedbackClicked());
fake_arc_support()->ClickSendFeedbackButton();
}
TEST_F(ArcSupportHostTest, RunNetworkTestsOnError) {
MockErrorDelegate* error_delegate = CreateMockErrorDelegate();
support_host()->SetErrorDelegate(error_delegate);
EXPECT_CALL(*error_delegate, OnErrorPageShown(true));
support_host()->ShowError(
ArcSupportHost::ErrorInfo(
ArcSupportHost::Error::NETWORK_UNAVAILABLE_ERROR),
true /* should_show_send_feedback */,
true /* should_show_run_network_tests */);
EXPECT_CALL(*error_delegate, OnRunNetworkTestsClicked());
fake_arc_support()->ClickRunNetworkTestsButton();
}
TEST_F(ArcSupportHostTest, TosLoadResult) {
MockTermsOfServiceDelegate* tos_delegate = CreateMockTermsOfServiceDelegate();
support_host()->SetTermsOfServiceDelegate(tos_delegate);
support_host()->ShowTermsOfService();
EXPECT_CALL(*tos_delegate, OnTermsLoadResult(true));
fake_arc_support()->TosLoadResult(true);
}
} // namespace
|
