1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/net/network_diagnostics/http_firewall_routine.h"
#include <memory>
#include <utility>
#include "base/containers/circular_deque.h"
#include "base/functional/callback_helpers.h"
#include "chrome/browser/ash/net/network_diagnostics/fake_network_context.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/browser_task_environment.h"
#include "net/base/net_errors.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash::network_diagnostics {
namespace {
namespace mojom = ::chromeos::network_diagnostics::mojom;
// The number of hosts the the routine tries to open socket connections to (if
// DNS resolution is successful). Value equals the number of random hosts
// + fixed hosts queried by HttpFirewallRoutine.
const int kTotalHosts = 9;
// Test implementation of TlsProber.
class TestTlsProber final : public TlsProber {
public:
TestTlsProber(TlsProber::TlsProbeCompleteCallback callback,
int result,
TlsProber::ProbeExitEnum probe_exit_enum) {
// Post an asynchronus task simulating a completed probe. This mimics the
// behavior of the production TlsProber constructor since the TestTlsProber
// instance will be complete before FinishProbe is invoked. In the
// production TlsProber, the constructor completes before DNS host
// resolution is invoked.
content::GetUIThreadTaskRunner({})->PostTask(
FROM_HERE,
base::BindOnce(&TestTlsProber::FinishProbe, weak_factory_.GetWeakPtr(),
std::move(callback), result, probe_exit_enum));
}
TestTlsProber(const TestTlsProber&) = delete;
TestTlsProber& operator=(const TestTlsProber&) = delete;
~TestTlsProber() override = default;
private:
void FinishProbe(TlsProber::TlsProbeCompleteCallback callback,
int result,
TlsProber::ProbeExitEnum probe_exit_enum) {
std::move(callback).Run(result, probe_exit_enum);
}
base::WeakPtrFactory<TestTlsProber> weak_factory_{this};
};
struct TlsProberReturnValue {
net::Error result;
TlsProber::ProbeExitEnum probe_exit_enum;
};
class TestDelegate : public HttpFirewallRoutine::Delegate {
public:
explicit TestDelegate(
base::circular_deque<TlsProberReturnValue> fake_probe_results)
: fake_probe_results_(fake_probe_results) {}
// Delegate:
std::unique_ptr<TlsProber> CreateAndExecuteTlsProber(
network::NetworkContextGetter network_context_getter,
net::HostPortPair host_port_pair,
bool negotiate_tls,
TlsProber::TlsProbeCompleteCallback callback) override {
DCHECK(fake_probe_results_.size() > 0);
auto value = fake_probe_results_.front();
fake_probe_results_.pop_front();
auto test_tls_prober = std::make_unique<TestTlsProber>(
std::move(callback), value.result, value.probe_exit_enum);
return std::move(test_tls_prober);
}
private:
base::circular_deque<TlsProberReturnValue> fake_probe_results_;
};
} // namespace
class HttpFirewallRoutineTest : public ::testing::Test {
public:
HttpFirewallRoutineTest() = default;
HttpFirewallRoutineTest(const HttpFirewallRoutineTest&) = delete;
HttpFirewallRoutineTest& operator=(const HttpFirewallRoutineTest&) = delete;
void RunRoutine(
mojom::RoutineVerdict expected_routine_verdict,
const std::vector<mojom::HttpFirewallProblem>& expected_problems) {
http_firewall_routine_->RunRoutine(base::BindOnce(
&HttpFirewallRoutineTest::CompareResult, weak_factory_.GetWeakPtr(),
expected_routine_verdict, expected_problems));
run_loop_.Run();
}
void CompareResult(
mojom::RoutineVerdict expected_verdict,
const std::vector<mojom::HttpFirewallProblem>& expected_problems,
mojom::RoutineResultPtr result) {
DCHECK(run_loop_.running());
EXPECT_EQ(expected_verdict, result->verdict);
EXPECT_EQ(expected_problems,
result->problems->get_http_firewall_problems());
run_loop_.Quit();
}
void SetUpRoutine(
base::circular_deque<TlsProberReturnValue> fake_probe_results) {
http_firewall_routine_ = std::make_unique<HttpFirewallRoutine>(
mojom::RoutineCallSource::kDiagnosticsUI);
http_firewall_routine_->SetDelegateForTesting(
std::make_unique<TestDelegate>(std::move(fake_probe_results)));
}
// Sets up required properties (via fakes) and runs the test.
//
// Parameters:
// |fake_probe_results|: Represents the results of TLS probes.
// |expected_routine_verdict|: Represents the expected verdict
// reported by this test.
// |expected_problems|: Represents the expected problem
// reported by this test.
void SetUpAndRunRoutine(
base::circular_deque<TlsProberReturnValue> fake_probe_results,
mojom::RoutineVerdict expected_routine_verdict,
const std::vector<mojom::HttpFirewallProblem>& expected_problems) {
SetUpRoutine(std::move(fake_probe_results));
RunRoutine(expected_routine_verdict, expected_problems);
}
private:
content::BrowserTaskEnvironment task_environment_;
base::RunLoop run_loop_;
std::unique_ptr<HttpFirewallRoutine> http_firewall_routine_;
base::WeakPtrFactory<HttpFirewallRoutineTest> weak_factory_{this};
};
TEST_F(HttpFirewallRoutineTest, TestDnsResolutionFailuresAboveThreshold) {
base::circular_deque<TlsProberReturnValue> fake_probe_results;
// kTotalHosts = 9
for (int i = 0; i < kTotalHosts; i++) {
if (i < 2) {
fake_probe_results.push_back(TlsProberReturnValue{
net::ERR_NAME_NOT_RESOLVED, TlsProber::ProbeExitEnum::kDnsFailure});
} else {
// Having seven successful resolutions out of nine puts us below the
// threshold needed to attempt TLS probes.
fake_probe_results.push_back(
TlsProberReturnValue{net::OK, TlsProber::ProbeExitEnum::kSuccess});
}
}
SetUpAndRunRoutine(
std::move(fake_probe_results), mojom::RoutineVerdict::kProblem,
{mojom::HttpFirewallProblem::kDnsResolutionFailuresAboveThreshold});
}
// Edge case for tls_probe_failure_rate calculation.
TEST_F(HttpFirewallRoutineTest, TestNoDnsResolutionSuccess) {
base::circular_deque<TlsProberReturnValue> fake_probe_results;
// kTotalHosts = 9
for (int i = 0; i < kTotalHosts; i++) {
fake_probe_results.push_back(TlsProberReturnValue{
net::ERR_NAME_NOT_RESOLVED, TlsProber::ProbeExitEnum::kDnsFailure});
}
SetUpAndRunRoutine(
std::move(fake_probe_results), mojom::RoutineVerdict::kProblem,
{mojom::HttpFirewallProblem::kDnsResolutionFailuresAboveThreshold});
}
TEST_F(HttpFirewallRoutineTest, TestFirewallDetection) {
base::circular_deque<TlsProberReturnValue> fake_probe_results;
// kTotalHosts = 9
for (int i = 0; i < kTotalHosts; i++) {
fake_probe_results.push_back(TlsProberReturnValue{
net::ERR_FAILED, TlsProber::ProbeExitEnum::kTlsUpgradeFailure});
}
SetUpAndRunRoutine(std::move(fake_probe_results),
mojom::RoutineVerdict::kProblem,
{mojom::HttpFirewallProblem::kFirewallDetected});
}
TEST_F(HttpFirewallRoutineTest, TestPotentialFirewallDetection) {
base::circular_deque<TlsProberReturnValue> fake_probe_results;
// kTotalHosts = 9
for (int i = 0; i < kTotalHosts; i++) {
if (i < 5) {
fake_probe_results.push_back(
TlsProberReturnValue{net::OK, TlsProber::ProbeExitEnum::kSuccess});
} else {
// Having five connection failures and four successful connections signals
// a potential firewall.
fake_probe_results.push_back(TlsProberReturnValue{
net::ERR_FAILED, TlsProber::ProbeExitEnum::kTcpConnectionFailure});
}
}
SetUpAndRunRoutine(std::move(fake_probe_results),
mojom::RoutineVerdict::kProblem,
{mojom::HttpFirewallProblem::kPotentialFirewall});
}
TEST_F(HttpFirewallRoutineTest, TestNoFirewallIssues) {
base::circular_deque<TlsProberReturnValue> fake_probe_results;
// kTotalHosts = 9
for (int i = 0; i < kTotalHosts; i++) {
if (i < 8) {
fake_probe_results.push_back(
TlsProberReturnValue{net::OK, TlsProber::ProbeExitEnum::kSuccess});
} else {
// Having one connection failure and eight successful connections puts us
// above the required threshold.
fake_probe_results.push_back(TlsProberReturnValue{
net::ERR_FAILED, TlsProber::ProbeExitEnum::kMojoDisconnectFailure});
}
}
SetUpAndRunRoutine(std::move(fake_probe_results),
mojom::RoutineVerdict::kNoProblem, {});
}
TEST_F(HttpFirewallRoutineTest, TestContinousRetries) {
base::circular_deque<TlsProberReturnValue> fake_probe_results;
// kTotalHosts = 9
for (int i = 0; i < kTotalHosts; i++) {
if (i < 8) {
fake_probe_results.push_back(
TlsProberReturnValue{net::OK, TlsProber::ProbeExitEnum::kSuccess});
} else {
// Having one socket that continuously retries until failure and eight
// sockets that make successful connections puts us above the required
// threshold.
for (int j = 0; j < HttpFirewallRoutine::kTotalNumRetries + 1; j++) {
fake_probe_results.push_back(TlsProberReturnValue{
net::ERR_TIMED_OUT,
TlsProber::ProbeExitEnum::kMojoDisconnectFailure});
}
}
}
SetUpAndRunRoutine(std::move(fake_probe_results),
mojom::RoutineVerdict::kNoProblem, {});
}
} // namespace ash::network_diagnostics
|