1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/plugin_vm/plugin_vm_files.h"
#include "ash/public/cpp/shelf_model.h"
#include "base/files/file_util.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/test/bind.h"
#include "base/test/mock_callback.h"
#include "base/test/scoped_running_on_chromeos.h"
#include "chrome/browser/ash/crostini/crostini_test_helper.h"
#include "chrome/browser/ash/file_manager/path_util.h"
#include "chrome/browser/ash/guest_os/guest_os_registry_service.h"
#include "chrome/browser/ash/plugin_vm/fake_plugin_vm_features.h"
#include "chrome/browser/ash/plugin_vm/mock_plugin_vm_manager.h"
#include "chrome/browser/ash/plugin_vm/plugin_vm_manager_factory.h"
#include "chrome/browser/ash/plugin_vm/plugin_vm_util.h"
#include "chrome/browser/ui/ash/shelf/app_window_base.h"
#include "chrome/browser/ui/ash/shelf/app_window_shelf_item_controller.h"
#include "chrome/browser/ui/ash/shelf/chrome_shelf_controller.h"
#include "chrome/browser/ui/ash/shelf/shelf_controller_helper.h"
#include "chrome/test/base/testing_profile.h"
#include "chromeos/ash/components/dbus/chunneld/chunneld_client.h"
#include "chromeos/ash/components/dbus/cicerone/cicerone_client.h"
#include "chromeos/ash/components/dbus/cicerone/fake_cicerone_client.h"
#include "chromeos/ash/components/dbus/concierge/concierge_client.h"
#include "chromeos/ash/components/dbus/seneschal/seneschal_client.h"
#include "chromeos/ash/components/dbus/vm_applications/apps.pb.h"
#include "chromeos/ash/components/dbus/vm_plugin_dispatcher/vm_plugin_dispatcher_client.h"
#include "content/public/test/browser_task_environment.h"
#include "storage/browser/file_system/external_mount_points.h"
#include "storage/common/file_system/file_system_types.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/storage_key/storage_key.h"
namespace {
class MockAppWindowBase : public AppWindowBase {
public:
MockAppWindowBase(const ash::ShelfID& shelf_id, views::Widget* widget)
: AppWindowBase(shelf_id, widget) {}
~MockAppWindowBase() override = default;
MockAppWindowBase(const MockAppWindowBase&) = delete;
MockAppWindowBase& operator=(const MockAppWindowBase&) = delete;
MOCK_METHOD(void, Activate, (), ());
};
} // namespace
namespace plugin_vm {
using EnsureDefaultSharedDirExistsCallback =
testing::StrictMock<base::MockCallback<
base::OnceCallback<void(const base::FilePath& dir, bool result)>>>;
class PluginVmFilesTest : public testing::Test {
protected:
void SetUp() override {
fake_plugin_vm_features_.set_enabled(true);
vm_tools::apps::ApplicationList app_list;
app_list.set_vm_type(vm_tools::apps::VmType::PLUGIN_VM);
app_list.set_vm_name("PvmDefault");
app_list.set_container_name("penguin");
*app_list.add_apps() = crostini::CrostiniTestHelper::BasicApp("name");
app_id_ = crostini::CrostiniTestHelper::GenerateAppId("name", "PvmDefault",
"penguin");
guest_os::GuestOsRegistryService(&profile_).UpdateApplicationList(app_list);
mount_points_ = storage::ExternalMountPoints::GetSystemInstance();
mount_name_ = file_manager::util::GetDownloadsMountPointName(&profile_);
mount_points_->RegisterFileSystem(
mount_name_, storage::kFileSystemTypeLocal,
storage::FileSystemMountOption(), GetMyFilesFolderPath());
}
void TearDown() override {
base::DeletePathRecursively(GetPvmDefaultPath());
mount_points_->RevokeAllFileSystems();
}
base::FilePath GetMyFilesFolderPath() {
return file_manager::util::GetMyFilesFolderForProfile(&profile_);
}
base::FilePath GetPvmDefaultPath() {
return GetMyFilesFolderPath().Append("PvmDefault");
}
storage::FileSystemURL GetMyFilesFileSystemURL(const std::string& path) {
return mount_points_->CreateExternalFileSystemURL(
blink::StorageKey(), mount_name_, base::FilePath(path));
}
struct ScopedDBusClients {
ScopedDBusClients() {
ash::CiceroneClient::InitializeFake();
ash::ConciergeClient::InitializeFake();
ash::SeneschalClient::InitializeFake();
ash::ChunneldClient::InitializeFake();
ash::VmPluginDispatcherClient::InitializeFake();
}
~ScopedDBusClients() {
ash::VmPluginDispatcherClient::Shutdown();
ash::SeneschalClient::Shutdown();
ash::ConciergeClient::Shutdown();
ash::CiceroneClient::Shutdown();
ash::ChunneldClient::Shutdown();
}
} dbus_clients_;
content::BrowserTaskEnvironment task_environment_;
TestingProfile profile_;
FakePluginVmFeatures fake_plugin_vm_features_;
base::test::ScopedRunningOnChromeOS running_on_chromeos_;
std::string app_id_;
raw_ptr<storage::ExternalMountPoints> mount_points_;
std::string mount_name_;
};
TEST_F(PluginVmFilesTest, DirNotExists) {
EnsureDefaultSharedDirExistsCallback callback;
EnsureDefaultSharedDirExists(&profile_, callback.Get());
EXPECT_CALL(callback, Run(GetPvmDefaultPath(), true));
task_environment_.RunUntilIdle();
}
TEST_F(PluginVmFilesTest, DirAlreadyExists) {
EXPECT_TRUE(base::CreateDirectory(GetPvmDefaultPath()));
EnsureDefaultSharedDirExistsCallback callback;
EnsureDefaultSharedDirExists(&profile_, callback.Get());
EXPECT_CALL(callback, Run(GetPvmDefaultPath(), true));
task_environment_.RunUntilIdle();
}
TEST_F(PluginVmFilesTest, FileAlreadyExists) {
EXPECT_TRUE(base::CreateDirectory(GetMyFilesFolderPath()));
EXPECT_TRUE(base::WriteFile(GetPvmDefaultPath(), ""));
EnsureDefaultSharedDirExistsCallback callback;
EnsureDefaultSharedDirExists(&profile_, callback.Get());
EXPECT_CALL(callback, Run(GetPvmDefaultPath(), false));
task_environment_.RunUntilIdle();
}
TEST_F(PluginVmFilesTest, LaunchPluginVmApp) {
using MockPluginVmManager = testing::StrictMock<test::MockPluginVmManager>;
using AppLaunchedCallback =
testing::StrictMock<base::MockCallback<LaunchPluginVmAppCallback>>;
using LaunchContainerApplicationCallback = chromeos::DBusMethodCallback<
vm_tools::cicerone::LaunchContainerApplicationResponse>;
auto& plugin_vm_manager = *static_cast<MockPluginVmManager*>(
PluginVmManagerFactory::GetInstance()->SetTestingFactoryAndUse(
&profile_,
base::BindRepeating(
[](content::BrowserContext*) -> std::unique_ptr<KeyedService> {
return std::make_unique<MockPluginVmManager>();
})));
ash::ShelfModel shelf_model;
ChromeShelfController chrome_shelf_controller(&profile_, &shelf_model);
chrome_shelf_controller.SetProfileForTest(&profile_);
chrome_shelf_controller.SetShelfControllerHelperForTest(
std::make_unique<ShelfControllerHelper>(&profile_));
chrome_shelf_controller.Init();
AppLaunchedCallback app_launched_callback;
PluginVmManager::LaunchPluginVmCallback launch_plugin_vm_callback;
EXPECT_CALL(plugin_vm_manager, LaunchPluginVm(testing::_))
.WillOnce(testing::Invoke(
[&](PluginVmManager::LaunchPluginVmCallback callback) {
launch_plugin_vm_callback = std::move(callback);
}));
LaunchPluginVmApp(&profile_, app_id_,
{GetMyFilesFileSystemURL("PvmDefault/file")},
app_launched_callback.Get());
ASSERT_FALSE(launch_plugin_vm_callback.is_null());
LaunchContainerApplicationCallback cicerone_response_callback;
ash::FakeCiceroneClient::Get()->SetOnLaunchContainerApplicationCallback(
base::BindLambdaForTesting(
[&](const vm_tools::cicerone::LaunchContainerApplicationRequest&
request,
LaunchContainerApplicationCallback callback) {
EXPECT_TRUE(cicerone_response_callback.is_null());
cicerone_response_callback = std::move(callback);
}));
std::move(launch_plugin_vm_callback).Run(/*success=*/true);
ASSERT_FALSE(cicerone_response_callback.is_null());
ash::ShelfID shelf_id(kPluginVmShelfAppId);
auto shelf_item_controller =
std::make_unique<AppWindowShelfItemController>(shelf_id);
MockAppWindowBase mock_window(shelf_id, nullptr);
shelf_item_controller->AddWindow(&mock_window);
mock_window.SetController(shelf_item_controller.get());
ash::ShelfItem item;
item.type = ash::TYPE_APP;
item.id = shelf_id;
shelf_model.Add(item, std::move(shelf_item_controller));
vm_tools::cicerone::LaunchContainerApplicationResponse response;
response.set_success(true);
EXPECT_CALL(mock_window, Activate());
EXPECT_CALL(app_launched_callback, Run(LaunchPluginVmAppResult::SUCCESS, ""));
std::move(cicerone_response_callback).Run(std::move(response));
}
TEST_F(PluginVmFilesTest, LaunchAppFail) {
LaunchPluginVmAppResult actual_result;
auto capture_result =
[](LaunchPluginVmAppResult* actual_result, LaunchPluginVmAppResult result,
const std::string& failure_reason) { *actual_result = result; };
// Not enabled.
fake_plugin_vm_features_.set_enabled(false);
LaunchPluginVmApp(&profile_, app_id_,
{GetMyFilesFileSystemURL("PvmDefault/file")},
base::BindOnce(capture_result, &actual_result));
task_environment_.RunUntilIdle();
EXPECT_EQ(LaunchPluginVmAppResult::FAILED, actual_result);
fake_plugin_vm_features_.set_enabled(true);
// Path in MyFiles, but not MyFiles/PvmDefault.
LaunchPluginVmApp(&profile_, app_id_,
{GetMyFilesFileSystemURL("not/in/PvmDefault")},
base::BindOnce(capture_result, &actual_result));
task_environment_.RunUntilIdle();
EXPECT_EQ(LaunchPluginVmAppResult::FAILED_DIRECTORY_NOT_SHARED,
actual_result);
// Path in different volume.
mount_points_->RegisterFileSystem(
"other-volume", storage::kFileSystemTypeLocal,
storage::FileSystemMountOption(), GetMyFilesFolderPath());
storage::FileSystemURL url = mount_points_->CreateExternalFileSystemURL(
blink::StorageKey(), "other-volume", base::FilePath("other/volume"));
LaunchPluginVmApp(&profile_, app_id_, {url},
base::BindOnce(capture_result, &actual_result));
task_environment_.RunUntilIdle();
EXPECT_EQ(LaunchPluginVmAppResult::FAILED_DIRECTORY_NOT_SHARED,
actual_result);
}
} // namespace plugin_vm
|
