1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/arc/arc_external_protocol_dialog.h"
#include "base/memory/raw_ptr.h"
#include "base/time/time.h"
#include "chrome/browser/chromeos/arc/arc_web_contents_data.h"
#include "chrome/browser/sharing/click_to_call/click_to_call_ui_controller.h"
#include "chrome/browser/sharing/sharing_service_factory.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chromeos/ash/experiences/arc/intent_helper/arc_intent_helper_mojo_delegate.h"
#include "chromeos/ash/experiences/arc/intent_helper/arc_intent_helper_package.h"
#include "chromeos/ash/experiences/arc/test/fake_arc_icon_cache.h"
#include "chromeos/ash/experiences/arc/test/fake_arc_intent_helper_mojo.h"
#include "components/sharing_message/features.h"
#include "components/sharing_message/mock_sharing_service.h"
#include "components/sharing_message/proto/click_to_call_message.pb.h"
#include "components/sharing_message/proto/sharing_message.pb.h"
#include "components/sharing_message/sharing_target_device_info.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "url/gurl.h"
using ::testing::Property;
namespace arc {
namespace {
SharingTargetDeviceInfo CreateFakeSharingTargetDeviceInfo(
const std::string& guid) {
return SharingTargetDeviceInfo(guid, "Test name",
SharingDevicePlatform::kUnknown,
/*pulse_interval=*/base::TimeDelta(),
syncer::DeviceInfo::FormFactor::kUnknown,
/*last_updated_timestamp=*/base::Time());
}
// Helper class to run tests that need a dummy WebContents and arc delegate.
class ArcExternalProtocolDialogTestUtils : public BrowserWithTestWindowTest {
public:
ArcExternalProtocolDialogTestUtils() = default;
ArcExternalProtocolDialogTestUtils(
const ArcExternalProtocolDialogTestUtils&) = delete;
ArcExternalProtocolDialogTestUtils& operator=(
const ArcExternalProtocolDialogTestUtils&) = delete;
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
arc_icon_cache_ = std::make_unique<FakeArcIconCache>();
delegate_provider_ =
std::make_unique<ArcIconCacheDelegateProvider>(arc_icon_cache_.get());
}
void TearDown() override { BrowserWithTestWindowTest::TearDown(); }
protected:
void CreateTab(bool started_from_arc) {
AddTab(browser(), GURL("http://www.tests.com"));
web_contents_ = browser()->tab_strip_model()->GetWebContentsAt(0);
if (started_from_arc) {
web_contents_->SetUserData(
&ArcWebContentsData::kArcTransitionFlag,
std::make_unique<ArcWebContentsData>(web_contents_));
}
}
bool WasTabStartedFromArc() {
return GetAndResetSafeToRedirectToArcWithoutUserConfirmationFlagForTesting(
web_contents_);
}
MockSharingService* CreateSharingService() {
return static_cast<MockSharingService*>(
SharingServiceFactory::GetInstance()->SetTestingFactoryAndUse(
profile(),
base::BindRepeating([](content::BrowserContext* context) {
return static_cast<std::unique_ptr<KeyedService>>(
std::make_unique<MockSharingService>());
})));
}
content::WebContents* web_contents() { return web_contents_; }
private:
base::test::ScopedFeatureList features_{kClickToCall};
// Keep only one |WebContents| at a time.
raw_ptr<content::WebContents, DanglingUntriaged> web_contents_;
std::unique_ptr<ArcIconCacheDelegate> arc_icon_cache_;
std::unique_ptr<ArcIconCacheDelegateProvider> delegate_provider_;
};
// Creates a dummy GurlAndActivityInfo object.
GurlAndActivityInfo CreateEmptyGurlAndActivityInfo() {
return std::make_pair(GURL(), ArcIntentHelperMojoDelegate::ActivityName(
/*package_name=*/std::string(),
/*activity_name=*/std::string()));
}
// Creates and returns a new IntentHandlerInfo object.
ArcIntentHelperMojoDelegate::IntentHandlerInfo Create(
const std::string& name,
const std::string& package_name,
const std::string& activity_name,
bool is_preferred,
const GURL& fallback_url) {
std::optional<std::string> url;
if (!fallback_url.is_empty())
url = fallback_url.spec();
return ArcIntentHelperMojoDelegate::IntentHandlerInfo(
std::move(name), std::move(package_name), std::move(activity_name),
is_preferred, std::move(url));
}
} // namespace
// Tests that when one app is passed to GetAction but the user hasn't selected
// it and |in_out_safe_to_bypass_ui| is true, the function returns
// HANDLE_URL_IN_ARC.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithOneAppBypassesIntentPicker) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("package", "com.google.package.name",
/*activity_name=*/std::string(),
/*is_preferred=*/false, /*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(GURL("external-protocol:foo"), handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests that when one app is passed to GetAction but the user hasn't selected
// it and |in_out_safe_to_bypass_ui| is false, the function returns
// ASK_USER.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithOneAppDoesntBypassIntentPicker) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("package", "com.google.package.name",
/*activity_name=*/std::string(),
/*is_preferred=*/false, /*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::ASK_USER,
GetActionForTesting(GURL("external-protocol:foo"), handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests that when 2+ apps are passed to GetAction but the user hasn't selected
// any the function returns ASK_USER, independently of whether or not is marked
// as safe to bypass the ui.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoAppWontBypassIntentPicker) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("package", "com.google.package.name",
/*activity_name=*/std::string(),
/*is_preferred=*/false, /*fallback_url=*/GURL()));
handlers.push_back(Create("package2", "com.google.package.name2",
/*activity_name=*/std::string(),
/*is_preferred=*/false, /*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::ASK_USER,
GetActionForTesting(GURL("external-protocol:foo"), handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_FALSE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::ASK_USER,
GetActionForTesting(GURL("external-protocol:foo"), handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests that when one preferred app is passed to GetAction, the function
// returns HANDLE_URL_IN_ARC even if the user hasn't selected the app, safe to
// bypass the UI is not relevant for this context.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithOnePreferredApp) {
const GURL external_url("external-protocol:foo");
const std::string package_name("com.google.package.name");
const std::string activity_name("com.google.activity");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("package", package_name, activity_name,
/*is_preferred=*/true,
/*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(external_url, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(external_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(external_url, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
// The flag was flipped since we have a preferred app.
EXPECT_TRUE(in_out_safe_to_bypass_ui);
EXPECT_EQ(external_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
}
// Tests that when one app is passed to GetAction, the user has already selected
// it, the function returns HANDLE_URL_IN_ARC. Since the user already selected
// safe to bypass ui it's always false.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithOneAppSelected) {
const GURL external_url("external-protocol:foo");
const std::string package_name("com.google.package.name");
const std::string activity_name("fake_activity_name");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("package", package_name, activity_name,
/*is_preferred=*/false,
/*fallback_url=*/GURL()));
constexpr size_t kSelection = 0;
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(external_url, handlers, kSelection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(external_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_FALSE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(external_url, handlers, kSelection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(external_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests the same as TestGetActionWithOnePreferredApp but with two apps.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithOnePreferredAppAndOneOther) {
const GURL external_url("external-protocol:foo");
const std::string package_name("com.google.package2.name");
const std::string activity_name("fake_activity_name2");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("package", "com.google.package.name",
"fake_activity_name",
/*is_preferred=*/false, /*fallback_url=*/GURL()));
handlers.push_back(Create("package2", package_name, activity_name,
/*is_preferred=*/true,
/*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
// For cases with 2+ apps it doesn't matter whether it was marked as safe to
// bypass or not, it will only check for user's preferrences.
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(external_url, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(external_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
// It is expected to correct the flag to true, regardless of the initial
// value, since there is a preferred app.
EXPECT_TRUE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(external_url, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(external_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests that HANDLE_URL_IN_ARC is returned for geo: URL. The URL is special in
// that intent_helper (i.e. the Chrome proxy) can handle it but Chrome cannot.
// We have to send such a URL to intent_helper to let the helper rewrite the
// URL to https://maps.google.com/?latlon=xxx which Chrome can handle. Since the
// url needs to be fixed in ARC first, safe to bypass doesn't modify this
// behavior.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithGeoUrl) {
const GURL geo_url("geo:37.7749,-122.4194");
const std::string activity_name("chrome_activity_name");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
activity_name,
/*is_preferred=*/true,
/*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(geo_url, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(geo_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
// Value will be corrected as in previous scenarios.
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests that OPEN_URL_IN_CHROME is returned when a handler with a fallback http
// URL and kArcIntentHelperPackageName is passed to GetAction, even if the
// handler is not a preferred one.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithOneFallbackUrl) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=http://zxing.org;end");
const GURL fallback_url("http://zxing.org");
const std::string activity_name("fake_activity_name");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
activity_name,
/*is_preferred=*/false, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
// Since the navigation is intended to stay in Chrome the UI is bypassed.
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::OPEN_URL_IN_CHROME,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::OPEN_URL_IN_CHROME,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests the same with https and is_preferred == true.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithOnePreferredFallbackUrl) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=https://zxing.org;end");
const GURL fallback_url("https://zxing.org");
const std::string activity_name("fake_activity_name");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
activity_name,
/*is_preferred=*/true, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
// Safe to bypass should be marked as true in the end, since the
// OPEN_URL_IN_CHROME actually bypasses the UI, regardless of the flag.
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::OPEN_URL_IN_CHROME,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
// Changing the flag will not modify the outcome.
in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::OPEN_URL_IN_CHROME,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests that ASK_USER is returned when two handlers with fallback URLs are
// passed to GetAction. This may happen when the user has installed a 3rd party
// browser app, and then clicks a intent: URI with a http fallback.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithTwoFallbackUrls) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=http://zxing.org;end");
const GURL fallback_url("http://zxing.org");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other browser", "com.other.browser",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::ASK_USER,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests the same but set Chrome as a preferred app. In this case, ASK_USER
// shouldn't be returned.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoFallbackUrlsChromePreferred) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=http://zxing.org;end");
const GURL fallback_url("http://zxing.org");
const std::string chrome_activity("chrome_activity");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other browser", "com.other.browser",
"fake_activity",
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
chrome_activity,
/*is_preferred=*/true, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::OPEN_URL_IN_CHROME,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(chrome_activity, url_and_activity_name.second.activity_name);
// Remember that this flag gets fixed under the presence of a preferred app.
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests the same but set "other browser" as a preferred app. In this case,
// ASK_USER shouldn't be returned either.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoFallbackUrlsOtherBrowserPreferred) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=http://zxing.org;end");
const GURL fallback_url("http://zxing.org");
const std::string package_name = "com.other.browser";
const std::string chrome_activity_name("chrome_activity_name");
const std::string other_activity_name("other_activity_name");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other browser", package_name, other_activity_name,
/*is_preferred=*/true, fallback_url));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
chrome_activity_name,
/*is_preferred=*/false, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(other_activity_name, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests the same but set Chrome as a user-selected app.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoFallbackUrlsChromeSelected) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=http://zxing.org;end");
const GURL fallback_url("http://zxing.org");
const std::string chrome_activity_name("chrome_activity");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other browser", "com.other.browser",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
chrome_activity_name,
/*is_preferred=*/false, fallback_url));
constexpr size_t kSelection = 1; // Chrome
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::OPEN_URL_IN_CHROME,
GetActionForTesting(intent_url_with_fallback, handlers, kSelection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(chrome_activity_name, url_and_activity_name.second.activity_name);
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests the same but set "other browser" as a preferred app.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoFallbackUrlsOtherBrowserSelected) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=http://zxing.org;end");
const GURL fallback_url("http://zxing.org");
const std::string package_name = "com.other.browser";
const std::string other_activity_name("other_activity_name");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other browser", package_name, other_activity_name,
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
"chrome_activity",
/*is_preferred=*/false, fallback_url));
constexpr size_t kSelection = 0; // the other browser
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
// Already selected app index, output should be corrected to false.
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, kSelection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(other_activity_name, url_and_activity_name.second.activity_name);
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests that HANDLE_URL_IN_ARC is returned when a handler with a fallback
// market: URL is passed to GetAction iff the flag to bypass the UI is set,
// otherwise UI will prompt to ASK_USER.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithOneMarketFallbackUrl) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Play Store", "com.google.play.store",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_TRUE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::ASK_USER,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests the same but with is_preferred == true.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithOnePreferredMarketFallbackUrl) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
const std::string play_store_package_name = "com.google.play.store";
const std::string play_store_activity("play_store_activity");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Play Store", play_store_package_name,
play_store_activity,
/*is_preferred=*/true, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(play_store_package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(play_store_activity, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(play_store_package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(play_store_activity, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests the same but with an app_seleteced_index.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithOneSelectedMarketFallbackUrl) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
const std::string play_store_package_name = "com.google.play.store";
const std::string play_store_activity("play_store_activity");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Play Store", play_store_package_name,
play_store_activity,
/*is_preferred=*/false, fallback_url));
constexpr size_t kSelection = 0;
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
// App already selected, it doesn't really makes sense to call GetAction with
// |in_out_safe_to_bypass_ui| set to true here.
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, kSelection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(play_store_package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(play_store_activity, url_and_activity_name.second.activity_name);
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests that HANDLE_URL_IN_ARC is returned when a handler with a fallback
// market: URL is passed to GetAction.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithOneMarketFallbackUrlBypassIntentPicker) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Play Store", "com.google.play.store",
"play_store_activity", /*is_preferred=*/false,
fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = true;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests that ASK_USER is returned when two handlers with fallback market: URLs
// are passed to GetAction. Unlike the two browsers case, this rarely happens on
// the user's device, though.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithTwoMarketFallbackUrls) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Play Store", "com.google.play.store",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Other Store app", "com.other.play.store",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::ASK_USER,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_FALSE(in_out_safe_to_bypass_ui);
}
// Tests the same, but make the second handler a preferred one.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoMarketFallbackUrlsOnePreferred) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
const std::string play_store_package_name = "com.google.play.store";
const std::string play_store_activity("play.store.act1");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other Store app", "com.other.play.store",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Play Store", play_store_package_name,
play_store_activity,
/*is_preferred=*/true, fallback_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(play_store_package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(play_store_activity, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Tests the same, but make the second handler a selected one.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithTwoMarketFallbackUrlsOneSelected) {
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;end");
const GURL fallback_url("market://details?id=com.google.abc");
const std::string play_store_package_name = "com.google.play.store";
const std::string play_store_activity("play.store.act1");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Other Store app", "com.other.play.store",
/*activity_name=*/std::string(),
/*is_preferred=*/false, fallback_url));
handlers.push_back(Create("Play Store", play_store_package_name,
play_store_activity,
/*is_preferred=*/false, fallback_url));
const size_t kSelection = 1; // Play Store
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
// After selection doesn't really makes sense to check this value.
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, kSelection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(fallback_url, url_and_activity_name.first);
EXPECT_EQ(play_store_package_name, url_and_activity_name.second.package_name);
EXPECT_EQ(play_store_activity, url_and_activity_name.second.activity_name);
}
// Tests the case where geo: URL is returned as a fallback. This should never
// happen because intent_helper ignores such a fallback, but just in case.
// GetAction shouldn't crash at least.
TEST(ArcExternalProtocolDialogTest, TestGetActionWithGeoUrlAsFallback) {
// Note: geo: as a browser fallback is banned in the production code.
const GURL intent_url_with_fallback(
"intent://scan/#Intent;scheme=abc;package=com.google.abc;"
"S.browser_fallback_url=geo:37.7749,-122.4194;end");
const GURL geo_url("geo:37.7749,-122.4194");
const std::string chrome_activity("chrome.activity");
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
chrome_activity,
/*is_preferred=*/true, geo_url));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
// GetAction shouldn't return OPEN_URL_IN_CHROME because Chrome doesn't
// directly support geo:.
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(intent_url_with_fallback, handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_EQ(geo_url, url_and_activity_name.first);
EXPECT_EQ(kArcIntentHelperPackageName,
url_and_activity_name.second.package_name);
EXPECT_EQ(chrome_activity, url_and_activity_name.second.activity_name);
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
// Test that GetUrlToNavigateOnDeactivate returns an empty GURL when |handlers|
// is empty.
TEST(ArcExternalProtocolDialogTest, TestGetUrlToNavigateOnDeactivateEmpty) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
EXPECT_EQ(GURL(), GetUrlToNavigateOnDeactivateForTesting(handlers));
}
// Test that GetUrlToNavigateOnDeactivate returns an empty GURL when |handlers|
// only contains a (non-Chrome) app.
TEST(ArcExternalProtocolDialogTest, TestGetUrlToNavigateOnDeactivateAppOnly) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
// On production, when |handlers| only contains app(s), the fallback field is
// empty, but to make the test more reliable, use non-empty fallback URL.
handlers.push_back(Create("App", "app.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("http://www")));
EXPECT_EQ(GURL(), GetUrlToNavigateOnDeactivateForTesting(handlers));
}
// Test that GetUrlToNavigateOnDeactivate returns an empty GURL when |handlers|
// only contains (non-Chrome) apps.
TEST(ArcExternalProtocolDialogTest, TestGetUrlToNavigateOnDeactivateAppsOnly) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
// On production, when |handlers| only contains app(s), the fallback field is
// empty, but to make the test more reliable, use non-empty fallback URL.
handlers.push_back(Create("App1", "app1.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("http://www")));
handlers.push_back(Create("App2", "app2.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("http://www")));
EXPECT_EQ(GURL(), GetUrlToNavigateOnDeactivateForTesting(handlers));
}
// Test that GetUrlToNavigateOnDeactivate returns an empty GURL when |handlers|
// contains Chrome, but it's not for http(s).
TEST(ArcExternalProtocolDialogTest, TestGetUrlToNavigateOnDeactivateGeoUrl) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create(
"Chrome", kArcIntentHelperPackageName, /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("geo:37.4220,-122.0840")));
EXPECT_EQ(GURL(), GetUrlToNavigateOnDeactivateForTesting(handlers));
}
// Test that GetUrlToNavigateOnDeactivate returns non-empty GURL when |handlers|
// contains Chrome and an app.
TEST(ArcExternalProtocolDialogTest,
TestGetUrlToNavigateOnDeactivateChromeAndApp) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
// On production, all handlers have the same fallback URL, but to make sure
// that "Chrome" is actually selected by the function, use different URLs.
handlers.push_back(Create("A browser app", "browser.app.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("http://www1/")));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("http://www2/")));
handlers.push_back(Create("Yet another browser app",
"yet.another.browser.app.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("http://www3/")));
EXPECT_EQ(GURL("http://www2/"),
GetUrlToNavigateOnDeactivateForTesting(handlers));
}
// Does the same with https, just in case.
TEST(ArcExternalProtocolDialogTest,
TestGetUrlToNavigateOnDeactivateChromeAndAppHttps) {
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("A browser app", "browser.app.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www1/")));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www2/")));
handlers.push_back(Create("Yet another browser app",
"yet.another.browser.app.package",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www3/")));
EXPECT_EQ(GURL("https://www2/"),
GetUrlToNavigateOnDeactivateForTesting(handlers));
}
// Checks that the flag is correctly attached to the current tab.
TEST_F(ArcExternalProtocolDialogTestUtils, TestTabIsStartedFromArc) {
CreateTab(/*started_from_arc=*/true);
EXPECT_TRUE(WasTabStartedFromArc());
}
// Tests the same as the previous, just for when the data is not attached to the
// tab.
TEST_F(ArcExternalProtocolDialogTestUtils, TestTabIsNotStartedFromArc) {
CreateTab(/*started_from_arc=*/false);
EXPECT_FALSE(WasTabStartedFromArc());
}
// Tests that IsChromeAnAppCandidate works as intended.
TEST(ArcExternalProtocolDialogTest, TestIsChromeAnAppCandidate) {
// First 3 cases are valid, just switching the position of Chrome.
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(
Create("fake app 1", "fake.app.package", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.fo.com")));
handlers.push_back(
Create("fake app 2", "fake.app.package2", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.bar.com")));
handlers.push_back(Create("Chrome", kArcIntentHelperPackageName,
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www/")));
EXPECT_TRUE(IsChromeAnAppCandidateForTesting(handlers));
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers2;
handlers2.push_back(
Create("fake app 1", "fake.app.package", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.fo.com")));
handlers2.push_back(Create("Chrome", kArcIntentHelperPackageName,
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www/")));
handlers2.push_back(
Create("fake app 2", "fake.app.package2", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.bar.com")));
EXPECT_TRUE(IsChromeAnAppCandidateForTesting(handlers2));
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers3;
handlers3.push_back(Create("Chrome", kArcIntentHelperPackageName,
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www/")));
handlers3.push_back(
Create("fake app 1", "fake.app.package", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.fo.com")));
handlers3.push_back(
Create("fake app 2", "fake.app.package2", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.bar.com")));
EXPECT_TRUE(IsChromeAnAppCandidateForTesting(handlers3));
// Only non-Chrome apps.
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers4;
handlers4.push_back(
Create("fake app 1", "fake.app.package", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.fo.com")));
handlers4.push_back(
Create("fake app 2", "fake.app.package2", /*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www.bar.com")));
handlers4.push_back(Create("fake app 3", "fake.app.package3",
/*activity_name=*/std::string(),
/*is_preferred=*/false, GURL("https://www/")));
EXPECT_FALSE(IsChromeAnAppCandidateForTesting(handlers4));
// Empty vector case.
EXPECT_FALSE(IsChromeAnAppCandidateForTesting(
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo>()));
}
// Tests that when one app is passed to GetAction and it's for ARC IME, the
// picker won't be triggered.
TEST(ArcExternalProtocolDialogTest,
TestGetActionWithArcImeSettingsActivityBypassesIntentPicker) {
constexpr char kPackageForOpeningArcImeSettingsPage[] =
"org.chromium.arc.applauncher";
constexpr char kActivityForOpeningArcImeSettingsPage[] =
"org.chromium.arc.applauncher.InputMethodSettingsActivity";
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
handlers.push_back(Create("ARC IME settings",
kPackageForOpeningArcImeSettingsPage,
kActivityForOpeningArcImeSettingsPage,
/*is_preferred=*/false, /*fallback_url=*/GURL()));
const size_t no_selection = handlers.size();
GurlAndActivityInfo url_and_activity_name = CreateEmptyGurlAndActivityInfo();
bool in_out_safe_to_bypass_ui = false;
EXPECT_EQ(
GetActionResult::HANDLE_URL_IN_ARC,
GetActionForTesting(GURL("intent:foo"), handlers, no_selection,
&url_and_activity_name, &in_out_safe_to_bypass_ui));
EXPECT_TRUE(in_out_safe_to_bypass_ui);
}
MATCHER_P(ProtoEquals, message, "") {
std::string expected_serialized, actual_serialized;
message.SerializeToString(&expected_serialized);
arg.SerializeToString(&actual_serialized);
return expected_serialized == actual_serialized;
}
// Tests that clicking on a device calls through to SharingService.
TEST_F(ArcExternalProtocolDialogTestUtils, TestSelectDeviceForTelLink) {
CreateTab(/*started_from_arc=*/false);
std::string device_guid = "device_guid";
MockSharingService* sharing_service = CreateSharingService();
std::vector<ArcIntentHelperMojoDelegate::IntentHandlerInfo> handlers;
std::vector<SharingTargetDeviceInfo> devices;
devices.push_back(CreateFakeSharingTargetDeviceInfo(device_guid));
GURL phone_number("tel:073%2099%209999%2099");
components_sharing_message::SharingMessage sharing_message;
sharing_message.mutable_click_to_call_message()->set_phone_number(
phone_number.GetContent());
EXPECT_CALL(*sharing_service,
SendMessageToDevice(
Property(&SharingTargetDeviceInfo::guid, device_guid),
testing::_, ProtoEquals(sharing_message), testing::_));
OnIntentPickerClosedForTesting(
web_contents()->GetWeakPtr(), phone_number,
/*safe_to_bypass_ui=*/true, std::move(handlers),
std::make_unique<FakeArcIntentHelperMojo>(), std::move(devices),
/*selected_app_package=*/device_guid, apps::PickerEntryType::kDevice,
apps::IntentPickerCloseReason::OPEN_APP, /*should_persist=*/false);
}
TEST_F(ArcExternalProtocolDialogTestUtils, TestDialogWithoutAppsWithDevices) {
CreateTab(/*started_from_arc=*/false);
MockSharingService* sharing_service = CreateSharingService();
std::vector<SharingTargetDeviceInfo> devices;
devices.push_back(CreateFakeSharingTargetDeviceInfo("device_guid"));
EXPECT_CALL(*sharing_service, GetDeviceCandidates(testing::_))
.WillOnce(testing::Return(testing::ByMove(std::move(devices))));
base::RunLoop run_loop;
ClickToCallUiController::GetOrCreateFromWebContents(web_contents())
->set_on_dialog_shown_closure_for_testing(run_loop.QuitClosure());
bool handled = false;
RunArcExternalProtocolDialog(
GURL("tel:12341234"), /*initiating_origin=*/std::nullopt,
web_contents()->GetWeakPtr(), ui::PAGE_TRANSITION_LINK,
/*has_user_gesture=*/true, /*is_in_fenced_frame_tree=*/false,
std::make_unique<FakeArcIntentHelperMojo>(),
base::BindOnce([](bool* handled, bool result) { *handled = result; },
&handled));
// Wait until the bubble is visible.
run_loop.Run();
EXPECT_TRUE(handled);
}
TEST_F(ArcExternalProtocolDialogTestUtils,
TestDialogWithoutAppsWithDevicesInFencedFrameWithGesture) {
CreateTab(/*started_from_arc=*/false);
MockSharingService* sharing_service = CreateSharingService();
std::vector<SharingTargetDeviceInfo> devices;
devices.push_back(CreateFakeSharingTargetDeviceInfo("device_guid"));
EXPECT_CALL(*sharing_service, GetDeviceCandidates(testing::_))
.WillOnce(testing::Return(testing::ByMove(std::move(devices))));
base::RunLoop run_loop;
ClickToCallUiController::GetOrCreateFromWebContents(web_contents())
->set_on_dialog_shown_closure_for_testing(run_loop.QuitClosure());
bool handled = false;
RunArcExternalProtocolDialog(
GURL("tel:12341234"), /*initiating_origin=*/std::nullopt,
web_contents()->GetWeakPtr(), ui::PAGE_TRANSITION_AUTO_SUBFRAME,
/*has_user_gesture=*/true, /*is_in_fenced_frame_tree=*/true,
std::make_unique<FakeArcIntentHelperMojo>(),
base::BindOnce([](bool* handled, bool result) { *handled = result; },
&handled));
// Wait until the bubble is visible.
run_loop.Run();
EXPECT_TRUE(handled);
}
TEST_F(ArcExternalProtocolDialogTestUtils,
TestDialogWithoutAppsWithDevicesInFencedFrameWithoutGesture) {
CreateTab(/*started_from_arc=*/false);
MockSharingService* sharing_service = CreateSharingService();
EXPECT_CALL(*sharing_service, GetDeviceCandidates).Times(0);
base::RunLoop run_loop;
ClickToCallUiController::GetOrCreateFromWebContents(web_contents())
->set_on_dialog_shown_closure_for_testing(run_loop.QuitClosure());
std::optional<bool> handled;
RunArcExternalProtocolDialog(
GURL("tel:12341234"), /*initiating_origin=*/std::nullopt,
web_contents()->GetWeakPtr(), ui::PAGE_TRANSITION_AUTO_SUBFRAME,
/*has_user_gesture=*/false, /*is_in_fenced_frame_tree=*/true,
std::make_unique<FakeArcIntentHelperMojo>(),
base::BindOnce(
[](std::optional<bool>* handled, bool result) { *handled = result; },
&handled));
EXPECT_TRUE(handled.has_value());
EXPECT_FALSE(*handled);
}
} // namespace arc
|