1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/enterprise/connectors/analysis/content_analysis_dialog_controller.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.h"
#include "chrome/browser/enterprise/connectors/analysis/content_analysis_downloads_delegate.h"
#include "chrome/browser/enterprise/connectors/analysis/content_analysis_features.h"
#include "chrome/browser/enterprise/connectors/test/deep_scanning_browsertest_base.h"
#include "chrome/browser/enterprise/connectors/test/deep_scanning_test_utils.h"
#include "chrome/browser/enterprise/connectors/test/fake_content_analysis_delegate.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_utils.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/grit/theme_resources.h"
#include "components/download/public/common/mock_download_item.h"
#include "components/enterprise/common/proto/connectors.pb.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/mojom/dialog_button.mojom.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/views/accessibility/view_accessibility.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/controls/textarea/textarea.h"
#include "ui/views/controls/throbber.h"
#include "ui/views/controls/webview/web_dialog_view.h"
#include "ui/views/test/ax_event_counter.h"
#include "ui/views/test/views_test_utils.h"
#include "ui/web_dialogs/test/test_web_dialog_delegate.h"
namespace enterprise_connectors {
// Tests the behavior of the dialog in the following ways:
// - It shows the appropriate buttons depending on its state.
// - It transitions from states in the correct order.
// - It respects time constraints (minimum shown time, initial delay, timeout)
// - It is always destroyed, therefore |quit_closure_| is called in the dtor
// observer.
// - It sends accessibility events correctly.
class ContentAnalysisDialogBehaviorBrowserTest
: public test::DeepScanningBrowserTestBase,
public ContentAnalysisDialogController::TestObserver,
public testing::WithParamInterface<
std::tuple<bool, bool, base::TimeDelta>> {
public:
ContentAnalysisDialogBehaviorBrowserTest()
: ax_event_counter_(views::AXUpdateNotifier::Get()) {
ContentAnalysisDialogController::SetObserverForTesting(this);
expected_scan_result_ = dlp_success() && malware_success();
}
void ConstructorCalled(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
ctor_called_timestamp_ = timestamp;
dialog_ = dialog;
// The scan should be pending when constructed.
EXPECT_TRUE(dialog_->is_pending());
// The dialog should only be constructed once.
EXPECT_FALSE(ctor_called_);
ctor_called_ = true;
}
void ViewsFirstShown(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
DCHECK_EQ(dialog, dialog_);
first_shown_timestamp_ = timestamp;
// The dialog can only be first shown in the pending or failure case.
EXPECT_TRUE(dialog_->is_pending() || dialog_->is_failure());
// If the failure dialog was shown immediately, ensure that was expected and
// set |pending_shown_| for future assertions.
if (dialog_->is_failure()) {
EXPECT_FALSE(expected_scan_result_);
pending_shown_ = false;
} else {
pending_shown_ = true;
}
// The dialog's buttons should be Cancel in the pending and fail case.
EXPECT_EQ(dialog_->buttons(),
static_cast<int>(ui::mojom::DialogButton::kCancel));
// Record the number of AX events until now to check if the text update adds
// one later.
ax_events_count_when_first_shown_ =
ax_event_counter_.GetCount(ax::mojom::Event::kAlert);
// The dialog should only be shown once some time after being constructed.
EXPECT_TRUE(ctor_called_);
EXPECT_FALSE(dialog_first_shown_);
// The initial dialog should only have the top views that are present on
// every state initialized, and everything else should be null.
EXPECT_TRUE(dialog->GetTopImageForTesting());
EXPECT_TRUE(dialog->GetSideIconSpinnerForTesting());
EXPECT_TRUE(dialog->GetMessageForTesting());
EXPECT_FALSE(dialog->GetLearnMoreLinkForTesting());
EXPECT_FALSE(dialog->GetBypassJustificationLabelForTesting());
EXPECT_FALSE(dialog->GetBypassJustificationTextareaForTesting());
EXPECT_FALSE(dialog->GetJustificationTextLengthForTesting());
dialog_first_shown_ = true;
}
void DialogUpdated(ContentAnalysisDialogController* dialog,
FinalContentAnalysisResult result) override {
DCHECK_EQ(dialog, dialog_);
dialog_updated_timestamp_ = base::TimeTicks::Now();
// The dialog should not be updated if the failure was shown immediately.
EXPECT_TRUE(pending_shown_);
// The dialog should only be updated after an initial delay.
base::TimeDelta delay = dialog_updated_timestamp_ - first_shown_timestamp_;
EXPECT_GE(delay,
ContentAnalysisDialogController::GetMinimumPendingDialogTime());
// The dialog can only be updated to the success or failure case.
EXPECT_TRUE(dialog_->is_result());
bool is_success = result == FinalContentAnalysisResult::SUCCESS;
EXPECT_EQ(dialog_->is_success(), is_success);
EXPECT_EQ(dialog_->is_success(), expected_scan_result_);
// The dialog's buttons should be Cancel in the fail case and nothing in the
// success case.
ui::mojom::DialogButton expected_buttons =
dialog_->is_success() ? ui::mojom::DialogButton::kNone
: ui::mojom::DialogButton::kCancel;
EXPECT_EQ(static_cast<int>(expected_buttons), dialog_->buttons());
// The dialog should only be updated once some time after being shown.
EXPECT_TRUE(dialog_first_shown_);
EXPECT_FALSE(dialog_updated_);
// TODO(crbug.com/40150258): Re-enable this for Mac.
#if !BUILDFLAG(IS_MAC)
// The dialog being updated implies an accessibility alert is sent.
EXPECT_EQ(ax_events_count_when_first_shown_ + 1,
ax_event_counter_.GetCount(ax::mojom::Event::kAlert));
#endif
// The updated dialog should have every relevant view initialized.
EXPECT_TRUE(dialog->GetTopImageForTesting());
EXPECT_FALSE(dialog->GetSideIconSpinnerForTesting());
EXPECT_TRUE(dialog->GetMessageForTesting());
EXPECT_EQ(!!dialog->GetLearnMoreLinkForTesting(),
dialog->has_learn_more_url());
EXPECT_EQ(!!dialog->GetBypassJustificationLabelForTesting(),
dialog->bypass_requires_justification());
EXPECT_EQ(!!dialog->GetBypassJustificationTextareaForTesting(),
dialog->bypass_requires_justification());
EXPECT_EQ(!!dialog->GetJustificationTextLengthForTesting(),
dialog->bypass_requires_justification());
dialog_updated_ = true;
}
void CancelDialogAndDeleteCalled(ContentAnalysisDialogController* dialog,
FinalContentAnalysisResult result) override {
EXPECT_EQ(dialog_, dialog);
EXPECT_NE(result, FinalContentAnalysisResult::FAIL_CLOSED);
if (dialog_->is_cloud()) {
EXPECT_FALSE(dialog_->is_failure());
EXPECT_FALSE(dialog_->is_warning());
}
}
void DestructorCalled(ContentAnalysisDialogController* dialog) override {
dtor_called_timestamp_ = base::TimeTicks::Now();
EXPECT_TRUE(dialog);
EXPECT_EQ(dialog_, dialog);
EXPECT_EQ(dialog_->is_success(), expected_scan_result_);
if (dialog_first_shown_) {
// Ensure the dialog update only occurred if the pending state was shown.
EXPECT_EQ(pending_shown_, dialog_updated_);
// Ensure the success UI timed out properly.
EXPECT_TRUE(dialog_->is_result());
if (dialog_->is_success()) {
// The success dialog should stay open for some time.
base::TimeDelta delay =
dtor_called_timestamp_ - dialog_updated_timestamp_;
EXPECT_GE(delay,
ContentAnalysisDialogController::GetSuccessDialogTimeout());
EXPECT_EQ(static_cast<int>(ui::mojom::DialogButton::kNone),
dialog_->buttons());
} else {
EXPECT_EQ(static_cast<int>(ui::mojom::DialogButton::kCancel),
dialog_->buttons());
}
} else {
// Ensure the dialog update didn't occur if no dialog was shown.
EXPECT_FALSE(dialog_updated_);
}
EXPECT_TRUE(ctor_called_);
// The test is over once the views are destroyed.
CallQuitClosure();
}
bool dlp_success() const { return std::get<0>(GetParam()); }
bool malware_success() const { return std::get<1>(GetParam()); }
base::TimeDelta response_delay() const { return std::get<2>(GetParam()); }
void SetUpOnMainThread() override {
ui::test::TestWebDialogDelegate* delegate =
new ui::test::TestWebDialogDelegate(GURL(url::kAboutBlankURL));
delegate->SetDeleteOnClosedAndObserve(&web_dialog_delegate_destroyed_);
auto view = std::make_unique<views::WebDialogView>(
browser()->profile(), delegate,
std::make_unique<ChromeWebContentsHandler>());
view->SetOwnedByWidget(views::WidgetDelegate::OwnedByWidgetPassKey());
gfx::NativeView parent_view =
browser()->tab_strip_model()->GetActiveWebContents()->GetNativeView();
view_ = view.get();
view_tracker_.SetView(view_);
auto* widget =
views::Widget::CreateWindowWithParent(std::move(view), parent_view);
widget->Show();
EXPECT_TRUE(content::WaitForLoadStop(view_->web_contents()));
}
content::WebContents* GetWebViewDialogContents() {
return view_->web_contents();
}
private:
views::ViewTracker view_tracker_;
raw_ptr<views::WebDialogView, DisableDanglingPtrDetection> view_ = nullptr;
bool web_dialog_delegate_destroyed_ = false;
raw_ptr<ContentAnalysisDialogController, DanglingUntriaged> dialog_;
base::TimeTicks ctor_called_timestamp_;
base::TimeTicks first_shown_timestamp_;
base::TimeTicks dialog_updated_timestamp_;
base::TimeTicks dtor_called_timestamp_;
bool pending_shown_ = false;
bool ctor_called_ = false;
bool dialog_first_shown_ = false;
bool dialog_updated_ = false;
bool expected_scan_result_;
int ax_events_count_when_first_shown_ = 0;
views::test::AXEventCounter ax_event_counter_;
};
namespace {
constexpr base::TimeDelta kNoDelay = base::Seconds(0);
constexpr base::TimeDelta kSmallDelay = base::Milliseconds(300);
constexpr base::TimeDelta kNormalDelay = base::Milliseconds(500);
constexpr char kBlockingScansForDlpAndMalware[] = R"(
{
"service_provider": "google",
"enable": [
{
"url_list": ["*"],
"tags": ["dlp", "malware"]
}
],
"block_until_verdict": 1
})";
constexpr char kBlockingScansForDlp[] = R"(
{
"service_provider": "google",
"enable": [
{
"url_list": ["*"],
"tags": ["dlp"]
}
],
"block_until_verdict": 1
})";
constexpr char kBlockingScansForDlpAndMalwareWithCustomMessage[] = R"(
{
"service_provider": "google",
"enable": [
{
"url_list": ["*"],
"tags": ["dlp", "malware"]
}
],
"block_until_verdict": 1,
"custom_messages": [{
"message": "Custom message",
"learn_more_url": "http://www.example.com/",
"tag": "dlp"
}]
})";
std::string text() {
return std::string(100, 'a');
}
// Tests the behavior of the dialog in the following ways:
// - It closes when the "Cancel" button is clicked.
// - It returns a negative verdict on the scanned content.
// - The "CancelledByUser" metrics are recorded.
class ContentAnalysisDialogCancelPendingScanBrowserTest
: public test::DeepScanningBrowserTestBase,
public ContentAnalysisDialogController::TestObserver {
public:
ContentAnalysisDialogCancelPendingScanBrowserTest() {
ContentAnalysisDialogController::SetObserverForTesting(this);
}
void ViewsFirstShown(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
// Simulate the user clicking "Cancel" after the dialog is first shown.
dialog->CancelDialog();
}
void DestructorCalled(ContentAnalysisDialogController* dialog) override {
// The test is over once the dialog is destroyed.
CallQuitClosure();
}
void ValidateMetrics() const {
ASSERT_EQ(
2u,
histograms_.GetTotalCountsForPrefix("SafeBrowsing.DeepScan.").size());
ASSERT_EQ(1u, histograms_
.GetTotalCountsForPrefix(
"SafeBrowsing.DeepScan.Upload.Duration")
.size());
ASSERT_EQ(1u,
histograms_
.GetTotalCountsForPrefix(
"SafeBrowsing.DeepScan.Upload.CancelledByUser.Duration")
.size());
}
private:
base::HistogramTester histograms_;
};
// Tests the behavior of the dialog in the following ways:
// - It shows the appropriate buttons depending when showing a warning.
// - It calls the appropriate methods when the user bypasses/respects the
// warning.
class ContentAnalysisDialogWarningBrowserTest
: public test::DeepScanningBrowserTestBase,
public ContentAnalysisDialogController::TestObserver,
public testing::WithParamInterface<bool> {
public:
ContentAnalysisDialogWarningBrowserTest() {
ContentAnalysisDialogController::SetObserverForTesting(this);
}
void ViewsFirstShown(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
// The dialog is first shown in the pending state.
ASSERT_TRUE(dialog->is_pending());
ASSERT_EQ(dialog->buttons(),
static_cast<int>(ui::mojom::DialogButton::kCancel));
}
void DialogUpdated(ContentAnalysisDialogController* dialog,
FinalContentAnalysisResult result) override {
ASSERT_TRUE(dialog->is_warning());
// The dialog's buttons should be Ok and Cancel.
ASSERT_EQ(static_cast<int>(ui::mojom::DialogButton::kOk) |
static_cast<int>(ui::mojom::DialogButton::kCancel),
dialog->buttons());
SimulateClickAndEndTest(dialog);
}
void SimulateClickAndEndTest(ContentAnalysisDialogController* dialog) {
if (user_bypasses_warning())
dialog->AcceptDialog();
else
dialog->CancelDialog();
CallQuitClosure();
}
bool user_bypasses_warning() { return GetParam(); }
};
// Tests the behavior of the dialog in the following ways:
// - It shows the appropriate message depending on its access point and scan
// type (file or text).
// - It shows the appropriate top image depending on its access point and scan
// type.
// - It shows the appropriate spinner depending on its state.
class ContentAnalysisDialogAppearanceBrowserTest
: public test::DeepScanningBrowserTestBase,
public ContentAnalysisDialogController::TestObserver,
public testing::WithParamInterface<
std::tuple<bool, bool, safe_browsing::DeepScanAccessPoint, bool>> {
public:
ContentAnalysisDialogAppearanceBrowserTest() {
ContentAnalysisDialogController::SetObserverForTesting(this);
}
void ViewsFirstShown(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
// The dialog initially shows the pending message for the appropriate access
// point and scan type.
std::u16string pending_message = dialog->GetMessageForTesting()->GetText();
std::u16string expected_message;
if (access_point() == safe_browsing::DeepScanAccessPoint::PRINT) {
expected_message = l10n_util::GetStringUTF16(
IDS_DEEP_SCANNING_DIALOG_PRINT_PENDING_MESSAGE);
} else {
expected_message = l10n_util::GetPluralStringFUTF16(
IDS_DEEP_SCANNING_DIALOG_UPLOAD_PENDING_MESSAGE, file_scan() ? 1 : 0);
}
ASSERT_EQ(pending_message, expected_message);
// The top image is the pending one corresponding to the access point.
const gfx::ImageSkia& actual_image =
dialog->GetTopImageForTesting()->GetImage();
const bool use_dark = dialog->ShouldUseDarkTopImage();
int expected_image_id =
use_dark ? IDR_UPLOAD_SCANNING_DARK : IDR_UPLOAD_SCANNING;
gfx::ImageSkia* expected_image =
ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
expected_image_id);
ASSERT_TRUE(expected_image->BackedBySameObjectAs(actual_image));
// The spinner should be present.
ASSERT_TRUE(dialog->GetSideIconSpinnerForTesting());
}
void DialogUpdated(ContentAnalysisDialogController* dialog,
FinalContentAnalysisResult result) override {
// The dialog shows the failure or success message for the appropriate
// access point and scan type.
std::u16string final_message = dialog->GetMessageForTesting()->GetText();
std::u16string expected_message = GetExpectedMessage();
ASSERT_EQ(final_message, expected_message);
// The top image is the failure/success one corresponding to the access
// point and scan type.
const gfx::ImageSkia& actual_image =
dialog->GetTopImageForTesting()->GetImage();
const bool use_dark = dialog->ShouldUseDarkTopImage();
int expected_image_id =
success()
? (use_dark ? IDR_UPLOAD_SUCCESS_DARK : IDR_UPLOAD_SUCCESS)
: (use_dark ? IDR_UPLOAD_VIOLATION_DARK : IDR_UPLOAD_VIOLATION);
gfx::ImageSkia* expected_image =
ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
expected_image_id);
ASSERT_TRUE(expected_image->BackedBySameObjectAs(actual_image));
// The spinner should not be present in the final result since nothing is
// pending.
ASSERT_FALSE(dialog->GetSideIconSpinnerForTesting());
}
virtual std::u16string GetExpectedMessage() {
if (access_point() == safe_browsing::DeepScanAccessPoint::PRINT) {
return success() ? l10n_util::GetStringUTF16(
IDS_DEEP_SCANNING_DIALOG_PRINT_SUCCESS_MESSAGE)
: l10n_util::GetStringUTF16(
IDS_DEEP_SCANNING_DIALOG_PRINT_WARNING_MESSAGE);
}
int files_count = file_scan() ? 1 : 0;
return success()
? l10n_util::GetPluralStringFUTF16(
IDS_DEEP_SCANNING_DIALOG_SUCCESS_MESSAGE, files_count)
: l10n_util::GetPluralStringFUTF16(
IDS_DEEP_SCANNING_DIALOG_UPLOAD_FAILURE_MESSAGE,
files_count);
}
void DestructorCalled(ContentAnalysisDialogController* dialog) override {
// End the test once the dialog gets destroyed.
CallQuitClosure();
}
bool file_scan() const { return std::get<0>(GetParam()); }
bool success() const { return std::get<1>(GetParam()); }
safe_browsing::DeepScanAccessPoint access_point() const {
return std::get<2>(GetParam());
}
bool has_custom_rule_message() { return std::get<3>(GetParam()); }
};
// Tests the behavior of the dialog in the same way as
// ContentAnalysisDialogAppearanceBrowserTest but with a custom
// message set by the admin.
class ContentAnalysisDialogCustomMessageBrowserTest
: public ContentAnalysisDialogAppearanceBrowserTest {
private:
void DialogUpdated(ContentAnalysisDialogController* dialog,
FinalContentAnalysisResult result) override {
// The dialog shows the failure or success message for the appropriate
// access point and scan type.
views::StyledLabel* final_message = dialog->GetMessageForTesting();
ASSERT_TRUE(final_message);
if ((dialog->is_failure() || dialog->is_warning()) &&
has_custom_rule_message()) {
// Run layout to get children.
views::test::RunScheduledLayout(final_message);
final_message->SetBounds(0, 0, 1000, 1000);
// Three children as we insert the custom message in the middle of
// IDS_DEEP_SCANNING_DIALOG_CUSTOM_MESSAGE.
ASSERT_EQ(3u, final_message->children().size());
ASSERT_EQ(u"Custom rule message",
final_message->GetFirstLinkForTesting()->GetText());
ASSERT_EQ(
gfx::Font::UNDERLINE,
final_message->GetFirstLinkForTesting()->font_list().GetFontStyle());
// Click on link and check if correct page opens in new tab.
content::WebContentsAddedObserver new_tab_observer;
final_message->ClickFirstLinkForTesting();
ASSERT_EQ(GURL("http://example.com"),
new_tab_observer.GetWebContents()->GetVisibleURL());
} else {
std::u16string expected_message = GetExpectedMessage();
ASSERT_EQ(final_message->GetText(), expected_message);
}
}
std::u16string GetExpectedMessage() override {
if (access_point() == safe_browsing::DeepScanAccessPoint::PRINT) {
return success() ? l10n_util::GetStringUTF16(
IDS_DEEP_SCANNING_DIALOG_PRINT_SUCCESS_MESSAGE)
: l10n_util::GetStringFUTF16(
IDS_DEEP_SCANNING_DIALOG_CUSTOM_MESSAGE,
u"Custom message");
}
int files_count = file_scan() ? 1 : 0;
return success()
? l10n_util::GetPluralStringFUTF16(
IDS_DEEP_SCANNING_DIALOG_SUCCESS_MESSAGE, files_count)
: l10n_util::GetStringFUTF16(
IDS_DEEP_SCANNING_DIALOG_CUSTOM_MESSAGE,
u"Custom message");
}
};
constexpr char kTestUrl[] = "https://google.com";
} // namespace
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogBehaviorBrowserTest, Test) {
base::ScopedAllowBlockingForTesting allow_blocking;
// Setup policies to enable deep scanning, its UI and the responses to be
// simulated.
enterprise_connectors::test::SetAnalysisConnector(
browser()->profile()->GetPrefs(), FILE_ATTACHED,
kBlockingScansForDlpAndMalware);
SetStatusCallbackResponse(
safe_browsing::SimpleContentAnalysisResponseForTesting(
dlp_success(), malware_success(), /*has_custom_rule_message=*/false));
// Set up delegate test values.
test::FakeContentAnalysisDelegate::SetResponseDelay(response_delay());
SetUpDelegate();
bool called = false;
base::RunLoop run_loop;
SetQuitClosure(run_loop.QuitClosure());
ContentAnalysisDelegate::Data data;
CreateFilesForTest({"foo.doc"}, {"content"}, &data);
ASSERT_TRUE(ContentAnalysisDelegate::IsEnabled(
browser()->profile(), GURL(kTestUrl), &data,
enterprise_connectors::AnalysisConnector::FILE_ATTACHED));
ContentAnalysisDelegate::CreateForWebContents(
browser()->tab_strip_model()->GetActiveWebContents(), std::move(data),
base::BindOnce(
[](bool* called, const ContentAnalysisDelegate::Data& data,
ContentAnalysisDelegate::Result& result) { *called = true; },
&called),
safe_browsing::DeepScanAccessPoint::UPLOAD);
run_loop.Run();
EXPECT_TRUE(called);
}
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogBehaviorBrowserTest,
NoWebContentsModalDialogManager) {
base::ScopedAllowBlockingForTesting allow_blocking;
// Setup policies to enable deep scanning, its UI and the responses to be
// simulated.
enterprise_connectors::test::SetAnalysisConnector(
browser()->profile()->GetPrefs(), FILE_ATTACHED,
kBlockingScansForDlpAndMalware);
SetStatusCallbackResponse(
safe_browsing::SimpleContentAnalysisResponseForTesting(
dlp_success(), malware_success(), /*has_custom_rule_message=*/false));
// Set up delegate test values.
test::FakeContentAnalysisDelegate::SetResponseDelay(response_delay());
SetUpDelegate();
base::RunLoop run_loop;
ContentAnalysisDelegate::Data data;
CreateFilesForTest({"foo.doc"}, {"content"}, &data);
ASSERT_TRUE(ContentAnalysisDelegate::IsEnabled(
browser()->profile(), GURL(kTestUrl), &data,
enterprise_connectors::AnalysisConnector::FILE_ATTACHED));
ContentAnalysisDelegate::CreateForWebContents(
GetWebViewDialogContents(), std::move(data),
base::BindOnce(
[](base::OnceClosure quit_closure,
const ContentAnalysisDelegate::Data& data,
ContentAnalysisDelegate::Result& result) {
std::move(quit_closure).Run();
},
run_loop.QuitClosure()),
safe_browsing::DeepScanAccessPoint::UPLOAD);
run_loop.Run();
}
// The scan type controls if DLP, malware or both are enabled via policies. The
// dialog currently behaves identically in all 3 cases, so this parameter
// ensures this assumption is not broken by new code.
//
// The DLP/Malware success parameters determine how the response is populated,
// and therefore what the dialog should show.
//
// The three different delays test three cases:
// kNoDelay: The response is as fast as possible, and therefore the pending
// UI is not shown (kNoDelay < GetInitialUIDelay).
// kSmallDelay: The response is not fast enough to prevent the pending UI from
// showing, but fast enough that it hasn't been show long enough
// (GetInitialDelay < kSmallDelay < GetMinimumPendingDialogTime).
// kNormalDelay: The response is slow enough that the pending UI is shown for
// more than its minimum duration (GetMinimumPendingDialogTime <
// kNormalDelay).
INSTANTIATE_TEST_SUITE_P(
,
ContentAnalysisDialogBehaviorBrowserTest,
testing::Combine(
/*dlp_success*/ testing::Bool(),
/*malware_success*/ testing::Bool(),
/*response_delay*/
testing::Values(kNoDelay, kSmallDelay, kNormalDelay)));
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogCancelPendingScanBrowserTest,
Test) {
base::ScopedAllowBlockingForTesting allow_blocking;
// Setup policies to enable deep scanning, its UI and the responses to be
// simulated.
enterprise_connectors::test::SetAnalysisConnector(
browser()->profile()->GetPrefs(), FILE_ATTACHED, kBlockingScansForDlp);
SetStatusCallbackResponse(
safe_browsing::SimpleContentAnalysisResponseForTesting(
/*dlp=*/true, /*malware=*/std::nullopt,
/*has_custom_rule_message=*/false));
// Set up delegate test values. An unresponsive delegate is set up to avoid
// a race between the file responses and the "Cancel" button being clicked.
test::FakeContentAnalysisDelegate::SetResponseDelay(kSmallDelay);
SetUpUnresponsiveDelegate();
bool called = false;
base::RunLoop run_loop;
SetQuitClosure(run_loop.QuitClosure());
ContentAnalysisDelegate::Data data;
CreateFilesForTest({"foo.doc", "bar.doc", "baz.doc"},
{"random", "file", "contents"}, &data);
ASSERT_TRUE(ContentAnalysisDelegate::IsEnabled(
browser()->profile(), GURL(kTestUrl), &data,
enterprise_connectors::AnalysisConnector::FILE_ATTACHED));
ContentAnalysisDelegate::CreateForWebContents(
browser()->tab_strip_model()->GetActiveWebContents(), std::move(data),
base::BindOnce(
[](bool* called, const ContentAnalysisDelegate::Data& data,
ContentAnalysisDelegate::Result& result) {
for (bool paths_result : result.paths_results)
ASSERT_FALSE(paths_result);
*called = true;
},
&called),
safe_browsing::DeepScanAccessPoint::UPLOAD);
run_loop.Run();
EXPECT_TRUE(called);
ValidateMetrics();
}
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogWarningBrowserTest, Test) {
base::ScopedAllowBlockingForTesting allow_blocking;
// Setup policies.
enterprise_connectors::test::SetAnalysisConnector(
browser()->profile()->GetPrefs(), FILE_ATTACHED, kBlockingScansForDlp);
// Setup the DLP warning response.
enterprise_connectors::ContentAnalysisResponse response;
auto* result = response.add_results();
result->set_tag("dlp");
result->set_status(
enterprise_connectors::ContentAnalysisResponse::Result::SUCCESS);
auto* rule = result->add_triggered_rules();
rule->set_rule_name("warning_rule_name");
rule->set_action(enterprise_connectors::TriggeredRule::WARN);
SetStatusCallbackResponse(response);
// Set up delegate.
SetUpDelegate();
bool called = false;
base::RunLoop run_loop;
SetQuitClosure(run_loop.QuitClosure());
ContentAnalysisDelegate::Data data;
data.text.emplace_back(text());
data.text.emplace_back(text());
CreateFilesForTest({"foo.doc", "bar.doc"}, {"file", "content"}, &data);
ASSERT_TRUE(ContentAnalysisDelegate::IsEnabled(
browser()->profile(), GURL(kTestUrl), &data,
enterprise_connectors::AnalysisConnector::FILE_ATTACHED));
ContentAnalysisDelegate::CreateForWebContents(
browser()->tab_strip_model()->GetActiveWebContents(), std::move(data),
base::BindOnce(
[](bool* called, bool user_bypasses_warning,
const ContentAnalysisDelegate::Data& data,
ContentAnalysisDelegate::Result& result) {
ASSERT_EQ(result.text_results.size(), 2u);
ASSERT_EQ(result.text_results[0], user_bypasses_warning);
ASSERT_EQ(result.text_results[1], user_bypasses_warning);
ASSERT_EQ(result.paths_results.size(), 2u);
ASSERT_EQ(result.paths_results[0], user_bypasses_warning);
ASSERT_EQ(result.paths_results[1], user_bypasses_warning);
*called = true;
},
&called, user_bypasses_warning()),
safe_browsing::DeepScanAccessPoint::UPLOAD);
run_loop.Run();
EXPECT_TRUE(called);
}
INSTANTIATE_TEST_SUITE_P(,
ContentAnalysisDialogWarningBrowserTest,
/*user_bypasses_warning=*/testing::Bool());
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogAppearanceBrowserTest, Test) {
base::ScopedAllowBlockingForTesting allow_blocking;
// Setup policies to enable deep scanning, its UI and the responses to be
// simulated.
enterprise_connectors::test::SetAnalysisConnector(
browser()->profile()->GetPrefs(), FILE_ATTACHED,
kBlockingScansForDlpAndMalware);
SetStatusCallbackResponse(
safe_browsing::SimpleContentAnalysisResponseForTesting(
success(), success(), /*has_custom_rule_message=*/false));
// Set up delegate test values.
test::FakeContentAnalysisDelegate::SetResponseDelay(kSmallDelay);
SetUpDelegate();
bool called = false;
base::RunLoop run_loop;
SetQuitClosure(run_loop.QuitClosure());
ContentAnalysisDelegate::Data data;
// Use a file path or text to validate the appearance of the dialog for both
// types of scans.
if (file_scan())
CreateFilesForTest({"foo.doc"}, {"content"}, &data);
else
data.text.emplace_back(text());
ASSERT_TRUE(ContentAnalysisDelegate::IsEnabled(
browser()->profile(), GURL(kTestUrl), &data,
enterprise_connectors::AnalysisConnector::FILE_ATTACHED));
ContentAnalysisDelegate::CreateForWebContents(
browser()->tab_strip_model()->GetActiveWebContents(), std::move(data),
base::BindLambdaForTesting(
[this, &called](const ContentAnalysisDelegate::Data& data,
ContentAnalysisDelegate::Result& result) {
for (bool paths_result : result.paths_results)
ASSERT_EQ(paths_result, success());
called = true;
}),
access_point());
run_loop.Run();
EXPECT_TRUE(called);
}
INSTANTIATE_TEST_SUITE_P(
,
ContentAnalysisDialogAppearanceBrowserTest,
testing::Combine(
/*file_scan=*/testing::Bool(),
/*success=*/testing::Bool(),
/*access_point=*/
testing::Values(safe_browsing::DeepScanAccessPoint::UPLOAD,
safe_browsing::DeepScanAccessPoint::DRAG_AND_DROP,
safe_browsing::DeepScanAccessPoint::PASTE,
safe_browsing::DeepScanAccessPoint::PRINT),
/*has_custom_rule_message=*/testing::Bool()));
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogCustomMessageBrowserTest, Test) {
base::ScopedAllowBlockingForTesting allow_blocking;
// Setup policies to enable deep scanning, its UI and the responses to be
// simulated.
enterprise_connectors::test::SetAnalysisConnector(
browser()->profile()->GetPrefs(), FILE_ATTACHED,
kBlockingScansForDlpAndMalwareWithCustomMessage);
SetStatusCallbackResponse(
safe_browsing::SimpleContentAnalysisResponseForTesting(
success(), success(), has_custom_rule_message()));
// Set up delegate test values.
test::FakeContentAnalysisDelegate::SetResponseDelay(kSmallDelay);
SetUpDelegate();
bool called = false;
base::RunLoop run_loop;
SetQuitClosure(run_loop.QuitClosure());
ContentAnalysisDelegate::Data data;
// Use a file path or text to validate the appearance of the dialog for both
// types of scans.
if (file_scan()) {
CreateFilesForTest({"foo.doc"}, {"content"}, &data);
} else {
data.text.emplace_back(text());
}
ASSERT_TRUE(ContentAnalysisDelegate::IsEnabled(
browser()->profile(), GURL(kTestUrl), &data,
enterprise_connectors::AnalysisConnector::FILE_ATTACHED));
ContentAnalysisDelegate::CreateForWebContents(
browser()->tab_strip_model()->GetActiveWebContents(), std::move(data),
base::BindLambdaForTesting(
[this, &called](const ContentAnalysisDelegate::Data& data,
ContentAnalysisDelegate::Result& result) {
for (bool paths_result : result.paths_results) {
ASSERT_EQ(paths_result, success());
}
called = true;
}),
access_point());
run_loop.Run();
EXPECT_TRUE(called);
}
INSTANTIATE_TEST_SUITE_P(
,
ContentAnalysisDialogCustomMessageBrowserTest,
testing::Combine(
/*file_scan=*/testing::Bool(),
/*success=*/testing::Bool(),
/*access_point=*/
testing::Values(safe_browsing::DeepScanAccessPoint::UPLOAD,
safe_browsing::DeepScanAccessPoint::DRAG_AND_DROP,
safe_browsing::DeepScanAccessPoint::PASTE,
safe_browsing::DeepScanAccessPoint::PRINT),
/*has_custom_rule_message=*/testing::Bool()));
class ContentAnalysisDialogPlainTests : public InProcessBrowserTest {
public:
ContentAnalysisDialogPlainTests() {
ContentAnalysisDialogController::SetShowDialogDelayForTesting(kNoDelay);
}
void OpenCallback() { ++times_open_called_; }
void DiscardCallback() { ++times_discard_called_; }
protected:
class MockDelegate : public ContentAnalysisDelegateBase {
public:
~MockDelegate() override = default;
void BypassWarnings(
std::optional<std::u16string> user_justification) override {}
void Cancel(bool warning) override {}
std::optional<std::u16string> GetCustomMessage() const override {
return std::nullopt;
}
std::optional<GURL> GetCustomLearnMoreUrl() const override {
return std::nullopt;
}
std::optional<std::vector<std::pair<gfx::Range, GURL>>>
GetCustomRuleMessageRanges() const override {
return std::nullopt;
}
bool BypassRequiresJustification() const override {
return bypass_requires_justification_;
}
std::u16string GetBypassJustificationLabel() const override {
return u"MOCK_BYPASS_JUSTIFICATION_LABEL";
}
std::optional<std::u16string> OverrideCancelButtonText() const override {
return std::nullopt;
}
void SetBypassRequiresJustification(bool value) {
bypass_requires_justification_ = value;
}
private:
bool bypass_requires_justification_ = false;
};
class MockCustomMessageDelegate : public ContentAnalysisDelegateBase {
public:
MockCustomMessageDelegate(const std::u16string& message, const GURL& url)
: custom_message_(message), learn_more_url_(url) {}
MockCustomMessageDelegate(
const std::u16string& message,
const std::vector<std::pair<gfx::Range, GURL>>& ranges)
: custom_message_(message), custom_rule_message_ranges_(ranges) {}
~MockCustomMessageDelegate() override = default;
void BypassWarnings(
std::optional<std::u16string> user_justification) override {}
void Cancel(bool warning) override {}
std::optional<std::u16string> GetCustomMessage() const override {
return custom_message_;
}
std::optional<GURL> GetCustomLearnMoreUrl() const override {
return learn_more_url_;
}
std::optional<std::vector<std::pair<gfx::Range, GURL>>>
GetCustomRuleMessageRanges() const override {
return custom_rule_message_ranges_;
}
bool BypassRequiresJustification() const override { return false; }
std::u16string GetBypassJustificationLabel() const override {
return u"MOCK_BYPASS_JUSTIFICATION_LABEL";
}
std::optional<std::u16string> OverrideCancelButtonText() const override {
return std::nullopt;
}
private:
std::u16string custom_message_;
GURL learn_more_url_;
std::vector<std::pair<gfx::Range, GURL>> custom_rule_message_ranges_;
};
ContentAnalysisDialogController* dialog() { return dialog_; }
ContentAnalysisDialogController* CreateContentAnalysisDialog(
std::unique_ptr<ContentAnalysisDelegateBase> delegate,
FinalContentAnalysisResult result = FinalContentAnalysisResult::SUCCESS) {
// This ctor ends up calling into constrained_window to show itself, in a
// way that relinquishes its ownership. Because of this, new it here and
// let it be deleted by the constrained_window code.
dialog_ = new ContentAnalysisDialogController(
std::move(delegate), true,
browser()->tab_strip_model()->GetActiveWebContents(),
safe_browsing::DeepScanAccessPoint::DOWNLOAD, 0, result);
return dialog_;
}
int times_open_called_ = 0;
int times_discard_called_ = 0;
private:
raw_ptr<ContentAnalysisDialogController, DanglingUntriaged> dialog_;
};
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests, TestCustomMessage) {
enterprise_connectors::ContentAnalysisDialogController::
SetMinimumPendingDialogTimeForTesting(base::Milliseconds(0));
std::unique_ptr<MockCustomMessageDelegate> delegate =
std::make_unique<MockCustomMessageDelegate>(
u"Test", GURL("https://www.example.com"));
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::move(delegate), FinalContentAnalysisResult::SUCCESS);
dialog->ShowResult(FinalContentAnalysisResult::WARNING);
EXPECT_TRUE(dialog->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(), u"Test");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests, TestCustomRuleMessage) {
enterprise_connectors::ContentAnalysisDialogController::
SetMinimumPendingDialogTimeForTesting(base::Milliseconds(0));
std::unique_ptr<MockCustomMessageDelegate> delegate =
std::make_unique<MockCustomMessageDelegate>(
u"Test", std::vector{std::pair{gfx::Range(0, 3),
GURL("https://www.example.com")}});
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::move(delegate), FinalContentAnalysisResult::SUCCESS);
dialog->ShowResult(FinalContentAnalysisResult::WARNING);
EXPECT_TRUE(dialog->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(), u"Test");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestBypassJustification) {
enterprise_connectors::ContentAnalysisDialogController::
SetMinimumPendingDialogTimeForTesting(base::Milliseconds(0));
std::unique_ptr<MockDelegate> delegate = std::make_unique<MockDelegate>();
delegate->SetBypassRequiresJustification(true);
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::move(delegate), FinalContentAnalysisResult::SUCCESS);
dialog->ShowResult(FinalContentAnalysisResult::WARNING);
EXPECT_FALSE(dialog->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
dialog->GetBypassJustificationTextareaForTesting()->InsertOrReplaceText(
u"test");
EXPECT_TRUE(dialog->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestBypassJustificationTooLongDisablesBypassButton) {
enterprise_connectors::ContentAnalysisDialogController::
SetMinimumPendingDialogTimeForTesting(base::Milliseconds(0));
std::unique_ptr<MockDelegate> delegate = std::make_unique<MockDelegate>();
delegate->SetBypassRequiresJustification(true);
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::move(delegate), FinalContentAnalysisResult::SUCCESS);
dialog->ShowResult(FinalContentAnalysisResult::WARNING);
EXPECT_FALSE(dialog->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
dialog->GetBypassJustificationTextareaForTesting()->InsertOrReplaceText(
u"This is a very long string. In fact, it is over two hundred characters "
u"long because that is the maximum length of a bypass justification that "
u"can be entered by a user. When the justification is this long, the "
u"user will not be able to submit it. The maximum length just happens to "
u"be the same as a popular bird-based service's character limit.");
EXPECT_FALSE(dialog->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestOpenInDefaultPendingState) {
ContentAnalysisDialogController* dialog =
CreateContentAnalysisDialog(std::make_unique<MockDelegate>());
EXPECT_TRUE(dialog->GetSideIconSpinnerForTesting());
EXPECT_EQ(
dialog->GetMessageForTesting()->GetText(),
u"Checking this data with your organization's security policies...");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestOpenInWarningState) {
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::make_unique<MockDelegate>(), FinalContentAnalysisResult::WARNING);
EXPECT_EQ(nullptr, dialog->GetSideIconSpinnerForTesting());
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(),
u"This data or your device doesn’t meet some of your organization’s"
u" security policies. Check with your admin on what needs to be "
u"fixed.");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests, TestOpenInBlockState) {
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::make_unique<MockDelegate>(), FinalContentAnalysisResult::FAILURE);
EXPECT_EQ(nullptr, dialog->GetSideIconSpinnerForTesting());
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(),
u"This data or your device doesn’t meet some of your organization’s"
u" security policies. Check with your admin on what needs to be "
u"fixed.");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestOpenInFailClosedState) {
ContentAnalysisDialogController* dialog =
CreateContentAnalysisDialog(std::make_unique<MockDelegate>(),
FinalContentAnalysisResult::FAIL_CLOSED);
EXPECT_EQ(nullptr, dialog->GetSideIconSpinnerForTesting());
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(),
u"Scan failed. This action is blocked by your administrator.");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestOpenInLargeFilesState) {
ContentAnalysisDialogController* dialog =
CreateContentAnalysisDialog(std::make_unique<MockDelegate>(),
FinalContentAnalysisResult::LARGE_FILES);
EXPECT_EQ(nullptr, dialog->GetSideIconSpinnerForTesting());
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(),
u"Some of these files are too big for a security check. You can "
u"upload files up to 50 MB.");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestOpenInEncryptedFilesState) {
ContentAnalysisDialogController* dialog =
CreateContentAnalysisDialog(std::make_unique<MockDelegate>(),
FinalContentAnalysisResult::ENCRYPTED_FILES);
EXPECT_EQ(nullptr, dialog->GetSideIconSpinnerForTesting());
EXPECT_EQ(dialog->GetMessageForTesting()->GetText(),
u"Some of these files are encrypted. Ask their owner to decrypt.");
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestWithDownloadsDelegateBypassWarning) {
download::MockDownloadItem mock_download_item;
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::make_unique<ContentAnalysisDownloadsDelegate>(
u"", u"", GURL(), true,
base::BindOnce(&ContentAnalysisDialogPlainTests::OpenCallback,
base::Unretained(this)),
base::BindOnce(&ContentAnalysisDialogPlainTests::DiscardCallback,
base::Unretained(this)),
&mock_download_item,
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage()),
FinalContentAnalysisResult::WARNING);
EXPECT_EQ(0, times_open_called_);
EXPECT_EQ(0, times_discard_called_);
std::u16string test_user_justification = u"user's justification for bypass";
dialog->GetBypassJustificationTextareaForTesting()->InsertOrReplaceText(
test_user_justification);
dialog->AcceptDialog();
EXPECT_EQ(1, times_open_called_);
EXPECT_EQ(0, times_discard_called_);
enterprise_connectors::ScanResult* stored_result =
static_cast<enterprise_connectors::ScanResult*>(
mock_download_item.GetUserData(
enterprise_connectors::ScanResult::kKey));
ASSERT_TRUE(stored_result);
EXPECT_EQ(stored_result->user_justification, test_user_justification);
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestWithDownloadsDelegateDiscardWarning) {
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::make_unique<ContentAnalysisDownloadsDelegate>(
u"", u"", GURL(), false,
base::BindOnce(&ContentAnalysisDialogPlainTests::OpenCallback,
base::Unretained(this)),
base::BindOnce(&ContentAnalysisDialogPlainTests::DiscardCallback,
base::Unretained(this)),
nullptr,
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage()),
FinalContentAnalysisResult::WARNING);
EXPECT_EQ(0, times_open_called_);
EXPECT_EQ(0, times_discard_called_);
dialog->CancelDialog();
EXPECT_EQ(0, times_open_called_);
EXPECT_EQ(1, times_discard_called_);
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
TestWithDownloadsDelegateDiscardBlock) {
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::make_unique<ContentAnalysisDownloadsDelegate>(
u"", u"", GURL(), false,
base::BindOnce(&ContentAnalysisDialogPlainTests::OpenCallback,
base::Unretained(this)),
base::BindOnce(&ContentAnalysisDialogPlainTests::DiscardCallback,
base::Unretained(this)),
nullptr,
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage()),
FinalContentAnalysisResult::FAILURE);
EXPECT_EQ(0, times_open_called_);
EXPECT_EQ(0, times_discard_called_);
dialog->CancelDialog();
EXPECT_EQ(0, times_open_called_);
EXPECT_EQ(1, times_discard_called_);
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogPlainTests,
BypassJustificationLabelAndTextareaAccessibility) {
enterprise_connectors::ContentAnalysisDialogController::
SetMinimumPendingDialogTimeForTesting(base::Milliseconds(0));
std::unique_ptr<MockDelegate> delegate = std::make_unique<MockDelegate>();
delegate->SetBypassRequiresJustification(true);
ContentAnalysisDialogController* dialog = CreateContentAnalysisDialog(
std::move(delegate), FinalContentAnalysisResult::SUCCESS);
dialog->ShowResult(FinalContentAnalysisResult::WARNING);
// We need the label and its `AXNodeData` to verify that the textarea's name
// matches the name of the label, and that the textarea's labelledby id is
// the accessible id of the label.
auto* label = dialog->GetBypassJustificationLabelForTesting();
EXPECT_TRUE(label);
ui::AXNodeData label_data;
label->GetViewAccessibility().GetAccessibleNodeData(&label_data);
auto* textarea = dialog->GetBypassJustificationTextareaForTesting();
EXPECT_TRUE(textarea);
ui::AXNodeData textarea_data;
textarea->GetViewAccessibility().GetAccessibleNodeData(&textarea_data);
EXPECT_EQ(textarea_data.role, ax::mojom::Role::kTextField);
EXPECT_EQ(textarea->GetViewAccessibility().GetCachedRole(),
ax::mojom::Role::kTextField);
EXPECT_EQ(
textarea_data.GetString16Attribute(ax::mojom::StringAttribute::kName),
label->GetViewAccessibility().GetCachedName());
EXPECT_EQ(textarea_data.GetNameFrom(), ax::mojom::NameFrom::kRelatedElement);
EXPECT_EQ(textarea_data.GetIntListAttribute(
ax::mojom::IntListAttribute::kLabelledbyIds)[0],
label_data.id);
EXPECT_TRUE(textarea_data.HasState(ax::mojom::State::kEditable));
EXPECT_FALSE(textarea_data.HasState(ax::mojom::State::kProtected));
EXPECT_EQ(textarea_data.GetDefaultActionVerb(),
ax::mojom::DefaultActionVerb::kActivate);
}
class ContentAnalysisDialogUiTest
: public DialogBrowserTest,
public testing::WithParamInterface<std::tuple<bool, bool, bool>> {
public:
ContentAnalysisDialogUiTest() {
ContentAnalysisDialogController::SetShowDialogDelayForTesting(kNoDelay);
}
ContentAnalysisDialogUiTest(const ContentAnalysisDialogUiTest&) = delete;
ContentAnalysisDialogUiTest& operator=(const ContentAnalysisDialogUiTest&) =
delete;
~ContentAnalysisDialogUiTest() override = default;
bool custom_message_provided() const { return std::get<0>(GetParam()); }
bool custom_url_provided() const { return std::get<1>(GetParam()); }
bool bypass_justification_enabled() const { return std::get<2>(GetParam()); }
std::u16string get_custom_message() {
return custom_message_provided() ? u"Admin comment" : u"";
}
GURL get_custom_url() {
return custom_url_provided() ? GURL("http://learn-more-url.com/") : GURL();
}
// DialogBrowserTest:
void ShowUi(const std::string& name) override {
auto delegate = std::make_unique<ContentAnalysisDownloadsDelegate>(
u"File Name", get_custom_message(), get_custom_url(),
bypass_justification_enabled(), base::DoNothing(), base::DoNothing(),
nullptr,
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage());
// This ctor ends up calling into constrained_window to show itself, in a
// way that relinquishes its ownership. Because of this, new it here and
// let it be deleted by the constrained_window code.
new ContentAnalysisDialogController(
std::move(delegate), true,
browser()->tab_strip_model()->GetActiveWebContents(),
safe_browsing::DeepScanAccessPoint::DOWNLOAD, 1,
FinalContentAnalysisResult::WARNING);
}
};
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogUiTest, InvokeUi_default) {
ShowAndVerifyUi();
}
INSTANTIATE_TEST_SUITE_P(,
ContentAnalysisDialogUiTest,
testing::Combine(
/*custom_message_exists*/ testing::Bool(),
/*custom_url_exists*/ testing::Bool(),
/*bypass_justification_enabled*/ testing::Bool()));
class ContentAnalysisDialogCustomRuleMessageUiTest
: public ContentAnalysisDialogUiTest {
public:
ContentAnalysisDialogCustomRuleMessageUiTest() {
ContentAnalysisDialogController::SetShowDialogDelayForTesting(kNoDelay);
}
// DialogBrowserTest:
void ShowUi(const std::string& name) override {
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage
custom_rule_message = CreateSampleCustomRuleMessage(
u"Admin rule message", get_custom_url().GetContent());
auto delegate = std::make_unique<ContentAnalysisDownloadsDelegate>(
u"File Name", get_custom_message(), get_custom_url(),
bypass_justification_enabled(), base::DoNothing(), base::DoNothing(),
nullptr, custom_rule_message);
// This ctor ends up calling into constrained_window to show itself, in a
// way that relinquishes its ownership. Because of this, new it here and
// let it be deleted by the constrained_window code.
new ContentAnalysisDialogController(
std::move(delegate), true,
browser()->tab_strip_model()->GetActiveWebContents(),
safe_browsing::DeepScanAccessPoint::DOWNLOAD, 1,
FinalContentAnalysisResult::WARNING);
}
private:
base::test::ScopedFeatureList scoped_features;
};
IN_PROC_BROWSER_TEST_P(ContentAnalysisDialogCustomRuleMessageUiTest,
InvokeUi_default) {
ShowAndVerifyUi();
}
INSTANTIATE_TEST_SUITE_P(,
ContentAnalysisDialogCustomRuleMessageUiTest,
testing::Combine(
/*custom_message_exists*/ testing::Bool(),
/*custom_url_exists*/ testing::Bool(),
/*bypass_justification_enabled*/ testing::Bool()));
class ContentAnalysisDialogDownloadObserverTest
: public test::DeepScanningBrowserTestBase,
public ContentAnalysisDialogController::TestObserver {
public:
ContentAnalysisDialogDownloadObserverTest() {
ContentAnalysisDialogController::SetObserverForTesting(this);
}
void ConstructorCalled(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
ctor_called_ = true;
}
void ViewsFirstShown(ContentAnalysisDialogController* dialog,
base::TimeTicks timestamp) override {
std::move(views_first_shown_closure_).Run();
}
void DestructorCalled(ContentAnalysisDialogController* dialog) override {
std::move(dtor_called_closure_).Run();
}
protected:
bool ctor_called_ = false;
base::OnceClosure views_first_shown_closure_;
base::OnceClosure dtor_called_closure_;
};
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogDownloadObserverTest,
DownloadOpened) {
download::MockDownloadItem mock_download_item;
base::RunLoop show_run_loop;
views_first_shown_closure_ = show_run_loop.QuitClosure();
new ContentAnalysisDialogController(
std::make_unique<ContentAnalysisDownloadsDelegate>(
u"", u"", GURL(), true,
/* open_file_callback */ base::DoNothing(),
/* discard_callback */ base::DoNothing(), &mock_download_item,
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage()),
true, browser()->tab_strip_model()->GetActiveWebContents(),
safe_browsing::DeepScanAccessPoint::DOWNLOAD, /* file_count */ 1,
FinalContentAnalysisResult::WARNING, &mock_download_item);
show_run_loop.Run();
EXPECT_TRUE(ctor_called_);
base::RunLoop dtor_run_loop;
dtor_called_closure_ = dtor_run_loop.QuitClosure();
mock_download_item.NotifyObserversDownloadOpened();
dtor_run_loop.Run();
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogDownloadObserverTest,
DownloadUpdated) {
download::MockDownloadItem mock_download_item;
base::RunLoop show_run_loop;
views_first_shown_closure_ = show_run_loop.QuitClosure();
new ContentAnalysisDialogController(
std::make_unique<ContentAnalysisDownloadsDelegate>(
u"", u"", GURL(), true,
/* open_file_callback */ base::DoNothing(),
/* discard_callback */ base::DoNothing(), &mock_download_item,
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage()),
true, browser()->tab_strip_model()->GetActiveWebContents(),
safe_browsing::DeepScanAccessPoint::DOWNLOAD, /* file_count */ 1,
FinalContentAnalysisResult::WARNING, &mock_download_item);
show_run_loop.Run();
EXPECT_TRUE(ctor_called_);
base::RunLoop dtor_run_loop;
dtor_called_closure_ = dtor_run_loop.QuitClosure();
// Randomly updating the download should not close the dialog.
EXPECT_CALL(mock_download_item, GetDangerType())
.WillOnce(testing::Return(download::DOWNLOAD_DANGER_TYPE_ASYNC_SCANNING));
mock_download_item.NotifyObserversDownloadUpdated();
EXPECT_FALSE(dtor_run_loop.AnyQuitCalled());
// Updating the download with a user validation results in the dialog closing.
EXPECT_CALL(mock_download_item, GetDangerType())
.WillOnce(testing::Return(download::DOWNLOAD_DANGER_TYPE_USER_VALIDATED));
mock_download_item.NotifyObserversDownloadUpdated();
dtor_run_loop.Run();
}
IN_PROC_BROWSER_TEST_F(ContentAnalysisDialogDownloadObserverTest,
DownloadDestroyed) {
auto mock_download_item = std::make_unique<download::MockDownloadItem>();
base::RunLoop show_run_loop;
views_first_shown_closure_ = show_run_loop.QuitClosure();
new ContentAnalysisDialogController(
std::make_unique<ContentAnalysisDownloadsDelegate>(
u"", u"", GURL(), true,
/* open_file_callback */ base::DoNothing(),
/* discard_callback */ base::DoNothing(), mock_download_item.get(),
ContentAnalysisResponse::Result::TriggeredRule::CustomRuleMessage()),
true, browser()->tab_strip_model()->GetActiveWebContents(),
safe_browsing::DeepScanAccessPoint::DOWNLOAD, /* file_count */ 1,
FinalContentAnalysisResult::WARNING, mock_download_item.get());
show_run_loop.Run();
EXPECT_TRUE(ctor_called_);
base::RunLoop dtor_run_loop;
dtor_called_closure_ = dtor_run_loop.QuitClosure();
mock_download_item.reset();
dtor_run_loop.Run();
}
} // namespace enterprise_connectors
|