1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/api/bookmarks/bookmarks_api.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/extensions/api/bookmarks/test/bookmarks_api_matchers.h"
#include "chrome/browser/extensions/bookmarks/bookmarks_error_constants.h"
#include "chrome/browser/extensions/bookmarks/bookmarks_features.h"
#include "chrome/browser/extensions/bookmarks/bookmarks_helpers.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/common/extensions/api/bookmarks.h"
#include "chrome/test/base/testing_profile.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/signin/public/base/signin_switches.h"
#include "extensions/browser/api_test_utils.h"
#include "extensions/browser/event_router.h"
#include "extensions/browser/event_router_factory.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/test_event_router_observer.h"
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
using ::testing::Eq;
using ::testing::ExplainMatchResult;
using ::testing::Pointwise;
namespace extensions {
class BookmarksApiUnittest : public ExtensionServiceTestBase {
public:
BookmarksApiUnittest() = default;
BookmarksApiUnittest(const BookmarksApiUnittest&) = delete;
BookmarksApiUnittest& operator=(const BookmarksApiUnittest&) = delete;
void SetUp() override {
ExtensionServiceTestBase::SetUp();
ExtensionServiceInitParams params;
params.enable_bookmark_model = true;
InitializeExtensionService(std::move(params));
model_ = BookmarkModelFactory::GetForBrowserContext(profile());
bookmarks::test::WaitForBookmarkModelToLoad(model_);
folder_node_ = model_->AddFolder(model_->other_node(), 0, u"Empty folder");
subfolder_node_ = model_->AddFolder(folder_node_, 0, u"Empty subfolder");
url_node_ = model_->AddURL(model_->other_node(), 0, u"URL", url_);
folder_node_id_ = base::NumberToString(folder_node_->id());
}
raw_ptr<bookmarks::BookmarkModel> model() const { return model_; }
const bookmarks::BookmarkNode* folder_node() const { return folder_node_; }
std::string folder_node_id() const { return folder_node_id_; }
const bookmarks::BookmarkNode* subfolder_node() const {
return subfolder_node_;
}
const bookmarks::BookmarkNode* url_node() const { return url_node_; }
const GURL url() const { return url_; }
private:
raw_ptr<bookmarks::BookmarkModel> model_ = nullptr;
raw_ptr<const bookmarks::BookmarkNode> folder_node_ = nullptr;
raw_ptr<const bookmarks::BookmarkNode> subfolder_node_ = nullptr;
raw_ptr<const bookmarks::BookmarkNode> url_node_ = nullptr;
std::string folder_node_id_;
const GURL url_ = GURL("https://example.org");
};
// Tests that running updating a bookmark folder's url does not succeed.
// Regression test for https://crbug.com/818395.
TEST_F(BookmarksApiUnittest, Update) {
auto update_function = base::MakeRefCounted<BookmarksUpdateFunction>();
ASSERT_EQ(R"(Can't set URL of a bookmark folder.)",
api_test_utils::RunFunctionAndReturnError(
update_function.get(),
absl::StrFormat(R"(["%s", {"url": "https://example.com"}])",
folder_node_id().c_str()),
profile()));
}
// Tests that attempting to create a bookmark with no parent folder specified
// succeeds when only local/syncable bookmarks are available.
TEST_F(BookmarksApiUnittest, Create_NoParentLocalOnly) {
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
create_function.get(), R"([{"title": "New folder"}])", profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
// The new folder should be added as the last child of the local other node.
#if BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Update this test once the default visible
// bookmarks behavior is clarified.
const bookmarks::BookmarkNode* expected_parent = model()->mobile_node();
#else
const bookmarks::BookmarkNode* expected_parent = model()->other_node();
#endif
EXPECT_EQ(result_node.parent_id,
base::NumberToString(expected_parent->id()));
EXPECT_EQ(result_node.index, expected_parent->children().size() - 1);
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
// Tests that attempting to create a bookmark with no parent folder specified
// succeeds and uses the account bookmarks folder when the user is signed in
// with bookmarks in transport mode.
TEST_F(BookmarksApiUnittest, Create_NoParentAccount) {
base::test::ScopedFeatureList scoped_feature_list{
switches::kSyncEnableBookmarksInTransportMode};
model()->CreateAccountPermanentFolders();
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
create_function.get(), R"([{"title": "New folder"}])", profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
// The new folder should be added as the last child of the account other node.
EXPECT_EQ(result_node.parent_id,
base::NumberToString(model()->account_other_node()->id()));
EXPECT_EQ(result_node.index,
model()->account_other_node()->children().size() - 1);
}
#endif // !BUILDFLAG(IS_ANDROID)
// Tests creating a bookmark with a valid parent specified.
TEST_F(BookmarksApiUnittest, Create_ValidParent) {
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
create_function.get(),
absl::StrFormat(R"([{"parentId": "%lu", "title": "New folder"}])",
folder_node()->id()),
profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
// The new folder should be added as the last child of the parent folder.
EXPECT_EQ(result_node.parent_id, folder_node_id());
EXPECT_EQ(result_node.index, folder_node()->children().size() - 1);
}
// Tests creating a bookmark with a valid parent specified.
TEST_F(BookmarksApiUnittest,
Create_SucceedsInLocalParentWhenBothLocalAndAccountBookmarksExist) {
base::test::ScopedFeatureList scoped_feature_list{
switches::kSyncEnableBookmarksInTransportMode};
model()->CreateAccountPermanentFolders();
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
create_function.get(),
absl::StrFormat(R"([{"parentId": "%lu", "title": "New folder"}])",
folder_node()->id()),
profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
// The new folder should be added as the last child of the parent folder.
EXPECT_EQ(result_node.parent_id, folder_node_id());
EXPECT_EQ(result_node.index, folder_node()->children().size() - 1);
}
// Tests that attempting to creating a bookmark with a non-folder parent does
// not add the bookmark to that parent.
// Regression test for https://crbug.com/1441071.
TEST_F(BookmarksApiUnittest, Create_NonFolderParent) {
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
create_function.get(),
absl::StrFormat(R"([{"parentId": "%d"}])", url_node()->id()), profile());
ASSERT_EQ("Parameter 'parentId' does not specify a folder.", error);
const bookmarks::BookmarkNode* url_node =
model()->GetMostRecentlyAddedUserNodeForURL(url());
ASSERT_TRUE(url_node->children().empty());
}
// Tests that attempting to create a bookmark with a parent that is not
// visible fails.
TEST_F(BookmarksApiUnittest, Create_NonExistentParent) {
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
create_function.get(), R"([{"parentId": "1234"}])", profile());
EXPECT_EQ(error, bookmarks_errors::kNoParentError);
}
// Tests that attempting to create a bookmark with a parent that is not
// visible fails.
TEST_F(BookmarksApiUnittest, Create_NonVisibleParentNoVisibilityEnforcement) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndDisableFeature(
kEnforceBookmarkVisibilityOnExtensionsAPI);
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
create_function.get(),
absl::StrFormat(R"([{"parentId": "%lu", "title": "New folder"}])",
model()->mobile_node()->id()),
profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
// The new folder should be added as the last child of the parent folder.
EXPECT_EQ(result_node.parent_id,
base::NumberToString(model()->mobile_node()->id()));
EXPECT_EQ(result_node.index, folder_node()->children().size() - 1);
// The mobile node is now visible, as it no longer empty.
ASSERT_TRUE(model()->mobile_node()->IsVisible());
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
TEST_F(BookmarksApiUnittest, Create_NonVisibleParent) {
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto create_function = base::MakeRefCounted<BookmarksCreateFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
create_function.get(),
absl::StrFormat(R"([{"parentId": "%lu", "title": "New folder"}])",
model()->mobile_node()->id()),
profile());
EXPECT_EQ(error, bookmarks_errors::kNoParentError);
}
#endif // !BUILDFLAG(IS_ANDROID)
TEST_F(BookmarksApiUnittest,
Get_SucceedsForLocalPermanentFolderWhenNoAccountFolders) {
auto get_function = base::MakeRefCounted<BookmarksGetFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->other_node()->id()), profile())
.value();
std::vector<const bookmarks::BookmarkNode*> expected_nodes = {
model()->other_node()};
EXPECT_THAT(result.GetList(), ResultMatchesNodes(expected_nodes));
}
TEST_F(BookmarksApiUnittest,
Get_SucceedsForNonEmptyLocalPermanentFolderWhenAccountFolders) {
base::test::ScopedFeatureList scoped_feature_list{
switches::kSyncEnableBookmarksInTransportMode};
model()->CreateAccountPermanentFolders();
auto get_function = base::MakeRefCounted<BookmarksGetFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->other_node()->id()), profile())
.value();
std::vector<const bookmarks::BookmarkNode*> expected_nodes = {
model()->other_node()};
EXPECT_THAT(result.GetList(), ResultMatchesNodes(expected_nodes));
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
TEST_F(BookmarksApiUnittest,
Get_ReturnsEmptyForNonVisibleFolderNoVisibilityEnforcement) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndDisableFeature(
kEnforceBookmarkVisibilityOnExtensionsAPI);
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto get_function = base::MakeRefCounted<BookmarksGetFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->mobile_node()->id()),
profile())
.value();
EXPECT_THAT(result.GetList(), ::testing::IsEmpty());
}
TEST_F(BookmarksApiUnittest, Get_ReturnsErrorForNonVisibleFolder) {
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto get_function = base::MakeRefCounted<BookmarksGetFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->mobile_node()->id()), profile());
EXPECT_EQ(error, extensions::bookmarks_errors::kNoNodeError);
}
#endif // !BUILDFLAG(IS_ANDROID)
TEST_F(BookmarksApiUnittest, Get_FailsForNonExistentId) {
auto get_function = base::MakeRefCounted<BookmarksGetFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
get_function.get(), R"(["1233456"])", profile());
EXPECT_EQ(error, extensions::bookmarks_errors::kNoNodeError);
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
TEST_F(BookmarksApiUnittest,
GetChildren_ReturnsEmptyForNonVisibleFolderNoVisibilityEnforcement) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndDisableFeature(
kEnforceBookmarkVisibilityOnExtensionsAPI);
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto get_function = base::MakeRefCounted<BookmarksGetChildrenFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->mobile_node()->id()),
profile())
.value();
EXPECT_THAT(result.GetList(), ::testing::IsEmpty());
}
TEST_F(BookmarksApiUnittest, GetChildren_ReturnsErrorForNonVisibleFolder) {
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto get_function = base::MakeRefCounted<BookmarksGetChildrenFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->mobile_node()->id()), profile());
EXPECT_EQ(error, extensions::bookmarks_errors::kNoNodeError);
}
#endif // !BUILDFLAG(IS_ANDROID)
TEST_F(BookmarksApiUnittest, GetChildren_FailsForNonExistentId) {
auto get_function = base::MakeRefCounted<BookmarksGetChildrenFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
get_function.get(), R"(["1233456"])", profile());
EXPECT_EQ(error, extensions::bookmarks_errors::kNoNodeError);
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
TEST_F(BookmarksApiUnittest,
GetSubTree_ReturnsEmptyForNonVisibleFolderNoVisibilityEnforcement) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndDisableFeature(
kEnforceBookmarkVisibilityOnExtensionsAPI);
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto get_function = base::MakeRefCounted<BookmarksGetSubTreeFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->mobile_node()->id()),
profile())
.value();
EXPECT_THAT(result.GetList(), ::testing::IsEmpty());
}
TEST_F(BookmarksApiUnittest, GetSubTree_ReturnsErrorForNonVisibleFolder) {
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto get_function = base::MakeRefCounted<BookmarksGetSubTreeFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
get_function.get(),
absl::StrFormat(R"(["%lu"])", model()->mobile_node()->id()), profile());
EXPECT_EQ(error, extensions::bookmarks_errors::kNoNodeError);
}
#endif // !BUILDFLAG(IS_ANDROID)
TEST_F(BookmarksApiUnittest, GetSubTree_FailsForNonExistentId) {
auto get_function = base::MakeRefCounted<BookmarksGetSubTreeFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
get_function.get(), R"(["1233456"])", profile());
EXPECT_EQ(error, extensions::bookmarks_errors::kNoNodeError);
}
TEST_F(BookmarksApiUnittest, Search_MatchesTitle) {
auto function = base::MakeRefCounted<BookmarksSearchFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
function.get(), R"([{"title": "Empty folder"}])", profile())
.value();
std::vector<const bookmarks::BookmarkNode*> expected_nodes = {folder_node()};
EXPECT_THAT(result.GetList(), ResultMatchesNodes(expected_nodes));
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
TEST_F(BookmarksApiUnittest, Search_NonVisibleFolderNotReturned) {
// Set the title of the folder node to a fixed value.
model()->SetTitle(model()->mobile_node(), u"Mobile Bookmarks",
bookmarks::metrics::BookmarkEditSource::kOther);
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto function = base::MakeRefCounted<BookmarksSearchFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
function.get(), R"([{"title": "Mobile Bookmarks"}])", profile())
.value();
EXPECT_THAT(result.GetList(), ::testing::IsEmpty());
}
TEST_F(BookmarksApiUnittest,
GetTree_SucceedsForLocalPermanentFolderWhenNoAccountFolders) {
auto get_tree_function = base::MakeRefCounted<BookmarksGetTreeFunction>();
const base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_tree_function.get(), R"([])", profile())
.value();
// The result should contain a single root node. Check that its children
// include the three permanent folders, plus the non-permanent folder/url.
ASSERT_EQ(result.GetList().size(), 1u);
auto root_node = extensions::api::bookmarks::BookmarkTreeNode::FromValue(
result.GetList()[0]);
EXPECT_EQ(root_node->id, "0");
ASSERT_EQ(root_node->children.value().size(), 2u);
EXPECT_EQ(root_node->children.value()[0].id,
base::NumberToString(model()->bookmark_bar_node()->id()));
EXPECT_EQ(root_node->children.value()[1].id,
base::NumberToString(model()->other_node()->id()));
auto& other_node = root_node->children.value()[1];
ASSERT_EQ(other_node.children.value().size(), 2u);
EXPECT_EQ(other_node.children.value()[0].id,
base::NumberToString(url_node()->id()));
EXPECT_EQ(other_node.children.value()[1].id,
base::NumberToString(folder_node()->id()));
}
TEST_F(BookmarksApiUnittest, GetTree_SucceedsWhenLocalAndAccountFolders) {
base::test::ScopedFeatureList scoped_feature_list{
switches::kSyncEnableBookmarksInTransportMode};
model()->CreateAccountPermanentFolders();
auto get_tree_function = base::MakeRefCounted<BookmarksGetTreeFunction>();
const base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
get_tree_function.get(), R"([])", profile())
.value();
// The result should contain a single root node. Check that its children
// include the three permanent folders, plus the non-permanent folder/url.
ASSERT_EQ(result.GetList().size(), 1u);
auto root_node = extensions::api::bookmarks::BookmarkTreeNode::FromValue(
result.GetList()[0]);
EXPECT_EQ(root_node->id, "0");
ASSERT_EQ(root_node->children.value().size(), 4u);
// TODO(crbug.com/382263783): the account folders should be returned before
// the local folders.
EXPECT_EQ(root_node->children.value()[0].id,
base::NumberToString(model()->bookmark_bar_node()->id()));
EXPECT_EQ(root_node->children.value()[0].index, 0);
EXPECT_EQ(root_node->children.value()[1].id,
base::NumberToString(model()->other_node()->id()));
auto& other_node = root_node->children.value()[1];
EXPECT_EQ(other_node.index, 1);
ASSERT_EQ(other_node.children.value().size(), 2u);
EXPECT_EQ(other_node.children.value()[0].id,
base::NumberToString(url_node()->id()));
EXPECT_EQ(other_node.children.value()[1].id,
base::NumberToString(folder_node()->id()));
EXPECT_EQ(root_node->children.value()[2].id,
base::NumberToString(model()->account_bookmark_bar_node()->id()));
EXPECT_EQ(root_node->children.value()[2].index, 2);
EXPECT_EQ(root_node->children.value()[3].id,
base::NumberToString(model()->account_other_node()->id()));
EXPECT_EQ(root_node->children.value()[3].index, 3);
}
// Tests that moving from local to account storage is allowed.
TEST_F(BookmarksApiUnittest, Move_LocalToAccount) {
base::test::ScopedFeatureList scoped_feature_list{
switches::kSyncEnableBookmarksInTransportMode};
model()->CreateAccountPermanentFolders();
ASSERT_TRUE(model()->IsLocalOnlyNode(*folder_node()));
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
move_function.get(),
absl::StrFormat(R"(["%lu", {"parentId": "%lu"}])",
folder_node()->id(),
model()->account_other_node()->id()),
profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
EXPECT_EQ(result_node.parent_id,
base::NumberToString(model()->account_other_node()->id()));
EXPECT_EQ(result_node.index, 0);
EXPECT_EQ(model()->account_other_node()->children()[0].get(), folder_node());
}
#endif // !BUILDFLAG(IS_ANDROID)
// Tests that attempting to move a bookmark to a non-folder parent does
// not add the bookmark to that parent.
// Regression test for https://crbug.com/1491227.
TEST_F(BookmarksApiUnittest, Move_NonFolderParent) {
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
move_function.get(),
absl::StrFormat(R"(["%d", {"parentId": "%d"}])", folder_node()->id(),
url_node()->id()),
profile());
ASSERT_EQ("Parameter 'parentId' does not specify a folder.", error);
const bookmarks::BookmarkNode* url_node =
model()->GetMostRecentlyAddedUserNodeForURL(url());
ASSERT_TRUE(url_node->children().empty());
}
// Tests that attempting to move a bookmark to a non existent parent returns an
// error.
TEST_F(BookmarksApiUnittest, Move_NonExistentParent) {
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
move_function.get(),
absl::StrFormat(R"(["%s", {"parentId": "1234"}])",
folder_node_id().c_str()),
profile());
EXPECT_EQ(error, bookmarks_errors::kNoParentError);
const bookmarks::BookmarkNode* url_node =
model()->GetMostRecentlyAddedUserNodeForURL(url());
ASSERT_TRUE(url_node->children().empty());
}
#if !BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/414844449): Port to desktop Android once default visible
// bookmarks behavior is clarified.
TEST_F(BookmarksApiUnittest, Move_NonVisibleParentNoVisibilityEnforcement) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndDisableFeature(
kEnforceBookmarkVisibilityOnExtensionsAPI);
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
base::Value result =
extensions::api_test_utils::RunFunctionAndReturnSingleResult(
move_function.get(),
absl::StrFormat(R"(["%lu", {"parentId": "%lu"}])",
folder_node()->id(), model()->mobile_node()->id()),
profile())
.value();
api::bookmarks::BookmarkTreeNode result_node =
extensions::api::bookmarks::BookmarkTreeNode::FromValue(result).value();
EXPECT_EQ(result_node.parent_id,
base::NumberToString(model()->mobile_node()->id()));
EXPECT_EQ(result_node.index, 0);
EXPECT_EQ(model()->mobile_node()->children()[0].get(), folder_node());
ASSERT_TRUE(model()->mobile_node()->IsVisible());
}
TEST_F(BookmarksApiUnittest, Move_NonVisibleParent) {
// The mobile node is not visible, because it is empty.
ASSERT_FALSE(model()->mobile_node()->IsVisible());
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
move_function.get(),
absl::StrFormat(R"(["%lu", {"parentId": "%lu"}])", folder_node()->id(),
model()->mobile_node()->id()),
profile());
EXPECT_EQ(error, bookmarks_errors::kNoParentError);
}
#endif // !BUILDFLAG(IS_ANDROID)
// Tests that attempting to move a folder to itself returns an error.
TEST_F(BookmarksApiUnittest, Move_FolderToItself) {
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
move_function.get(),
absl::StrFormat(R"(["%s", {"parentId": "%s"}])", folder_node_id().c_str(),
folder_node_id().c_str()),
profile());
ASSERT_EQ("Can't move a folder to itself or its descendant.", error);
}
// Tests that attempting to move a folder to its descendant returns an error.
TEST_F(BookmarksApiUnittest, Move_FolderToDescendant) {
auto move_function = base::MakeRefCounted<BookmarksMoveFunction>();
std::string error = api_test_utils::RunFunctionAndReturnError(
move_function.get(),
absl::StrFormat(R"(["%d", {"parentId": "%d"}])", folder_node()->id(),
subfolder_node()->id()),
profile());
ASSERT_EQ("Can't move a folder to itself or its descendant.", error);
}
} // namespace extensions
|