1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/api/declarative/rules_registry.h"
// Here we test the TestRulesRegistry which is the simplest possible
// implementation of RulesRegistryWithCache as a proxy for
// RulesRegistryWithCache.
#include <memory>
#include "base/command_line.h"
#include "chrome/browser/extensions/test_extension_environment.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/common/extensions/extension_test_util.h"
#include "chrome/test/base/testing_profile.h"
#include "components/value_store/testing_value_store.h"
#include "components/version_info/version_info.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/api/declarative/rules_cache_delegate.h"
#include "extensions/browser/api/declarative/rules_registry_service.h"
#include "extensions/browser/api/declarative/test_rules_registry.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/rules_registry_ids.h"
#include "extensions/buildflags/buildflags.h"
#include "extensions/common/extension.h"
#include "extensions/common/features/feature_channel.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/permissions/permissions_data.h"
#include "testing/gtest/include/gtest/gtest.h"
#if !BUILDFLAG(IS_ANDROID)
#include "chrome/browser/extensions/scoped_test_mv2_enabler.h"
#endif
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
using extension_test_util::LoadManifestUnchecked;
namespace {
const char kRuleId[] = "rule";
const char kRule2Id[] = "rule2";
}
namespace extensions {
const int kRulesRegistryID = rules_registry_ids::kDefaultRulesRegistryID;
class RulesRegistryWithCacheTest : public testing::Test {
public:
RulesRegistryWithCacheTest()
: cache_delegate_(RulesCacheDelegate::Type::kPersistent),
registry_(new TestRulesRegistry(profile(),
/*event_name=*/"",
&cache_delegate_,
kRulesRegistryID)) {}
void SetUp() override {
// Note that env_.MakeExtension below also forces the creation of
// ExtensionService.
base::Value::Dict manifest_extra;
std::string key;
CHECK(Extension::ProducePEM("test extension 1", &key));
manifest_extra.Set(manifest_keys::kPublicKey, key);
extension1_ = env_.MakeExtension(manifest_extra);
CHECK(extension1_.get());
// Different "key" values for the two extensions ensure a different ID.
CHECK(Extension::ProducePEM("test extension 2", &key));
manifest_extra.Set(manifest_keys::kPublicKey, key);
extension2_ = env_.MakeExtension(manifest_extra);
CHECK(extension2_.get());
CHECK_NE(extension2_->id(), extension1_->id());
}
~RulesRegistryWithCacheTest() override = default;
std::string AddRule(const std::string& extension_id,
const std::string& rule_id,
TestRulesRegistry* registry) {
std::vector<api::events::Rule> add_rules;
add_rules.emplace_back();
add_rules[0].id = rule_id;
return registry->AddRules(extension_id, std::move(add_rules));
}
std::string AddRule(const std::string& extension_id,
const std::string& rule_id) {
return AddRule(extension_id, rule_id, registry_.get());
}
std::string RemoveRule(const std::string& extension_id,
const std::string& rule_id) {
std::vector<std::string> remove_rules;
remove_rules.push_back(rule_id);
return registry_->RemoveRules(extension_id, remove_rules);
}
int GetNumberOfRules(const std::string& extension_id,
TestRulesRegistry* registry) {
std::vector<const api::events::Rule*> get_rules;
registry->GetAllRules(extension_id, &get_rules);
return get_rules.size();
}
int GetNumberOfRules(const std::string& extension_id) {
return GetNumberOfRules(extension_id, registry_.get());
}
TestingProfile* profile() const { return env_.profile(); }
protected:
TestExtensionEnvironment env_;
RulesCacheDelegate cache_delegate_;
scoped_refptr<TestRulesRegistry> registry_;
scoped_refptr<const Extension> extension1_;
scoped_refptr<const Extension> extension2_;
};
TEST_F(RulesRegistryWithCacheTest, AddRules) {
// Check that nothing happens if the concrete RulesRegistry refuses to insert
// the rules.
registry_->SetResult("Error");
EXPECT_EQ("Error", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ(0, GetNumberOfRules(extension1_->id()));
registry_->SetResult(std::string());
// Check that rules can be inserted.
EXPECT_EQ("", AddRule(extension1_->id(), kRule2Id));
EXPECT_EQ(1, GetNumberOfRules(extension1_->id()));
// Check that rules cannot be inserted twice with the same kRuleId.
EXPECT_NE("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ(1, GetNumberOfRules(extension1_->id()));
// Check that different extensions may use the same kRuleId.
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
EXPECT_EQ(1, GetNumberOfRules(extension1_->id()));
EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));
}
TEST_F(RulesRegistryWithCacheTest, RemoveRules) {
// Prime registry.
EXPECT_EQ("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
EXPECT_EQ(1, GetNumberOfRules(extension1_->id()));
EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));
// Check that nothing happens if the concrete RuleRegistry refuses to remove
// the rules.
registry_->SetResult("Error");
EXPECT_EQ("Error", RemoveRule(extension1_->id(), kRuleId));
EXPECT_EQ(1, GetNumberOfRules(extension1_->id()));
registry_->SetResult(std::string());
// Check that nothing happens if a rule does not exist.
EXPECT_EQ("", RemoveRule(extension1_->id(), "unknown_rule"));
EXPECT_EQ(1, GetNumberOfRules(extension1_->id()));
// Check that rules may be removed and only for the correct extension.
EXPECT_EQ("", RemoveRule(extension1_->id(), kRuleId));
EXPECT_EQ(0, GetNumberOfRules(extension1_->id()));
EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));
}
TEST_F(RulesRegistryWithCacheTest, RemoveAllRules) {
// Prime registry.
EXPECT_EQ("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ("", AddRule(extension1_->id(), kRule2Id));
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
EXPECT_EQ(2, GetNumberOfRules(extension1_->id()));
EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));
// Check that nothing happens if the concrete RuleRegistry refuses to remove
// the rules.
registry_->SetResult("Error");
EXPECT_EQ("Error", registry_->RemoveAllRules(extension1_->id()));
EXPECT_EQ(2, GetNumberOfRules(extension1_->id()));
registry_->SetResult(std::string());
// Check that rules may be removed and only for the correct extension.
EXPECT_EQ("", registry_->RemoveAllRules(extension1_->id()));
EXPECT_EQ(0, GetNumberOfRules(extension1_->id()));
EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));
}
TEST_F(RulesRegistryWithCacheTest, GetRules) {
// Prime registry.
EXPECT_EQ("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ("", AddRule(extension1_->id(), kRule2Id));
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
// Check that we get the correct rule and unknown rules are ignored.
std::vector<std::string> rules_to_get;
rules_to_get.push_back(kRuleId);
rules_to_get.push_back("unknown_rule");
std::vector<const api::events::Rule*> gotten_rules;
registry_->GetRules(extension1_->id(), rules_to_get, &gotten_rules);
ASSERT_EQ(1u, gotten_rules.size());
ASSERT_TRUE(gotten_rules[0]->id);
EXPECT_EQ(kRuleId, *(gotten_rules[0]->id));
}
TEST_F(RulesRegistryWithCacheTest, GetAllRules) {
// Prime registry.
EXPECT_EQ("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ("", AddRule(extension1_->id(), kRule2Id));
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
// Check that we get the correct rules.
std::vector<const api::events::Rule*> gotten_rules;
registry_->GetAllRules(extension1_->id(), &gotten_rules);
EXPECT_EQ(2u, gotten_rules.size());
ASSERT_TRUE(gotten_rules[0]->id);
ASSERT_TRUE(gotten_rules[1]->id);
EXPECT_TRUE((kRuleId == *(gotten_rules[0]->id) &&
kRule2Id == *(gotten_rules[1]->id)) ||
(kRuleId == *(gotten_rules[1]->id) &&
kRule2Id == *(gotten_rules[0]->id)) );
}
TEST_F(RulesRegistryWithCacheTest, OnExtensionUninstalled) {
// Prime registry.
EXPECT_EQ("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));
// Check that the correct rules are removed.
registry_->OnExtensionUninstalled(extension1_.get());
EXPECT_EQ(0, GetNumberOfRules(extension1_->id()));
EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));
}
TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {
ExtensionPrefs* extension_prefs = env_.GetExtensionPrefs();
const std::string event_name("testEvent");
const std::string rules_stored_key(
RulesCacheDelegate::GetRulesStoredKey(
event_name, profile()->IsOffTheRecord()));
auto cache_delegate = std::make_unique<RulesCacheDelegate>(
RulesCacheDelegate::Type::kPersistent);
scoped_refptr<RulesRegistry> registry(new TestRulesRegistry(
profile(), event_name, cache_delegate.get(), kRulesRegistryID));
// 1. Test the handling of preferences.
// Default value is always true.
EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));
extension_prefs->UpdateExtensionPref(extension1_->id(), rules_stored_key,
base::Value(false));
EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));
extension_prefs->UpdateExtensionPref(extension1_->id(), rules_stored_key,
base::Value(true));
EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));
// 2. Test writing behavior.
{
base::Value::List value;
value.Append(base::Value(true));
cache_delegate->UpdateRules(extension1_->id(), std::move(value));
}
EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));
content::RunAllTasksUntilIdle();
value_store::TestingValueStore* store =
env_.GetExtensionSystem()->value_store();
ASSERT_TRUE(store);
EXPECT_EQ(1, store->write_count());
int write_count = store->write_count();
{
base::Value::List value;
cache_delegate->UpdateRules(extension1_->id(), std::move(value));
EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));
}
content::RunAllTasksUntilIdle();
// No rules currently, but previously there were, so we expect a write.
EXPECT_EQ(write_count + 1, store->write_count());
write_count = store->write_count();
{
base::Value::List value;
cache_delegate->UpdateRules(extension1_->id(), std::move(value));
EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));
}
content::RunAllTasksUntilIdle();
EXPECT_EQ(write_count, store->write_count());
// 3. Test reading behavior.
int read_count = store->read_count();
cache_delegate->SetDeclarativeRulesStored(extension1_->id(), false);
cache_delegate->ReadFromStorage(extension1_->id());
content::RunAllTasksUntilIdle();
EXPECT_EQ(read_count, store->read_count());
read_count = store->read_count();
cache_delegate->SetDeclarativeRulesStored(extension1_->id(), true);
cache_delegate->ReadFromStorage(extension1_->id());
content::RunAllTasksUntilIdle();
EXPECT_EQ(read_count + 1, store->read_count());
}
TEST_F(RulesRegistryWithCacheTest, EphemeralCacheIsEphemeral) {
auto cache_delegate = std::make_unique<RulesCacheDelegate>(
RulesCacheDelegate::Type::kEphemeral);
base::Value::List value;
value.Append(base::Value(true));
cache_delegate->UpdateRules(extension1_->id(), std::move(value));
content::RunAllTasksUntilIdle();
value_store::TestingValueStore* store =
env_.GetExtensionSystem()->value_store();
ASSERT_TRUE(store);
EXPECT_EQ(0, store->write_count());
}
// Test that each registry has its own "are some rules stored" flag.
TEST_F(RulesRegistryWithCacheTest, RulesStoredFlagMultipleRegistries) {
ExtensionPrefs* extension_prefs = env_.GetExtensionPrefs();
const std::string event_name1("testEvent1");
const std::string event_name2("testEvent2");
const std::string rules_stored_key1(
RulesCacheDelegate::GetRulesStoredKey(
event_name1, profile()->IsOffTheRecord()));
const std::string rules_stored_key2(
RulesCacheDelegate::GetRulesStoredKey(
event_name2, profile()->IsOffTheRecord()));
auto cache_delegate1 = std::make_unique<RulesCacheDelegate>(
RulesCacheDelegate::Type::kPersistent);
scoped_refptr<RulesRegistry> registry1(new TestRulesRegistry(
profile(), event_name1, cache_delegate1.get(), kRulesRegistryID));
auto cache_delegate2 = std::make_unique<RulesCacheDelegate>(
RulesCacheDelegate::Type::kPersistent);
scoped_refptr<RulesRegistry> registry2(new TestRulesRegistry(
profile(), event_name2, cache_delegate2.get(), kRulesRegistryID));
// Checkt the correct default values.
EXPECT_TRUE(cache_delegate1->GetDeclarativeRulesStored(extension1_->id()));
EXPECT_TRUE(cache_delegate2->GetDeclarativeRulesStored(extension1_->id()));
// Update the flag for the first registry.
extension_prefs->UpdateExtensionPref(extension1_->id(), rules_stored_key1,
base::Value(false));
EXPECT_FALSE(cache_delegate1->GetDeclarativeRulesStored(extension1_->id()));
EXPECT_TRUE(cache_delegate2->GetDeclarativeRulesStored(extension1_->id()));
}
#if !BUILDFLAG(IS_ANDROID)
// This test relies on declarativeWebRequest, which is deprecated and will not
// be supported on desktop Android.
TEST_F(RulesRegistryWithCacheTest, RulesPreservedAcrossRestart) {
// This test makes sure that rules are restored from the rule store
// on registry (in particular, browser) restart.
// The Declarative Web Request API used below to interact with the rule
// registry is not in stable, therefore set the channel to something where
// that API is available.
ScopedCurrentChannel channel(version_info::Channel::UNKNOWN);
// The Declarative Web Request API is also restricted to MV2, so allow MV2
// extensions.
ScopedTestMV2Enabler mv2_enabler;
// 1. Add an extension, before rules registry gets created.
std::string error;
scoped_refptr<Extension> extension(LoadManifestUnchecked(
"permissions", "web_request_all_host_permissions.json",
mojom::ManifestLocation::kUnpacked, Extension::NO_FLAGS,
extension1_->id(), &error));
ASSERT_TRUE(error.empty());
env_.GetExtensionRegistrar()->AddExtension(extension.get());
EXPECT_TRUE(ExtensionRegistry::Get(env_.profile())
->enabled_extensions()
.Contains(extension->id()));
EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(
mojom::APIPermissionID::kDeclarativeWebRequest));
env_.GetExtensionSystem()->SetReady();
// 2. First run, adding a rule for the extension.
auto cache_delegate = std::make_unique<RulesCacheDelegate>(
RulesCacheDelegate::Type::kPersistent);
scoped_refptr<TestRulesRegistry> registry(new TestRulesRegistry(
profile(), "testEvent", cache_delegate.get(), kRulesRegistryID));
AddRule(extension1_->id(), kRuleId, registry.get());
// Posted tasks store the added rule.
content::RunAllTasksUntilIdle();
EXPECT_EQ(1, GetNumberOfRules(extension1_->id(), registry.get()));
// 3. Restart the TestRulesRegistry and see the rule still there.
cache_delegate = std::make_unique<RulesCacheDelegate>(
RulesCacheDelegate::Type::kPersistent);
registry = new TestRulesRegistry(profile(), "testEvent", cache_delegate.get(),
kRulesRegistryID);
// Posted tasks retrieve the stored rule.
content::RunAllTasksUntilIdle();
EXPECT_EQ(1, GetNumberOfRules(extension1_->id(), registry.get()));
}
#endif // !BUILDFLAG(IS_ANDROID)
TEST_F(RulesRegistryWithCacheTest, ConcurrentStoringOfRules) {
// When an extension updates its rules, the new set of rules is stored to disk
// with some delay. While it is acceptable for a quick series of updates for a
// single extension to only write the last one, we should never forget to
// write a rules update for extension A, just because it is immediately
// followed by a rules update for extension B.
extensions::TestExtensionSystem* system = env_.GetExtensionSystem();
int write_count = 0;
EXPECT_EQ("", AddRule(extension1_->id(), kRuleId));
EXPECT_EQ("", AddRule(extension2_->id(), kRule2Id));
env_.GetExtensionSystem()->SetReady();
content::RunAllTasksUntilIdle();
EXPECT_EQ(write_count + 2, system->value_store()->write_count());
}
} // namespace extensions
|