1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/api/declarative_net_request/ruleset_manager.h"
#include <optional>
#include <string_view>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/extensions/api/declarative_net_request/dnr_test_base.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/extension_util.h"
#include "components/version_info/channel.h"
#include "extensions/browser/api/declarative_net_request/composite_matcher.h"
#include "extensions/browser/api/declarative_net_request/file_backed_ruleset_source.h"
#include "extensions/browser/api/declarative_net_request/prefs_helper.h"
#include "extensions/browser/api/declarative_net_request/request_action.h"
#include "extensions/browser/api/declarative_net_request/ruleset_matcher.h"
#include "extensions/browser/api/declarative_net_request/test_utils.h"
#include "extensions/browser/api/web_request/web_request_info.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/extension_util.h"
#include "extensions/common/api/declarative_net_request.h"
#include "extensions/common/api/declarative_net_request/constants.h"
#include "extensions/common/api/declarative_net_request/test_utils.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/features/feature_channel.h"
#include "extensions/common/file_util.h"
#include "extensions/common/manifest_handlers/background_info.h"
#include "extensions/common/url_pattern.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
#include "url/origin.h"
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions::declarative_net_request {
namespace dnr_api = api::declarative_net_request;
namespace {
class RulesetManagerTest : public DNRTestBase {
public:
RulesetManagerTest() = default;
RulesetManagerTest(const RulesetManagerTest&) = delete;
RulesetManagerTest& operator=(const RulesetManagerTest&) = delete;
void SetUp() override {
DNRTestBase::SetUp();
manager_ = std::make_unique<RulesetManager>(browser_context());
}
protected:
using RequestActionType = RequestAction::Type;
// Helper to create a composite matcher instance for the given |rules|.
void CreateMatcherForRules(
const std::vector<TestRule>& rules,
const std::string& extension_dirname,
std::unique_ptr<CompositeMatcher>* matcher,
const std::vector<std::string>& host_permissions = {},
bool has_background_script = false) {
base::FilePath extension_dir =
temp_dir().GetPath().AppendASCII(extension_dirname);
// Create extension directory.
ASSERT_TRUE(base::CreateDirectory(extension_dir));
ConfigFlag flags = has_background_script
? ConfigFlag::kConfig_HasBackgroundScript
: ConfigFlag::kConfig_None;
constexpr char kRulesetID[] = "id";
constexpr char kJSONRulesFilename[] = "rules_file.json";
TestRulesetInfo info(kRulesetID, kJSONRulesFilename, ToListValue(rules));
WriteManifestAndRuleset(extension_dir, info, host_permissions, flags);
last_loaded_extension_ =
CreateExtensionLoader()->LoadExtension(extension_dir);
ASSERT_TRUE(last_loaded_extension_);
ExtensionRegistry::Get(browser_context())
->AddEnabled(last_loaded_extension_);
std::vector<FileBackedRulesetSource> sources =
FileBackedRulesetSource::CreateStatic(
*last_loaded_extension_,
FileBackedRulesetSource::RulesetFilter::kIncludeAll);
ASSERT_EQ(1u, sources.size());
int expected_checksum;
PrefsHelper helper(*ExtensionPrefs::Get(browser_context()));
EXPECT_TRUE(helper.GetStaticRulesetChecksum(
last_loaded_extension_->id(), sources[0].id(), expected_checksum));
std::vector<std::unique_ptr<RulesetMatcher>> matchers(1);
EXPECT_EQ(
LoadRulesetResult::kSuccess,
sources[0].CreateVerifiedMatcher(expected_checksum, &matchers[0]));
*matcher = std::make_unique<CompositeMatcher>(
std::move(matchers), last_loaded_extension_->id(),
HostPermissionsAlwaysRequired::kFalse);
}
void SetIncognitoEnabled(const Extension* extension, bool incognito_enabled) {
util::SetIsIncognitoEnabled(extension->id(), browser_context(),
incognito_enabled);
ExtensionRegistry::Get(browser_context())->AddEnabled(extension);
}
const Extension* last_loaded_extension() const {
return last_loaded_extension_.get();
}
// Returns renderer-initiated request params for the given |url|.
WebRequestInfoInitParams GetRequestParamsForURL(
std::string_view url,
std::optional<url::Origin> initiator = std::nullopt,
WebRequestResourceType web_request_type = WebRequestResourceType::OTHER) {
const int kRendererId = 1;
WebRequestInfoInitParams info;
info.url = GURL(url);
info.method = net::HttpRequestHeaders::kGetMethod;
info.render_process_id = kRendererId;
info.initiator = std::move(initiator);
info.web_request_type = web_request_type;
return info;
}
// Returns renderer-initiated request params for the given |url| and
// |request_headers| request headers.
WebRequestInfoInitParams GetRequestParamsForURLWithHeaders(
std::string_view url,
const std::vector<std::string>& request_headers) {
const int kRendererId = 1;
WebRequestInfoInitParams info;
info.url = GURL(url);
info.method = net::HttpRequestHeaders::kGetMethod;
info.render_process_id = kRendererId;
net::HttpRequestHeaders extra_request_headers;
for (const auto& header : request_headers)
extra_request_headers.SetHeaderIfMissing(header, "foo");
info.extra_request_headers = extra_request_headers;
return info;
}
RulesetManager* manager() { return manager_.get(); }
private:
scoped_refptr<const Extension> last_loaded_extension_;
std::unique_ptr<RulesetManager> manager_;
};
// Tests that the RulesetManager handles multiple rulesets correctly.
TEST_P(RulesetManagerTest, MultipleRulesets) {
enum RulesetMask {
kEnableRulesetOne = 1 << 0,
kEnableRulesetTwo = 1 << 1,
};
TestRule rule_one = CreateGenericRule();
rule_one.condition->url_filter = std::string("one.com");
TestRule rule_two = CreateGenericRule();
rule_two.condition->url_filter = std::string("two.com");
auto should_block_request = [this](const WebRequestInfo& request, int rule_id,
const ExtensionId& extension_id) {
manager()->EvaluateBeforeRequest(request, false /*is_incognito_context*/);
return !request.dnr_actions->empty() &&
((*request.dnr_actions)[0] ==
CreateRequestActionForTesting(
RequestActionType::BLOCK, rule_id, kDefaultPriority,
kMinValidStaticRulesetID, extension_id));
};
for (int mask = 0; mask < 4; mask++) {
SCOPED_TRACE(base::StringPrintf("Testing ruleset mask %d", mask));
ASSERT_EQ(0u, manager()->GetMatcherCountForTest());
ExtensionId extension_id_one;
ExtensionId extension_id_two;
size_t expected_matcher_count = 0;
// Add the required rulesets.
if (mask & kEnableRulesetOne) {
++expected_matcher_count;
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule_one}, base::NumberToString(mask) + "_one", &matcher));
extension_id_one = last_loaded_extension()->id();
manager()->AddRuleset(extension_id_one, std::move(matcher));
}
if (mask & kEnableRulesetTwo) {
++expected_matcher_count;
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule_two}, base::NumberToString(mask) + "_two", &matcher));
extension_id_two = last_loaded_extension()->id();
manager()->AddRuleset(extension_id_two, std::move(matcher));
}
ASSERT_EQ(expected_matcher_count, manager()->GetMatcherCountForTest());
WebRequestInfo request_one_info(GetRequestParamsForURL("http://one.com"));
WebRequestInfo request_two_info(GetRequestParamsForURL("http://two.com"));
WebRequestInfo request_three_info(
GetRequestParamsForURL("http://three.com"));
EXPECT_EQ(
(mask & kEnableRulesetOne) != 0,
should_block_request(request_one_info, *rule_one.id, extension_id_one));
EXPECT_EQ(
(mask & kEnableRulesetTwo) != 0,
should_block_request(request_two_info, *rule_two.id, extension_id_two));
EXPECT_FALSE(should_block_request(request_three_info, 0 /* rule_id */,
"" /* extension_id */));
// Remove the rulesets.
if (mask & kEnableRulesetOne)
manager()->RemoveRuleset(extension_id_one);
if (mask & kEnableRulesetTwo)
manager()->RemoveRuleset(extension_id_two);
}
}
// Tests that only extensions enabled in incognito mode can modify requests made
// from the incognito context.
TEST_P(RulesetManagerTest, IncognitoRequests) {
// Add an extension ruleset blocking "example.com".
TestRule rule_one = CreateGenericRule();
rule_one.condition->url_filter = std::string("example.com");
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(
CreateMatcherForRules({rule_one}, "test_extension", &matcher));
manager()->AddRuleset(last_loaded_extension()->id(), std::move(matcher));
WebRequestInfo request_info(GetRequestParamsForURL("http://example.com"));
// By default, the extension is disabled in incognito mode. So requests from
// incognito contexts should not be evaluated.
EXPECT_FALSE(util::IsIncognitoEnabled(last_loaded_extension()->id(),
browser_context()));
manager()->EvaluateBeforeRequest(request_info, true /*is_incognito_context*/);
EXPECT_TRUE(request_info.dnr_actions->empty());
request_info.dnr_actions.reset();
manager()->EvaluateBeforeRequest(request_info,
false /*is_incognito_context*/);
ASSERT_EQ(1u, request_info.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, *rule_one.id, kDefaultPriority,
kMinValidStaticRulesetID, last_loaded_extension()->id()),
(*request_info.dnr_actions)[0]);
request_info.dnr_actions.reset();
// Enabling the extension in incognito mode, should cause requests from
// incognito contexts to also be evaluated.
SetIncognitoEnabled(last_loaded_extension(), true /*incognito_enabled*/);
EXPECT_TRUE(util::IsIncognitoEnabled(last_loaded_extension()->id(),
browser_context()));
manager()->EvaluateBeforeRequest(request_info, true /*is_incognito_context*/);
ASSERT_EQ(1u, request_info.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, *rule_one.id, kDefaultPriority,
kMinValidStaticRulesetID, last_loaded_extension()->id()),
(*request_info.dnr_actions)[0]);
request_info.dnr_actions.reset();
manager()->EvaluateBeforeRequest(request_info,
false /*is_incognito_context*/);
ASSERT_EQ(1u, request_info.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, *rule_one.id, kDefaultPriority,
kMinValidStaticRulesetID, last_loaded_extension()->id()),
(*request_info.dnr_actions)[0]);
request_info.dnr_actions.reset();
}
// Tests that
// Extensions.DeclarativeNetRequest.EvaluateRequestTime.AllExtensions3
// is only emitted when there are active rulesets.
// TODO(crbug.com/40727004): Add a check for the HeadersReceived versions of the
// below histograms.
TEST_P(RulesetManagerTest, EvaluationHistograms) {
WebRequestInfo example_com_request(
GetRequestParamsForURL("http://example.com"));
WebRequestInfo google_com_request(
GetRequestParamsForURL("http://google.com"));
bool is_incognito_context = false;
static constexpr char kEvaluationTimeHistogramName[] =
"Extensions.DeclarativeNetRequest.EvaluateRequestTime.AllExtensions3";
static constexpr char kBeforeRequestRegexTimeHistogramName[] =
"Extensions.DeclarativeNetRequest.RegexRulesBeforeRequestActionTime."
"LessThan15Rules";
static constexpr char kBeforeRequestRulesetTimeHistogramName[] =
"Extensions.DeclarativeNetRequest."
"RulesetMatchingBeforeRequestActionTime."
"LessThan1000Rules";
{
base::HistogramTester tester;
manager()->EvaluateBeforeRequest(example_com_request, is_incognito_context);
EXPECT_TRUE(example_com_request.dnr_actions->empty());
manager()->EvaluateBeforeRequest(google_com_request, is_incognito_context);
EXPECT_TRUE(google_com_request.dnr_actions->empty());
tester.ExpectTotalCount(kEvaluationTimeHistogramName, 0);
tester.ExpectTotalCount(kBeforeRequestRegexTimeHistogramName, 0);
tester.ExpectTotalCount(kBeforeRequestRulesetTimeHistogramName, 0);
example_com_request.dnr_actions.reset();
google_com_request.dnr_actions.reset();
}
// Add an extension ruleset which blocks requests to "example.com".
TestRule rule = CreateGenericRule();
TestRule regex_rule = CreateRegexRule(2);
rule.condition->url_filter = std::string("example.com");
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(
CreateMatcherForRules({rule, regex_rule}, "test_extension", &matcher));
manager()->AddRuleset(last_loaded_extension()->id(), std::move(matcher));
{
base::HistogramTester tester;
manager()->EvaluateBeforeRequest(example_com_request, is_incognito_context);
ASSERT_EQ(1u, example_com_request.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, *rule.id, kDefaultPriority,
kMinValidStaticRulesetID, last_loaded_extension()->id()),
(*example_com_request.dnr_actions)[0]);
tester.ExpectTotalCount(kEvaluationTimeHistogramName, 1);
tester.ExpectTotalCount(kBeforeRequestRegexTimeHistogramName, 1);
tester.ExpectTotalCount(kBeforeRequestRulesetTimeHistogramName, 1);
manager()->EvaluateBeforeRequest(google_com_request, is_incognito_context);
EXPECT_TRUE(google_com_request.dnr_actions->empty());
tester.ExpectTotalCount(kEvaluationTimeHistogramName, 2);
tester.ExpectTotalCount(kBeforeRequestRegexTimeHistogramName, 2);
tester.ExpectTotalCount(kBeforeRequestRulesetTimeHistogramName, 2);
example_com_request.dnr_actions.reset();
google_com_request.dnr_actions.reset();
}
}
// Test redirect rules.
TEST_P(RulesetManagerTest, Redirect) {
// Add an extension ruleset which redirects "example.com" to "google.com".
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("example.com");
rule.priority = kMinValidPriority;
rule.action->type = std::string("redirect");
rule.action->redirect.emplace();
rule.action->redirect->url = std::string("http://google.com");
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(
CreateMatcherForRules({rule}, "test_extension", &matcher,
{"*://example.com/*", "*://abc.com/*"}));
manager()->AddRuleset(last_loaded_extension()->id(), std::move(matcher));
// Create a request to "example.com" with an empty initiator. It should be
// redirected to "google.com".
const bool is_incognito_context = false;
const char* kExampleURL = "http://example.com";
RequestAction expected_redirect_action = CreateRequestActionForTesting(
RequestActionType::REDIRECT, *rule.id, *rule.priority,
kMinValidStaticRulesetID, last_loaded_extension()->id());
expected_redirect_action.redirect_url = GURL("http://google.com");
WebRequestInfo request_1(GetRequestParamsForURL(kExampleURL, std::nullopt));
manager()->EvaluateBeforeRequest(request_1, is_incognito_context);
ASSERT_EQ(1u, request_1.dnr_actions->size());
EXPECT_EQ(expected_redirect_action, (*request_1.dnr_actions)[0]);
// Change the initiator to "xyz.com". It should not be redirected since we
// don't have host permissions to the request initiator.
WebRequestInfo request_2(GetRequestParamsForURL(
kExampleURL, url::Origin::Create(GURL("http://xyz.com"))));
manager()->EvaluateBeforeRequest(request_2, is_incognito_context);
EXPECT_TRUE(request_2.dnr_actions->empty());
// Change the initiator to "abc.com". It should be redirected since we have
// the required host permissions.
WebRequestInfo request_3(GetRequestParamsForURL(
kExampleURL, url::Origin::Create(GURL("http://abc.com"))));
manager()->EvaluateBeforeRequest(request_3, is_incognito_context);
ASSERT_EQ(1u, request_3.dnr_actions->size());
EXPECT_EQ(expected_redirect_action, (*request_3.dnr_actions)[0]);
// Ensure web-socket requests are not redirected.
WebRequestInfo request_4(
GetRequestParamsForURL("ws://example.com", std::nullopt));
manager()->EvaluateBeforeRequest(request_4, is_incognito_context);
EXPECT_TRUE(request_4.dnr_actions->empty());
}
// Tests that an extension can't block or redirect resources on the chrome-
// extension scheme.
TEST_P(RulesetManagerTest, ExtensionScheme) {
const Extension* extension_1 = nullptr;
const Extension* extension_2 = nullptr;
// Add an extension with a background page which blocks all requests.
{
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("*");
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension", &matcher,
std::vector<std::string>({URLPattern::kAllUrlsPattern}),
true /* has_background_script */));
extension_1 = last_loaded_extension();
manager()->AddRuleset(extension_1->id(), std::move(matcher));
}
// Add another extension with a background page which redirects all requests
// to "http://google.com".
{
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("*");
rule.priority = kMinValidPriority;
rule.action->type = std::string("redirect");
rule.action->redirect.emplace();
rule.action->redirect->url = std::string("http://google.com");
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension_2", &matcher,
std::vector<std::string>({URLPattern::kAllUrlsPattern}),
true /* has_background_script */));
extension_2 = last_loaded_extension();
manager()->AddRuleset(extension_2->id(), std::move(matcher));
}
EXPECT_EQ(2u, manager()->GetMatcherCountForTest());
// Ensure that "http://example.com" will be blocked (with blocking taking
// priority over redirection).
WebRequestInfo request_1(GetRequestParamsForURL("http://example.com"));
manager()->EvaluateBeforeRequest(request_1, false /*is_incognito_context*/);
ASSERT_EQ(1u, request_1.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension_1->id()),
(*request_1.dnr_actions)[0]);
// Ensure that the background page for |extension_1| won't be blocked or
// redirected.
GURL background_page_url_1 = BackgroundInfo::GetBackgroundURL(extension_1);
EXPECT_TRUE(!background_page_url_1.is_empty());
WebRequestInfo request_2(
GetRequestParamsForURL(background_page_url_1.spec()));
manager()->EvaluateBeforeRequest(request_2, false /*is_incognito_context*/);
EXPECT_TRUE(request_2.dnr_actions->empty());
// Ensure that the background page for |extension_2| won't be blocked or
// redirected.
GURL background_page_url_2 = BackgroundInfo::GetBackgroundURL(extension_2);
EXPECT_TRUE(!background_page_url_2.is_empty());
WebRequestInfo request_3(
GetRequestParamsForURL(background_page_url_2.spec()));
manager()->EvaluateBeforeRequest(request_3, false /*is_incognito_context*/);
EXPECT_TRUE(request_3.dnr_actions->empty());
// Also ensure that an arbitrary url on the chrome extension scheme is also
// not blocked or redirected.
WebRequestInfo request_4(GetRequestParamsForURL(base::StringPrintf(
"%s://%s/%s", kExtensionScheme, "extension_id", "path")));
manager()->EvaluateBeforeRequest(request_4, false /*is_incognito_context*/);
EXPECT_TRUE(request_4.dnr_actions->empty());
}
// Test that the correct modifyHeaders actions are returned for each extension.
TEST_P(RulesetManagerTest, ModifyHeaders) {
const Extension* extension_1 = nullptr;
const Extension* extension_2 = nullptr;
// Add an extension which removes "header1" and sets "header2".
{
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("*");
rule.action->type = std::string("modifyHeaders");
rule.action->request_headers = std::vector<TestHeaderInfo>(
{TestHeaderInfo("header1", "remove", std::nullopt),
TestHeaderInfo("header2", "set", "value2")});
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension", &matcher, {URLPattern::kAllUrlsPattern}));
extension_1 = last_loaded_extension();
manager()->AddRuleset(extension_1->id(), std::move(matcher));
}
// Add another extension which removes "header1" and appends "header3".
{
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("*");
rule.action->type = std::string("modifyHeaders");
rule.action->request_headers = std::vector<TestHeaderInfo>(
{TestHeaderInfo("header1", "remove", std::nullopt)});
rule.action->response_headers = std::vector<TestHeaderInfo>(
{TestHeaderInfo("header3", "append", "value3")});
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension 2", &matcher, {URLPattern::kAllUrlsPattern}));
extension_2 = last_loaded_extension();
manager()->AddRuleset(extension_2->id(), std::move(matcher));
}
ASSERT_EQ(2u, manager()->GetMatcherCountForTest());
WebRequestInfo request(GetRequestParamsForURL("http://example.com"));
const std::vector<RequestAction>& actual_actions =
manager()->EvaluateBeforeRequest(request, false /*is_incognito_context*/);
// Create the expected RequestAction for |extension_2|.
RequestAction expected_action_1 = CreateRequestActionForTesting(
RequestActionType::MODIFY_HEADERS, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension_2->id());
expected_action_1.request_headers_to_modify = {RequestAction::HeaderInfo(
"header1", dnr_api::HeaderOperation::kRemove, std::nullopt)};
expected_action_1.response_headers_to_modify = {RequestAction::HeaderInfo(
"header3", dnr_api::HeaderOperation::kAppend, "value3")};
// Create the expected RequestAction for |extension_1|.
RequestAction expected_action_2 = CreateRequestActionForTesting(
RequestActionType::MODIFY_HEADERS, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension_1->id());
expected_action_2.request_headers_to_modify = {
RequestAction::HeaderInfo("header1", dnr_api::HeaderOperation::kRemove,
std::nullopt),
RequestAction::HeaderInfo("header2", dnr_api::HeaderOperation::kSet,
"value2")};
// Verify that the list of actions is sorted in descending order of extension
// priority.
EXPECT_THAT(actual_actions,
::testing::ElementsAre(
::testing::Eq(::testing::ByRef(expected_action_1)),
::testing::Eq(::testing::ByRef(expected_action_2))));
}
// Ensures that an allow rule doesn't win over a higher priority modifyHeaders
// rule. Regression test for crbug.com/1244249.
TEST_P(RulesetManagerTest, ModifyHeadersWithAllowRules) {
int rule_id = kMinValidID;
TestRule rule1 = CreateGenericRule();
rule1.condition->url_filter = std::string("example.com");
rule1.action->type = std::string("modifyHeaders");
rule1.action->request_headers =
std::vector<TestHeaderInfo>({TestHeaderInfo("header", "set", "value")});
rule1.priority = 5;
rule1.id = rule_id++;
TestRule rule2 = CreateGenericRule();
rule2.condition->url_filter = std::string("example.com");
rule2.action->type = std::string("allow");
rule2.priority = 3;
rule2.id = rule_id++;
TestRule rule3 = CreateGenericRule();
rule3.condition->url_filter = std::string("abc.example.com");
rule3.action->type = std::string("allow");
rule3.priority = 8;
rule3.id = rule_id++;
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules({rule1, rule2, rule3},
"test extension", &matcher,
{URLPattern::kAllUrlsPattern}));
const Extension* extension = last_loaded_extension();
manager()->AddRuleset(extension->id(), std::move(matcher));
{
WebRequestInfo request(GetRequestParamsForURL("http://example.com"));
const std::vector<RequestAction>& actions =
manager()->EvaluateBeforeRequest(request,
false /*is_incognito_context*/);
// `rule1` and `rule2` match. `rule1` gets precedence because of priority.
RequestAction expected_action = CreateRequestActionForTesting(
RequestActionType::MODIFY_HEADERS, *rule1.id, *rule1.priority,
kMinValidStaticRulesetID, extension->id());
expected_action.request_headers_to_modify = {RequestAction::HeaderInfo(
"header", dnr_api::HeaderOperation::kSet, "value")};
EXPECT_THAT(actions, ::testing::ElementsAre(
::testing::Eq(::testing::ByRef(expected_action))));
}
{
WebRequestInfo request(GetRequestParamsForURL("http://abc.example.com"));
const std::vector<RequestAction>& actions =
manager()->EvaluateBeforeRequest(request,
false /*is_incognito_context*/);
// `rule1`, `rule2` and `rule3` match. `rule3` gets precedence because of
// priority.
RequestAction expected_action = CreateRequestActionForTesting(
RequestActionType::ALLOW, *rule3.id, *rule3.priority,
kMinValidStaticRulesetID, extension->id());
EXPECT_THAT(actions, ::testing::ElementsAre(
::testing::Eq(::testing::ByRef(expected_action))));
}
}
// Test that an extension's modify header rules are applied on a request only if
// it has host permissions for the request.
TEST_P(RulesetManagerTest, ModifyHeaders_HostPermissions) {
// Add an extension which removes the "header1" header with host permissions
// for example.com.
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("*");
rule.action->type = std::string("modifyHeaders");
rule.action->request_headers = std::vector<TestHeaderInfo>(
{TestHeaderInfo("header1", "remove", std::nullopt)});
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension", &matcher, {"*://example.com/*"}));
const Extension* extension = last_loaded_extension();
manager()->AddRuleset(extension->id(), std::move(matcher));
ASSERT_EQ(1u, manager()->GetMatcherCountForTest());
{
WebRequestInfo request(GetRequestParamsForURL("http://example.com"));
const std::vector<RequestAction>& actual_actions =
manager()->EvaluateBeforeRequest(request,
false /*is_incognito_context*/);
RequestAction expected_action = CreateRequestActionForTesting(
RequestActionType::MODIFY_HEADERS, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension->id());
expected_action.request_headers_to_modify = {RequestAction::HeaderInfo(
"header1", dnr_api::HeaderOperation::kRemove, std::nullopt)};
EXPECT_THAT(actual_actions, ::testing::ElementsAre(::testing::Eq(
::testing::ByRef(expected_action))));
}
{
WebRequestInfo request(GetRequestParamsForURL("http://nopermissions.com"));
const std::vector<RequestAction>& actual_actions =
manager()->EvaluateBeforeRequest(request,
false /*is_incognito_context*/);
EXPECT_TRUE(actual_actions.empty());
}
{
// Has access to url but no access to initiator, so no actions should be
// returned.
WebRequestInfo request(GetRequestParamsForURL(
"http://example.com",
url::Origin::Create(GURL("http://nopermissions.com"))));
const std::vector<RequestAction>& actual_actions =
manager()->EvaluateBeforeRequest(request,
false /*is_incognito_context*/);
EXPECT_TRUE(actual_actions.empty());
}
}
TEST_P(RulesetManagerTest, HostPermissionForInitiator) {
// Add an extension which redirects all sub-resource and sub-frame requests
// made to example.com, to foo.com. By default, the "main_frame" type is
// excluded if no "resource_types" are specified.
std::unique_ptr<CompositeMatcher> redirect_matcher;
{
TestRule rule = CreateGenericRule();
rule.id = kMinValidID;
rule.priority = kMinValidPriority;
rule.condition->url_filter = std::string("example.com");
rule.action->type = std::string("redirect");
rule.action->redirect.emplace();
rule.action->redirect->url = std::string("https://foo.com");
std::vector<std::string> host_permissions = {"*://yahoo.com/*",
"*://example.com/*"};
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "redirecting extension", &redirect_matcher, host_permissions,
false /* has_background_script */));
}
std::string redirect_extension_id = last_loaded_extension()->id();
// Add an extension which blocks all sub-resource and sub-frame requests to
// example.com. By default, the "main_frame" type is excluded if no
// "resource_types" are specified. The extension has no host permissions.
std::unique_ptr<CompositeMatcher> blocking_matcher;
{
TestRule rule = CreateGenericRule();
rule.id = kMinValidID;
rule.condition->url_filter = std::string("example.com");
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "blocking extension", &blocking_matcher,
{} /* host_permissions */, false /* has_background_script */));
}
std::string blocking_extension_id = last_loaded_extension()->id();
struct TestCase {
std::string url;
std::optional<url::Origin> initiator;
bool expected_action_redirect_extension;
bool expected_action_blocking_extension;
} cases[] = {
// Empty initiator. Has access.
{"https://example.com", std::nullopt, true, true},
// Opaque origin as initiator. Has access.
{"https://example.com", url::Origin(), true, true},
// yahoo.com as initiator. Has access.
{"https://example.com", url::Origin::Create(GURL("http://yahoo.com")),
true, true},
// No matching rule.
{"https://yahoo.com", url::Origin::Create(GURL("http://example.com")),
false, false},
// Doesn't have access to initiator. But blocking a request doesn't
// require host permissions.
{"https://example.com", url::Origin::Create(GURL("http://google.com")),
false, true},
};
auto verify_test_case = [this](const std::string& url,
const std::optional<url::Origin>& initiator,
RequestAction* expected_action) {
SCOPED_TRACE(base::StringPrintf(
"Url-%s initiator-%s", url.c_str(),
initiator ? initiator->Serialize().c_str() : "empty"));
WebRequestInfo request(GetRequestParamsForURL(url, initiator));
bool is_incognito_context = false;
manager()->EvaluateBeforeRequest(request, is_incognito_context);
if (expected_action) {
ASSERT_EQ(1u, request.dnr_actions->size());
EXPECT_EQ(*expected_action, (*request.dnr_actions)[0]);
} else {
EXPECT_TRUE(request.dnr_actions->empty());
}
};
// Test redirect extension.
{
SCOPED_TRACE("Testing redirect extension");
manager()->AddRuleset(redirect_extension_id, std::move(redirect_matcher));
for (const auto& test : cases) {
RequestAction redirect_action = CreateRequestActionForTesting(
RequestActionType::REDIRECT, kMinValidID, kMinValidPriority,
kMinValidStaticRulesetID, redirect_extension_id);
redirect_action.redirect_url = GURL("https://foo.com/");
verify_test_case(
test.url, test.initiator,
test.expected_action_redirect_extension ? &redirect_action : nullptr);
}
manager()->RemoveRuleset(redirect_extension_id);
}
// Test blocking extension.
{
SCOPED_TRACE("Testing blocking extension");
manager()->AddRuleset(blocking_extension_id, std::move(blocking_matcher));
for (const auto& test : cases) {
RequestAction block_action = CreateRequestActionForTesting(
RequestActionType::BLOCK, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, blocking_extension_id);
verify_test_case(
test.url, test.initiator,
test.expected_action_blocking_extension ? &block_action : nullptr);
}
manager()->RemoveRuleset(blocking_extension_id);
}
}
class RulesetManagerResponseHeadersTest : public RulesetManagerTest {
public:
RulesetManagerResponseHeadersTest() {
scoped_feature_list_.InitAndEnableFeature(
extensions_features::kDeclarativeNetRequestResponseHeaderMatching);
}
private:
// TODO(crbug.com/40727004): Once feature is launched to stable and feature
// flag can be removed, replace usages of this test class with just
// DeclarativeNetRequestBrowserTest.
base::test::ScopedFeatureList scoped_feature_list_;
ScopedCurrentChannel current_channel_override_{version_info::Channel::DEV};
};
// Test that multiple lists of modify header actions can be merged into a single
// list that is still sorted in descending order of action precedence.
TEST_P(RulesetManagerResponseHeadersTest, MergeModifyHeaderActions) {
// For 2 modify header actions, A and B, A has a higher priority than B if:
// A's extension is more recently installed than B's extension
// or if from the same extension:
// A's priority is greater than B's priority.
// Test setup: install 3 extensions, with extension N being more recently
// installed than extension N-1.
// Add the following (rule id, priority) for each extension:
// Extension 1:
// - OnHeadersReceived: (1, 100)
// Extension 2:
// - OnBeforeRequest: (2, 10), (3, 1)
// - OnHeadersReceived: (4, 2)
// Extension 3:
// - OnBeforeRequest: (5, 3)
// - OnHeadersReceived: (6, 2)
// Loads an extension with the given `rules`.
auto load_extension_with_rules = [this](const std::string& name,
const std::vector<TestRule>& rules) {
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(
CreateMatcherForRules(rules, name, &matcher, {"<all_urls>"},
/*has_background_script=*/false));
manager()->AddRuleset(last_loaded_extension()->id(), std::move(matcher));
};
// Creates a modifyHeaders rule with a given `id` and `priority`. If
// `headers_received_rule` is true, a trivial response header condition is
// added to the rule so it will be matched in onHeadersReceived instead of
// onBeforeRequest. Note: the action that the rule takes on a request is not
// important as it's not tested here.
auto create_rule = [](int id, int priority, bool headers_received_rule) {
TestRule rule = CreateGenericRule(id);
rule.priority = priority;
rule.condition->url_filter = std::string("example.com");
if (headers_received_rule) {
rule.condition->excluded_response_headers =
std::vector<TestHeaderCondition>(
{TestHeaderCondition("excludedKey", {}, {})});
}
rule.action->type = std::string("modifyHeaders");
rule.action->response_headers = std::vector<TestHeaderInfo>(
{TestHeaderInfo("header1", "append", "test")});
return rule;
};
auto get_rule_and_extension_ids =
[](const std::vector<RequestAction>& actions) {
std::vector<std::pair<int, ExtensionId>> rule_and_extension_ids;
for (const auto& action : actions) {
rule_and_extension_ids.emplace_back(action.rule_id,
action.extension_id);
}
return rule_and_extension_ids;
};
// Create the three extensions with their respective rules:
auto e1_hr_rule = create_rule(kMinValidID, 100, true);
load_extension_with_rules("extension 1", {e1_hr_rule});
auto extension_1_id = last_loaded_extension()->id();
auto e2_br_rule1 = create_rule(kMinValidID + 1, 10, false);
auto e2_br_rule2 = create_rule(kMinValidID + 2, 1, false);
auto e2_hr_rule = create_rule(kMinValidID + 3, 2, true);
load_extension_with_rules("extension 2",
{e2_br_rule1, e2_br_rule2, e2_hr_rule});
auto extension_2_id = last_loaded_extension()->id();
auto e3_br_rule = create_rule(kMinValidID + 4, 3, false);
auto e3_hr_rule = create_rule(kMinValidID + 5, 2, true);
load_extension_with_rules("extension 3", {e3_br_rule, e3_hr_rule});
auto extension_3_id = last_loaded_extension()->id();
// Create a request to "example.com" and match with on before request actions.
WebRequestInfo request(
GetRequestParamsForURL("http://example.com", std::nullopt));
manager()->EvaluateBeforeRequest(request, /*is_incognito_context=*/false);
// The action from `extension_3` should come first since it was the most
// recently installed, followed by the 2 `extension_2` actions in descending
// order of priority, so:
//
// Extension 3:
// - e3_br_rule (pri = 3)
// Extension 2:
// - e2_br_rule1 (pri = 10)
// - e2_br_rule2 (pri = 1)
EXPECT_THAT(
get_rule_and_extension_ids(*request.dnr_actions),
testing::ElementsAre(std::make_pair(*e3_br_rule.id, extension_3_id),
std::make_pair(*e2_br_rule1.id, extension_2_id),
std::make_pair(*e2_br_rule2.id, extension_2_id)));
// Now match with actions in the on headers received phase.
auto base_headers = base::MakeRefCounted<net::HttpResponseHeaders>(
net::HttpUtil::AssembleRawHeaders("HTTP/1.0 200 OK\r\n"));
std::vector<RequestAction> headers_received_actions =
manager()->EvaluateRequestWithHeaders(request, base_headers.get(),
/*is_incognito_context=*/false);
// Each extension only has one response header matching rule each, so the
// actions returned should be in descending order of extension install time
// (most recent first), so:
//
// Extension 3:
// - e3_hr_rule (pri = 2)
// Extension 2:
// - e2_hr_rule (pri = 2)
// Extension 1:
// - e1_hr_rule (pri = 100)
EXPECT_THAT(
get_rule_and_extension_ids(headers_received_actions),
testing::ElementsAre(std::make_pair(*e3_hr_rule.id, extension_3_id),
std::make_pair(*e2_hr_rule.id, extension_2_id),
std::make_pair(*e1_hr_rule.id, extension_1_id)));
// Now merge actions matched in both request stages.
std::vector<RequestAction> merged_actions =
manager()->MergeModifyHeaderActions(std::move(*request.dnr_actions),
std::move(headers_received_actions));
// We should see [ext_3_actions, ext_2_actions, ext_1 actions], and actions
// within each block from the same extension should be sorted in descending
// order of priority, so, the merged actions in order are:
//
// Extension 3:
// - e3_br_rule (pri = 3)
// - e3_hr_rule (pri = 2)
// Extension 2:
// - e2_br_rule1 (pri = 10)
// - e2_hr_rule (pri = 2)
// - e2_br_rule2 (pri = 1)
// Extension 1:
// - e1_hr_rule (pri = 100)
EXPECT_THAT(
get_rule_and_extension_ids(merged_actions),
testing::ElementsAre(std::make_pair(*e3_br_rule.id, extension_3_id),
std::make_pair(*e3_hr_rule.id, extension_3_id),
std::make_pair(*e2_br_rule1.id, extension_2_id),
std::make_pair(*e2_hr_rule.id, extension_2_id),
std::make_pair(*e2_br_rule2.id, extension_2_id),
std::make_pair(*e1_hr_rule.id, extension_1_id)));
}
// Tests that extensions can't block requests initiated by other extensions by
// default.
// Note: The --extensions-on-chrome-urls switch isn't tested here, see the
/// CrossExtensionRequestBlocking browser test.
TEST_P(RulesetManagerTest, CrossExtensionRequestBlocking) {
const Extension* extension_1 = nullptr;
const Extension* extension_2 = nullptr;
// Add an extension with a background page that blocks all requests.
{
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("*");
rule.condition->resource_types =
std::vector<std::string>({"main_frame", "sub_frame", "other"});
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension_1", &matcher,
std::vector<std::string>({URLPattern::kAllUrlsPattern}),
true /* has_background_script */));
extension_1 = last_loaded_extension();
manager()->AddRuleset(extension_1->id(), std::move(matcher));
}
// Add a second extension which doesn't do anything.
{
std::unique_ptr<CompositeMatcher> matcher;
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{}, "test extension_2", &matcher,
std::vector<std::string>({URLPattern::kAllUrlsPattern}),
true /* has_background_script */));
extension_2 = last_loaded_extension();
}
EXPECT_EQ(1u, manager()->GetMatcherCountForTest());
// Extensions should be able to block requests that they initiated.
WebRequestInfo request_1(
GetRequestParamsForURL("http://example.com", extension_1->origin()));
manager()->EvaluateBeforeRequest(request_1, false /*is_incognito_context*/);
ASSERT_EQ(1u, request_1.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension_1->id()),
(*request_1.dnr_actions)[0]);
// Extensions should be able to block requests that they initiated from a
// manifest sandbox page.
WebRequestInfo request_2(GetRequestParamsForURL(
"http://example.com", extension_1->origin().DeriveNewOpaqueOrigin()));
manager()->EvaluateBeforeRequest(request_2, false /*is_incognito_context*/);
ASSERT_EQ(1u, request_2.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension_1->id()),
(*request_2.dnr_actions)[0]);
// Extensions should not be able to block (non-navigation) requests initiated
// by other extensions.
WebRequestInfo request_3(
GetRequestParamsForURL("http://example.com", extension_2->origin()));
manager()->EvaluateBeforeRequest(request_3, false /*is_incognito_context*/);
EXPECT_TRUE(request_3.dnr_actions->empty());
// Extensions should not be able to block (non-navigation) requests initiated
// by other extensions, even if they initiated from within a manifest sandbox
// page.
WebRequestInfo request_4(GetRequestParamsForURL(
"http://example.com", extension_2->origin().DeriveNewOpaqueOrigin()));
manager()->EvaluateBeforeRequest(request_4, false /*is_incognito_context*/);
EXPECT_TRUE(request_4.dnr_actions->empty());
// Extensions should be able to block main_frame navigation requests initiated
// by other extensions.
WebRequestInfo request_5(
GetRequestParamsForURL("http://example.com", extension_2->origin(),
WebRequestResourceType::MAIN_FRAME));
manager()->EvaluateBeforeRequest(request_5, false /*is_incognito_context*/);
ASSERT_EQ(1u, request_5.dnr_actions->size());
EXPECT_EQ(CreateRequestActionForTesting(
RequestActionType::BLOCK, kMinValidID, kDefaultPriority,
kMinValidStaticRulesetID, extension_1->id()),
(*request_5.dnr_actions)[0]);
// Extensions should not be able to block sub_frame requests initiated by
// other extensions.
WebRequestInfo request_6(
GetRequestParamsForURL("http://example.com", extension_2->origin(),
WebRequestResourceType::SUB_FRAME));
manager()->EvaluateBeforeRequest(request_6, false /*is_incognito_context*/);
EXPECT_TRUE(request_6.dnr_actions->empty());
}
// Tests that queryTransform rules do not leave a trailing "?" after removing
// the last parameter from a URL.
TEST_P(RulesetManagerTest, QueryTransformRemoveParamsTrailingQuestionMark) {
const Extension* extension = nullptr;
{
std::unique_ptr<CompositeMatcher> matcher;
TestRule rule = CreateGenericRule();
rule.condition->url_filter = std::string("example.com");
rule.action->type = std::string("redirect");
rule.action->redirect.emplace();
rule.action->redirect->transform.emplace();
rule.action->redirect->transform->query_transform.emplace();
rule.action->redirect->transform->query_transform->remove_params =
std::vector<std::string>({"remove"});
ASSERT_NO_FATAL_FAILURE(CreateMatcherForRules(
{rule}, "test extension_1", &matcher,
std::vector<std::string>({URLPattern::kAllUrlsPattern}),
true /* has_background_script */));
extension = last_loaded_extension();
manager()->AddRuleset(extension->id(), std::move(matcher));
}
EXPECT_EQ(1u, manager()->GetMatcherCountForTest());
struct TestCase {
std::string url;
std::string expected_redirected_url;
} test_cases[] = {
{"https://example.com", "https://example.com"},
{"https://example.com?", "https://example.com?"},
{"https://example.com?keep=1", "https://example.com?keep=1"},
{"https://example.com?keep=1&remove=2", "https://example.com?keep=1"},
{"https://example.com?remove=1", "https://example.com"},
{"https://example.com?remove", "https://example.com"}};
for (const auto& test_case : test_cases) {
SCOPED_TRACE("Testing " + test_case.url + " -> " +
test_case.expected_redirected_url);
WebRequestInfo request(GetRequestParamsForURL(test_case.url));
manager()->EvaluateBeforeRequest(request, false /*is_incognito_context*/);
if (request.dnr_actions->empty()) {
EXPECT_EQ(test_case.expected_redirected_url, test_case.url);
} else {
ASSERT_EQ(1u, request.dnr_actions->size());
EXPECT_EQ(GURL(test_case.expected_redirected_url),
(*request.dnr_actions)[0].redirect_url);
}
}
}
INSTANTIATE_TEST_SUITE_P(All,
RulesetManagerTest,
::testing::Values(ExtensionLoadType::PACKED,
ExtensionLoadType::UNPACKED));
INSTANTIATE_TEST_SUITE_P(All,
RulesetManagerResponseHeadersTest,
::testing::Values(ExtensionLoadType::PACKED,
ExtensionLoadType::UNPACKED));
} // namespace
} // namespace extensions::declarative_net_request
|