1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_refptr.h"
#include "base/notreached.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "base/test/values_test_util.h"
#include "build/build_config.h"
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/devtools/devtools_window_testing.h"
#include "chrome/browser/extensions/api/developer_private/developer_private_functions.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/extensions/manifest_v2_experiment_manager.h"
#include "chrome/browser/extensions/mv2_experiment_stage.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_paths.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/service_worker_test_helpers.h"
#include "extensions/browser/api_test_utils.h"
#include "extensions/browser/app_window/app_window.h"
#include "extensions/browser/app_window/app_window_registry.h"
#include "extensions/browser/browsertest_util.h"
#include "extensions/browser/extension_host_test_helper.h"
#include "extensions/browser/offscreen_document_host.h"
#include "extensions/browser/process_manager.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/manifest_handlers/background_info.h"
#include "extensions/common/mojom/view_type.mojom.h"
#include "extensions/test/result_catcher.h"
#include "extensions/test/test_extension_dir.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
#include "ui/views/window/dialog_delegate.h"
namespace extensions {
class DeveloperPrivateApiTest : public ExtensionApiTest {
protected:
std::optional<api::developer_private::ExtensionInfo> GetExtensionInfo(
const Extension& extension) {
auto get_info_function =
base::MakeRefCounted<api::DeveloperPrivateGetExtensionInfoFunction>();
std::optional<base::Value> result =
api_test_utils::RunFunctionAndReturnSingleResult(
get_info_function.get(),
content::JsReplace(R"([$1])", extension.id()), profile());
if (!result) {
ADD_FAILURE() << "No result back when getting extension info";
return std::nullopt;
}
std::optional<api::developer_private::ExtensionInfo> info =
api::developer_private::ExtensionInfo::FromValue(*result);
if (!info) {
ADD_FAILURE() << "Problem creating ExtensionInfo from result data";
}
return info;
}
};
// Tests opening the developer tools for an app window.
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, InspectAppWindowView) {
base::FilePath dir;
base::PathService::Get(chrome::DIR_TEST_DATA, &dir);
dir = dir.AppendASCII("extensions")
.AppendASCII("platform_apps")
.AppendASCII("minimal");
// Load and launch a platform app.
const Extension* app = LoadAndLaunchApp(dir);
// Get the info about the app, including the inspectable views.
auto info = GetExtensionInfo(*app);
// There should be two inspectable views - the background page and the app
// window. Find the app window.
ASSERT_EQ(2u, info->views.size());
const api::developer_private::ExtensionView* window_view = nullptr;
for (const auto& view : info->views) {
if (view.type == api::developer_private::ViewType::kAppWindow) {
window_view = &view;
break;
}
}
ASSERT_TRUE(window_view);
// Inspect the app window.
auto function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(
function.get(),
base::StringPrintf("[{\"renderViewId\": %d, \"renderProcessId\": %d}]",
window_view->render_view_id,
window_view->render_process_id),
profile());
// Verify that dev tools opened.
std::list<raw_ptr<AppWindow, CtnExperimental>> app_windows =
AppWindowRegistry::Get(profile())->GetAppWindowsForApp(app->id());
ASSERT_EQ(1u, app_windows.size());
EXPECT_TRUE(DevToolsWindow::GetInstanceForInspectedWebContents(
(*app_windows.begin())->web_contents()));
}
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, InspectEmbeddedOptionsPage) {
base::FilePath dir;
base::PathService::Get(chrome::DIR_TEST_DATA, &dir);
// Load an extension that only has an embedded options_ui page.
const Extension* extension = LoadExtension(dir.AppendASCII("extensions")
.AppendASCII("delayed_install")
.AppendASCII("v1"));
ASSERT_TRUE(extension);
// Open the embedded options page.
ASSERT_TRUE(ExtensionTabUtil::OpenOptionsPage(extension, browser()));
WaitForExtensionNotIdle(extension->id());
// Get the info about the extension, including the inspectable views.
auto info = GetExtensionInfo(*extension);
// The embedded options page should show up.
ASSERT_EQ(1u, info->views.size());
const api::developer_private::ExtensionView& view = info->views[0];
ASSERT_EQ(api::developer_private::ViewType::kExtensionGuest, view.type);
// Inspect the embedded options page.
auto function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(
function.get(),
base::StringPrintf("[{\"renderViewId\": %d, \"renderProcessId\": %d}]",
view.render_view_id, view.render_process_id),
profile());
// Verify that dev tools opened.
content::RenderFrameHost* render_frame_host =
content::RenderFrameHost::FromID(view.render_process_id,
view.render_view_id);
ASSERT_TRUE(render_frame_host);
content::WebContents* wc =
content::WebContents::FromRenderFrameHost(render_frame_host);
ASSERT_TRUE(wc);
EXPECT_TRUE(DevToolsWindow::GetInstanceForInspectedWebContents(wc));
}
// TODO(crbug.com/40273479): Test is flaky on MSan builders.
// TODO(crbug.com/40282331): Disabled on ASAN due to leak caused by renderer gin
// objects which are intended to be leaked.
#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER)
#define MAYBE_InspectInactiveServiceWorkerBackground \
DISABLED_InspectInactiveServiceWorkerBackground
#else
#define MAYBE_InspectInactiveServiceWorkerBackground \
InspectInactiveServiceWorkerBackground
#endif
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest,
MAYBE_InspectInactiveServiceWorkerBackground) {
ResultCatcher result_catcher;
// Load an extension that is service worker-based.
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("service_worker")
.AppendASCII("worker_based_background")
.AppendASCII("inspect"),
// Wait for the registration to be stored since we'll stop
// the worker.
{.wait_for_registration_stored = true});
ASSERT_TRUE(extension);
ASSERT_TRUE(result_catcher.GetNextResult());
// Stop the service worker.
browsertest_util::StopServiceWorkerForExtensionGlobalScope(profile(),
extension->id());
// Get the info about the extension, including the inspectable views.
auto info = GetExtensionInfo(*extension);
// There should be a worker based background for the extension.
ASSERT_EQ(1u, info->views.size());
const api::developer_private::ExtensionView& view = info->views[0];
EXPECT_EQ(api::developer_private::ViewType::kExtensionServiceWorkerBackground,
view.type);
// The service worker should be inactive (indicated by -1 for
// the process id).
EXPECT_EQ(-1, view.render_process_id);
// Inspect the inactive service worker background.
DevToolsWindowCreationObserver devtools_window_created_observer;
auto dev_tools_function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(dev_tools_function.get(),
base::StringPrintf(
R"([{"renderViewId": -1,
"renderProcessId": -1,
"isServiceWorker": true,
"extensionId": "%s"
}])",
extension->id().c_str()),
profile());
devtools_window_created_observer.WaitForLoad();
// Verify that dev tool window opened.
scoped_refptr<content::DevToolsAgentHost> service_worker_host;
content::DevToolsAgentHost::List targets =
content::DevToolsAgentHost::GetOrCreateAll();
for (const scoped_refptr<content::DevToolsAgentHost>& host : targets) {
if (host->GetType() == content::DevToolsAgentHost::kTypeServiceWorker &&
host->GetURL() ==
extension->GetResourceURL(
BackgroundInfo::GetBackgroundServiceWorkerScript(extension))) {
EXPECT_FALSE(service_worker_host);
service_worker_host = host;
}
}
ASSERT_TRUE(service_worker_host);
EXPECT_TRUE(DevToolsWindow::FindDevToolsWindow(service_worker_host.get()));
}
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest,
InspectActiveServiceWorkerBackground) {
ResultCatcher result_catcher;
// Load an extension that is service worker based.
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("service_worker")
.AppendASCII("worker_based_background")
.AppendASCII("inspect"));
ASSERT_TRUE(extension);
ASSERT_TRUE(result_catcher.GetNextResult());
// Get the info about the extension, including the inspectable views.
auto info = GetExtensionInfo(*extension);
// There should be a worker based background for the extension.
ASSERT_EQ(1u, info->views.size());
const api::developer_private::ExtensionView& view = info->views[0];
EXPECT_EQ(api::developer_private::ViewType::kExtensionServiceWorkerBackground,
view.type);
EXPECT_NE(-1, view.render_process_id);
// Inspect the service worker page.
auto dev_tools_function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(
dev_tools_function.get(),
base::StringPrintf(
R"([{"renderViewId": -1,
"renderProcessId": %d,
"isServiceWorker": true,
"extensionId": "%s"
}])",
info->views[0].render_process_id, extension->id().c_str()),
profile());
// Find the service worker background host.
content::DevToolsAgentHost::List targets =
content::DevToolsAgentHost::GetOrCreateAll();
scoped_refptr<content::DevToolsAgentHost> service_worker_host;
for (const scoped_refptr<content::DevToolsAgentHost>& host : targets) {
if (host->GetType() == content::DevToolsAgentHost::kTypeServiceWorker &&
host->GetURL() ==
extension->GetResourceURL(
BackgroundInfo::GetBackgroundServiceWorkerScript(extension))) {
EXPECT_FALSE(service_worker_host);
service_worker_host = host;
}
}
// Verify that dev tools opened.
ASSERT_TRUE(service_worker_host);
EXPECT_TRUE(DevToolsWindow::FindDevToolsWindow(service_worker_host.get()));
}
// TODO(crbug.com/40882269): The test is flaky on MSAN and Linux. Re-enable it.
#if defined(MEMORY_SANITIZER) || BUILDFLAG(IS_LINUX)
#define MAYBE_InspectSplitModeServiceWorkerBackgrounds \
DISABLED_InspectSplitModeServiceWorkerBackgrounds
#else
#define MAYBE_InspectSplitModeServiceWorkerBackgrounds \
InspectSplitModeServiceWorkerBackgrounds
#endif
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest,
MAYBE_InspectSplitModeServiceWorkerBackgrounds) {
ResultCatcher result_catcher;
// Load an extension that is service worker based, split mode and enabled in
// incognito.
static constexpr char kManifest[] =
R"({
"name": "Split mode worker test",
"manifest_version": 3,
"version": "0.1",
"background": {"service_worker": "worker.js"},
"incognito": "split"
})";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("worker.js"),
"chrome.test.notifyPass();");
const Extension* extension =
LoadExtension(test_dir.UnpackedPath(), {.allow_in_incognito = true});
ASSERT_TRUE(extension);
ASSERT_TRUE(result_catcher.GetNextResult());
// Get the info about the extension, including the inspectable views.
auto info = GetExtensionInfo(*extension);
// With no incognito window open, there should be a single worker based
// background page for the extension.
ASSERT_EQ(1u, info->views.size());
int main_render_process_id = -1;
{
const api::developer_private::ExtensionView& view = info->views[0];
EXPECT_EQ(
api::developer_private::ViewType::kExtensionServiceWorkerBackground,
view.type);
EXPECT_NE(-1, view.render_process_id);
main_render_process_id = view.render_process_id;
EXPECT_FALSE(view.incognito);
}
// Now open up an incognito browser window page and check the inspectable
// views again. Waiting for the result catcher will wait for the incognito
// service worker to have become active.
Browser* incognito_browser = CreateIncognitoBrowser(browser()->profile());
ASSERT_TRUE(incognito_browser);
ASSERT_TRUE(result_catcher.GetNextResult());
info = GetExtensionInfo(*extension);
// The views should now have 2 entries, one for the main worker which will be
// the same as before and a new one for the incognito worker.
ASSERT_EQ(2u, info->views.size());
EXPECT_NE(info->views[0].incognito, info->views[1].incognito);
int incognito_render_process_id = -1;
for (auto& view : info->views) {
EXPECT_EQ(
api::developer_private::ViewType::kExtensionServiceWorkerBackground,
view.type);
EXPECT_NE(-1, view.render_process_id);
if (view.incognito) {
EXPECT_NE(main_render_process_id, view.render_process_id);
incognito_render_process_id = view.render_process_id;
} else {
EXPECT_EQ(main_render_process_id, view.render_process_id);
}
}
// Open a devtools window for both the primary and incognito worker.
std::string kOpenDevToolsParams =
R"([{"renderViewId": -1,
"renderProcessId": $1,
"isServiceWorker": true,
"extensionId": $2,
"incognito": $3
}])";
DevToolsWindow* main_devtools_window = nullptr;
{
DevToolsWindowCreationObserver devtools_window_created_observer;
auto dev_tools_function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(
dev_tools_function.get(),
content::JsReplace(kOpenDevToolsParams, main_render_process_id,
extension->id().c_str(), /*incognito:*/ false),
profile());
devtools_window_created_observer.WaitForLoad();
main_devtools_window = devtools_window_created_observer.devtools_window();
}
DevToolsWindow* incognito_devtools_window = nullptr;
{
DevToolsWindowCreationObserver devtools_window_created_observer;
auto dev_tools_function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(
dev_tools_function.get(),
content::JsReplace(kOpenDevToolsParams, incognito_render_process_id,
extension->id().c_str(), /*incognito:*/ true),
profile());
devtools_window_created_observer.WaitForLoad();
incognito_devtools_window =
devtools_window_created_observer.devtools_window();
}
// Both windows should have opened and should not point to the same window.
ASSERT_TRUE(main_devtools_window);
ASSERT_TRUE(incognito_devtools_window);
ASSERT_NE(main_devtools_window, incognito_devtools_window);
}
// Test that offscreen documents show up in the list of inspectable views and
// can be inspected.
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, InspectOffscreenDocument) {
static constexpr char kManifest[] =
R"({
"name": "Offscreen Document Test",
"manifest_version": 3,
"version": "0.1"
})";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("offscreen.html"),
"<html>offscreen</html>");
const Extension* extension = LoadExtension(test_dir.UnpackedPath());
// Create an offscreen document and wait for it to load.
std::unique_ptr<OffscreenDocumentHost> offscreen_document;
GURL offscreen_url = extension->GetResourceURL("offscreen.html");
{
ExtensionHostTestHelper offscreen_waiter(profile(), extension->id());
offscreen_waiter.RestrictToType(mojom::ViewType::kOffscreenDocument);
offscreen_document = std::make_unique<OffscreenDocumentHost>(
*extension,
ProcessManager::Get(profile())
->GetSiteInstanceForURL(offscreen_url)
.get(),
profile(), offscreen_url);
offscreen_document->CreateRendererSoon();
offscreen_waiter.WaitForHostCompletedFirstLoad();
}
// Get the list of inspectable views for the extension.
auto info = GetExtensionInfo(*extension);
// The only inspectable view should be the offscreen document. Validate the
// metadata.
ASSERT_EQ(1u, info->views.size());
const api::developer_private::ExtensionView& view = info->views[0];
EXPECT_EQ(api::developer_private::ViewType::kOffscreenDocument, view.type);
content::WebContents* offscreen_contents =
offscreen_document->host_contents();
EXPECT_EQ(offscreen_url.spec(), view.url);
EXPECT_EQ(offscreen_document->render_process_host()->GetDeprecatedID(),
view.render_process_id);
EXPECT_EQ(offscreen_contents->GetPrimaryMainFrame()->GetRoutingID(),
view.render_view_id);
EXPECT_FALSE(view.incognito);
EXPECT_FALSE(view.is_iframe);
// The document shouldn't currently be under inspection.
EXPECT_FALSE(
DevToolsWindow::GetInstanceForInspectedWebContents(offscreen_contents));
// Call the API function to inspect the offscreen document.
auto dev_tools_function =
base::MakeRefCounted<api::DeveloperPrivateOpenDevToolsFunction>();
api_test_utils::RunFunction(
dev_tools_function.get(),
content::JsReplace(
R"([{"renderViewId": $1,
"renderProcessId": $2,
"extensionId": $3
}])",
view.render_view_id, view.render_process_id, extension->id()),
profile());
// Validate that the devtools window is now shown.
DevToolsWindow* dev_tools_window =
DevToolsWindow::GetInstanceForInspectedWebContents(offscreen_contents);
ASSERT_TRUE(dev_tools_window);
// Tidy up.
DevToolsWindowTesting::CloseDevToolsWindowSync(dev_tools_window);
}
IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, UninstallMultipleExtensions) {
// Load first extension.
static constexpr char kManifest_0[] =
R"({
"name": "Multiple extensions uninstall test 0",
"manifest_version": 3,
"version": "0.1"
})";
TestExtensionDir test_dir_0;
test_dir_0.WriteManifest(kManifest_0);
const Extension* extension_0 = LoadExtension(test_dir_0.UnpackedPath());
ASSERT_TRUE(extension_0);
std::string extension_0_id = extension_0->id();
// Load second extension.
static constexpr char kManifest_1[] =
R"({
"name": "Multiple extensions uninstall test 1",
"manifest_version": 3,
"version": "0.1"
})";
TestExtensionDir test_dir_1;
test_dir_1.WriteManifest(kManifest_1);
const Extension* extension_1 = LoadExtension(test_dir_1.UnpackedPath());
ASSERT_TRUE(extension_1);
std::string extension_1_id = extension_1->id();
auto function = base::MakeRefCounted<
api::DeveloperPrivateRemoveMultipleExtensionsFunction>();
std::unique_ptr<ExtensionFunctionDispatcher> dispatcher(
new ExtensionFunctionDispatcher(profile()));
function->SetDispatcher(dispatcher->AsWeakPtr());
std::string args =
base::StrCat({"[[\"", extension_0_id, "\", \"", extension_1_id, "\"]]"});
function->SetArgs(base::test::ParseJsonList(args));
// Create a waiter to wait for the uninstall dialog to show up.
views::NamedWidgetShownWaiter waiter(views::test::AnyWidgetTestPasskey{},
"ExtensionMultipleUninstallDialog");
api_test_utils::SendResponseHelper response_helper(function.get());
function->RunWithValidation().Execute();
auto* widget = waiter.WaitIfNeededAndGet();
widget->widget_delegate()->AsDialogDelegate()->AcceptDialog();
response_helper.WaitForResponse();
// Verify the extensions are uninstalled.
EXPECT_FALSE(extension_registry()->GetExtensionById(
extension_0_id, ExtensionRegistry::EVERYTHING));
EXPECT_FALSE(extension_registry()->GetExtensionById(
extension_1_id, ExtensionRegistry::EVERYTHING));
}
class DeveloperPrivateApiWithMV2DeprecationApiTest
: public DeveloperPrivateApiTest,
public testing::WithParamInterface<MV2ExperimentStage> {
public:
DeveloperPrivateApiWithMV2DeprecationApiTest() {
experiment_stage_ = GetParam();
std::vector<base::test::FeatureRef> enabled_features;
std::vector<base::test::FeatureRef> disabled_features;
switch (experiment_stage_) {
case MV2ExperimentStage::kNone:
NOTREACHED();
case MV2ExperimentStage::kWarning:
enabled_features.push_back(
extensions_features::kExtensionManifestV2DeprecationWarning);
disabled_features.push_back(
extensions_features::kExtensionManifestV2Disabled);
disabled_features.push_back(
extensions_features::kExtensionManifestV2Unsupported);
break;
case MV2ExperimentStage::kDisableWithReEnable:
enabled_features.push_back(
extensions_features::kExtensionManifestV2Disabled);
disabled_features.push_back(
extensions_features::kExtensionManifestV2DeprecationWarning);
disabled_features.push_back(
extensions_features::kExtensionManifestV2Unsupported);
break;
case MV2ExperimentStage::kUnsupported:
enabled_features.push_back(
extensions_features::kExtensionManifestV2Unsupported);
disabled_features.push_back(
extensions_features::kExtensionManifestV2Disabled);
disabled_features.push_back(
extensions_features::kExtensionManifestV2DeprecationWarning);
}
feature_list_.InitWithFeatures(enabled_features, disabled_features);
}
MV2ExperimentStage experiment_stage() const { return experiment_stage_; }
private:
base::test::ScopedFeatureList feature_list_;
MV2ExperimentStage experiment_stage_;
};
INSTANTIATE_TEST_SUITE_P(
,
DeveloperPrivateApiWithMV2DeprecationApiTest,
testing::Values(MV2ExperimentStage::kWarning,
MV2ExperimentStage::kDisableWithReEnable,
MV2ExperimentStage::kUnsupported),
[](const testing::TestParamInfo<MV2ExperimentStage>& info) {
switch (info.param) {
case MV2ExperimentStage::kNone:
NOTREACHED();
case MV2ExperimentStage::kWarning:
return "WarningExperiment";
case MV2ExperimentStage::kDisableWithReEnable:
return "DisableExperiment";
case MV2ExperimentStage::kUnsupported:
return "UnsupportedExperiment";
}
});
// Tests that an extension's MV2 deprecation notice is marked as deprecated when
// the function is called and by accepting the dialog, if necessary.
// Note: we don't test cancelling the dialog since that's done extensively in
// unit tests.
IN_PROC_BROWSER_TEST_P(DeveloperPrivateApiWithMV2DeprecationApiTest,
DismissMv2DeprecationNotice) {
// Load MV2 extension.
static constexpr char kManifest[] =
R"({
"name": "MV2 extension",
"manifest_version": 2,
"version": "0.1"
})";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
const Extension* extension = LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
// Verify extension is affected by the MV2 deprecation and its notice hasn't
// been marked as acknowledged.
ManifestV2ExperimentManager* experiment_manager =
ManifestV2ExperimentManager::Get(profile());
EXPECT_TRUE(experiment_manager->IsExtensionAffected(*extension));
EXPECT_FALSE(experiment_manager->DidUserAcknowledgeNotice(extension->id()));
// Create the dismiss notice function.
auto dismiss_notice_function = base::MakeRefCounted<
api::DeveloperPrivateDismissMv2DeprecationNoticeForExtensionFunction>();
std::string args = base::StringPrintf(R"(["%s"])", extension->id().c_str());
switch (experiment_stage()) {
case MV2ExperimentStage::kNone:
NOTREACHED();
case MV2ExperimentStage::kWarning:
api_test_utils::RunFunction(dismiss_notice_function.get(), args,
profile());
// Extension's notice should be marked as acknowledged.
EXPECT_TRUE(experiment_manager->IsExtensionAffected(*extension));
EXPECT_TRUE(
experiment_manager->DidUserAcknowledgeNotice(extension->id()));
break;
case MV2ExperimentStage::kDisableWithReEnable: {
// The function will trigger a dialog for this stage. Add a waiter for the
// dialog.
views::NamedWidgetShownWaiter waiter(views::test::AnyWidgetTestPasskey{},
"Mv2DeprecationKeepDialog");
api_test_utils::SendResponseHelper response_helper(
dismiss_notice_function.get());
// Add a dispatcher to wait for the response since the function won't
// return till the dialog is accepted/canceled.
std::unique_ptr<ExtensionFunctionDispatcher> dispatcher(
new ExtensionFunctionDispatcher(profile()));
dismiss_notice_function->SetDispatcher(dispatcher->AsWeakPtr());
dismiss_notice_function->SetArgs(base::test::ParseJsonList(args));
dismiss_notice_function->RunWithValidation().Execute();
// Wait for the dialog and accept it.
auto* widget = waiter.WaitIfNeededAndGet();
widget->widget_delegate()->AsDialogDelegate()->AcceptDialog();
response_helper.WaitForResponse();
// Extension's notice should be marked as acknowledged.
EXPECT_TRUE(experiment_manager->IsExtensionAffected(*extension));
EXPECT_TRUE(
experiment_manager->DidUserAcknowledgeNotice(extension->id()));
break;
}
case MV2ExperimentStage::kUnsupported: {
std::string error = api_test_utils::RunFunctionAndReturnError(
dismiss_notice_function.get(), args, profile());
EXPECT_EQ(error, base::StringPrintf(
"Cannot dismiss the MV2 deprecation notice for "
"extension with ID '%s' on the unsupported stage.",
extension->id().c_str()));
// Extension's notice should not be marked as acknowledged.
EXPECT_TRUE(experiment_manager->IsExtensionAffected(*extension));
EXPECT_FALSE(
experiment_manager->DidUserAcknowledgeNotice(extension->id()));
break;
}
}
}
} // namespace extensions
|