1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/api/file_system/file_system_api.h"
#include <stddef.h>
#include <memory>
#include <vector>
#include "base/files/file_path.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/shell_dialogs/select_file_dialog.h"
// Tests static helper methods of chrome.fileSystem API functions.
using extensions::FileSystemChooseEntryFunction;
using extensions::api::file_system::AcceptOption;
namespace extensions {
namespace {
void CheckExtensions(const std::vector<base::FilePath::StringType>& expected,
const std::vector<base::FilePath::StringType>& actual) {
EXPECT_EQ(expected.size(), actual.size());
if (expected.size() != actual.size())
return;
for (size_t i = 0; i < expected.size(); ++i) {
EXPECT_EQ(expected[i], actual[i]);
}
}
AcceptOption BuildAcceptOption(const std::string& description,
const std::string& mime_types,
const std::string& extensions) {
AcceptOption option;
if (!description.empty())
option.description = description;
if (!mime_types.empty()) {
option.mime_types = base::SplitString(
mime_types, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
}
if (!extensions.empty()) {
option.extensions = base::SplitString(
extensions, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
}
return option;
}
#if BUILDFLAG(IS_WIN)
#define ToStringType base::UTF8ToWide
#else
#define ToStringType
#endif
} // namespace
TEST(FileSystemApiUnitTest, FileSystemChooseEntryFunctionFileTypeInfoTest) {
// AcceptsAllTypes is ignored when no other extensions are available.
ui::SelectFileDialog::FileTypeInfo file_type_info;
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, base::FilePath::StringType(), std::nullopt,
/*acceptsAllTypes=*/false);
EXPECT_TRUE(file_type_info.include_all_files);
EXPECT_TRUE(file_type_info.extensions.empty());
// Test grouping of multiple types.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
std::vector<AcceptOption> options;
options.push_back(BuildAcceptOption(std::string(),
"application/x-chrome-extension", "jso"));
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, base::FilePath::StringType(), std::move(options),
/*acceptsAllTypes=*/false);
EXPECT_FALSE(file_type_info.include_all_files);
ASSERT_EQ(file_type_info.extensions.size(), (size_t) 1);
EXPECT_TRUE(file_type_info.extension_description_overrides[0].empty()) <<
"No override must be specified for boring accept types";
// Note here (and below) that the expectedTypes are sorted, because we use a
// set internally to generate the output: thus, the output is sorted.
std::vector<base::FilePath::StringType> expectedTypes;
expectedTypes.push_back(ToStringType("crx"));
expectedTypes.push_back(ToStringType("jso"));
CheckExtensions(expectedTypes, file_type_info.extensions[0]);
// Test that not satisfying the extension will force all types.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(
BuildAcceptOption(std::string(), std::string(), "unrelated"));
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, ToStringType(".jso"), std::move(options),
/*acceptsAllTypes=*/false);
EXPECT_TRUE(file_type_info.include_all_files);
// Test multiple list entries, all containing their own types.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(BuildAcceptOption(std::string(), std::string(), "jso,js"));
options.push_back(BuildAcceptOption(std::string(), std::string(), "cpp,cc"));
size_t num_options = options.size();
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, base::FilePath::StringType(), std::move(options),
/*acceptsAllTypes=*/false);
ASSERT_EQ(file_type_info.extensions.size(), num_options);
expectedTypes.clear();
expectedTypes.push_back(ToStringType("js"));
expectedTypes.push_back(ToStringType("jso"));
CheckExtensions(expectedTypes, file_type_info.extensions[0]);
expectedTypes.clear();
expectedTypes.push_back(ToStringType("cc"));
expectedTypes.push_back(ToStringType("cpp"));
CheckExtensions(expectedTypes, file_type_info.extensions[1]);
// Test accept type that causes description override.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(BuildAcceptOption(std::string(), "image/*", "html"));
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, base::FilePath::StringType(), std::move(options),
/*acceptsAllTypes=*/false);
ASSERT_EQ(file_type_info.extension_description_overrides.size(), (size_t) 1);
EXPECT_FALSE(file_type_info.extension_description_overrides[0].empty()) <<
"Accept type \"image/*\" must generate description override";
// Test multiple accept types that cause description override causes us to
// still present the default.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(BuildAcceptOption(std::string(), "image/*,audio/*,video/*",
std::string()));
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, base::FilePath::StringType(), std::move(options),
/*acceptsAllTypes=*/false);
ASSERT_EQ(file_type_info.extension_description_overrides.size(), (size_t) 1);
EXPECT_TRUE(file_type_info.extension_description_overrides[0].empty());
// Test explicit description override.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(
BuildAcceptOption("File Types 101", "image/jpeg", std::string()));
FileSystemChooseEntryFunction::BuildFileTypeInfo(
&file_type_info, base::FilePath::StringType(), std::move(options),
/*acceptsAllTypes=*/false);
EXPECT_EQ(file_type_info.extension_description_overrides[0],
u"File Types 101");
}
TEST(FileSystemApiUnitTest, FileSystemChooseEntryFunctionSuggestionTest) {
std::optional<std::string> opt_name;
base::FilePath suggested_name;
base::FilePath::StringType suggested_extension;
opt_name = std::string("normal_path.txt");
FileSystemChooseEntryFunction::BuildSuggestion(opt_name, &suggested_name,
&suggested_extension);
EXPECT_FALSE(suggested_name.IsAbsolute());
EXPECT_EQ(suggested_name.MaybeAsASCII(), "normal_path.txt");
EXPECT_EQ(suggested_extension, ToStringType("txt"));
// We should provide just the basename, i.e., "path".
opt_name = std::string("/a/bad/path");
FileSystemChooseEntryFunction::BuildSuggestion(opt_name, &suggested_name,
&suggested_extension);
EXPECT_FALSE(suggested_name.IsAbsolute());
EXPECT_EQ(suggested_name.MaybeAsASCII(), "path");
EXPECT_TRUE(suggested_extension.empty());
#if !BUILDFLAG(IS_WIN)
// TODO(thorogood): Fix this test on Windows.
// Filter out absolute paths with no basename.
opt_name = std::string("/");
FileSystemChooseEntryFunction::BuildSuggestion(opt_name, &suggested_name,
&suggested_extension);
EXPECT_FALSE(suggested_name.IsAbsolute());
EXPECT_TRUE(suggested_name.MaybeAsASCII().empty());
EXPECT_TRUE(suggested_extension.empty());
#endif
}
} // namespace extensions
|
