1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/api/identity/web_auth_flow.h"
#include "base/strings/strcat.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_mock_time_task_runner.h"
#include "base/time/time.h"
#include "chrome/browser/extensions/api/identity/web_auth_flow_info_bar_delegate.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/keep_alive/profile_keep_alive_types.h"
#include "chrome/browser/profiles/keep_alive/scoped_profile_keep_alive.h"
#include "chrome/browser/profiles/nuke_profile_directory_utils.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sessions/session_restore.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/keep_alive_registry/keep_alive_types.h"
#include "components/keep_alive_registry/scoped_keep_alive.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/back_forward_cache_util.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/fenced_frame_test_util.h"
#include "content/public/test/test_navigation_observer.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
class MockWebAuthFlowDelegate : public WebAuthFlow::Delegate {
public:
MOCK_METHOD(void, OnAuthFlowURLChange, (const GURL&), (override));
MOCK_METHOD(void, OnAuthFlowTitleChange, (const std::string&), (override));
MOCK_METHOD(void, OnAuthFlowFailure, (WebAuthFlow::Failure), (override));
};
class WebAuthFlowBrowserTest : public InProcessBrowserTest {
public:
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Start());
// Delete the flow early if OnAuthFlowFailure is called. Simulates real
// usages.
ON_CALL(mock(), OnAuthFlowFailure(testing::_))
.WillByDefault(
[this](WebAuthFlow::Failure failure) { DeleteWebAuthFlow(); });
}
void DeleteWebAuthFlow() {
DCHECK(web_auth_flow_);
// Delete the web auth flow (uses DeleteSoon).
web_auth_flow_.release()->DetachDelegateAndDelete();
}
void TearDownOnMainThread() override {
// Ensures any timer tasks finish.
timeout_task_runner_->RunUntilIdle();
if (web_auth_flow_) {
DeleteWebAuthFlow();
}
// Ensures `web_auth_flow_` is deleted before teardown. This cannot be run
// in |DeleteWebAuthFlow| as it can be called from `timeout_task_runner_`'s
// loop.
base::RunLoop().RunUntilIdle();
InProcessBrowserTest::TearDownOnMainThread();
}
void StartWebAuthFlow(
const GURL& url,
WebAuthFlow::Mode mode = WebAuthFlow::Mode::INTERACTIVE,
Profile* profile = nullptr,
WebAuthFlow::AbortOnLoad abort_on_load_for_non_interactive =
WebAuthFlow::AbortOnLoad::kYes,
std::optional<base::TimeDelta> timeout_for_non_interactive = std::nullopt,
std::optional<gfx::Rect> popup_bounds = std::nullopt) {
if (!profile)
profile = browser()->profile();
web_auth_flow_ = std::make_unique<WebAuthFlow>(
&mock_web_auth_flow_delegate_, profile, url, mode,
/*user_gesture=*/true, abort_on_load_for_non_interactive,
timeout_for_non_interactive, popup_bounds);
timeout_task_runner_ = base::MakeRefCounted<base::TestMockTimeTaskRunner>();
web_auth_flow_->SetClockForTesting(timeout_task_runner_->GetMockTickClock(),
timeout_task_runner_);
web_auth_flow_->Start();
}
WebAuthFlow* web_auth_flow() { return web_auth_flow_.get(); }
content::WebContents* web_contents() {
if (!web_auth_flow_) {
return nullptr;
}
return web_auth_flow_->web_contents();
}
MockWebAuthFlowDelegate& mock() { return mock_web_auth_flow_delegate_; }
scoped_refptr<base::TestMockTimeTaskRunner> timeout_task_runner() {
return timeout_task_runner_;
}
private:
std::unique_ptr<WebAuthFlow> web_auth_flow_;
MockWebAuthFlowDelegate mock_web_auth_flow_delegate_;
scoped_refptr<base::TestMockTimeTaskRunner> timeout_task_runner_;
};
class WebAuthFlowInBrowserTabParamBrowserTest : public WebAuthFlowBrowserTest {
public:
bool JsRedirectToUrl(const GURL& url) {
content::TestNavigationObserver redirect_observer(url);
redirect_observer.WatchExistingWebContents();
const std::string script =
base::StringPrintf("window.location.href = '%s'", url.spec().c_str());
bool result = content::ExecJs(web_contents(), script);
if (result) {
redirect_observer.Wait();
}
return result;
}
};
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowURLChangeCalled) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
// Observer for waiting until a navigation to a url has finished.
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url);
navigation_observer.WaitForNavigationFinished();
}
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowFailureChangeCalled) {
// Navigate to a url that doesn't exist.
const GURL error_url = embedded_test_server()->GetURL("/error");
content::TestNavigationObserver navigation_observer(error_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowFailure should be called
// by DidFinishNavigation.
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::LOAD_FAILED));
StartWebAuthFlow(error_url);
navigation_observer.WaitForNavigationFinished();
}
// Tests that the flow launched in silent mode with default parameters will
// terminate immediately with the "interacation required" error if the page
// loads and does not navigate to the redirect URL.
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowFailureCalledInteractionRequired) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// In SILENT mode, DidStopLoading() will force the auth flow to fail if it has
// not already redirected, because we did not specify a timeout.
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::INTERACTION_REQUIRED));
StartWebAuthFlow(auth_url, WebAuthFlow::SILENT);
navigation_observer.Wait();
}
// Tests that the flow launched in silent mode with
// `abortOnLoadForNonInteractive` set to `false` will terminate with the
// "interaction required" after a specified timeout if the page loads and does
// not navigate to the redirect URL.
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowInteractionRequiredWithTimeout) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// In SILENT mode, DidStopLoading() will wait for our specified 50ms timeout
// before calling OnAuthFlowFailure.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
StartWebAuthFlow(auth_url, WebAuthFlow::SILENT, /*profile=*/nullptr,
WebAuthFlow::AbortOnLoad::kNo,
/*timeout_for_non_interactive=*/base::Milliseconds(50));
navigation_observer.Wait();
testing::Mock::VerifyAndClearExpectations(&mock());
// Increment the time by 40ms - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Milliseconds(40));
testing::Mock::VerifyAndClearExpectations(&mock());
// Now we exceed our 50ms limit and expect a failure.
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::INTERACTION_REQUIRED));
timeout_task_runner()->FastForwardBy(base::Milliseconds(20));
}
// Tests that the flow launched in silent mode with
// `abortOnLoadForNonInteractive` set to `false` will terminate with the
// "interaction required" error after a default timeout if the page loads and
// does not navigate to the redirect URL.
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowInteractionRequiredWithDefaultTimeout) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// In SILENT mode, DidStopLoading() will wait for the default 1 minute timeout
// before calling OnAuthFlowFailure.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
StartWebAuthFlow(auth_url, WebAuthFlow::SILENT, /*profile=*/nullptr,
WebAuthFlow::AbortOnLoad::kNo);
navigation_observer.Wait();
testing::Mock::VerifyAndClearExpectations(&mock());
// Increment the time by 59s - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Seconds(59));
testing::Mock::VerifyAndClearExpectations(&mock());
// Now we exceed the 1 minute default limit and expect a failure.
// The error is "interaction required" when the flow times out when the page
// has already loaded.
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::INTERACTION_REQUIRED));
timeout_task_runner()->FastForwardBy(base::Seconds(2));
}
// Tests that the flow launched in silent mode with `timeoutMsForNonInteractive`
// set will terminate with the "timed out" error after a timeout if the page
// fails to load (distinct from the flow failing to navigate to the redirect URL
// in time).
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowPageLoadTimeout) {
const GURL auth_url = embedded_test_server()->GetURL("/hung-after-headers");
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
base::RunLoop run_loop;
ON_CALL(mock(), OnAuthFlowURLChange(testing::_))
.WillByDefault([&run_loop](const GURL& url) { run_loop.Quit(); });
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// In SILENT mode, DidStopLoading() will wait for our specified 50ms timeout
// before calling OnAuthFlowFailure.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
StartWebAuthFlow(auth_url, WebAuthFlow::SILENT, /*profile=*/nullptr,
WebAuthFlow::AbortOnLoad::kYes,
/*timeout_for_non_interactive=*/base::Milliseconds(50));
// Wait for navigation to the failing page to start first.
run_loop.Run();
testing::Mock::VerifyAndClearExpectations(&mock());
// Increment the time by 40ms - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Milliseconds(40));
testing::Mock::VerifyAndClearExpectations(&mock());
// Now we exceed our 50ms limit and expect a failure. The error is "load
// timed out" when the flow times out while the page is still loading.
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::TIMED_OUT));
timeout_task_runner()->FastForwardBy(base::Milliseconds(20));
}
// Tests that the flow launched in silent mode with
// `abortOnLoadForNonInteractive` set to `false` and
// `timeoutMsForNonInteractive` set will succeed if it navigates to the redirect
// URL before the timeout.
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowRedirectBeforeTimeout) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// In SILENT mode, DidStopLoading() will wait for our specified 50ms timeout
// before calling OnAuthFlowFailure.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
StartWebAuthFlow(auth_url, WebAuthFlow::SILENT, /*profile=*/nullptr,
WebAuthFlow::AbortOnLoad::kNo,
/*timeout_for_non_interactive=*/base::Milliseconds(50));
navigation_observer.Wait();
testing::Mock::VerifyAndClearExpectations(&mock());
// Increment the time by 40ms - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Milliseconds(40));
testing::Mock::VerifyAndClearExpectations(&mock());
// Redirect after page load and check we get OnAuthFlowURLChange.
const GURL redirect_url = embedded_test_server()->GetURL("/title2.html");
EXPECT_CALL(mock(), OnAuthFlowURLChange(redirect_url));
EXPECT_TRUE(JsRedirectToUrl(redirect_url));
}
// Tests that the loaded auth page can redirect multiple times and fails only
// after the timeout.
IN_PROC_BROWSER_TEST_F(WebAuthFlowInBrowserTabParamBrowserTest,
OnAuthFlowMultipleRedirects) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
// The delegate method OnAuthFlowURLChange should be called
// by DidStartNavigation.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// In SILENT mode, DidStopLoading() will wait for our specified 50ms timeout
// before calling OnAuthFlowFailure.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
StartWebAuthFlow(auth_url, WebAuthFlow::SILENT, /*profile=*/nullptr,
WebAuthFlow::AbortOnLoad::kNo,
/*timeout_for_non_interactive=*/base::Milliseconds(50));
navigation_observer.Wait();
testing::Mock::VerifyAndClearExpectations(&mock());
// Increment the time by 10ms - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Milliseconds(10));
testing::Mock::VerifyAndClearExpectations(&mock());
// Redirect after page load and check we get OnAuthFlowURLChange.
const GURL redirect_url = embedded_test_server()->GetURL("/title2.html");
EXPECT_CALL(mock(), OnAuthFlowURLChange(redirect_url));
EXPECT_TRUE(JsRedirectToUrl(redirect_url));
// Increment the time by 10ms - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Milliseconds(10));
testing::Mock::VerifyAndClearExpectations(&mock());
// Redirect after 2nd page load and check we get OnAuthFlowURLChange.
const GURL redirect_url2 = embedded_test_server()->GetURL("/title3.html");
EXPECT_CALL(mock(), OnAuthFlowURLChange(redirect_url2));
EXPECT_TRUE(JsRedirectToUrl(redirect_url2));
testing::Mock::VerifyAndClearExpectations(&mock());
// Increment the time by 10ms - nothing should happen.
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
timeout_task_runner()->FastForwardBy(base::Milliseconds(10));
testing::Mock::VerifyAndClearExpectations(&mock());
// Now we exceed our 50ms limit and expect a failure.
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::INTERACTION_REQUIRED));
timeout_task_runner()->FastForwardBy(base::Milliseconds(30));
}
class WebAuthFlowFencedFrameTest
: public WebAuthFlowInBrowserTabParamBrowserTest {
public:
content::test::FencedFrameTestHelper& fenced_frame_test_helper() {
return fenced_frame_helper_;
}
private:
content::test::FencedFrameTestHelper fenced_frame_helper_;
};
IN_PROC_BROWSER_TEST_F(WebAuthFlowFencedFrameTest,
FencedFrameNavigationSuccess) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
// Observer for waiting until loading stops. A fenced frame will be created
// after load has finished.
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.set_wait_event(
content::TestNavigationObserver::WaitEvent::kLoadStopped);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url);
navigation_observer.Wait();
testing::Mock::VerifyAndClearExpectations(&mock());
// Navigation for fenced frames should not affect to call the delegate methods
// in the WebAuthFlow.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url)).Times(0);
// Create a fenced frame into the inner WebContents of the WebAuthFlow.
ASSERT_TRUE(fenced_frame_test_helper().CreateFencedFrame(
web_contents()->GetPrimaryMainFrame(),
embedded_test_server()->GetURL("/fenced_frames/title1.html")));
}
IN_PROC_BROWSER_TEST_F(WebAuthFlowFencedFrameTest,
FencedFrameNavigationFailure) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
// Observer for waiting until loading stops. A fenced frame will be created
// after load has finished.
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.set_wait_event(
content::TestNavigationObserver::WaitEvent::kLoadStopped);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url);
navigation_observer.Wait();
testing::Mock::VerifyAndClearExpectations(&mock());
// Navigation for fenced frames should not affect to call the delegate methods
// in the WebAuthFlow.
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url)).Times(0);
EXPECT_CALL(mock(), OnAuthFlowFailure).Times(0);
// Create a fenced frame into the inner WebContents of the WebAuthFlow.
ASSERT_TRUE(fenced_frame_test_helper().CreateFencedFrame(
web_contents()->GetPrimaryMainFrame(),
embedded_test_server()->GetURL("/error"), net::Error::ERR_FAILED));
}
// This test is in two parts:
// - First create a WebAuthFlow in interactive mode that will create a new tab
// with the auth_url.
// - Close the new created tab, simulating the user declining the consent by
// closing the tab.
//
// These two tests are combined into one in order not to re-test the tab
// creation twice.
IN_PROC_BROWSER_TEST_F(WebAuthFlowBrowserTest,
InteractivePopupWindowCreatedWithAuthURL_ThenCloseTab) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE);
const char extension_name[] = "extension_name";
web_auth_flow()->SetShouldShowInfoBar(extension_name);
navigation_observer.Wait();
Browser* popup_browser = chrome::FindBrowserWithTab(web_contents());
EXPECT_EQ(popup_browser->type(), Browser::Type::TYPE_POPUP);
EXPECT_NE(browser(), popup_browser);
TabStripModel* tabs = popup_browser->tab_strip_model();
EXPECT_EQ(tabs->GetActiveWebContents()->GetLastCommittedURL(), auth_url);
// Check info bar exists and displays proper message with extension name.
base::WeakPtr<WebAuthFlowInfoBarDelegate> infobar_delegate =
web_auth_flow()->GetInfoBarDelegateForTesting();
EXPECT_TRUE(infobar_delegate);
EXPECT_EQ(
infobar_delegate->GetIdentifier(),
infobars::InfoBarDelegate::EXTENSIONS_WEB_AUTH_FLOW_INFOBAR_DELEGATE);
EXPECT_TRUE(infobar_delegate->GetMessageText().find(
base::UTF8ToUTF16(std::string(extension_name))));
//---------------------------------------------------------------------
// Part of the test that closes the tab, simulating declining the consent.
//---------------------------------------------------------------------
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::Failure::WINDOW_CLOSED));
tabs->CloseWebContentsAt(tabs->active_index(), 0);
}
IN_PROC_BROWSER_TEST_F(
WebAuthFlowBrowserTest,
InteractivePopupWindowCreatedWithAuthURL_NavigationInURLDoesNotBreakTheFlow) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE);
web_auth_flow()->SetShouldShowInfoBar("extension name");
navigation_observer.Wait();
//---------------------------------------------------------------------
// Browser-initiated URL change in the opened tab before completing the auth
// flow should not trigger an auth flow failure in popup window mode
// specifically to allow Back/Forward navigation. Other types of URL changes
// such as new URL input are actually disabled in the Popup window by the UI.
//---------------------------------------------------------------------
testing::Mock::VerifyAndClearExpectations(&mock());
// Keeping a reference to the info bar delegate to check later.
base::WeakPtr<WebAuthFlowInfoBarDelegate> auth_info_bar =
web_auth_flow()->GetInfoBarDelegateForTesting();
ASSERT_TRUE(auth_info_bar);
Browser* popup_browser = chrome::FindBrowserWithTab(web_contents());
EXPECT_EQ(popup_browser->type(), Browser::Type::TYPE_POPUP);
EXPECT_NE(browser(), popup_browser);
// Simulate an internal navigation, such as an authentication that needs an
// input of username and password on two different pages/urls.
GURL new_url = embedded_test_server()->GetURL("/title2.html");
EXPECT_CALL(mock(), OnAuthFlowURLChange(new_url));
ASSERT_TRUE(content::NavigateToURL(web_contents(), new_url));
EXPECT_EQ(web_contents()->GetURL(), new_url);
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// TODO(crbug.com/40272465): Need to disable BackForwardCaching as it
// causes crashes since the WebContent is initially loaded in an
// unattached mode.
content::DisableBackForwardCacheForTesting(
web_contents(), content::BackForwardCache::DisableForTestingReason::
TEST_REQUIRES_NO_CACHING);
ASSERT_TRUE(content::HistoryGoBack(web_contents()));
EXPECT_EQ(web_contents()->GetURL(), auth_url);
// Popup window is still active.
EXPECT_TRUE(popup_browser);
EXPECT_EQ(chrome::FindBrowserWithTab(web_contents()), popup_browser);
// Infobar should not be closed on navigation.
EXPECT_TRUE(auth_info_bar);
}
IN_PROC_BROWSER_TEST_F(
WebAuthFlowBrowserTest,
InteractiveNoBrowser_WebAuthCreatesBrowserWithPopupWindow) {
Profile* profile = browser()->profile();
// Simulates an extension being opened, in order for the profile not to be
// added for destruction.
ScopedProfileKeepAlive profile_keep_alive(
profile, ProfileKeepAliveOrigin::kBackgroundMode);
ScopedKeepAlive keep_alive{KeepAliveOrigin::BROWSER,
KeepAliveRestartOption::DISABLED};
CloseBrowserSynchronously(browser());
ASSERT_FALSE(chrome::FindBrowserWithProfile(profile));
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE, profile);
navigation_observer.Wait();
Browser* new_browser = chrome::FindBrowserWithProfile(profile);
EXPECT_TRUE(new_browser);
EXPECT_EQ(new_browser->type(), Browser::Type::TYPE_POPUP);
EXPECT_EQ(new_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL(),
auth_url);
}
// This is a regression test for crbug/1445824, makes sure the opened popup
// window does not trigger Session restore.
IN_PROC_BROWSER_TEST_F(WebAuthFlowBrowserTest,
InteractiveNoBrowser_NotActivatingSessionRestore) {
Profile* profile = browser()->profile();
// Enable SessionRestore to last used pages.
SessionStartupPref startup_pref(SessionStartupPref::LAST);
SessionStartupPref::SetStartupPref(profile, startup_pref);
// Simulates an extension being opened, with no active browser.
ScopedProfileKeepAlive profile_keep_alive(
profile, ProfileKeepAliveOrigin::kBackgroundMode);
ScopedKeepAlive keep_alive{KeepAliveOrigin::BROWSER,
KeepAliveRestartOption::DISABLED};
CloseBrowserSynchronously(browser());
ASSERT_FALSE(chrome::FindBrowserWithProfile(profile));
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE, profile);
navigation_observer.Wait();
// Makes sure only one browser is created and profile is not trying to restore
// previous tabs.
EXPECT_FALSE(SessionRestore::IsRestoring(profile));
EXPECT_EQ(chrome::FindAllBrowsersWithProfile(profile).size(), 1u);
Browser* new_browser = chrome::FindBrowserWithProfile(profile);
EXPECT_TRUE(new_browser);
EXPECT_EQ(new_browser->type(), Browser::Type::TYPE_POPUP);
EXPECT_EQ(new_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL(),
auth_url);
}
IN_PROC_BROWSER_TEST_F(WebAuthFlowBrowserTest, SilentNewTabNotCreated) {
TabStripModel* tabs = browser()->tab_strip_model();
int initial_tab_count = tabs->count();
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(),
OnAuthFlowFailure(WebAuthFlow::Failure::INTERACTION_REQUIRED));
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::SILENT);
navigation_observer.Wait();
// Tab not created, tab count did not increase.
EXPECT_EQ(tabs->count(), initial_tab_count);
}
IN_PROC_BROWSER_TEST_F(WebAuthFlowBrowserTest,
InteractiveNewTabCreatedWithAuthURL_NoInfoBarByDefault) {
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE);
navigation_observer.Wait();
Browser* popup_browser = chrome::FindBrowserWithTab(web_contents());
TabStripModel* tabs = popup_browser->tab_strip_model();
EXPECT_NE(browser(), popup_browser);
EXPECT_EQ(tabs->GetActiveWebContents()->GetLastCommittedURL(), auth_url);
// Check info bar is not created if not set via
// `SetShouldShowInfoBar())`.
base::WeakPtr<WebAuthFlowInfoBarDelegate> infobar_delegate =
web_auth_flow()->GetInfoBarDelegateForTesting();
EXPECT_FALSE(infobar_delegate);
}
IN_PROC_BROWSER_TEST_F(WebAuthFlowBrowserTest,
PopupWindowOpened_ThenCloseWindow) {
size_t initial_browser_count = chrome::GetTotalBrowserCount();
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE);
navigation_observer.Wait();
// New popup window is a browser, browser count should increment by 1.
EXPECT_EQ(chrome::GetTotalBrowserCount(), initial_browser_count + 1);
// Retrieve the browser used in the WebAuthFlow, the popup window.
Browser* popup_window_browser = chrome::FindBrowserWithTab(web_contents());
EXPECT_NE(popup_window_browser, browser());
TabStripModel* popup_tabs = popup_window_browser->tab_strip_model();
EXPECT_EQ(popup_tabs->count(), 1);
EXPECT_EQ(popup_tabs->GetActiveWebContents()->GetLastCommittedURL(),
auth_url);
//---------------------------------------------------------------------
// Closing the browser popup window, simulating declining the consent.
//---------------------------------------------------------------------
EXPECT_CALL(mock(), OnAuthFlowFailure(WebAuthFlow::Failure::WINDOW_CLOSED));
CloseBrowserSynchronously(popup_window_browser);
}
IN_PROC_BROWSER_TEST_F(
WebAuthFlowBrowserTest,
Interactive_MarkedForDeletionProfileNotAllowedToCreatePopupWindow) {
// Marking active profile for deletion.
MarkProfileDirectoryForDeletion(browser()->profile()->GetPath());
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
// Profiles marked for deletion are not allowed to create a popup window and
// should return an error.
EXPECT_CALL(mock(),
OnAuthFlowFailure(WebAuthFlow::Failure::CANNOT_CREATE_WINDOW));
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE);
navigation_observer.Wait();
}
IN_PROC_BROWSER_TEST_F(WebAuthFlowBrowserTest, PopupWindowOpened_WithBounds) {
size_t initial_browser_count = chrome::GetTotalBrowserCount();
const GURL auth_url = embedded_test_server()->GetURL("/title1.html");
content::TestNavigationObserver navigation_observer(auth_url);
navigation_observer.StartWatchingNewWebContents();
EXPECT_CALL(mock(), OnAuthFlowURLChange(auth_url));
const gfx::Rect test_bounds(35, 47, 400, 400);
StartWebAuthFlow(auth_url, WebAuthFlow::Mode::INTERACTIVE, nullptr,
WebAuthFlow::AbortOnLoad::kYes, std::nullopt, test_bounds);
navigation_observer.Wait();
// New popup window is a browser, browser count should increment by 1.
EXPECT_EQ(chrome::GetTotalBrowserCount(), initial_browser_count + 1);
// Retrieve the browser used in the WebAuthFlow, the popup window.
Browser* popup_window_browser = chrome::FindBrowserWithTab(web_contents());
EXPECT_NE(popup_window_browser, browser());
gfx::Rect bounds = popup_window_browser->window()->GetBounds();
EXPECT_EQ(bounds.x(), test_bounds.x());
EXPECT_EQ(bounds.y(), test_bounds.y());
// The final width and height can contain platform-specific offsets for the
// window title bar, which we don't want to assert exactly here.
EXPECT_GE(bounds.width(), test_bounds.width());
EXPECT_GE(bounds.height(), test_bounds.height());
}
} // namespace extensions
|