1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h"
#include <stddef.h>
#include <memory>
#include <utility>
#include "base/json/json_reader.h"
#include "base/values.h"
#include "chrome/browser/extensions/permissions/permissions_test_util.h"
#include "chrome/common/extensions/api/permissions.h"
#include "extensions/common/extension.h"
#include "extensions/common/permissions/permission_set.h"
#include "extensions/common/permissions/permissions_info.h"
#include "extensions/common/permissions/usb_device_permission.h"
#include "extensions/common/url_pattern_set.h"
#include "extensions/common/user_script.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
using extensions::api::permissions::Permissions;
using extensions::mojom::APIPermissionID;
using extensions::permissions_api_helpers::PackPermissionSet;
using extensions::permissions_api_helpers::UnpackPermissionSet;
using extensions::permissions_api_helpers::UnpackPermissionSetResult;
using extensions::permissions_test_util::GetPatternsAsStrings;
namespace extensions {
// Tests that we can convert PermissionSets to the generated types.
TEST(PermissionsApiHelpersTest, Pack) {
APIPermissionSet apis;
apis.insert(APIPermissionID::kTab);
URLPatternSet explicit_hosts(
{URLPattern(Extension::kValidHostPermissionSchemes, "http://a.com/*"),
URLPattern(Extension::kValidHostPermissionSchemes, "http://b.com/*")});
URLPatternSet scriptable_hosts(
{URLPattern(UserScript::ValidUserScriptSchemes(), "http://c.com/*"),
URLPattern(UserScript::ValidUserScriptSchemes(), "http://d.com/*")});
// Pack the permission set to value and verify its contents.
std::unique_ptr<Permissions> pack_result(PackPermissionSet(
PermissionSet(std::move(apis), ManifestPermissionSet(),
std::move(explicit_hosts), std::move(scriptable_hosts))));
ASSERT_TRUE(pack_result);
ASSERT_TRUE(pack_result->permissions);
EXPECT_THAT(*pack_result->permissions, testing::UnorderedElementsAre("tabs"));
ASSERT_TRUE(pack_result->origins);
EXPECT_THAT(*pack_result->origins, testing::UnorderedElementsAre(
"http://a.com/*", "http://b.com/*",
"http://c.com/*", "http://d.com/*"));
}
// Tests various error conditions and edge cases when unpacking Dicts
// into PermissionSets.
TEST(PermissionsApiHelpersTest, Unpack_Basic) {
base::Value::List apis;
apis.Append("tabs");
base::Value::List origins;
origins.Append("http://a.com/*");
std::unique_ptr<const PermissionSet> permissions;
std::string error;
APIPermissionSet optional_apis;
optional_apis.insert(APIPermissionID::kTab);
URLPatternSet optional_explicit_hosts(
{URLPattern(Extension::kValidHostPermissionSchemes, "http://a.com/*")});
PermissionSet optional_permissions(
std::move(optional_apis), ManifestPermissionSet(),
std::move(optional_explicit_hosts), URLPatternSet());
// Origins shouldn't have to be present.
{
base::Value::Dict dict;
dict.Set("permissions", apis.Clone());
auto permissions_object = Permissions::FromValue(dict);
EXPECT_TRUE(permissions_object);
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(*permissions_object, PermissionSet(),
optional_permissions, true, &error);
ASSERT_TRUE(unpack_result);
EXPECT_TRUE(error.empty());
EXPECT_EQ(1u, unpack_result->optional_apis.size());
EXPECT_TRUE(
unpack_result->optional_apis.count(mojom::APIPermissionID::kTab));
}
// The api permissions don't need to be present either.
{
base::Value::Dict dict;
dict.Set("origins", origins.Clone());
auto permissions_object = Permissions::FromValue(dict);
EXPECT_TRUE(permissions_object);
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(*permissions_object, PermissionSet(),
optional_permissions, true, &error);
ASSERT_TRUE(unpack_result);
EXPECT_TRUE(error.empty());
EXPECT_THAT(permissions_test_util::GetPatternsAsStrings(
unpack_result->optional_explicit_hosts),
testing::UnorderedElementsAre("http://a.com/*"));
}
// Throw errors for non-string API permissions.
{
base::Value::Dict dict;
base::Value::List invalid_apis = apis.Clone();
invalid_apis.Append(3);
dict.Set("permissions", std::move(invalid_apis));
auto permissions_object = Permissions::FromValue(dict);
EXPECT_FALSE(permissions_object);
}
// Throw errors for non-string origins.
{
base::Value::Dict dict;
base::Value::List invalid_origins = origins.Clone();
invalid_origins.Append(3);
dict.Set("origins", std::move(invalid_origins));
auto permissions_object = Permissions::FromValue(dict);
EXPECT_FALSE(permissions_object);
}
// Throw errors when "origins" or "permissions" are not list values.
{
base::Value::Dict dict;
dict.Set("origins", 2);
auto permissions_object = Permissions::FromValue(dict);
EXPECT_FALSE(permissions_object);
}
{
base::Value::Dict dict;
dict.Set("permissions", 2);
auto permissions_object = Permissions::FromValue(dict);
EXPECT_FALSE(permissions_object);
}
// Additional fields should be allowed.
{
base::Value::Dict dict;
dict.Set("origins", origins.Clone());
dict.Set("random", 3);
auto permissions_object = Permissions::FromValue(dict);
EXPECT_TRUE(permissions_object);
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(*permissions_object, PermissionSet(),
optional_permissions, true, &error);
ASSERT_TRUE(unpack_result);
EXPECT_TRUE(error.empty());
EXPECT_THAT(permissions_test_util::GetPatternsAsStrings(
unpack_result->optional_explicit_hosts),
testing::UnorderedElementsAre("http://a.com/*"));
}
// Unknown permissions should throw an error.
{
base::Value::Dict dict;
base::Value::List invalid_apis = apis.Clone();
invalid_apis.Append("unknown_permission");
dict.Set("permissions", std::move(invalid_apis));
auto permissions_object = Permissions::FromValue(dict);
EXPECT_TRUE(permissions_object);
EXPECT_FALSE(UnpackPermissionSet(*permissions_object, PermissionSet(),
optional_permissions, true, &error));
EXPECT_EQ(error, "'unknown_permission' is not a recognized permission.");
}
}
// Tests that host permissions are properly partitioned according to the
// required/optional permission sets.
TEST(PermissionsApiHelpersTest, Unpack_HostSeparation) {
auto explicit_url_pattern = [](const char* pattern) {
return URLPattern(Extension::kValidHostPermissionSchemes, pattern);
};
auto scriptable_url_pattern = [](const char* pattern) {
return URLPattern(UserScript::ValidUserScriptSchemes(), pattern);
};
constexpr char kRequiredExplicit1[] = "https://required_explicit1.com/*";
constexpr char kRequiredExplicit2[] = "https://required_explicit2.com/*";
constexpr char kOptionalExplicit1[] = "https://optional_explicit1.com/*";
constexpr char kOptionalExplicit2[] = "https://optional_explicit2.com/*";
constexpr char kRequiredScriptable1[] = "https://required_scriptable1.com/*";
constexpr char kRequiredScriptable2[] = "https://required_scriptable2.com/*";
constexpr char kRequiredExplicitAndScriptable1[] =
"https://required_explicit_and_scriptable1.com/*";
constexpr char kRequiredExplicitAndScriptable2[] =
"https://required_explicit_and_scriptable2.com/*";
constexpr char kOptionalExplicitAndRequiredScriptable1[] =
"https://optional_explicit_and_scriptable1.com/*";
constexpr char kOptionalExplicitAndRequiredScriptable2[] =
"https://optional_explicit_and_scriptable2.com/*";
constexpr char kUnlisted1[] = "https://unlisted1.com/*";
URLPatternSet required_explicit_hosts({
explicit_url_pattern(kRequiredExplicit1),
explicit_url_pattern(kRequiredExplicit2),
explicit_url_pattern(kRequiredExplicitAndScriptable1),
explicit_url_pattern(kRequiredExplicitAndScriptable2),
});
URLPatternSet required_scriptable_hosts({
scriptable_url_pattern(kRequiredScriptable1),
scriptable_url_pattern(kRequiredScriptable2),
scriptable_url_pattern(kRequiredExplicitAndScriptable1),
scriptable_url_pattern(kRequiredExplicitAndScriptable2),
scriptable_url_pattern(kOptionalExplicitAndRequiredScriptable1),
scriptable_url_pattern(kOptionalExplicitAndRequiredScriptable2),
});
URLPatternSet optional_explicit_hosts({
explicit_url_pattern(kOptionalExplicit1),
explicit_url_pattern(kOptionalExplicit2),
explicit_url_pattern(kOptionalExplicitAndRequiredScriptable1),
explicit_url_pattern(kOptionalExplicitAndRequiredScriptable2),
});
PermissionSet required_permissions(
APIPermissionSet(), ManifestPermissionSet(),
std::move(required_explicit_hosts), std::move(required_scriptable_hosts));
PermissionSet optional_permissions(
APIPermissionSet(), ManifestPermissionSet(),
std::move(optional_explicit_hosts), URLPatternSet());
Permissions permissions_object;
permissions_object.origins = std::vector<std::string>(
{kRequiredExplicit1, kOptionalExplicit1, kRequiredScriptable1,
kRequiredExplicitAndScriptable1, kOptionalExplicitAndRequiredScriptable1,
kUnlisted1});
std::string error;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, required_permissions,
optional_permissions, true, &error);
ASSERT_TRUE(unpack_result);
EXPECT_TRUE(error.empty()) << error;
EXPECT_THAT(GetPatternsAsStrings(unpack_result->required_explicit_hosts),
testing::UnorderedElementsAre(kRequiredExplicit1,
kRequiredExplicitAndScriptable1));
EXPECT_THAT(GetPatternsAsStrings(unpack_result->optional_explicit_hosts),
testing::UnorderedElementsAre(
kOptionalExplicit1, kOptionalExplicitAndRequiredScriptable1));
EXPECT_THAT(GetPatternsAsStrings(unpack_result->required_scriptable_hosts),
testing::UnorderedElementsAre(
kRequiredScriptable1, kRequiredExplicitAndScriptable1,
kOptionalExplicitAndRequiredScriptable1));
EXPECT_THAT(GetPatternsAsStrings(unpack_result->unlisted_hosts),
testing::UnorderedElementsAre(kUnlisted1));
}
// Tests that host permissions are properly partitioned according to the
// required/optional permission sets.
TEST(PermissionsApiHelpersTest, Unpack_APISeparation) {
constexpr APIPermissionID kRequired1 = APIPermissionID::kTab;
constexpr APIPermissionID kRequired2 = APIPermissionID::kStorage;
constexpr APIPermissionID kOptional1 = APIPermissionID::kCookie;
constexpr APIPermissionID kOptional2 = APIPermissionID::kAlarms;
constexpr APIPermissionID kUnlisted1 = APIPermissionID::kIdle;
APIPermissionSet required_apis;
required_apis.insert(kRequired1);
required_apis.insert(kRequired2);
APIPermissionSet optional_apis;
optional_apis.insert(kOptional1);
optional_apis.insert(kOptional2);
PermissionSet required_permissions(std::move(required_apis),
ManifestPermissionSet(), URLPatternSet(),
URLPatternSet());
PermissionSet optional_permissions(std::move(optional_apis),
ManifestPermissionSet(), URLPatternSet(),
URLPatternSet());
Permissions permissions_object;
permissions_object.permissions =
std::vector<std::string>({"tabs", "cookies", "idle"});
std::string error;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, required_permissions,
optional_permissions, true, &error);
ASSERT_TRUE(unpack_result);
EXPECT_TRUE(error.empty()) << error;
EXPECT_EQ(1u, unpack_result->required_apis.size());
EXPECT_TRUE(unpack_result->required_apis.count(kRequired1));
EXPECT_EQ(1u, unpack_result->optional_apis.size());
EXPECT_TRUE(unpack_result->optional_apis.count(kOptional1));
EXPECT_EQ(1u, unpack_result->unlisted_apis.size());
EXPECT_TRUE(unpack_result->unlisted_apis.count(kUnlisted1));
}
// Tests that unpacking works correctly with wildcard schemes (which are
// interesting, because they only match http | https, and not all schemes).
TEST(PermissionsApiHelpersTest, Unpack_WildcardSchemes) {
constexpr char kWildcardSchemePattern[] = "*://*/*";
PermissionSet optional_permissions(
APIPermissionSet(), ManifestPermissionSet(),
URLPatternSet({URLPattern(Extension::kValidHostPermissionSchemes,
kWildcardSchemePattern)}),
URLPatternSet());
Permissions permissions_object;
permissions_object.origins =
std::vector<std::string>({kWildcardSchemePattern});
std::string error;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, PermissionSet(),
optional_permissions, true, &error);
ASSERT_TRUE(unpack_result) << error;
EXPECT_THAT(GetPatternsAsStrings(unpack_result->optional_explicit_hosts),
testing::ElementsAre(kWildcardSchemePattern));
}
// Tests that unpacking <all_urls> correctly includes or omits the file:-scheme.
TEST(PermissionsApiHelpersTest, Unpack_FileSchemes_AllUrls) {
// Without file access, <all_urls> should be parsed, but the resulting pattern
// should not include file:-scheme access.
{
const int kNonFileSchemes =
Extension::kValidHostPermissionSchemes & ~URLPattern::SCHEME_FILE;
URLPattern all_urls(kNonFileSchemes, URLPattern::kAllUrlsPattern);
PermissionSet required_permissions(
APIPermissionSet(), ManifestPermissionSet(), URLPatternSet({all_urls}),
URLPatternSet());
Permissions permissions_object;
permissions_object.origins =
std::vector<std::string>({URLPattern::kAllUrlsPattern});
constexpr bool kHasFileAccess = false;
std::string error;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, required_permissions,
PermissionSet(), kHasFileAccess, &error);
ASSERT_TRUE(unpack_result) << error;
EXPECT_THAT(GetPatternsAsStrings(unpack_result->required_explicit_hosts),
testing::ElementsAre(URLPattern::kAllUrlsPattern));
EXPECT_FALSE(
unpack_result->required_explicit_hosts.begin()->valid_schemes() &
URLPattern::SCHEME_FILE);
EXPECT_THAT(
GetPatternsAsStrings(unpack_result->restricted_file_scheme_patterns),
testing::IsEmpty());
}
// With file access, <all_urls> should be parsed and include file:-scheme
// access.
{
URLPattern all_urls(Extension::kValidHostPermissionSchemes,
URLPattern::kAllUrlsPattern);
PermissionSet required_permissions(
APIPermissionSet(), ManifestPermissionSet(), URLPatternSet({all_urls}),
URLPatternSet());
Permissions permissions_object;
permissions_object.origins =
std::vector<std::string>({URLPattern::kAllUrlsPattern});
std::string error;
constexpr bool kHasFileAccess = true;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, required_permissions,
PermissionSet(), kHasFileAccess, &error);
ASSERT_TRUE(unpack_result) << error;
EXPECT_THAT(GetPatternsAsStrings(unpack_result->required_explicit_hosts),
testing::ElementsAre(URLPattern::kAllUrlsPattern));
EXPECT_TRUE(
unpack_result->required_explicit_hosts.begin()->valid_schemes() &
URLPattern::SCHEME_FILE);
EXPECT_THAT(
GetPatternsAsStrings(unpack_result->restricted_file_scheme_patterns),
testing::IsEmpty());
}
}
// Tests that unpacking a pattern that explicitly specifies the file:-scheme is
// properly placed into the |restricted_file_scheme_patterns| set.
TEST(PermissionsApiHelpersTest, Unpack_FileSchemes_Specific) {
constexpr char kFilePattern[] = "file:///*";
// Without file access, the file:-scheme pattern should be populated into
// |restricted_file_scheme_patterns|.
{
URLPattern file_pattern(Extension::kValidHostPermissionSchemes,
kFilePattern);
PermissionSet required_permissions(
APIPermissionSet(), ManifestPermissionSet(),
URLPatternSet({file_pattern}), URLPatternSet());
Permissions permissions_object;
permissions_object.origins = std::vector<std::string>({kFilePattern});
std::string error;
constexpr bool kHasFileAccess = false;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, required_permissions,
PermissionSet(), kHasFileAccess, &error);
ASSERT_TRUE(unpack_result) << error;
EXPECT_THAT(GetPatternsAsStrings(unpack_result->required_explicit_hosts),
testing::IsEmpty());
EXPECT_THAT(
GetPatternsAsStrings(unpack_result->restricted_file_scheme_patterns),
testing::ElementsAre(kFilePattern));
EXPECT_TRUE(unpack_result->restricted_file_scheme_patterns.begin()
->valid_schemes() &
URLPattern::SCHEME_FILE);
}
// With file access, the file:-scheme pattern should be populated into
// |required_explicit_hosts| (since it's not restricted).
{
URLPattern file_pattern(Extension::kValidHostPermissionSchemes,
kFilePattern);
PermissionSet required_permissions(
APIPermissionSet(), ManifestPermissionSet(),
URLPatternSet({file_pattern}), URLPatternSet());
Permissions permissions_object;
permissions_object.origins = std::vector<std::string>({kFilePattern});
std::string error;
constexpr bool kHasFileAccess = true;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, required_permissions,
PermissionSet(), kHasFileAccess, &error);
ASSERT_TRUE(unpack_result) << error;
EXPECT_THAT(GetPatternsAsStrings(unpack_result->required_explicit_hosts),
testing::ElementsAre(kFilePattern));
EXPECT_TRUE(
unpack_result->required_explicit_hosts.begin()->valid_schemes() &
URLPattern::SCHEME_FILE);
EXPECT_THAT(
GetPatternsAsStrings(unpack_result->restricted_file_scheme_patterns),
testing::IsEmpty());
}
}
// Tests that unpacking a UsbDevicePermission with a list of USB device IDs
// preserves the device list in the result object.
TEST(PermissionsApiHelpersTest, Unpack_UsbDevicePermission) {
constexpr char kDeviceListJson[] = R"([{"productId":2,"vendorId":1}])";
constexpr char kUsbDevicesPermissionJson[] =
R"(usbDevices|[{"productId":2,"vendorId":1}])";
auto device_list = base::JSONReader::Read(kDeviceListJson);
ASSERT_TRUE(device_list) << "Failed to parse device list JSON.";
auto usb_device_permission = std::make_unique<UsbDevicePermission>(
PermissionsInfo::GetInstance()->GetByID(
mojom::APIPermissionID::kUsbDevice));
std::string error;
std::vector<std::string> unhandled_permissions;
bool from_value_result = usb_device_permission->FromValue(
&device_list.value(), &error, &unhandled_permissions);
ASSERT_TRUE(from_value_result);
EXPECT_TRUE(unhandled_permissions.empty());
APIPermissionSet api_permission_set;
api_permission_set.insert(usb_device_permission->Clone());
PermissionSet optional_permissions(std::move(api_permission_set),
ManifestPermissionSet(), URLPatternSet(),
URLPatternSet());
Permissions permissions_object;
permissions_object.permissions =
std::vector<std::string>({kUsbDevicesPermissionJson});
constexpr bool kHasFileAccess = false;
std::unique_ptr<UnpackPermissionSetResult> unpack_result =
UnpackPermissionSet(permissions_object, PermissionSet(),
optional_permissions, kHasFileAccess, &error);
ASSERT_TRUE(unpack_result) << error;
ASSERT_EQ(1U, unpack_result->optional_apis.size());
EXPECT_EQ(mojom::APIPermissionID::kUsbDevice,
unpack_result->optional_apis.begin()->id());
EXPECT_TRUE(unpack_result->optional_apis.begin()->Contains(
usb_device_permission.get()));
}
} // namespace extensions
|