1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/permissions/site_permissions_helper.h"
#include <memory>
#include <vector>
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/extensions/extension_action_runner.h"
#include "chrome/browser/extensions/extension_service_test_with_install.h"
#include "chrome/browser/extensions/permissions/permissions_updater.h"
#include "chrome/browser/extensions/permissions/scripting_permissions_modifier.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "components/crx_file/id_util.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/web_contents_tester.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/permissions_manager.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/test/permissions_manager_waiter.h"
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions {
using UserSiteAccess = PermissionsManager::UserSiteAccess;
using SiteInteraction = SitePermissionsHelper::SiteInteraction;
class SitePermissionsHelperUnitTest : public ExtensionServiceTestWithInstall {
public:
scoped_refptr<const Extension> InstallExtension(const std::string& name);
scoped_refptr<const Extension> InstallExtensionWithPermissions(
const std::string& name,
const std::vector<std::string>& host_permissions,
const std::vector<std::string>& permissions = {});
// Adds a new tab with `url` to the simulated tab strip, and returns the
// WebContents associated with it.
content::WebContents* AddTab(const GURL& url);
SitePermissionsHelper* permissions_helper() {
return permissions_helper_.get();
}
PermissionsManager* permissions_manager() { return permissions_manager_; }
// ExtensionServiceTestBase:
void SetUp() override;
void TearDown() override;
private:
// A simulated tab strip that just owns WebContents.
std::vector<std::unique_ptr<content::WebContents>> tabs_;
// Site permissions helper being tested.
std::unique_ptr<SitePermissionsHelper> permissions_helper_;
raw_ptr<PermissionsManager> permissions_manager_;
};
scoped_refptr<const Extension> SitePermissionsHelperUnitTest::InstallExtension(
const std::string& name) {
return InstallExtensionWithPermissions(name, {}, {});
}
scoped_refptr<const Extension>
SitePermissionsHelperUnitTest::InstallExtensionWithPermissions(
const std::string& name,
const std::vector<std::string>& host_permissions,
const std::vector<std::string>& permissions) {
auto extension = ExtensionBuilder(name)
.SetManifestVersion(3)
.AddHostPermissions(host_permissions)
.AddAPIPermissions(permissions)
.SetID(crx_file::id_util::GenerateId(name))
.Build();
registrar()->AddExtension(extension);
return extension;
}
content::WebContents* SitePermissionsHelperUnitTest::AddTab(const GURL& url) {
std::unique_ptr<content::WebContents> web_contents(
content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
content::WebContents* raw_contents = web_contents.get();
TabHelper::CreateForWebContents(raw_contents);
tabs_.push_back(std::move(web_contents));
content::NavigationSimulator::NavigateAndCommitFromBrowser(raw_contents, url);
EXPECT_EQ(url, raw_contents->GetLastCommittedURL());
return raw_contents;
}
void SitePermissionsHelperUnitTest::SetUp() {
ExtensionServiceTestBase::SetUp();
InitializeEmptyExtensionService();
permissions_helper_ = std::make_unique<SitePermissionsHelper>(profile());
permissions_manager_ = PermissionsManager::Get(profile());
}
void SitePermissionsHelperUnitTest::TearDown() {
// Delete the WebContents in the simulated tab strip.
tabs_.clear();
permissions_manager_ = nullptr;
permissions_helper_.reset();
ExtensionServiceTestBase::TearDown();
}
// TODO(crbug.com/40817514): Move test that verify SiteAccess and
// SiteInteraction behavior after moving both enums to PermissionsManager.
TEST_F(SitePermissionsHelperUnitTest, SiteAccessAndInteraction_AllUrls) {
auto extension =
InstallExtensionWithPermissions("AllUrls Extension", {"<all_urls>"});
{
// Verify a non-restricted url has "on all sites" site access and "granted"
// site interaction when the extension has all urls permission.
const GURL non_restricted_url("http://www.non-restricted-url.com");
auto* web_contents = AddTab(non_restricted_url);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(*extension,
non_restricted_url),
UserSiteAccess::kOnAllSites);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kGranted);
}
{
// Verify a restricted url has "none" site interaction even when the
// extension has all urls permission
const GURL restricted_url("chrome://extensions");
auto* web_contents = AddTab(restricted_url);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kNone);
}
}
TEST_F(SitePermissionsHelperUnitTest, SiteAccessAndInteraction_RequestedUrl) {
const GURL requested_url("http://www.requested.com");
auto extension = InstallExtensionWithPermissions("Requested Extension",
{requested_url.spec()});
{
// Verify a non-restricted url has "on site" site access and "granted" site
// interaction by default when the extension requests it.
auto* web_contents = AddTab(requested_url);
EXPECT_EQ(
permissions_manager()->GetUserSiteAccess(*extension, requested_url),
UserSiteAccess::kOnSite);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kGranted);
}
{
// Verify a non-restricted url has "none" site interaction when the
// extension does not request it.
const GURL non_requested_url("http://www.non-requested.com");
auto* web_contents = AddTab(non_requested_url);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kNone);
}
}
TEST_F(SitePermissionsHelperUnitTest, SiteAccessAndInteraction_ActiveTab) {
auto extension = InstallExtensionWithPermissions(
"ActiveTab Extension",
/*host_permissions=*/{}, /*permissions=*/{"activeTab"});
{
// Verify a non-restricted url has "on click" site access and "active tab"
// site interaction when the extension only has active tab permission.
const GURL non_restricted_url("http://www.non-restricted.com");
auto* web_contents = AddTab(non_restricted_url);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(*extension,
non_restricted_url),
UserSiteAccess::kOnClick);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kActiveTab);
}
{
// Verify a restricted url has "none" site interaction even if the extension
// has active tab permission.
const GURL restricted_url("chrome://extensions");
auto* web_contents = AddTab(restricted_url);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kNone);
}
}
TEST_F(SitePermissionsHelperUnitTest,
SiteAccessAndInteraction_ActiveTabAndRequestedUrl) {
const GURL requested_url("http://www.requested.com");
auto extension = InstallExtensionWithPermissions(
"ActiveTab Extension",
/*host_permissions=*/{requested_url.spec()},
/*permissions=*/{"activeTab"});
{
// Verify a url has "on click" site access and "active tab"
// site interaction when the extension does not request it but has active
// tab permission.
const GURL non_requested_url("http://www.non-requested.com");
auto* web_contents = AddTab(non_requested_url);
EXPECT_EQ(
permissions_manager()->GetUserSiteAccess(*extension, non_requested_url),
UserSiteAccess::kOnClick);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kActiveTab);
}
{
// Verify a url has "on site" site access and "granted" site
// interaction when the extension requests it and has access (default
// behavior). "granted" takes priority over "activeTab" since the extension
// has access to the site.
auto* web_contents = AddTab(requested_url);
EXPECT_EQ(
permissions_manager()->GetUserSiteAccess(*extension, requested_url),
UserSiteAccess::kOnSite);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kGranted);
}
ScriptingPermissionsModifier(profile(), extension.get())
.RemoveAllGrantedHostPermissions();
{
// Verify a url has "on site" site access and "granted" site
// interaction when the extension requests it and its access is withheld.
// "withheld" takes priority over "activeTab" since the extension is
// explicitly requesting access to the site.
auto* web_contents = AddTab(requested_url);
EXPECT_EQ(
permissions_manager()->GetUserSiteAccess(*extension, requested_url),
UserSiteAccess::kOnClick);
EXPECT_EQ(
permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kWithheld);
}
}
TEST_F(SitePermissionsHelperUnitTest,
SiteAccessAndInteraction_NoHostPermissions) {
auto extension = InstallExtension("Requested Extension");
// Verify any url has "none" site interaction when the extension has no host
// permissions.
const GURL url("http://www.example.com");
auto* web_contents = AddTab(url);
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SiteInteraction::kNone);
}
// Tests that updating site access only applies to the specified extensions for
// the current site.
TEST_F(SitePermissionsHelperUnitTest, UpdateSiteAccess_OnlySiteSelected) {
auto extensionA =
InstallExtensionWithPermissions("Extension A", {"*://requested.com/*"});
auto extensionB =
InstallExtensionWithPermissions("Extension b", {"<all_urls>"});
const GURL requested_site("https://requested.com");
const GURL other_site("https://other.com");
// Open a site requested by both extensions.
content::WebContents* site_contents = AddTab(requested_site);
ExtensionActionRunner* action_runner =
ExtensionActionRunner::GetForWebContents(site_contents);
ASSERT_TRUE(action_runner);
action_runner->accept_bubble_for_testing(false);
// Extension A should have 'on site' access for the site it requested and 'on
// click' for a site it didn't request. Extension A should have 'on all sites'
// access for both sites.
// TODO(emiliapaz): Technically, extensionA has 'never' site access. However,
// there is not that option in UserSiteAccess. Thus we default to the 'lower
// tier' access which is 'on click'. Separately, we compute whether the
// extension requested access. Access is granted iff extension requested
// access and user granted it, thus it doesn't matter that user access is
// 'on click' if extension didn't request access; access won't be granted.
// We should consider adding a CHECK in GetUserSiteAccess() so it's only
// called when user can select site access.
EXPECT_EQ(
PermissionsManager::UserSiteAccess::kOnSite,
permissions_manager()->GetUserSiteAccess(*extensionA, requested_site));
EXPECT_EQ(PermissionsManager::UserSiteAccess::kOnClick,
permissions_manager()->GetUserSiteAccess(*extensionA, other_site));
EXPECT_EQ(
PermissionsManager::UserSiteAccess::kOnAllSites,
permissions_manager()->GetUserSiteAccess(*extensionB, requested_site));
EXPECT_EQ(PermissionsManager::UserSiteAccess::kOnAllSites,
permissions_manager()->GetUserSiteAccess(*extensionB, other_site));
// Update extension A site access to be 'on click' for requested.com.
permissions_helper()->UpdateSiteAccess(
*extensionA, site_contents, PermissionsManager::UserSiteAccess::kOnClick);
// Extension A should have 'on click' access for both sites. Extension B
// should still have 'on all sites' for both sites.
EXPECT_EQ(
PermissionsManager::UserSiteAccess::kOnClick,
permissions_manager()->GetUserSiteAccess(*extensionA, requested_site));
EXPECT_EQ(PermissionsManager::UserSiteAccess::kOnClick,
permissions_manager()->GetUserSiteAccess(*extensionA, other_site));
EXPECT_EQ(
PermissionsManager::UserSiteAccess::kOnAllSites,
permissions_manager()->GetUserSiteAccess(*extensionB, requested_site));
EXPECT_EQ(PermissionsManager::UserSiteAccess::kOnAllSites,
permissions_manager()->GetUserSiteAccess(*extensionB, other_site));
// Update extension A and B site access to be 'on site' for requested.com.
permissions_helper()->UpdateSiteAccess(
{extensionA.get(), extensionB.get()}, site_contents,
PermissionsManager::UserSiteAccess::kOnSite);
// Extension A and B should have 'on site' access for requested.com and 'on
// click' access for other.com.
EXPECT_EQ(
PermissionsManager::UserSiteAccess::kOnSite,
permissions_manager()->GetUserSiteAccess(*extensionA, requested_site));
EXPECT_EQ(PermissionsManager::UserSiteAccess::kOnClick,
permissions_manager()->GetUserSiteAccess(*extensionA, other_site));
EXPECT_EQ(
PermissionsManager::UserSiteAccess::kOnSite,
permissions_manager()->GetUserSiteAccess(*extensionB, requested_site));
EXPECT_EQ(PermissionsManager::UserSiteAccess::kOnClick,
permissions_manager()->GetUserSiteAccess(*extensionB, other_site));
}
class SitePermissionsHelperWithUserHostControlsUnitTest
: public SitePermissionsHelperUnitTest {
public:
SitePermissionsHelperWithUserHostControlsUnitTest() {
std::vector<base::test::FeatureRef> enabled_features = {
extensions_features::kExtensionsMenuAccessControl,
extensions_features::kExtensionsMenuAccessControlWithPermittedSites};
std::vector<base::test::FeatureRef> disabled_features;
feature_list_.InitWithFeatures(enabled_features, disabled_features);
}
~SitePermissionsHelperWithUserHostControlsUnitTest() override = default;
private:
base::test::ScopedFeatureList feature_list_;
};
// Tests that setting an extension to on-click retains its access to
// sites the user explicitly marked as ones that all extensions may run on.
TEST_F(SitePermissionsHelperWithUserHostControlsUnitTest,
DowngradingFromAllSitesToOnClickAppliesUserPermittedSites) {
auto extension = InstallExtensionWithPermissions(
"extension", /*host_permissions=*/{"<all_urls>"}, /*permissions=*/{});
const GURL user_permitted_site("https://allowed.example");
const GURL non_user_permitted_site("https://not-allowed.example");
{
// Add a user-permitted site.
PermissionsManagerWaiter waiter(permissions_manager());
permissions_manager()->AddUserPermittedSite(
url::Origin::Create(user_permitted_site));
waiter.WaitForUserPermissionsSettingsChange();
}
auto* user_permitted_contents = AddTab(user_permitted_site);
auto* non_user_permitted_contents = AddTab(non_user_permitted_site);
// Right now, the extension should be allowed to run everywhere (on both
// `user_permitted_site` and `non_user_permitted_site`).
EXPECT_EQ(UserSiteAccess::kOnAllSites,
permissions_manager()->GetUserSiteAccess(*extension,
user_permitted_site));
EXPECT_EQ(SitePermissionsHelper::SiteInteraction::kGranted,
permissions_helper()->GetSiteInteraction(*extension,
user_permitted_contents));
EXPECT_EQ(PermissionsData::PageAccess::kAllowed,
extension->permissions_data()->GetPageAccess(
user_permitted_site, extension_misc::kUnknownTabId, nullptr));
EXPECT_EQ(UserSiteAccess::kOnAllSites,
permissions_manager()->GetUserSiteAccess(*extension,
non_user_permitted_site));
EXPECT_EQ(SitePermissionsHelper::SiteInteraction::kGranted,
permissions_helper()->GetSiteInteraction(
*extension, non_user_permitted_contents));
EXPECT_EQ(
PermissionsData::PageAccess::kAllowed,
extension->permissions_data()->GetPageAccess(
non_user_permitted_site, extension_misc::kUnknownTabId, nullptr));
{
// Switch the extension from on all sites to on-click.
ExtensionActionRunner* action_runner =
ExtensionActionRunner::GetForWebContents(non_user_permitted_contents);
ASSERT_TRUE(action_runner);
// Permissions for the site are still updated even if the tab is not
// reloaded.
action_runner->accept_bubble_for_testing(false);
PermissionsManagerWaiter waiter(permissions_manager());
permissions_helper()->UpdateSiteAccess(
*extension, non_user_permitted_contents, UserSiteAccess::kOnClick);
waiter.WaitForExtensionPermissionsUpdate();
}
// The extension should now be able to run on `user_permitted` site
// automatically, since it's a user-permitted site.
// TODO(crbug.com/40803363): The following check should be in place:
// EXPECT_EQ(UserSiteAccess::kOnSite,
// permissions_manager->GetUserSiteAccess(
// *extension, user_permitted_site));
// However, currently PermissionsManager::GetSiteAccess() (which is used by
// SitePermissionsHelper::GetSiteAccess()) doesn't take user-permitted sites
// into account.
EXPECT_EQ(UserSiteAccess::kOnClick, permissions_manager()->GetUserSiteAccess(
*extension, user_permitted_site));
EXPECT_EQ(SitePermissionsHelper::SiteInteraction::kGranted,
permissions_helper()->GetSiteInteraction(*extension,
user_permitted_contents));
EXPECT_EQ(PermissionsData::PageAccess::kAllowed,
extension->permissions_data()->GetPageAccess(
user_permitted_site, extension_misc::kUnknownTabId, nullptr));
// Non-user-permitted sites should remain withheld.
EXPECT_EQ(UserSiteAccess::kOnClick, permissions_manager()->GetUserSiteAccess(
*extension, non_user_permitted_site));
EXPECT_EQ(SitePermissionsHelper::SiteInteraction::kWithheld,
permissions_helper()->GetSiteInteraction(
*extension, non_user_permitted_contents));
EXPECT_EQ(
PermissionsData::PageAccess::kWithheld,
extension->permissions_data()->GetPageAccess(
non_user_permitted_site, extension_misc::kUnknownTabId, nullptr));
}
} // namespace extensions
|