1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/password_manager/android/credential_leak_controller_android.h"
#include <memory>
#include <string>
#include "base/android/build_info.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "chrome/browser/password_manager/android/mock_password_checkup_launcher_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/password_manager/core/browser/features/password_features.h"
#include "components/password_manager/core/browser/leak_detection_dialog_utils.h"
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/ukm/test_ukm_recorder.h"
#include "content/public/test/browser_task_environment.h"
#include "services/metrics/public/cpp/ukm_builders.h"
#include "services/metrics/public/cpp/ukm_source_id.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
constexpr ukm::SourceId kTestSourceId = 0x1234;
using password_manager::CreateLeakType;
using password_manager::IsReused;
using password_manager::IsSaved;
using password_manager::IsSyncing;
using password_manager::metrics_util::LeakDialogDismissalReason;
using password_manager::metrics_util::LeakDialogMetricsRecorder;
using password_manager::metrics_util::LeakDialogType;
using testing::_;
using testing::StrictMock;
using UkmEntry = ukm::builders::PasswordManager_LeakWarningDialog;
namespace {
constexpr char kOrigin[] = "https://example.com";
constexpr char16_t kUsername[] = u"test_username";
constexpr char kTestAccount[] = "test@gmail.com";
// The On*Dialog() methods used by the tests below all invoke `delete this;`,
// thus there is no memory leak here.
CredentialLeakControllerAndroid* MakeController(
Profile* profile,
std::unique_ptr<MockPasswordCheckupLauncherHelper> check_launcher,
IsSaved is_saved,
IsReused is_reused,
IsSyncing is_syncing,
std::string account_email) {
password_manager::CredentialLeakType leak_type =
CreateLeakType(is_saved, is_reused, is_syncing);
auto recorder = std::make_unique<LeakDialogMetricsRecorder>(
kTestSourceId, password_manager::GetLeakDialogType(leak_type));
// Set sampling rate to 100% to avoid flakiness.
recorder->SetSamplingRateForTesting(1.0);
return new CredentialLeakControllerAndroid(
leak_type, GURL(kOrigin), kUsername, profile,
/*window_android=*/nullptr, std::move(check_launcher),
std::move(recorder), account_email);
}
void CheckUkmMetricsExpectations(
ukm::TestAutoSetUkmRecorder& recorder,
LeakDialogType expected_dialog_type,
LeakDialogDismissalReason expected_dismissal_reason) {
const auto& entries = recorder.GetEntriesByName(UkmEntry::kEntryName);
EXPECT_EQ(1u, entries.size());
for (const ukm::mojom::UkmEntry* entry : entries) {
EXPECT_EQ(kTestSourceId, entry->source_id);
recorder.ExpectEntryMetric(entry,
UkmEntry::kPasswordLeakDetectionDialogTypeName,
static_cast<int64_t>(expected_dialog_type));
recorder.ExpectEntryMetric(
entry, UkmEntry::kPasswordLeakDetectionDialogDismissalReasonName,
static_cast<int64_t>(expected_dismissal_reason));
}
}
} // namespace
class CredentialLeakControllerAndroidTest : public testing::Test {
public:
TestingProfile* profile() { return testing_profile_.get(); }
private:
content::BrowserTaskEnvironment task_environment_;
std::unique_ptr<TestingProfile> testing_profile_ =
TestingProfile::Builder().Build();
};
TEST_F(CredentialLeakControllerAndroidTest, ClickedCancel) {
if (base::android::BuildInfo::GetInstance()->is_automotive()) {
GTEST_SKIP() << "This test should not run on automotive.";
}
base::HistogramTester histogram_tester;
ukm::TestAutoSetUkmRecorder test_ukm_recorder;
MakeController(profile(),
std::make_unique<MockPasswordCheckupLauncherHelper>(),
IsSaved(false), IsReused(true), IsSyncing(true), kTestAccount)
->OnCancelDialog();
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedClose, 1);
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.CheckupAndChange",
LeakDialogDismissalReason::kClickedClose, 1);
CheckUkmMetricsExpectations(test_ukm_recorder,
LeakDialogType::kCheckupAndChange,
LeakDialogDismissalReason::kClickedClose);
}
TEST_F(CredentialLeakControllerAndroidTest, ClickedOkDoesNotLaunchCheckup) {
base::HistogramTester histogram_tester;
ukm::TestAutoSetUkmRecorder test_ukm_recorder;
std::unique_ptr<StrictMock<MockPasswordCheckupLauncherHelper>> mock_launcher =
std::make_unique<StrictMock<MockPasswordCheckupLauncherHelper>>();
MakeController(profile(), std::move(mock_launcher), IsSaved(false),
IsReused(false), IsSyncing(false), /* account_email = */ "")
->OnAcceptDialog();
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedOk, 1);
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Change",
LeakDialogDismissalReason::kClickedOk, 1);
CheckUkmMetricsExpectations(test_ukm_recorder, LeakDialogType::kChange,
LeakDialogDismissalReason::kClickedOk);
}
TEST_F(CredentialLeakControllerAndroidTest,
ClickedCheckPasswordsLaunchesCheckup) {
if (base::android::BuildInfo::GetInstance()->is_automotive()) {
GTEST_SKIP() << "This test should not run on automotive.";
}
base::HistogramTester histogram_tester;
ukm::TestAutoSetUkmRecorder test_ukm_recorder;
std::unique_ptr<MockPasswordCheckupLauncherHelper> mock_launcher =
std::make_unique<MockPasswordCheckupLauncherHelper>();
EXPECT_CALL(*mock_launcher,
LaunchCheckupOnDevice(
_, profile(), _,
password_manager::PasswordCheckReferrerAndroid::kLeakDialog,
testing::Eq(kTestAccount)));
MakeController(profile(), std::move(mock_launcher), IsSaved(true),
IsReused(true), IsSyncing(true), kTestAccount)
->OnAcceptDialog();
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedCheckPasswords, 1);
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Checkup",
LeakDialogDismissalReason::kClickedCheckPasswords, 1);
CheckUkmMetricsExpectations(
test_ukm_recorder, LeakDialogType::kCheckup,
LeakDialogDismissalReason::kClickedCheckPasswords);
}
TEST_F(CredentialLeakControllerAndroidTest,
AutomotiveShowsOkButtonForSavedReusedSynced) {
if (!base::android::BuildInfo::GetInstance()->is_automotive()) {
GTEST_SKIP() << "This test should only run on automotive.";
}
base::HistogramTester histogram_tester;
ukm::TestAutoSetUkmRecorder test_ukm_recorder;
std::unique_ptr<MockPasswordCheckupLauncherHelper> mock_launcher =
std::make_unique<MockPasswordCheckupLauncherHelper>();
EXPECT_CALL(*mock_launcher,
LaunchCheckupOnDevice(
_, profile(), _,
password_manager::PasswordCheckReferrerAndroid::kLeakDialog,
testing::Eq(kTestAccount)))
.Times(0);
MakeController(profile(), std::move(mock_launcher), IsSaved(true),
IsReused(true), IsSyncing(true), kTestAccount)
->OnAcceptDialog();
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kClickedOk, 1);
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Change",
LeakDialogDismissalReason::kClickedOk, 1);
CheckUkmMetricsExpectations(test_ukm_recorder, LeakDialogType::kChange,
LeakDialogDismissalReason::kClickedOk);
}
TEST_F(CredentialLeakControllerAndroidTest, NoDirectInteraction) {
base::HistogramTester histogram_tester;
ukm::TestAutoSetUkmRecorder test_ukm_recorder;
MakeController(profile(),
std::make_unique<MockPasswordCheckupLauncherHelper>(),
IsSaved(false), IsReused(false), IsSyncing(false),
/* account_email_ = */ "")
->OnCloseDialog();
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason",
LeakDialogDismissalReason::kNoDirectInteraction, 1);
histogram_tester.ExpectUniqueSample(
"PasswordManager.LeakDetection.DialogDismissalReason.Change",
LeakDialogDismissalReason::kNoDirectInteraction, 1);
CheckUkmMetricsExpectations(test_ukm_recorder, LeakDialogType::kChange,
LeakDialogDismissalReason::kNoDirectInteraction);
}
// The following tests are specific to the login DB deprecation.
TEST_F(CredentialLeakControllerAndroidTest,
LeakTypeResetToChangeIfLoginDbDeprecationNotReady) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
password_manager::features::kLoginDbDeprecationAndroid);
// The export state is only valid for users who are not enrolled in UPM.
profile()->GetPrefs()->SetInteger(
password_manager::prefs::kPasswordsUseUPMLocalAndSeparateStores,
static_cast<int>(
password_manager::prefs::UseUpmLocalAndSeparateStoresState::kOff));
profile()->GetPrefs()->SetBoolean(
password_manager::prefs::kUpmUnmigratedPasswordsExported, false);
std::unique_ptr<MockPasswordCheckupLauncherHelper> mock_launcher =
std::make_unique<MockPasswordCheckupLauncherHelper>();
MockPasswordCheckupLauncherHelper* weak_mock_launcher = mock_launcher.get();
// Setting `isReused` to true will normally cause the leak type to be
// `kCheckup`.
CredentialLeakControllerAndroid* controller =
MakeController(profile(), std::move(mock_launcher), IsSaved(false),
IsReused(true), IsSyncing(false),
/* account_email_ = */ "");
// Expect that despite the original leak being of type `kCheckup` the positive
// button is not the "Check" one.
EXPECT_CALL(
*weak_mock_launcher,
LaunchCheckupOnDevice(
_, profile(), _,
password_manager::PasswordCheckReferrerAndroid::kLeakDialog, _))
.Times(0);
controller->OnAcceptDialog();
}
TEST_F(CredentialLeakControllerAndroidTest,
LeakTypeNotResetIfPasswordsExported) {
if (base::android::BuildInfo::GetInstance()->is_automotive()) {
// Automotive only uses the base leak type and doesn't display the
// "Check passwords" button.
GTEST_SKIP() << "This test should not run on automotive.";
}
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
password_manager::features::kLoginDbDeprecationAndroid);
// The export state is only valid for users who are not enrolled in UPM.
profile()->GetPrefs()->SetInteger(
password_manager::prefs::kPasswordsUseUPMLocalAndSeparateStores,
static_cast<int>(
password_manager::prefs::UseUpmLocalAndSeparateStoresState::kOff));
profile()->GetPrefs()->SetBoolean(
password_manager::prefs::kUpmUnmigratedPasswordsExported, true);
std::unique_ptr<MockPasswordCheckupLauncherHelper> mock_launcher =
std::make_unique<MockPasswordCheckupLauncherHelper>();
MockPasswordCheckupLauncherHelper* weak_mock_launcher = mock_launcher.get();
// Setting `isReused` to true will normally cause the leak type to be
// `kCheckup`.
CredentialLeakControllerAndroid* controller =
MakeController(profile(), std::move(mock_launcher), IsSaved(false),
IsReused(true), IsSyncing(false),
/* account_email_ = */ "");
// Expect that despite the original leak being of type `kCheckup` the positive
// button is not the "Check" one.
EXPECT_CALL(
*weak_mock_launcher,
LaunchCheckupOnDevice(
_, profile(), _,
password_manager::PasswordCheckReferrerAndroid::kLeakDialog, _))
.Times(1);
controller->OnAcceptDialog();
}
TEST_F(CredentialLeakControllerAndroidTest,
LeakTypeNotResetIfUPMAlreadyActive) {
if (base::android::BuildInfo::GetInstance()->is_automotive()) {
// Automotive only uses the base leak type and doesn't display the
// "Check passwords" button.
GTEST_SKIP() << "This test should not run on automotive.";
}
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
password_manager::features::kLoginDbDeprecationAndroid);
profile()->GetPrefs()->SetInteger(
password_manager::prefs::kPasswordsUseUPMLocalAndSeparateStores,
static_cast<int>(
password_manager::prefs::UseUpmLocalAndSeparateStoresState::kOn));
profile()->GetPrefs()->SetBoolean(
password_manager::prefs::kUpmUnmigratedPasswordsExported, false);
std::unique_ptr<MockPasswordCheckupLauncherHelper> mock_launcher =
std::make_unique<MockPasswordCheckupLauncherHelper>();
MockPasswordCheckupLauncherHelper* weak_mock_launcher = mock_launcher.get();
// Setting `isReused` to true will cause the leak type to be `kCheckup`.
CredentialLeakControllerAndroid* controller =
MakeController(profile(), std::move(mock_launcher), IsSaved(false),
IsReused(true), IsSyncing(false),
/* account_email_ = */ "");
// Check that the checkup option is presented to the user if UPM is active.
EXPECT_CALL(
*weak_mock_launcher,
LaunchCheckupOnDevice(
_, profile(), _,
password_manager::PasswordCheckReferrerAndroid::kLeakDialog, _))
.Times(1);
controller->OnAcceptDialog();
}
|
