1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/performance_manager/policies/background_tab_loading_policy.h"
#include <map>
#include <memory>
#include <optional>
#include <utility>
#include <vector>
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/to_string.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/performance_manager/mechanisms/page_loader.h"
#include "components/performance_manager/graph/graph_impl.h"
#include "components/performance_manager/graph/page_node_impl.h"
#include "components/performance_manager/public/features.h"
#include "components/performance_manager/public/persistence/site_data/site_data_reader.h"
#include "components/performance_manager/test_support/graph_test_harness.h"
#include "components/performance_manager/test_support/persistence/test_site_data_reader.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/mojom/permissions/permission_status.mojom.h"
#include "url/gurl.h"
namespace performance_manager {
namespace policies {
using PageNodeData = BackgroundTabLoadingPolicy::PageNodeData;
namespace {
// Mock version of a performance_manager::mechanism::PageLoader.
class LenientMockPageLoader
: public performance_manager::mechanism::PageLoader {
public:
LenientMockPageLoader() = default;
~LenientMockPageLoader() override = default;
LenientMockPageLoader(const LenientMockPageLoader& other) = delete;
LenientMockPageLoader& operator=(const LenientMockPageLoader&) = delete;
MOCK_METHOD1(LoadPageNode, void(const PageNode* page_node));
};
using MockPageLoader = ::testing::StrictMock<LenientMockPageLoader>;
class MockBackgroundTabLoadingPolicy : public BackgroundTabLoadingPolicy {
public:
explicit MockBackgroundTabLoadingPolicy(
base::RepeatingClosure all_tabs_loaded_callback)
: BackgroundTabLoadingPolicy(std::move(all_tabs_loaded_callback)) {}
void SetSiteDataReaderForPageNode(const PageNode* page_node,
SiteDataReader* site_data_reader) {
site_data_readers_[page_node] = site_data_reader;
}
private:
SiteDataReader* GetSiteDataReader(const PageNode* page_node) const override {
auto it = site_data_readers_.find(page_node);
if (it == site_data_readers_.end())
return nullptr;
return it->second;
}
std::map<const PageNode*, raw_ptr<SiteDataReader, CtnExperimental>>
site_data_readers_;
};
static constexpr size_t kMinSiteEngagement = 5;
} // namespace
class BackgroundTabLoadingPolicyTest : public GraphTestHarness {
public:
using Super = GraphTestHarness;
BackgroundTabLoadingPolicyTest() = default;
~BackgroundTabLoadingPolicyTest() override = default;
BackgroundTabLoadingPolicyTest(const BackgroundTabLoadingPolicyTest& other) =
delete;
BackgroundTabLoadingPolicyTest& operator=(
const BackgroundTabLoadingPolicyTest&) = delete;
void SetUp() override {
Super::SetUp();
system_node_ = std::make_unique<TestNodeWrapper<SystemNodeImpl>>(
TestNodeWrapper<SystemNodeImpl>::Create(graph()));
// Create the policy.
auto policy =
std::make_unique<MockBackgroundTabLoadingPolicy>(base::BindRepeating(
&BackgroundTabLoadingPolicyTest::AllTabsLoadedCallback,
base::Unretained(this)));
policy_ = policy.get();
graph()->PassToGraph(std::move(policy));
// Make the policy use a mock PageLoader.
auto mock_loader = std::make_unique<MockPageLoader>();
mock_loader_ = mock_loader.get();
policy_->SetMockLoaderForTesting(std::move(mock_loader));
// Set a value explicitly for thresholds that depends on system information.
policy_->SetMaxSimultaneousLoadsForTesting(4);
policy_->SetFreeMemoryForTesting(150);
}
void TearDown() override {
graph()->TakeFromGraph(policy_);
system_node_->reset();
Super::TearDown();
}
int num_all_tabs_loaded_calls() const { return num_all_tabs_loaded_calls_; }
void AllTabsLoadedCallback() { ++num_all_tabs_loaded_calls_; }
protected:
using PageNodeToLoadData = BackgroundTabLoadingPolicy::PageNodeToLoadData;
PageNodeToLoadData CreatePageNodeToLoadData(
const PageNode* page_node,
bool updates_title_or_favicon_in_bg = false,
std::optional<size_t> site_engagement = std::nullopt) {
PageNodeToLoadData data(page_node, site_engagement);
data.updates_title_or_favicon_in_bg = updates_title_or_favicon_in_bg;
return data;
}
MockBackgroundTabLoadingPolicy* policy() { return policy_; }
MockPageLoader* loader() { return mock_loader_; }
SystemNodeImpl* system_node() { return system_node_.get()->get(); }
private:
std::unique_ptr<
performance_manager::TestNodeWrapper<performance_manager::SystemNodeImpl>>
system_node_;
raw_ptr<MockBackgroundTabLoadingPolicy, DanglingUntriaged> policy_;
raw_ptr<MockPageLoader, DanglingUntriaged> mock_loader_;
int num_all_tabs_loaded_calls_ = 0;
};
TEST_F(BackgroundTabLoadingPolicyTest,
ScheduleLoadForRestoredTabsWithoutNotificationPermission) {
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeData> to_load;
// Create vector of PageNode to restore.
for (int i = 0; i < 4; i++) {
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>());
to_load.emplace_back(page_nodes.back().get()->GetWeakPtr());
EXPECT_CALL(*loader(), LoadPageNode(to_load.back().page_node.get()));
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_nodes.back()->SetType(PageType::kTab);
}
EXPECT_EQ(0, num_all_tabs_loaded_calls());
policy()->ScheduleLoadForRestoredTabs(to_load);
EXPECT_EQ(0, num_all_tabs_loaded_calls());
for (auto& page_node : page_nodes) {
EXPECT_EQ(0, num_all_tabs_loaded_calls());
page_node->SetLoadingState(PageNode::LoadingState::kLoading);
page_node->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
}
EXPECT_EQ(1, num_all_tabs_loaded_calls());
}
TEST_F(BackgroundTabLoadingPolicyTest,
ScheduleLoadForRestoredTabsWithNotificationPermission) {
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeData> to_load;
// Create vector of PageNode to restore.
for (int i = 0; i < 4; i++) {
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>());
to_load.emplace_back(page_nodes.back().get()->GetWeakPtr(), GURL(),
blink::mojom::PermissionStatus::GRANTED);
EXPECT_CALL(*loader(), LoadPageNode(to_load.back().page_node.get()));
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_nodes.back()->SetType(PageType::kTab);
}
EXPECT_EQ(0, num_all_tabs_loaded_calls());
policy()->ScheduleLoadForRestoredTabs(to_load);
EXPECT_EQ(0, num_all_tabs_loaded_calls());
for (auto& page_node : page_nodes) {
EXPECT_EQ(0, num_all_tabs_loaded_calls());
page_node->SetLoadingState(PageNode::LoadingState::kLoading);
page_node->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
}
EXPECT_EQ(1, num_all_tabs_loaded_calls());
}
TEST_F(BackgroundTabLoadingPolicyTest, AllLoadingSlotsUsed) {
// Create 4 PageNode to restore.
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeData> to_load;
// Create vector of PageNode to restore.
for (int i = 0; i < 4; i++) {
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>());
to_load.emplace_back(page_nodes.back().get()->GetWeakPtr());
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_nodes.back()->SetType(PageType::kTab);
}
EXPECT_CALL(*loader(), LoadPageNode(to_load[0].page_node.get()));
EXPECT_CALL(*loader(), LoadPageNode(to_load[1].page_node.get()));
// Use 2 loading slots, which means only 2 of the PageNodes should immediately
// be scheduled to load.
policy()->SetMaxSimultaneousLoadsForTesting(2);
policy()->ScheduleLoadForRestoredTabs(to_load);
task_env().RunUntilIdle();
::testing::Mock::VerifyAndClear(loader());
EXPECT_EQ(0, num_all_tabs_loaded_calls());
// The 3rd page should start loading when the 1st page finishes loading.
page_nodes[0]->SetLoadingState(PageNode::LoadingState::kLoading);
EXPECT_CALL(*loader(), LoadPageNode(to_load[2].page_node.get()));
page_nodes[0]->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
::testing::Mock::VerifyAndClear(loader());
EXPECT_EQ(0, num_all_tabs_loaded_calls());
// The 4th page should start loading when the 2nd page finishes loading.
page_nodes[1]->SetLoadingState(PageNode::LoadingState::kLoading);
EXPECT_CALL(*loader(), LoadPageNode(to_load[3].page_node.get()));
page_nodes[1]->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
::testing::Mock::VerifyAndClear(loader());
EXPECT_EQ(0, num_all_tabs_loaded_calls());
// The "all tabs loaded" callback should be loaded after the 3rd and 4th pages
// finish loading.
page_nodes[2]->SetLoadingState(PageNode::LoadingState::kLoading);
page_nodes[2]->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
page_nodes[3]->SetLoadingState(PageNode::LoadingState::kLoading);
page_nodes[3]->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
EXPECT_EQ(1, num_all_tabs_loaded_calls());
}
// Regression test for crbug.com/1166745
TEST_F(BackgroundTabLoadingPolicyTest, LoadingStateLoadedBusy) {
// Create 1 PageNode to load.
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node(CreateNode<performance_manager::PageNodeImpl>());
std::vector<PageNodeData> to_load{
PageNodeData{page_node.get()->GetWeakPtr()}};
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_node->SetType(PageType::kTab);
EXPECT_CALL(*loader(), LoadPageNode(page_node.get()));
policy()->ScheduleLoadForRestoredTabs(to_load);
task_env().RunUntilIdle();
::testing::Mock::VerifyAndClear(loader());
// Transition to kLoading, to kLoadedBusy, and then back to kLoading. This
// should not crash.
page_node->SetLoadingState(PageNode::LoadingState::kLoading);
page_node->SetLoadingState(PageNode::LoadingState::kLoadedBusy);
page_node->SetLoadingState(PageNode::LoadingState::kLoading);
// Simulate load finish.
page_node->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
}
TEST_F(BackgroundTabLoadingPolicyTest, ShouldLoad_MaxTabsToRestore) {
// Create vector of PageNodes to restore.
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeToLoadData> page_node_datas;
for (uint32_t i = 0; i < policy()->kMaxTabsToLoad + 1; i++) {
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>());
page_node_datas.push_back(
CreatePageNodeToLoadData(page_nodes.back().get()));
}
// Test the maximum number of tabs to load threshold.
for (uint32_t i = 0; i < policy()->kMaxTabsToLoad; i++) {
EXPECT_TRUE(policy()->ShouldLoad(page_node_datas[i]));
policy()->tab_loads_started_++;
}
EXPECT_FALSE(policy()->ShouldLoad(page_node_datas[policy()->kMaxTabsToLoad]));
}
TEST_F(BackgroundTabLoadingPolicyTest, ShouldLoad_MinTabsToRestore) {
// Create vector of PageNodes to restore.
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeToLoadData> page_node_datas;
for (uint32_t i = 0; i < policy()->kMinTabsToLoad + 1; i++) {
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>());
page_node_datas.push_back(
CreatePageNodeToLoadData(page_nodes.back().get()));
}
// When free memory limit is reached.
const size_t kFreeMemoryLimit = policy()->kDesiredAmountOfFreeMemoryMb - 1;
policy()->SetFreeMemoryForTesting(kFreeMemoryLimit);
// Test that the minimum number of tabs to load is respected.
for (uint32_t i = 0; i < policy()->kMinTabsToLoad; i++) {
EXPECT_TRUE(policy()->ShouldLoad(page_node_datas[i]));
policy()->tab_loads_started_++;
}
EXPECT_FALSE(policy()->ShouldLoad(page_node_datas[policy()->kMinTabsToLoad]));
}
TEST_F(BackgroundTabLoadingPolicyTest, ShouldLoad_FreeMemory) {
// Create a PageNode to restore.
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node = CreateNode<performance_manager::PageNodeImpl>();
PageNodeToLoadData page_node_data = CreatePageNodeToLoadData(page_node.get());
// Simulate that kMinTabsToLoad have loaded.
policy()->tab_loads_started_ = policy()->kMinTabsToLoad;
// Test the free memory constraint.
const size_t kFreeMemoryLimit = policy()->kDesiredAmountOfFreeMemoryMb;
policy()->SetFreeMemoryForTesting(kFreeMemoryLimit);
EXPECT_TRUE(policy()->ShouldLoad(page_node_data));
policy()->SetFreeMemoryForTesting(kFreeMemoryLimit - 1);
EXPECT_FALSE(policy()->ShouldLoad(page_node_data));
policy()->SetFreeMemoryForTesting(kFreeMemoryLimit + 1);
EXPECT_TRUE(policy()->ShouldLoad(page_node_data));
}
TEST_F(BackgroundTabLoadingPolicyTest, ShouldLoad_OldTab) {
// Create an old tab.
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node = CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(),
performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() -
(base::Seconds(1) + policy()->kMaxTimeSinceLastUseToLoad));
PageNodeToLoadData page_node_data = CreatePageNodeToLoadData(page_node.get());
// Simulate that kMinTabsToLoad have loaded.
policy()->tab_loads_started_ = policy()->kMinTabsToLoad;
// Test the max time since last use threshold.
EXPECT_FALSE(policy()->ShouldLoad(page_node_data));
}
TEST_F(BackgroundTabLoadingPolicyTest, ShouldLoad_SiteEngagement) {
for (size_t site_engagement : {0, 100}) {
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node = CreateNode<performance_manager::PageNodeImpl>();
PageNodeToLoadData data = CreatePageNodeToLoadData(
page_node.get(), /*updates_title_or_favicon_in_bg=*/false,
site_engagement);
// With the default value of kBackgroundTabLoadingMinSiteEngagement, site
// engagement should always be ignored.
EXPECT_TRUE(policy()->ShouldLoad(data))
<< "site_engagement " << site_engagement;
}
}
// Regression test for https://crrev.com/c/3909768: Deleting a PageNode with the
// notification permission before it starts loading but before it is scored
// should not decrement the number of tabs scored.
TEST_F(BackgroundTabLoadingPolicyTest, RemoveTabWithNotificationPermission) {
testing::SimpleTestSiteDataReader site_data_reader_default(
{.updates_favicon = false, .updates_title = false, .uses_audio = false});
std::vector<PageNodeData> to_load;
// Tab without notification permission.
auto page_node_without_notification_permission =
CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(),
performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Days(1));
policy()->SetSiteDataReaderForPageNode(
page_node_without_notification_permission.get(),
&site_data_reader_default);
page_node_without_notification_permission->SetType(PageType::kTab);
to_load.emplace_back(
page_node_without_notification_permission.get()->GetWeakPtr());
// Tab with notification permission.
auto page_node_with_notification_permission =
CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(),
performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Days(1));
policy()->SetSiteDataReaderForPageNode(
page_node_with_notification_permission.get(), &site_data_reader_default);
page_node_with_notification_permission->SetType(PageType::kTab);
to_load.emplace_back(
page_node_with_notification_permission.get()->GetWeakPtr(), GURL(),
blink::mojom::PermissionStatus::GRANTED);
// Schedule load for restored tabs.
policy()->ScheduleLoadForRestoredTabs(to_load);
// Delete the tab with the notification permission.
page_node_with_notification_permission.reset();
// The tab without the notification permission should be loaded by the policy
// (before https://crrev.com/c/3909768, the number of tabs scored would
// overflow and DCHECKs would fail).
EXPECT_CALL(*loader(),
LoadPageNode(page_node_without_notification_permission.get()));
task_env().RunUntilIdle();
::testing::Mock::VerifyAndClear(loader());
}
TEST_F(BackgroundTabLoadingPolicyTest, ScoreAndScheduleTabLoad) {
// Use 1 loading slot so only one PageNode loads at a time.
policy()->SetMaxSimultaneousLoadsForTesting(1);
testing::SimpleTestSiteDataReader site_data_reader_favicon(
{.updates_favicon = true, .updates_title = false, .uses_audio = false});
testing::SimpleTestSiteDataReader site_data_reader_title(
{.updates_favicon = false, .updates_title = true, .uses_audio = false});
testing::SimpleTestSiteDataReader site_data_reader_audio(
{.updates_favicon = false, .updates_title = false, .uses_audio = true});
testing::SimpleTestSiteDataReader site_data_reader_default(
{.updates_favicon = false, .updates_title = false, .uses_audio = false});
// Create PageNodes with decreasing last visibility time (oldest to newest).
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeData> to_load;
// Add tabs to restore:
// Old
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Days(30)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_default);
const PageNodeData old(page_nodes.back().get()->GetWeakPtr());
to_load.push_back(old);
// Recent
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Seconds(1)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_default);
const PageNodeData recent(page_nodes.back().get()->GetWeakPtr());
to_load.push_back(recent);
// Slightly older tabs which were observed updating their title or favicon or
// playing audio in the background
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Seconds(2)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_title);
const PageNodeData title(page_nodes.back().get()->GetWeakPtr());
to_load.push_back(title);
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Seconds(3)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_favicon);
const PageNodeData favicon(page_nodes.back().get()->GetWeakPtr());
to_load.push_back(favicon);
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Seconds(4)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_audio);
const PageNodeData audio(page_nodes.back().get()->GetWeakPtr());
to_load.push_back(audio);
// Internal page
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Seconds(1)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_default);
const PageNodeData internal(page_nodes.back().get()->GetWeakPtr(),
GURL("chrome://newtab"));
to_load.push_back(internal);
// Page with notification permission
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>(
nullptr, std::string(), GURL(), performance_manager::PagePropertyFlags{},
base::TimeTicks::Now() - base::Seconds(1)));
policy()->SetSiteDataReaderForPageNode(page_nodes.back().get(),
&site_data_reader_default);
const PageNodeData notification(page_nodes.back().get()->GetWeakPtr(), GURL(),
blink::mojom::PermissionStatus::GRANTED);
to_load.push_back(notification);
for (auto& page_node : page_nodes) {
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_node->SetType(PageType::kTab);
}
// Test that tabs are loaded in the expected order:
const std::vector<PageNodeData> expected_load_order{
notification, title, favicon, recent, audio, old, internal};
// 1st tab starts loading when ScheduleLoadForRestoredTabs is invoked.
EXPECT_CALL(*loader(), LoadPageNode(expected_load_order[0].page_node.get()));
policy()->ScheduleLoadForRestoredTabs(to_load);
task_env().RunUntilIdle();
::testing::Mock::VerifyAndClear(loader());
// Other tabs start loading when the previous tab finishes loading.
for (size_t i = 1; i < expected_load_order.size(); ++i) {
PageNodeImpl::FromNode(expected_load_order[i - 1].page_node.get())
->SetLoadingState(PageNode::LoadingState::kLoading);
EXPECT_CALL(*loader(),
LoadPageNode(expected_load_order[i].page_node.get()));
PageNodeImpl::FromNode(expected_load_order[i - 1].page_node.get())
->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
::testing::Mock::VerifyAndClear(loader());
}
}
TEST_F(BackgroundTabLoadingPolicyTest, OnMemoryPressure) {
// Multiple PageNodes are necessary to make sure that the policy
// doesn't immediately kick off loading of all tabs.
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes;
std::vector<PageNodeData> to_load;
for (uint32_t i = 0; i < 2; i++) {
page_nodes.push_back(CreateNode<performance_manager::PageNodeImpl>());
to_load.emplace_back(page_nodes.back().get()->GetWeakPtr());
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_nodes.back()->SetType(PageType::kTab);
}
// Use 1 loading slot so only one PageNode loads at a time.
policy()->SetMaxSimultaneousLoadsForTesting(1);
// Test that the score produces the expected loading order
EXPECT_CALL(*loader(), LoadPageNode(to_load[0].page_node.get()));
policy()->ScheduleLoadForRestoredTabs(to_load);
task_env().RunUntilIdle();
::testing::Mock::VerifyAndClear(loader());
// Simulate memory pressure and expect the tab loader to disable loading.
system_node()->OnMemoryPressureForTesting(
base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE);
PageNodeImpl* page_node_impl = page_nodes[0].get();
// Simulate load start of a PageNode that initiated load.
page_node_impl->SetLoadingState(PageNode::LoadingState::kLoading);
// Simulate load finish of a PageNode and expect the policy to not start
// another load.
page_node_impl->SetLoadingState(PageNode::LoadingState::kLoadedIdle);
}
// Tests that enable the kBackgroundTabLoadingMinSiteEngagement feature param.
class BackgroundTabLoadingPolicySiteEngagementTest
: public BackgroundTabLoadingPolicyTest,
public ::testing::WithParamInterface<std::optional<size_t>> {
public:
BackgroundTabLoadingPolicySiteEngagementTest() {
scoped_feature_list_.InitAndEnableFeatureWithParameters(
features::kBackgroundTabLoadingFromPerformanceManager,
{{"min_site_engagement", base::NumberToString(kMinSiteEngagement)}});
}
protected:
std::optional<size_t> site_engagement_to_test_ = GetParam();
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
INSTANTIATE_TEST_SUITE_P(
All,
BackgroundTabLoadingPolicySiteEngagementTest,
::testing::Values(std::nullopt, // Site engagement should be ignored.
0ul,
kMinSiteEngagement - 1,
kMinSiteEngagement,
kMinSiteEngagement + 1));
TEST_P(BackgroundTabLoadingPolicySiteEngagementTest,
ShouldLoad_NoBackgroundCommunication) {
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node = CreateNode<performance_manager::PageNodeImpl>();
PageNodeToLoadData data = CreatePageNodeToLoadData(
page_node.get(), /*updates_title_or_favicon_in_bg=*/false,
site_engagement_to_test_);
// kMinTabsToLoad should be respected.
policy()->tab_loads_started_ = BackgroundTabLoadingPolicy::kMinTabsToLoad - 1;
EXPECT_TRUE(policy()->ShouldLoad(data));
// Once the minimum tabs are loading, only tabs with high site engagement
// should load.
policy()->tab_loads_started_ = BackgroundTabLoadingPolicy::kMinTabsToLoad;
if (site_engagement_to_test_.has_value()) {
EXPECT_EQ(policy()->ShouldLoad(data),
site_engagement_to_test_.value() >= kMinSiteEngagement);
} else {
EXPECT_TRUE(policy()->ShouldLoad(data));
}
}
TEST_P(BackgroundTabLoadingPolicySiteEngagementTest,
ShouldLoad_NotificationPermission) {
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node = CreateNode<performance_manager::PageNodeImpl>();
page_node->OnNotificationPermissionStatusChange(
blink::mojom::PermissionStatus::GRANTED);
PageNodeToLoadData data = CreatePageNodeToLoadData(
page_node.get(), /*updates_title_or_favicon_in_bg=*/false,
site_engagement_to_test_);
// After the minimum tabs are loading, the notification permission should
// cause tabs with low site engagement to load.
policy()->tab_loads_started_ = BackgroundTabLoadingPolicy::kMinTabsToLoad;
EXPECT_TRUE(policy()->ShouldLoad(data));
}
TEST_P(BackgroundTabLoadingPolicySiteEngagementTest,
ShouldLoad_UpdatesTitleOrFaviconInBackground) {
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>
page_node = CreateNode<performance_manager::PageNodeImpl>();
PageNodeToLoadData data = CreatePageNodeToLoadData(
page_node.get(), /*updates_title_or_favicon_in_bg=*/true,
site_engagement_to_test_);
// After the minimum tabs are loading, the background update should cause
// tabs with low site engagement to load.
policy()->tab_loads_started_ = BackgroundTabLoadingPolicy::kMinTabsToLoad;
EXPECT_TRUE(policy()->ShouldLoad(data));
}
// End-to-end tests that ensure the `site_engagement` score and notification
// permissions are piped through correctly from ScheduleLoadForRestoreTabs.
class BackgroundTabLoadingPolicyScheduleLoadTest
: public BackgroundTabLoadingPolicyTest,
public ::testing::WithParamInterface<bool> {
public:
BackgroundTabLoadingPolicyScheduleLoadTest() {
scoped_feature_list_.InitAndEnableFeatureWithParameters(
features::kBackgroundTabLoadingFromPerformanceManager,
{
{"min_site_engagement", base::NumberToString(kMinSiteEngagement)},
{"restore_main_frame_state",
base::ToString(restore_main_frame_state_)},
});
}
void TearDown() override {
// Destroy all nodes before tearing down the graph.
page_nodes_.clear();
BackgroundTabLoadingPolicyTest::TearDown();
}
// Adds a PageNode to `page_nodes_` and returns a PageNodeData struct for it.
PageNodeData AddPageNode(
GURL main_frame_url = GURL(),
blink::mojom::PermissionStatus notification_permission_status =
blink::mojom::PermissionStatus::ASK) {
auto page_node = CreateNode<performance_manager::PageNodeImpl>();
// Mark the PageNode as a tab as this is a requirement to pass it to
// ScheduleLoadForRestoredTabs().
page_node->SetType(PageType::kTab);
PageNodeData page_node_data(page_node->GetWeakPtr(), main_frame_url,
notification_permission_status);
page_nodes_.push_back(std::move(page_node));
return page_node_data;
}
protected:
bool restore_main_frame_state_ = GetParam();
// PageNodes created and owned by the test.
std::vector<
performance_manager::TestNodeWrapper<performance_manager::PageNodeImpl>>
page_nodes_;
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
INSTANTIATE_TEST_SUITE_P(All,
BackgroundTabLoadingPolicyScheduleLoadTest,
::testing::Bool());
TEST_P(BackgroundTabLoadingPolicyScheduleLoadTest,
ScheduleLoadForRestoredTabs_WithoutNotificationPermission) {
std::vector<PageNodeData> to_load;
// kMinTabsToLoad tabs will always be loaded, regardless of `site_engagement`.
for (size_t i = 0; i < BackgroundTabLoadingPolicy::kMinTabsToLoad; i++) {
auto page_node_data = AddPageNode();
EXPECT_CALL(*loader(), LoadPageNode(page_node_data.page_node.get()));
to_load.push_back(std::move(page_node_data));
}
// Tab with a low `site_engagement` score should not be loaded.
PageNodeData low_engagement_data = AddPageNode();
low_engagement_data.site_engagement = kMinSiteEngagement - 1;
EXPECT_CALL(*loader(), LoadPageNode(low_engagement_data.page_node.get()))
.Times(0);
to_load.push_back(std::move(low_engagement_data));
// Tab with a high `site_engagement` score should be loaded.
PageNodeData high_engagement_data = AddPageNode();
high_engagement_data.site_engagement = kMinSiteEngagement + 1;
EXPECT_CALL(*loader(), LoadPageNode(high_engagement_data.page_node.get()));
to_load.push_back(std::move(high_engagement_data));
// Tab with unknown `site_engagement` should be loaded.
PageNodeData no_engagement_data = AddPageNode();
EXPECT_FALSE(no_engagement_data.site_engagement.has_value());
EXPECT_CALL(*loader(), LoadPageNode(no_engagement_data.page_node.get()));
to_load.push_back(std::move(no_engagement_data));
policy()->SetMaxSimultaneousLoadsForTesting(to_load.size());
policy()->ScheduleLoadForRestoredTabs(to_load);
}
TEST_P(BackgroundTabLoadingPolicyScheduleLoadTest,
ScheduleLoadForRestoredTabs_WithNotificationPermission) {
std::vector<PageNodeData> to_load;
// kMinTabsToLoad tabs will always be loaded, regardless of `site_engagement`.
for (size_t i = 0; i < BackgroundTabLoadingPolicy::kMinTabsToLoad; i++) {
auto page_node_data = AddPageNode();
EXPECT_CALL(*loader(), LoadPageNode(page_node_data.page_node.get()));
to_load.push_back(std::move(page_node_data));
}
// The notification permission allows a tab with a low `site_engagement` score
// to be loaded. It should not be loaded if RestoreMainFrameState wasn't
// called, because the notification permission is lost (bug-for-bug
// compatibility with TabLoader).
PageNodeData low_engagement_data =
AddPageNode(GURL("http://low-engagement.example.com"),
blink::mojom::PermissionStatus::GRANTED);
low_engagement_data.site_engagement = kMinSiteEngagement - 1;
EXPECT_CALL(*loader(), LoadPageNode(low_engagement_data.page_node.get()))
.Times(restore_main_frame_state_ ? 1 : 0);
to_load.push_back(std::move(low_engagement_data));
// Tab with a high `site_engagement` score should be loaded regardless of
// notification permission
PageNodeData high_engagement_data =
AddPageNode(GURL("http://high-engagement.example.com"),
blink::mojom::PermissionStatus::GRANTED);
high_engagement_data.site_engagement = kMinSiteEngagement + 1;
EXPECT_CALL(*loader(), LoadPageNode(high_engagement_data.page_node.get()));
to_load.push_back(std::move(high_engagement_data));
// Tab with unknown `site_engagement` should be loaded regardless of
// notification permission.
PageNodeData no_engagement_data =
AddPageNode(GURL("http://no-engagement.example.com"),
blink::mojom::PermissionStatus::GRANTED);
EXPECT_FALSE(no_engagement_data.site_engagement.has_value());
EXPECT_CALL(*loader(), LoadPageNode(no_engagement_data.page_node.get()));
to_load.push_back(std::move(no_engagement_data));
policy()->SetMaxSimultaneousLoadsForTesting(to_load.size());
policy()->ScheduleLoadForRestoredTabs(to_load);
}
} // namespace policies
} // namespace performance_manager
|