File: PRESUBMIT.py

package info (click to toggle)
chromium 138.0.7204.183-1~deb12u1
  • links: PTS, VCS
  • area: main
  • in suites: bookworm-proposed-updates
  • size: 6,080,960 kB
  • sloc: cpp: 34,937,079; ansic: 7,176,967; javascript: 4,110,704; python: 1,419,954; asm: 946,768; xml: 739,971; pascal: 187,324; sh: 89,623; perl: 88,663; objc: 79,944; sql: 50,304; cs: 41,786; fortran: 24,137; makefile: 21,811; php: 13,980; tcl: 13,166; yacc: 8,925; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (43 lines) | stat: -rw-r--r-- 1,433 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
# Copyright 2023 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import os

def _CheckNoJsChanges(input_api, output_api):
  """Enforce that JavaScript files are not changed.

  During the migration to TypeScript, the closure compiler has been disabled.
  That means any changes in JavaScript will not be run through a type compiler,
  which is not good. Convert to TypeScript before making changes.
  """
  results = []
  for f in input_api.AffectedFiles(False):  # ignores deleted files.
    path = f.LocalPath()
    filename = os.path.basename(path)
    if (
        path.endswith("js")
        and not path.endswith("test.js")
        and path.find("_test") == -1
        and path.find("test_") == -1
        and path.find("common/testing/") == -1
        and not filename[0] == "."
    ):
      results.append(
          output_api.PresubmitError(
              "Illegal file modification: %s\n\nModifying JavaScript files in"
              " the accessibility/ subdirectory is not allowed during the"
              " TypeScript migration. Please migrate this file to TypeScript"
              " before making any changes."
              % f.LocalPath()
          )
      )
  return results


def CheckChangeOnUpload(input_api, output_api):
  return _CheckNoJsChanges(input_api, output_api)


def CheckChangeOnCommit(input_api, output_api):
  return []