1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/ash/boca/chrome_tab_strip_delegate.h"
#include "ash/constants/ash_features.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/test_future.h"
#include "chrome/browser/apps/platform_apps/app_browsertest_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/test/base/ash/util/ash_test_util.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/test_navigation_observer.h"
namespace {
constexpr char kTabUrl1[] = "https://foo/1";
constexpr char kTabUrl2[] = "https://foo/2";
constexpr char kTabUrl3[] = "https://foo/3";
constexpr char kDefaultTitle[] = "foo";
} // namespace
class ChromeTabStripDelegateBrowserTest
: public extensions::PlatformAppBrowserTest {
public:
ChromeTabStripDelegateBrowserTest() = default;
ChromeTabStripDelegateBrowserTest(const ChromeTabStripDelegateBrowserTest&) =
delete;
ChromeTabStripDelegateBrowserTest& operator=(
const ChromeTabStripDelegateBrowserTest&) = delete;
~ChromeTabStripDelegateBrowserTest() override = default;
void SetUp() override {
scoped_feature_list_.InitWithFeatures(
{ash::features::kBoca, ash::features::kBocaConsumer,
ash::features::kOnDeviceSpeechRecognition},
/*disabled_features=*/{});
extensions::PlatformAppBrowserTest::SetUp();
}
// extensions::PlatformAppBrowserTest:
void SetUpOnMainThread() override {
extensions::PlatformAppBrowserTest::SetUpOnMainThread();
delegate_ = std::make_unique<ChromeTabStripDelegate>();
}
Browser* CreateBrowser(const std::vector<GURL>& urls,
std::optional<size_t> active_url_index) {
Browser::CreateParams params(Browser::TYPE_NORMAL, profile(),
/*user_gesture=*/false);
Browser* browser = Browser::Create(params);
// Create a new tab and make sure the urls have loaded.
for (const auto& url : urls) {
// content::TestNavigationObserver navigation_observer(urls[i]);
ui_test_utils::NavigateToURLWithDisposition(
browser, url, WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
}
return browser;
}
ChromeTabStripDelegate* delegate() { return delegate_.get(); }
void ExpectTab(GURL url, std::string title, ash::TabInfo tab) {
// Tab in test setup doesn't include title info.
EXPECT_EQ(base::UTF8ToUTF16(title), tab.title);
EXPECT_EQ(url, tab.url);
EXPECT_GT(tab.last_access_timetick, base::TimeTicks());
EXPECT_GT(tab.id, 0);
}
private:
std::unique_ptr<ChromeTabStripDelegate> delegate_;
base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(ChromeTabStripDelegateBrowserTest, GetTabListForWindow) {
Browser* browser = CreateBrowser({GURL(kTabUrl1), GURL(kTabUrl2)},
/*active_url_index=*/0);
// Add tab in a new browser.
CreateBrowser({GURL(kTabUrl3)}, /*active_url_index=*/1);
auto* aura_window = browser->window()->GetNativeWindow();
base::test::TestFuture<std::vector<ash::TabInfo>> future;
auto tab_list = delegate()->GetTabsListForWindow(aura_window);
ASSERT_EQ(2u, tab_list.size());
ExpectTab(GURL(kTabUrl1), kDefaultTitle, tab_list[0]);
ExpectTab(GURL(kTabUrl2), kDefaultTitle, tab_list[1]);
// Verify last access time reflects the access order.
EXPECT_GT(tab_list[1].last_access_timetick, tab_list[0].last_access_timetick);
}
IN_PROC_BROWSER_TEST_F(ChromeTabStripDelegateBrowserTest,
GetTabListForSWANonEmptyWindow) {
ASSERT_EQ(1u, BrowserList::GetInstance()->size());
// Create browser 1 and navigate to url1 and then url2
CreateBrowser({GURL(kTabUrl1), GURL(kTabUrl2)}, /*active_url_index=*/1);
// Create a SWA
ash::test::InstallSystemAppsForTesting(profile());
ash::test::CreateSystemWebApp(profile(), ash::SystemWebAppType::BOCA);
auto* swa_browser = BrowserList::GetInstance()->get(2);
chrome::AddTabAt(swa_browser, GURL(kTabUrl3), /*index=*/0,
/*foreground=*/false);
EXPECT_EQ(3u, BrowserList::GetInstance()->size());
auto tab_list = delegate()->GetTabsListForWindow(
swa_browser->window()->GetNativeWindow());
// Contains the new tab and webui itself.
ASSERT_EQ(2u, tab_list.size());
// Verify tab is listed in non-ascending order inside window based on last
// access time.
EXPECT_EQ(kTabUrl3, tab_list[1].url);
}
IN_PROC_BROWSER_TEST_F(ChromeTabStripDelegateBrowserTest,
GetTabListForSWAEmptyWindow) {
ash::test::InstallSystemAppsForTesting(profile());
ash::test::CreateSystemWebApp(profile(), ash::SystemWebAppType::BOCA);
auto* swa_browser = BrowserList::GetInstance()->get(1);
auto tab_list = delegate()->GetTabsListForWindow(
swa_browser->window()->GetNativeWindow());
// Contains the webui itself.
EXPECT_EQ(1u, tab_list.size());
}
|
