1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/ash/quick_answers/quick_answers_state_ash.h"
#include "ash/constants/ash_pref_names.h"
#include "ash/session/session_controller_impl.h"
#include "ash/shell.h"
#include "base/memory/raw_ptr.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/ui/ash/quick_answers/test/chrome_quick_answers_test_base.h"
#include "chrome/test/base/testing_profile.h"
#include "chromeos/ash/components/login/login_state/login_state.h"
#include "chromeos/components/kiosk/kiosk_test_utils.h"
#include "chromeos/components/kiosk/kiosk_utils.h"
#include "chromeos/components/quick_answers/public/cpp/constants.h"
#include "chromeos/components/quick_answers/public/cpp/quick_answers_prefs.h"
#include "chromeos/components/quick_answers/public/cpp/quick_answers_state.h"
#include "chromeos/constants/chromeos_features.h"
#include "components/language/core/browser/pref_names.h"
#include "components/prefs/testing_pref_service.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "components/user_manager/fake_user_manager.h"
#include "components/user_manager/scoped_user_manager.h"
#include "third_party/icu/source/common/unicode/locid.h"
namespace {
using quick_answers::prefs::ConsentStatus;
constexpr char kTestUser[] = "user@gmail.com";
} // namespace
class TestQuickAnswersStateObserver : public QuickAnswersStateObserver {
public:
TestQuickAnswersStateObserver() = default;
TestQuickAnswersStateObserver(const TestQuickAnswersStateObserver&) = delete;
TestQuickAnswersStateObserver& operator=(
const TestQuickAnswersStateObserver&) = delete;
~TestQuickAnswersStateObserver() override = default;
// QuickAnswersStateObserver:
void OnSettingsEnabled(bool settings_enabled) override {
settings_enabled_ = settings_enabled;
}
void OnConsentStatusUpdated(ConsentStatus status) override {
consent_status_ = status;
}
void OnApplicationLocaleReady(
const std::string& application_locale) override {
application_locale_ = application_locale;
}
void OnPreferredLanguagesChanged(
const std::string& preferred_languages) override {
preferred_languages_ = preferred_languages;
}
void OnEligibilityChanged(bool eligible) override { is_eligible_ = eligible; }
void OnPrefsInitialized() override { prefs_initialized_ = true; }
bool settings_enabled() const { return settings_enabled_; }
ConsentStatus consent_status() const { return consent_status_; }
const std::string& application_locale() const { return application_locale_; }
const std::string& preferred_languages() const {
return preferred_languages_;
}
bool is_eligible() const { return is_eligible_; }
bool prefs_initialized() const { return prefs_initialized_; }
private:
bool settings_enabled_ = false;
ConsentStatus consent_status_ = ConsentStatus::kUnknown;
std::string application_locale_;
std::string preferred_languages_;
bool is_eligible_ = false;
bool prefs_initialized_ = false;
};
// The bool parameter controls the feature flag QuickAnswers.
class QuickAnswersStateAshTest : public ChromeQuickAnswersTestBase,
public testing::WithParamInterface<bool> {
protected:
QuickAnswersStateAshTest() = default;
QuickAnswersStateAshTest(const QuickAnswersStateAshTest&) = delete;
QuickAnswersStateAshTest& operator=(const QuickAnswersStateAshTest&) = delete;
~QuickAnswersStateAshTest() override = default;
// ChromeQuickAnswersTestBase:
void SetUp() override {
ChromeQuickAnswersTestBase::SetUp();
CHECK(QuickAnswersState::Get()->prefs_initialized());
observer_ = std::make_unique<TestQuickAnswersStateObserver>();
}
void SetUpInitialPrefValues() override {
EXPECT_EQ(
ash::Shell::Get()->session_controller()->GetPrimaryUserPrefService(),
prefs());
prefs()->SetString(language::prefs::kPreferredLanguages, "");
}
sync_preferences::TestingPrefServiceSyncable* prefs() {
return GetProfile()->GetTestingPrefService();
}
TestQuickAnswersStateObserver* observer() { return observer_.get(); }
private:
std::unique_ptr<TestQuickAnswersStateObserver> observer_;
};
class QuickAnswersStateAshEnabledTest : public QuickAnswersStateAshTest {
protected:
void SetUpInitialPrefValues() override {
QuickAnswersStateAshTest::SetUpInitialPrefValues();
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersEnabled, true);
CHECK_EQ(
ConsentStatus::kUnknown,
prefs()->GetInteger(quick_answers::prefs::kQuickAnswersConsentStatus));
}
};
TEST_F(QuickAnswersStateAshTest, InitObserver) {
EXPECT_FALSE(QuickAnswersState::IsEnabled());
EXPECT_EQ(QuickAnswersState::GetConsentStatus(), ConsentStatus::kUnknown);
EXPECT_EQ(QuickAnswersState::Get()->application_locale(), std::string());
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersEnabled, true);
prefs()->SetInteger(quick_answers::prefs::kQuickAnswersConsentStatus,
ConsentStatus::kAccepted);
const std::string application_locale = "en-US";
prefs()->SetString(language::prefs::kApplicationLocale, application_locale);
EXPECT_TRUE(QuickAnswersState::IsEnabled());
EXPECT_EQ(QuickAnswersState::GetConsentStatus(), ConsentStatus::kAccepted);
EXPECT_EQ(QuickAnswersState::Get()->application_locale(), application_locale);
// The observer class should get an instant notification about the current
// pref value.
QuickAnswersState::Get()->AddObserver(observer());
EXPECT_TRUE(observer()->settings_enabled());
EXPECT_EQ(observer()->consent_status(), ConsentStatus::kAccepted);
EXPECT_EQ(observer()->application_locale(), application_locale);
EXPECT_TRUE(observer()->prefs_initialized());
QuickAnswersState::Get()->RemoveObserver(observer());
}
TEST_F(QuickAnswersStateAshTest, NotifySettingsEnabled) {
QuickAnswersState::Get()->AddObserver(observer());
const std::string application_locale = "en-US";
prefs()->SetString(language::prefs::kApplicationLocale, application_locale);
EXPECT_FALSE(QuickAnswersState::IsEnabled());
EXPECT_FALSE(observer()->settings_enabled());
EXPECT_EQ(QuickAnswersState::GetConsentStatus(),
quick_answers::prefs::ConsentStatus::kUnknown);
// The observer class should get an notification when the pref value changes.
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersEnabled, true);
EXPECT_TRUE(QuickAnswersState::IsEnabled());
EXPECT_TRUE(observer()->settings_enabled());
// Consent status should also be set to accepted since the feature is
// explicitly enabled.
EXPECT_EQ(QuickAnswersState::GetConsentStatus(),
quick_answers::prefs::ConsentStatus::kAccepted);
QuickAnswersState::Get()->RemoveObserver(observer());
}
TEST_F(QuickAnswersStateAshTest, UpdateConsentStatus) {
QuickAnswersState::Get()->AddObserver(observer());
EXPECT_EQ(QuickAnswersState::GetConsentStatus(),
quick_answers::prefs::ConsentStatus::kUnknown);
EXPECT_EQ(observer()->consent_status(),
quick_answers::prefs::ConsentStatus::kUnknown);
// The observer class should get an notification when the pref value changes.
prefs()->SetInteger(quick_answers::prefs::kQuickAnswersConsentStatus,
quick_answers::prefs::ConsentStatus::kRejected);
EXPECT_EQ(QuickAnswersState::GetConsentStatus(),
quick_answers::prefs::ConsentStatus::kRejected);
EXPECT_EQ(observer()->consent_status(),
quick_answers::prefs::ConsentStatus::kRejected);
prefs()->SetInteger(quick_answers::prefs::kQuickAnswersConsentStatus,
quick_answers::prefs::ConsentStatus::kAccepted);
EXPECT_EQ(QuickAnswersState::GetConsentStatus(),
quick_answers::prefs::ConsentStatus::kAccepted);
EXPECT_EQ(observer()->consent_status(),
quick_answers::prefs::ConsentStatus::kAccepted);
QuickAnswersState::Get()->RemoveObserver(observer());
}
TEST_F(QuickAnswersStateAshTest, UpdateDefinitionEnabled) {
const std::string application_locale = "en-US";
prefs()->SetString(language::prefs::kApplicationLocale, application_locale);
// Definition subfeature is default on.
EXPECT_TRUE(
QuickAnswersState::IsIntentEligible(quick_answers::Intent::kDefinition));
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersDefinitionEnabled,
false);
EXPECT_FALSE(
QuickAnswersState::IsIntentEligible(quick_answers::Intent::kDefinition));
}
TEST_F(QuickAnswersStateAshTest, UpdateTranslationEnabled) {
const std::string application_locale = "en-US";
prefs()->SetString(language::prefs::kApplicationLocale, application_locale);
// Translation subfeature is default on.
EXPECT_TRUE(
QuickAnswersState::IsIntentEligible(quick_answers::Intent::kTranslation));
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersTranslationEnabled,
false);
EXPECT_FALSE(
QuickAnswersState::IsIntentEligible(quick_answers::Intent::kTranslation));
}
TEST_F(QuickAnswersStateAshTest, UpdateUnitConversionEnabled) {
const std::string application_locale = "en-US";
prefs()->SetString(language::prefs::kApplicationLocale, application_locale);
// Unit conversion subfeature is default on.
EXPECT_TRUE(QuickAnswersState::IsIntentEligible(
quick_answers::Intent::kUnitConversion));
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersUnitConversionEnabled,
false);
EXPECT_FALSE(QuickAnswersState::IsIntentEligible(
quick_answers::Intent::kUnitConversion));
}
TEST_F(QuickAnswersStateAshTest, NotifyApplicationLocaleReady) {
QuickAnswersState::Get()->AddObserver(observer());
EXPECT_TRUE(QuickAnswersState::Get()->application_locale().empty());
EXPECT_TRUE(observer()->application_locale().empty());
const std::string application_locale = "en-US";
// The observer class should get an notification when the pref value changes.
prefs()->SetString(language::prefs::kApplicationLocale, application_locale);
EXPECT_EQ(QuickAnswersState::Get()->application_locale(), application_locale);
EXPECT_EQ(observer()->application_locale(), application_locale);
QuickAnswersState::Get()->RemoveObserver(observer());
}
TEST_F(QuickAnswersStateAshTest, UpdatePreferredLanguages) {
QuickAnswersState::Get()->AddObserver(observer());
EXPECT_TRUE(QuickAnswersState::Get()->preferred_languages().empty());
EXPECT_TRUE(observer()->preferred_languages().empty());
const std::string preferred_languages = "en-US,zh";
prefs()->SetString(language::prefs::kPreferredLanguages, preferred_languages);
EXPECT_EQ(QuickAnswersState::Get()->preferred_languages(),
preferred_languages);
EXPECT_EQ(observer()->preferred_languages(), preferred_languages);
QuickAnswersState::Get()->RemoveObserver(observer());
}
TEST_F(QuickAnswersStateAshTest, UpdateSpokenFeedbackEnabled) {
EXPECT_FALSE(QuickAnswersState::Get()->spoken_feedback_enabled());
prefs()->SetBoolean(ash::prefs::kAccessibilitySpokenFeedbackEnabled, true);
EXPECT_TRUE(QuickAnswersState::Get()->spoken_feedback_enabled());
}
TEST_F(QuickAnswersStateAshTest, EligibleLocales) {
QuickAnswersState::Get()->AddObserver(observer());
EXPECT_FALSE(QuickAnswersState::IsEligible());
EXPECT_FALSE(observer()->is_eligible());
prefs()->SetString(language::prefs::kApplicationLocale, "pt");
SimulateUserLogin({kTestUser});
EXPECT_TRUE(QuickAnswersState::IsEligible());
EXPECT_TRUE(observer()->is_eligible());
ClearLogin();
prefs()->SetString(language::prefs::kApplicationLocale, "en");
SimulateUserLogin({kTestUser});
EXPECT_TRUE(QuickAnswersState::IsEligible());
EXPECT_TRUE(observer()->is_eligible());
}
TEST_F(QuickAnswersStateAshTest, IneligibleLocales) {
QuickAnswersState::Get()->AddObserver(observer());
EXPECT_FALSE(QuickAnswersState::IsEligible());
EXPECT_FALSE(observer()->is_eligible());
prefs()->SetString(language::prefs::kApplicationLocale, "zh");
SimulateUserLogin({kTestUser});
EXPECT_FALSE(QuickAnswersState::IsEligible());
EXPECT_FALSE(observer()->is_eligible());
ClearLogin();
prefs()->SetString(language::prefs::kApplicationLocale, "ja");
SimulateUserLogin({kTestUser});
EXPECT_FALSE(QuickAnswersState::IsEligible());
EXPECT_FALSE(observer()->is_eligible());
}
TEST_F(QuickAnswersStateAshTest, DisabledByPolicy) {
QuickAnswersState::Get()->AddObserver(observer());
ASSERT_FALSE(
prefs()->IsManagedPreference(quick_answers::prefs::kQuickAnswersEnabled));
ASSERT_FALSE(prefs()->GetBoolean(quick_answers::prefs::kQuickAnswersEnabled));
ASSERT_EQ(quick_answers::prefs::ConsentStatus::kUnknown,
observer()->consent_status());
prefs()->SetManagedPref(quick_answers::prefs::kQuickAnswersEnabled,
base::Value(false));
EXPECT_EQ(quick_answers::prefs::ConsentStatus::kRejected,
observer()->consent_status());
EXPECT_FALSE(observer()->settings_enabled());
}
TEST_F(QuickAnswersStateAshTest, EnabledThenDisabledByPolicy) {
QuickAnswersState::Get()->AddObserver(observer());
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersEnabled, true);
ASSERT_FALSE(
prefs()->IsManagedPreference(quick_answers::prefs::kQuickAnswersEnabled));
ASSERT_TRUE(prefs()->GetBoolean(quick_answers::prefs::kQuickAnswersEnabled));
ASSERT_EQ(quick_answers::prefs::ConsentStatus::kAccepted,
observer()->consent_status());
prefs()->SetManagedPref(quick_answers::prefs::kQuickAnswersEnabled,
base::Value(false));
EXPECT_EQ(quick_answers::prefs::ConsentStatus::kRejected,
observer()->consent_status());
EXPECT_FALSE(observer()->settings_enabled());
}
// This is for testing `turned_on` in
// `QuickAnswersStateAsh::UpdateSettingsEnabled`.
TEST_F(QuickAnswersStateAshEnabledTest, EnabledFromBeginning) {
ASSERT_TRUE(prefs()->GetBoolean(quick_answers::prefs::kQuickAnswersEnabled));
EXPECT_EQ(
ConsentStatus::kUnknown,
prefs()->GetInteger(quick_answers::prefs::kQuickAnswersConsentStatus))
<< "If pref value is enabled from beginning, it should not be treated as "
"turned on, i.e., consent status must be un-touched.";
}
class QuickAnswersStateAshKioskTest : public QuickAnswersStateAshTest {
public:
user_manager::User* StartUserSession() override {
// TODO(crbug.com/278643115): Consider to return Session instance by
// chromeos::SetUpFakeKioskSession().
chromeos::SetUpFakeKioskSession();
return user_manager::UserManager::Get()->GetActiveUser();
}
};
TEST_P(QuickAnswersStateAshKioskTest, ForceDisabledForKiosk) {
QuickAnswersState::Get()->AddObserver(observer());
ASSERT_TRUE(chromeos::IsKioskSession());
prefs()->SetBoolean(quick_answers::prefs::kQuickAnswersEnabled, GetParam());
EXPECT_FALSE(
prefs()->IsManagedPreference(quick_answers::prefs::kQuickAnswersEnabled));
EXPECT_EQ(quick_answers::prefs::ConsentStatus::kRejected,
observer()->consent_status());
EXPECT_FALSE(observer()->settings_enabled());
}
INSTANTIATE_TEST_SUITE_P(ForceDisabledForKiosk,
QuickAnswersStateAshKioskTest,
testing::Bool());
|
