File: edit_address_profile_view_unittest.cc

package info (click to toggle)
chromium 138.0.7204.183-1~deb12u1
  • links: PTS, VCS
  • area: main
  • in suites: bookworm-proposed-updates
  • size: 6,080,960 kB
  • sloc: cpp: 34,937,079; ansic: 7,176,967; javascript: 4,110,704; python: 1,419,954; asm: 946,768; xml: 739,971; pascal: 187,324; sh: 89,623; perl: 88,663; objc: 79,944; sql: 50,304; cs: 41,786; fortran: 24,137; makefile: 21,811; php: 13,980; tcl: 13,166; yacc: 8,925; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (257 lines) | stat: -rw-r--r-- 9,946 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/ui/views/autofill/edit_address_profile_view.h"

#include <memory>
#include <utility>

#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/ui/autofill/edit_address_profile_dialog_controller.h"
#include "chrome/browser/ui/views/autofill/address_editor_view.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/views/chrome_views_test_base.h"
#include "components/autofill/core/browser/data_model/addresses/autofill_profile.h"
#include "components/autofill/core/browser/test_utils/autofill_test_utils.h"
#include "components/autofill/core/common/autofill_features.h"
#include "content/public/test/test_renderer_host.h"
#include "content/public/test/web_contents_tester.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/mojom/dialog_button.mojom.h"
#include "ui/views/widget/widget.h"

namespace autofill {

// |arg| must be of type base::optional_ref<const AutofillProfile>.
MATCHER_P2(AutofillProfileHasInfo, type, expected_value, "") {
  EXPECT_TRUE(arg.has_value());
  return arg.value().GetRawInfo(type) == expected_value;
}

class MockEditAddressProfileDialogController
    : public EditAddressProfileDialogController {
 public:
  MOCK_METHOD(std::u16string, GetWindowTitle, (), (const, override));
  MOCK_METHOD(const std::u16string&, GetFooterMessage, (), (const, override));
  MOCK_METHOD(std::u16string, GetOkButtonLabel, (), (const, override));
  MOCK_METHOD(const AutofillProfile&, GetProfileToEdit, (), (const, override));
  MOCK_METHOD(bool, GetIsValidatable, (), (const, override));
  MOCK_METHOD(void,
              OnDialogClosed,
              (AutofillClient::AddressPromptUserDecision decision,
               base::optional_ref<const AutofillProfile> profile),
              (override));
};

class EditAddressProfileViewTest : public ChromeViewsTestBase {
 public:
  EditAddressProfileViewTest() = default;
  ~EditAddressProfileViewTest() override = default;

  void CreateViewAndShow() { CreateViewAndShow(address_profile_to_edit()); }

  void CreateViewAndShow(const AutofillProfile& address_profile);

  void SetUp() override {
    ChromeViewsTestBase::SetUp();

    address_profile_to_edit_ = test::GetFullProfile();
    test_web_contents_ =
        content::WebContentsTester::CreateTestWebContents(&profile_, nullptr);

    ON_CALL(mock_controller_, GetFooterMessage)
        .WillByDefault(::testing::ReturnRefOfCopy(std::u16string()));
  }

  void TearDown() override {
    if (widget_) {
      widget_->Close();
    }
    parent_widget_.reset();
    ChromeViewsTestBase::TearDown();
  }

  void WidgetClosed(views::Widget::ClosedReason closed_reason);

  const AutofillProfile& address_profile_to_edit() {
    return address_profile_to_edit_;
  }
  content::WebContents* test_web_contents() { return test_web_contents_.get(); }
  EditAddressProfileView* dialog() { return dialog_; }
  MockEditAddressProfileDialogController* mock_controller() {
    return &mock_controller_;
  }

 private:
  base::test::ScopedFeatureList feature_list_;
  TestingProfile profile_;
  AutofillProfile address_profile_to_edit_{
      i18n_model_definition::kLegacyHierarchyCountryCode};
  // This enables uses of TestWebContents.
  content::RenderViewHostTestEnabler test_render_host_factories_;
  std::unique_ptr<content::WebContents> test_web_contents_;
  std::unique_ptr<views::Widget> parent_widget_;
  std::unique_ptr<views::Widget> widget_ = nullptr;
  raw_ptr<EditAddressProfileView> dialog_ = nullptr;
  testing::NiceMock<MockEditAddressProfileDialogController> mock_controller_;
};

void EditAddressProfileViewTest::WidgetClosed(
    views::Widget::ClosedReason closed_reason) {
  dialog_->WidgetClosed();
  dialog_ = nullptr;
  std::exchange(widget_, nullptr).reset();
}

void EditAddressProfileViewTest::CreateViewAndShow(
    const AutofillProfile& address_profile) {
  ON_CALL(*mock_controller(), GetWindowTitle())
      .WillByDefault(testing::Return(std::u16string()));
  ON_CALL(*mock_controller(), GetProfileToEdit())
      .WillByDefault(testing::ReturnRef(address_profile));

  dialog_ = new EditAddressProfileView(mock_controller());
  dialog_->ShowForWebContents(test_web_contents());

  gfx::NativeView parent = gfx::NativeView();
#if BUILDFLAG(IS_MAC)
  // We need a native view parent for the dialog to avoid a DCHECK
  // on Mac.
  parent_widget_ =
      CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
  parent = parent_widget_->GetNativeView();
#endif
  widget_ = base::WrapUnique(
      views::DialogDelegate::CreateDialogWidget(dialog_, GetContext(), parent));
  widget_->SetVisibilityChangedAnimationsEnabled(false);
  widget_->MakeCloseSynchronous(base::BindOnce(
      &EditAddressProfileViewTest::WidgetClosed, base::Unretained(this)));
  widget_->Show();
#if BUILDFLAG(IS_MAC)
  // Necessary for Mac. On other platforms this happens in the focus
  // manager, but it's disabled for Mac due to crbug.com/650859.
  parent_widget_->Activate();
  widget_->Activate();
#endif
}

TEST_F(EditAddressProfileViewTest, Sanity) {
  CreateViewAndShow();
  // Check that both OK and cancel button are enabled.
  EXPECT_TRUE(dialog()->IsDialogButtonEnabled(ui::mojom::DialogButton::kOk));
  EXPECT_TRUE(
      dialog()->IsDialogButtonEnabled(ui::mojom::DialogButton::kCancel));
}

TEST_F(EditAddressProfileViewTest, SaveInvokesTheCallbackWithEditedFullname) {
  CreateViewAndShow();
  const std::u16string kNewFirstName = u"New First Name";
  const std::string locale = g_browser_process->GetApplicationLocale();
  // Confirm that the new name is indeed different from the original one from
  // the controller.
  ASSERT_NE(kNewFirstName, address_profile_to_edit().GetInfo(
                               autofill::FieldType::NAME_FULL, locale));
  AddressEditorView* editor_view = dialog()->GetAddressEditorViewForTesting();
  DCHECK(editor_view);

  editor_view->SetTextInputFieldValueForTesting(autofill::FieldType::NAME_FULL,
                                                kNewFirstName);

  EXPECT_CALL(
      *mock_controller(),
      OnDialogClosed(AutofillClient::AddressPromptUserDecision::kEditAccepted,
                     AutofillProfileHasInfo(autofill::FieldType::NAME_FULL,
                                            kNewFirstName)));
  dialog()->Accept();
}

TEST_F(EditAddressProfileViewTest,
       SaveInvokesTheCallbackWithEditedInvalidPhoneNumber) {
  CreateViewAndShow();
  const std::u16string kNewPhoneNumber = u"123456789";
  const std::string locale = g_browser_process->GetApplicationLocale();
  // Confirm that the new phone number is indeed different from the original one
  // from the controller.
  ASSERT_NE(kNewPhoneNumber,
            address_profile_to_edit().GetInfo(
                autofill::FieldType::PHONE_HOME_WHOLE_NUMBER, locale));

  // Set the phone number in the editor to the new invalid value. Make sure that
  // this value is respected and sent to the backend.
  AddressEditorView* editor_view = dialog()->GetAddressEditorViewForTesting();
  DCHECK(editor_view);

  editor_view->SetTextInputFieldValueForTesting(
      autofill::FieldType::PHONE_HOME_WHOLE_NUMBER, kNewPhoneNumber);

  EXPECT_CALL(
      *mock_controller(),
      OnDialogClosed(
          AutofillClient::AddressPromptUserDecision::kEditAccepted,
          AutofillProfileHasInfo(autofill::FieldType::PHONE_HOME_WHOLE_NUMBER,
                                 kNewPhoneNumber)));
  dialog()->Accept();
}

TEST_F(EditAddressProfileViewTest, SaveInvokesTheCallbackWithEditedEmail) {
  CreateViewAndShow();
  const std::u16string kNewEmail = u"abc@xyz.com";
  const std::string locale = g_browser_process->GetApplicationLocale();
  // Confirm that the new email is indeed different from the original one
  // from the controller.
  ASSERT_NE(kNewEmail, address_profile_to_edit().GetInfo(
                           autofill::FieldType::EMAIL_ADDRESS, locale));
  AddressEditorView* editor_view = dialog()->GetAddressEditorViewForTesting();
  DCHECK(editor_view);

  editor_view->SetTextInputFieldValueForTesting(
      autofill::FieldType::EMAIL_ADDRESS, kNewEmail);

  EXPECT_CALL(
      *mock_controller(),
      OnDialogClosed(AutofillClient::AddressPromptUserDecision::kEditAccepted,
                     AutofillProfileHasInfo(autofill::FieldType::EMAIL_ADDRESS,
                                            kNewEmail)));
  dialog()->Accept();
}

TEST_F(EditAddressProfileViewTest, InvalidFormIsNotSent) {
  ON_CALL(*mock_controller(), GetIsValidatable)
      .WillByDefault(::testing::Return(true));
  CreateViewAndShow(AutofillProfile(AddressCountryCode("US")));

  // `kIgnored` is sent as the decision when the dialog is closed (on test end).
  EXPECT_CALL(
      *mock_controller(),
      OnDialogClosed(AutofillClient::AddressPromptUserDecision::kIgnored,
                     ::testing::_));
  EXPECT_CALL(
      *mock_controller(),
      OnDialogClosed(AutofillClient::AddressPromptUserDecision::kEditAccepted,
                     ::testing::_))
      .Times(0);

  dialog()->Accept();
}

TEST_F(EditAddressProfileViewTest, GetInitiallyFocusedView) {
  auto dialog = std::make_unique<EditAddressProfileView>(mock_controller());

  EXPECT_EQ(dialog->GetInitiallyFocusedView(), nullptr);

  AutofillProfile profile(AddressCountryCode("US"));
  ON_CALL(*mock_controller(), GetProfileToEdit())
      .WillByDefault(testing::ReturnRef(profile));
  dialog->ShowForWebContents(test_web_contents());

  EXPECT_NE(dialog->GetInitiallyFocusedView(), nullptr);
  EXPECT_EQ(dialog->GetInitiallyFocusedView()->GetClassName(), "Combobox");
}

}  // namespace autofill