1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/controls/menu/menu_model_adapter.h"
#include "base/functional/callback.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/current_thread.h"
#include "base/task/single_thread_task_runner.h"
#include "chrome/browser/ui/views/test/view_event_test_base.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "ui/base/models/menu_model.h"
#include "ui/base/mojom/menu_source_type.mojom.h"
#include "ui/base/test/ui_controls.h"
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/menu/menu_controller.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/controls/menu/submenu_view.h"
#include "ui/views/test/menu_test_utils.h"
#include "ui/views/widget/root_view.h"
#include "ui/views/widget/widget.h"
namespace {
const int kTopMenuBaseId = 100;
const int kSubMenuBaseId = 200;
// Implement most of the ui::MenuModel pure virtual methods for subclasses
//
// Exceptions:
// virtual int GetItemCount() const = 0;
// virtual ItemType GetTypeAt(int index) const = 0;
// virtual int GetCommandIdAt(int index) const = 0;
// virtual std::u16string GetLabelAt(int index) const = 0;
class CommonMenuModel : public ui::MenuModel {
public:
CommonMenuModel() = default;
CommonMenuModel(const CommonMenuModel&) = delete;
CommonMenuModel& operator=(const CommonMenuModel&) = delete;
~CommonMenuModel() override = default;
protected:
// ui::MenuModel:
bool IsItemDynamicAt(size_t index) const override { return false; }
bool GetAcceleratorAt(size_t index,
ui::Accelerator* accelerator) const override {
return false;
}
ui::MenuSeparatorType GetSeparatorTypeAt(size_t index) const override {
return ui::NORMAL_SEPARATOR;
}
bool IsItemCheckedAt(size_t index) const override { return false; }
int GetGroupIdAt(size_t index) const override { return 0; }
ui::ImageModel GetIconAt(size_t index) const override {
return ui::ImageModel();
}
ui::ButtonMenuItemModel* GetButtonMenuItemAt(size_t index) const override {
return nullptr;
}
bool IsEnabledAt(size_t index) const override { return true; }
ui::MenuModel* GetSubmenuModelAt(size_t index) const override {
return nullptr;
}
void ActivatedAt(size_t index) override {}
};
class SubMenuModel final : public CommonMenuModel {
public:
SubMenuModel() = default;
SubMenuModel(const SubMenuModel&) = delete;
SubMenuModel& operator=(const SubMenuModel&) = delete;
~SubMenuModel() override = default;
bool showing() const { return showing_; }
private:
// ui::MenuModel implementation.
base::WeakPtr<ui::MenuModel> AsWeakPtr() override {
return weak_ptr_factory_.GetWeakPtr();
}
size_t GetItemCount() const override { return 1; }
ItemType GetTypeAt(size_t index) const override { return TYPE_COMMAND; }
int GetCommandIdAt(size_t index) const override {
return static_cast<int>(index) + kSubMenuBaseId;
}
std::u16string GetLabelAt(size_t index) const override { return u"Item"; }
void MenuWillShow() override { showing_ = true; }
// Called when the menu is about to close.
void MenuWillClose() override { showing_ = false; }
bool showing_ = false;
base::WeakPtrFactory<SubMenuModel> weak_ptr_factory_{this};
};
class TopMenuModel final : public CommonMenuModel {
public:
TopMenuModel() = default;
TopMenuModel(const TopMenuModel&) = delete;
TopMenuModel& operator=(const TopMenuModel&) = delete;
~TopMenuModel() override = default;
bool IsSubmenuShowing() { return sub_menu_model_.showing(); }
private:
// ui::MenuModel implementation.
base::WeakPtr<ui::MenuModel> AsWeakPtr() override {
return weak_ptr_factory_.GetWeakPtr();
}
size_t GetItemCount() const override { return 1; }
ItemType GetTypeAt(size_t index) const override { return TYPE_SUBMENU; }
int GetCommandIdAt(size_t index) const override {
return static_cast<int>(index) + kTopMenuBaseId;
}
std::u16string GetLabelAt(size_t index) const override { return u"submenu"; }
MenuModel* GetSubmenuModelAt(size_t index) const override {
return &sub_menu_model_;
}
mutable SubMenuModel sub_menu_model_;
base::WeakPtrFactory<TopMenuModel> weak_ptr_factory_{this};
};
} // namespace
class MenuModelAdapterTest : public ViewEventTestBase {
public:
MenuModelAdapterTest() = default;
~MenuModelAdapterTest() override = default;
// ViewEventTestBase implementation.
void SetUp() override {
ViewEventTestBase::SetUp();
std::unique_ptr<views::MenuItemView> menu =
menu_model_adapter_.CreateMenu();
menu_ = menu.get();
menu_runner_ = std::make_unique<views::MenuRunner>(
std::move(menu), views::MenuRunner::HAS_MNEMONICS);
}
void TearDown() override {
menu_ = nullptr;
menu_runner_.reset();
button_ = nullptr;
ViewEventTestBase::TearDown();
}
std::unique_ptr<views::View> CreateContentsView() override {
auto button = std::make_unique<views::MenuButton>(
base::BindRepeating(&MenuModelAdapterTest::ButtonPressed,
base::Unretained(this)),
u"Menu Adapter Test");
button_ = button.get();
return button;
}
gfx::Size GetPreferredSizeForContents() const override {
return button_->GetPreferredSize();
}
// ViewEventTestBase implementation
void DoTestOnMessageLoop() override {
Click(button_, CreateEventTask(this, &MenuModelAdapterTest::Step1));
}
// Open the submenu.
void Step1() {
views::test::DisableMenuClosureAnimations();
views::SubmenuView* topmenu = menu_->GetSubmenu();
ASSERT_TRUE(topmenu);
ASSERT_TRUE(topmenu->IsShowing());
ASSERT_FALSE(top_menu_model_.IsSubmenuShowing());
// Click the first item to open the submenu.
views::MenuItemView* item = topmenu->GetMenuItemAt(0);
ASSERT_TRUE(item);
Click(item, CreateEventTask(this, &MenuModelAdapterTest::Step2));
}
// Rebuild the menu which should close the submenu.
void Step2() {
views::SubmenuView* topmenu = menu_->GetSubmenu();
ASSERT_TRUE(topmenu);
ASSERT_TRUE(topmenu->IsShowing());
ASSERT_TRUE(top_menu_model_.IsSubmenuShowing());
menu_model_adapter_.BuildMenu(menu_);
ASSERT_TRUE(base::CurrentUIThread::IsSet());
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE, CreateEventTask(this, &MenuModelAdapterTest::Step3));
}
// Verify that the submenu MenuModel received the close callback
// and close the menu.
void Step3() {
views::SubmenuView* topmenu = menu_->GetSubmenu();
ASSERT_TRUE(topmenu);
ASSERT_TRUE(topmenu->IsShowing());
ASSERT_FALSE(top_menu_model_.IsSubmenuShowing());
// Click the button to exit the menu.
Click(button_, CreateEventTask(this, &MenuModelAdapterTest::Step4));
}
// All done.
void Step4() {
views::SubmenuView* topmenu = menu_->GetSubmenu();
views::test::WaitForMenuClosureAnimation();
ASSERT_TRUE(topmenu);
ASSERT_FALSE(topmenu->IsShowing());
ASSERT_FALSE(top_menu_model_.IsSubmenuShowing());
Done();
}
private:
// Generate a mouse click on the specified view and post a new task.
virtual void Click(views::View* view, base::OnceClosure next) {
ui_test_utils::MoveMouseToCenterAndClick(
view, ui_controls::LEFT, ui_controls::DOWN | ui_controls::UP,
std::move(next));
}
void ButtonPressed() {
menu_runner_->RunMenuAt(button_->GetWidget(), button_->button_controller(),
button_->GetBoundsInScreen(),
views::MenuAnchorPosition::kTopLeft,
ui::mojom::MenuSourceType::kNone);
}
raw_ptr<views::MenuButton> button_ = nullptr;
TopMenuModel top_menu_model_;
views::MenuModelAdapter menu_model_adapter_{&top_menu_model_};
std::unique_ptr<views::MenuRunner> menu_runner_;
raw_ptr<views::MenuItemView> menu_ = nullptr;
};
// If this flakes, disable and log details in http://crbug.com/523255.
VIEW_TEST(MenuModelAdapterTest, RebuildMenu)
|