1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <algorithm>
#include "base/containers/to_vector.h"
#include "base/memory/raw_ptr.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/test_with_browser_view.h"
#include "chrome/browser/ui/views/permissions/chip/chip_controller.h"
#include "chrome/browser/ui/views/permissions/permission_prompt_chip.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/grit/generated_resources.h"
#include "components/permissions/features.h"
#include "components/permissions/permission_request_enums.h"
#include "components/permissions/permission_ui_selector.h"
#include "components/permissions/test/mock_permission_request.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/events/base_event_utils.h"
#include "ui/gfx/animation/animation_test_api.h"
#include "ui/views/test/ax_event_counter.h"
#include "ui/views/test/button_test_api.h"
namespace {
class TestDelegate : public permissions::PermissionPrompt::Delegate {
public:
explicit TestDelegate(
const GURL& origin,
const std::vector<permissions::RequestType> request_types,
bool with_gesture,
content::WebContents* web_contents)
: TestDelegate(origin,
request_types,
with_gesture,
std::nullopt,
web_contents) {}
explicit TestDelegate(
const GURL& origin,
const std::vector<permissions::RequestType> request_types,
bool with_gesture,
std::optional<permissions::PermissionUiSelector::QuietUiReason>
quiet_ui_reason,
content::WebContents* web_contents)
: quiet_ui_reason_(quiet_ui_reason), web_contents_(web_contents) {
requests_ = base::ToVector(
request_types,
[&](auto request_type)
-> std::unique_ptr<permissions::PermissionRequest> {
return std::make_unique<permissions::MockPermissionRequest>(
origin, request_type,
with_gesture
? permissions::PermissionRequestGestureType::GESTURE
: permissions::PermissionRequestGestureType::NO_GESTURE);
});
raw_requests_ = base::ToVector(
requests_,
[](const auto& request)
-> raw_ptr<permissions::PermissionRequest, VectorExperimental> {
return request.get();
});
}
const std::vector<std::unique_ptr<permissions::PermissionRequest>>& Requests()
override {
return requests_;
}
GURL GetRequestingOrigin() const override {
return raw_requests_.front()->requesting_origin();
}
GURL GetEmbeddingOrigin() const override {
return GURL("https://embedder.example.com");
}
void Accept() override { requests_.clear(); }
void AcceptThisTime() override { requests_.clear(); }
void Deny() override { requests_.clear(); }
void Dismiss() override { requests_.clear(); }
void Ignore() override { requests_.clear(); }
void FinalizeCurrentRequests() override { NOTREACHED(); }
void OpenHelpCenterLink(const ui::Event& event) override {}
void PreIgnoreQuietPrompt() override { requests_.clear(); }
void SetManageClicked() override { requests_.clear(); }
void SetLearnMoreClicked() override { requests_.clear(); }
void SetHatsShownCallback(base::OnceCallback<void()> callback) override {}
bool RecreateView() override { return false; }
const permissions::PermissionPrompt* GetCurrentPrompt() const override {
return nullptr;
}
bool WasCurrentRequestAlreadyDisplayed() override {
return was_current_request_already_displayed_;
}
bool ShouldDropCurrentRequestIfCannotShowQuietly() const override {
return false;
}
bool ShouldCurrentRequestUseQuietUI() const override {
return quiet_ui_reason_.has_value();
}
std::optional<permissions::PermissionUiSelector::QuietUiReason>
ReasonForUsingQuietUi() const override {
return quiet_ui_reason_;
}
void SetDismissOnTabClose() override {}
void SetPromptShown() override {}
void SetDecisionTime() override {}
base::WeakPtr<permissions::PermissionPrompt::Delegate> GetWeakPtr() override {
return weak_factory_.GetWeakPtr();
}
content::WebContents* GetAssociatedWebContents() override {
return web_contents_;
}
bool IsRequestInProgress() { return !requests_.empty(); }
void SetAlreadyDisplayed() { was_current_request_already_displayed_ = true; }
private:
std::vector<std::unique_ptr<permissions::PermissionRequest>> requests_;
std::vector<raw_ptr<permissions::PermissionRequest, VectorExperimental>>
raw_requests_;
bool was_current_request_already_displayed_ = false;
std::optional<permissions::PermissionUiSelector::QuietUiReason>
quiet_ui_reason_;
raw_ptr<content::WebContents> web_contents_;
base::WeakPtrFactory<TestDelegate> weak_factory_{this};
};
} // namespace
class PermissionChipUnitTest : public TestWithBrowserView {
public:
PermissionChipUnitTest()
: TestWithBrowserView(base::test::TaskEnvironment::TimeSource::MOCK_TIME),
animation_mode_reset_(gfx::AnimationTestApi::SetRichAnimationRenderMode(
gfx::Animation::RichAnimationRenderMode::FORCE_ENABLED)) {}
PermissionChipUnitTest(const PermissionChipUnitTest&) = delete;
PermissionChipUnitTest& operator=(const PermissionChipUnitTest&) = delete;
void SetUp() override {
TestWithBrowserView::SetUp();
AddTab(browser(), GURL("http://a.com"));
web_contents_ = browser()->tab_strip_model()->GetWebContentsAt(0);
}
void ClickOnChip(PermissionChipView& chip) {
views::test::ButtonTestApi(&chip).NotifyClick(
ui::MouseEvent(ui::EventType::kMousePressed, gfx::Point(), gfx::Point(),
ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON, 0));
base::RunLoop().RunUntilIdle();
}
raw_ptr<content::WebContents, DanglingUntriaged> web_contents_;
// Some of these tests rely on animation being enabled. This forces
// animation on even if it's turned off in the OS.
gfx::AnimationTestApi::RenderModeResetter animation_mode_reset_;
base::TimeDelta kChipCollapseDuration = base::Seconds(12);
base::TimeDelta kNormalChipDismissDuration = base::Seconds(6);
base::TimeDelta kQuietChipDismissDuration = base::Seconds(18);
base::TimeDelta kLongerThanAllTimersDuration = base::Seconds(50);
};
TEST_F(PermissionChipUnitTest, AlreadyDisplayedRequestTest) {
TestDelegate delegate(GURL("https://test.origin"),
{permissions::RequestType::kNotifications}, false,
web_contents_);
delegate.SetAlreadyDisplayed();
EXPECT_TRUE(delegate.WasCurrentRequestAlreadyDisplayed());
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
EXPECT_FALSE(chip_controller->IsBubbleShowing());
// The permission request was already displayed, but the dismiss timer will
// not be triggered directly after the chip is displayed because of the popup
// bubble.
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// The default dismiss timer is 6 seconds. The chip should be still displayed
// after 5 seconds.
task_environment()->AdvanceClock(kNormalChipDismissDuration -
base::Seconds(1));
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
// Wait 2 more seconds for the dismiss timer to finish.
task_environment()->AdvanceClock(base::Seconds(2));
base::RunLoop().RunUntilIdle();
// All chips are feature auto popup bubble. They should not resolve a prompt
// automatically.
ASSERT_TRUE(delegate.IsRequestInProgress());
}
TEST_F(PermissionChipUnitTest, AccessibleName) {
TestDelegate delegate(GURL("https://test.origin"),
{permissions::RequestType::kNotifications}, false,
web_contents_);
delegate.SetAlreadyDisplayed();
EXPECT_TRUE(delegate.WasCurrentRequestAlreadyDisplayed());
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
AddTab(browser(), GURL("http://a.com"));
std::u16string tab_title = browser()->GetTitleForTab(0);
std::u16string permission_title = l10n_util::GetStringFUTF16(
IDS_TAB_AX_LABEL_PERMISSION_REQUESTED_FORMAT, tab_title);
chip_controller->ShowPermissionUi(delegate.GetWeakPtr());
chip_controller->AnimateExpand();
ui::AXNodeData data;
browser()
->GetBrowserView()
.tabstrip_->tab_at(0)
->GetViewAccessibility()
.GetAccessibleNodeData(&data);
EXPECT_TRUE(chip_controller->IsPermissionPromptChipVisible());
EXPECT_EQ(permission_title,
data.GetString16Attribute(ax::mojom::StringAttribute::kName));
chip_controller->HideChip();
data = ui::AXNodeData();
browser()
->GetBrowserView()
.tabstrip_->tab_at(0)
->GetViewAccessibility()
.GetAccessibleNodeData(&data);
EXPECT_FALSE(chip_controller->IsPermissionPromptChipVisible());
EXPECT_EQ(tab_title,
data.GetString16Attribute(ax::mojom::StringAttribute::kName));
}
TEST_F(PermissionChipUnitTest, ClickOnRequestChipTest) {
TestDelegate delegate(GURL("https://test.origin"),
{permissions::RequestType::kNotifications}, true,
web_contents_);
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
// Due to animation issue, the collapse timer will not be started.
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// Animation does not work. Most probably it is unit tests limitations.
// `chip.is_fully_collapsed()` will not work as well.
EXPECT_TRUE(chip_controller->IsAnimating());
chip_controller->stop_animation_for_test();
EXPECT_FALSE(chip_controller->IsAnimating());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
task_environment()->AdvanceClock(kLongerThanAllTimersDuration);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
// Bubble is showing automatically.
EXPECT_TRUE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// A click on the chip hides the popup bubble and resolves a permission
// request.
ClickOnChip(*chip_controller->chip());
EXPECT_FALSE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(delegate.IsRequestInProgress());
}
TEST_F(PermissionChipUnitTest, DisplayQuietChipNoAbusiveTest) {
TestDelegate delegate(
GURL("https://test.origin"), {permissions::RequestType::kNotifications},
true, permissions::PermissionUiSelector::QuietUiReason::kEnabledInPrefs,
web_contents_);
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
EXPECT_FALSE(chip_controller->IsBubbleShowing());
// Due to animation issue, the collapse timer will not be started.
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// Animation does not work. Most probably it is unit tests limitations.
// `chip.is_fully_collapsed()` will not work as well.
EXPECT_TRUE(chip_controller->IsAnimating());
chip_controller->stop_animation_for_test();
EXPECT_FALSE(chip_controller->IsAnimating());
EXPECT_TRUE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
task_environment()->AdvanceClock(kChipCollapseDuration - base::Seconds(1));
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
EXPECT_TRUE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// Wait 2 more seconds for the collapse timer to finish.
task_environment()->AdvanceClock(base::Seconds(2));
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
// The collapse timer is fired and the dismiss timer is started.
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_TRUE(chip_controller->is_dismiss_timer_running_for_testing());
task_environment()->AdvanceClock(kNormalChipDismissDuration +
base::Seconds(1));
base::RunLoop().RunUntilIdle();
ASSERT_FALSE(delegate.IsRequestInProgress());
}
TEST_F(PermissionChipUnitTest, ClickOnQuietChipNoAbusiveTest) {
TestDelegate delegate(
GURL("https://test.origin"), {permissions::RequestType::kNotifications},
true, permissions::PermissionUiSelector::QuietUiReason::kEnabledInPrefs,
web_contents_);
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
EXPECT_FALSE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// Animation does not work. Most probably it is unit tests limitations.
// `chip.is_fully_collapsed()` will not work as well.
EXPECT_TRUE(chip_controller->IsAnimating());
chip_controller->stop_animation_for_test();
EXPECT_FALSE(chip_controller->IsAnimating());
EXPECT_TRUE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
EXPECT_FALSE(chip_controller->IsBubbleShowing());
// The chip collapse timer is 12 seconds.
task_environment()->AdvanceClock(kChipCollapseDuration - base::Seconds(1));
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
EXPECT_TRUE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
ClickOnChip(*chip_controller->chip());
EXPECT_TRUE(chip_controller->IsBubbleShowing());
// Collapse timer was restarted.
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// After 30 seconds the permissin prompt popup bubble should still be
// visible.
task_environment()->AdvanceClock(kLongerThanAllTimersDuration);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
EXPECT_TRUE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// The seconds click on the chip hides the popup bubble.
ClickOnChip(*chip_controller->chip());
EXPECT_FALSE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(delegate.IsRequestInProgress());
}
TEST_F(PermissionChipUnitTest, DisplayQuietChipAbusiveTest) {
TestDelegate delegate(GURL("https://test.origin"),
{permissions::RequestType::kNotifications}, true,
permissions::PermissionUiSelector::QuietUiReason::
kTriggeredDueToAbusiveRequests,
web_contents_);
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
EXPECT_FALSE(chip_controller->IsBubbleShowing());
// The quiet abusive chip does not have animation and will start the dismiss
// timer immediately after displaying.
EXPECT_FALSE(chip_controller->IsAnimating());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_TRUE(chip_controller->is_dismiss_timer_running_for_testing());
// The dismiss timer is 18 seconds by default. After 17 seconds, the chip
// should be there.
task_environment()->AdvanceClock(kQuietChipDismissDuration -
base::Seconds(1));
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_TRUE(chip_controller->is_dismiss_timer_running_for_testing());
// Wait 2 more seconds for the dismiss timer to finish.
task_environment()->AdvanceClock(base::Seconds(2));
base::RunLoop().RunUntilIdle();
ASSERT_FALSE(delegate.IsRequestInProgress());
}
TEST_F(PermissionChipUnitTest, ClickOnQuietChipAbusiveTest) {
TestDelegate delegate(GURL("https://test.origin"),
{permissions::RequestType::kNotifications}, true,
permissions::PermissionUiSelector::QuietUiReason::
kTriggeredDueToAbusiveRequests,
web_contents_);
PermissionPromptChip chip_prompt(browser(), web_contents_, &delegate);
ChipController* chip_controller =
chip_prompt.get_chip_controller_for_testing();
EXPECT_FALSE(chip_controller->IsBubbleShowing());
// The quiet abusive chip does not have animation and will start the dismiss
// timer immediately after displaying.
EXPECT_FALSE(chip_controller->IsAnimating());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_TRUE(chip_controller->is_dismiss_timer_running_for_testing());
// The dismiss timer is 18 seconds by default. After 17 seconds, the chip
// should be there.
task_environment()->AdvanceClock(kQuietChipDismissDuration -
base::Seconds(1));
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_TRUE(chip_controller->is_dismiss_timer_running_for_testing());
// Click to open a permission popup bubble.
ClickOnChip(*chip_controller->chip());
EXPECT_TRUE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
task_environment()->AdvanceClock(kLongerThanAllTimersDuration);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(delegate.IsRequestInProgress());
EXPECT_TRUE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(chip_controller->is_collapse_timer_running_for_testing());
EXPECT_FALSE(chip_controller->is_dismiss_timer_running_for_testing());
// The second click on the chip hides the prompt and resolves the permission
// request.
ClickOnChip(*chip_controller->chip());
EXPECT_FALSE(chip_controller->IsBubbleShowing());
EXPECT_FALSE(delegate.IsRequestInProgress());
}
|
