1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/tabs/tab_hover_card_controller.h"
#include "base/memory/scoped_refptr.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/ui/performance_controls/memory_saver_chip_tab_helper.h"
#include "chrome/browser/ui/performance_controls/tab_resource_usage_tab_helper.h"
#include "chrome/browser/ui/thumbnails/thumbnail_image.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/test_with_browser_view.h"
#include "chrome/browser/ui/views/tabs/tab_hover_card_thumbnail_observer.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/common/pref_names.h"
#include "components/memory_pressure/fake_memory_pressure_monitor.h"
// These are regression tests for possible crashes.
class TabHoverCardControllerTest : public TestWithBrowserView {
public:
TabHoverCardControllerTest() {
feature_list_.InitAndEnableFeature(features::kTabHoverCardImages);
}
void SimulateMemoryPressure(
base::MemoryPressureMonitor::MemoryPressureLevel level) {
fake_memory_monitor_.SetAndNotifyMemoryPressure(level);
}
private:
base::test::ScopedFeatureList feature_list_;
memory_pressure::test::FakeMemoryPressureMonitor fake_memory_monitor_;
};
TEST_F(TabHoverCardControllerTest, ShowWrongTabDoesntCrash) {
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
// Create some completely invalid pointer values (these should never be
// dereferenced).
Tab* const tab1 = reinterpret_cast<Tab*>(3);
Tab* const tab2 = reinterpret_cast<Tab*>(7);
controller->target_tab_ = tab1;
// If the safeguard is not in place, this will crash because the target tab is
// not a valid pointer.
controller->ShowHoverCard(false, tab2);
}
TEST_F(TabHoverCardControllerTest, SetPreviewWithNoHoverCardDoesntCrash) {
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
// If the safeguard is not in place, this could crash in either metrics
// collection *or* in trying to set the actual thumbnail image on the card.
controller->OnPreviewImageAvailable(controller->thumbnail_observer_.get(),
gfx::ImageSkia());
}
TEST_F(TabHoverCardControllerTest, ShowPreviewsForTab) {
g_browser_process->local_state()->SetBoolean(prefs::kHoverCardImagesEnabled,
true);
AddTab(browser_view()->browser(), GURL("http://foo1.com"));
AddTab(browser_view()->browser(), GURL("http://foo2.com"));
browser_view()->browser()->tab_strip_model()->ActivateTabAt(0);
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
Tab* const target_tab = browser_view()->tabstrip()->tab_at(1);
controller->target_tab_ = target_tab;
controller->CreateHoverCard(target_tab);
EXPECT_TRUE(controller->ArePreviewsEnabled());
}
TEST_F(TabHoverCardControllerTest, DisablePreviewsForTab) {
g_browser_process->local_state()->SetBoolean(prefs::kHoverCardImagesEnabled,
false);
AddTab(browser_view()->browser(), GURL("http://foo1.com"));
AddTab(browser_view()->browser(), GURL("http://foo2.com"));
browser_view()->browser()->tab_strip_model()->ActivateTabAt(0);
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
Tab* const target_tab = browser_view()->tabstrip()->tab_at(1);
controller->target_tab_ = target_tab;
controller->CreateHoverCard(target_tab);
EXPECT_FALSE(controller->ArePreviewsEnabled());
}
TEST_F(TabHoverCardControllerTest, HidePreviewsForDiscardedTab) {
g_browser_process->local_state()->SetBoolean(prefs::kHoverCardImagesEnabled,
true);
AddTab(browser_view()->browser(), GURL("http://foo1.com"));
AddTab(browser_view()->browser(), GURL("http://foo2.com"));
browser_view()->browser()->tab_strip_model()->ActivateTabAt(0);
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
Tab* const target_tab = browser_view()->tabstrip()->tab_at(1);
TabRendererData data;
data.is_tab_discarded = true;
target_tab->SetData(std::move(data));
controller->target_tab_ = target_tab;
controller->CreateHoverCard(target_tab);
controller->UpdateCardContent(target_tab);
EXPECT_EQ(controller->thumbnail_observer_.get()->current_image(), nullptr);
EXPECT_EQ(controller->thumbnail_wait_state_,
TabHoverCardController::kNotWaiting);
}
TEST_F(TabHoverCardControllerTest, DisableMemoryUsageForTab) {
g_browser_process->local_state()->SetBoolean(
prefs::kHoverCardMemoryUsageEnabled, false);
AddTab(browser_view()->browser(), GURL("http://foo1.com"));
AddTab(browser_view()->browser(), GURL("http://foo2.com"));
browser_view()->browser()->tab_strip_model()->ActivateTabAt(0);
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
Tab* const target_tab = browser_view()->tabstrip()->tab_at(1);
TabRendererData data;
auto tab_resource_usage = base::MakeRefCounted<TabResourceUsage>();
tab_resource_usage->SetMemoryUsageInBytes(100);
data.tab_resource_usage = std::move(tab_resource_usage);
target_tab->SetData(std::move(data));
controller->target_tab_ = target_tab;
controller->CreateHoverCard(target_tab);
EXPECT_FALSE(controller->hover_card_memory_usage_enabled_);
}
class TestThumbnailImageDelegate : public ThumbnailImage::Delegate {
public:
TestThumbnailImageDelegate() = default;
~TestThumbnailImageDelegate() override = default;
void ThumbnailImageBeingObservedChanged(bool is_being_observed) override {
is_being_observed_ = is_being_observed;
}
bool is_being_observed() const { return is_being_observed_; }
private:
bool is_being_observed_ = false;
};
TEST_F(TabHoverCardControllerTest, ShowPreviewsForDiscardedTabWithThumbnail) {
g_browser_process->local_state()->SetBoolean(prefs::kHoverCardImagesEnabled,
true);
AddTab(browser_view()->browser(), GURL("http://foo1.com"));
AddTab(browser_view()->browser(), GURL("http://foo2.com"));
browser_view()->browser()->tab_strip_model()->ActivateTabAt(0);
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
Tab* const target_tab = browser_view()->tabstrip()->tab_at(1);
TabRendererData data;
data.is_tab_discarded = true;
target_tab->SetData(std::move(data));
controller->target_tab_ = target_tab;
TestThumbnailImageDelegate delegate;
auto image = base::MakeRefCounted<ThumbnailImage>(&delegate);
controller->CreateHoverCard(target_tab);
controller->thumbnail_observer_.get()->Observe(image);
EXPECT_NE(controller->thumbnail_observer_.get()->current_image(), nullptr);
EXPECT_EQ(controller->thumbnail_wait_state_,
TabHoverCardController::kNotWaiting);
}
TEST_F(TabHoverCardControllerTest, DontCaptureUnderCriticalMemoryPressure) {
g_browser_process->local_state()->SetBoolean(prefs::kHoverCardImagesEnabled,
true);
AddTab(browser_view()->browser(), GURL("http://foo1.com"));
AddTab(browser_view()->browser(), GURL("http://foo2.com"));
browser_view()->browser()->tab_strip_model()->ActivateTabAt(0);
auto controller =
std::make_unique<TabHoverCardController>(browser_view()->tabstrip());
Tab* const target_tab = browser_view()->tabstrip()->tab_at(1);
TabRendererData data;
TestThumbnailImageDelegate delegate;
data.thumbnail = base::MakeRefCounted<ThumbnailImage>(&delegate);
target_tab->SetData(std::move(data));
controller->target_tab_ = target_tab;
SimulateMemoryPressure(base::MemoryPressureMonitor::MemoryPressureLevel::
MEMORY_PRESSURE_LEVEL_CRITICAL);
controller->ShowHoverCard(true, target_tab);
EXPECT_EQ(controller->thumbnail_observer_.get()->current_image(), nullptr);
EXPECT_EQ(controller->thumbnail_wait_state_,
TabHoverCardController::kWaitingWithPlaceholder);
}
class TabHoverCardPreviewsEnabledPrefTest : public TestWithBrowserView {
public:
TabHoverCardPreviewsEnabledPrefTest() {
feature_list_.InitAndDisableFeature(features::kTabHoverCardImages);
}
private:
base::test::ScopedFeatureList feature_list_;
};
TEST_F(TabHoverCardPreviewsEnabledPrefTest, DefaultState) {
EXPECT_FALSE(TabHoverCardController::AreHoverCardImagesEnabled());
}
|
