1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <optional>
#include <sstream>
#include <variant>
#include "base/functional/overloaded.h"
#include "base/strings/stringprintf.h"
#include "base/strings/to_string.h"
#include "base/test/metrics/user_action_tester.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_element_identifiers.h"
#include "chrome/browser/ui/browser_window/public/browser_window_features.h"
#include "chrome/browser/ui/toolbar/pinned_toolbar/pinned_toolbar_actions_model.h"
#include "chrome/browser/ui/toolbar_controller_util.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_container.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/side_panel/side_panel_coordinator.h"
#include "chrome/browser/ui/views/side_panel/side_panel_util.h"
#include "chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container.h"
#include "chrome/browser/ui/views/toolbar/toolbar_controller.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "chrome/test/interaction/feature_engagement_initialized_observer.h"
#include "chrome/test/interaction/interactive_browser_test.h"
#include "chrome/test/user_education/interactive_feature_promo_test.h"
#include "components/feature_engagement/public/feature_constants.h"
#include "components/feature_engagement/test/scoped_iph_feature_list.h"
#include "components/user_education/common/feature_promo/feature_promo_result.h"
#include "components/user_education/views/help_bubble_view.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "extensions/test/test_extension_dir.h"
#include "ui/base/interaction/element_identifier.h"
#include "ui/base/ui_base_features.h"
#include "ui/views/layout/animating_layout_manager_test_util.h"
#include "ui/views/test/views_test_utils.h"
#include "ui/views/view.h"
#include "ui/views/view_class_properties.h"
namespace {
constexpr int kBrowserContentAllowedMinimumWidth =
BrowserViewLayout::kMainBrowserContentsMinimumWidth;
} // namespace
class ToolbarControllerUiTest : public InteractiveFeaturePromoTest {
public:
ToolbarControllerUiTest()
: InteractiveFeaturePromoTest(UseDefaultTrackerAllowingPromos(
{feature_engagement::kIPHMemorySaverModeFeature})) {
ToolbarControllerUtil::SetPreventOverflowForTesting(false);
}
void SetUpOnMainThread() override {
ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
embedded_test_server()->StartAcceptingConnections();
InteractiveFeaturePromoTest::SetUpOnMainThread();
browser_view_ = BrowserView::GetBrowserViewForBrowser(browser());
PinnedToolbarActionsModel* const actions_model =
PinnedToolbarActionsModel::Get(browser()->profile());
actions_model->UpdatePinnedState(kActionShowChromeLabs, false);
if (features::HasTabSearchToolbarButton()) {
actions_model->UpdatePinnedState(kActionTabSearch, false);
}
views::test::WaitForAnimatingLayoutManager(
browser_view_->toolbar()->pinned_toolbar_actions_container());
toolbar_controller_ = const_cast<ToolbarController*>(
browser_view_->toolbar()->toolbar_controller());
toolbar_container_view_ = const_cast<views::View*>(
toolbar_controller_->toolbar_container_view_.get());
overflow_button_ = toolbar_controller_->overflow_button_;
dummy_button_size_ = overflow_button_->GetPreferredSize();
element_flex_order_start_ = toolbar_controller_->element_flex_order_start_;
MaybeAddDummyButtonsToToolbarView();
overflow_threshold_width_ = GetOverflowThresholdWidthInToolbarContainer();
default_browser_width_ = browser()->window()->GetBounds().width();
ASSERT_GT(default_browser_width_, overflow_threshold_width_);
}
void TearDownOnMainThread() override {
toolbar_container_view_ = nullptr;
overflow_button_ = nullptr;
toolbar_controller_ = nullptr;
browser_view_ = nullptr;
EXPECT_TRUE(embedded_test_server()->ShutdownAndWaitUntilComplete());
InteractiveFeaturePromoTest::TearDownOnMainThread();
}
// Returns the minimum width the toolbar view can be without any ToolbarButton
// dropped out in ToolbarContainer. This function calculates the
// browser width where elements with flex order > kOrderOffset defined in
// ToolbarView should have minimum size. Since elements with flex order <=
// kOrderOffset happens to have minimum width == preferred width it has no
// effect on diff_sum.
int GetOverflowThresholdWidthInToolbarContainer() {
int diff_sum = 0;
for (views::View* element : toolbar_container_view_->children()) {
diff_sum += element->GetPreferredSize().width() -
element->GetMinimumSize().width();
}
return toolbar_container_view_->GetPreferredSize().width() - diff_sum;
}
// Returns the minimum width the toolbar view can be without any elements
// dropped out in PinnedSidePanelContainer. This function calculates the
// browser width where elements with flex order > kToolbarActionsFlexOrder
// defined in ToolbarView should have minimum size
int GetOverflowThresholdWidthInPinnedSidePanelContainer() {
auto* extensions_container =
browser_view_->toolbar()->extensions_container();
int diff = extensions_container->GetPreferredSize().width() -
extensions_container->GetMinimumSize().width();
return toolbar_container_view_->GetPreferredSize().width() - diff;
}
// Because actual_browser_minimum_width == Max(toolbar_width,
// kBrowserContentAllowedMinimumWidth) So if `overflow_threshold_width_` <
// kBrowserContentAllowedMinimumWidth, then actual_browser_minimum_width ==
// kBrowserContentAllowedMinimumWidth In this case we will never see any
// overflow so stuff toolbar with some fixed dummy buttons till it's
// guaranteed we can observe overflow with browser resized to its minimum
// width.
void MaybeAddDummyButtonsToToolbarView() {
while (GetOverflowThresholdWidthInToolbarContainer() <=
kBrowserContentAllowedMinimumWidth) {
toolbar_container_view_->AddChildView(CreateADummyButton());
}
}
std::unique_ptr<ToolbarButton> CreateADummyButton() {
auto button = std::make_unique<ToolbarButton>();
button->SetPreferredSize(dummy_button_size_);
button->SetMinSize(dummy_button_size_);
button->GetViewAccessibility().SetName(u"dummybutton");
button->SetVisible(true);
return button;
}
auto CheckIsManagedByController(ui::ElementIdentifier id) {
return Check(
[this, id]() {
const std::vector<ToolbarController::ResponsiveElementInfo>&
responsive_elements = get_responsive_elements();
for (const auto& el : responsive_elements) {
if (const auto* info =
std::get_if<ToolbarController::ElementIdInfo>(
&el.overflow_id)) {
if (info->overflow_identifier == id) {
return true;
}
}
}
return false;
},
"CheckIsManagedByController()");
}
auto CheckIsManagedByController(actions::ActionId id) {
return Check(
[this, id]() {
const std::vector<ToolbarController::ResponsiveElementInfo>&
responsive_elements = get_responsive_elements();
for (const auto& el : responsive_elements) {
if (const auto* action =
std::get_if<actions::ActionId>(&el.overflow_id)) {
if (*action == id) {
return true;
}
}
}
return false;
},
"CheckIsManagedByController()");
}
auto CheckActionItemOverflowed(actions::ActionId id, bool overflowed) {
return CheckResult([this, id]() { return delegate()->IsOverflowed(id); },
overflowed,
base::StringPrintf("CheckActionItemOverflowed(%s)",
base::ToString(overflowed)));
}
// Forces `id` to overflow by filling toolbar with dummy buttons.
auto AddDummyButtonsToToolbarTillElementOverflows(ui::ElementIdentifier id) {
auto result = Steps(CheckIsManagedByController(id),
Do([this]() {
SetBrowserWidth(kBrowserContentAllowedMinimumWidth);
}).SetDescription("SetBrowserWidth()"),
Do([this, id]() {
const auto* element =
toolbar_controller_->FindToolbarElementWithId(
toolbar_container_view_, id);
ASSERT_NE(element, nullptr);
while (element->GetVisible()) {
toolbar_container_view_->AddChildView(
CreateADummyButton());
views::test::RunScheduledLayout(browser_view_);
}
}).SetDescription("ForceOverflow"),
WaitForShow(kToolbarOverflowButtonElementId),
WaitForHide(id));
AddDescriptionPrefix(result,
"AddDummyButtonsToToolbarTillElementOverflows()");
return result;
}
auto AddDummyButtonsToToolbarTillElementOverflows(actions::ActionId id) {
auto result = Steps(CheckIsManagedByController(id),
Do([this]() {
SetBrowserWidth(kBrowserContentAllowedMinimumWidth);
}).SetDescription("SetBrowserWidth()"),
Do([this, id]() {
while (!delegate()->IsOverflowed(id)) {
toolbar_container_view_->AddChildView(
CreateADummyButton());
views::test::RunScheduledLayout(browser_view_);
}
}).SetDescription("ForceOverflow"),
WaitForShow(kToolbarOverflowButtonElementId),
CheckActionItemOverflowed(id, true));
AddDescriptionPrefix(result,
"AddDummyButtonsToToolbarTillElementOverflows()");
return result;
}
// This checks menu model, not the actual menu that pops up.
// TODO(pengchaocai): Explore a way to check the actual menu appearing.
auto CheckMenuMatchesOverflowedElements() {
return Steps(Check([this]() {
const ui::SimpleMenuModel* menu = GetOverflowMenu();
EXPECT_NE(menu, nullptr);
EXPECT_GT(menu->GetItemCount(), size_t(0));
const auto& responsive_elements = get_responsive_elements();
for (size_t i = 0; i < responsive_elements.size(); ++i) {
if (toolbar_controller_->IsOverflowed(responsive_elements[i])) {
if (toolbar_controller_->GetMenuText(responsive_elements[i]) !=
menu->GetLabelAt(menu->GetIndexOfCommandId(i).value())) {
return false;
}
}
}
return true;
}));
}
auto ActivateMenuItemWithElementId(
std::variant<ui::ElementIdentifier, actions::ActionId> id) {
return Do([=, this]() {
const std::vector<ToolbarController::ResponsiveElementInfo>&
responsive_elements = get_responsive_elements();
int command_id = -1;
for (size_t i = 0; i < responsive_elements.size(); ++i) {
const auto& overflow_id = responsive_elements[i].overflow_id;
std::visit(
base::Overloaded(
[&](ToolbarController::ElementIdInfo overflow_id) {
if (std::holds_alternative<ui::ElementIdentifier>(id) &&
overflow_id.overflow_identifier ==
std::get<ui::ElementIdentifier>(id)) {
command_id = i;
return;
}
},
[&](actions::ActionId overflow_id) {
if (std::holds_alternative<actions::ActionId>(id) &&
overflow_id == std::get<actions::ActionId>(id)) {
command_id = i;
return;
}
}),
overflow_id);
if (command_id != -1) {
break;
}
}
auto* menu = const_cast<ui::SimpleMenuModel*>(GetOverflowMenu());
auto index = menu->GetIndexOfCommandId(command_id);
EXPECT_TRUE(index.has_value());
menu->ActivatedAt(index.value());
});
}
auto ForceForwardButtonOverflow() {
return Steps(AddDummyButtonsToToolbarTillElementOverflows(
kToolbarForwardButtonElementId));
}
auto PinBookmarkToToolbar() {
return Steps(Do([=, this]() {
chrome::ExecuteCommand(browser(),
IDC_SHOW_BOOKMARK_SIDE_PANEL);
}),
WaitForShow(kSidePanelElementId),
PressButton(kSidePanelPinButtonElementId),
PressButton(kSidePanelCloseButtonElementId),
WaitForHide(kSidePanelElementId));
}
auto PinReadingModeToToolbar() {
return Steps(Do([=, this]() {
chrome::ExecuteCommand(browser(),
IDC_SHOW_READING_MODE_SIDE_PANEL);
}),
WaitForShow(kSidePanelElementId),
PressButton(kSidePanelPinButtonElementId),
PressButton(kSidePanelCloseButtonElementId),
WaitForHide(kSidePanelElementId));
}
auto RestoreBrowserWidth() {
return Steps(Do([this]() { SetBrowserWidth(default_browser_width_); }),
WaitForHide(kToolbarOverflowButtonElementId));
}
auto LoadAndPinExtensionButton() {
return Do([this]() {
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test Extension",
"version": "1",
"manifest_version": 3,
"host_permissions": [
"<all_urls>"
]
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(browser()->profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
// Pin extension.
auto* toolbar_model = ToolbarActionsModel::Get(browser()->profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extension->id(), true);
views::test::RunScheduledLayout(browser_view_);
});
}
auto ResizeRelativeToOverflow(int diff) {
return Do(
[this, diff]() { SetBrowserWidth(overflow_threshold_width() + diff); });
}
void SetBrowserWidth(int width) {
int widget_width = browser_view_->GetWidget()->GetSize().width();
int browser_width = browser_view_->size().width();
browser_view_->GetWidget()->SetSize(
{width + widget_width - browser_width,
browser_view_->GetWidget()->GetSize().height()});
views::test::RunScheduledLayout(browser_view_);
}
const views::View* FindToolbarElementWithId(ui::ElementIdentifier id) const {
return toolbar_controller_->FindToolbarElementWithId(
toolbar_container_view_, id);
}
gfx::Size dummy_button_size() { return dummy_button_size_; }
ToolbarController::PinnedActionsDelegate* delegate() {
return toolbar_controller_->pinned_actions_delegate_;
}
const views::View* overflow_button() const { return overflow_button_; }
int element_flex_order_start() const { return element_flex_order_start_; }
const std::vector<ToolbarController::ResponsiveElementInfo>&
get_responsive_elements() const {
return toolbar_controller_->responsive_elements_;
}
int overflow_threshold_width() const { return overflow_threshold_width_; }
std::vector<const ToolbarController::ResponsiveElementInfo*>
GetOverflowedElements() {
return toolbar_controller_->GetOverflowedElements();
}
const ui::SimpleMenuModel* GetOverflowMenu() {
return toolbar_controller_->menu_model_for_testing();
}
BrowserView* browser_view() { return browser_view_.get(); }
private:
raw_ptr<BrowserView> browser_view_;
raw_ptr<ToolbarController> toolbar_controller_;
raw_ptr<views::View> toolbar_container_view_;
raw_ptr<views::View> overflow_button_;
int element_flex_order_start_;
gfx::Size dummy_button_size_;
// The minimum width the toolbar view can be without any elements dropped out.
int overflow_threshold_width_;
int default_browser_width_;
};
// TODO(crbug.com/41495158): Flaky on Windows.
#if BUILDFLAG(IS_WIN)
#define MAYBE_StartBrowserWithThresholdWidth \
DISABLED_StartBrowserWithThresholdWidth
#else
#define MAYBE_StartBrowserWithThresholdWidth StartBrowserWithThresholdWidth
#endif
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
MAYBE_StartBrowserWithThresholdWidth) {
// Start browser with threshold width. Should not see overflow.
SetBrowserWidth(overflow_threshold_width());
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser a bit wider. Should not see overflow.
SetBrowserWidth(overflow_threshold_width() + 1);
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser back to threshold width. Should not see overflow.
SetBrowserWidth(overflow_threshold_width());
EXPECT_FALSE(overflow_button()->GetVisible());
base::UserActionTester user_action_tester;
EXPECT_EQ(0, user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowButtonShown"));
// Resize browser a bit narrower. Should see overflow.
SetBrowserWidth(overflow_threshold_width() - 1);
EXPECT_TRUE(overflow_button()->GetVisible());
EXPECT_EQ(1, user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowButtonShown"));
EXPECT_EQ(0, user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowButtonHidden"));
// Resize browser back to threshold width. Should not see overflow.
SetBrowserWidth(overflow_threshold_width());
EXPECT_FALSE(overflow_button()->GetVisible());
EXPECT_EQ(1, user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowButtonHidden"));
}
// TODO(crbug.com/41495158): Flaky on Windows.
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_CHROMEOS)
#define MAYBE_StartBrowserWithWidthSmallerThanThreshold \
DISABLED_StartBrowserWithWidthSmallerThanThreshold
#else
#define MAYBE_StartBrowserWithWidthSmallerThanThreshold \
StartBrowserWithWidthSmallerThanThreshold
#endif
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
MAYBE_StartBrowserWithWidthSmallerThanThreshold) {
// Start browser with a smaller width than threshold. Should see overflow.
SetBrowserWidth(overflow_threshold_width() - 1);
EXPECT_TRUE(overflow_button()->GetVisible());
// Resize browser wider to threshold width. Should not see overflow.
SetBrowserWidth(overflow_threshold_width());
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser a bit narrower. Should see overflow.
SetBrowserWidth(overflow_threshold_width() - 1);
EXPECT_TRUE(overflow_button()->GetVisible());
// Keep resizing browser narrower. Should see overflow.
SetBrowserWidth(overflow_threshold_width() - 2);
EXPECT_TRUE(overflow_button()->GetVisible());
// Resize browser a bit wider. Should still see overflow.
SetBrowserWidth(overflow_threshold_width() - 1);
EXPECT_TRUE(overflow_button()->GetVisible());
}
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
StartBrowserWithWidthLargerThanThreshold) {
// Start browser with a larger width than threshold. Should not see overflow.
SetBrowserWidth(overflow_threshold_width() + 1);
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser wider. Should not see overflow.
SetBrowserWidth(overflow_threshold_width() + 2);
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser a bit narrower. Should not see overflow.
SetBrowserWidth(overflow_threshold_width() + 1);
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser back to threshold width. Should not see overflow.
SetBrowserWidth(overflow_threshold_width());
EXPECT_FALSE(overflow_button()->GetVisible());
// Resize browser a bit wider. Should not see overflow.
SetBrowserWidth(overflow_threshold_width() + 1);
EXPECT_FALSE(overflow_button()->GetVisible());
}
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest, MenuMatchesOverflowedElements) {
RunTestSequence(
Do([this]() { SetBrowserWidth(overflow_threshold_width() - 1); }),
WaitForShow(kToolbarOverflowButtonElementId),
PressButton(kToolbarOverflowButtonElementId),
CheckMenuMatchesOverflowedElements());
}
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest, ActivateActionElementFromMenu) {
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kPrimaryTabPageElementId);
const auto back_url = embedded_test_server()->GetURL("/back");
const auto forward_url = embedded_test_server()->GetURL("/forward");
base::UserActionTester user_action_tester;
EXPECT_EQ(0, user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowButtonActivated"));
EXPECT_EQ(0, user_action_tester.GetActionCount(
"ResponsiveToolbar.MenuItemActivated.ForwardButton"));
RunTestSequence(
InstrumentTab(kPrimaryTabPageElementId),
NavigateWebContents(kPrimaryTabPageElementId, back_url),
NavigateWebContents(kPrimaryTabPageElementId, forward_url),
PressButton(kToolbarBackButtonElementId),
WaitForWebContentsNavigation(kPrimaryTabPageElementId, back_url),
ForceForwardButtonOverflow(),
PressButton(kToolbarOverflowButtonElementId),
ActivateMenuItemWithElementId(kToolbarForwardButtonElementId),
// Forward navigation is triggered after activating menu item.
WaitForWebContentsNavigation(kPrimaryTabPageElementId, forward_url));
EXPECT_EQ(1, user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowButtonActivated"));
EXPECT_EQ(1,
user_action_tester.GetActionCount(
"ResponsiveToolbar.OverflowMenuItemActivated.ForwardButton"));
}
// TODO(crbug/361296257): ActionItemsOverflowAndReappear is flaky on
// linux64-rel-ready.
#if BUILDFLAG(IS_LINUX)
#define MAYBE_ActionItemsOverflowAndReappear \
DISABLED_ActionItemsOverflowAndReappear
#else
#define MAYBE_ActionItemsOverflowAndReappear ActionItemsOverflowAndReappear
#endif
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
MAYBE_ActionItemsOverflowAndReappear) {
RunTestSequence(PinBookmarkToToolbar(),
// Pinned bookmark button is visible.
CheckActionItemOverflowed(
ChromeActionIds::kActionSidePanelShowBookmarks, false),
AddDummyButtonsToToolbarTillElementOverflows(
ChromeActionIds::kActionSidePanelShowBookmarks),
// Set browser wider; action item reappears.
RestoreBrowserWidth(),
WaitForShow(kPinnedToolbarActionsContainerElementId),
CheckActionItemOverflowed(
ChromeActionIds::kActionSidePanelShowBookmarks, false));
}
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
ActionItemsShowInMenuAndActivateFromMenu) {
RunTestSequence(PinBookmarkToToolbar(),
AddDummyButtonsToToolbarTillElementOverflows(
ChromeActionIds::kActionSidePanelShowBookmarks),
PressButton(kToolbarOverflowButtonElementId),
CheckMenuMatchesOverflowedElements(),
// Check bookmark menu item is activated correctly.
ActivateMenuItemWithElementId(
ChromeActionIds::kActionSidePanelShowBookmarks),
WaitForShow(kSidePanelElementId), Check([this]() {
auto* coordinator =
browser()->GetFeatures().side_panel_coordinator();
return coordinator->IsSidePanelEntryShowing(
SidePanelEntry::Key(SidePanelEntry::Id::kBookmarks));
}));
}
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
ActivatedActionItemsDoNotOverflow) {
RunTestSequence(
PinBookmarkToToolbar(),
CheckActionItemOverflowed(ChromeActionIds::kActionSidePanelShowBookmarks,
false),
EnsureNotPresent(kSidePanelElementId),
// Open bookmark side panel.
Do([=, this]() {
chrome::ExecuteCommand(browser(), IDC_SHOW_BOOKMARK_SIDE_PANEL);
}),
WaitForShow(kSidePanelElementId), ForceForwardButtonOverflow(),
// Activated bookmark button is still visible because side panel is open
// even though it should overflow earlier than forward button.
CheckActionItemOverflowed(ChromeActionIds::kActionSidePanelShowBookmarks,
false),
// Set browser wider; still no overflow.
RestoreBrowserWidth(),
CheckActionItemOverflowed(ChromeActionIds::kActionSidePanelShowBookmarks,
false));
}
// TODO(crbug.com/41495158): Flaky on multiple platforms.
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
DISABLED_DeactivatedActionItemsOverflow) {
RunTestSequence(PinBookmarkToToolbar(),
AddDummyButtonsToToolbarTillElementOverflows(
ChromeActionIds::kActionSidePanelShowBookmarks),
PressButton(kToolbarOverflowButtonElementId),
ActivateMenuItemWithElementId(
ChromeActionIds::kActionSidePanelShowBookmarks),
WaitForShow(kSidePanelElementId),
// Close bookmark side panel.
PressButton(kSidePanelCloseButtonElementId),
WaitForHide(kSidePanelElementId),
// Pinned button overflows after side panel is closed.
CheckActionItemOverflowed(
ChromeActionIds::kActionSidePanelShowBookmarks, true));
}
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
EveryElementHasActionMetricName) {
for (auto& it : ToolbarController::GetDefaultResponsiveElements(browser())) {
std::visit(
base::Overloaded(
[](actions::ActionId id) {
EXPECT_NE(
ToolbarController::GetActionNameFromElementIdentifier(id), "")
<< "Missing metric name for ActionId: " << id;
},
[&](ToolbarController::ElementIdInfo id) {
EXPECT_NE(ToolbarController::GetActionNameFromElementIdentifier(
id.activate_identifier),
"")
<< "Missing metric name for ElementIdentifier: "
<< id.activate_identifier;
}),
it.overflow_id);
}
}
// Verify fixing animation loop bug (crbug.com/).
// Steps to reproduce:
// 1 Set browser with to a big value that nothing should overflow.
// 2. Have 1 pinned extension button in extensions container.
// 3. Have 2 pinned buttons in pinned toolbar container.
// 4. Set browser width to when PinnedToolbarContainer starts to overflow. In
// this case both pinned buttons in PinnedToolbarContainer should overflow,
// overflow button should show. Verify: The pinned extension button should still
// be visible because there's enough space for it. Extensions container should
// not have animation because its visibility didn't change.
// TODO(crbug.com/41495158): Flaky on Windows and Mac.
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
#define MAYBE_ExtensionHasNoAnimationLoop DISABLED_ExtensionHasNoAnimationLoop
#else
#define MAYBE_ExtensionHasNoAnimationLoop ExtensionHasNoAnimationLoop
#endif
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
MAYBE_ExtensionHasNoAnimationLoop) {
RunTestSequence(
LoadAndPinExtensionButton(), PinBookmarkToToolbar(),
PinReadingModeToToolbar(), Do([this]() {
SetBrowserWidth(GetOverflowThresholdWidthInPinnedSidePanelContainer() -
1);
}),
WaitForShow(kToolbarOverflowButtonElementId));
EXPECT_FALSE(BrowserView::GetBrowserViewForBrowser(browser())
->toolbar()
->extensions_container()
->GetAnimatingLayoutManager()
->is_animating());
}
// TODO(crbug.com/41495158): Flaky on Windows.
#if BUILDFLAG(IS_WIN)
#define MAYBE_DoNotShowIphWhenOverflowed DISABLED_DoNotShowIphWhenOverflowed
#else
#define MAYBE_DoNotShowIphWhenOverflowed DoNotShowIphWhenOverflowed
#endif
IN_PROC_BROWSER_TEST_F(ToolbarControllerUiTest,
MAYBE_DoNotShowIphWhenOverflowed) {
RunTestSequence(
ResizeRelativeToOverflow(-1),
MaybeShowPromo(feature_engagement::kIPHMemorySaverModeFeature,
user_education::FeaturePromoResult::kWindowTooSmall),
ResizeRelativeToOverflow(1),
MaybeShowPromo(feature_engagement::kIPHMemorySaverModeFeature),
PressClosePromoButton());
}
|