1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/translate/partial_translate_bubble_view.h"
#include "base/memory/raw_ptr.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/ui/translate/partial_translate_bubble_model.h"
#include "chrome/browser/ui/translate/partial_translate_bubble_ui_action_logger.h"
#include "chrome/test/views/chrome_views_test_base.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/actions/actions.h"
#include "ui/events/event.h"
#include "ui/events/keycodes/dom/dom_code.h"
#include "ui/views/test/button_test_api.h"
#include "ui/views/widget/widget.h"
namespace {
class FakePartialTranslateBubbleModel : public PartialTranslateBubbleModel {
public:
explicit FakePartialTranslateBubbleModel(
PartialTranslateBubbleModel::ViewState view_state) {
DCHECK_NE(VIEW_STATE_SOURCE_LANGUAGE, view_state);
DCHECK_NE(VIEW_STATE_TARGET_LANGUAGE, view_state);
current_view_state_ = view_state;
}
void AddObserver(PartialTranslateBubbleModel::Observer* observer) override {}
void RemoveObserver(
PartialTranslateBubbleModel::Observer* observer) override {}
PartialTranslateBubbleModel::ViewState GetViewState() const override {
return current_view_state_;
}
void SetViewState(
PartialTranslateBubbleModel::ViewState view_state) override {
current_view_state_ = view_state;
}
void SetSourceLanguage(const std::string& language_code) override {}
void SetTargetLanguage(const std::string& language_code) override {}
void SetSourceText(const std::u16string& text) override {}
std::u16string GetSourceText() const override { return u"source"; }
void SetTargetText(const std::u16string& text) override {}
std::u16string GetTargetText() const override { return u"target"; }
void SetError(translate::TranslateErrors error_type) override {}
translate::TranslateErrors GetError() const override {
return translate::TranslateErrors::NONE;
}
int GetNumberOfSourceLanguages() const override { return 1000; }
int GetNumberOfTargetLanguages() const override { return 1000; }
std::u16string GetSourceLanguageNameAt(int index) const override {
return source_name_;
}
std::u16string GetTargetLanguageNameAt(int index) const override {
return target_name_;
}
int GetSourceLanguageIndex() const override { return 1; }
void UpdateSourceLanguageIndex(int index) override {}
int GetTargetLanguageIndex() const override { return 2; }
void UpdateTargetLanguageIndex(int index) override {}
std::string GetSourceLanguageCode() const override { return "en"; }
std::string GetTargetLanguageCode() const override { return "en"; }
void Translate(content::WebContents* web_contents) override {
translate_called_ = true;
}
void TranslateFullPage(content::WebContents* web_contents) override {
full_page_translate_called_ = true;
}
void SetSourceTextTruncated(bool is_truncated) override {}
ViewState current_view_state_;
std::u16string source_name_ = u"English";
std::u16string target_name_ = u"English";
bool translate_called_ = false;
bool full_page_translate_called_ = false;
};
} // namespace
class PartialTranslateBubbleViewTest : public ChromeViewsTestBase {
public:
PartialTranslateBubbleViewTest() = default;
protected:
void SetUp() override {
ChromeViewsTestBase::SetUp();
// The bubble needs the parent as an anchor.
anchor_widget_ =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET,
views::Widget::InitParams::TYPE_WINDOW);
anchor_widget_->Show();
mock_model_ = new FakePartialTranslateBubbleModel(
PartialTranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE);
action_item_ = actions::ActionItem::Builder().SetActionId(0).Build();
}
void CreateAndShowBubble() {
std::unique_ptr<PartialTranslateBubbleModel> model(mock_model_);
bubble_ = new PartialTranslateBubbleView(
action_item_->GetAsWeakPtr(), anchor_widget_->GetContentsView(),
std::move(model), nullptr, base::DoNothing());
views::BubbleDialogDelegateView::CreateBubble(bubble_)->Show();
}
void PressButton(PartialTranslateBubbleView::ButtonID id) {
views::Button* button =
static_cast<views::Button*>(bubble_->GetViewByID(id));
ui::KeyEvent key_event(ui::EventType::kKeyPressed, ui::VKEY_RETURN,
ui::DomCode::ENTER, ui::EF_NONE);
views::test::ButtonTestApi(button).NotifyClick(key_event);
}
void TearDown() override {
if (bubble_) {
bubble_->GetWidget()->CloseNow();
}
anchor_widget_.reset();
ChromeViewsTestBase::TearDown();
}
std::unique_ptr<views::Widget> anchor_widget_;
raw_ptr<FakePartialTranslateBubbleModel, DanglingUntriaged> mock_model_;
raw_ptr<PartialTranslateBubbleView, DanglingUntriaged> bubble_;
std::unique_ptr<actions::ActionItem> action_item_;
};
TEST_F(PartialTranslateBubbleViewTest,
TargetLanguageTabDoesntTriggerTranslate) {
base::HistogramTester histogram_tester;
CreateAndShowBubble();
EXPECT_FALSE(mock_model_->translate_called_);
// Press the target language tab to start translation.
bubble_->TabSelectedAt(1);
EXPECT_FALSE(mock_model_->translate_called_);
histogram_tester.ExpectUniqueSample(
translate::kPartialTranslateBubbleUiEventHistogramName,
translate::PartialTranslateBubbleUiEvent::TARGET_LANGUAGE_TAB_SELECTED,
1);
}
TEST_F(PartialTranslateBubbleViewTest, TabSelectedAfterTranslation) {
CreateAndShowBubble();
EXPECT_EQ(bubble_->tabbed_pane_->GetSelectedTabIndex(),
static_cast<size_t>(0));
bubble_->SwitchView(PartialTranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE);
EXPECT_EQ(bubble_->tabbed_pane_->GetSelectedTabIndex(),
static_cast<size_t>(1));
}
TEST_F(PartialTranslateBubbleViewTest, UpdateLanguageTabsFromResponse) {
CreateAndShowBubble();
EXPECT_EQ(bubble_->tabbed_pane_->GetTabAt(0)->GetTitleText(), u"English");
EXPECT_EQ(bubble_->tabbed_pane_->GetTabAt(1)->GetTitleText(), u"English");
mock_model_->source_name_ = u"Japanese";
mock_model_->target_name_ = u"French";
bubble_->SwitchView(PartialTranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE);
EXPECT_EQ(bubble_->tabbed_pane_->GetTabAt(0)->GetTitleText(), u"Japanese");
EXPECT_EQ(bubble_->tabbed_pane_->GetTabAt(1)->GetTitleText(), u"French");
}
TEST_F(PartialTranslateBubbleViewTest, SourceLanguageTabUpdatesViewState) {
CreateAndShowBubble();
// Select target language tab to translate.
bubble_->TabSelectedAt(1);
EXPECT_EQ(PartialTranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE,
bubble_->GetViewState());
// Select source language tab to revert translation.
bubble_->TabSelectedAt(0);
EXPECT_EQ(PartialTranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
bubble_->GetViewState());
}
// TODO(crbug.com/40848161): For some reason calling bubble_->TabSelectedAt(1)
// before bubble_->TabSelectedAt(0) in a test causes TabSelectedAt(0) to be
// run twice, resulting in the corresponding sample being logged twice. This
// does not happen in production. For now, test this logging separately to avoid
// encountering this issue in TabSelectedAfterTranslation.
TEST_F(PartialTranslateBubbleViewTest, SourceLanguageTabSelectedLogged) {
base::HistogramTester histogram_tester;
CreateAndShowBubble();
bubble_->TabSelectedAt(0);
histogram_tester.ExpectBucketCount(
translate::kPartialTranslateBubbleUiEventHistogramName,
translate::PartialTranslateBubbleUiEvent::SOURCE_LANGUAGE_TAB_SELECTED,
1);
}
TEST_F(PartialTranslateBubbleViewTest, TranslateFullPageButton) {
CreateAndShowBubble();
PressButton(PartialTranslateBubbleView::BUTTON_ID_FULL_PAGE_TRANSLATE);
EXPECT_TRUE(mock_model_->full_page_translate_called_);
}
TEST_F(PartialTranslateBubbleViewTest, ActionItemUpdatesWithBubbleLifetime) {
EXPECT_FALSE(action_item_->GetIsShowingBubble());
CreateAndShowBubble();
EXPECT_TRUE(action_item_->GetIsShowingBubble());
bubble_->GetWidget()->CloseNow();
EXPECT_FALSE(action_item_->GetIsShowingBubble());
bubble_ = nullptr;
}
|