1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <optional>
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/test_future.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/browser/ui/views/web_apps/web_app_uninstall_dialog_view.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/ui/web_applications/web_app_browsertest_base.h"
#include "chrome/browser/web_applications/mojom/user_display_mode.mojom.h"
#include "chrome/browser/web_applications/os_integration/os_integration_manager.h"
#include "chrome/browser/web_applications/test/web_app_icon_test_utils.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/browser/web_applications/web_app_ui_manager.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/keep_alive_registry/keep_alive_types.h"
#include "components/keep_alive_registry/scoped_keep_alive.h"
#include "components/webapps/browser/installable/installable_metrics.h"
#include "components/webapps/browser/uninstall_result_code.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_dialog_auto_confirm.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/widget/any_widget_observer.h"
using webapps::AppId;
namespace {
webapps::AppId InstallTestWebApp(Profile* profile) {
const GURL example_url = GURL("http://example.org/");
auto web_app_info =
web_app::WebAppInstallInfo::CreateWithStartUrlForTesting(example_url);
web_app_info->scope = example_url;
web_app_info->user_display_mode =
web_app::mojom::UserDisplayMode::kStandalone;
return web_app::test::InstallWebApp(profile, std::move(web_app_info));
}
} // namespace
class WebAppUninstallDialogViewBrowserTest
: public web_app::WebAppBrowserTestBase {
public:
web_app::WebAppProvider* provider() {
return web_app::WebAppProvider::GetForTest(browser()->profile());
}
};
IN_PROC_BROWSER_TEST_F(WebAppUninstallDialogViewBrowserTest,
TrackParentWindowDestructionAfterViewCreation) {
webapps::AppId app_id = InstallTestWebApp(browser()->profile());
base::test::TestFuture<webapps::UninstallResultCode> test_future;
provider()->ui_manager().PresentUserUninstallDialog(
app_id, webapps::WebappUninstallSource::kAppMenu,
browser()->window()->GetNativeWindow(), test_future.GetCallback());
views::NamedWidgetShownWaiter uninstall_dialog_waiter(
views::test::AnyWidgetTestPasskey{}, "WebAppUninstallDialogDelegateView");
auto* uninstall_widget = uninstall_dialog_waiter.WaitIfNeededAndGet();
EXPECT_NE(uninstall_widget, nullptr);
// Kill parent window.
browser()->window()->Close();
EXPECT_TRUE(test_future.Wait());
EXPECT_EQ(test_future.Get<webapps::UninstallResultCode>(),
webapps::UninstallResultCode::kCancelled);
}
// Uninstalling with no browser window open can cause the view to be destroyed
// before the views object. Test that this does not cause a UAF. See
// https://crbug.com/1150798.
// Also tests that we don't crash when uninstalling a web app from a web app
// window in Ash. See https://crbug.com/825554.
IN_PROC_BROWSER_TEST_F(WebAppUninstallDialogViewBrowserTest,
TrackParentWindowDestructionBeforeViewCreation) {
extensions::ScopedTestDialogAutoConfirm auto_confirm(
extensions::ScopedTestDialogAutoConfirm::ACCEPT);
webapps::AppId app_id = InstallTestWebApp(browser()->profile());
Browser* app_browser =
web_app::LaunchWebAppBrowser(browser()->profile(), app_id);
ASSERT_TRUE(app_browser);
EXPECT_NE(app_browser, browser());
chrome::CloseWindow(browser());
base::test::TestFuture<webapps::UninstallResultCode> test_future;
provider()->ui_manager().PresentUserUninstallDialog(
app_id, webapps::WebappUninstallSource::kAppMenu,
app_browser->window()->GetNativeWindow(), test_future.GetCallback());
EXPECT_TRUE(test_future.Wait());
EXPECT_EQ(test_future.Get<webapps::UninstallResultCode>(),
webapps::UninstallResultCode::kAppRemoved);
}
IN_PROC_BROWSER_TEST_F(WebAppUninstallDialogViewBrowserTest,
TestDialogUserFlow_Cancel) {
extensions::ScopedTestDialogAutoConfirm auto_confirm(
extensions::ScopedTestDialogAutoConfirm::CANCEL);
webapps::AppId app_id = InstallTestWebApp(browser()->profile());
base::test::TestFuture<webapps::UninstallResultCode> test_future;
provider()->ui_manager().PresentUserUninstallDialog(
app_id, webapps::WebappUninstallSource::kAppMenu,
browser()->window()->GetNativeWindow(), test_future.GetCallback());
EXPECT_TRUE(test_future.Wait());
EXPECT_EQ(test_future.Get<webapps::UninstallResultCode>(),
webapps::UninstallResultCode::kCancelled);
}
IN_PROC_BROWSER_TEST_F(WebAppUninstallDialogViewBrowserTest,
TestDialogUserFlow_Accept) {
extensions::ScopedTestDialogAutoConfirm auto_confirm(
extensions::ScopedTestDialogAutoConfirm::ACCEPT_AND_OPTION);
webapps::AppId app_id = InstallTestWebApp(browser()->profile());
base::test::TestFuture<webapps::UninstallResultCode> test_future;
provider()->ui_manager().PresentUserUninstallDialog(
app_id, webapps::WebappUninstallSource::kAppMenu,
browser()->window()->GetNativeWindow(), test_future.GetCallback());
EXPECT_TRUE(test_future.Wait());
EXPECT_EQ(test_future.Get<webapps::UninstallResultCode>(),
webapps::UninstallResultCode::kAppRemoved);
}
|
