1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/webui/ash/app_install/app_install_dialog.h"
#include "base/strings/strcat.h"
#include "base/strings/string_util.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "chrome/browser/apps/almanac_api_client/almanac_api_util.h"
#include "chrome/browser/apps/app_service/app_install/app_install.pb.h"
#include "chrome/browser/apps/app_service/app_install/app_install_service.h"
#include "chrome/browser/apps/app_service/app_install/test_app_install_server.h"
#include "chrome/browser/apps/app_service/app_registry_cache_waiter.h"
#include "chrome/browser/apps/app_service/app_service_proxy.h"
#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/web_applications/app_browser_controller.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/ui/web_applications/web_app_dialog_utils.h"
#include "chrome/browser/ui/webui/ash/app_install/app_install_dialog_test_helpers.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app_command_scheduler.h"
#include "chrome/browser/web_applications/web_app_helpers.h"
#include "chrome/browser/web_applications/web_app_install_params.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/test/base/chrome_test_utils.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "chromeos/constants/chromeos_features.h"
#include "components/services/app_service/public/cpp/package_id.h"
#include "components/webapps/browser/installable/installable_metrics.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
namespace ash::app_install {
class AppInstallDialogBrowserTest : public InProcessBrowserTest {
public:
void SetUpOnMainThread() override {
ASSERT_TRUE(app_install_server_.SetUp());
}
void SetUpAlmanacPayload(const char* app_url) {
std::string package_id = base::StrCat({"web:", app_url});
apps::proto::AppInstallResponse response;
apps::proto::AppInstallResponse_AppInstance& instance =
*response.mutable_app_instance();
instance.set_package_id(package_id);
instance.set_name("Test app");
apps::proto::AppInstallResponse_WebExtras& web_extras =
*instance.mutable_web_extras();
web_extras.set_document_url(app_url);
web_extras.set_original_manifest_url(app_url);
web_extras.set_scs_url(app_url);
auto http_response =
std::make_unique<net::test_server::BasicHttpResponse>();
http_response->set_code(net::HTTP_OK);
http_response->set_content(response.SerializeAsString());
app_install_server_.SetUpResponse(package_id, response);
}
apps::TestAppInstallServer* app_install_server() {
return &app_install_server_;
}
private:
apps::TestAppInstallServer app_install_server_;
};
IN_PROC_BROWSER_TEST_F(AppInstallDialogBrowserTest, InstallApp) {
const GURL app_url(app_install_server()->GetUrl("/web_apps/basic.html"));
ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete(
browser(), app_url, 1, WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
content::TestNavigationObserver navigation_observer_dialog(
(GURL(chrome::kChromeUIAppInstallDialogURL)));
navigation_observer_dialog.StartWatchingNewWebContents();
base::WeakPtr<AppInstallDialog> dialog_handle =
AppInstallDialog::CreateDialog();
base::test::TestFuture<bool> dialog_accepted_future;
dialog_handle->ShowApp(
browser()->profile(),
/*parent=*/browser()->window()->GetNativeWindow(),
apps::PackageId(apps::PackageType::kWeb, app_url.spec()),
/*app_name=*/"Test app",
/*app_url=*/app_url,
/*app_description=*/"",
/*icon=*/std::nullopt,
/*screenshots=*/{},
/*dialog_accepted_callback=*/dialog_accepted_future.GetCallback());
navigation_observer_dialog.Wait();
ASSERT_TRUE(navigation_observer_dialog.last_navigation_succeeded());
content::WebContents* web_contents = GetWebContentsFromDialog();
EXPECT_TRUE(
base::StartsWith(GetDialogTitle(web_contents), "Install app on your"));
// Click the install button.
while (GetDialogActionButton(web_contents) != "Install")
;
EXPECT_TRUE(ClickDialogActionButton(web_contents));
// Make sure the button goes through the 'Installing' state.
while (GetDialogActionButton(web_contents) != "Installing")
;
EXPECT_TRUE(base::StartsWith(GetDialogTitle(web_contents), "Installing app"));
// Check the dialog_accepted callback was run.
EXPECT_TRUE(dialog_accepted_future.Get<bool>());
// Install the app.
web_app::InstallWebAppFromPageAndCloseAppBrowser(browser(), app_url);
dialog_handle->SetInstallSucceeded();
// Wait for the button text to say "Open app", which means it knows the app
// was installed successfully.
while (GetDialogActionButton(web_contents) != "Open app")
;
EXPECT_EQ(GetDialogTitle(web_contents), "App installed");
// Click the open app button and expect the dialog was closed.
content::WebContentsDestroyedWatcher watcher(web_contents);
EXPECT_TRUE(ClickDialogActionButton(web_contents));
watcher.Wait();
// Expect the app is opened.
webapps::AppId app_id = web_app::GenerateAppIdFromManifestId(app_url);
Browser* app_browser = BrowserList::GetInstance()->GetLastActive();
EXPECT_TRUE(web_app::AppBrowserController::IsForWebApp(app_browser, app_id));
// Expect the browser tab was not closed.
EXPECT_EQ(
browser()->tab_strip_model()->GetActiveWebContents()->GetVisibleURL(),
app_url);
}
IN_PROC_BROWSER_TEST_F(AppInstallDialogBrowserTest, AlreadyInstalled) {
constexpr char kAppUrl[] = "https://example.org/";
webapps::AppId app_id = web_app::GenerateAppIdFromManifestId(GURL(kAppUrl));
SetUpAlmanacPayload(kAppUrl);
web_app::test::InstallDummyWebApp(browser()->profile(), "Test app",
GURL(kAppUrl));
apps::AppReadinessWaiter(browser()->profile(), app_id).Await();
content::TestNavigationObserver navigation_observer_dialog(
(GURL(chrome::kChromeUIAppInstallDialogURL)));
navigation_observer_dialog.StartWatchingNewWebContents();
auto* proxy =
apps::AppServiceProxyFactory::GetForProfile(browser()->profile());
proxy->AppInstallService().InstallApp(
apps::AppInstallSurface::kAppInstallUriUnknown,
apps::PackageId(apps::PackageType::kWeb, kAppUrl),
/*anchor_window=*/std::nullopt,
/*callback=*/base::DoNothing());
navigation_observer_dialog.Wait();
ASSERT_TRUE(navigation_observer_dialog.last_navigation_succeeded());
content::WebContents* web_contents = GetWebContentsFromDialog();
EXPECT_EQ(GetDialogTitle(web_contents), "App is already installed");
EXPECT_EQ(GetDialogActionButton(web_contents), "Open app");
// Click the open app button and expect the dialog was closed.
content::WebContentsDestroyedWatcher watcher(web_contents);
EXPECT_TRUE(ClickDialogActionButton(web_contents));
watcher.Wait();
// Expect the app is opened.
Browser* app_browser = BrowserList::GetInstance()->GetLastActive();
EXPECT_TRUE(web_app::AppBrowserController::IsForWebApp(app_browser, app_id));
}
IN_PROC_BROWSER_TEST_F(AppInstallDialogBrowserTest, FailedInstall) {
content::TestNavigationObserver navigation_observer_dialog(
(GURL(chrome::kChromeUIAppInstallDialogURL)));
navigation_observer_dialog.StartWatchingNewWebContents();
base::WeakPtr<AppInstallDialog> dialog_handle =
AppInstallDialog::CreateDialog();
// TODO(b/331310950): Add a test that sends a retry callback.
constexpr char kAppUrl[] = "https://example.org/";
dialog_handle->ShowApp(
browser()->profile(),
/*parent=*/browser()->window()->GetNativeWindow(),
apps::PackageId(apps::PackageType::kWeb, kAppUrl),
/*app_name=*/"Test app",
/*app_url=*/GURL(kAppUrl),
/*app_description=*/"",
/*icon=*/std::nullopt,
/*screenshots=*/{},
base::BindOnce(
[](base::WeakPtr<AppInstallDialog> dialog_handle,
bool dialog_accepted) {
dialog_handle->SetInstallFailed(base::DoNothing());
},
dialog_handle));
navigation_observer_dialog.Wait();
ASSERT_TRUE(navigation_observer_dialog.last_navigation_succeeded());
content::WebContents* web_contents = GetWebContentsFromDialog();
// Click the install button.
while (GetDialogActionButton(web_contents) != "Install")
;
EXPECT_TRUE(ClickDialogActionButton(web_contents));
// Make sure the button goes through the 'Installing' state.
while (GetDialogActionButton(web_contents) != "Installing")
;
// Wait for the button text to say "Try again".
while (GetDialogActionButton(web_contents) != "Try again")
;
EXPECT_EQ(GetDialogTitle(web_contents),
"Can't install app. Something went wrong.");
}
IN_PROC_BROWSER_TEST_F(AppInstallDialogBrowserTest, NoAppError) {
content::TestNavigationObserver navigation_observer_dialog(
(GURL(chrome::kChromeUIAppInstallDialogURL)));
navigation_observer_dialog.StartWatchingNewWebContents();
apps::PackageId package_id(apps::PackageType::kWeb, "invalid");
app_install_server()->SetUpResponseCode(package_id, net::HTTP_NOT_FOUND);
auto* proxy =
apps::AppServiceProxyFactory::GetForProfile(browser()->profile());
proxy->AppInstallService().InstallApp(
apps::AppInstallSurface::kAppInstallUriUnknown, package_id,
/*anchor_window=*/std::nullopt,
/*callback=*/base::DoNothing());
navigation_observer_dialog.Wait();
ASSERT_TRUE(navigation_observer_dialog.last_navigation_succeeded());
content::WebContents* web_contents = GetWebContentsFromDialog();
EXPECT_EQ(GetDialogTitle(web_contents), "App not available");
EXPECT_EQ(GetDialogActionButton(web_contents), std::nullopt);
}
IN_PROC_BROWSER_TEST_F(AppInstallDialogBrowserTest, ConnectionError) {
content::TestNavigationObserver navigation_observer_dialog(
(GURL(chrome::kChromeUIAppInstallDialogURL)));
navigation_observer_dialog.StartWatchingNewWebContents();
apps::PackageId package_id(apps::PackageType::kWeb, "invalid");
app_install_server()->SetUpResponseCode(package_id,
net::HTTP_INTERNAL_SERVER_ERROR);
auto* proxy =
apps::AppServiceProxyFactory::GetForProfile(browser()->profile());
proxy->AppInstallService().InstallApp(
apps::AppInstallSurface::kAppInstallUriUnknown, package_id,
/*anchor_window=*/std::nullopt,
/*callback=*/base::DoNothing());
navigation_observer_dialog.Wait();
ASSERT_TRUE(navigation_observer_dialog.last_navigation_succeeded());
content::WebContents* web_contents = GetWebContentsFromDialog();
EXPECT_EQ(GetDialogTitle(web_contents), "Can't install app");
EXPECT_EQ(GetDialogActionButton(web_contents), "Try again");
}
} // namespace ash::app_install
|
