1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/webui/feedback/feedback_dialog.h"
#include <memory>
#include <utility>
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h"
#include "chrome/browser/profiles/keep_alive/profile_keep_alive_types.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/webui/feedback/feedback_handler.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/grit/generated_resources.h"
#include "content/public/browser/browser_thread.h"
#include "extensions/browser/api/feedback_private/feedback_private_api.h"
#include "extensions/common/api/feedback_private.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/mojom/ui_base_types.mojom-shared.h"
#include "ui/views/view_class_properties.h"
#include "ui/views/widget/widget.h"
#include "url/gurl.h"
using content::WebContents;
using content::WebUIMessageHandler;
namespace {
// Default width/height of the Feedback Window.
constexpr gfx::Size kDefaultSize{500, 628};
} // namespace
using extensions::api::feedback_private::FeedbackFlow;
using extensions::api::feedback_private::FeedbackInfo;
// static
FeedbackDialog* FeedbackDialog::current_instance_ = nullptr;
// static
FeedbackDialog* FeedbackDialog::GetInstanceForTest() {
return current_instance_;
}
DEFINE_CLASS_ELEMENT_IDENTIFIER_VALUE(FeedbackDialog,
kFeedbackDialogForTesting);
// static
void FeedbackDialog::CreateOrShow(
Profile* profile,
const extensions::api::feedback_private::FeedbackInfo& info) {
if (current_instance_) {
DCHECK(current_instance_->widget_);
const Profile* current_profile =
current_instance_->profile_keep_alive_.profile();
if (profile == current_profile) {
// Focus the window hosting the dialog that has already been created.
current_instance_->widget_->Show();
return;
} else {
// Close the existing window and create a new one for `profile`.
VLOG(1) << "Re-opening the feedback dialog for profile \""
<< profile->GetDebugName() << "\" (was \""
<< current_profile->GetDebugName() << "\")";
current_instance_->attached_to_current_instance_ = false;
current_instance_->widget_->Close();
}
}
// Metric should has been recorded for other request sources before
// ShowDialogAsync is being called.
if (info.flow == extensions::api::feedback_private::FeedbackFlow::kLogin) {
UMA_HISTOGRAM_ENUMERATION("Feedback.RequestSource",
feedback::kFeedbackSourceLogin,
feedback::kFeedbackSourceCount);
}
current_instance_ = new FeedbackDialog(profile, info);
gfx::NativeWindow window =
chrome::ShowWebDialog(gfx::NativeView(), profile, current_instance_,
/*show=*/false);
current_instance_->widget_ = views::Widget::GetWidgetForNativeWindow(window);
views::View* root = current_instance_->widget_->GetRootView();
if (root != nullptr) {
root->SetProperty(views::kElementIdentifierKey, kFeedbackDialogForTesting);
}
}
FeedbackDialog::FeedbackDialog(
Profile* profile,
const extensions::api::feedback_private::FeedbackInfo& info)
: widget_(nullptr),
// We need to use GetOriginalProfile() here because `profile` may be an
// OTR Profile (when opening Feedback dialog on ChromeOS login screen, for
// example), and ScopedProfileKeepAlive only supports non-OTR Profiles.
// Trying to acquire a keepalive on the OTR Profile would trigger a
// DCHECK.
//
// TODO(crbug.com/40159237): Once OTR Profiles use refcounting, remove the
// call to GetOriginalProfile(). The OTR Profile will hold a keepalive on
// the regular Profile, so the ownership model will be more
// straightforward.
profile_keep_alive_(profile->GetOriginalProfile(),
ProfileKeepAliveOrigin::kFeedbackDialog) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
set_can_close(true);
set_can_resize(false);
set_can_minimize(true);
set_dialog_args(base::WriteJson(info.ToValue()).value());
set_dialog_content_url(GURL(chrome::kChromeUIFeedbackURL));
// On the login screen, set to Modal mode. Otherwise, this is not visible.
// For other cases, set to none Modal mode so the user can navigate to
// other windows.
set_dialog_modal_type(info.flow == FeedbackFlow::kLogin
? ui::mojom::ModalType::kSystem
: ui::mojom::ModalType::kNone);
set_dialog_size(kDefaultSize);
set_dialog_title(l10n_util::GetStringUTF16(
info.flow == FeedbackFlow::kSadTabCrash
? IDS_FEEDBACK_REPORT_PAGE_TITLE_SAD_TAB_FLOW
: IDS_FEEDBACK_REPORT_PAGE_TITLE));
set_show_dialog_title(true);
AddWebUIMessageHandler(
std::make_unique<FeedbackHandler>(weak_ptr_factory_.GetWeakPtr()));
}
FeedbackDialog::~FeedbackDialog() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (attached_to_current_instance_) {
current_instance_ = nullptr;
}
}
void FeedbackDialog::Show() const {
// The widget_ is set to null when the FeedbackDialog is constructed.
// After the following two function calls, it is finally initialized.
// Therefore, it is safer to check whether the widget_ is null
if (this->widget_) {
this->widget_->Show();
}
}
views::Widget* FeedbackDialog::GetWidget() const {
return this->widget_;
}
void FeedbackDialog::RequestMediaAccessPermission(
content::WebContents* web_contents,
const content::MediaStreamRequest& request,
content::MediaResponseCallback callback) {
MediaCaptureDevicesDispatcher::GetInstance()->ProcessMediaAccessRequest(
web_contents, request, std::move(callback), nullptr /* extension */);
}
bool FeedbackDialog::CheckMediaAccessPermission(
content::RenderFrameHost* render_frame_host,
const url::Origin& security_origin,
blink::mojom::MediaStreamType type) {
return true;
}
|
