1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <set>
#include "base/containers/contains.h"
#include "base/stl_util.h"
#include "base/test/mock_callback.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/search/ntp_features.h"
#include "content/public/browser/child_process_id.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/spare_render_process_host_manager.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "net/dns/mock_host_resolver.h"
namespace {
// Observes TabStripModelChange::kRemoved notifications and records the
// WebContents remove reason and the TabModel detach reason.
class WebContentsRemovedObserver : public TabStripModelObserver {
public:
WebContentsRemovedObserver() = default;
WebContentsRemovedObserver(const WebContentsRemovedObserver&) = delete;
WebContentsRemovedObserver& operator=(const WebContentsRemovedObserver&) =
delete;
~WebContentsRemovedObserver() override = default;
// TabStripModelObserver:
void OnTabStripModelChanged(
TabStripModel* tab_strip_model,
const TabStripModelChange& change,
const TabStripSelectionChange& selection) override {
if (change.type() == TabStripModelChange::kRemoved) {
const TabStripModelChange::RemovedTab& removed_tab =
change.GetRemove()->contents[0];
remove_reason_ = removed_tab.remove_reason;
tab_detach_reason_ = removed_tab.tab_detach_reason;
}
}
std::optional<TabStripModelChange::RemoveReason> remove_reason() const {
return remove_reason_;
}
std::optional<tabs::TabInterface::DetachReason> tab_detach_reason() const {
return tab_detach_reason_;
}
private:
std::optional<TabStripModelChange::RemoveReason> remove_reason_;
std::optional<tabs::TabInterface::DetachReason> tab_detach_reason_;
};
void ExpectIsWebUiNtp(content::WebContents* tab) {
EXPECT_EQ(GURL(chrome::kChromeUINewTabPageURL).spec(),
EvalJs(tab, "window.location.href",
content::EXECUTE_SCRIPT_DEFAULT_OPTIONS, /*world_id=*/1));
}
std::set<content::ChildProcessId> LiveRenderProcessHostIds() {
std::set<content::ChildProcessId> result;
for (auto iter = content::RenderProcessHost::AllHostsIterator();
!iter.IsAtEnd(); iter.Advance()) {
result.insert(iter.GetCurrentKey());
}
return result;
}
} // namespace
class WebUiNtpBrowserTest : public InProcessBrowserTest {
public:
WebUiNtpBrowserTest() = default;
~WebUiNtpBrowserTest() override = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
embedded_test_server()->ServeFilesFromSourceDirectory("content/test/data");
ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
}
void SetUpOnMainThread() override {
host_resolver()->AddRule("*", "127.0.0.1");
embedded_test_server()->StartAcceptingConnections();
}
private:
base::test::ScopedFeatureList feature_list_;
};
// Verify that the WebUI NTP commits in a SiteInstance with the WebUI URL.
IN_PROC_BROWSER_TEST_F(WebUiNtpBrowserTest, VerifySiteInstance) {
GURL ntp_url(chrome::kChromeUINewTabURL);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), ntp_url));
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_EQ(ntp_url, web_contents->GetLastCommittedURL());
GURL webui_ntp_url(chrome::kChromeUINewTabPageURL);
ASSERT_EQ(
webui_ntp_url,
web_contents->GetPrimaryMainFrame()->GetSiteInstance()->GetSiteURL());
}
// Verify that the WebUI NTP uses process-per-site.
IN_PROC_BROWSER_TEST_F(WebUiNtpBrowserTest, ProcessPerSite) {
std::vector<content::WebContents*> tabs;
// Open a few NTPs.
for (size_t i = 0; i < 3; i++) {
content::WebContentsAddedObserver tab_observer;
chrome::NewTab(browser());
// Wait for the new tab.
auto* tab = tab_observer.GetWebContents();
ASSERT_TRUE(WaitForLoadStop(tab));
// Sanity check: the NTP should be a WebUI NTP (and not chrome://newtab/ or
// some other NTP).
ExpectIsWebUiNtp(tab);
tabs.push_back(tab);
}
// Verify that all NTPs share a process.
for (size_t i = 1; i < tabs.size(); i++) {
EXPECT_EQ(tabs[0]->GetPrimaryMainFrame()->GetProcess(),
tabs[i]->GetPrimaryMainFrame()->GetProcess());
}
}
// Verify that the WebUI NTP uses an available spare process and does not
// discard it as in https://crbug.com/1094088.
IN_PROC_BROWSER_TEST_F(WebUiNtpBrowserTest, SpareRenderer) {
// Capture current spare renderer.
std::vector<content::ChildProcessId> spare_ids_before_navigation =
content::SpareRenderProcessHostManager::Get().GetSpareIds();
ASSERT_FALSE(spare_ids_before_navigation.empty());
// Note the current render processes before the navigation. These should all
// remain alive after the navigation.
const std::set<content::ChildProcessId> starting_rph_ids =
LiveRenderProcessHostIds();
// Open an NTP.
chrome::NewTab(browser());
auto* ntp = browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(WaitForLoadStop(ntp));
ExpectIsWebUiNtp(ntp);
// Check spare was taken.
EXPECT_TRUE(
base::Contains(spare_ids_before_navigation,
ntp->GetPrimaryMainFrame()->GetProcess()->GetID()));
// No processes should be unnecessarily terminated.
const std::set<content::ChildProcessId> ending_rph_ids =
LiveRenderProcessHostIds();
const std::set<content::ChildProcessId> terminated_rph_ids =
base::STLSetDifference<std::set<content::ChildProcessId>>(
starting_rph_ids, ending_rph_ids);
EXPECT_TRUE(terminated_rph_ids.empty());
}
// Currently it is possible to load the NTP absent a TabModel in an app window
// context. Assert the NTP loads without a TabModel successfully.
// TODO(crbug.com/378475391): This can be removed once an owning TabModel is
// guaranteed to be always present and fixed for the lifetime of the NTP.
IN_PROC_BROWSER_TEST_F(WebUiNtpBrowserTest, LoadsSuccessfullyWithoutTabModel) {
// Add a new about:blank tab to the browser tab strip.
TabStripModel* tab_strip_model = browser()->tab_strip_model();
chrome::AddTabAt(browser(), GURL(url::kAboutBlankURL), 1, true);
tabs::TabInterface* initial_tab = tab_strip_model->GetTabAtIndex(1);
EXPECT_EQ(2, tab_strip_model->count());
base::MockCallback<tabs::TabInterface::WillDetach> tab_detached_callback;
base::CallbackListSubscription tab_subscription =
initial_tab->RegisterWillDetach(tab_detached_callback.Get());
WebContentsRemovedObserver removed_observer;
tab_strip_model->AddObserver(&removed_observer);
// Extract the about:blank tab WebContents while destroying its TabModel.
EXPECT_CALL(tab_detached_callback,
Run(tab_strip_model->GetTabAtIndex(1),
tabs::TabInterface::DetachReason::kDelete));
std::unique_ptr<content::WebContents> extracted_contents =
tab_strip_model->DetachWebContentsAtForInsertion(1);
EXPECT_EQ(TabStripModelChange::RemoveReason::kInsertedIntoOtherTabStrip,
removed_observer.remove_reason());
EXPECT_EQ(tabs::TabInterface::DetachReason::kDelete,
removed_observer.tab_detach_reason());
// Load the NTP into the detached tab. The NTP should load without crashing.
EXPECT_TRUE(content::NavigateToURL(extracted_contents.get(),
GURL(chrome::kChromeUINewTabURL)));
// Re-insert the tab into the tab strip.
tab_strip_model->AppendWebContents(std::move(extracted_contents), true);
}
// Currently it is possible to load the NTP in an app window context that
// supports re-parenting the tab into a normal browser window. Assert the NTP
// supports such TabModel transitions.
// TODO(crbug.com/378475391): This can be removed once an owning TabModel is
// guaranteed to be always present and fixed for the lifetime of the NTP.
IN_PROC_BROWSER_TEST_F(WebUiNtpBrowserTest, HandlesTabModelChanges) {
// Add a new NTP tab to the browser tab strip.
TabStripModel* tab_strip_model = browser()->tab_strip_model();
chrome::AddTabAt(browser(), GURL(chrome::kChromeUINewTabURL), 1, true);
tabs::TabInterface* initial_tab = tab_strip_model->GetTabAtIndex(1);
EXPECT_EQ(2, tab_strip_model->count());
base::MockCallback<tabs::TabInterface::WillDetach> tab_detached_callback;
base::CallbackListSubscription tab_subscription =
initial_tab->RegisterWillDetach(tab_detached_callback.Get());
WebContentsRemovedObserver removed_observer;
tab_strip_model->AddObserver(&removed_observer);
// Extract the NTP WebContents while destroying its TabModel, simulating what
// occurs during a browser-type transition.
EXPECT_CALL(tab_detached_callback,
Run(tab_strip_model->GetTabAtIndex(1),
tabs::TabInterface::DetachReason::kDelete));
std::unique_ptr<content::WebContents> extracted_contents =
tab_strip_model->DetachWebContentsAtForInsertion(1);
EXPECT_EQ(TabStripModelChange::RemoveReason::kInsertedIntoOtherTabStrip,
removed_observer.remove_reason());
EXPECT_EQ(tabs::TabInterface::DetachReason::kDelete,
removed_observer.tab_detach_reason());
// Re-insert the tab into the tab strip, creating a new TabModel.
tab_strip_model->AppendWebContents(std::move(extracted_contents), true);
}
|