File: window_sizer_chromeos_unittest.cc

package info (click to toggle)
chromium 138.0.7204.183-1~deb12u1
  • links: PTS, VCS
  • area: main
  • in suites: bookworm-proposed-updates
  • size: 6,080,960 kB
  • sloc: cpp: 34,937,079; ansic: 7,176,967; javascript: 4,110,704; python: 1,419,954; asm: 946,768; xml: 739,971; pascal: 187,324; sh: 89,623; perl: 88,663; objc: 79,944; sql: 50,304; cs: 41,786; fortran: 24,137; makefile: 21,811; php: 13,980; tcl: 13,166; yacc: 8,925; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (818 lines) | stat: -rw-r--r-- 35,913 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/ui/window_sizer/window_sizer_chromeos.h"

#include "ash/public/cpp/window_properties.h"
#include "ash/root_window_controller.h"
#include "ash/shelf/shelf.h"
#include "ash/shell.h"
#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/window_sizer/window_sizer_common_unittest.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/chrome_ash_test_base.h"
#include "chrome/test/base/test_browser_window_aura.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/render_view_test.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/env.h"
#include "ui/aura/test/test_windows.h"
#include "ui/aura/window_event_dispatcher.h"
#include "ui/base/mojom/window_show_state.mojom.h"
#include "ui/display/display.h"
#include "ui/display/manager/display_manager.h"
#include "ui/display/screen.h"
#include "ui/display/test/display_manager_test_api.h"
#include "ui/wm/public/activation_client.h"

class WindowSizerChromeOSTest : public ChromeAshTestBase {
 public:
  WindowSizerChromeOSTest() = default;
  WindowSizerChromeOSTest(const WindowSizerChromeOSTest&) = delete;
  WindowSizerChromeOSTest& operator=(const WindowSizerChromeOSTest&) = delete;
  ~WindowSizerChromeOSTest() override = default;

  // The window sizing code only works when the window hasn't yet been created.
  std::unique_ptr<Browser> CreateWindowlessBrowser(
      Browser::CreateParams params) {
    params.skip_window_init_for_testing = true;
    return std::unique_ptr<Browser>(Browser::Create(params));
  }

  // Similar to WindowSizerTestUtil::GetWindowBounds() but takes an existing
  // |display_id| instead of creating a TestScreen and new displays.
  // TODO(mek): Refactor this to use a builder pattern similar to what
  // WindowSizerTestUtil does.
  enum Source { DEFAULT, LAST_ACTIVE, PERSISTED, BOTH };
  void GetWindowBounds(const Browser* browser,
                       const gfx::Rect& passed_in,
                       int64_t display_id,
                       const gfx::Rect& bounds,
                       const gfx::Rect& work_area,
                       Source source,
                       gfx::Rect* out_bounds) {
    auto state_provider = std::make_unique<TestStateProvider>();
    if (source == PERSISTED) {
      state_provider->SetPersistentState(bounds, work_area,
                                         ui::mojom::WindowShowState::kDefault);
    } else {
      DCHECK_EQ(source, DEFAULT);
    }
    display::Screen::GetScreen()->SetDisplayForNewWindows(display_id);

    ui::mojom::WindowShowState ignored;
    WindowSizer::GetBrowserWindowBoundsAndShowState(
        std::move(state_provider), passed_in, browser, out_bounds, &ignored);
  }
  void GetWindowBounds(const Browser* browser,
                       const gfx::Rect& passed_in,
                       int64_t display_id,
                       gfx::Rect* out_bounds = nullptr) {
    GetWindowBounds(browser, passed_in, display_id, gfx::Rect(), gfx::Rect(),
                    PERSISTED, out_bounds);
  }

  // Returns browser window |out_bounds| and |out_show_state| for simulated
  // persisted and last-active window bounds, work area, show state, etc.
  static void GetBrowserWindowBoundsAndShowState(
      const gfx::Rect& bounds,
      const gfx::Rect& work_area,
      ui::mojom::WindowShowState show_state_persisted,
      ui::mojom::WindowShowState show_state_last,
      Source source,
      const Browser* browser,
      const gfx::Rect& passed_in,
      gfx::Rect* out_bounds,
      ui::mojom::WindowShowState* out_show_state) {
    DCHECK(out_show_state);
    auto provider = std::make_unique<TestStateProvider>();
    if (source == PERSISTED || source == BOTH) {
      provider->SetPersistentState(bounds, work_area, show_state_persisted);
    }
    if (source == LAST_ACTIVE || source == BOTH) {
      provider->SetLastActiveState(bounds, show_state_last);
    }

    WindowSizer::GetBrowserWindowBoundsAndShowState(
        std::move(provider), passed_in, browser, out_bounds, out_show_state);
  }

  // Returns browser window show state for simulated persisted and last-active
  // window bounds, work area, show state, etc.
  static ui::mojom::WindowShowState GetBrowserWindowShowState(
      ui::mojom::WindowShowState show_state_persisted,
      ui::mojom::WindowShowState show_state_last,
      Source source,
      const Browser* browser,
      const gfx::Rect& bounds,
      const gfx::Rect& work_area) {
    ui::mojom::WindowShowState out_show_state =
        ui::mojom::WindowShowState::kDefault;
    gfx::Rect ignored;
    GetBrowserWindowBoundsAndShowState(bounds, work_area, show_state_persisted,
                                       show_state_last, source, browser,
                                       gfx::Rect(), &ignored, &out_show_state);
    return out_show_state;
  }

 protected:
  TestingProfile profile_;
};

namespace {

// Shorten identifiers to improve line wrapping.
const int kDesktopBorderSize = WindowSizerChromeOS::kDesktopBorderSize;
const int kMaximumWindowWidth = WindowSizerChromeOS::kMaximumWindowWidth;
const int kWindowTilePixels = WindowSizer::kWindowTilePixels;

std::unique_ptr<Browser> CreateTestBrowser(aura::Window* window,
                                           const gfx::Rect& bounds,
                                           Browser::CreateParams* params) {
  if (!bounds.IsEmpty()) {
    window->SetBounds(bounds);
  }
  std::unique_ptr<Browser> browser =
      chrome::CreateBrowserWithAuraTestWindowForParams(base::WrapUnique(window),
                                                       params);
  if (browser->is_type_normal()) {
    browser->window()->GetNativeWindow()->SetProperty(
        ash::kWindowPositionManagedTypeKey, true);
  }
  return browser;
}

}  // namespace

// WindowSizerChromeOSNoAshTest are the tests that does not require ash
// environment, thus it can use WindowSizerTestUtil that create a TestScreen
// inside.

// Test that the window is sized appropriately for the first run experience
// where the default window bounds calculation is invoked.
TEST(WindowSizerChromeOSNoAshTest, DefaultSizeCase) {
  {
    // 4:3 monitor case, 1024x768, no taskbar.
    gfx::Rect window_bounds =
        WindowSizerTestUtil().WithMonitorBounds(p1024x768).GetWindowBounds();
    EXPECT_EQ(
        gfx::Rect(kDesktopBorderSize, kDesktopBorderSize,
                  1024 - kDesktopBorderSize * 2, 768 - kDesktopBorderSize),
        window_bounds);
  }

  {
    // 4:3 monitor case, 1024x768, taskbar on bottom.
    gfx::Rect window_bounds = WindowSizerTestUtil()
                                  .WithMonitorBounds(p1024x768)
                                  .WithMonitorWorkArea(taskbar_bottom_work_area)
                                  .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(kDesktopBorderSize, kDesktopBorderSize,
                        1024 - kDesktopBorderSize * 2,
                        taskbar_bottom_work_area.height() - kDesktopBorderSize),
              window_bounds);
  }

  {
    // 4:3 monitor case, 1024x768, taskbar on right.
    gfx::Rect window_bounds = WindowSizerTestUtil()
                                  .WithMonitorBounds(p1024x768)
                                  .WithMonitorWorkArea(taskbar_right_work_area)
                                  .GetWindowBounds();
    EXPECT_EQ(
        gfx::Rect(kDesktopBorderSize, kDesktopBorderSize,
                  taskbar_right_work_area.width() - kDesktopBorderSize * 2,
                  768 - kDesktopBorderSize),
        window_bounds);
  }

  {
    // 4:3 monitor case, 1024x768, taskbar on left.
    gfx::Rect window_bounds = WindowSizerTestUtil()
                                  .WithMonitorBounds(p1024x768)
                                  .WithMonitorWorkArea(taskbar_left_work_area)
                                  .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(taskbar_left_work_area.x() + kDesktopBorderSize,
                        kDesktopBorderSize,
                        taskbar_left_work_area.width() - kDesktopBorderSize * 2,
                        taskbar_left_work_area.height() - kDesktopBorderSize),
              window_bounds);
  }

  {
    // 4:3 monitor case, 1024x768, taskbar on top.
    gfx::Rect window_bounds = WindowSizerTestUtil()
                                  .WithMonitorBounds(p1024x768)
                                  .WithMonitorWorkArea(taskbar_top_work_area)
                                  .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(kDesktopBorderSize,
                        taskbar_top_work_area.y() + kDesktopBorderSize,
                        1024 - kDesktopBorderSize * 2,
                        taskbar_top_work_area.height() - kDesktopBorderSize),
              window_bounds);
  }

  {
    // 4:3 monitor case, 1280x1024.
    gfx::Rect window_bounds =
        WindowSizerTestUtil().WithMonitorBounds(p1280x1024).GetWindowBounds();
    EXPECT_EQ(gfx::Rect((1280 - kMaximumWindowWidth) / 2, kDesktopBorderSize,
                        kMaximumWindowWidth, 1024 - kDesktopBorderSize),
              window_bounds);
  }

  {
    // 4:3 monitor case, 1600x1200.
    gfx::Rect window_bounds =
        WindowSizerTestUtil().WithMonitorBounds(p1600x1200).GetWindowBounds();
    EXPECT_EQ(gfx::Rect((1600 - kMaximumWindowWidth) / 2, kDesktopBorderSize,
                        kMaximumWindowWidth, 1200 - kDesktopBorderSize),
              window_bounds);
  }

  {
    // 16:10 monitor case, 1680x1050.
    gfx::Rect window_bounds =
        WindowSizerTestUtil().WithMonitorBounds(p1680x1050).GetWindowBounds();
    EXPECT_EQ(gfx::Rect((1680 - kMaximumWindowWidth) / 2, kDesktopBorderSize,
                        kMaximumWindowWidth, 1050 - kDesktopBorderSize),
              window_bounds);
  }

  {
    // 16:10 monitor case, 1920x1200.
    gfx::Rect window_bounds =
        WindowSizerTestUtil().WithMonitorBounds(p1920x1200).GetWindowBounds();
    EXPECT_EQ(gfx::Rect((1920 - kMaximumWindowWidth) / 2, kDesktopBorderSize,
                        kMaximumWindowWidth, 1200 - kDesktopBorderSize),
              window_bounds);
  }
}

// Test that the next opened window is positioned appropriately given the
// bounds of an existing window of the same type.
TEST(WindowSizerChromeOS2NoAshTest, LastWindowBoundsCase) {
  {
    // Normal, in the middle of the screen somewhere.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(
                gfx::Rect(kDesktopBorderSize, kDesktopBorderSize, 500, 400))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(kWindowTilePixels + kDesktopBorderSize,
                        kWindowTilePixels + kDesktopBorderSize, 500, 400)
                  .ToString(),
              window_bounds.ToString());
  }

  {
    // Taskbar on top.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithMonitorWorkArea(taskbar_top_work_area)
            .WithLastActiveBounds(
                gfx::Rect(kDesktopBorderSize, kDesktopBorderSize, 500, 400))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(kWindowTilePixels + kDesktopBorderSize,
                        std::max(kWindowTilePixels + kDesktopBorderSize,
                                 34 /* toolbar height */),
                        500, 400)
                  .ToString(),
              window_bounds.ToString());
  }

  {
    // Too small to satisfy the minimum visibility condition.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(
                gfx::Rect(kDesktopBorderSize, kDesktopBorderSize, 29, 29))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(kWindowTilePixels + kDesktopBorderSize,
                        kWindowTilePixels + kDesktopBorderSize, 30 /* not 29 */,
                        30 /* not 29 */)
                  .ToString(),
              window_bounds.ToString());
  }
}

TEST(WindowSizerChromeOSNoAshTest,
     LastWindowOffscreenWithNonAggressiveRepositioning) {
  {
    // Taskbar on left.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithMonitorWorkArea(taskbar_left_work_area)
            .WithLastActiveBounds(
                gfx::Rect(kDesktopBorderSize, kDesktopBorderSize, 500, 400))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(kWindowTilePixels + kDesktopBorderSize,
                        kWindowTilePixels + kDesktopBorderSize, 500, 400)
                  .ToString(),
              window_bounds.ToString());
  }

  {
    // Offset would put the new window offscreen at the bottom but the minimum
    // visibility condition is barely satisfied without relocation.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(gfx::Rect(10, 638, 500, 400))
            .GetWindowBounds();
    // The y position is the display height (768) minus the minimum visible
    // height (0.3f * 400).
    EXPECT_EQ(gfx::Rect(10 + kWindowTilePixels, 648, 500, 400).ToString(),
              window_bounds.ToString());
  }

  {
    // Offset would put the new window offscreen at the bottom and the minimum
    // visibility condition is satisfied by relocation.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(gfx::Rect(20, 639, 500, 400))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(20 + kWindowTilePixels, 648, 500, 400).ToString(),
              window_bounds.ToString());
  }

  {
    // Offset would put the new window offscreen at the right but the minimum
    // visibility condition is barely satisfied without relocation.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(gfx::Rect(864, 10, 500, 400))
            .GetWindowBounds();
    // The x position is the display width (1024) minus the minimum visible
    // width (0.3f * 500).
    EXPECT_EQ(gfx::Rect(874, 10 + kWindowTilePixels, 500, 400).ToString(),
              window_bounds.ToString());
  }

  {
    // Offset would put the new window offscreen at the right and the minimum
    // visibility condition is satisfied by relocation.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(gfx::Rect(865, 20, 500, 400))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(874, 20 + kWindowTilePixels, 500, 400).ToString(),
              window_bounds.ToString());
  }

  {
    // Offset would put the new window offscreen at the bottom right and the
    // minimum visibility condition is satisfied by relocation.
    gfx::Rect window_bounds =
        WindowSizerTestUtil()
            .WithMonitorBounds(p1024x768)
            .WithLastActiveBounds(gfx::Rect(865, 639, 500, 400))
            .GetWindowBounds();
    EXPECT_EQ(gfx::Rect(874, 648, 500, 400).ToString(),
              window_bounds.ToString());
  }
}

// Test the placement of newly created windows.
TEST_F(WindowSizerChromeOSTest, PlaceNewWindows) {
  UpdateDisplay("1600x1200");
  auto* shelf = ash::Shell::GetPrimaryRootWindowController()->shelf();
  shelf->SetAutoHideBehavior(ash::ShelfAutoHideBehavior::kAlways);

  int64_t display_id = display::Screen::GetScreen()->GetPrimaryDisplay().id();

  // Create a browser to pass into the WindowSizerTestUtil::GetWindowBounds
  // function.
  Browser::CreateParams native_params(&profile_, true);
  auto browser = CreateWindowlessBrowser(native_params);

  // Creating a popup handler here to make sure it does not interfere with the
  // existing windows.
  Browser::CreateParams params2(&profile_, true);
  std::unique_ptr<Browser> browser2 = (CreateTestBrowser(
      CreateTestWindowInShellWithId(0), gfx::Rect(16, 32, 640, 320), &params2));
  BrowserWindow* browser_window = browser2->window();

  // Creating a popup to make sure it does not interfere with the positioning.
  Browser::CreateParams params_popup(Browser::TYPE_POPUP, &profile_, true);
  std::unique_ptr<Browser> browser_popup(
      CreateTestBrowser(CreateTestWindowInShellWithId(1),
                        gfx::Rect(16, 32, 128, 256), &params_popup));

  browser_window->Show();

  // Make sure that popups do not get changed.
  {
    Browser::CreateParams params_new_popup(Browser::TYPE_POPUP, &profile_,
                                           true);
    auto new_popup = CreateWindowlessBrowser(params_new_popup);
    gfx::Rect window_bounds;
    GetWindowBounds(new_popup.get(), gfx::Rect(), display_id,
                    gfx::Rect(50, 100, 300, 150), bottom_s1600x1200, PERSISTED,
                    &window_bounds);
    EXPECT_EQ("50,100 300x150", window_bounds.ToString());
  }

  browser_window->Hide();
  {
    // If a window is there but not shown the persisted default should be used.
    gfx::Rect window_bounds;
    GetWindowBounds(browser.get(), gfx::Rect(), display_id,
                    gfx::Rect(50, 100, 300, 150), bottom_s1600x1200, PERSISTED,
                    &window_bounds);
    EXPECT_EQ("50,100 300x150", window_bounds.ToString());
  }

  {
    // If a window is there but not shown the default should be returned.
    gfx::Rect window_bounds;
    GetWindowBounds(browser.get(), gfx::Rect(), display_id, gfx::Rect(),
                    bottom_s1600x1200, DEFAULT, &window_bounds);
    // Note: We need to also take the defaults maximum width into account here
    // since that might get used if the resolution is too big.
    EXPECT_EQ(
        gfx::Rect(
            std::max(kDesktopBorderSize, (1600 - kMaximumWindowWidth) / 2),
            kDesktopBorderSize,
            std::min(kMaximumWindowWidth, 1600 - 2 * kDesktopBorderSize),
            1200 - kDesktopBorderSize)
            .ToString(),
        window_bounds.ToString());
  }
}

// Test the placement of newly created windows on an empty desktop.
// This test supplements "PlaceNewWindows" by testing the creation of a newly
// created browser window on an empty desktop.
TEST_F(WindowSizerChromeOSTest, PlaceNewBrowserWindowOnEmptyDesktop) {
  Browser::CreateParams native_params(&profile_, true);
  auto browser = CreateWindowlessBrowser(native_params);

  // A common screen size for Chrome OS devices where forced-maximized
  // windows are desirable.
  UpdateDisplay("1366x768");
  const gfx::Rect p1366x768(0, 0, 1366, 768);

  // If there is no previous state the window should get maximized if the
  // screen is less than or equal to our limit (1366 pixels width).
  gfx::Rect window_bounds;
  ui::mojom::WindowShowState out_show_state1 =
      ui::mojom::WindowShowState::kDefault;
  GetBrowserWindowBoundsAndShowState(
      gfx::Rect(),                           // The (persisted) bounds.
      p1366x768,                             // The overall work area.
      ui::mojom::WindowShowState::kNormal,   // The persisted show state.
      ui::mojom::WindowShowState::kDefault,  // The last show state.
      DEFAULT,                               // No persisted values.
      browser.get(),                         // Use this browser.
      gfx::Rect(),                           // Don't request valid bounds.
      &window_bounds, &out_show_state1);
  EXPECT_EQ(ui::mojom::WindowShowState::kMaximized, out_show_state1);

  // If there is a stored coordinate however, that should be taken instead.
  ui::mojom::WindowShowState out_show_state2 =
      ui::mojom::WindowShowState::kDefault;
  GetBrowserWindowBoundsAndShowState(
      gfx::Rect(50, 100, 300, 150),          // The (persisted) bounds.
      p1366x768,                             // The overall work area.
      ui::mojom::WindowShowState::kNormal,   // The persisted show state.
      ui::mojom::WindowShowState::kDefault,  // The last show state.
      PERSISTED,                             // Set the persisted values.
      browser.get(),                         // Use this browser.
      gfx::Rect(),                           // Don't request valid bounds.
      &window_bounds, &out_show_state2);
  EXPECT_EQ(ui::mojom::WindowShowState::kNormal, out_show_state2);
  EXPECT_EQ("50,100 300x150", window_bounds.ToString());
}

TEST_F(WindowSizerChromeOSTest, PlaceNewBrowserWindowOnLargeDesktop) {
  Browser::CreateParams native_params(&profile_, true);
  auto browser = CreateWindowlessBrowser(native_params);

  // A larger monitor should not trigger auto-maximize.
  UpdateDisplay("1600x1200");
  gfx::Rect window_bounds;
  ui::mojom::WindowShowState out_show_state =
      ui::mojom::WindowShowState::kDefault;
  GetBrowserWindowBoundsAndShowState(
      gfx::Rect(),                           // The (persisted) bounds.
      p1600x1200,                            // The overall work area.
      ui::mojom::WindowShowState::kNormal,   // The persisted show state.
      ui::mojom::WindowShowState::kDefault,  // The last show state.
      DEFAULT,                               // No persisted values.
      browser.get(),                         // Use this browser.
      gfx::Rect(),                           // Don't request valid bounds.
      &window_bounds, &out_show_state);
  EXPECT_EQ(ui::mojom::WindowShowState::kDefault, out_show_state);
}

// Test the placement of newly created windows on multiple dislays.
TEST_F(WindowSizerChromeOSTest, PlaceNewWindowsOnMultipleDisplays) {
  UpdateDisplay("1600x1200,1600x1200");
  display::Display primary_display =
      display::Screen::GetScreen()->GetPrimaryDisplay();
  display::Display second_display =
      display::test::DisplayManagerTestApi(display_manager())
          .GetSecondaryDisplay();
  gfx::Rect primary_bounds = primary_display.bounds();
  gfx::Rect secondary_bounds = second_display.bounds();

  // Create browser windows that are used as reference.
  Browser::CreateParams params(&profile_, true);
  std::unique_ptr<Browser> browser(CreateTestBrowser(
      CreateTestWindowInShellWithId(0), gfx::Rect(10, 10, 200, 200), &params));
  BrowserWindow* browser_window = browser->window();
  gfx::NativeWindow native_window = browser_window->GetNativeWindow();
  browser_window->Show();
  EXPECT_EQ(native_window->GetRootWindow(),
            ash::Shell::GetRootWindowForNewWindows());

  Browser::CreateParams another_params(&profile_, true);
  std::unique_ptr<Browser> another_browser(
      CreateTestBrowser(CreateTestWindowInShellWithId(1),
                        gfx::Rect(400, 10, 300, 300), &another_params));
  BrowserWindow* another_browser_window = another_browser->window();
  gfx::NativeWindow another_native_window =
      another_browser_window->GetNativeWindow();
  another_browser_window->Show();

  // Creating a new window to verify the new placement.
  Browser::CreateParams new_params(&profile_, true);
  auto new_browser = CreateWindowlessBrowser(new_params);

  // Make sure the primary root is active.
  ASSERT_EQ(ash::Shell::GetPrimaryRootWindow(),
            ash::Shell::GetRootWindowForNewWindows());

  // First new window should be in the primary.
  {
    gfx::Rect window_bounds;
    GetWindowBounds(new_browser.get(), gfx::Rect(), primary_display.id(),
                    &window_bounds);
    // TODO(oshima): Use exact bounds when the window sizer includes the result
    // from RearrangeVisibleWindowOnShow.
    EXPECT_TRUE(primary_bounds.Contains(window_bounds));
  }

  // Move the window to the right side of the secondary display and create a new
  // window. It should be opened then on the secondary display.
  {
    browser_window->GetNativeWindow()->SetBoundsInScreen(
        gfx::Rect(secondary_bounds.CenterPoint().x() - 100, 10, 200, 200),
        second_display);
    wm::GetActivationClient(native_window->GetRootWindow())
        ->ActivateWindow(native_window);
    EXPECT_NE(ash::Shell::GetPrimaryRootWindow(),
              ash::Shell::GetRootWindowForNewWindows());
    gfx::Rect window_bounds;
    GetWindowBounds(new_browser.get(), gfx::Rect(), second_display.id(),
                    &window_bounds);
    // TODO(oshima): Use exact bounds when the window sizer includes the result
    // from RearrangeVisibleWindowOnShow.
    EXPECT_TRUE(secondary_bounds.Contains(window_bounds));
  }

  // Activate another window in the primary display and create a new window.
  // It should be created in the primary display.
  {
    wm::GetActivationClient(another_native_window->GetRootWindow())
        ->ActivateWindow(another_native_window);
    EXPECT_EQ(ash::Shell::GetPrimaryRootWindow(),
              ash::Shell::GetRootWindowForNewWindows());

    gfx::Rect window_bounds;
    GetWindowBounds(new_browser.get(), gfx::Rect(), primary_display.id(),
                    &window_bounds);
    // TODO(oshima): Use exact bounds when the window sizer includes the result
    // from RearrangeVisibleWindowOnShow.
    EXPECT_TRUE(primary_bounds.Contains(window_bounds));
  }
}

// Test that the show state is properly returned for non default cases.
TEST_F(WindowSizerChromeOSTest, TestShowState) {
  UpdateDisplay("1600x1200");

  // Creating a browser & window to play with.
  Browser::CreateParams params(Browser::TYPE_NORMAL, &profile_, true);
  auto browser = CreateWindowlessBrowser(params);

  // Create also a popup browser since that behaves different.
  Browser::CreateParams params_popup(Browser::TYPE_POPUP, &profile_, true);
  auto browser_popup = CreateWindowlessBrowser(params_popup);

  // Tabbed windows should retrieve the saved window state - since there is a
  // top window.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kMaximized,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kNormal, PERSISTED,
                                browser.get(), p1600x1200, p1600x1200));
  // A window that is smaller than the whole work area is set to default state.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kDefault,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kDefault,
                                ui::mojom::WindowShowState::kNormal, PERSISTED,
                                browser.get(), p1280x1024, p1600x1200));
  // A window that is sized to occupy the whole work area is maximized.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kMaximized,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kDefault,
                                ui::mojom::WindowShowState::kNormal, PERSISTED,
                                browser.get(), p1600x1200, p1600x1200));
  // Non tabbed windows should always follow the window saved visibility state.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kMaximized,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kNormal, BOTH,
                                browser_popup.get(), p1600x1200, p1600x1200));
  // The non tabbed window will take the status of the last active of its kind.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kNormal,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kDefault,
                                ui::mojom::WindowShowState::kNormal, BOTH,
                                browser_popup.get(), p1600x1200, p1600x1200));

  // A tabbed window should now take the top level window state.
  EXPECT_EQ(ui::mojom::WindowShowState::kNormal,
            GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                      ui::mojom::WindowShowState::kNormal, BOTH,
                                      browser.get(), p1600x1200, p1600x1200));
  // Non tabbed windows should always follow the window saved visibility state.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kMaximized,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kMinimized, BOTH,
                                browser_popup.get(), p1600x1200, p1600x1200));
}

TEST_F(WindowSizerChromeOSTest, TestShowStateOnTinyScreen) {
  Browser::CreateParams params(Browser::TYPE_NORMAL, &profile_, true);
  auto browser = CreateWindowlessBrowser(params);

  // In smaller screen resolutions we default to maximized if there is no other
  // window visible.
  UpdateDisplay("640x480");
  const gfx::Rect tiny_screen(0, 0, 640, 480);
  EXPECT_EQ(
      ui::mojom::WindowShowState::kMaximized,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kDefault, BOTH,
                                browser.get(), tiny_screen, tiny_screen));
}

// Test that the default show state override behavior is properly handled.
TEST_F(WindowSizerChromeOSTest, TestShowStateDefaults) {
  UpdateDisplay("1600x1200");
  // Creating a browser & window to play with.

  Browser::CreateParams params(Browser::TYPE_NORMAL, &profile_, true);
  auto browser = CreateWindowlessBrowser(params);

  // Create also a popup browser since that behaves slightly different for
  // defaults.
  Browser::CreateParams params_popup(Browser::TYPE_POPUP, &profile_, true);
  auto browser_popup = CreateWindowlessBrowser(params_popup);

  // Check that a browser creation state always get used if not given as
  // SHOW_STATE_DEFAULT.
  ui::mojom::WindowShowState window_show_state =
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kMaximized, DEFAULT,
                                browser.get(), p1600x1200, p1600x1200);
  EXPECT_EQ(window_show_state, ui::mojom::WindowShowState::kDefault);

  browser->set_initial_show_state(ui::mojom::WindowShowState::kMinimized);
  EXPECT_EQ(
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kMaximized, BOTH,
                                browser.get(), p1600x1200, p1600x1200),
      ui::mojom::WindowShowState::kMinimized);
  browser->set_initial_show_state(ui::mojom::WindowShowState::kNormal);
  EXPECT_EQ(
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kMaximized,
                                ui::mojom::WindowShowState::kMaximized, BOTH,
                                browser.get(), p1600x1200, p1600x1200),
      ui::mojom::WindowShowState::kNormal);
  browser->set_initial_show_state(ui::mojom::WindowShowState::kMaximized);
  EXPECT_EQ(GetBrowserWindowShowState(ui::mojom::WindowShowState::kNormal,
                                      ui::mojom::WindowShowState::kNormal, BOTH,
                                      browser.get(), p1600x1200, p1600x1200),
            ui::mojom::WindowShowState::kMaximized);

  // Check that setting the maximized command line option is forcing the
  // maximized state.
  base::CommandLine::ForCurrentProcess()->AppendSwitch(
      switches::kStartMaximized);

  browser->set_initial_show_state(ui::mojom::WindowShowState::kNormal);
  EXPECT_EQ(GetBrowserWindowShowState(ui::mojom::WindowShowState::kNormal,
                                      ui::mojom::WindowShowState::kNormal, BOTH,
                                      browser.get(), p1600x1200, p1600x1200),
            ui::mojom::WindowShowState::kMaximized);

  // The popup should favor the initial show state over the command line.
  EXPECT_EQ(
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kNormal,
                                ui::mojom::WindowShowState::kNormal, BOTH,
                                browser_popup.get(), p1600x1200, p1600x1200),
      ui::mojom::WindowShowState::kNormal);
}

TEST_F(WindowSizerChromeOSTest, DefaultStateBecomesMaximized) {
  // Create a browser to pass into the WindowSizerTestUtil::GetWindowBounds
  // function.
  Browser::CreateParams native_params(&profile_, true);
  auto browser = CreateWindowlessBrowser(native_params);

  gfx::Rect display_bounds =
      display::Screen::GetScreen()->GetPrimaryDisplay().bounds();
  gfx::Rect specified_bounds = display_bounds;

  // Make a window bigger than the display work area.
  specified_bounds.Inset(-20);
  ui::mojom::WindowShowState show_state = ui::mojom::WindowShowState::kDefault;
  gfx::Rect bounds;
  WindowSizer::GetBrowserWindowBoundsAndShowState(
      specified_bounds, browser.get(), &bounds, &show_state);
  // The window should start maximized with its restore bounds shrunken.
  EXPECT_EQ(ui::mojom::WindowShowState::kMaximized, show_state);
  EXPECT_NE(display_bounds.ToString(), bounds.ToString());
  EXPECT_TRUE(display_bounds.Contains(bounds));

  // Make a window smaller than the display work area.
  specified_bounds.Inset(100);
  show_state = ui::mojom::WindowShowState::kDefault;
  WindowSizer::GetBrowserWindowBoundsAndShowState(
      specified_bounds, browser.get(), &bounds, &show_state);
  // The window should start in default state.
  EXPECT_EQ(ui::mojom::WindowShowState::kDefault, show_state);
  EXPECT_EQ(specified_bounds.ToString(), bounds.ToString());
}

// Test that the target root window is used as the destination of
// the non browser window. This differ from PersistedBoundsCase
// in that this uses real ash shell implementations + StateProvider
// rather than mocks.
TEST_F(WindowSizerChromeOSTest, DefaultBoundsInTargetDisplay) {
  UpdateDisplay("500x400,600x500");

  {
    // By default windows are placed on the primary display.
    aura::Window* first_root = ash::Shell::GetAllRootWindows()[0];
    EXPECT_EQ(first_root, ash::Shell::GetRootWindowForNewWindows());
    gfx::Rect bounds;
    ui::mojom::WindowShowState show_state;
    WindowSizer::GetBrowserWindowBoundsAndShowState(gfx::Rect(), nullptr,
                                                    &bounds, &show_state);
    EXPECT_TRUE(first_root->GetBoundsInScreen().Contains(bounds));
  }

  {
    // When the second display is active new windows are placed there.
    aura::Window* second_root = ash::Shell::GetAllRootWindows()[1];
    int64_t second_display_id =
        display::test::DisplayManagerTestApi(display_manager())
            .GetSecondaryDisplay()
            .id();
    display::Screen::GetScreen()->SetDisplayForNewWindows(second_display_id);
    gfx::Rect bounds;
    ui::mojom::WindowShowState show_state;
    WindowSizer::GetBrowserWindowBoundsAndShowState(gfx::Rect(), nullptr,
                                                    &bounds, &show_state);
    EXPECT_TRUE(second_root->GetBoundsInScreen().Contains(bounds));
  }
}

TEST_F(WindowSizerChromeOSTest, TrustedPopupBehavior) {
  Browser::CreateParams trusted_popup_create_params(Browser::TYPE_POPUP,
                                                    &profile_, true);
  trusted_popup_create_params.trusted_source = true;

  auto trusted_popup = CreateWindowlessBrowser(trusted_popup_create_params);
  // Trusted popup windows should follow the saved show state and ignore the
  // last show state.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kDefault,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kDefault,
                                ui::mojom::WindowShowState::kNormal, BOTH,
                                trusted_popup.get(), p1280x1024, p1600x1200));
  // A popup that is sized to occupy the whole work area has default state.
  EXPECT_EQ(
      ui::mojom::WindowShowState::kDefault,
      GetBrowserWindowShowState(ui::mojom::WindowShowState::kDefault,
                                ui::mojom::WindowShowState::kNormal, BOTH,
                                trusted_popup.get(), p1600x1200, p1600x1200));
}