1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/web_applications/os_integration/mac/app_shim_registry.h"
#include "base/base64.h"
#include "base/memory/raw_ptr.h"
#include "components/os_crypt/sync/os_crypt_mocker.h"
#include "components/prefs/testing_pref_service.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
class AppShimRegistryTest : public testing::Test {
public:
AppShimRegistryTest() = default;
~AppShimRegistryTest() override = default;
AppShimRegistryTest(const AppShimRegistryTest&) = delete;
AppShimRegistryTest& operator=(const AppShimRegistryTest&) = delete;
void SetUp() override {
local_state_ = std::make_unique<TestingPrefServiceSimple>();
registry_ = AppShimRegistry::Get();
registry_->RegisterLocalPrefs(local_state_->registry());
registry_->SetPrefServiceAndUserDataDirForTesting(local_state_.get(),
base::FilePath("/x/y/z"));
OSCryptMocker::SetUp();
}
void TearDown() override {
registry_->SetPrefServiceAndUserDataDirForTesting(nullptr,
base::FilePath());
OSCryptMocker::TearDown();
}
protected:
raw_ptr<AppShimRegistry> registry_ = nullptr;
std::unique_ptr<TestingPrefServiceSimple> local_state_;
};
TEST_F(AppShimRegistryTest, Lifetime) {
const std::string app_id_a("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
const std::string app_id_b("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb");
base::FilePath profile_path_a("/x/y/z/Profile A");
base::FilePath profile_path_b("/x/y/z/Profile B");
base::FilePath profile_path_c("/x/y/z/Profile C");
std::set<base::FilePath> profiles;
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_a).size());
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_b).size());
// Ensure that OnAppUninstalledForProfile with no profiles installed is a
// no-op, and reports that the app is installed for no profiles.
EXPECT_TRUE(registry_->OnAppUninstalledForProfile(app_id_a, profile_path_a));
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_a).size());
// Ensure that SaveLastActiveProfilesForApp with no profiles installed is a
// no-op.
profiles.insert(profile_path_a);
registry_->SaveLastActiveProfilesForApp(app_id_a, profiles);
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_a).size());
EXPECT_EQ(0u, registry_->GetLastActiveProfilesForApp(app_id_a).size());
// Test installing for profile a.
registry_->OnAppInstalledForProfile(app_id_a, profile_path_a);
profiles = registry_->GetInstalledProfilesForApp(app_id_a);
EXPECT_EQ(profiles.size(), 1u);
EXPECT_TRUE(profiles.count(profile_path_a));
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_b).size());
// And installing for profile b.
registry_->OnAppInstalledForProfile(app_id_a, profile_path_b);
profiles = registry_->GetInstalledProfilesForApp(app_id_a);
EXPECT_EQ(profiles.size(), 2u);
EXPECT_TRUE(profiles.count(profile_path_a));
EXPECT_TRUE(profiles.count(profile_path_b));
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_b).size());
// Test SaveLastActiveProfilesForApp with a valid profile.
profiles.clear();
profiles.insert(profile_path_b);
registry_->SaveLastActiveProfilesForApp(app_id_a, profiles);
profiles = registry_->GetLastActiveProfilesForApp(app_id_a);
EXPECT_EQ(profiles.size(), 1u);
EXPECT_TRUE(profiles.count(profile_path_b));
// Test SaveLastActiveProfilesForApp with an invalid profile.
profiles.clear();
profiles.insert(profile_path_c);
registry_->SaveLastActiveProfilesForApp(app_id_a, profiles);
profiles = registry_->GetLastActiveProfilesForApp(app_id_a);
EXPECT_EQ(0u, registry_->GetLastActiveProfilesForApp(app_id_a).size());
// Test SaveLastActiveProfilesForApp with a valid and invalid profile. The
// invalid profile should be discarded.
profiles.clear();
profiles.insert(profile_path_a);
profiles.insert(profile_path_c);
registry_->SaveLastActiveProfilesForApp(app_id_a, profiles);
profiles = registry_->GetLastActiveProfilesForApp(app_id_a);
EXPECT_EQ(profiles.size(), 1u);
EXPECT_TRUE(profiles.count(profile_path_a));
// Uninstall for profile a. It should return false because it is still
// installed for profile b. The list of last active profiles should now
// be empty.
EXPECT_FALSE(registry_->OnAppUninstalledForProfile(app_id_a, profile_path_a));
EXPECT_EQ(0u, registry_->GetLastActiveProfilesForApp(app_id_a).size());
profiles = registry_->GetInstalledProfilesForApp(app_id_a);
EXPECT_EQ(profiles.size(), 1u);
EXPECT_TRUE(profiles.count(profile_path_b));
// Uninstall for profile b. It should return true because all profiles are
// gone.
EXPECT_TRUE(registry_->OnAppUninstalledForProfile(app_id_a, profile_path_b));
EXPECT_EQ(0u, registry_->GetInstalledProfilesForApp(app_id_a).size());
EXPECT_EQ(0u, registry_->GetLastActiveProfilesForApp(app_id_a).size());
}
TEST_F(AppShimRegistryTest, InstalledAppsForProfile) {
const std::string app_id_a("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
const std::string app_id_b("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb");
const base::FilePath profile_path_a("/x/y/z/Profile A");
const base::FilePath profile_path_b("/x/y/z/Profile B");
const base::FilePath profile_path_c("/x/y/z/Profile C");
std::set<std::string> apps;
// App A is installed for profiles B and C.
registry_->OnAppInstalledForProfile(app_id_a, profile_path_b);
registry_->OnAppInstalledForProfile(app_id_a, profile_path_c);
EXPECT_EQ(2u, registry_->GetInstalledProfilesForApp(app_id_a).size());
apps = registry_->GetInstalledAppsForProfile(profile_path_a);
EXPECT_TRUE(apps.empty());
apps = registry_->GetInstalledAppsForProfile(profile_path_b);
EXPECT_EQ(1u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_a));
apps = registry_->GetInstalledAppsForProfile(profile_path_c);
EXPECT_EQ(1u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_a));
// App B is installed for profiles A and C.
registry_->OnAppInstalledForProfile(app_id_b, profile_path_a);
registry_->OnAppInstalledForProfile(app_id_b, profile_path_c);
apps = registry_->GetInstalledAppsForProfile(profile_path_a);
EXPECT_EQ(1u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_b));
apps = registry_->GetInstalledAppsForProfile(profile_path_b);
EXPECT_EQ(1u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_a));
apps = registry_->GetInstalledAppsForProfile(profile_path_c);
EXPECT_EQ(2u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_a));
EXPECT_EQ(1u, apps.count(app_id_b));
// Uninstall app A for profile B.
EXPECT_FALSE(registry_->OnAppUninstalledForProfile(app_id_a, profile_path_b));
apps = registry_->GetInstalledAppsForProfile(profile_path_b);
EXPECT_TRUE(apps.empty());
apps = registry_->GetInstalledAppsForProfile(profile_path_c);
EXPECT_EQ(2u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_a));
EXPECT_EQ(1u, apps.count(app_id_b));
// Uninstall app A for profile C.
EXPECT_TRUE(registry_->OnAppUninstalledForProfile(app_id_a, profile_path_c));
apps = registry_->GetInstalledAppsForProfile(profile_path_c);
EXPECT_EQ(1u, apps.size());
EXPECT_EQ(1u, apps.count(app_id_b));
// Uninstall app B for profile C.
EXPECT_FALSE(registry_->OnAppUninstalledForProfile(app_id_b, profile_path_c));
apps = registry_->GetInstalledAppsForProfile(profile_path_c);
EXPECT_TRUE(apps.empty());
}
TEST_F(AppShimRegistryTest, FileHandlers) {
const std::string app_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
base::FilePath profile_path_a("/x/y/z/Profile A");
base::FilePath profile_path_b("/x/y/z/Profile B");
std::set<std::string> extensions;
extensions.insert(".jpg");
extensions.insert(".jpeg");
std::set<std::string> mime_types;
mime_types.insert("text/plain");
auto handlers = registry_->GetHandlersForApp(app_id);
EXPECT_TRUE(handlers.empty());
// Updating handlers for an app that isn't installed in any profile should be
// a noop.
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_a,
extensions, mime_types);
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_TRUE(handlers.empty());
// Install app A in profile B.
registry_->OnAppInstalledForProfile(app_id, profile_path_b);
// Verify updating handlers in profile A.
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_a,
extensions, mime_types);
handlers = registry_->GetHandlersForApp(app_id);
ASSERT_EQ(1u, handlers.size());
EXPECT_EQ(profile_path_a, handlers.begin()->first);
EXPECT_EQ(extensions, handlers.begin()->second.file_handler_extensions);
EXPECT_EQ(mime_types, handlers.begin()->second.file_handler_mime_types);
// Also update handlers in profile B.
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_b,
extensions, mime_types);
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_EQ(2u, handlers.size());
EXPECT_EQ(1u, handlers.count(profile_path_a));
EXPECT_EQ(1u, handlers.count(profile_path_b));
// Verify updating handlers to be empty removes them.
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_a, {}, {});
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_EQ(1u, handlers.size());
EXPECT_EQ(1u, handlers.count(profile_path_b));
// Only setting mime types to empty should not remove extensions and vice
// versa.
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_b,
extensions, {});
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_EQ(1u, handlers.size());
EXPECT_EQ(1u, handlers.count(profile_path_b));
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_b, {},
mime_types);
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_EQ(1u, handlers.size());
EXPECT_EQ(1u, handlers.count(profile_path_b));
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_b, {}, {});
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_TRUE(handlers.empty());
// Verify that updating protocol handlers does not change file handlers.
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_a,
extensions, mime_types);
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_a,
{"ftp"});
handlers = registry_->GetHandlersForApp(app_id);
ASSERT_EQ(1u, handlers.size());
EXPECT_EQ(profile_path_a, handlers.begin()->first);
EXPECT_EQ(extensions, handlers.begin()->second.file_handler_extensions);
EXPECT_EQ(mime_types, handlers.begin()->second.file_handler_mime_types);
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_a, {});
handlers = registry_->GetHandlersForApp(app_id);
ASSERT_EQ(1u, handlers.size());
EXPECT_EQ(profile_path_a, handlers.begin()->first);
EXPECT_EQ(extensions, handlers.begin()->second.file_handler_extensions);
EXPECT_EQ(mime_types, handlers.begin()->second.file_handler_mime_types);
// Verify uninstalling an app also removes handler information.
EXPECT_FALSE(registry_->GetHandlersForApp(app_id).empty());
EXPECT_TRUE(registry_->OnAppUninstalledForProfile(app_id, profile_path_b));
EXPECT_TRUE(registry_->GetHandlersForApp(app_id).empty());
}
TEST_F(AppShimRegistryTest, ProtocolHandlers) {
const std::string app_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
base::FilePath profile_path_a("/x/y/z/Profile A");
base::FilePath profile_path_b("/x/y/z/Profile B");
std::set<std::string> protocols;
protocols.insert("myprotocol");
auto handlers = registry_->GetHandlersForApp(app_id);
EXPECT_TRUE(handlers.empty());
// Updating handlers for an app that isn't installed in any profile should be
// a noop.
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_a,
protocols);
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_TRUE(handlers.empty());
// Install app A in profile B.
registry_->OnAppInstalledForProfile(app_id, profile_path_b);
// Verify updating handlers in profile A.
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_a,
protocols);
handlers = registry_->GetHandlersForApp(app_id);
ASSERT_EQ(1u, handlers.size());
EXPECT_EQ(profile_path_a, handlers.begin()->first);
EXPECT_EQ(protocols, handlers.begin()->second.protocol_handlers);
// Also update handlers in profile B.
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_b,
protocols);
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_EQ(2u, handlers.size());
EXPECT_EQ(1u, handlers.count(profile_path_a));
EXPECT_EQ(1u, handlers.count(profile_path_b));
// Verify updating handlers to be empty removes them.
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_a, {});
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_EQ(1u, handlers.size());
EXPECT_EQ(1u, handlers.count(profile_path_b));
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_b, {});
handlers = registry_->GetHandlersForApp(app_id);
EXPECT_TRUE(handlers.empty());
// Verify that updating file handlers does not change protocol handlers.
registry_->SaveProtocolHandlersForAppAndProfile(app_id, profile_path_a,
protocols);
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_a, {".jpg"},
{});
handlers = registry_->GetHandlersForApp(app_id);
ASSERT_EQ(1u, handlers.size());
EXPECT_EQ(profile_path_a, handlers.begin()->first);
EXPECT_EQ(protocols, handlers.begin()->second.protocol_handlers);
registry_->SaveFileHandlersForAppAndProfile(app_id, profile_path_a, {}, {});
handlers = registry_->GetHandlersForApp(app_id);
ASSERT_EQ(1u, handlers.size());
EXPECT_EQ(profile_path_a, handlers.begin()->first);
EXPECT_EQ(protocols, handlers.begin()->second.protocol_handlers);
// Verify uninstalling an app also removes handler information.
EXPECT_TRUE(registry_->OnAppUninstalledForProfile(app_id, profile_path_b));
EXPECT_TRUE(registry_->GetHandlersForApp(app_id).empty());
}
TEST_F(AppShimRegistryTest, CodeDirectoryHashes) {
const std::string app_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
const uint8_t cd_hash[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
const uint8_t other_cd_hash[] = {10, 11, 12, 13, 14, 15, 16, 17, 18, 19};
base::FilePath profile_path("/x/y/z/Profile");
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Saving code directory hash for an app that isn't in any profile should
// be a noop.
registry_->SaveCdHashForApp(app_id, cd_hash);
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Install app in profile.
registry_->OnAppInstalledForProfile(app_id, profile_path);
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Verify saving code directory hash.
registry_->SaveCdHashForApp(app_id, cd_hash);
EXPECT_TRUE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Ensure that a different code directory hash is invalid for this app.
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, other_cd_hash));
// Verify uninstalling an app removes its code directory hash.
EXPECT_TRUE(registry_->OnAppUninstalledForProfile(app_id, profile_path));
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, cd_hash));
}
TEST_F(AppShimRegistryTest, CodeDirectoryHashesInvalidData) {
const std::string app_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
const uint8_t cd_hash[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
base::FilePath profile_path("/x/y/z/Profile");
// Install app in profile.
registry_->OnAppInstalledForProfile(app_id, profile_path);
registry_->SaveCdHashForApp(app_id, cd_hash);
EXPECT_TRUE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Overwrite the HMAC key with data that cannot be decoded as base64.
local_state_->SetString("app_shims_cdhash_hmac_key",
"this-is-not-valid-base64");
// The existing code directory hash should fail to verify after altering the
// HMAC key.
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Verify that saving the code directory hash again makes it possible to
// verify the hash once more.
registry_->SaveCdHashForApp(app_id, cd_hash);
EXPECT_TRUE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Overwrite the HMAC key with valid base64 data that cannot be decrypted
// via OSCrypt.
local_state_->SetString("app_shims_cdhash_hmac_key",
base::Base64Encode("this-is-not-a-valid-key"));
// The existing code directory hash should fail to verify after altering the
// HMAC key.
EXPECT_FALSE(registry_->VerifyCdHashForApp(app_id, cd_hash));
// Verify that saving the code directory hash again makes it possible to
// verify the hash once more.
registry_->SaveCdHashForApp(app_id, cd_hash);
EXPECT_TRUE(registry_->VerifyCdHashForApp(app_id, cd_hash));
}
} // namespace
|