1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/autofill/content/renderer/form_autofill_issues.h"
#include <algorithm>
#include <string_view>
#include <vector>
#include "base/no_destructor.h"
#include "base/strings/string_split.h"
#include "components/autofill/content/renderer/form_autofill_util.h"
#include "components/autofill/core/common/autofill_features.h"
#include "components/autofill/core/common/form_field_data.h"
#include "third_party/blink/public/common/features.h"
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/web/web_autofill_client.h"
#include "third_party/blink/public/web/web_document.h"
#include "third_party/blink/public/web/web_element_collection.h"
#include "third_party/blink/public/web/web_form_control_element.h"
#include "third_party/blink/public/web/web_input_element.h"
#include "third_party/blink/public/web/web_label_element.h"
#include "third_party/blink/public/web/web_local_frame.h"
using blink::WebDocument;
using blink::WebElement;
using blink::WebElementCollection;
using blink::WebFormControlElement;
using blink::WebFormElement;
using blink::WebInputElement;
using blink::WebLabelElement;
using blink::WebLocalFrame;
using blink::WebString;
using blink::mojom::GenericIssueErrorType;
namespace autofill::form_issues {
using form_util::IsAutofillableElement;
namespace {
constexpr size_t kMaxNumberOfDevtoolsIssuesEmitted = 100;
constexpr std::string_view kFor = "for";
constexpr std::string_view kAriaLabelledBy = "aria-labelledby";
constexpr std::string_view kName = "name";
constexpr std::string_view kId = "id";
constexpr std::string_view kLabel = "label";
constexpr std::string_view kAutocomplete = "autocomplete";
// Wrapper for frequently used WebString constants.
template <const std::string_view& string>
const WebString& GetWebString() {
static const base::NoDestructor<WebString> web_string(
WebString::FromUTF8(string));
return *web_string;
}
void MaybeAppendLabelWithoutControlDevtoolsIssue(
WebLabelElement label,
std::vector<FormIssue>& form_issues) {
if (label.CorrespondingControl()) {
return;
}
const WebString& for_attr = GetWebString<kFor>();
if (!label.HasAttribute(for_attr)) {
// Label has neither for attribute nor a control element was found.
form_issues.emplace_back(
GenericIssueErrorType::kFormLabelHasNeitherForNorNestedInput,
label.GetDomNodeId());
}
}
void MaybeAppendAriaLabelledByDevtoolsIssue(
const WebElement& element,
std::vector<FormIssue>& form_issues) {
const WebString& aria_label_attr = GetWebString<kAriaLabelledBy>();
if (std::ranges::any_of(
base::SplitStringPiece(element.GetAttribute(aria_label_attr).Utf16(),
base::kWhitespaceUTF16, base::KEEP_WHITESPACE,
base::SPLIT_WANT_NONEMPTY),
[&](const auto& id) {
return !element.GetDocument().GetElementById(WebString(id));
})) {
form_issues.emplace_back(
GenericIssueErrorType::kFormAriaLabelledByToNonExistingId,
element.GetDomNodeId(), aria_label_attr);
}
}
void MaybeAppendInputWithEmptyIdAndNameDevtoolsIssue(
const WebFormControlElement& element,
std::vector<FormIssue>& form_issues) {
const WebString& name_attr = GetWebString<kName>();
if (element.GetAttribute(name_attr).IsEmpty() &&
element.GetIdAttribute().IsEmpty()) {
form_issues.emplace_back(
GenericIssueErrorType::kFormEmptyIdAndNameAttributesForInputError,
element.GetDomNodeId());
}
}
int GetShadowHostDOMNodeId(const WebFormControlElement& element) {
WebElement host = element.OwnerShadowHost();
if (!host) {
return /*blink::kInvalidDOMNodeId*/ 0;
}
return host.GetDomNodeId();
}
void MaybeAppendDuplicateIdForInputDevtoolsIssue(
const std::vector<WebFormControlElement>& elements,
std::vector<FormIssue>& form_issues) {
const WebString& id_attr = GetWebString<kId>();
// Create copies of |elements| with ids that can be modified
std::vector<WebFormControlElement> elements_with_id_attr;
elements_with_id_attr.reserve(elements.size());
for (const auto& element : elements) {
if (IsAutofillableElement(element) && !element.GetIdAttribute().IsEmpty()) {
elements_with_id_attr.push_back(element);
}
}
std::ranges::sort(elements_with_id_attr, [](const WebFormControlElement& a,
const WebFormControlElement& b) {
return std::forward_as_tuple(a.GetIdAttribute(),
GetShadowHostDOMNodeId(a)) <
std::forward_as_tuple(b.GetIdAttribute(), GetShadowHostDOMNodeId(b));
});
for (auto it = elements_with_id_attr.begin();
(it = std::ranges::adjacent_find(
it, elements_with_id_attr.end(),
[](const WebFormControlElement& a, const WebFormControlElement& b) {
return a.GetIdAttribute() == b.GetIdAttribute() &&
GetShadowHostDOMNodeId(a) == GetShadowHostDOMNodeId(b);
})) != elements_with_id_attr.end();
it++) {
bool current_element_not_added =
form_issues.empty() ||
form_issues.back().issue_type !=
GenericIssueErrorType::kFormDuplicateIdForInputError ||
form_issues.back().violating_node != it->GetDomNodeId();
if (current_element_not_added) {
form_issues.emplace_back(
GenericIssueErrorType::kFormDuplicateIdForInputError,
it->GetDomNodeId(), id_attr);
}
form_issues.emplace_back(
GenericIssueErrorType::kFormDuplicateIdForInputError,
std::next(it)->GetDomNodeId(), id_attr);
}
}
void MaybeAppendAutocompleteAttributeDevtoolsIssue(
const WebElement& element,
std::vector<FormIssue>& form_issues) {
const WebString& autocomplete_attr = GetWebString<kAutocomplete>();
std::string autocomplete_attribute =
form_util::GetAutocompleteAttribute(element);
if (element.HasAttribute(autocomplete_attr) &&
autocomplete_attribute.empty()) {
form_issues.emplace_back(
GenericIssueErrorType::kFormAutocompleteAttributeEmptyError,
element.GetDomNodeId(), autocomplete_attr);
}
if (IsAutocompleteTypeWrongButWellIntended(autocomplete_attribute)) {
form_issues.emplace_back(
GenericIssueErrorType::
kFormInputHasWrongButWellIntendedAutocompleteValueError,
element.GetDomNodeId(), autocomplete_attr);
}
}
void MaybeAppendInputAssignedAutocompleteValueToIdOrNameAttributesDevtoolsIssue(
const WebFormControlElement& element,
std::vector<FormIssue>& form_issues) {
const WebString& autocomplete_attr = GetWebString<kAutocomplete>();
if (element.HasAttribute(autocomplete_attr)) {
return;
}
auto ParsedHtmlAttributeValueToAutocompleteHasFieldType =
[](const std::string& attribute_value) {
std::optional<AutocompleteParsingResult>
parsed_attribute_to_autocomplete =
ParseAutocompleteAttribute(attribute_value);
if (!parsed_attribute_to_autocomplete) {
return false;
}
return parsed_attribute_to_autocomplete->field_type !=
HtmlFieldType::kUnspecified &&
parsed_attribute_to_autocomplete->field_type !=
HtmlFieldType::kUnrecognized;
};
const WebString& name_attr = GetWebString<kName>();
bool name_attr_matches_autocomplete =
ParsedHtmlAttributeValueToAutocompleteHasFieldType(
element.GetAttribute(name_attr).Utf8());
bool id_attr_matches_autocomplete =
ParsedHtmlAttributeValueToAutocompleteHasFieldType(
element.GetIdAttribute().Utf8());
if (name_attr_matches_autocomplete || id_attr_matches_autocomplete) {
WebString attribute_with_autocomplete_value =
id_attr_matches_autocomplete ? GetWebString<kId>() : name_attr;
form_issues.emplace_back(
GenericIssueErrorType::
kFormInputAssignedAutocompleteValueToIdOrNameAttributeError,
element.GetDomNodeId(), attribute_with_autocomplete_value);
return;
}
}
void AppendFormIssuesInternal(
const std::vector<WebFormControlElement>& elements,
std::vector<FormIssue>& form_issues) {
if (elements.size() == 0) {
return;
}
const WebString& label_attr = GetWebString<kLabel>();
WebElementCollection labels =
elements[0].GetDocument().GetElementsByHTMLTagName(label_attr);
CHECK(labels);
for (WebElement item = labels.FirstItem(); item; item = labels.NextItem()) {
WebLabelElement label = item.To<WebLabelElement>();
MaybeAppendLabelWithoutControlDevtoolsIssue(label, form_issues);
}
MaybeAppendDuplicateIdForInputDevtoolsIssue(elements, form_issues);
for (const WebFormControlElement& element : elements) {
if (!form_util::IsAutofillableElement(element)) {
continue;
}
MaybeAppendAriaLabelledByDevtoolsIssue(element, form_issues);
MaybeAppendAutocompleteAttributeDevtoolsIssue(element, form_issues);
MaybeAppendInputWithEmptyIdAndNameDevtoolsIssue(element, form_issues);
MaybeAppendInputAssignedAutocompleteValueToIdOrNameAttributesDevtoolsIssue(
element, form_issues);
}
}
// Looks for form issues in `control_elements`, e.g., inputs with duplicate ids
// and returns a vector that is the union of `form_issues` and the new issues
// found.
std::vector<FormIssue> GetFormIssues(
const std::vector<blink::WebFormControlElement>& control_elements,
std::vector<FormIssue> form_issues) {
AppendFormIssuesInternal(control_elements, form_issues);
return form_issues;
}
// Method specific to find issues regarding label `for` attribute. This needs to
// be called after label extraction. Similar to `GetFormIssues` it returns
// a vector that is the union of `form_issues` and the new issues found.
std::vector<FormIssue> CheckForLabelsWithIncorrectForAttribute(
const blink::WebDocument& document,
const std::vector<FormFieldData>& fields,
std::vector<FormIssue> form_issues) {
const WebString& for_attr = GetWebString<kFor>();
const WebString& label_attr = GetWebString<kLabel>();
std::set<std::u16string> elements_whose_name_match_a_label_for_attr;
for (const FormFieldData& field : fields) {
if (field.label_source() == FormFieldData::LabelSource::kForName) {
elements_whose_name_match_a_label_for_attr.insert(field.name_attribute());
}
}
WebElementCollection labels = document.GetElementsByHTMLTagName(label_attr);
for (WebElement item = labels.FirstItem(); item; item = labels.NextItem()) {
WebLabelElement label = item.To<WebLabelElement>();
if (label.CorrespondingControl() || !label.HasAttribute(for_attr)) {
continue;
}
if (elements_whose_name_match_a_label_for_attr.contains(
label.GetAttribute(for_attr).Utf16())) {
// Add a DevTools issue informing the developer that the `label`'s for-
// attribute is pointing to the name of a field, even though the ID
// should be used.
form_issues.emplace_back(GenericIssueErrorType::kFormLabelForNameError,
label.GetDomNodeId(), for_attr);
} else {
// Label has for attribute but no labellable element whose id OR name
// matches it.
// This issue is not emitted in case an element has a name that matches
// it, in this case we emit kFormLabelForNameError to educate developers
// that labels should be linked to element ids.
form_issues.emplace_back(
GenericIssueErrorType::kFormLabelForMatchesNonExistingIdError,
label.GetDomNodeId(), for_attr);
}
}
return form_issues;
}
} // namespace
void MaybeEmitFormIssuesToDevtools(blink::WebLocalFrame& web_local_frame,
base::span<const FormData> forms) {
// Only log the issues if devtools is connected.
if (!web_local_frame.IsInspectorConnected()) {
return;
}
WebDocument document = web_local_frame.GetDocument();
std::vector<FormIssue> form_issues;
// Get issues from forms input elements.
for (const WebFormElement& form_element : document.GetTopLevelForms()) {
form_issues = form_issues::GetFormIssues(
form_element.GetFormControlElements(), std::move(form_issues));
}
// Get issues from input elements that belong to no form.
form_issues = form_issues::GetFormIssues(
form_util::GetOwnedAutofillableFormControls(document, WebFormElement()),
std::move(form_issues));
// Look for fields that after parsed were found to have labels incorrectly
// used.
for (const FormData& form : forms) {
form_issues = form_issues::CheckForLabelsWithIncorrectForAttribute(
document, form.fields(), std::move(form_issues));
}
if (form_issues.size() > kMaxNumberOfDevtoolsIssuesEmitted) {
form_issues.erase(form_issues.begin() + kMaxNumberOfDevtoolsIssuesEmitted,
form_issues.end());
}
for (const FormIssue& form_issue : form_issues) {
web_local_frame.AddGenericIssue(form_issue.issue_type,
form_issue.violating_node,
form_issue.violating_node_attribute);
}
}
std::vector<FormIssue> GetFormIssuesForTesting( // IN-TEST
const std::vector<blink::WebFormControlElement>& control_elements,
std::vector<FormIssue> form_issues) {
return GetFormIssues(control_elements, form_issues);
}
std::vector<FormIssue>
CheckForLabelsWithIncorrectForAttributeForTesting( // IN-TEST
const blink::WebDocument& document,
const std::vector<FormFieldData>& fields,
std::vector<FormIssue> form_issues) {
return CheckForLabelsWithIncorrectForAttribute(document, fields, form_issues);
}
} // namespace autofill::form_issues
|