1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/omnibox_view.h"
#include <stddef.h>
#include <array>
#include <string>
#include <utility>
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/omnibox_controller.h"
#include "components/omnibox/browser/omnibox_text_util.h"
#include "components/omnibox/browser/test_omnibox_client.h"
#include "components/omnibox/browser/test_omnibox_edit_model.h"
#include "components/omnibox/browser/test_omnibox_popup_view.h"
#include "components/omnibox/browser/test_omnibox_view.h"
#include "components/omnibox/common/omnibox_features.h"
#include "components/search_engines/template_url_data.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/ui_base_features.h"
#include "ui/gfx/color_palette.h"
#include "ui/gfx/favicon_size.h"
#include "ui/gfx/image/image_unittest_util.h"
#include "ui/gfx/paint_vector_icon.h"
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
#include "components/omnibox/browser/vector_icons.h" // nogncheck
#include "components/vector_icons/vector_icons.h" // nogncheck
#endif
using base::ASCIIToUTF16;
using testing::_;
using testing::DoAll;
using testing::Return;
using testing::SaveArg;
using testing::SaveArgPointee;
namespace {
class OmniboxViewTest : public testing::Test {
public:
OmniboxViewTest()
: bookmark_model_(bookmarks::TestBookmarkClient::CreateModel()) {
auto omnibox_client = std::make_unique<TestOmniboxClient>();
omnibox_client_ = omnibox_client.get();
EXPECT_CALL(*client(), GetBookmarkModel())
.WillRepeatedly(Return(bookmark_model_.get()));
view_ = std::make_unique<TestOmniboxView>(std::move(omnibox_client));
view_->controller()->SetEditModelForTesting(
std::make_unique<TestOmniboxEditModel>(view_->controller(), view_.get(),
/*pref_service=*/nullptr));
}
TestOmniboxView* view() { return view_.get(); }
TestOmniboxEditModel* model() {
return static_cast<TestOmniboxEditModel*>(view_->model());
}
TestOmniboxClient* client() { return omnibox_client_; }
bookmarks::BookmarkModel* bookmark_model() { return bookmark_model_.get(); }
private:
base::test::TaskEnvironment task_environment_;
std::unique_ptr<TestOmniboxView> view_;
std::unique_ptr<bookmarks::BookmarkModel> bookmark_model_;
raw_ptr<TestOmniboxClient> omnibox_client_;
};
class OmniboxViewPopupTest : public testing::Test {
public:
OmniboxViewPopupTest() {
auto omnibox_client = std::make_unique<TestOmniboxClient>();
omnibox_client_ = omnibox_client.get();
view_ = std::make_unique<TestOmniboxView>(std::move(omnibox_client));
view_->controller()->SetEditModelForTesting(
std::make_unique<TestOmniboxEditModel>(view_->controller(), view_.get(),
/*pref_service=*/nullptr));
model()->set_popup_view(&popup_view_);
model()->SetPopupIsOpen(true);
}
TestOmniboxView* view() { return view_.get(); }
TestOmniboxEditModel* model() {
return static_cast<TestOmniboxEditModel*>(view_->model());
}
TestOmniboxClient* client() { return omnibox_client_; }
private:
base::test::TaskEnvironment task_environment_;
std::unique_ptr<TestOmniboxView> view_;
raw_ptr<TestOmniboxClient> omnibox_client_;
TestOmniboxPopupView popup_view_;
};
} // namespace
TEST_F(OmniboxViewTest, TestStripSchemasUnsafeForPaste) {
constexpr const auto urls = std::to_array<const char*>({
" \x01 ", // Safe query.
"http://www.google.com?q=javascript:alert(0)", // Safe URL.
"JavaScript", // Safe query.
"javaScript:", // Unsafe JS URL.
" javaScript: ", // Unsafe JS URL.
"javAscript:Javascript:javascript", // Unsafe JS URL.
"javAscript:alert(1)", // Unsafe JS URL.
"javAscript:javascript:alert(2)", // Single strip unsafe.
"jaVascript:\njavaScript:\x01 alert(3) \x01", // Single strip unsafe.
("\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16\x17"
"\x18\x19 JavaScript:alert(4)"), // Leading control chars unsafe.
"\x01\x02javascript:\x03\x04JavaScript:alert(5)", // Embedded control
// characters unsafe.
});
constexpr const auto expecteds = std::to_array<const char*>({
" \x01 ", // Safe query.
"http://www.google.com?q=javascript:alert(0)", // Safe URL.
"JavaScript", // Safe query.
"", // Unsafe JS URL.
"", // Unsafe JS URL.
"javascript", // Unsafe JS URL.
"alert(1)", // Unsafe JS URL.
"alert(2)", // Single strip unsafe.
"alert(3) \x01", // Single strip unsafe.
"alert(4)", // Leading control chars unsafe.
"alert(5)", // Embedded control characters unsafe.
});
for (size_t i = 0; i < std::size(urls); i++) {
EXPECT_EQ(ASCIIToUTF16(expecteds[i]),
omnibox::StripJavascriptSchemas(base::UTF8ToUTF16(urls[i])));
}
}
TEST_F(OmniboxViewTest, SanitizeTextForPaste) {
const struct {
std::u16string input;
std::u16string output;
} kTestcases[] = {
// No whitespace: leave unchanged.
{std::u16string(), std::u16string()},
{u"a", u"a"},
{u"abc", u"abc"},
// Leading/trailing whitespace: remove.
{u" abc", u"abc"},
{u" \n abc", u"abc"},
{u"abc ", u"abc"},
{u"abc\t \t", u"abc"},
{u"\nabc\n", u"abc"},
// All whitespace: Convert to single space.
{u" ", u" "},
{u"\n", u" "},
{u" ", u" "},
{u"\n\n\n", u" "},
{u" \n\t", u" "},
// Broken URL has newlines stripped.
{u"http://www.chromium.org/developers/testing/chromium-\n"
u"build-infrastructure/tour-of-the-chromium-buildbot",
u"http://www.chromium.org/developers/testing/"
u"chromium-build-infrastructure/tour-of-the-chromium-buildbot"},
// Multi-line address is converted to a single-line address.
{u"1600 Amphitheatre Parkway\nMountain View, CA",
u"1600 Amphitheatre Parkway Mountain View, CA"},
// Line-breaking the JavaScript scheme with no other whitespace results in
// a
// dangerous URL that is sanitized by dropping the scheme.
{u"java\x0d\x0ascript:alert(0)", u"alert(0)"},
// Line-breaking the JavaScript scheme with whitespace elsewhere in the
// string results in a safe string with a space replacing the line break.
{u"java\x0d\x0ascript: alert(0)", u"java script: alert(0)"},
// Unusual URL with multiple internal spaces is preserved as-is.
{u"http://foo.com/a. b", u"http://foo.com/a. b"},
// URL with unicode whitespace is also preserved as-is.
{u"http://foo.com/a\x3000"
u"b",
u"http://foo.com/a\x3000"
u"b"},
};
for (const auto& testcase : kTestcases) {
EXPECT_EQ(testcase.output, omnibox::SanitizeTextForPaste(testcase.input));
}
}
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
// Tests GetIcon returns the default search icon when the match is a search
// query.
TEST_F(OmniboxViewTest, DISABLED_GetIcon_Default) {
ui::ImageModel expected_icon =
ui::ImageModel::FromVectorIcon(vector_icons::kSearchChromeRefreshIcon,
gfx::kPlaceholderColor, gfx::kFaviconSize);
ui::ImageModel icon = view()->GetIcon(
gfx::kFaviconSize, gfx::kPlaceholderColor, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, gfx::kPlaceholderColor, base::DoNothing(), false);
EXPECT_EQ(expected_icon, icon);
}
// Tests GetIcon returns the bookmark icon when the match is bookmarked.
TEST_F(OmniboxViewTest, DISABLED_GetIcon_BookmarkIcon) {
const GURL kUrl("https://bookmarks.com");
AutocompleteMatch match;
match.destination_url = kUrl;
model()->SetCurrentMatchForTest(match);
bookmark_model()->AddURL(bookmark_model()->bookmark_bar_node(), 0,
u"a bookmark", kUrl);
ui::ImageModel expected_icon =
ui::ImageModel::FromVectorIcon(omnibox::kBookmarkChromeRefreshIcon,
gfx::kPlaceholderColor, gfx::kFaviconSize);
ui::ImageModel icon = view()->GetIcon(
gfx::kFaviconSize, gfx::kPlaceholderColor, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, gfx::kPlaceholderColor, base::DoNothing(), false);
EXPECT_EQ(expected_icon, icon);
}
// Tests GetIcon returns the keyword search provider favicon when the match is a
// non-Google search query.
TEST_F(OmniboxViewTest, GetIcon_NonGoogleKeywordSearch) {
SkBitmap bitmap;
bitmap.allocN32Pixels(16, 16);
bitmap.eraseColor(SK_ColorRED);
gfx::Image expected_image =
gfx::Image(gfx::ImageSkia::CreateFrom1xBitmap(bitmap));
EXPECT_CALL(*client(), GetFaviconForKeywordSearchProvider(_, _))
.WillOnce(Return(expected_image));
TemplateURLData data;
data.SetKeyword(u"foo");
data.SetURL("https://foo.com");
TemplateURL* turl =
view()->controller()->client()->GetTemplateURLService()->Add(
std::make_unique<TemplateURL>(data));
ASSERT_TRUE(turl);
AutocompleteMatch match;
match.type = AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED;
match.keyword = u"foo";
model()->SetCurrentMatchForTest(match);
ui::ImageModel image = view()->GetIcon(
gfx::kFaviconSize, gfx::kPlaceholderColor, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, gfx::kPlaceholderColor, base::DoNothing(), false);
gfx::test::CheckColors(bitmap.getColor(0, 0),
image.GetImage().ToSkBitmap()->getColor(0, 0));
}
// Tests GetIcon returns the website's favicon when the match is a website.
TEST_F(OmniboxViewTest, GetIcon_Favicon) {
const GURL kUrl("https://woahDude.com");
GURL page_url;
EXPECT_CALL(*client(), GetFaviconForPageUrl(_, _))
.WillOnce(DoAll(SaveArg<0>(&page_url), Return(gfx::Image())));
AutocompleteMatch match;
match.type = AutocompleteMatchType::URL_WHAT_YOU_TYPED;
match.destination_url = kUrl;
model()->SetCurrentMatchForTest(match);
view()->GetIcon(gfx::kFaviconSize, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, base::DoNothing(), false);
EXPECT_EQ(page_url, kUrl);
}
// Tests GetIcon returns the search aggregator's favicon by bitmap when the
// match is a non-Google search query with search aggregator keyword.
TEST_F(OmniboxViewPopupTest, GetIcon_SearchAggregatorKeywordSearch) {
SkBitmap bitmap;
bitmap.allocN32Pixels(16, 16);
bitmap.eraseColor(SK_ColorRED);
gfx::Image expected_image =
gfx::Image(gfx::ImageSkia::CreateFrom1xBitmap(bitmap));
EXPECT_CALL(*client(), GetFaviconForKeywordSearchProvider(_, _)).Times(0);
TemplateURLData data;
data.SetKeyword(u"foo");
data.SetURL("https://foo.com");
data.favicon_url = GURL("https://foo.com/icon.png");
data.policy_origin = TemplateURLData::PolicyOrigin::kSearchAggregator;
TemplateURL* turl =
view()->controller()->client()->GetTemplateURLService()->Add(
std::make_unique<TemplateURL>(data));
ASSERT_TRUE(turl);
// Sets the icon bitmap for search aggregator.
model()->SetIconBitmap(GURL("https://foo.com/icon.png"), bitmap);
AutocompleteMatch match;
match.type = AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED;
match.keyword = u"foo";
model()->SetCurrentMatchForTest(match);
ui::ImageModel image = view()->GetIcon(
gfx::kFaviconSize, gfx::kPlaceholderColor, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, gfx::kPlaceholderColor, base::DoNothing(), false);
gfx::test::CheckColors(bitmap.getColor(0, 0),
image.GetImage().ToSkBitmap()->getColor(0, 0));
}
// Tests GetIcon returns the website's favicon when the match is a website.
TEST_F(OmniboxViewPopupTest, GetIcon_IconUrl) {
SkBitmap bitmap;
bitmap.allocN32Pixels(16, 16);
bitmap.eraseColor(SK_ColorRED);
EXPECT_CALL(*client(), GetFaviconForPageUrl(_, _)).Times(0);
// Creates a set of matches.
ACMatches matches;
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::NAVSUGGEST);
match.icon_url = GURL("https://example.com/icon.png");
matches.push_back(match);
AutocompleteResult* result =
&view()->controller()->autocomplete_controller()->published_result_;
result->AppendMatches(matches);
model()->SetCurrentMatchForTest(match);
// Sets the icon bitmap for search aggregator match.
model()->SetIconBitmap(GURL("https://example.com/icon.png"), bitmap);
ui::ImageModel image = view()->GetIcon(
gfx::kFaviconSize, gfx::kPlaceholderColor, gfx::kPlaceholderColor,
gfx::kPlaceholderColor, gfx::kPlaceholderColor, base::DoNothing(), false);
gfx::test::CheckColors(bitmap.getColor(0, 0),
image.GetImage().ToSkBitmap()->getColor(0, 0));
}
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
// Tests GetStateChanges correctly determines if text was deleted.
TEST_F(OmniboxViewTest, GetStateChanges_DeletedText) {
{
// Continuing autocompletion
auto state_before =
TestOmniboxView::CreateState("google.com", 10, 3); // goo[gle.com]
auto state_after = TestOmniboxView::CreateState("goog", 4, 4); // goog|
auto state_changes = view()->GetStateChanges(state_before, state_after);
EXPECT_FALSE(state_changes.just_deleted_text);
}
{
// Typing not the autocompletion
auto state_before =
TestOmniboxView::CreateState("google.com", 1, 10); // g[oogle.com]
auto state_after = TestOmniboxView::CreateState("gi", 2, 2); // gi|
auto state_changes = view()->GetStateChanges(state_before, state_after);
EXPECT_FALSE(state_changes.just_deleted_text);
}
{
// Deleting autocompletion
auto state_before =
TestOmniboxView::CreateState("google.com", 1, 10); // g[oogle.com]
auto state_after = TestOmniboxView::CreateState("g", 1, 1); // g|
auto state_changes = view()->GetStateChanges(state_before, state_after);
EXPECT_TRUE(state_changes.just_deleted_text);
}
{
// Inserting
auto state_before =
TestOmniboxView::CreateState("goole.com", 3, 3); // goo|le.com
auto state_after =
TestOmniboxView::CreateState("google.com", 4, 4); // goog|le.com
auto state_changes = view()->GetStateChanges(state_before, state_after);
EXPECT_FALSE(state_changes.just_deleted_text);
}
{
// Deleting
auto state_before =
TestOmniboxView::CreateState("googgle.com", 5, 5); // googg|le.com
auto state_after =
TestOmniboxView::CreateState("google.com", 4, 4); // goog|le.com
auto state_changes = view()->GetStateChanges(state_before, state_after);
EXPECT_TRUE(state_changes.just_deleted_text);
}
{
// Replacing
auto state_before =
TestOmniboxView::CreateState("goojle.com", 3, 4); // goo[j]le.com
auto state_after =
TestOmniboxView::CreateState("google.com", 4, 4); // goog|le.com
auto state_changes = view()->GetStateChanges(state_before, state_after);
EXPECT_FALSE(state_changes.just_deleted_text);
}
}
|