1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/os_crypt/sync/os_crypt.h"
#include <string>
#include <vector>
#include "base/compiler_specific.h"
#include "base/containers/span.h"
#include "base/functional/bind.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/threading/thread.h"
#include "build/build_config.h"
#include "components/os_crypt/sync/os_crypt_metrics.h"
#include "components/os_crypt/sync/os_crypt_mocker.h"
#include "testing/gtest/include/gtest/gtest.h"
#if BUILDFLAG(IS_LINUX)
#include "components/os_crypt/sync/os_crypt_mocker_linux.h"
#endif
#if BUILDFLAG(IS_WIN)
#include "components/prefs/testing_pref_service.h"
#include "crypto/random.h"
#endif
namespace {
class OSCryptTest : public testing::Test {
public:
OSCryptTest() { OSCryptMocker::SetUp(); }
OSCryptTest(const OSCryptTest&) = delete;
OSCryptTest& operator=(const OSCryptTest&) = delete;
~OSCryptTest() override { OSCryptMocker::TearDown(); }
};
TEST_F(OSCryptTest, String16EncryptionDecryption) {
std::u16string plaintext;
std::u16string result;
std::string utf8_plaintext;
std::string utf8_result;
std::string ciphertext;
// Test borderline cases (empty strings).
EXPECT_TRUE(OSCrypt::EncryptString16(plaintext, &ciphertext));
EXPECT_TRUE(OSCrypt::DecryptString16(ciphertext, &result));
EXPECT_EQ(plaintext, result);
// Test a simple string.
plaintext = u"hello";
EXPECT_TRUE(OSCrypt::EncryptString16(plaintext, &ciphertext));
EXPECT_TRUE(OSCrypt::DecryptString16(ciphertext, &result));
EXPECT_EQ(plaintext, result);
// Test a 16-byte aligned string. This previously hit a boundary error in
// base::OSCrypt::Crypt() on Mac.
plaintext = u"1234567890123456";
EXPECT_TRUE(OSCrypt::EncryptString16(plaintext, &ciphertext));
EXPECT_TRUE(OSCrypt::DecryptString16(ciphertext, &result));
EXPECT_EQ(plaintext, result);
// Test Unicode.
char16_t wchars[] = {0xdbeb, 0xdf1b, 0x4e03, 0x6708, 0x8849, 0x661f, 0x671f,
0x56db, 0x597c, 0x4e03, 0x6708, 0x56db, 0x6708, 0xe407,
0xdbaf, 0xdeb5, 0x4ec5, 0x544b, 0x661f, 0x671f, 0x65e5,
0x661f, 0x671f, 0x4e94, 0xd8b1, 0xdce1, 0x7052, 0x5095,
0x7c0b, 0xe586, 0};
plaintext = wchars;
utf8_plaintext = base::UTF16ToUTF8(plaintext);
EXPECT_EQ(plaintext, base::UTF8ToUTF16(utf8_plaintext));
EXPECT_TRUE(OSCrypt::EncryptString16(plaintext, &ciphertext));
EXPECT_TRUE(OSCrypt::DecryptString16(ciphertext, &result));
EXPECT_EQ(plaintext, result);
EXPECT_TRUE(OSCrypt::DecryptString(ciphertext, &utf8_result));
EXPECT_EQ(utf8_plaintext, base::UTF16ToUTF8(result));
EXPECT_TRUE(OSCrypt::EncryptString(utf8_plaintext, &ciphertext));
EXPECT_TRUE(OSCrypt::DecryptString16(ciphertext, &result));
EXPECT_EQ(plaintext, result);
EXPECT_TRUE(OSCrypt::DecryptString(ciphertext, &utf8_result));
EXPECT_EQ(utf8_plaintext, base::UTF16ToUTF8(result));
}
TEST_F(OSCryptTest, EncryptionDecryption) {
std::string plaintext;
std::string result;
std::string ciphertext;
// Test borderline cases (empty strings).
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &result));
EXPECT_EQ(plaintext, result);
// Test a simple string.
plaintext = "hello";
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &result));
EXPECT_EQ(plaintext, result);
// Make sure it null terminates.
plaintext.assign("hello", 3);
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &result));
EXPECT_EQ(plaintext, "hel");
}
TEST_F(OSCryptTest, CypherTextDiffers) {
std::string plaintext;
std::string result;
std::string ciphertext;
// Test borderline cases (empty strings).
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &result));
// |cyphertext| is empty on the Mac, different on Windows.
EXPECT_TRUE(ciphertext.empty() || plaintext != ciphertext);
EXPECT_EQ(plaintext, result);
// Test a simple string.
plaintext = "hello";
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &result));
EXPECT_NE(plaintext, ciphertext);
EXPECT_EQ(plaintext, result);
// Make sure it null terminates.
plaintext.assign("hello", 3);
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &result));
EXPECT_NE(plaintext, ciphertext);
EXPECT_EQ(result, "hel");
}
TEST_F(OSCryptTest, DecryptError) {
std::string plaintext;
std::string result;
std::string ciphertext;
// Test a simple string, messing with ciphertext prior to decrypting.
plaintext = "hello";
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
EXPECT_NE(plaintext, ciphertext);
ASSERT_LT(4UL, ciphertext.size());
ciphertext[3] = ciphertext[3] + 1;
EXPECT_FALSE(OSCrypt::DecryptString(ciphertext, &result));
EXPECT_NE(plaintext, result);
EXPECT_TRUE(result.empty());
}
TEST_F(OSCryptTest, Metrics) {
{
std::string ciphertext;
EXPECT_TRUE(OSCrypt::EncryptString("secret", &ciphertext));
base::HistogramTester histograms;
std::string plaintext;
EXPECT_TRUE(OSCrypt::DecryptString(ciphertext, &plaintext));
#if BUILDFLAG(IS_WIN)
histograms.ExpectTotalCount("OSCrypt.EncryptionPrefixVersion", 0);
#else
#if BUILDFLAG(IS_LINUX)
// Linux defaults to using a `v11` key.
const os_crypt::EncryptionPrefixVersion expected =
os_crypt::EncryptionPrefixVersion::kVersion11;
#else
// All other non-Windows platforms use a `v10` key.
const os_crypt::EncryptionPrefixVersion expected =
os_crypt::EncryptionPrefixVersion::kVersion10;
#endif // BUILDFLAG(IS_LINUX)
histograms.ExpectUniqueSample("OSCrypt.EncryptionPrefixVersion", expected,
1u);
#endif // BUILDFLAG(IS_WIN)
}
{
base::HistogramTester histograms;
std::string plaintext;
// Empty string should not log any histograms, but only returns success on
// non-Windows.
std::ignore = OSCrypt::DecryptString(std::string(), &plaintext);
histograms.ExpectTotalCount("OSCrypt.EncryptionPrefixVersion", 0);
}
{
base::HistogramTester histograms;
std::string plaintext;
// On Windows, this call will fail so ignore the return value. That's tested
// elsewhere and this test only cares about metrics.
std::ignore = OSCrypt::DecryptString("invaliddata!", &plaintext);
#if BUILDFLAG(IS_WIN)
histograms.ExpectTotalCount("OSCrypt.EncryptionPrefixVersion", 0);
#else
histograms.ExpectUniqueSample("OSCrypt.EncryptionPrefixVersion",
os_crypt::EncryptionPrefixVersion::kNoVersion,
1u);
#endif // BUILDFLAG(IS_WIN)
}
}
class OSCryptConcurrencyTest : public testing::Test {
public:
OSCryptConcurrencyTest() { OSCryptMocker::SetUp(); }
OSCryptConcurrencyTest(const OSCryptConcurrencyTest&) = delete;
OSCryptConcurrencyTest& operator=(const OSCryptConcurrencyTest&) = delete;
~OSCryptConcurrencyTest() override { OSCryptMocker::TearDown(); }
};
// Flaky on Win 7 (dbg) and win-asan, see https://crbug.com/1066699
#if BUILDFLAG(IS_WIN)
#define MAYBE_ConcurrentInitialization DISABLED_ConcurrentInitialization
#else
#define MAYBE_ConcurrentInitialization ConcurrentInitialization
#endif
TEST_F(OSCryptConcurrencyTest, MAYBE_ConcurrentInitialization) {
// Launch multiple threads
base::Thread thread1("thread1");
base::Thread thread2("thread2");
std::vector<base::Thread*> threads = {&thread1, &thread2};
for (base::Thread* thread : threads) {
ASSERT_TRUE(thread->Start());
}
// Make calls.
for (base::Thread* thread : threads) {
ASSERT_TRUE(thread->task_runner()->PostTask(
FROM_HERE, base::BindOnce([]() -> void {
std::string plaintext = "secrets";
std::string encrypted;
std::string decrypted;
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &encrypted));
ASSERT_TRUE(OSCrypt::DecryptString(encrypted, &decrypted));
ASSERT_EQ(plaintext, decrypted);
})));
}
// Cleanup
for (base::Thread* thread : threads) {
thread->Stop();
}
}
#if BUILDFLAG(IS_WIN)
class OSCryptTestWin : public testing::Test {
public:
OSCryptTestWin() = default;
OSCryptTestWin(const OSCryptTestWin&) = delete;
OSCryptTestWin& operator=(const OSCryptTestWin&) = delete;
~OSCryptTestWin() override { OSCryptMocker::ResetState(); }
};
// This test verifies that the header of the data returned from CryptProtectData
// never collides with the kEncryptionVersionPrefix ("v10") used in
// os_crypt_win.cc. If this ever happened, we would not be able to distinguish
// between data encrypted using the legacy DPAPI interface, and data that's been
// encrypted with the new session key.
// If this test ever breaks do not ignore it as it might result in data loss for
// users.
TEST_F(OSCryptTestWin, DPAPIHeader) {
OSCryptMocker::SetLegacyEncryption(true);
std::string plaintext(10, '\0');
crypto::RandBytes(base::as_writable_byte_span(plaintext));
std::string ciphertext;
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
using std::string_literals::operator""s;
const std::string expected_header("\x01\x00\x00\x00"s);
ASSERT_EQ(4U, expected_header.length());
ASSERT_TRUE(ciphertext.length() >= expected_header.length());
std::string dpapi_header = ciphertext.substr(0, expected_header.length());
EXPECT_EQ(expected_header, dpapi_header);
}
TEST_F(OSCryptTestWin, ReadOldData) {
OSCryptMocker::SetLegacyEncryption(true);
std::string plaintext = "secrets";
std::string legacy_ciphertext;
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &legacy_ciphertext));
OSCryptMocker::SetLegacyEncryption(false);
TestingPrefServiceSimple pref_service_simple;
OSCrypt::RegisterLocalPrefs(pref_service_simple.registry());
ASSERT_TRUE(OSCrypt::Init(&pref_service_simple));
std::string decrypted;
// Should be able to decrypt data encrypted with DPAPI.
ASSERT_TRUE(OSCrypt::DecryptString(legacy_ciphertext, &decrypted));
EXPECT_EQ(plaintext, decrypted);
// Should now encrypt same plaintext to get different ciphertext.
std::string new_ciphertext;
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &new_ciphertext));
// Should be different from DPAPI ciphertext.
EXPECT_NE(legacy_ciphertext, new_ciphertext);
// Decrypt new ciphertext to give original string.
ASSERT_TRUE(OSCrypt::DecryptString(new_ciphertext, &decrypted));
EXPECT_EQ(plaintext, decrypted);
}
TEST_F(OSCryptTestWin, PrefsKeyTest) {
TestingPrefServiceSimple first_prefs;
OSCrypt::RegisterLocalPrefs(first_prefs.registry());
// Verify new random key can be generated.
ASSERT_TRUE(OSCrypt::Init(&first_prefs));
std::string first_key = OSCrypt::GetRawEncryptionKey();
std::string plaintext = "secrets";
std::string ciphertext;
ASSERT_TRUE(OSCrypt::EncryptString(plaintext, &ciphertext));
TestingPrefServiceSimple second_prefs;
OSCrypt::RegisterLocalPrefs(second_prefs.registry());
OSCryptMocker::ResetState();
ASSERT_TRUE(OSCrypt::Init(&second_prefs));
std::string second_key = OSCrypt::GetRawEncryptionKey();
// Keys should be different since they are random.
EXPECT_NE(first_key, second_key);
std::string decrypted;
// Cannot decrypt with the wrong key.
EXPECT_FALSE(OSCrypt::DecryptString(ciphertext, &decrypted));
// Initialize OSCrypt from existing key.
OSCryptMocker::ResetState();
OSCrypt::SetRawEncryptionKey(first_key);
// Verify decryption works with first key.
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &decrypted));
EXPECT_EQ(plaintext, decrypted);
// Initialize OSCrypt from existing prefs.
OSCryptMocker::ResetState();
ASSERT_TRUE(OSCrypt::Init(&first_prefs));
// Verify decryption works with key from first prefs.
ASSERT_TRUE(OSCrypt::DecryptString(ciphertext, &decrypted));
EXPECT_EQ(plaintext, decrypted);
}
// This test verifies that an existing key is re-encrypted if the pref
// `os_crypt.audit_enabled` is not set, enabling the audit flag and setting the
// data description `szDataDescr` on the data.
TEST_F(OSCryptTestWin, AuditMigrationTest) {
// Taken from os_crypt_win.cc.
constexpr char kOsCryptEncryptedKeyPrefName[] = "os_crypt.encrypted_key";
constexpr char kOsCryptAuditEnabledPrefName[] = "os_crypt.audit_enabled";
TestingPrefServiceSimple prefs;
OSCrypt::RegisterLocalPrefs(prefs.registry());
// Verify new random key can be generated.
ASSERT_TRUE(OSCrypt::Init(&prefs));
EXPECT_TRUE(prefs.GetBoolean(kOsCryptAuditEnabledPrefName));
auto encrypted_key = prefs.GetString(kOsCryptEncryptedKeyPrefName);
EXPECT_TRUE(!encrypted_key.empty());
// Clear state, and fake that the key does not have audit enabled for testing
// by clearing the pref.
OSCrypt::ResetStateForTesting();
prefs.ClearPref(kOsCryptAuditEnabledPrefName);
// Init again with same pref store, this should cause the raw key to be
// re-encrypted with audit enabled.
ASSERT_TRUE(OSCrypt::Init(&prefs));
EXPECT_TRUE(prefs.GetBoolean(kOsCryptAuditEnabledPrefName));
auto encrypted_key2 = prefs.GetString(kOsCryptEncryptedKeyPrefName);
EXPECT_TRUE(!encrypted_key2.empty());
// DPAPI guarantees that two identical data will encrypt to different values
// since it uses a random 16-byte salt internally, so this check is used to
// show that the re-encryption has occurred.
EXPECT_NE(encrypted_key, encrypted_key2);
// Clear state again, this time to test that the data only gets re-encrypted
// once.
OSCrypt::ResetStateForTesting();
ASSERT_TRUE(OSCrypt::Init(&prefs));
auto encrypted_key3 = prefs.GetString(kOsCryptEncryptedKeyPrefName);
// This time, since the key has already been re-encrypted and re-encryption
// only happens once, it will be left alone and the encrypted key data should
// be identical.
EXPECT_EQ(encrypted_key2, encrypted_key3);
}
#endif // BUILDFLAG(IS_WIN)
} // namespace
|