1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "components/password_manager/ios/password_suggestion_helper.h"
#import "base/memory/raw_ptr.h"
#import "base/strings/sys_string_conversions.h"
#import "base/strings/utf_string_conversions.h"
#import "base/test/scoped_feature_list.h"
#import "components/autofill/core/browser/foundations/test_autofill_client.h"
#import "components/autofill/core/common/autofill_test_utils.h"
#import "components/autofill/core/common/form_data.h"
#import "components/autofill/core/common/password_form_fill_data.h"
#import "components/autofill/core/common/unique_ids.h"
#import "components/autofill/ios/browser/autofill_driver_ios_factory.h"
#import "components/autofill/ios/browser/autofill_util.h"
#import "components/autofill/ios/browser/form_suggestion.h"
#import "components/autofill/ios/browser/form_suggestion_provider_query.h"
#import "components/autofill/ios/browser/test_autofill_client_ios.h"
#import "components/autofill/ios/common/javascript_feature_util.h"
#import "components/password_manager/core/browser/features/password_features.h"
#import "components/password_manager/core/browser/mock_password_form_cache.h"
#import "components/password_manager/core/browser/mock_password_manager.h"
#import "components/password_manager/core/browser/password_form.h"
#import "components/password_manager/core/browser/password_ui_utils.h"
#import "components/password_manager/ios/account_select_fill_data.h"
#import "components/password_manager/ios/features.h"
#import "components/password_manager/ios/ios_password_manager_driver_factory.h"
#import "components/password_manager/ios/test_helpers.h"
#import "ios/web/public/test/fakes/fake_navigation_manager.h"
#import "ios/web/public/test/fakes/fake_web_frame.h"
#import "ios/web/public/test/fakes/fake_web_frames_manager.h"
#import "ios/web/public/test/fakes/fake_web_state.h"
#import "ios/web/public/test/web_task_environment.h"
#import "testing/gtest_mac.h"
#import "testing/platform_test.h"
#import "third_party/ocmock/OCMock/OCMock.h"
#import "third_party/ocmock/gtest_support.h"
#import "url/gurl.h"
#import "url/origin.h"
using autofill::FieldRendererId;
using autofill::FormRendererId;
using autofill::PasswordFormFillData;
using autofill::test::MakeFieldRendererId;
using autofill::test::MakeFormRendererId;
using base::SysUTF8ToNSString;
using base::UTF8ToUTF16;
using ::testing::Return;
namespace {
constexpr char kTestUrl[] = "http://foo.com";
constexpr char kFillDataUsername[] = "john.doe@gmail.com";
constexpr char kFillDataPassword[] = "super!secret";
NSString* const kTestFrameID = @"mainframe";
NSString* const kTextFieldType = @"text";
NSString* const kQueryFocusType = @"focus";
NSString* NSFrameId(web::WebFrame* frame) {
return SysUTF8ToNSString(frame->GetFrameId());
}
PasswordFormFillData CreatePasswordFillData(
FormRendererId form_renderer_id,
FieldRendererId username_renderer_id,
FieldRendererId password_renderer_id) {
PasswordFormFillData form_fill_data;
test_helpers::SetPasswordFormFillData(
kTestUrl, "", form_renderer_id.value(), "", username_renderer_id.value(),
kFillDataUsername, "", password_renderer_id.value(), kFillDataPassword,
nullptr, nullptr, &form_fill_data);
return form_fill_data;
}
} // namespace
class PasswordSuggestionHelperTest : public PlatformTest {
protected:
void SetUp() override {
web_state_.SetCurrentURL(GURL(kTestUrl));
auto frames_manager = std::make_unique<web::FakeWebFramesManager>();
frames_manager_ = frames_manager.get();
auto main_frame =
web::FakeWebFrame::Create("mainframe", true, GURL(kTestUrl));
main_frame_ = main_frame.get();
AddWebFrame(std::move(main_frame));
web::ContentWorld content_world =
ContentWorldForAutofillJavascriptFeatures();
web_state_.SetWebFramesManager(content_world, std::move(frames_manager));
autofill_client_ = std::make_unique<autofill::TestAutofillClientIOS>(
&web_state_, /*bridge=*/nil);
IOSPasswordManagerDriverFactory::CreateForWebState(&web_state_, nil,
&password_manager_);
delegate_ = OCMProtocolMock(@protocol(PasswordSuggestionHelperDelegate));
helper_ =
[[PasswordSuggestionHelper alloc] initWithWebState:&web_state_
passwordManager:&password_manager_];
helper_.delegate = delegate_;
ON_CALL(password_manager_, GetPasswordFormCache)
.WillByDefault(Return(&password_form_cache_));
}
void AddWebFrame(std::unique_ptr<web::WebFrame> frame) {
frames_manager_->AddWebFrame(std::move(frame));
}
FormSuggestionProviderQuery* BuildQuery(
autofill::FormRendererId formRendererID,
NSString* fieldIdentifier,
autofill::FieldRendererId fieldRendererID,
NSString* fieldType,
NSString* frameID) {
return [[FormSuggestionProviderQuery alloc] initWithFormName:@"form1"
formRendererID:formRendererID
fieldIdentifier:fieldIdentifier
fieldRendererID:fieldRendererID
fieldType:fieldType
type:kQueryFocusType
typedValue:@""
frameID:frameID
onlyPassword:NO];
}
FormSuggestionProviderQuery* BuildPasswordQuery(
autofill::FormRendererId formRendererID,
autofill::FieldRendererId fieldRendererID,
NSString* frameID) {
return BuildQuery(formRendererID, @"password1", fieldRendererID,
kObfuscatedFieldType, frameID);
}
FormSuggestionProviderQuery* BuildQuery(NSString* fieldIdentifier,
NSString* fieldType,
NSString* frameID) {
return BuildQuery(autofill::test::MakeFormRendererId(), fieldIdentifier,
autofill::test::MakeFieldRendererId(), fieldType,
frameID);
}
web::WebTaskEnvironment task_environment_;
autofill::test::AutofillUnitTestEnvironment autofill_test_environment_;
std::unique_ptr<autofill::TestAutofillClientIOS> autofill_client_;
web::FakeWebState web_state_;
id delegate_;
PasswordSuggestionHelper* helper_;
raw_ptr<web::FakeWebFrame> main_frame_;
raw_ptr<web::FakeWebFramesManager> frames_manager_;
password_manager::MockPasswordManager password_manager_;
password_manager::MockPasswordFormCache password_form_cache_;
base::test::ScopedFeatureList feature_list_;
};
// Tests that the suggestions check query passes when there is fill data for the
// password field in the form that is being checked.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_WithFillDataImmediately_OnPasswordField) {
FormSuggestionProviderQuery* query =
BuildQuery(@"pwd1", kObfuscatedFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = autofill::test::MakeFieldRendererId();
FieldRendererId password1_renderer_id = query.fieldRendererID;
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:main_frame_->GetFrameId()]);
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
__block BOOL retrieved_suggestions = NO;
__block BOOL completion_called = NO;
SuggestionsAvailableCompletion completion = ^(BOOL suggestionsAvailable) {
retrieved_suggestions = suggestionsAvailable;
completion_called = YES;
};
OCMReject([delegate_
suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:main_frame_]);
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion];
ASSERT_EQ(YES, completion_called);
EXPECT_EQ(YES, retrieved_suggestions);
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that the suggestions check query passes when there is fill data for the
// username field in the form that is being checked.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_WithFillDataImmediately_OnUsernameField) {
FormSuggestionProviderQuery* query =
BuildQuery(@"username1", kTextFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = query.fieldRendererID;
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:main_frame_->GetFrameId()]);
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
__block BOOL retrieved_suggestions = NO;
__block BOOL completion_called = NO;
SuggestionsAvailableCompletion completion = ^(BOOL suggestionsAvailable) {
retrieved_suggestions = suggestionsAvailable;
completion_called = YES;
};
OCMReject([delegate_
suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:main_frame_]);
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion];
ASSERT_EQ(YES, completion_called);
EXPECT_EQ(YES, retrieved_suggestions);
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that the suggestions check query fails when there is no fill data for
// the field in the form that is being checked, not even with the triggered
// forms extraction.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_WithoutFillDataOnTriggeredFormsExtraction) {
__block BOOL retrieved_suggestions = NO;
__block BOOL completion_called = NO;
SuggestionsAvailableCompletion completion = ^(BOOL suggestionsAvailable) {
retrieved_suggestions = suggestionsAvailable;
completion_called = YES;
};
FormSuggestionProviderQuery* query =
BuildQuery(@"pwd1", kObfuscatedFieldType, NSFrameId(main_frame_));
OCMExpect([delegate_
suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:main_frame_]);
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion];
EXPECT_OCMOCK_VERIFY(delegate_);
// The completion shouldn't be called yet as there is no fill data for the
// queried form. The helper triggers forms extraction in an attempt to get
// fill data for the form.
ASSERT_EQ(NO, completion_called);
// Give feedback to the helper that no saved credentials could be retrieved,
// with the triggered forms extraction.
[helper_ processWithNoSavedCredentialsWithFrameId:main_frame_->GetFrameId()];
// Now the completion should be called since the triggered forms extraction
// was done.
ASSERT_EQ(YES, completion_called);
EXPECT_EQ(NO, retrieved_suggestions);
}
// Tests that the suggestions check query passes when there is fill data for the
// field in the form that is being checked, after the triggered forms
// extraction.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_WithFillDataOnTriggeredFormsExtraction) {
__block BOOL retrieved_suggestions = NO;
__block BOOL completion_called = NO;
SuggestionsAvailableCompletion completion = ^(BOOL suggestionsAvailable) {
retrieved_suggestions = suggestionsAvailable;
completion_called = YES;
};
FormSuggestionProviderQuery* query =
BuildQuery(@"pwd1", kObfuscatedFieldType, kTestFrameID);
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = autofill::test::MakeFieldRendererId();
FieldRendererId password1_renderer_id = query.fieldRendererID;
OCMExpect([delegate_
suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:main_frame_]);
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion];
// The completion shouldn't be called yet as there is no fill data for the
// queried form. The helper triggers forms extraction in an attempt to get
// fill data for the form.
ASSERT_EQ(NO, completion_called);
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:main_frame_->GetFrameId()]);
// Process fill data for the queried form after the check query call. Will run
// the queued queries.
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
// Now the completion should be called since the triggered forms extraction
// was done.
ASSERT_EQ(YES, completion_called);
EXPECT_EQ(YES, retrieved_suggestions);
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that multiple queued check queries across forms are completed correctly
// with the right result after processing fill data.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_MultipleQueries_AcrossForms) {
OCMExpect([delegate_
suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:main_frame_]);
// First query.
__block BOOL retrieved_suggestions1 = NO;
__block BOOL completion1_called = NO;
SuggestionsAvailableCompletion completion1 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions1 = suggestionsAvailable;
completion1_called = YES;
};
FormSuggestionProviderQuery* query1 =
BuildQuery(@"password1", kObfuscatedFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query1.formRendererID;
FormRendererId form2_renderer_id = autofill::test::MakeFormRendererId();
FieldRendererId username1_renderer_id = query1.fieldRendererID;
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
[helper_ checkIfSuggestionsAvailableForForm:query1
completionHandler:completion1];
// Second query for the same focused field as query 1.
__block BOOL retrieved_suggestions2 = NO;
__block BOOL completion2_called = NO;
SuggestionsAvailableCompletion completion2 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions2 = suggestionsAvailable;
completion2_called = YES;
};
FormSuggestionProviderQuery* query2 = BuildPasswordQuery(
form1_renderer_id, password1_renderer_id, NSFrameId(main_frame_));
[helper_ checkIfSuggestionsAvailableForForm:query2
completionHandler:completion2];
// Third query for a field in a different form.
__block BOOL retrieved_suggestions3 = NO;
__block BOOL completion3_called = NO;
SuggestionsAvailableCompletion completion3 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions3 = suggestionsAvailable;
completion3_called = YES;
};
FormSuggestionProviderQuery* query3 = BuildPasswordQuery(
form2_renderer_id, password1_renderer_id, NSFrameId(main_frame_));
// Queue the third query to check if suggestions are available. At this point
// there are 4 queries in the queue to be executed the next time fill data is
// processed.
[helper_ checkIfSuggestionsAvailableForForm:query3
completionHandler:completion3];
// The completions shouldn't be called yet as there is no fill data for the
// queried forms. The helper triggers a in an attempt to get fill
// data for the form.
ASSERT_EQ(NO, completion1_called);
ASSERT_EQ(NO, completion2_called);
ASSERT_EQ(NO, completion3_called);
// Process fill data for the queried form after the check query call. Will run
// the queued queries.
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:main_frame_->GetFrameId()]);
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
// Now the queued completion blocks should be called since the triggered forms
// extraction was done.
ASSERT_EQ(YES, completion1_called);
ASSERT_EQ(YES, completion2_called);
ASSERT_EQ(YES, completion3_called);
EXPECT_EQ(YES, retrieved_suggestions1);
EXPECT_EQ(YES, retrieved_suggestions2);
// Expect no suggestions for the third query because there was no fill data
// for the queried form2.
EXPECT_EQ(NO, retrieved_suggestions3);
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that multiple queued check queries across frames are completed
// correctly with the right result after processing fill data.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_MultipleQueries_AcrossFrames) {
FormRendererId form1_renderer_id = autofill::test::MakeFormRendererId();
FieldRendererId username1_renderer_id = autofill::test::MakeFieldRendererId();
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
auto frame1 = web::FakeWebFrame::Create("subframe1", false, GURL(kTestUrl));
web::FakeWebFrame* frame1_ptr = frame1.get();
AddWebFrame(std::move(frame1));
auto frame2 = web::FakeWebFrame::Create("subframe2", false, GURL(kTestUrl));
web::FakeWebFrame* frame2_ptr = frame2.get();
AddWebFrame(std::move(frame2));
OCMExpect([delegate_
suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:main_frame_]);
OCMExpect([delegate_ suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:frame1_ptr]);
OCMExpect([delegate_ suggestionHelperShouldTriggerFormExtraction:helper_
inFrame:frame2_ptr]);
// First query for form in main frame.
__block BOOL retrieved_suggestions1 = NO;
__block BOOL completion1_called = NO;
SuggestionsAvailableCompletion completion1 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions1 = suggestionsAvailable;
completion1_called = YES;
};
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form1_renderer_id, password1_renderer_id, NSFrameId(main_frame_));
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion1];
}
// Second query for other form in main frame.
__block BOOL retrieved_suggestions2 = NO;
__block BOOL completion2_called = NO;
SuggestionsAvailableCompletion completion2 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions2 = suggestionsAvailable;
completion2_called = YES;
};
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form1_renderer_id, password1_renderer_id, NSFrameId(main_frame_));
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion2];
}
// Third query for form in subframe.
__block BOOL retrieved_suggestions3 = NO;
__block BOOL completion3_called = NO;
SuggestionsAvailableCompletion completion3 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions3 = suggestionsAvailable;
completion3_called = YES;
};
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form1_renderer_id, password1_renderer_id, NSFrameId(frame1_ptr));
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion3];
}
// Fourth query for form in other subframe.
__block BOOL retrieved_suggestions4 = NO;
__block BOOL completion4_called = NO;
SuggestionsAvailableCompletion completion4 = ^(BOOL suggestionsAvailable) {
retrieved_suggestions4 = suggestionsAvailable;
completion4_called = YES;
};
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form1_renderer_id, password1_renderer_id, NSFrameId(frame2_ptr));
// Queue the third query to check if suggestions are available. At this
// point there are 4 queries in the queue to be executed when processing
// fill data.
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:completion4];
}
// The completions shouldn't be called yet as there is no fill data for the
// queried forms. The helper triggers forms extraction in an attempt to get
// fill data for the form.
ASSERT_EQ(NO, completion1_called);
ASSERT_EQ(NO, completion2_called);
ASSERT_EQ(NO, completion3_called);
ASSERT_EQ(NO, completion4_called);
// Process fill data for the queried form in the main frame.
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:main_frame_->GetFrameId()]);
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Queries for the forms in main frame should be completed after processing
// the fill data for that frame.
ASSERT_EQ(YES, completion1_called);
ASSERT_EQ(YES, completion2_called);
EXPECT_EQ(YES, retrieved_suggestions1);
EXPECT_EQ(YES, retrieved_suggestions2);
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:frame1_ptr->GetFrameId()]);
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:frame1_ptr->GetFrameId()
isMainFrame:frame1_ptr->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Queries for the forms in first subframe should be completed after
// processing the fill data for that frame.
ASSERT_EQ(YES, completion3_called);
EXPECT_EQ(YES, retrieved_suggestions3);
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:{}
forFrameId:frame2_ptr->GetFrameId()]);
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:frame2_ptr->GetFrameId()
isMainFrame:frame2_ptr->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Queries for the forms in second subframe should be completed after
// processing the fill data for that frame.
ASSERT_EQ(YES, completion4_called);
EXPECT_EQ(YES, retrieved_suggestions4);
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that the completed check queries are popped out of the queue. The
// test will crash with a CHECK failure if a query is run more than one time.
TEST_F(PasswordSuggestionHelperTest,
CheckIfSuggestions_CompletedQueriesPoppedOut) {
FormRendererId form_renderer_id = autofill::test::MakeFormRendererId();
FieldRendererId username_renderer_id = autofill::test::MakeFieldRendererId();
FieldRendererId password_renderer_id = autofill::test::MakeFieldRendererId();
auto frame1 = web::FakeWebFrame::Create("subframe1", false, GURL(kTestUrl));
web::FakeWebFrame* frame1_ptr = frame1.get();
AddWebFrame(std::move(frame1));
auto frame2 = web::FakeWebFrame::Create("subframe2", false, GURL(kTestUrl));
web::FakeWebFrame* frame2_ptr = frame2.get();
AddWebFrame(std::move(frame2));
// First query for form in main frame.
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form_renderer_id, password_renderer_id, NSFrameId(main_frame_));
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:^(BOOL suggestionsAvailable){
}];
}
// Second query for form in main frame.
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form_renderer_id, password_renderer_id, NSFrameId(main_frame_));
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:^(BOOL suggestionsAvailable){
}];
}
// Third query for form in first subframe.
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form_renderer_id, password_renderer_id, NSFrameId(frame1_ptr));
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:^(BOOL suggestionsAvailable){
}];
}
// Fourth query for form in second subframe.
{
FormSuggestionProviderQuery* query = BuildPasswordQuery(
form_renderer_id, password_renderer_id, NSFrameId(frame2_ptr));
// Queue the third query to check if suggestions are available. At this
// point there are 4 queries in the queue to be executed the next time fill
// data is processed.
[helper_ checkIfSuggestionsAvailableForForm:query
completionHandler:^(BOOL suggestionsAvailable){
}];
}
// Process fill data for the main frame.
// Process the fill data a first time where all queries for main frame must
// be popped out.
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id, username_renderer_id, password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Process the fill data a second time to verify that all the queries for
// the main frame were popped out of the queue in which case the query
// only-once CHECK won't fail.
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id, username_renderer_id, password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Process fill data for the first subframe.
// Process the fill data a first time where all queries for the first
// subframe must be popped out.
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id, username_renderer_id, password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:frame1_ptr->GetFrameId()
isMainFrame:frame1_ptr->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Process the fill data a second time to verify that all the queries for
// the first subframe were popped out of the queue in which case the query
// only-once CHECK won't fail.
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id, username_renderer_id, password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:frame1_ptr->GetFrameId()
isMainFrame:frame1_ptr->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Process fill data for the second subframe.
// Process the fill data a first time where all queries for the second
// subframe must be popped out.
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id, username_renderer_id, password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:frame2_ptr->GetFrameId()
isMainFrame:frame2_ptr->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Process the fill data a second time to verify that all the queries for
// the second subframe were popped out of the queue in which case the query
// only-once CHECK won't fail.
{
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id, username_renderer_id, password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:frame2_ptr->GetFrameId()
isMainFrame:frame2_ptr->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
}
// Reaching this line means the no CHECK were triggered and that the queued
// queries were correctly popped out.
}
// Tests retrieving suggestions on username field in form when available.
TEST_F(PasswordSuggestionHelperTest, RetrieveSuggestions_OnUsernameField) {
FormSuggestionProviderQuery* query =
BuildQuery(@"username1", kTextFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = query.fieldRendererID;
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:query];
ASSERT_EQ(1ul, [suggestions count]);
FormSuggestion* suggestionToEvaluate = suggestions.firstObject;
EXPECT_NSEQ(SysUTF8ToNSString(kFillDataUsername), suggestionToEvaluate.value);
EXPECT_FALSE(suggestionToEvaluate.metadata.is_single_username_form);
}
// Tests retrieving suggestions on password field in form when available.
TEST_F(PasswordSuggestionHelperTest, RetrieveSuggestions_OnPasswordField) {
FormSuggestionProviderQuery* query =
BuildQuery(@"password1", kObfuscatedFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = autofill::test::MakeFieldRendererId();
FieldRendererId password1_renderer_id = query.fieldRendererID;
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:query];
ASSERT_EQ(1ul, [suggestions count]);
FormSuggestion* suggestionToEvaluate = suggestions.firstObject;
EXPECT_NSEQ(SysUTF8ToNSString(kFillDataUsername), suggestionToEvaluate.value);
EXPECT_FALSE(suggestionToEvaluate.metadata.is_single_username_form);
}
// Tests retrieving suggestions on the password field in form when suggestions
// are available. Tests the case where the type of the field is associated with
// a password and can be determined from the password manager cache.
TEST_F(PasswordSuggestionHelperTest,
RetrieveSuggestions_OnPasswordField_UsingPasswordFormCache) {
FormSuggestionProviderQuery* query =
BuildQuery(@"password1", kObfuscatedFieldType, NSFrameId(main_frame_));
FormRendererId form_renderer_id(query.formRendererID);
FieldRendererId password_renderer_id(query.fieldRendererID);
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form_renderer_id,
/*username_renderer_id=*/autofill::test::MakeFieldRendererId(),
password_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
// Return a password form in the cache that has its password field
// corresponding to the field in the query.
password_manager::PasswordForm password_form;
password_form.password_element_renderer_id = password_renderer_id;
EXPECT_CALL(password_form_cache_,
GetPasswordForm(::testing::_, form_renderer_id))
.WillOnce(Return(&password_form));
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:query];
ASSERT_EQ(1ul, [suggestions count]);
FormSuggestion* suggestionToEvaluate = suggestions.firstObject;
EXPECT_NSEQ(SysUTF8ToNSString(kFillDataUsername), suggestionToEvaluate.value);
EXPECT_FALSE(suggestionToEvaluate.metadata.is_single_username_form);
}
// Tests retrieving suggestions for a single username form on the username
// field.
TEST_F(PasswordSuggestionHelperTest, RetrieveSuggestions_OnSingleUsernameForm) {
FormSuggestionProviderQuery* query =
BuildQuery(@"username1", kTextFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = query.fieldRendererID;
FieldRendererId password1_renderer_id = FieldRendererId();
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:query];
ASSERT_EQ(1ul, [suggestions count]);
FormSuggestion* suggestionToEvaluate = suggestions.firstObject;
EXPECT_NSEQ(SysUTF8ToNSString(kFillDataUsername), suggestionToEvaluate.value);
EXPECT_TRUE(suggestionToEvaluate.metadata.is_single_username_form);
}
// Tests retrieving suggestions for form when there are no suggestions.
TEST_F(PasswordSuggestionHelperTest, RetrieveSuggestions_Empty) {
FormSuggestionProviderQuery* form1_query =
BuildQuery(@"username1", kTextFieldType, NSFrameId(main_frame_));
// Create a 2nd form with the same username field id but a different form id.
FormRendererId form2_renderer_id = autofill::test::MakeFormRendererId();
FieldRendererId username1_renderer_id = form1_query.fieldRendererID;
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
ASSERT_NE(form1_query.formRendererID, form2_renderer_id);
// Process fill data for form2.
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form2_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
// Try to get suggestions for form1 which doesn't have fill data.
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:form1_query];
ASSERT_EQ(0ul, [suggestions count]);
}
// Tests getting password fill data when in stateless mode.
TEST_F(PasswordSuggestionHelperTest, GetPasswordFillData_WhenStateless) {
base::test::ScopedFeatureList scoped_feature_list{
password_manager::features::kIOSStatelessFillDataFlow};
FormSuggestionProviderQuery* query =
BuildQuery(@"username1", kTextFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = query.formRendererID;
FieldRendererId username1_renderer_id = query.fieldRendererID;
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
// Process the form for fill data so there is fill data available for that
// form.
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
// Retrieves password form fill data for the corresponding `frameId`,
// `username`, and contextual information. There is no need to retrieve
// suggestions before calling this method when in stateless mode.
password_manager::FillDataRetrievalResult result =
[helper_ passwordFillDataForUsername:SysUTF8ToNSString(kFillDataUsername)
likelyRealPasswordField:true
formIdentifier:form1_renderer_id
fieldIdentifier:password1_renderer_id
frameId:main_frame_->GetFrameId()];
ASSERT_TRUE(result.has_value());
const password_manager::FillData* fill_data = result.value().get();
ASSERT_TRUE(fill_data);
EXPECT_EQ(GURL(kTestUrl), (*fill_data).origin);
EXPECT_EQ(form1_renderer_id, (*fill_data).form_id);
EXPECT_EQ(username1_renderer_id, (*fill_data).username_element_id);
EXPECT_EQ(UTF8ToUTF16(std::string("john.doe@gmail.com")),
(*fill_data).username_value);
EXPECT_EQ(password1_renderer_id, (*fill_data).password_element_id);
EXPECT_EQ(UTF8ToUTF16(std::string("super!secret")),
(*fill_data).password_value);
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests getting password fill data when in stateless mode and there is no
// FillData yet available for the frame.
TEST_F(PasswordSuggestionHelperTest,
GetPasswordFillData_WhenStateless_NoFillDataForFrame) {
base::test::ScopedFeatureList scoped_feature_list{
password_manager::features::kIOSStatelessFillDataFlow};
// Retrieves password form fill data while the there isn't any fill data yet
// available for the frame.
password_manager::FillDataRetrievalResult result =
[helper_ passwordFillDataForUsername:SysUTF8ToNSString(kFillDataUsername)
likelyRealPasswordField:true
formIdentifier:autofill::test::MakeFormRendererId()
fieldIdentifier:autofill::test::MakeFieldRendererId()
frameId:main_frame_->GetFrameId()];
EXPECT_FALSE(result.has_value());
EXPECT_EQ(password_manager::FillDataRetrievalStatus::kNoFrame,
result.error());
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests getting password fill data when in stateful mode and there is no
// FillData yet available for the frame.
TEST_F(PasswordSuggestionHelperTest,
GetPasswordFillData_WhenStateful_NoFillDataForFrame) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndDisableFeature(
password_manager::features::kIOSStatelessFillDataFlow);
// Retrieves password form fill data while the there isn't any fill data yet
// available for the frame.
password_manager::FillDataRetrievalResult result =
[helper_ passwordFillDataForUsername:SysUTF8ToNSString(kFillDataUsername)
forFrameId:main_frame_->GetFrameId()];
EXPECT_FALSE(result.has_value());
EXPECT_EQ(password_manager::FillDataRetrievalStatus::kNoFrame,
result.error());
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that the helper is correctly reset.
TEST_F(PasswordSuggestionHelperTest, ResetForNewPage) {
FormSuggestionProviderQuery* main_frame_query =
BuildQuery(@"username1", kTextFieldType, NSFrameId(main_frame_));
FormRendererId form1_renderer_id = main_frame_query.formRendererID;
FieldRendererId username1_renderer_id = main_frame_query.fieldRendererID;
FieldRendererId password1_renderer_id = autofill::test::MakeFieldRendererId();
auto frame1 = web::FakeWebFrame::Create("subframe1", false, GURL(kTestUrl));
web::FakeWebFrame* frame1_ptr = frame1.get();
AddWebFrame(std::move(frame1));
// Queue check query for subframe.
__block BOOL completion_called = NO;
SuggestionsAvailableCompletion completion = ^(BOOL suggestionsAvailable) {
completion_called = YES;
};
{
FormSuggestionProviderQuery* iframe_query =
BuildQuery(@"password1", kObfuscatedFieldType, NSFrameId(frame1_ptr));
[helper_ checkIfSuggestionsAvailableForForm:iframe_query
completionHandler:completion];
}
// Process fill data for main frame.
PasswordFormFillData form_fill_data = CreatePasswordFillData(
form1_renderer_id, username1_renderer_id, password1_renderer_id);
[helper_ processWithPasswordFormFillData:form_fill_data
forFrameId:main_frame_->GetFrameId()
isMainFrame:main_frame_->IsMainFrame()
forSecurityOrigin:main_frame_->GetSecurityOrigin()];
{
// Get suggestions and fill data for main frame when there is still fill
// data.
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:main_frame_query];
password_manager::FillDataRetrievalResult fill_data_result = [helper_
passwordFillDataForUsername:SysUTF8ToNSString(kFillDataUsername)
forFrameId:main_frame_->GetFrameId()];
// Check that there are suggestions for the main frame before the reset.
ASSERT_EQ(1ul, [suggestions count]);
ASSERT_TRUE(fill_data_result.has_value());
}
[helper_ resetForNewPage];
{
// Retry to get suggestions for the main frame which had processed fill data
// before the reset.
NSArray<FormSuggestion*>* suggestions =
[helper_ retrieveSuggestionsWithForm:main_frame_query];
// Check that there shouldn't be fill data anymore for the main frame.
EXPECT_EQ(0ul, [suggestions count]);
}
// Process fill data after the reset where the query completion queue should
// be empty.
[helper_ processWithNoSavedCredentialsWithFrameId:frame1_ptr->GetFrameId()];
EXPECT_EQ(NO, completion_called);
EXPECT_OCMOCK_VERIFY(delegate_);
}
|