1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "components/password_manager/ios/shared_password_controller.h"
#import "base/memory/raw_ptr.h"
#import "base/strings/sys_string_conversions.h"
#import "base/test/metrics/histogram_tester.h"
#import "base/test/scoped_feature_list.h"
#import "base/test/task_environment.h"
#import "components/autofill/core/browser/form_structure.h"
#import "components/autofill/core/browser/foundations/autofill_driver_router.h"
#import "components/autofill/core/browser/foundations/test_autofill_client.h"
#import "components/autofill/core/browser/foundations/test_browser_autofill_manager.h"
#import "components/autofill/core/browser/suggestions/suggestion_type.h"
#import "components/autofill/core/browser/test_utils/autofill_test_utils.h"
#import "components/autofill/core/common/autofill_features.h"
#import "components/autofill/core/common/autofill_test_utils.h"
#import "components/autofill/core/common/form_data.h"
#import "components/autofill/core/common/form_data_test_api.h"
#import "components/autofill/core/common/form_field_data.h"
#import "components/autofill/core/common/password_form_generation_data.h"
#import "components/autofill/core/common/password_generation_util.h"
#import "components/autofill/core/common/unique_ids.h"
#import "components/autofill/ios/browser/autofill_driver_ios.h"
#import "components/autofill/ios/browser/autofill_driver_ios_factory.h"
#import "components/autofill/ios/browser/autofill_util.h"
#import "components/autofill/ios/browser/form_suggestion.h"
#import "components/autofill/ios/browser/form_suggestion_provider_query.h"
#import "components/autofill/ios/browser/password_autofill_agent.h"
#import "components/autofill/ios/browser/test_autofill_client_ios.h"
#import "components/autofill/ios/browser/test_autofill_manager_injector.h"
#import "components/autofill/ios/common/field_data_manager_factory_ios.h"
#import "components/autofill/ios/form_util/child_frame_registrar.h"
#import "components/autofill/ios/form_util/form_activity_params.h"
#import "components/password_manager/core/browser/features/password_features.h"
#import "components/password_manager/core/browser/mock_password_form_cache.h"
#import "components/password_manager/core/browser/mock_password_manager.h"
#import "components/password_manager/core/browser/password_generation_frame_helper.h"
#import "components/password_manager/core/browser/password_manager_interface.h"
#import "components/password_manager/core/browser/stub_password_manager_client.h"
#import "components/password_manager/core/browser/stub_password_manager_driver.h"
#import "components/password_manager/core/common/password_manager_features.h"
#import "components/password_manager/ios/constants.h"
#import "components/password_manager/ios/ios_password_manager_driver.h"
#import "components/password_manager/ios/ios_password_manager_driver_factory.h"
#import "components/password_manager/ios/password_controller_driver_helper.h"
#import "components/password_manager/ios/password_form_helper.h"
#import "components/password_manager/ios/password_manager_ios_util.h"
#import "components/password_manager/ios/password_manager_java_script_feature.h"
#import "components/password_manager/ios/password_suggestion_helper.h"
#import "components/password_manager/ios/shared_password_controller+private.h"
#import "components/password_manager/ios/test_helpers.h"
#import "ios/web/public/test/fakes/fake_navigation_context.h"
#import "ios/web/public/test/fakes/fake_web_frame.h"
#import "ios/web/public/test/fakes/fake_web_frames_manager.h"
#import "ios/web/public/test/fakes/fake_web_state.h"
#import "testing/gmock/include/gmock/gmock.h"
#import "testing/gtest/include/gtest/gtest.h"
#import "testing/gtest_mac.h"
#import "testing/platform_test.h"
#import "third_party/ocmock/OCMock/OCMock.h"
#import "third_party/ocmock/gtest_support.h"
#define andCompareStringAtIndex(expected_string, index) \
andDo(^(NSInvocation * invocation) { \
const std::string* param; \
[invocation getArgument:¶m atIndex:index + 2]; \
EXPECT_EQ(*param, expected_string); \
})
namespace password_manager {
namespace {
using autofill::AutofillDriverIOS;
using autofill::AutofillDriverIOSFactory;
using autofill::FormData;
using autofill::LocalFrameToken;
using autofill::PasswordFormFillData;
using autofill::RemoteFrameToken;
using autofill::TestAutofillManagerInjector;
using autofill::TestBrowserAutofillManager;
using autofill::password_generation::PasswordGenerationType;
using autofill::test::CreateTestFormField;
using autofill::test::MakeLocalFrameToken;
using autofill::test::MakeRemoteFrameToken;
using base::SysNSStringToUTF8;
using base::SysUTF16ToNSString;
using password_manager::IsCrossOriginIframe;
using password_manager::PasswordGenerationFrameHelper;
using ::testing::_;
using ::testing::Return;
const std::string kTestURL = "https://www.chromium.org/";
NSString* kTestFrameID = @"dummy-frame-id";
constexpr uint64_t kMaxPasswordLength = 10;
constexpr char16_t kGeneratedPassword[] = u"testpassword";
// Creates renderer FormData tied to a frame that can compose a xframe browser
// form.
FormData CreateFormDataForRenderFrameHost(
web::WebFrame* frame,
const GURL& url,
LocalFrameToken host_frame_token,
std::vector<autofill::FormFieldData> fields) {
FormData form;
form.set_url(url);
form.set_action(form.url());
form.set_host_frame(host_frame_token);
form.set_renderer_id(autofill::test::MakeFormRendererId());
for (autofill::FormFieldData& field : fields) {
field.set_host_frame(form.host_frame());
field.set_host_form_id(form.renderer_id());
}
form.set_fields(std::move(fields));
return form;
}
// Creates a basic signup form with one username field and one password field.
FormData CreateSignupForm() {
FormData form_data = test_helpers::MakeSimpleFormData();
form_data.set_renderer_id(autofill::test::MakeFormRendererId());
for (auto& field_data : test_api(form_data).fields()) {
field_data.set_renderer_id(autofill::test::MakeFieldRendererId());
}
test_api(form_data).fields().back().set_max_length(kMaxPasswordLength);
return form_data;
}
} // namespace
class MockPasswordGenerationFrameHelper : public PasswordGenerationFrameHelper {
public:
MOCK_METHOD(std::u16string,
GeneratePassword,
(const GURL&,
autofill::password_generation::PasswordGenerationType,
autofill::FormSignature,
autofill::FieldSignature,
uint64_t),
(override));
MOCK_METHOD(bool, IsGenerationEnabled, (bool), (const));
explicit MockPasswordGenerationFrameHelper()
: PasswordGenerationFrameHelper(nullptr, nullptr) {}
};
class SharedPasswordControllerTest : public PlatformTest {
public:
SharedPasswordControllerTest() : PlatformTest() {
delegate_ = OCMProtocolMock(@protocol(SharedPasswordControllerDelegate));
password_manager::PasswordManagerClient* client_ptr =
&password_manager_client_;
[[[delegate_ stub] andReturnValue:OCMOCK_VALUE(client_ptr)]
passwordManagerClient];
form_helper_ = OCMStrictClassMock([PasswordFormHelper class]);
suggestion_helper_ = OCMStrictClassMock([PasswordSuggestionHelper class]);
driver_helper_ = OCMStrictClassMock([PasswordControllerDriverHelper class]);
OCMExpect([form_helper_ setDelegate:[OCMArg any]]);
OCMExpect([suggestion_helper_ setDelegate:[OCMArg any]]);
// Some tests observe both frame managers. Making sure that both content
// world have managers set.
web_state_.SetWebFramesManager(
web::ContentWorld::kPageContentWorld,
std::make_unique<web::FakeWebFramesManager>());
web_state_.SetWebFramesManager(
web::ContentWorld::kIsolatedWorld,
std::make_unique<web::FakeWebFramesManager>());
auto web_frames_manager = std::make_unique<web::FakeWebFramesManager>();
web_frames_manager_ = web_frames_manager.get();
web::ContentWorld content_world =
PasswordManagerJavaScriptFeature::GetInstance()
->GetSupportedContentWorld();
web_state_.SetWebFramesManager(content_world,
std::move(web_frames_manager));
autofill_client_ = std::make_unique<autofill::TestAutofillClientIOS>(
&web_state_, /*bridge=*/nil);
// The manager injector must be created before creating the controller to
// make sure it can exchange the manager before the controller starts
// observing it.
autofill_manager_injector_ = std::make_unique<
TestAutofillManagerInjector<TestBrowserAutofillManager>>(&web_state_);
controller_ =
[[SharedPasswordController alloc] initWithWebState:&web_state_
manager:&password_manager_
formHelper:form_helper_
suggestionHelper:suggestion_helper_
driverHelper:driver_helper_];
controller_.delegate = delegate_;
[suggestion_helper_ verify];
[form_helper_ verify];
web_state_.SetCurrentURL(GURL(kTestURL));
}
void SetUp() override {
PlatformTest::SetUp();
PasswordGenerationFrameHelper* password_generation_helper_ptr =
&password_generation_helper_;
OCMStub(
[driver_helper_ PasswordGenerationHelper:static_cast<web::WebFrame*>(
[OCMArg anyPointer])])
.andReturn(password_generation_helper_ptr);
EXPECT_CALL(password_manager_, GetClient)
.WillRepeatedly(Return(&password_manager_client_));
IOSPasswordManagerDriverFactory::CreateForWebState(&web_state_, controller_,
&password_manager_);
// It's not possible to mock the driver, and it has to be non-null, so we
// have the mock DriverHelper return a real driver.
auto dummy_web_frame =
web::FakeWebFrame::CreateMainWebFrame(GURL(kTestURL));
dummy_driver_ = IOSPasswordManagerDriverFactory::GetRetainableDriver(
&web_state_, dummy_web_frame.get());
OCMStub([driver_helper_ PasswordManagerDriver:static_cast<web::WebFrame*>(
[OCMArg anyPointer])])
.andReturn(dummy_driver_.get());
}
protected:
void AddWebFrame(std::unique_ptr<web::WebFrame> frame,
id completion_handler) {
OCMExpect([form_helper_ findPasswordFormsInFrame:frame.get()
completionHandler:completion_handler]);
web_frames_manager_->AddWebFrame(std::move(frame));
}
void AddWebFrame(std::unique_ptr<web::WebFrame> frame) {
AddWebFrame(std::move(frame), [OCMArg any]);
}
base::test::TaskEnvironment task_environment_;
autofill::test::AutofillUnitTestEnvironment autofill_test_environment_;
std::unique_ptr<autofill::TestAutofillClientIOS> autofill_client_;
std::unique_ptr<TestAutofillManagerInjector<TestBrowserAutofillManager>>
autofill_manager_injector_;
web::FakeWebState web_state_;
raw_ptr<web::FakeWebFramesManager> web_frames_manager_;
testing::StrictMock<MockPasswordManager> password_manager_;
testing::StrictMock<MockPasswordGenerationFrameHelper>
password_generation_helper_;
id form_helper_;
id suggestion_helper_;
id driver_helper_;
scoped_refptr<IOSPasswordManagerDriver> dummy_driver_;
password_manager::StubPasswordManagerClient password_manager_client_;
id delegate_;
SharedPasswordController* controller_;
};
TEST_F(SharedPasswordControllerTest,
PasswordManagerIsNotNotifiedAboutHeuristicsPredictions) {
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
EXPECT_CALL(password_manager_, ProcessAutofillPredictions).Times(0);
// Simulate seeing a form.
TestBrowserAutofillManager* manager =
autofill_manager_injector_->GetForFrame(frame);
ASSERT_TRUE(manager);
FormData test_form = autofill::test::CreateTestPersonalInformationFormData();
// `OnFormsSeen` emits a `OnFieldTypesDetermined` event, but with source
// heuristics - this should be ignored by the `SharedPasswordController`.
manager->OnFormsSeen(/*updated_forms=*/{test_form}, /*removed_forms=*/{});
}
// Tests that the password manager of a single main frame is notified about
// server predictions for a form.
TEST_F(SharedPasswordControllerTest,
PasswordManagerIsNotifiedAboutServerPredictions_SingleFrame) {
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
EXPECT_CALL(password_manager_, ProcessAutofillPredictions);
// Simulate seeing a form.
TestBrowserAutofillManager* manager =
autofill_manager_injector_->GetForFrame(frame);
ASSERT_TRUE(manager);
FormData test_form = autofill::test::CreateTestPersonalInformationFormData();
manager->OnFormsSeen(/*updated_forms=*/{test_form}, /*removed_forms=*/{});
// Trigger `OnFieldTypesDetetermined` with source `kAutofillServer` explicitly
// to simulate receiving server predictions.
using Observer = autofill::AutofillManager::Observer;
manager->NotifyObservers(&Observer::OnFieldTypesDetermined,
test_form.global_id(),
Observer::FieldTypeSource::kAutofillServer);
}
// Tests that the password manager of each frame is notified about server
// predictions when a form streches across multiple frames.
TEST_F(SharedPasswordControllerTest,
PasswordManagerIsNotifiedAboutServerPredictions_AcrossFrames) {
base::test::ScopedFeatureList feature_list(
autofill::features::kAutofillAcrossIframesIos);
const LocalFrameToken main_frame_local_frame_token(MakeLocalFrameToken());
const LocalFrameToken child_frame_local_token(MakeLocalFrameToken());
const RemoteFrameToken child_frame_remote_token(MakeRemoteFrameToken());
GURL url(kTestURL);
auto main_frame =
web::FakeWebFrame::Create(main_frame_local_frame_token.ToString(),
/*is_main_frame=*/true, url);
web::WebFrame* main_frame_ptr = main_frame.get();
AddWebFrame(std::move(main_frame));
auto child_frame =
web::FakeWebFrame::Create(child_frame_local_token.ToString(),
/*is_main_frame=*/true, url);
web::WebFrame* child_frame_ptr = child_frame.get();
AddWebFrame(std::move(child_frame));
FormData main_form = CreateFormDataForRenderFrameHost(
main_frame_ptr, url, main_frame_local_frame_token,
{CreateTestFormField("Search", "search", "",
autofill::FormControlType::kInputText)});
{
autofill::FrameTokenWithPredecessor child_token;
child_token.token = child_frame_remote_token;
child_token.predecessor = 64;
main_form.set_child_frames({child_token});
}
FormData child_form = CreateFormDataForRenderFrameHost(
child_frame_ptr, url, child_frame_local_token,
{CreateTestFormField("Username", "username", "",
autofill::FormControlType::kInputText),
CreateTestFormField("Password", "password", "",
autofill::FormControlType::kInputPassword)});
// Simulate seeing a form in the main frame.
{
auto* driver =
AutofillDriverIOS::FromWebStateAndWebFrame(&web_state_, main_frame_ptr);
driver->FormsSeen(/*updated_forms=*/{main_form},
/*removed_forms=*/{});
}
// Simulate seeing a form in the child frame.
{
auto* driver = AutofillDriverIOS::FromWebStateAndWebFrame(&web_state_,
child_frame_ptr);
driver->FormsSeen(/*updated_forms=*/{child_form},
/*removed_forms=*/{});
}
// Complete registration of the child frame so it can be included in the
// browser form.
{
auto* registrar =
autofill::ChildFrameRegistrar::GetOrCreateForWebState(&web_state_);
registrar->RegisterMapping(child_frame_remote_token,
child_frame_local_token);
}
// Verify that the browser form is correctly constructed, composed of the main
// frame form and child frame form, having 3 fields in total.
autofill::FormStructure* browser_form =
autofill_manager_injector_->GetForFrame(main_frame_ptr)
->FindCachedFormById(main_form.global_id());
ASSERT_TRUE(browser_form);
ASSERT_EQ(3u, browser_form->field_count());
// Expect to process predictions for each renderer form that composes the
// browser form. Validate that the arguments are correct.
{
auto* password_driver =
IOSPasswordManagerDriverFactory::FromWebStateAndWebFrame(
&web_state_, main_frame_ptr);
EXPECT_CALL(
password_manager_,
ProcessAutofillPredictions(password_driver,
::testing::Property(&FormData::renderer_id,
main_form.renderer_id()),
::testing::SizeIs(1)));
}
{
auto* password_driver =
IOSPasswordManagerDriverFactory::FromWebStateAndWebFrame(
&web_state_, child_frame_ptr);
EXPECT_CALL(password_manager_,
ProcessAutofillPredictions(
password_driver,
::testing::Property(&FormData::renderer_id,
child_form.renderer_id()),
::testing::SizeIs(2)));
}
// Trigger `OnFieldTypesDetetermined` with source `kAutofillServer` explicitly
// to simulate receiving server predictions.
// using Observer = autofill::AutofillManager::Observer;
TestBrowserAutofillManager* manager =
autofill_manager_injector_->GetForFrame(main_frame_ptr);
using Observer = autofill::AutofillManager::Observer;
manager->NotifyObservers(&Observer::OnFieldTypesDetermined,
main_form.global_id(),
Observer::FieldTypeSource::kAutofillServer);
}
// Tests that the password manager is notified about model predictions for a
// form.
TEST_F(SharedPasswordControllerTest,
PasswordManagerIsNotifiedAboutModelPredictions) {
base::test::ScopedFeatureList features(
password_manager::features::kPasswordFormClientsideClassifier);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
// Simulate seeing a form and expect that PasswordManager gets notified once
// the parsing is complete,
TestBrowserAutofillManager* manager =
autofill_manager_injector_->GetForFrame(frame);
ASSERT_TRUE(manager);
FormData test_form = autofill::test::CreateTestPersonalInformationFormData();
auto* password_driver =
IOSPasswordManagerDriverFactory::FromWebStateAndWebFrame(&web_state_,
frame);
EXPECT_CALL(password_manager_,
ProcessClassificationModelPredictions(
password_driver, test_form,
::testing::SizeIs(test_form.fields().size())));
manager->OnFormsSeen(/*updated_forms=*/{test_form}, /*removed_forms=*/{});
}
// Test that PasswordManager is notified of main frame navigation.
TEST_F(SharedPasswordControllerTest,
PasswordManagerDidNavigationMainFrameOnNavigationFinished) {
web::FakeNavigationContext navigation_context;
navigation_context.SetHasCommitted(true);
navigation_context.SetIsSameDocument(false);
navigation_context.SetIsRendererInitiated(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
AddWebFrame(std::move(web_frame));
EXPECT_CALL(password_manager_, DidNavigateMainFrame(true));
OCMExpect([suggestion_helper_ resetForNewPage]);
web_state_.OnNavigationFinished(&navigation_context);
}
// Tests that forms are found, parsed, and sent to PasswordManager.
TEST_F(SharedPasswordControllerTest, FormsArePropagatedOnHTMLPageLoad) {
web_state_.SetCurrentURL(GURL(kTestURL));
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create("dummy-frame-id",
/*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
id mock_completion_handler = [OCMArg checkWithBlock:^(void (
^completionHandler)(const std::vector<FormData>& forms, uint32_t maxID)) {
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_manager_, OnPasswordFormsParsed);
EXPECT_CALL(password_manager_, OnPasswordFormsRendered);
FormData form_data = test_helpers::MakeSimpleFormData();
completionHandler({form_data}, 1);
return YES;
}];
AddWebFrame(std::move(web_frame), mock_completion_handler);
web_state_.OnPageLoaded(web::PageLoadCompletionStatus::SUCCESS);
[suggestion_helper_ verify];
[form_helper_ verify];
}
// Tests form finding and parsing is not triggered for non HTML pages.
TEST_F(SharedPasswordControllerTest, NoFormsArePropagatedOnNonHTMLPageLoad) {
web_state_.SetCurrentURL(GURL(kTestURL));
web_state_.SetContentIsHTML(false);
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame = web::FakeWebFrame::Create(
web_frame_id, /*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
web_frames_manager_->AddWebFrame(std::move(web_frame));
[[form_helper_ reject] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
OCMExpect([[suggestion_helper_ ignoringNonObjectArgs]
processWithNoSavedCredentialsWithFrameId:""])
.andCompareStringAtIndex(web_frame_id, 0);
EXPECT_CALL(password_manager_, OnPasswordFormsRendered);
web_state_.OnPageLoaded(web::PageLoadCompletionStatus::SUCCESS);
[suggestion_helper_ verify];
[form_helper_ verify];
}
// Tests that suggestions are reported as unavailable for nonpassword forms.
TEST_F(SharedPasswordControllerTest,
CheckNoSuggestionsAreAvailableForNonPasswordForm) {
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:@"text"
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
id mock_completion_handler =
[OCMArg checkWithBlock:^BOOL(void (^completionHandler)(BOOL)) {
// Ensure |suggestion_helper_| reports no suggestions.
completionHandler(NO);
return YES;
}];
[[suggestion_helper_ expect]
checkIfSuggestionsAvailableForForm:form_query
completionHandler:mock_completion_handler];
[[suggestion_helper_ expect] isPasswordFieldOnForm:form_query webFrame:frame];
__block BOOL completion_was_called = NO;
[controller_ checkIfSuggestionsAvailableForForm:form_query
hasUserGesture:NO
webState:&web_state_
completionHandler:^(BOOL suggestionsAvailable) {
EXPECT_FALSE(suggestionsAvailable);
completion_was_called = YES;
}];
EXPECT_TRUE(completion_was_called);
[suggestion_helper_ verify];
}
// Tests that no suggestions are returned if PasswordSuggestionHelper has none.
TEST_F(SharedPasswordControllerTest, ReturnsNoSuggestionsIfNoneAreAvailable) {
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:kObfuscatedFieldType // Ensures this is a password form.
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
OCMExpect([suggestion_helper_ retrieveSuggestionsWithForm:form_query])
.andReturn(@[]);
OCMExpect([[suggestion_helper_ ignoringNonObjectArgs]
isPasswordFieldOnForm:form_query
webFrame:frame]);
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_generation_helper_, IsGenerationEnabled(true))
.WillOnce(Return(true));
__block BOOL completion_was_called = NO;
[controller_
retrieveSuggestionsForForm:form_query
webState:&web_state_
completionHandler:^(NSArray<FormSuggestion*>* suggestions,
id<FormSuggestionProvider> delegate) {
EXPECT_EQ(0UL, suggestions.count);
EXPECT_EQ(delegate, controller_);
completion_was_called = YES;
}];
EXPECT_TRUE(completion_was_called);
}
// Tests that no suggestions are returned if the frame was destroyed.
TEST_F(SharedPasswordControllerTest, ReturnsNoSuggestionsIfFrameDestroyed) {
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:kObfuscatedFieldType // Ensures this is a password form.
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
web::WebFrame* frame = nullptr;
const std::string frame_id = "";
OCMExpect([suggestion_helper_ retrieveSuggestionsWithForm:form_query])
.andReturn(@[]);
OCMExpect([[suggestion_helper_ ignoringNonObjectArgs]
isPasswordFieldOnForm:form_query
webFrame:frame]);
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
__block BOOL completion_was_called = NO;
[controller_
retrieveSuggestionsForForm:form_query
webState:&web_state_
completionHandler:^(NSArray<FormSuggestion*>* suggestions,
id<FormSuggestionProvider> delegate) {
EXPECT_EQ(0UL, suggestions.count);
EXPECT_EQ(delegate, controller_);
completion_was_called = YES;
}];
EXPECT_TRUE(completion_was_called);
}
// Tests that suggestions are returned if PasswordSuggestionHelper has some.
TEST_F(SharedPasswordControllerTest, ReturnsSuggestionsIfAvailable) {
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:kObfuscatedFieldType // Ensures this is a password form.
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
FormSuggestion* suggestion = [FormSuggestion
suggestionWithValue:@"value"
displayDescription:@"display-description"
icon:nil
type:autofill::SuggestionType::kAutocompleteEntry
payload:autofill::Suggestion::Payload()
requiresReauth:NO
acceptanceA11yAnnouncement:nil
metadata:{.is_single_username_form = true}];
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
OCMExpect([suggestion_helper_ retrieveSuggestionsWithForm:form_query])
.andReturn(@[ suggestion ]);
OCMExpect([[suggestion_helper_ ignoringNonObjectArgs]
isPasswordFieldOnForm:form_query
webFrame:frame]);
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_generation_helper_, IsGenerationEnabled(true))
.WillOnce(Return(true));
__block BOOL completion_was_called = NO;
[controller_
retrieveSuggestionsForForm:form_query
webState:&web_state_
completionHandler:^(NSArray<FormSuggestion*>* suggestions,
id<FormSuggestionProvider> delegate) {
EXPECT_EQ(1UL, suggestions.count);
// Verify that the metadata is correctly copied over.
EXPECT_TRUE([suggestions firstObject]
.metadata.is_single_username_form);
EXPECT_EQ(delegate, controller_);
completion_was_called = YES;
}];
EXPECT_TRUE(completion_was_called);
}
// Tests that the "Suggest a password" suggestion is returned if the form is
// eligible for generation.
TEST_F(SharedPasswordControllerTest,
ReturnsGenerateSuggestionIfFormIsEligibleForGeneration) {
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:kObfuscatedFieldType // Ensures this is a password form.
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
OCMExpect([suggestion_helper_ retrieveSuggestionsWithForm:form_query])
.andReturn(@[]);
OCMExpect([[suggestion_helper_ ignoringNonObjectArgs]
isPasswordFieldOnForm:form_query
webFrame:frame]);
autofill::PasswordFormGenerationData form_generation_data = {
form_query.formRendererID, form_query.fieldRendererID,
form_query.fieldRendererID};
[controller_ formEligibleForGenerationFound:form_generation_data];
__block BOOL completion_was_called = NO;
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_generation_helper_, IsGenerationEnabled(true))
.WillOnce(Return(true));
[controller_
retrieveSuggestionsForForm:form_query
webState:&web_state_
completionHandler:^(NSArray<FormSuggestion*>* suggestions,
id<FormSuggestionProvider> delegate) {
ASSERT_EQ(1UL, suggestions.count);
FormSuggestion* suggestion = suggestions.firstObject;
EXPECT_EQ(autofill::SuggestionType::kGeneratePasswordEntry,
suggestion.type);
EXPECT_EQ(delegate, controller_);
completion_was_called = YES;
}];
EXPECT_TRUE(completion_was_called);
}
// Tests that accepting a "Suggest a password" suggestion will give a suggested
// password to the delegate.
TEST_F(SharedPasswordControllerTest, SuggestsGeneratedPassword) {
FormData form_data = CreateSignupForm();
const autofill::FormRendererId form_id = form_data.renderer_id();
autofill::FormFieldData password_field_data = form_data.fields().back();
const autofill::FieldRendererId field_id = password_field_data.renderer_id();
// Register the form as eligible for password generation while specifying that
// the form has no confirmation password field. This is to allow generating a
// password on that form.
autofill::PasswordFormGenerationData form_generation_data = {
form_id, field_id,
/*confirmation_field=*/autofill::FieldRendererId(0)};
[controller_ formEligibleForGenerationFound:form_generation_data];
// Set up the frame that hosts the new password form.
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
OCMExpect([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:SysUTF16ToNSString(kGeneratedPassword)
proactive:NO
frame:frame->AsWeakPtr()
decisionHandler:[OCMArg isNotNil]]);
EXPECT_CALL(password_manager_, SetGenerationElementAndTypeForForm);
// Emulate completing the extraction.
id extract_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL, FormData)) {
completion_handler(/*found=*/YES, form_data);
return YES;
}];
OCMExpect([form_helper_
extractPasswordFormData:form_id
inFrame:frame
completionHandler:extract_completion_handler_arg]);
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
// Mock generating a valid password and verify that GeneratePassword() is
// correctly called.
autofill::FormSignature form_signature =
autofill::CalculateFormSignature(form_data);
autofill::FieldSignature field_signature =
autofill::CalculateFieldSignatureForField(password_field_data);
EXPECT_CALL(
password_generation_helper_,
GeneratePassword(web_state_.GetLastCommittedURL(),
PasswordGenerationType::kAutomatic, form_signature,
field_signature, kMaxPasswordLength))
.WillOnce(::testing::Return(kGeneratedPassword));
// Select suggestion to start the password generation flow which will stop at
// showing the generated pasword.
FormSuggestion* suggestion = [FormSuggestion
suggestionWithValue:@"test-value"
displayDescription:@"test-description"
icon:nil
type:autofill::SuggestionType::kGeneratePasswordEntry
payload:autofill::Suggestion::Payload()
requiresReauth:NO];
[controller_ didSelectSuggestion:suggestion
atIndex:0
form:@"test-form-name"
formRendererID:form_id
fieldIdentifier:@"test-field-id"
fieldRendererID:field_id
frameID:kTestFrameID
completionHandler:nil];
EXPECT_OCMOCK_VERIFY(delegate_);
}
// Tests that generated passwords are presaved.
TEST_F(SharedPasswordControllerTest, PresavesGeneratedPassword) {
base::HistogramTester histogram_tester;
FormData form_data = CreateSignupForm();
autofill::FormRendererId form_id = form_data.renderer_id();
autofill::FieldRendererId password_field_id =
form_data.fields()[1].renderer_id();
// Register the form as eligible for password generation while specifying that
// the form has no confirmation password field. This is to allow generating a
// password on that form.
autofill::PasswordFormGenerationData form_generation_data = {
form_id, password_field_id, password_field_id};
[controller_ formEligibleForGenerationFound:form_generation_data];
web_state_.SetCurrentURL(GURL(kTestURL));
web_state_.SetContentIsHTML(true);
// Set up the frame that hosts the new password form.
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
// Show and accept password in the same loop.
id decision_handler_arg =
[OCMArg checkWithBlock:^(void (^decision_handler)(BOOL)) {
decision_handler(/*accept=*/YES);
return YES;
}];
OCMExpect([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:[OCMArg isNotNil]
proactive:NO
frame:frame->AsWeakPtr()
decisionHandler:decision_handler_arg]);
// Emulating completing filling of the generated password in the renderer.
id fill_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL)) {
completion_handler(/*success=*/YES);
return YES;
}];
OCMExpect([form_helper_
fillPasswordForm:form_id
inFrame:frame
newPasswordIdentifier:password_field_id
confirmPasswordIdentifier:password_field_id
generatedPassword:SysUTF16ToNSString(kGeneratedPassword)
completionHandler:fill_completion_handler_arg]);
// Complete form extraction before generating the password.
id extract_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL, FormData)) {
completion_handler(/*found=*/YES, form_data);
return YES;
}];
OCMExpect([form_helper_
extractPasswordFormData:form_id
inFrame:frame
completionHandler:extract_completion_handler_arg]);
OCMStub([driver_helper_ PasswordManagerDriver:frame]);
// Mock generating a valid password.
EXPECT_CALL(password_generation_helper_, GeneratePassword)
.WillOnce(::testing::Return(kGeneratedPassword));
EXPECT_CALL(password_manager_, OnPresaveGeneratedPassword);
// Start the password generation flow by selecting the corresponding
// suggestion which will end up presaving the generated password.
EXPECT_CALL(password_manager_, SetGenerationElementAndTypeForForm);
FormSuggestion* suggestion = [FormSuggestion
suggestionWithValue:@"test-value"
displayDescription:@"test-description"
icon:nil
type:autofill::SuggestionType::kGeneratePasswordEntry
payload:autofill::Suggestion::Payload()
requiresReauth:NO];
[controller_ didSelectSuggestion:suggestion
atIndex:0
form:@"test-form-name"
formRendererID:form_id
fieldIdentifier:@"test-field-id"
fieldRendererID:password_field_id
frameID:kTestFrameID
completionHandler:nil];
EXPECT_OCMOCK_VERIFY(delegate_);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.Event",
autofill::password_generation::PASSWORD_ACCEPTED, 1);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.AcceptedGeneratedPasswordSource",
AcceptedGeneratedPasswordSourceType::kSuggestion, 1);
// Verify that the non-empty generated password occurence is recorded.
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.GeneratedPasswordIsEmpty.BeforeParsing", 0, 1);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.AcceptedGeneratedPasswordIsEmpty", 0, 1);
// No metric for the bottom sheet should be recorded since an another
// entrypoint was used.
histogram_tester.ExpectTotalCount(
"PasswordManager.TouchToFill.PasswordGeneration.UserChoice", 0);
}
// Tests that generated passwords that are empty aren't presaved.
TEST_F(SharedPasswordControllerTest, PresavesGeneratedPassword_Empty) {
base::HistogramTester histogram_tester;
FormData form_data = CreateSignupForm();
const autofill::FormRendererId form_id = form_data.renderer_id();
const autofill::FieldRendererId password_field_id =
form_data.fields()[1].renderer_id();
// Register the form as eligible for password generation to allow password
// generation on that form.
autofill::PasswordFormGenerationData form_generation_data = {
form_id, password_field_id, password_field_id};
[controller_ formEligibleForGenerationFound:form_generation_data];
web_state_.SetCurrentURL(GURL(kTestURL));
web_state_.SetContentIsHTML(true);
// Set up the frame that hosts the sign up form.
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
// Show and accept password in the same loop.
id decision_handler_arg =
[OCMArg checkWithBlock:^(void (^decision_handler)(BOOL)) {
decision_handler(/*accept=*/YES);
return YES;
}];
OCMExpect([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:[OCMArg isNotNil]
proactive:NO
frame:frame->AsWeakPtr()
decisionHandler:decision_handler_arg]);
// Emulate completing the extraction before generating the password.
id extract_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL, FormData)) {
completion_handler(/*found=*/YES, form_data);
return YES;
}];
[[form_helper_ expect]
extractPasswordFormData:form_id
inFrame:frame
completionHandler:extract_completion_handler_arg];
OCMStub([driver_helper_ PasswordManagerDriver:frame]);
// Emulate generating an empty password.
EXPECT_CALL(password_generation_helper_, GeneratePassword)
.WillOnce(::testing::Return(u""));
// Verify that presaving is never done because the generated password is empty
// hence invalid for presaving. The
EXPECT_CALL(password_manager_, OnPresaveGeneratedPassword).Times(0);
EXPECT_CALL(password_manager_, OnPasswordNoLongerGenerated);
// Start the password generation flow by selecting the corresponding
// suggestion which will be interrupted at the presaving stage because the
// generated password is invalid.
EXPECT_CALL(password_manager_, SetGenerationElementAndTypeForForm);
FormSuggestion* suggestion = [FormSuggestion
suggestionWithValue:@"test-value"
displayDescription:@"test-description"
icon:nil
type:autofill::SuggestionType::kGeneratePasswordEntry
payload:autofill::Suggestion::Payload()
requiresReauth:NO];
[controller_ didSelectSuggestion:suggestion
atIndex:0
form:@"test-form-name"
formRendererID:form_id
fieldIdentifier:@"test-field-id"
fieldRendererID:password_field_id
frameID:kTestFrameID
completionHandler:nil];
EXPECT_OCMOCK_VERIFY(delegate_);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.Event",
autofill::password_generation::PASSWORD_ACCEPTED, 1);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.AcceptedGeneratedPasswordSource",
AcceptedGeneratedPasswordSourceType::kSuggestion, 1);
// Verify that the empty generated password occurence is recorded at each
// stage of the flow.
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.GeneratedPasswordIsEmpty.BeforeParsing", 1, 1);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.AcceptedGeneratedPasswordIsEmpty", 1, 1);
// No metric for the bottom sheet should be recorded since an another
// entrypoint was used.
histogram_tester.ExpectTotalCount(
"PasswordManager.TouchToFill.PasswordGeneration.UserChoice", 0);
}
// Tests that triggering password generation on the last focused field triggers
// the generation flow.
TEST_F(SharedPasswordControllerTest, TriggerPasswordGeneration) {
base::HistogramTester histogram_tester;
autofill::FormActivityParams params;
params.form_renderer_id = autofill::FormRendererId(0);
params.field_type = "password";
params.field_renderer_id = autofill::FieldRendererId(1);
params.type = "focus";
params.input_missing = false;
auto web_frame = web::FakeWebFrame::Create("frame-id", /*is_main_frame=*/true,
GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
[controller_ webState:&web_state_
didRegisterFormActivity:params
inFrame:frame];
OCMExpect([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:[OCMArg isNotNil]
proactive:NO
frame:frame->AsWeakPtr()
decisionHandler:[OCMArg any]]);
EXPECT_CALL(password_manager_, SetGenerationElementAndTypeForForm);
FormData form_data = test_helpers::MakeSimpleFormData();
id extract_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL, FormData)) {
completion_handler(/*found=*/YES, form_data);
return YES;
}];
OCMExpect([form_helper_
extractPasswordFormData:params.form_renderer_id
inFrame:frame
completionHandler:extract_completion_handler_arg]);
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_generation_helper_, GeneratePassword)
.WillOnce(Return(u"testpass"));
[controller_ triggerPasswordGeneration];
EXPECT_OCMOCK_VERIFY(delegate_);
// Verify that the metrics that verify the emptyness of the generated password
// are recorded.
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.GeneratedPasswordIsEmpty.BeforeParsing", 0, 1);
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.Event",
autofill::password_generation::PASSWORD_GENERATION_CONTEXT_MENU_PRESSED,
1);
}
// Tests that triggering password generation proactively (aka the proactive
// password generation bottom sheet).
TEST_F(SharedPasswordControllerTest, TriggerPasswordGeneration_Proactively) {
base::HistogramTester histogram_tester;
FormData form_data = CreateSignupForm();
const autofill::FormRendererId form_id = form_data.renderer_id();
const autofill::FieldRendererId password_field_id =
form_data.fields()[1].renderer_id();
// Register the form as eligible for password generation to allow password
// generation on that form.
autofill::PasswordFormGenerationData form_generation_data = {
form_id, password_field_id, password_field_id};
[controller_ formEligibleForGenerationFound:form_generation_data];
// Set up the frame that hosts the sign up form.
auto web_frame = web::FakeWebFrame::Create("frame-id", /*is_main_frame=*/true,
GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
// Verify that the potential password is shown as the proactive variant.
OCMExpect([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:[OCMArg isNotNil]
proactive:YES
frame:frame->AsWeakPtr()
decisionHandler:[OCMArg any]]);
EXPECT_CALL(password_manager_, SetGenerationElementAndTypeForForm);
// Emulate completing form extraction before generating the password.
id extract_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL, FormData)) {
completion_handler(/*found=*/YES, form_data);
return YES;
}];
OCMExpect([form_helper_
extractPasswordFormData:form_id
inFrame:frame
completionHandler:extract_completion_handler_arg]);
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
// Emulate generating a non-empty password.
EXPECT_CALL(password_generation_helper_, GeneratePassword)
.WillOnce(Return(u"testpass"));
// Trigger password generation proactively to start the password generation
// flow which will stop at the stage where it is shown to the user through the
// bottom sheet.
[controller_ triggerPasswordGenerationForFormId:form_id
fieldIdentifier:password_field_id
inFrame:frame
proactive:YES];
EXPECT_OCMOCK_VERIFY(delegate_);
// Verify that the metrics that verify the emptyness of the generated password
// are recorded.
histogram_tester.ExpectUniqueSample(
"PasswordGeneration.iOS.GeneratedPasswordIsEmpty.BeforeParsing", 0, 1);
// Verify that the proactive trigger isn't wrongly recorded as the manual
// fallback trigger.
histogram_tester.ExpectBucketCount(
"PasswordGeneration.Event",
autofill::password_generation::PASSWORD_GENERATION_CONTEXT_MENU_PRESSED,
0);
}
// Tests that triggering password generation on the last focused field does not
// trigger the generation flow if the last reported form activity did not
// provide valid form and field identifiers.
TEST_F(SharedPasswordControllerTest, LastFocusedFieldData) {
autofill::FormActivityParams params;
params.form_renderer_id = autofill::FormRendererId(0);
params.field_type = "password";
params.field_renderer_id = autofill::FieldRendererId(1);
params.type = "focus";
params.input_missing = true;
auto web_frame = web::FakeWebFrame::Create("frame-id", /*is_main_frame=*/true,
GURL(kTestURL));
[controller_ webState:&web_state_
didRegisterFormActivity:params
inFrame:web_frame.get()];
OCMReject([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:[OCMArg isNotNil]
proactive:NO
frame:web_frame->AsWeakPtr()
decisionHandler:[OCMArg any]]);
[controller_ triggerPasswordGeneration];
[delegate_ verify];
}
// Tests that detecting element additions (form_changed events) is not
// interpreted as form submissions.
TEST_F(SharedPasswordControllerTest,
DoesntInterpretElementAdditionsAsFormSubmission) {
id mock_completion_handler = [OCMArg checkWithBlock:^(void (
^completionHandler)(const std::vector<FormData>& forms, uint32_t maxID)) {
EXPECT_CALL(password_manager_, OnPasswordFormsParsed);
// OnPasswordFormsRendered is responsible for detecting submissions.
// Making sure it's not called after element additions.
EXPECT_CALL(password_manager_, OnPasswordFormsRendered).Times(0);
FormData form_data = test_helpers::MakeSimpleFormData();
completionHandler({form_data}, 1);
return YES;
}];
auto web_frame = web::FakeWebFrame::Create("frame-id", /*is_main_frame=*/true,
GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
AddWebFrame(std::move(web_frame));
OCMExpect([form_helper_ findPasswordFormsInFrame:frame
completionHandler:mock_completion_handler]);
autofill::FormActivityParams params;
params.type = "form_changed";
[controller_ webState:&web_state_
didRegisterFormActivity:params
inFrame:frame];
[suggestion_helper_ verify];
[form_helper_ verify];
}
class SharedPasswordControllerTestWithRealSuggestionHelper
: public PlatformTest {
public:
SharedPasswordControllerTestWithRealSuggestionHelper() : PlatformTest() {
delegate_ = OCMProtocolMock(@protocol(SharedPasswordControllerDelegate));
password_manager::PasswordManagerClient* client_ptr =
&password_manager_client_;
[[[delegate_ stub] andReturnValue:OCMOCK_VALUE(client_ptr)]
passwordManagerClient];
suggestion_helper_ =
[[PasswordSuggestionHelper alloc] initWithWebState:&web_state_
passwordManager:&password_manager_];
form_helper_ = OCMStrictClassMock([PasswordFormHelper class]);
OCMExpect([form_helper_ setDelegate:[OCMArg any]]);
auto web_frames_manager = std::make_unique<web::FakeWebFramesManager>();
web_frames_manager_ = web_frames_manager.get();
web::ContentWorld content_world =
PasswordManagerJavaScriptFeature::GetInstance()
->GetSupportedContentWorld();
web_state_.SetWebFramesManager(content_world,
std::move(web_frames_manager));
PasswordControllerDriverHelper* driver_helper =
[[PasswordControllerDriverHelper alloc] initWithWebState:&web_state_];
controller_ =
[[SharedPasswordController alloc] initWithWebState:&web_state_
manager:&password_manager_
formHelper:form_helper_
suggestionHelper:suggestion_helper_
driverHelper:driver_helper];
[form_helper_ verify];
controller_.delegate = delegate_;
autofill_client_ = std::make_unique<autofill::TestAutofillClientIOS>(
&web_state_, /*bridge=*/nil);
web_state_.SetCurrentURL(GURL(kTestURL));
EXPECT_CALL(password_manager_, GetPasswordFormCache)
.WillRepeatedly(Return(&password_form_cache_));
}
void SetUp() override {
PlatformTest::SetUp();
EXPECT_CALL(password_manager_, GetClient)
.WillRepeatedly(Return(&password_manager_client_));
}
void AddWebFrame(std::unique_ptr<web::WebFrame> frame) {
web_frames_manager_->AddWebFrame(std::move(frame));
}
protected:
base::test::TaskEnvironment task_environment_;
std::unique_ptr<autofill::TestAutofillClientIOS> autofill_client_;
web::FakeWebState web_state_;
raw_ptr<web::FakeWebFramesManager> web_frames_manager_;
testing::StrictMock<MockPasswordManager> password_manager_;
PasswordSuggestionHelper* suggestion_helper_;
id form_helper_;
id delegate_;
password_manager::StubPasswordManagerClient password_manager_client_;
SharedPasswordController* controller_;
password_manager::MockPasswordFormCache password_form_cache_;
base::test::ScopedFeatureList feature_list_;
};
// Tests the completion handler for suggestions availability is not called
// until password manager replies with suggestions.
TEST_F(SharedPasswordControllerTestWithRealSuggestionHelper,
WaitForPasswordmanagerResponseToShowSuggestions) {
// Simulate that the form is parsed and sent to PasswordManager.
FormData form = test_helpers::MakeSimpleFormData();
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
AddWebFrame(std::move(web_frame));
EXPECT_CALL(password_manager_, OnPasswordFormsParsed);
EXPECT_CALL(password_manager_, OnPasswordFormsRendered);
[controller_ didFinishPasswordFormExtraction:{form}
triggeredByFormChange:false
inFrame:frame];
// Simulate user focusing the field in a form before the password store
// response is received.
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:SysUTF16ToNSString(form.name())
formRendererID:form.renderer_id()
fieldIdentifier:SysUTF16ToNSString(form.fields()[0].name())
fieldRendererID:form.fields()[0].renderer_id()
fieldType:@"text"
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
__block BOOL completion_was_called = NO;
[controller_ checkIfSuggestionsAvailableForForm:form_query
hasUserGesture:NO
webState:&web_state_
completionHandler:^(BOOL suggestionsAvailable) {
completion_was_called = YES;
}];
// Check that completion handler wasn't called.
EXPECT_FALSE(completion_was_called);
// Receive suggestions from PasswordManager.
PasswordFormFillData form_fill_data;
test_helpers::SetPasswordFormFillData(
form.url().spec(), "", form.renderer_id().value(), "",
form.fields()[0].renderer_id().value(), "john.doe@gmail.com", "",
form.fields()[1].renderer_id().value(), "super!secret", nullptr, nullptr,
&form_fill_data);
[controller_ processPasswordFormFillData:form_fill_data
forFrameId:web_frame_id
isMainFrame:frame->IsMainFrame()
forSecurityOrigin:frame->GetSecurityOrigin()];
// Check that completion handler was called.
EXPECT_TRUE(completion_was_called);
}
// Tests the completion handler for suggestions availability is not called
// until password manager replies with suggestions.
TEST_F(SharedPasswordControllerTestWithRealSuggestionHelper,
WaitForPasswordManagerResponseToShowSuggestionsTwoFields) {
// Simulate that the form is parsed and sent to PasswordManager.
FormData form = test_helpers::MakeSimpleFormData();
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
AddWebFrame(std::move(web_frame));
EXPECT_CALL(password_manager_, OnPasswordFormsParsed);
EXPECT_CALL(password_manager_, OnPasswordFormsRendered);
[controller_ didFinishPasswordFormExtraction:{form}
triggeredByFormChange:false
inFrame:frame];
// Simulate user focusing the field in a form before the password store
// response is received.
FormSuggestionProviderQuery* form_query1 =
[[FormSuggestionProviderQuery alloc]
initWithFormName:SysUTF16ToNSString(form.name())
formRendererID:form.renderer_id()
fieldIdentifier:SysUTF16ToNSString(form.fields()[0].name())
fieldRendererID:form.fields()[0].renderer_id()
fieldType:@"text"
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
__block BOOL completion_was_called1 = NO;
[controller_ checkIfSuggestionsAvailableForForm:form_query1
hasUserGesture:NO
webState:&web_state_
completionHandler:^(BOOL suggestionsAvailable) {
completion_was_called1 = YES;
}];
// Check that completion handler wasn't called.
EXPECT_FALSE(completion_was_called1);
// Simulate user focusing another field in a form before the password store
// response is received.
FormSuggestionProviderQuery* form_query2 =
[[FormSuggestionProviderQuery alloc]
initWithFormName:SysUTF16ToNSString(form.name())
formRendererID:form.renderer_id()
fieldIdentifier:SysUTF16ToNSString(form.fields()[1].name())
fieldRendererID:form.fields()[1].renderer_id()
fieldType:kObfuscatedFieldType
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
__block BOOL completion_was_called2 = NO;
[controller_ checkIfSuggestionsAvailableForForm:form_query2
hasUserGesture:NO
webState:&web_state_
completionHandler:^(BOOL suggestionsAvailable) {
completion_was_called2 = YES;
}];
// Check that completion handler wasn't called yet, not until processing fill
// data.
EXPECT_FALSE(completion_was_called1);
EXPECT_FALSE(completion_was_called2);
// Receive suggestions from PasswordManager.
PasswordFormFillData form_fill_data;
test_helpers::SetPasswordFormFillData(
form.url().spec(), "", form.renderer_id().value(), "",
form.fields()[0].renderer_id().value(), "john.doe@gmail.com", "",
form.fields()[1].renderer_id().value(), "super!secret", nullptr, nullptr,
&form_fill_data);
[controller_ processPasswordFormFillData:form_fill_data
forFrameId:web_frame_id
isMainFrame:frame->IsMainFrame()
forSecurityOrigin:frame->GetSecurityOrigin()];
// Check that completion handlers were called.
EXPECT_TRUE(completion_was_called1);
EXPECT_TRUE(completion_was_called2);
}
// Test that the password suggestions for cross-origin iframes have the origin
// as their description.
TEST_F(SharedPasswordControllerTestWithRealSuggestionHelper,
CrossOriginIframeSugesstionHasOriginAsDescription) {
// Simulate that the form is parsed and sent to PasswordManager.
FormData form = test_helpers::MakeSimpleFormData();
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
PasswordFormFillData form_fill_data;
test_helpers::SetPasswordFormFillData(
kTestURL, "", form.renderer_id().value(), "",
form.fields()[0].renderer_id().value(), "john.doe@gmail.com", "",
form.fields()[1].renderer_id().value(), "super!secret", nullptr, nullptr,
&form_fill_data);
[controller_ processPasswordFormFillData:form_fill_data
forFrameId:web_frame_id
isMainFrame:frame->IsMainFrame()
forSecurityOrigin:frame->GetSecurityOrigin()];
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:kObfuscatedFieldType
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
[controller_
retrieveSuggestionsForForm:form_query
webState:&web_state_
completionHandler:^(NSArray<FormSuggestion*>* suggestions,
id<FormSuggestionProvider> delegate) {
// Assert that kTestURL contains [suggestions[0]
// displayDescription].
ASSERT_NE(kTestURL.find(SysNSStringToUTF8(
[suggestions[0] displayDescription])),
std::string::npos);
}];
}
// Tests that attachListenersForBottomSheet, from the
// PasswordSuggestionHelperDelegate protocol, is properly used by the
// PasswordSuggestionHelper object.
TEST_F(SharedPasswordControllerTestWithRealSuggestionHelper,
AttachListenersForBottomSheet) {
// Simulate that the form is parsed and sent to PasswordManager.
FormData form = test_helpers::MakeSimpleFormData();
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame = web::FakeWebFrame::Create(
web_frame_id, /*is_main_frame=*/true, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
AddWebFrame(std::move(web_frame));
EXPECT_CALL(password_manager_, OnPasswordFormsParsed);
EXPECT_CALL(password_manager_, OnPasswordFormsRendered);
[controller_ didFinishPasswordFormExtraction:{form}
triggeredByFormChange:false
inFrame:frame];
// Receive suggestions from PasswordManager.
PasswordFormFillData form_fill_data;
test_helpers::SetPasswordFormFillData(
form.url().spec(), "", form.renderer_id().value(), "",
form.fields()[0].renderer_id().value(), "john.doe@gmail.com", "",
form.fields()[1].renderer_id().value(), "super!secret", nullptr, nullptr,
&form_fill_data);
std::vector<autofill::FieldRendererId> rendererIds;
OCMExpect([[delegate_ ignoringNonObjectArgs]
attachListenersForBottomSheet:rendererIds
forFrameId:""])
.andCompareStringAtIndex(web_frame_id, 1);
[controller_ processPasswordFormFillData:form_fill_data
forFrameId:web_frame_id
isMainFrame:frame->IsMainFrame()
forSecurityOrigin:frame->GetSecurityOrigin()];
[delegate_ verify];
}
// Tests frameDidBecomeAvailable supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
FrameDidBecomeAvailableCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
[[form_helper_ expect] findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]];
web_frames_manager_->AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
[form_helper_ verify];
}
// Tests frameWillBecomeUnavailable supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
FrameWillBecomeUnavailableCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
// OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_manager_, OnIframeDetach).Times(1);
web_frames_manager_->RemoveWebFrame(frame->GetFrameId());
}
// Tests checkIfSuggestionsAvailableForForm supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
CheckIfSuggestionsAvailableForFormCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:@"text"
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
id mock_completion_handler =
[OCMArg checkWithBlock:^BOOL(void (^completionHandler)(BOOL)) {
completionHandler(YES);
return YES;
}];
[[suggestion_helper_ expect]
checkIfSuggestionsAvailableForForm:form_query
completionHandler:mock_completion_handler];
[[suggestion_helper_ expect] isPasswordFieldOnForm:form_query webFrame:frame];
[controller_ checkIfSuggestionsAvailableForForm:form_query
hasUserGesture:NO
webState:&web_state_
completionHandler:^(BOOL suggestionsAvailable) {
EXPECT_TRUE(suggestionsAvailable);
}];
}
// Tests retrieveSuggestionsForForm supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
RetrieveSuggestionsForFormCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
const std::string web_frame_id = SysNSStringToUTF8(kTestFrameID);
auto web_frame =
web::FakeWebFrame::Create(web_frame_id,
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
FormSuggestionProviderQuery* form_query = [[FormSuggestionProviderQuery alloc]
initWithFormName:@"form"
formRendererID:autofill::FormRendererId(0)
fieldIdentifier:@"field"
fieldRendererID:autofill::FieldRendererId(1)
fieldType:@"text"
type:@"focus"
typedValue:@""
frameID:kTestFrameID
onlyPassword:NO];
OCMExpect([suggestion_helper_ retrieveSuggestionsWithForm:form_query])
.andReturn(@[]);
OCMExpect([[suggestion_helper_ ignoringNonObjectArgs]
isPasswordFieldOnForm:form_query
webFrame:frame]);
EXPECT_CALL(password_generation_helper_, IsGenerationEnabled(true))
.WillOnce(Return(false));
[controller_
retrieveSuggestionsForForm:form_query
webState:&web_state_
completionHandler:^(NSArray<FormSuggestion*>* suggestions,
id<FormSuggestionProvider> delegate){
}];
[suggestion_helper_ verify];
}
// Tests formHelper didSubmitForm supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
FormHelperDidSubmitFormForFormCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_manager_, OnSubframeFormSubmission).Times(1);
FormData form_data;
[controller_ formHelper:form_helper_ didSubmitForm:form_data inFrame:frame];
}
// Tests didRegisterFormActivity supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
DidRegisterFormActivityForFormCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
OCMExpect([form_helper_ findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]]);
web_frames_manager_->AddWebFrame(std::move(web_frame));
autofill::FormActivityParams params;
params.type = "form_changed";
OCMExpect([form_helper_ findPasswordFormsInFrame:frame
completionHandler:[OCMArg any]]);
[controller_ webState:&web_state_
didRegisterFormActivity:params
inFrame:frame];
[form_helper_ verify];
}
// Tests didRegisterFormRemoval supports cross-origin iframes.
TEST_F(SharedPasswordControllerTest,
DidRegisterFormRemovalForFormCrossOriginIframe) {
web_state_.SetCurrentURL(GURL());
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/false, GURL(kTestURL));
web::WebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
ASSERT_TRUE(IsCrossOriginIframe(&web_state_, frame->IsMainFrame(),
frame->GetSecurityOrigin()));
OCMExpect([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_manager_, OnPasswordFormsRemoved).Times(1);
autofill::FormRemovalParams params;
params.removed_forms = {autofill::FormRendererId()};
[controller_ webState:&web_state_
didRegisterFormRemoval:params
inFrame:frame];
}
// Tests that password generation is terminated correctly when the
// user declines the dialog.
TEST_F(SharedPasswordControllerTest, DeclinePasswordGenerationDialog) {
base::HistogramTester histogram_tester;
autofill::FormRendererId form_id(0);
autofill::FieldRendererId field_id(1);
autofill::PasswordFormGenerationData form_generation_data = {
form_id, field_id, field_id};
[controller_ formEligibleForGenerationFound:form_generation_data];
web_state_.SetCurrentURL(GURL(kTestURL));
web_state_.SetContentIsHTML(true);
auto web_frame =
web::FakeWebFrame::Create(SysNSStringToUTF8(kTestFrameID),
/*is_main_frame=*/true, GURL(kTestURL));
web::FakeWebFrame* frame = web_frame.get();
AddWebFrame(std::move(web_frame));
// Create a password generation suggestion.
FormSuggestion* suggestion = [FormSuggestion
suggestionWithValue:@"test-value"
displayDescription:@"test-description"
icon:nil
type:autofill::SuggestionType::kGeneratePasswordEntry
payload:autofill::Suggestion::Payload()
requiresReauth:NO];
// Triggering password generation will trigger a new form extraction.
// Simulate it completes successfully.
FormData form_data = test_helpers::MakeSimpleFormData();
id extract_completion_handler_arg =
[OCMArg checkWithBlock:^(void (^completion_handler)(BOOL, FormData)) {
completion_handler(/*found=*/YES, form_data);
return YES;
}];
[[form_helper_ expect]
extractPasswordFormData:form_id
inFrame:frame
completionHandler:extract_completion_handler_arg];
// Simulate the user declining the generated password in the dialog.
id decision_handler_arg =
[OCMArg checkWithBlock:^(void (^decision_handler)(BOOL)) {
decision_handler(/*accept=*/NO);
return YES;
}];
OCMExpect([[delegate_ ignoringNonObjectArgs]
sharedPasswordController:controller_
showGeneratedPotentialPassword:[OCMArg isNotNil]
proactive:NO
frame:frame->AsWeakPtr()
decisionHandler:decision_handler_arg]);
OCMStub([driver_helper_ PasswordManagerDriver:frame]);
EXPECT_CALL(password_generation_helper_, GeneratePassword)
.WillOnce(Return(u"testpass"));
EXPECT_CALL(password_manager_, SetGenerationElementAndTypeForForm);
// Check that the generation is terminated.
EXPECT_CALL(password_manager_, OnPasswordNoLongerGenerated);
// Start the password generation flow by selecting the password generation
// suggestion. The flow will complete itself by declining the generated
// password.
[controller_ didSelectSuggestion:suggestion
atIndex:0
form:@"test-form-name"
formRendererID:form_id
fieldIdentifier:@"test-field-id"
fieldRendererID:field_id
frameID:kTestFrameID
completionHandler:nil];
// Verify that the metric is only recorded iff the generated password is
// accepted.
histogram_tester.ExpectTotalCount(
"PasswordGeneration.iOS.AcceptedGeneratedPasswordIsEmpty", 0);
}
// Tests that upon calling DidFillField() on the agent, the delegate implemented
// and owned by the SharedPasswordController correctly calls the password
// manager to update its state.
TEST_F(SharedPasswordControllerTest, DidFillField) {
GURL url("https://example.com");
auto frame = web::FakeWebFrame::Create("frameID", true, url);
autofill::FormRendererId form_id(1);
autofill::FieldRendererId field_id(2);
const std::u16string value(u"value");
auto* driver = IOSPasswordManagerDriverFactory::FromWebStateAndWebFrame(
&web_state_, frame.get());
auto* field_data_manager =
autofill::FieldDataManagerFactoryIOS::FromWebFrame(frame.get());
EXPECT_CALL(
password_manager_,
UpdateStateOnUserInput(driver, ::testing::Ref(*field_data_manager),
std::make_optional<FormRendererId>(form_id),
field_id, value));
auto* agent = autofill::PasswordAutofillAgent::FromWebState(&web_state_);
agent->DidFillField(frame.get(), form_id, field_id, value);
}
// TODO(crbug.com/40701292): Finish unit testing the rest of the public API.
} // namespace password_manager
|