1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <stdint.h>
#include <string>
#include "base/functional/callback_helpers.h"
#include "base/time/time.h"
#include "base/values.h"
#include "components/prefs/json_pref_store.h"
#include "components/prefs/mock_pref_change_callback.h"
#include "components/prefs/pref_change_registrar.h"
#include "components/prefs/pref_notifier_impl.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/pref_service_factory.h"
#include "components/prefs/pref_value_store.h"
#include "components/prefs/testing_pref_service.h"
#include "components/prefs/testing_pref_store.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using testing::_;
using testing::Mock;
namespace {
const char kPrefName[] = "pref.name";
} // namespace
TEST(PrefServiceTest, NoObserverFire) {
TestingPrefServiceSimple prefs;
const char pref_name[] = "homepage";
prefs.registry()->RegisterStringPref(pref_name, std::string());
const char new_pref_value[] = "http://www.google.com/";
MockPrefChangeCallback obs(&prefs);
PrefChangeRegistrar registrar;
registrar.Init(&prefs);
registrar.Add(pref_name, obs.GetCallback());
// This should fire the checks in MockPrefChangeCallback::OnPreferenceChanged.
const base::Value expected_value(new_pref_value);
obs.Expect(pref_name, &expected_value);
prefs.SetString(pref_name, new_pref_value);
Mock::VerifyAndClearExpectations(&obs);
// Setting the pref to the same value should not set the pref value a second
// time.
EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0);
prefs.SetString(pref_name, new_pref_value);
Mock::VerifyAndClearExpectations(&obs);
// Clearing the pref should cause the pref to fire.
const base::Value expected_default_value((std::string()));
obs.Expect(pref_name, &expected_default_value);
prefs.ClearPref(pref_name);
Mock::VerifyAndClearExpectations(&obs);
// Clearing the pref again should not cause the pref to fire.
EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0);
prefs.ClearPref(pref_name);
Mock::VerifyAndClearExpectations(&obs);
}
TEST(PrefServiceTest, HasPrefPath) {
TestingPrefServiceSimple prefs;
const char path[] = "fake.path";
// Shouldn't initially have a path.
EXPECT_FALSE(prefs.HasPrefPath(path));
// Register the path. This doesn't set a value, so the path still shouldn't
// exist.
prefs.registry()->RegisterStringPref(path, std::string());
EXPECT_FALSE(prefs.HasPrefPath(path));
// Set a value and make sure we have a path.
prefs.SetString(path, "blah");
EXPECT_TRUE(prefs.HasPrefPath(path));
}
TEST(PrefServiceTest, Observers) {
const char pref_name[] = "homepage";
TestingPrefServiceSimple prefs;
prefs.SetUserPref(pref_name, base::Value("http://www.cnn.com"));
prefs.registry()->RegisterStringPref(pref_name, std::string());
const char new_pref_value[] = "http://www.google.com/";
const base::Value expected_new_pref_value(new_pref_value);
MockPrefChangeCallback obs(&prefs);
PrefChangeRegistrar registrar;
registrar.Init(&prefs);
registrar.Add(pref_name, obs.GetCallback());
PrefChangeRegistrar registrar_two;
registrar_two.Init(&prefs);
// This should fire the checks in MockPrefChangeCallback::OnPreferenceChanged.
obs.Expect(pref_name, &expected_new_pref_value);
prefs.SetString(pref_name, new_pref_value);
Mock::VerifyAndClearExpectations(&obs);
// Now try adding a second pref observer.
const char new_pref_value2[] = "http://www.youtube.com/";
const base::Value expected_new_pref_value2(new_pref_value2);
MockPrefChangeCallback obs2(&prefs);
obs.Expect(pref_name, &expected_new_pref_value2);
obs2.Expect(pref_name, &expected_new_pref_value2);
registrar_two.Add(pref_name, obs2.GetCallback());
// This should fire the checks in obs and obs2.
prefs.SetString(pref_name, new_pref_value2);
Mock::VerifyAndClearExpectations(&obs);
Mock::VerifyAndClearExpectations(&obs2);
// Set a recommended value.
const base::Value recommended_pref_value("http://www.gmail.com/");
obs.Expect(pref_name, &expected_new_pref_value2);
obs2.Expect(pref_name, &expected_new_pref_value2);
// This should fire the checks in obs and obs2 but with an unchanged value
// as the recommended value is being overridden by the user-set value.
prefs.SetRecommendedPref(pref_name, recommended_pref_value.Clone());
Mock::VerifyAndClearExpectations(&obs);
Mock::VerifyAndClearExpectations(&obs2);
// Make sure obs2 still works after removing obs.
registrar.Remove(pref_name);
EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0);
obs2.Expect(pref_name, &expected_new_pref_value);
// This should only fire the observer in obs2.
prefs.SetString(pref_name, new_pref_value);
Mock::VerifyAndClearExpectations(&obs);
Mock::VerifyAndClearExpectations(&obs2);
}
// Make sure that if a preference changes type, so the wrong type is stored in
// the user pref file, it uses the correct fallback value instead.
TEST(PrefServiceTest, GetValueChangedType) {
const int kTestValue = 10;
TestingPrefServiceSimple prefs;
prefs.registry()->RegisterIntegerPref(kPrefName, kTestValue);
// Check falling back to a recommended value.
prefs.SetUserPref(kPrefName, base::Value("not an integer"));
const PrefService::Preference* pref = prefs.FindPreference(kPrefName);
ASSERT_TRUE(pref);
const base::Value* value = pref->GetValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kTestValue, value->GetInt());
}
TEST(PrefServiceTest, GetValueAndGetRecommendedValue) {
const int kDefaultValue = 5;
const int kUserValue = 10;
const int kRecommendedValue = 15;
TestingPrefServiceSimple prefs;
prefs.registry()->RegisterIntegerPref(kPrefName, kDefaultValue);
// Create pref with a default value only.
const PrefService::Preference* pref = prefs.FindPreference(kPrefName);
ASSERT_TRUE(pref);
// Check that GetValue() returns the default value.
const base::Value* value = pref->GetValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kDefaultValue, value->GetInt());
// Check that GetRecommendedValue() returns no value.
value = pref->GetRecommendedValue();
ASSERT_FALSE(value);
// Set a user-set value.
prefs.SetUserPref(kPrefName, base::Value(kUserValue));
// Check that GetValue() returns the user-set value.
value = pref->GetValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kUserValue, value->GetInt());
// Check that GetRecommendedValue() returns no value.
value = pref->GetRecommendedValue();
ASSERT_FALSE(value);
// Set a recommended value.
prefs.SetRecommendedPref(kPrefName, base::Value(kRecommendedValue));
// Check that GetValue() returns the user-set value.
value = pref->GetValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kUserValue, value->GetInt());
// Check that GetRecommendedValue() returns the recommended value.
value = pref->GetRecommendedValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kRecommendedValue, value->GetInt());
// Remove the user-set value.
prefs.RemoveUserPref(kPrefName);
// Check that GetValue() returns the recommended value.
value = pref->GetValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kRecommendedValue, value->GetInt());
// Check that GetRecommendedValue() returns the recommended value.
value = pref->GetRecommendedValue();
ASSERT_TRUE(value);
EXPECT_EQ(base::Value::Type::INTEGER, value->type());
ASSERT_TRUE(value->is_int());
EXPECT_EQ(kRecommendedValue, value->GetInt());
}
TEST(PrefServiceTest, SetTimeValue_RegularTime) {
TestingPrefServiceSimple prefs;
// Register a null time as the default.
prefs.registry()->RegisterTimePref(kPrefName, base::Time());
EXPECT_TRUE(prefs.GetTime(kPrefName).is_null());
// Set a time and make sure that we can read it without any loss of precision.
const base::Time time = base::Time::Now();
prefs.SetTime(kPrefName, time);
EXPECT_EQ(time, prefs.GetTime(kPrefName));
}
TEST(PrefServiceTest, SetTimeValue_NullTime) {
TestingPrefServiceSimple prefs;
// Register a non-null time as the default.
const base::Time default_time =
base::Time::FromDeltaSinceWindowsEpoch(base::Microseconds(12345));
prefs.registry()->RegisterTimePref(kPrefName, default_time);
EXPECT_FALSE(prefs.GetTime(kPrefName).is_null());
// Set a null time and make sure that it remains null upon deserialization.
prefs.SetTime(kPrefName, base::Time());
EXPECT_TRUE(prefs.GetTime(kPrefName).is_null());
}
TEST(PrefServiceTest, SetTimeDeltaValue_RegularTimeDelta) {
TestingPrefServiceSimple prefs;
// Register a zero time delta as the default.
prefs.registry()->RegisterTimeDeltaPref(kPrefName, base::TimeDelta());
EXPECT_TRUE(prefs.GetTimeDelta(kPrefName).is_zero());
// Set a time delta and make sure that we can read it without any loss of
// precision.
const base::TimeDelta delta = base::Time::Now() - base::Time();
prefs.SetTimeDelta(kPrefName, delta);
EXPECT_EQ(delta, prefs.GetTimeDelta(kPrefName));
}
TEST(PrefServiceTest, SetTimeDeltaValue_ZeroTimeDelta) {
TestingPrefServiceSimple prefs;
// Register a non-zero time delta as the default.
const base::TimeDelta default_delta = base::Microseconds(12345);
prefs.registry()->RegisterTimeDeltaPref(kPrefName, default_delta);
EXPECT_FALSE(prefs.GetTimeDelta(kPrefName).is_zero());
// Set a zero time delta and make sure that it remains zero upon
// deserialization.
prefs.SetTimeDelta(kPrefName, base::TimeDelta());
EXPECT_TRUE(prefs.GetTimeDelta(kPrefName).is_zero());
}
// A PrefStore which just stores the last write flags that were used to write
// values to it.
class WriteFlagChecker : public TestingPrefStore {
public:
WriteFlagChecker() = default;
void ReportValueChanged(std::string_view key, uint32_t flags) override {
SetLastWriteFlags(flags);
}
void SetValue(std::string_view key,
base::Value value,
uint32_t flags) override {
SetLastWriteFlags(flags);
}
void SetValueSilently(std::string_view key,
base::Value value,
uint32_t flags) override {
SetLastWriteFlags(flags);
}
void RemoveValue(std::string_view key, uint32_t flags) override {
SetLastWriteFlags(flags);
}
uint32_t GetLastFlagsAndClear() {
CHECK(last_write_flags_set_);
uint32_t result = last_write_flags_;
last_write_flags_set_ = false;
last_write_flags_ = WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS;
return result;
}
bool last_write_flags_set() { return last_write_flags_set_; }
private:
~WriteFlagChecker() override = default;
void SetLastWriteFlags(uint32_t flags) {
CHECK(!last_write_flags_set_);
last_write_flags_set_ = true;
last_write_flags_ = flags;
}
bool last_write_flags_set_ = false;
uint32_t last_write_flags_ = WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS;
};
TEST(PrefServiceTest, WriteablePrefStoreFlags) {
scoped_refptr<WriteFlagChecker> flag_checker(new WriteFlagChecker);
scoped_refptr<PrefRegistrySimple> registry(new PrefRegistrySimple);
PrefServiceFactory factory;
factory.set_user_prefs(flag_checker);
std::unique_ptr<PrefService> prefs(factory.Create(registry.get()));
// The first 8 bits of write flags are reserved for subclasses. Create a
// custom flag in this range
uint32_t kCustomRegistrationFlag = 1 << 2;
// A map of the registration flags that will be tested and the write flags
// they are expected to convert to.
struct RegistrationToWriteFlags {
const char* pref_name;
uint32_t registration_flags;
uint32_t write_flags;
};
const RegistrationToWriteFlags kRegistrationToWriteFlags[] = {
{"none",
PrefRegistry::NO_REGISTRATION_FLAGS,
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS},
{"lossy",
PrefRegistry::LOSSY_PREF,
WriteablePrefStore::LOSSY_PREF_WRITE_FLAG},
{"custom",
kCustomRegistrationFlag,
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS},
{"lossyandcustom",
PrefRegistry::LOSSY_PREF | kCustomRegistrationFlag,
WriteablePrefStore::LOSSY_PREF_WRITE_FLAG}};
for (const RegistrationToWriteFlags& entry : kRegistrationToWriteFlags) {
registry->RegisterDictionaryPref(entry.pref_name,
entry.registration_flags);
SCOPED_TRACE("Currently testing pref with name: " +
std::string(entry.pref_name));
prefs->GetMutableUserPref(entry.pref_name, base::Value::Type::DICT);
EXPECT_TRUE(flag_checker->last_write_flags_set());
EXPECT_EQ(entry.write_flags, flag_checker->GetLastFlagsAndClear());
prefs->ReportUserPrefChanged(entry.pref_name);
EXPECT_TRUE(flag_checker->last_write_flags_set());
EXPECT_EQ(entry.write_flags, flag_checker->GetLastFlagsAndClear());
prefs->ClearPref(entry.pref_name);
EXPECT_TRUE(flag_checker->last_write_flags_set());
EXPECT_EQ(entry.write_flags, flag_checker->GetLastFlagsAndClear());
prefs->SetUserPrefValue(entry.pref_name,
base::Value(base::Value::Type::DICT));
EXPECT_TRUE(flag_checker->last_write_flags_set());
EXPECT_EQ(entry.write_flags, flag_checker->GetLastFlagsAndClear());
}
}
class PrefServiceSetValueTest : public testing::Test {
protected:
static const char kName[];
static const char kValue[];
PrefServiceSetValueTest() : observer_(&prefs_) {}
TestingPrefServiceSimple prefs_;
MockPrefChangeCallback observer_;
};
const char PrefServiceSetValueTest::kName[] = "name";
const char PrefServiceSetValueTest::kValue[] = "value";
TEST_F(PrefServiceSetValueTest, SetStringValue) {
const char default_string[] = "default";
const base::Value default_value(default_string);
prefs_.registry()->RegisterStringPref(kName, default_string);
PrefChangeRegistrar registrar;
registrar.Init(&prefs_);
registrar.Add(kName, observer_.GetCallback());
// Changing the controlling store from default to user triggers notification.
observer_.Expect(kName, &default_value);
prefs_.Set(kName, default_value);
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
prefs_.Set(kName, default_value);
Mock::VerifyAndClearExpectations(&observer_);
base::Value new_value(kValue);
observer_.Expect(kName, &new_value);
prefs_.Set(kName, new_value);
Mock::VerifyAndClearExpectations(&observer_);
}
TEST_F(PrefServiceSetValueTest, SetDictionaryValue) {
prefs_.registry()->RegisterDictionaryPref(kName);
PrefChangeRegistrar registrar;
registrar.Init(&prefs_);
registrar.Add(kName, observer_.GetCallback());
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
prefs_.RemoveUserPref(kName);
Mock::VerifyAndClearExpectations(&observer_);
base::Value::Dict new_value_dict;
new_value_dict.Set(kName, kValue);
base::Value new_value(std::move(new_value_dict));
observer_.Expect(kName, &new_value);
prefs_.Set(kName, new_value);
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
prefs_.Set(kName, new_value);
Mock::VerifyAndClearExpectations(&observer_);
base::Value empty((base::Value::Dict()));
observer_.Expect(kName, &empty);
prefs_.Set(kName, empty);
Mock::VerifyAndClearExpectations(&observer_);
}
TEST_F(PrefServiceSetValueTest, SetListValue) {
prefs_.registry()->RegisterListPref(kName);
PrefChangeRegistrar registrar;
registrar.Init(&prefs_);
registrar.Add(kName, observer_.GetCallback());
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
prefs_.RemoveUserPref(kName);
Mock::VerifyAndClearExpectations(&observer_);
base::Value::List new_value_list;
new_value_list.Append(kValue);
base::Value new_value(std::move(new_value_list));
observer_.Expect(kName, &new_value);
prefs_.Set(kName, new_value);
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
prefs_.Set(kName, new_value);
Mock::VerifyAndClearExpectations(&observer_);
base::Value empty((base::Value::List()));
observer_.Expect(kName, &empty);
prefs_.Set(kName, empty);
Mock::VerifyAndClearExpectations(&observer_);
}
|